On Tue, Jan 05, 2016 at 05:18:40PM +0200, Ville Syrjälä wrote:
> On Tue, Jan 05, 2016 at 03:50:38PM +0100, Daniel Vetter wrote:
> > On Mon, Jan 04, 2016 at 07:06:15PM +0200, Ville Syrjälä wrote:
> > > On Mon, Jan 04, 2016 at 11:16:39AM +0100, Maarten Lankhorst wrote:
> > > > Hey,
> > > >
> > > > O
On Tue, Dec 22, 2015 at 11:50:53AM +0530, ankitprasad.r.sha...@intel.com wrote:
> From: Ankitprasad Sharma
>
> The BIOS RapidStartTechnology may corrupt the stolen memory across S3
> suspend due to unalarmed hibernation, in which case we will not be able
> to preserve the User data stored in the
On Tue, Dec 22, 2015 at 04:41:17PM +, Tvrtko Ursulin wrote:
>
> On 22/12/15 06:20, ankitprasad.r.sha...@intel.com wrote:
> >From: Ankitprasad Sharma
> >
> >Some modules, like i915.ko, needs to detect when certain ACPI features
> >are active inorder to prevent corruption on contended resources
== Summary ==
Built on bc303261a81a96298b2f9e02734aeaa0a25421a6 drm-intel-nightly:
2016y-01m-05d-16h-47m-54s UTC integration manifest
Test gem_ctx_param_basic:
Subgroup basic:
pass -> DMESG-WARN (skl-i7k-2)
Subgroup invalid-param-set:
pass
On Tue, Dec 22, 2015 at 05:14:34PM +, Tvrtko Ursulin wrote:
>
> On 22/12/15 17:02, Chris Wilson wrote:
> >On Tue, Dec 22, 2015 at 12:33:41PM +, Tvrtko Ursulin wrote:
> >>On 22/12/15 06:20, ankitprasad.r.sha...@intel.com wrote:
> >>>From: Chris Wilson
> >>>+ /* Recreate any pinned binding
On Tue, Dec 22, 2015 at 12:02:17PM +, Tvrtko Ursulin wrote:
>
> On 22/12/15 11:29, Ankitprasad Sharma wrote:
> >On Tue, 2015-12-22 at 11:20 +, Tvrtko Ursulin wrote:
> >>On 22/12/15 06:20, ankitprasad.r.sha...@intel.com wrote:
> >>>diff --git a/drivers/gpu/drm/i915/intel_pm.c
> >>>b/driver
On Tue, Jan 05, 2016 at 10:33:02AM -0800, yu@intel.com wrote:
> From: Dave Gordon
>
> The GuC code needs to know the size of a logical context, so we
> expose get_lr_context_size(), renaming it intel_lr_context__size()
> to fit the naming conventions for nonstatic functions.
>
> Add comments
On Tue, Jan 05, 2016 at 04:15:30PM -0500, Lyude wrote:
> This fixes reprobing of display connectors on resume. After some talking
> with danvet on IRC, I learned that calling drm_helper_hpd_irq_event() does
> actually trigger a full reprobe of each connector's status. It turns out
> this is the act
On Tue, Jan 05, 2016 at 04:03:38PM +0100, Andrea Gelmini wrote:
> Hi everybody,
>on my laptop I'm using 4.4.0-rc8 + drm-intel-nightly from
> git://anongit.freedesktop.org/drm-intel
>(commit 0417da5e6f56078d87d366d5f959f8290ae9d16d).
>
>Found this after few hours (dunno if it's a false
== Summary ==
Built on bc303261a81a96298b2f9e02734aeaa0a25421a6 drm-intel-nightly:
2016y-01m-05d-16h-47m-54s UTC integration manifest
Test gem_storedw_loop:
Subgroup basic-render:
pass -> DMESG-WARN (skl-i5k-2) UNSTABLE
pass -> DMESG-WARN (bdw-
Hi Matt,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20160105]
[cannot apply to v4.4-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Matt-Roper
From: Libin Yang
hsw platforms supports DP MST while ilk doesn't.
This patch fixes the bug.
Signed-off-by: Libin Yang
---
drivers/gpu/drm/i915/intel_audio.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c
b/drivers/gpu/drm/i91
From: Libin Yang
For DP MST, use enc_to_mst(encoder)->primary to get intel_digital_port,
instead of using enc_to_dig_port(encoder).
Signed-off-by: Libin Yang
---
drivers/gpu/drm/i915/intel_audio.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/driver
Hi Ville,
> -Original Message-
> From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
> Sent: Tuesday, January 05, 2016 12:03 AM
> To: libin.y...@linux.intel.com
> Cc: intel-gfx@lists.freedesktop.org; conselv...@gmail.com;
> ti...@suse.de; jani.nik...@linux.intel.com; Vetter, Daniel;
Hi Matt,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20160105]
[cannot apply to v4.4-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Matt-Roper
Our attempts save/restore panel power state in i915_suspend.c are
causing unclaimed register warnings on BXT since the registers for this
platform differ from older platforms.
The big hammer suspend/resume shouldn't actually be necessary for PP
since the connector/encoder hooks should already hand
On Tue, Dec 15, 2015 at 10:26 AM, Chris Wilson wrote:
> On Mon, Dec 14, 2015 at 04:54:02PM +0200, Ville Syrjälä wrote:
>> On Sun, Dec 13, 2015 at 12:49:45PM +, Chris Wilson wrote:
>> > i7-5557U nuc currently connected to HDMI.
>>
>> Sigh. Do those correcpond to AUX attempts by any chance? IIRC
Our attempts save/restore panel power state in i915_suspend.c are
causing unclaimed register warnings on BXT since the registers for this
platform differ from older platforms.
The big hammer suspend/resume shouldn't actually be necessary for PP
since the connector/encoder hooks should already hand
Hi Matt,
On Tue, Jan 05, 2016 at 01:58:19PM -0800, Matt Roper wrote:
> Hi Jan. I think the flicker you're seeing is caused by our current lack
> of two-stage watermark updates on platforms that use ILK-style
> watermarks. I have a patch series at
> http://patchwork.freedesktop.org/bundle/mattrop
On Tue, Jan 05, 2016 at 01:49:33PM +0100, Jan Niehusmann wrote:
> Hi,
>
> On Thu, Sep 24, 2015 at 03:53:07PM -0700, Matt Roper wrote:
> > Just pull the info out of the plane state structure rather than staging
> > it in an additional structure.
> >
> > v2: Add 'visible' condition to sprites_scale
This fixes reprobing of display connectors on resume. After some talking
with danvet on IRC, I learned that calling drm_helper_hpd_irq_event() does
actually trigger a full reprobe of each connector's status. It turns out
this is the actual reason reprobing on resume hasn't been working (this was
ob
On 12/21/2015 5:18 PM, Kumar, Abhay wrote:
From: Abhay Kumar
Make resume/on codepath not to wait for panel_power_cycle_delay(t11_t12)
if this time is already spent in suspend/poweron time.
v2: Use CLOCK_BOOTTIME and remove jiffies for panel power cycle
delay calculation(Ville).
Cc: Vill
On Tue, Jan 05, 2016 at 05:17:07PM +0100, Lukasz Fiedorowicz wrote:
> +static void open_guc_status(void)
> +{
> + guc_status_fd = igt_debugfs_open("i915_guc_load_status", O_RDONLY);
> + igt_assert_f(guc_status_fd >= 0, "Can't open i915_guc_load_status\n");
igt_require(). So that the test d
On 4 January 2016 at 05:50, Kumar, Shobhit
wrote:
>
> Yeah, this got sidelined by other stuff. Should be doable. Let me get back
> onto this. Will surely need testing support as don't have this device with
> me.
I would, obviously, be delighted to assist in testing any patches.
CB
_
On Tue, Jan 05, 2016 at 04:51:39PM +, Szwichtenberg, Radoslaw wrote:
> Hello Chris,
>
> Happy New Year!
> Thanks for answers so far. I have some additional questions.
>
> You wrote that this change was made to take a defensive position to ensure
> minimum power consumption - did we do any po
On 1/5/2016 3:04 AM, Daniel Vetter wrote:
On Tue, Jan 05, 2016 at 01:30:53AM +, Kumar, Abhay wrote:
Ville,
Is this patch is coming close to what you wanted?
Please don't bottom-post but not quote properly - no one will ever find
your comment and assume you accidentally sent out the p
On Tue, Jan 05, 2016 at 09:05:49PM +0100, Daniel Vetter wrote:
> On Tue, Jan 05, 2016 at 02:53:08PM -0500, Lyude wrote:
> > There's no reason to check for an active encoder when setting up hpd,
> > especially since a disconnected connector isn't going to have an encoder
> > in the first place. This
On Tue, Jan 05, 2016 at 02:53:08PM -0500, Lyude wrote:
> There's no reason to check for an active encoder when setting up hpd,
> especially since a disconnected connector isn't going to have an encoder
> in the first place. This fixes reprobing display connectors on resume.
>
> Signed-off-by: Lyud
There's no reason to check for an active encoder when setting up hpd,
especially since a disconnected connector isn't going to have an encoder
in the first place. This fixes reprobing display connectors on resume.
Signed-off-by: Lyude
---
After some talking with danvet on IRC, I learned that call
On Mon, Dec 21, 2015 at 03:11:00PM +0200, Jani Nikula wrote:
> Add parsing of the i2c element, defined in MIPI sequence block v2. Drop
> the status operation byte while at it, that does not exist.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_bios.c | 5 +
> drivers/gpu/d
No functional changes.
That state the obvious and just duplicate the place we
need to change whenever the table is updated. So let's clean it.
Cc: Ville Syrjälä
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_ddi.c | 22 +++---
1 file changed, 11 insertions(+), 11 de
From: Alex Dai
This is to enable command submission via GuC.
Signed-off-by: Dave Gordon
Signed-off-by: Alex Dai
---
drivers/gpu/drm/i915/i915_params.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_params.c
b/drivers/gpu/drm/i915/i915_params
When debuging an intermittent corrupted screen I suspected on DDI
translation table and checked we are out of date with the spec.
I'm not sure this will fix my bug yet, but it is always good to follow
the spec.
v2: Ville caught a switched i-boost value. Thanks!
Cc: Ville Syrjälä
Signed-off-by:
On Tue, 2016-01-05 at 20:39 +0200, Ville Syrjälä wrote:
> On Tue, Jan 05, 2016 at 07:32:59AM -0800, Rodrigo Vivi wrote:
> > When debuging an intermittent corrupted screen I suspected on DDI
> > translation table and checked we are out of date with the spec.
> >
> > I'm not sure this will fix my bu
On Tue, Jan 05, 2016 at 07:58:31AM -0800, Rodrigo Vivi wrote:
> When reviewing DDI translation table I noticed few changes we
> haven't incorporated yet and it is always good to follow latest
> spec.
>
> Signed-off-by: Rodrigo Vivi
Reviewed-by: Ville Syrjälä
>---
> drivers/gpu/drm/i915/intel_
On Tue, Jan 05, 2016 at 07:32:59AM -0800, Rodrigo Vivi wrote:
> When debuging an intermittent corrupted screen I suspected on DDI
> translation table and checked we are out of date with the spec.
>
> I'm not sure this will fix my bug yet, but it is always good to follow
> the spec.
>
> Signed-off
On 01/05/2016 02:27 AM, Daniel Vetter wrote:
On Fri, Dec 18, 2015 at 12:00:08PM -0800, yu@intel.com wrote:
> From: Dave Gordon
>
> The GuC code needs to know the size of a logical context, so we
> expose get_lr_context_size(), renaming it intel_lr_context__size()
> to fit the naming conven
From: Dave Gordon
The GuC code needs to know the size of a logical context, so we
expose get_lr_context_size(), renaming it intel_lr_context__size()
to fit the naming conventions for nonstatic functions.
Add comments or kerneldoc (Daniel Vetter)
For: VIZ-2021
Signed-off-by: Dave Gordon
Signed-
-Original Message-
From: Thierry, Michel
Sent: Tuesday, January 5, 2016 10:02 AM
To: Belgaumkar, Vinay
Subject: RE: [Intel-gfx] [PATCH i-g-t] tests/gem_softpin: Use offset addresses
in canonical form
> -Original Message-
> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freed
I think this patch is a worthwhile cleanup even if it might look only marginally
useful. It gets more useful in upcoming patches and for handling of future GEN
platforms.
The only non-mechanical part of this is the removal of the extra & operation on
the ring->next_context_status_buffer. This is s
This is a useful thing to have around as a function because the mechanism may
change in the future.
There is a net increase in LOC here, and it will continue to be the case on GEN8
and GEN9 - but future GENs may have an alternate mechanism for doing this.
Signed-off-by: Ben Widawsky
---
drivers
Sample output:
...
waiting: yes
ring->head: 0x
ring->tail: 0x0c50
ring->next_context_status_buffer: 0x5
CSB Pointer: 0x0405
Context 0 Status: 0x0001
Context 1 Status: 0x009d0018
Context 2 Status: 0x0001
Context 3 Status: 0x00
Since we extracted it for use in error state, we may as well use it in debugfs
too.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
There is no point in emitting a WARN since the backtrace will always be the
same. Errors have actually become easier to spot given the large number of WARNs
which exist today in modesetting paths.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_lrc.c | 4 +++-
1 file changed, 3 insert
While doing some debug in simulation, I came across a handful of patches which I
think are beneficial today. Mostly this just has some minor cleanups and error
state additions. They're pretty optional, though I have a private branch that
depends on some of this stuff, so it'd be nice to land as muc
On 01/04/16 19:29, Masanari Iida wrote:
> This patch fix some spelling typos found in Documentation/Docbook
> gpu/ch04s03.html. This file was generated from comments within
> source, so I have to fix typos in i915_gem_fence.c.
>
> Signed-off-by: Masanari Iida
> ---
> drivers/gpu/drm/i915/i915_g
== Summary ==
Built on bc303261a81a96298b2f9e02734aeaa0a25421a6 drm-intel-nightly:
2016y-01m-05d-16h-47m-54s UTC integration manifest
Test kms_flip:
Subgroup basic-flip-vs-modeset:
dmesg-warn -> PASS (bdw-nuci7) UNSTABLE
Subgroup basic-flip-vs-wf_vblank:
They're causing massive amounts of dmesg noise and hence CI noise all
over the place. Enabling them for a bit was good enough to refresh our
task list of what's still needed to enable rpm by default.
To make sure we're not forgetting to make this noisy again add a FIXME
comment.
Fixes: da5827c366
Hello Chris,
Happy New Year!
Thanks for answers so far. I have some additional questions.
You wrote that this change was made to take a defensive position to ensure
minimum power consumption - did we do any power measurements to confirm the
benefit? How does this change affect user experience a
On Tue, Dec 22, 2015 at 10:39:38AM +, Chris Wilson wrote:
> On Tue, Dec 22, 2015 at 10:23:11AM +, Tvrtko Ursulin wrote:
> >
> >
> > On 22/12/15 06:20, ankitprasad.r.sha...@intel.com wrote:
> > >From: Ankitprasad Sharma
> > >
> > >i915_gem_object_get_dma_address function is used to retrie
Test check GuC debugfs file for successful loading confirmation
Signed-off-by: Lukasz Fiedorowicz
---
tests/Makefile.sources | 1 +
tests/gem_guc_loading.c | 89 +
2 files changed, 90 insertions(+)
create mode 100644 tests/gem_guc_loading.c
dif
== Summary ==
HEAD is now at 865e245 drm-intel-nightly: 2016y-01m-05d-15h-23m-53s UTC
integration manifest
Applying: drm/i915/bios: add proper documentation for the Video BIOS Table (VBT)
Using index info to reconstruct a base tree...
M Documentation/DocBook/gpu.tmpl
M drivers/gpu/drm
When reviewing DDI translation table I noticed few changes we
haven't incorporated yet and it is always good to follow latest
spec.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_
When debuging an intermittent corrupted screen I suspected on DDI
translation table and checked we are out of date with the spec.
I'm not sure this will fix my bug yet, but it is always good to follow
the spec.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_ddi.c | 20 ++
On Tue, Jan 05, 2016 at 04:22:15PM +0100, Daniel Vetter wrote:
> Another pile of vfuncs from the old gpu.tmpl xml documentation that
> I've forgotten to delete. I spotted a few more things to
> clarify/extend in the new kerneldoc while going through this once
> more.
>
> v2: Spelling fixes (Thierr
Another pile of vfuncs from the old gpu.tmpl xml documentation that
I've forgotten to delete. I spotted a few more things to
clarify/extend in the new kerneldoc while going through this once
more.
v2: Spelling fixes (Thierry).
v3: More spelling fixes and use Thierry's proposal to clarify why
driv
On Tue, Jan 05, 2016 at 03:50:38PM +0100, Daniel Vetter wrote:
> On Mon, Jan 04, 2016 at 07:06:15PM +0200, Ville Syrjälä wrote:
> > On Mon, Jan 04, 2016 at 11:16:39AM +0100, Maarten Lankhorst wrote:
> > > Hey,
> > >
> > > Op 23-12-15 om 12:05 schreef Nabendu Maiti:
> > > > This patch is adding pip
On Mon, Jan 04, 2016 at 07:49:41AM +0100, Daniel Vetter wrote:
> On Mon, Dec 28, 2015 at 11:22:52AM +0100, Thierry Reding wrote:
> > On Wed, Dec 16, 2015 at 06:18:25PM +0100, Daniel Vetter wrote:
> > > Another pile of vfuncs from the old gpu.tmpl xml documentation that
> > > I've forgotten to delet
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index 70fc11e0869d..a5817bef2d71 100644
--- a/drivers/gpu/drm/i915/intel_dsi
On Wed, Dec 23, 2015 at 03:34:48PM +, Derek Morton wrote:
> line[strlen(line)] will always evaluate to NULL so line_continuation
> was always true. That prevented the program name, pid and log level
> ever being printed.
> Changed to [strlen(line) - 1] so the last character before the null
> te
On Tue, Jan 05, 2016 at 04:02:13PM +0100, Peter Zijlstra wrote:
> > Shouldn't the slab subsystem do this for us if we request it delays the
> > actual kfree? Seems like a core bug to me ... Adding more folks.
>
> note that sync_rcu() can take a terribly long time.. but yes, I seem to
> remember Pa
The sequence block has sizes of elements after the operation byte since
sequence block v3. Use it to skip elements we don't support yet.
v2: remove redundant exec_elem[operation_byte] check (Daniel)
Reviewed-by: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dsi_panel_
The changes since the sequence block v2 are:
* The whole MIPI bios data block has a separate 32-bit size field since
v3, stored after the version. This facilitates big sequences.
* The size of the panel specific sequence blocks has grown to 32
bits. This facilitates big sequences.
* The elem
On Tue, Jan 05, 2016 at 03:59:51PM +0100, Daniel Vetter wrote:
> On Wed, Dec 23, 2015 at 01:35:54PM +, Chris Wilson wrote:
> > If we enable RCU for the requests (providing a grace period where we can
> > inspect a "dead" request before it is freed), we can allow callers to
> > carefully perform
On Wed, Dec 23, 2015 at 01:35:54PM +, Chris Wilson wrote:
> If we enable RCU for the requests (providing a grace period where we can
> inspect a "dead" request before it is freed), we can allow callers to
> carefully perform lockless lookup of an active request.
>
> However, by enabling deferr
On Tue, 05 Jan 2016, Daniel Vetter wrote:
> On Mon, Dec 21, 2015 at 03:11:05PM +0200, Jani Nikula wrote:
>> The sequence block has sizes of elements after the operation byte since
>> sequence block v3. Use it to skip elements we don't support yet.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> driv
On Tue, 05 Jan 2016, Daniel Vetter wrote:
> On Mon, Dec 21, 2015 at 03:10:59PM +0200, Jani Nikula wrote:
>> Untie the VBT based generic panel driver from the VBT parsing, so that
>> the two don't have to be updated in lockstep.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/int
On Mon, Jan 04, 2016 at 07:06:15PM +0200, Ville Syrjälä wrote:
> On Mon, Jan 04, 2016 at 11:16:39AM +0100, Maarten Lankhorst wrote:
> > Hey,
> >
> > Op 23-12-15 om 12:05 schreef Nabendu Maiti:
> > > This patch is adding pipesource size as property as intel property.User
> > > application is allowe
On Mon, Jan 04, 2016 at 07:53:36AM +0100, Daniel Vetter wrote:
> Another pile of vfuncs from the old gpu.tmpl xml documentation that
> I've forgotten to delete. I spotted a few more things to
> clarify/extend in the new kerneldoc while going through this once
> more.
>
> v2: Spelling fixes (Thierr
On Wed, Dec 23, 2015 at 10:52:36AM +0530, Nabendu Maiti wrote:
> Recalculate watermark when there is a change in pixel format.
>
> Signed-off-by: Nabendu Maiti
This seems like something that's been broken recently in the watermark
shuffling. Please dig out the patch which broke this (using git b
On Tue, Dec 22, 2015 at 04:37:26PM +0100, Sebastian Andrzej Siewior wrote:
> * Christoph Mathys | 2015-12-21 14:19:10 [+0100]:
>
> >While playing with 4.1.13-rt15 I stumbled across the following thread
> >where Luis reports the same problem with i915 gpu:
> >i915: sleeping function called from inv
On Wed, Dec 23, 2015 at 01:40:06PM +0100, Christoph Mathys wrote:
> On Tue, Dec 22, 2015 at 4:37 PM, Sebastian Andrzej Siewior
> wrote:
> > I have to admit, the i915 tries very hard to avoid running on -RT. Could
> > you try the s/local_irq_disable();/local_irq_disable_nort();/ patch
> > mentioned
== Summary ==
Built on 05ade905f2fda5416476677509e016ef830d181a drm-intel-nightly:
2016y-01m-05d-13h-00m-24s UTC integration manifest
Test gem_storedw_loop:
Subgroup basic-render:
dmesg-warn -> PASS (bdw-nuci7)
Test kms_flip:
Subgroup basic-flip-vs-modeset:
On Mon, Dec 21, 2015 at 03:11:06PM +0200, Jani Nikula wrote:
> Make it a bit tidier.
Also more save.
> Signed-off-by: Jani Nikula
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 62
> +++---
> 1 file changed, 22 insertions(+), 40 delet
On Mon, Dec 21, 2015 at 03:11:05PM +0200, Jani Nikula wrote:
> The sequence block has sizes of elements after the operation byte since
> sequence block v3. Use it to skip elements we don't support yet.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 43
>
On Mon, Dec 21, 2015 at 03:10:59PM +0200, Jani Nikula wrote:
> Untie the VBT based generic panel driver from the VBT parsing, so that
> the two don't have to be updated in lockstep.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 22 +-
> 1
On Mon, Dec 21, 2015 at 03:10:58PM +0200, Jani Nikula wrote:
> Untie the VBT based generic panel driver from the VBT parsing, so that
> the two don't have to be updated in lockstep.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c |
On Mon, Dec 21, 2015 at 03:10:57PM +0200, Jani Nikula wrote:
> Make everything a bit more readable and clear.
>
> Signed-off-by: Jani Nikula
A real pain to check, but I think I convinced myself that this is
equivalent code.
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/i915_drv.h
On Tue, Jan 05, 2016 at 02:54:31PM +0100, Daniel Vetter wrote:
> On Mon, Jan 4, 2016 at 4:05 PM, Ville Syrjälä
> wrote:
> > I think what we really need here is some kind of
> > intel_display_power_get_unless_zero() thing. We need to make sure not
> > only that the rpm reference is held when readin
On Tue, Jan 05, 2016 at 02:45:00PM +0200, Jani Nikula wrote:
> On Tue, 05 Jan 2016, Daniel Vetter wrote:
> > On Mon, Dec 21, 2015 at 03:10:56PM +0200, Jani Nikula wrote:
> >> Make the whole thing easier to read.
> >>
> >> Signed-off-by: Jani Nikula
> >> ---
> >> drivers/gpu/drm/i915/intel_bios.
On Tue, Jan 05, 2016 at 12:21:33PM +, Dave Gordon wrote:
> This function was recently renamed & exposed, so now it gets documented
>
> Signed-off-by: Dave Gordon
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 14 ++
> 1 file changed,
On Mon, Jan 4, 2016 at 4:05 PM, Ville Syrjälä
wrote:
> I think what we really need here is some kind of
> intel_display_power_get_unless_zero() thing. We need to make sure not
> only that the rpm reference is held when reading out the state, but also
> that the relevant power well(s) remain enable
Make the whole thing easier to read. While at it, make the parsing more
robust, and ensure we don't read past buffer being parsed.
v2: improve commit message (Daniel)
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_bios.c | 76 +--
1 file changed, 4
Check if *NO_AUX_TRANSACTIONS_LINK_TRAINING* bit is set on
DPCD registers. If this bit is set, we can reuse the known
good drive current and pre-emphasis level from the last
"full" link training.
v2: Commit message update (Thierry)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91393
Sign
== Summary ==
Built on 05ade905f2fda5416476677509e016ef830d181a drm-intel-nightly:
2016y-01m-05d-13h-00m-24s UTC integration manifest
Test gem_storedw_loop:
Subgroup basic-render:
dmesg-warn -> PASS (bdw-nuci7)
dmesg-warn -> PASS (skl-i7k-2)
Te
Don't use DP link training optimization if channel EQ is not ok. It has
been reported that in case of failure in channel EQ check the link training
optimization can be enabled and therefore may not be able to reuse the
previously computed drive current and pre-emphasis levels.
v2: Added MST case (
These three patches are fixes for DP link trainging failures and flickering
issues
reported by https://bugs.freedesktop.org/show_bug.cgi?id=91393
Mika Kahola (3):
drm/i915: Disable fast link training if DP config changes
drm/i915: Check DP no aux transaction bit on link training
drm/i915: D
Disable DP link training optimization if DP link configuration
changes. If one of the DP link parameters i.e. link rate or
lane count changes the link training does no longer apply the
previously computed drive current and pre-emphasis level.
Instead, the link training is started with zero values.
Hi,
On Thu, Sep 24, 2015 at 03:53:07PM -0700, Matt Roper wrote:
> Just pull the info out of the plane state structure rather than staging
> it in an additional structure.
>
> v2: Add 'visible' condition to sprites_scaled so that we don't limit the
> WM level when the sprite isn't enabled. (V
On 05/01/16 10:06, Chris Wilson wrote:
On Mon, Jan 04, 2016 at 01:38:26PM -0800, Jesse Barnes wrote:
On 01/04/2016 11:39 AM, Chris Wilson wrote:
This series is NAKed.
Why? Because you want things in a different order? Or do you object to
something in Dave's reply?
The series was intended
On Tue, 05 Jan 2016, Daniel Vetter wrote:
> On Mon, Dec 21, 2015 at 03:10:55PM +0200, Jani Nikula wrote:
>> Have get_blocksize() support the special case of MIPI sequence block v3+
>> which has a separate field for size. Provide and use abstractions for
>> getting the blocksize given a pointer to
Hi,
Can someone please help review this patch series from December.
https://patchwork.freedesktop.org/series/1864/
Thank you.
Yetunde
> -Original Message-
> From: Adebisi, YetundeX
> Sent: Wednesday, December 16, 2015 12:07 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Adebisi, Yetun
This patch checks for changes in sink count between short pulse
hpds and forces full detect when there is a change.
This will allow both detection of hotplug and unplug of panels
through dongles that give only short pulse for such events.
v2: changed variable type from u8 to bool (Jani)
retur
intel_dp_detect() is called for not just detection but
during modes enumeration as well. Repeating the whole
sequence during each of these calls is wasteful and
time consuming.
This patch moves probing for panel, DPCD read etc done in
intel_dp_detect() to a new function intel_dp_long_pulse().
Note
This patch reads sink_count dpcd always and removes its
read operation based on values in downstream port dpcd.
SINK_COUNT dpcd is not dependent on DOWNSTREAM_PORT_PRESENT dpcd.
SINK_COUNT denotes if a display is attached, while
DOWNSTREAM_PORT_PRESET indicates how many ports are available
in the
This patch set cleans up DP detection logic to bring all DPCD
operations at one place and to create a clear demarcation
between handling of long and short pulses. This simplifies
fixing of sink count related detection for DP panels.
Patches:
1. First two patches clean up intel_dp_detect and form a
Current DP detection has DPCD operations split across
intel_dp_hpd_pulse and intel_dp_detect which contains
duplicates as well. Also intel_dp_detect is called
during modes enumeration as well which will result
in multiple dpcd operations. So this patch tries
to solve both these by bringing all DPCD
When created originally intel_dp_check_link_status()
was supposed to handle only link training for short
pulse but has grown into handler for short pulse itself.
This patch cleans up this function by splitting it into
two halves. First intel_dp_short_pulse() is called,
which will be entry point and
Sink count can change between short pulse hpd hence this patch
adds a member variable to intel_dp so we can track any changes
between short pulse interrupts.
Tested-by: Nathan D Ciobanu
Signed-off-by: Sivakumar Thulasimani
Signed-off-by: Shubhangi Shrivastava
---
drivers/gpu/drm/i915/intel_dp.
On 11/12/15 11:33, Chris Wilson wrote:
In order to ensure seqno/irq coherency, we current read a ring register.
We are not sure quite how it works, only that is does. Experiments show
that e.g. doing a clflush(seqno) instead is not sufficient, but we can
remove the forcewake dance from the mmio a
1 - 100 of 136 matches
Mail list logo
