Re: [Intel-gfx] [igvt-g-dev] [PULL] GVT-g device model fixes

2016-11-16 Thread Daniel Vetter
On Thu, Nov 17, 2016 at 02:51:28PM +0800, Zhenyu Wang wrote: > > On 2016.11.16 15:50:27 +0800, Zhenyu Wang wrote: > > > > Hi, > > > > Please pull current GVT-g device model fixes. > > > > Sorry, pls hold on this as found a possible conflict, as this is > supposed to be last pull before 4.10 mer

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Update connector status for DP MST hotplugs

2016-11-16 Thread Daniel Vetter
On Thu, Nov 17, 2016 at 01:53:31AM +, Pandiyan, Dhinakaran wrote: > On Sun, 2016-11-13 at 11:39 +0100, Daniel Vetter wrote: > > On Fri, Nov 11, 2016 at 10:21:39PM +0100, Daniel Vetter wrote: > > > On Mon, Nov 07, 2016 at 04:27:30PM -0800, Dhinakaran Pandiyan wrote: > > > > Hotplugging a monitor

[Intel-gfx] [PATCH] drm/i915: Complete requests in nop_submit_request

2016-11-16 Thread Chris Wilson
Since the submit/execute split in commit d55ac5bf97c6 ("drm/i915: Defer transfer onto execution timeline to actual hw submission") the global seqno advance was deferred until the submit_request callback. After wedging the GPU, we were installing a nop_submit_request handler (to avoid waking up the

Re: [Intel-gfx] [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes

2016-11-16 Thread Daniel Vetter
On Fri, Oct 28, 2016 at 10:10:50AM +0200, Daniel Vetter wrote: > Looking at the ioctl permission checks I noticed that it's impossible > to import gem buffers into a control nodes, and fd2handle/handle2fd > also don't work, so no joy with dma-bufs. > > The only way to do anything with a control no

Re: [Intel-gfx] [igvt-g-dev] [PULL] GVT-g device model fixes

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 15:50:27 +0800, Zhenyu Wang wrote: > > Hi, > > Please pull current GVT-g device model fixes. > Sorry, pls hold on this as found a possible conflict, as this is supposed to be last pull before 4.10 merge window, like to include the fix for that, will send update later. > Thanks. >

Re: [Intel-gfx] [PATCH v3] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 22:05:04 +0800, Min He wrote: > For a singl_port_submission context, it can only be submitted to port 0, > and there shouldn't be any other context in port 1 at the same time. This > is required by GVT-g context to have an opportunity to save/restore some > non-hw context render regis

Re: [Intel-gfx] [PATCH v3] drm/i915: start adding dp mst audio

2016-11-16 Thread Yang, Libin
Hi all, Could anyone help review the patches? Thanks. Regards, Libin > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Yang, Libin > Sent: Monday, November 14, 2016 1:41 PM > To: intel-gfx@lists.freedesktop.org; jani.nik...@linux.inte

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Update connector status for DP MST hotplugs

2016-11-16 Thread Pandiyan, Dhinakaran
On Sun, 2016-11-13 at 11:39 +0100, Daniel Vetter wrote: > On Fri, Nov 11, 2016 at 10:21:39PM +0100, Daniel Vetter wrote: > > On Mon, Nov 07, 2016 at 04:27:30PM -0800, Dhinakaran Pandiyan wrote: > > > Hotplugging a monitor in DP MST configuration triggers short pulses. > > > Although the short pulse

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Update connector status for DP MST hotplugs

2016-11-16 Thread Pandiyan, Dhinakaran
On Fri, 2016-11-11 at 23:05 +0200, Ville Syrjälä wrote: > On Fri, Nov 11, 2016 at 08:43:53PM +, Pandiyan, Dhinakaran wrote: > > On Tue, 2016-11-08 at 13:04 +0200, Ville Syrjälä wrote: > > > On Mon, Nov 07, 2016 at 04:27:30PM -0800, Dhinakaran Pandiyan wrote: > > > > Hotplugging a monitor in DP

Re: [Intel-gfx] [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

2016-11-16 Thread Marcos Paulo de Souza
Hi, On Wed, Nov 16, 2016 at 09:14:28PM +0100, Paolo Stivanin wrote: > Hello all, > @Jani Nikula: I just tried the patches you linked and they work > *perfectly* on my notebook (Clevo P640RE). I also tried to suspend and > resume the laptop and it works like a charm! > I applied the patches against

Re: [Intel-gfx] [PATCH] drm/i915/gvt: drop checks for early Skylake revisions

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 12:13:59 +0200, Jani Nikula wrote: > We no longer cater for pre-production revisions of Skylake. > > Fixes: d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on stepping > info") > Cc: Ping Gao > Cc: Zhenyu Wang > Cc: Zhi Wang > Cc: > Signed-off-by: Jani Nikula > --- appl

Re: [Intel-gfx] [PATCH] drm/i915/GuC: Combine the two kernel parameter into one

2016-11-16 Thread Srivatsa, Anusha
>-Original Message- >From: Mcgee, Jeff >Sent: Tuesday, November 15, 2016 2:46 PM >To: Srivatsa, Anusha >Cc: Tvrtko Ursulin ; Ursulin, Tvrtko >; intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > >Subject: Re: [Intel-gfx] [PATCH] drm/i915/GuC: Combine the two kernel >parameter into one > >O

Re: [Intel-gfx] [PATCH] drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:52:43PM -0200, Paulo Zanoni wrote: > Em Qua, 2016-11-16 às 19:07 +, Chris Wilson escreveu: > > I tried to avoid having to track the write for every VMA by only > > tracking writes to the ggtt. However, for the purposes of frontbuffer > > tracking this is insufficient

Re: [Intel-gfx] [PATCH] drm/i915: add i915_address_space_fini

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 07:25:17PM +, Matthew Auld wrote: > We already have an i915_address_space_init, so for symmetry we should > also have a _fini, plus we already open code it twice. This then also > fixes a bug where we leak the timeline for the ggtt vm. > > Cc: Chris Wilson > Signed-off

Re: [Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 07:32:49PM +, Matthew Auld wrote: > We need to clean up the global_timeline in i915_gem_load_cleanup. > > Cc: Chris Wilson > Signed-off-by: Matthew Auld > --- > drivers/gpu/drm/i915/i915_gem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/dr

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: don't leak global_timeline

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915: don't leak global_timeline URL : https://patchwork.freedesktop.org/series/15439/ State : warning == Summary == Series 15439v1 drm/i915: don't leak global_timeline https://patchwork.freedesktop.org/api/1.0/series/15439/revisions/1/mbox/ Test drv_module_re

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: add i915_address_space_fini

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915: add i915_address_space_fini URL : https://patchwork.freedesktop.org/series/15437/ State : warning == Summary == Series 15437v1 drm/i915: add i915_address_space_fini https://patchwork.freedesktop.org/api/1.0/series/15437/revisions/1/mbox/ Test drv_module_

Re: [Intel-gfx] [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

2016-11-16 Thread Paolo Stivanin
Hello all, @Jani Nikula: I just tried the patches you linked and they work *perfectly* on my notebook (Clevo P640RE). I also tried to suspend and resume the laptop and it works like a charm! I applied the patches against the Linux kernel v4.8.8 taken from upstream. Thanks again :) Cheers, Paolo

Re: [Intel-gfx] [PATCH] drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-16 Thread Paulo Zanoni
Em Qua, 2016-11-16 às 19:07 +, Chris Wilson escreveu: > I tried to avoid having to track the write for every VMA by only > tracking writes to the ggtt. However, for the purposes of frontbuffer > tracking this is insufficient as we need to invalidate around writes > not > just to the the ggtt bu

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915: Move frontbuffer CS write tracking from ggtt vma to object URL : https://patchwork.freedesktop.org/series/15435/ State : success == Summary == Series 15435v1 drm/i915: Move frontbuffer CS write tracking from ggtt vma to object https://patchwork.freedeskt

[Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-16 Thread Matthew Auld
We need to clean up the global_timeline in i915_gem_load_cleanup. Cc: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 3fb5e66..c440e72 10064

[Intel-gfx] [PATCH] drm/i915: add i915_address_space_fini

2016-11-16 Thread Matthew Auld
We already have an i915_address_space_init, so for symmetry we should also have a _fini, plus we already open code it twice. This then also fixes a bug where we leak the timeline for the ggtt vm. Cc: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 17 +

[Intel-gfx] [PATCH] drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-16 Thread Chris Wilson
I tried to avoid having to track the write for every VMA by only tracking writes to the ggtt. However, for the purposes of frontbuffer tracking this is insufficient as we need to invalidate around writes not just to the the ggtt but all aliased ppgtt views of the framebuffer. By moving the critical

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-16 Thread Manasi Navare
Jani/Ville could you please review this patch? This has been ACKed by DRM and is good from DRM point fo view. But I need r-b from either of you for this to get merged. Regards Manasi On Mon, Nov 14, 2016 at 07:13:23PM -0800, Manasi Navare wrote: > If link training at a link rate optimal for a par

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-16 Thread Manasi Navare
Jani/Ville , could you please review this patch? Jani, you had mentioned it looks good and we were only waiting for ACKs from DRM, so now from the DRM point of view all these patches are ACKed and it looks good. But I need r-b for these two i915 specific patches to get them merged. Regards Manasi

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Wipe hang stats as an embedded struct

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:20:34PM +0200, Mika Kuoppala wrote: > Bannable property, banned status, guilty and active counts are > properties of i915_gem_context. Make them so. > > v2: rebase > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala Been hesistating since the substruct might have hel

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add per client max context ban limit

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:20:33PM +0200, Mika Kuoppala wrote: > If we have a bad client submitting unfavourably across different > contexts, creating new ones, the per context scoring of badness > doesn't remove the root cause, the offending client. > To counter, keep track of per client context b

[Intel-gfx] [PULL] drm-misc-next

2016-11-16 Thread Daniel Vetter
Hi Dave, Another pile of misc: - Explicit fencing for atomic! Big thanks to Gustavo, Sean, Rob 3x, Brian and anyone else I've forgotten to make this happen. - roll out fbdev helper ops to drivers (Stefan Christ) - last bits of drm_crtc split-up&kerneldoc - some drm_irq.c crtc functions cleanup -

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Use request retirement as context progress

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:20:31PM +0200, Mika Kuoppala wrote: > As hangcheck score was removed, the active decay of score > was removed also. This removed feature for hangcheck to detect > if the gpu client was accidentally or maliciously causing intermittent > hangs. Reinstate the scoring as a pe

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Decouple hang detection from hangcheck period

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:20:30PM +0200, Mika Kuoppala wrote: > - ring_hung = engine->hangcheck.score >= HANGCHECK_SCORE_RING_HUNG; > - if (engine->hangcheck.seqno != intel_engine_get_seqno(engine)) > + ring_hung = engine->hangcheck.stall; > + if (engine->hangcheck.seqno != intel_e

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Use a local lock for dfs_link access URL : https://patchwork.freedesktop.org/series/15425/ State : warning == Summary == Series 15425v1 drm/i915/execlists: Use a local lock for dfs_link access https://patchwork.freedesktop.org/api/1.0/series/154

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/6] drm/i915: Split up hangcheck phases

2016-11-16 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Split up hangcheck phases URL : https://patchwork.freedesktop.org/series/15423/ State : warning == Summary == Series 15423v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15423/revisions/1/mbox/ T

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 03:54:23PM +, Tvrtko Ursulin wrote: > > On 16/11/2016 15:27, Chris Wilson wrote: > >Avoid requiring struct_mutex for exclusive access to the temporary > >dfs_link inside the i915_dependency as not all callers may want to touch > >struct_mutex. So rather than force them

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] HAX drm/i915: Enable guc submission (rev3)

2016-11-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] HAX drm/i915: Enable guc submission (rev3) URL : https://patchwork.freedesktop.org/series/15407/ State : failure == Summary == Series 15407v3 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15407/revisions/3/m

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Tvrtko Ursulin
On 16/11/2016 15:27, Chris Wilson wrote: Avoid requiring struct_mutex for exclusive access to the temporary dfs_link inside the i915_dependency as not all callers may want to touch struct_mutex. So rather than force them to take a highly contended lock, introduce a local lock for the execlists s

[Intel-gfx] [PATCH 6/6] drm/i915: Wipe hang stats as an embedded struct

2016-11-16 Thread Mika Kuoppala
Bannable property, banned status, guilty and active counts are properties of i915_gem_context. Make them so. v2: rebase Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h| 31 ++ drivers/gpu/drm/i915/i915_gem.c|

[Intel-gfx] [PATCH 5/6] drm/i915: Add per client max context ban limit

2016-11-16 Thread Mika Kuoppala
If we have a bad client submitting unfavourably across different contexts, creating new ones, the per context scoring of badness doesn't remove the root cause, the offending client. To counter, keep track of per client context bans. Deny access if client is responsible for more than 3 context bans

[Intel-gfx] [PATCH 2/6] drm/i915: Decouple hang detection from hangcheck period

2016-11-16 Thread Mika Kuoppala
Hangcheck state accumulation has gained more steps along the years, like head movement and more recently the subunit inactivity check. As the subunit sampling is only done if the previous state check showed inactivity, we have added more stages (and time) to reach a hang verdict. Asymmetric engine

[Intel-gfx] [PATCH 4/6] drm/i915: Add bannable context parameter

2016-11-16 Thread Mika Kuoppala
Now when driver has per context scoring of 'hanging badness' and also subsequent hangs during short windows are allowed, if there is progress made in between, it does not make sense to expose a ban timing window as a context parameter anymore. Let the scoring be the sole indicator for ban policy a

[Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Chris Wilson
Avoid requiring struct_mutex for exclusive access to the temporary dfs_link inside the i915_dependency as not all callers may want to touch struct_mutex. So rather than force them to take a highly contended lock, introduce a local lock for the execlists schedule operation. Reported-by: David Weine

[Intel-gfx] [PATCH 3/6] drm/i915: Use request retirement as context progress

2016-11-16 Thread Mika Kuoppala
As hangcheck score was removed, the active decay of score was removed also. This removed feature for hangcheck to detect if the gpu client was accidentally or maliciously causing intermittent hangs. Reinstate the scoring as a per context property, so that if one context starts to act unfavourably,

[Intel-gfx] [PATCH 1/6] drm/i915: Split up hangcheck phases

2016-11-16 Thread Mika Kuoppala
In order to simplify hangcheck state keeping, split hangcheck per engine loop in three phases: state load, action, state save. Add few more hangcheck actions to separate between seqno, head and subunit movements. This helps to gather all the hangcheck actions under a single switch umbrella. Cc: C

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix the dequeue logic for single_port_submission context (rev3)

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915: fix the dequeue logic for single_port_submission context (rev3) URL : https://patchwork.freedesktop.org/series/15391/ State : success == Summary == Series 15391v3 drm/i915: fix the dequeue logic for single_port_submission context https://patchwork.freed

[Intel-gfx] [PATCH v3] drm/i915/guc: Split hw submission for replay after GPU reset

2016-11-16 Thread Chris Wilson
Something I missed before sending off the partial series was that the non-scheduler guc reset path was broken (in the full series, this is pushed to the execlists reset handler). The issue is that after a reset, we have to refill the GuC workqueues, which we do by resubmitting the requests. However

Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 03:41:53PM +0100, Daniel Vetter wrote: > On Wed, Nov 16, 2016 at 08:58:30AM +, Chris Wilson wrote: > > Soft-pinning depends upon being able to check for availabilty of an > > interval and evict overlapping object from a drm_mm range manager very > > quickly. Currently it

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] HAX drm/i915: Enable guc submission (rev2)

2016-11-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] HAX drm/i915: Enable guc submission (rev2) URL : https://patchwork.freedesktop.org/series/15407/ State : failure == Summary == Series 15407v2 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15407/revisions/2/m

Re: [Intel-gfx] [PATCH v2] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-16 Thread Daniel Vetter
On Wed, Nov 16, 2016 at 01:54:45PM +, He, Min wrote: > > > -Original Message- > > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > > Sent: Wednesday, November 16, 2016 9:48 PM > > To: He, Min > > Cc: intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH v2] drm/i91

Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-16 Thread Daniel Vetter
On Wed, Nov 16, 2016 at 08:58:30AM +, Chris Wilson wrote: > Soft-pinning depends upon being able to check for availabilty of an > interval and evict overlapping object from a drm_mm range manager very > quickly. Currently it uses a linear list, and so performance is dire and > not suitable as a

Re: [Intel-gfx] [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

2016-11-16 Thread Jani Nikula
On Mon, 07 Nov 2016, Rainer Koenig wrote: > this is sad and also bad news. Means that actually we don't have any > driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6 > series work. I hope we can make this work [1]. BR, Jani. [1] https://patchwork.freedesktop.org/series/15403/

[Intel-gfx] [PATCH v3] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-16 Thread Min He
For a singl_port_submission context, it can only be submitted to port 0, and there shouldn't be any other context in port 1 at the same time. This is required by GVT-g context to have an opportunity to save/restore some non-hw context render registers. This patch is to implement the correct logic i

Re: [Intel-gfx] [i-g-t PATCH v7 2/5] lib: add igt_dummyload

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 04:07:33PM +0200, Abdiel Janulgue wrote: > > > On 16.11.2016 15:56, Chris Wilson wrote: > > On Wed, Nov 16, 2016 at 11:18:01PM +0200, Abdiel Janulgue wrote: > >> A lot of igt testcases need some GPU workload to make sure a race > >> window is big enough. Unfortunately havi

[Intel-gfx] ✗ Fi.CI.BAT: warning for Remove __I915__ magic macro (rev2)

2016-11-16 Thread Patchwork
== Series Details == Series: Remove __I915__ magic macro (rev2) URL : https://patchwork.freedesktop.org/series/15393/ State : warning == Summary == Series 15393v2 Remove __I915__ magic macro https://patchwork.freedesktop.org/api/1.0/series/15393/revisions/2/mbox/ Test kms_force_connector_basi

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Daniel Vetter
On Wed, Nov 16, 2016 at 04:08:30PM +0200, Jani Nikula wrote: > On Wed, 16 Nov 2016, Tomeu Vizoso wrote: > > On 16 November 2016 at 13:58, Jani Nikula > > wrote: > >> On Wed, 16 Nov 2016, Tomeu Vizoso wrote: > >>> On 15 November 2016 at 09:27, Jani Nikula > >>> wrote: > On Tue, 15 Nov 201

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Jani Nikula
On Wed, 16 Nov 2016, Tomeu Vizoso wrote: > On 16 November 2016 at 13:58, Jani Nikula wrote: >> On Wed, 16 Nov 2016, Tomeu Vizoso wrote: >>> On 15 November 2016 at 09:27, Jani Nikula >>> wrote: On Tue, 15 Nov 2016, David Weinehall wrote: > On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jan

Re: [Intel-gfx] [i-g-t PATCH v7 2/5] lib: add igt_dummyload

2016-11-16 Thread Abdiel Janulgue
On 16.11.2016 15:56, Chris Wilson wrote: > On Wed, Nov 16, 2016 at 11:18:01PM +0200, Abdiel Janulgue wrote: >> A lot of igt testcases need some GPU workload to make sure a race >> window is big enough. Unfortunately having a fixed amount of >> workload leads to spurious test failures or overtly l

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Tomeu Vizoso
On 16 November 2016 at 13:58, Jani Nikula wrote: > On Wed, 16 Nov 2016, Tomeu Vizoso wrote: >> On 15 November 2016 at 09:27, Jani Nikula >> wrote: >>> On Tue, 15 Nov 2016, David Weinehall wrote: On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: > On Thu, 06 Oct 2016, Tomeu

Re: [Intel-gfx] [i-g-t PATCH v7 2/5] lib: add igt_dummyload

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 11:18:01PM +0200, Abdiel Janulgue wrote: > A lot of igt testcases need some GPU workload to make sure a race > window is big enough. Unfortunately having a fixed amount of > workload leads to spurious test failures or overtly long runtimes > on some fast/slow platforms. This

Re: [Intel-gfx] [PATCH v2] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-16 Thread He, Min
> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Wednesday, November 16, 2016 9:48 PM > To: He, Min > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: fix the dequeue logic for > single_port_submission context > > On W

Re: [Intel-gfx] [PATCH v2] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 09:32:56PM +0800, Min He wrote: > For a singl_port_submission context, it can only be submitted to port 0, > and there shouldn't be any other context in port 1 at the same time. This > is required by GVT-g context to have an opportunity to save/restore some > non-hw context

[Intel-gfx] [PATCH v2] drm/i915/guc: Split hw submission for replay after GPU reset

2016-11-16 Thread Chris Wilson
Something I missed before sending off the partial series was that the non-scheduler guc reset path was broken (in the full series, this is pushed to the execlists reset handler). The issue is that after a reset, we have to refill the GuC workqueues, which we do by resubmitting the requests. However

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] HAX drm/i915: Enable guc submission

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 01:24:26PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] HAX drm/i915: Enable guc submission > URL : https://patchwork.freedesktop.org/series/15407/ > State : failure > > == Summary == > > Series 15407v1 Series without cover lette

[Intel-gfx] [PATCH v2] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-16 Thread Min He
For a singl_port_submission context, it can only be submitted to port 0, and there shouldn't be any other context in port 1 at the same time. This is required by GVT-g context to have an opportunity to save/restore some non-hw context render registers. This patch is to implement the correct logic i

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] HAX drm/i915: Enable guc submission

2016-11-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] HAX drm/i915: Enable guc submission URL : https://patchwork.freedesktop.org/series/15407/ State : failure == Summary == Series 15407v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15407/revisions/1/mbox/ T

[Intel-gfx] [i-g-t PATCH v7 5/5] igt/kms_busy.c: Use new igt_spin_batch

2016-11-16 Thread Abdiel Janulgue
v7: Adapt to api rename Cc: Chris Wilson Cc: Daniel Vetter Signed-off-by: Abdiel Janulgue --- tests/kms_busy.c | 75 +++- 1 file changed, 4 insertions(+), 71 deletions(-) diff --git a/tests/kms_busy.c b/tests/kms_busy.c index b555f99..680aeb

[Intel-gfx] [i-g-t PATCH v7 4/5] igt/kms_flip: Use new igt_spin_batch

2016-11-16 Thread Abdiel Janulgue
v7: Reuse NSEC_PER_SEC defines Cc: Chris Wilson Cc: Daniel Vetter Signed-off-by: Abdiel Janulgue --- tests/kms_flip.c | 188 ++- 1 file changed, 4 insertions(+), 184 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 2a9fe2e

[Intel-gfx] [i-g-t PATCH v7 3/5] igt/gem_wait: Use new igt_spin_batch

2016-11-16 Thread Abdiel Janulgue
v7: Adapt to api rename Cc: Chris Wilson Cc: Daniel Vetter Signed-off-by: Abdiel Janulgue --- tests/gem_wait.c | 129 +++ 1 file changed, 7 insertions(+), 122 deletions(-) diff --git a/tests/gem_wait.c b/tests/gem_wait.c index b4127de..d2920

[Intel-gfx] [i-g-t PATCH v7 2/5] lib: add igt_dummyload

2016-11-16 Thread Abdiel Janulgue
A lot of igt testcases need some GPU workload to make sure a race window is big enough. Unfortunately having a fixed amount of workload leads to spurious test failures or overtly long runtimes on some fast/slow platforms. This library contains functionality to submit GPU workloads that should consu

[Intel-gfx] [i-g-t PATCH v7 1/5] lib: Make signal helper definitions reusable

2016-11-16 Thread Abdiel Janulgue
More and more test-cases are using this. Signed-off-by: Abdiel Janulgue --- lib/igt_aux.c | 11 --- lib/igt_aux.h | 10 ++ lib/igt_core.c | 3 --- tests/drv_hangman.c | 1 - 4 files changed, 10 insertions(+), 15 deletions(-) diff --git a/lib/igt_aux.c b/lib/ig

[Intel-gfx] i-g-t dummyload/spin batch v7

2016-11-16 Thread Abdiel Janulgue
* Fix for Haswell in generating a dummy reloc * code cleanups / api name clarifications - Abdiel ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Split hw submission for replay after GPU reset

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 12:53:07PM +, Tvrtko Ursulin wrote: > On 16/11/2016 12:20, Chris Wilson wrote: > >@@ -1538,8 +1541,7 @@ int i915_guc_submission_enable(struct drm_i915_private > >*dev_priv) > > list_for_each_entry(request, > > &engine->timelin

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Jani Nikula
On Wed, 16 Nov 2016, Tomeu Vizoso wrote: > On 15 November 2016 at 09:27, Jani Nikula wrote: >> On Tue, 15 Nov 2016, David Weinehall wrote: >>> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: On Thu, 06 Oct 2016, Tomeu Vizoso wrote: > diff --git a/drivers/gpu/drm/i915/inte

Re: [Intel-gfx] [PATCH 01/19] drm/atomic: Add new iterators over all state

2016-11-16 Thread Maarten Lankhorst
Op 03-11-16 om 16:11 schreef Ville Syrjälä: > On Wed, Nov 02, 2016 at 09:28:46AM +0100, Maarten Lankhorst wrote: >> Op 01-11-16 om 14:41 schreef Ville Syrjälä: >>> On Tue, Nov 01, 2016 at 02:34:00PM +0100, Maarten Lankhorst wrote: Op 01-11-16 om 14:09 schreef Ville Syrjälä: > On Mon, Oct 1

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Split hw submission for replay after GPU reset

2016-11-16 Thread Tvrtko Ursulin
On 16/11/2016 12:20, Chris Wilson wrote: Something I missed before sending off the partial series was that the non-scheduler guc reset path was broken (in the full series, this is pushed to the execlists reset handler). The issue is that after a reset, we have to refill the GuC workqueues, which

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/opregion: proper handling of DIDL, and some hacks on CADL

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915/opregion: proper handling of DIDL, and some hacks on CADL URL : https://patchwork.freedesktop.org/series/15403/ State : failure == Summary == Series 15403v1 drm/i915/opregion: proper handling of DIDL, and some hacks on CADL https://patchwork.freedesktop.o

Re: [Intel-gfx] [PATCH v4 4/8] drm/i915/gen9: WM memory bandwidth related workaround

2016-11-16 Thread Paulo Zanoni
Em Qui, 2016-11-10 às 11:24 +0530, Mahesh Kumar escreveu: > Hi, > > > (removed a bunch of stuff here) > > > > >  > > > > > > > > > > + bool y_tile_enabled = false; > > > + > > if (!platforms_that_require_the_wa) { > > wa = WATERMARK_WA_NONE; > > return; > > } > this function is not

Re: [Intel-gfx] [PATCH] drm/i915: Remove stolen object spam

2016-11-16 Thread Tvrtko Ursulin
On 16/11/2016 12:26, Chris Wilson wrote: We don't spam the debug when we create a normal object, nor when we allocate their pages. Yet we do for stolen objects, and since these are quite frequently used (at least once per context), the resulting spam floods the dmesg in CI. Signed-off-by: Chris

[Intel-gfx] [PATCH v2 13/15] drm/i915: dev_priv cleanup in intel_display.c

2016-11-16 Thread Tvrtko Ursulin
From: Tvrtko Ursulin v2: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 3 +- drivers/gpu/drm/i915/intel_display.c | 167 +++ 3 files changed, 75 insertions(+), 97 deletions(-) d

Re: [Intel-gfx] [PATCH] drm/i915/gvt: drop checks for early Skylake revisions

2016-11-16 Thread Paulo Zanoni
Em Qua, 2016-11-16 às 12:13 +0200, Jani Nikula escreveu: > We no longer cater for pre-production revisions of Skylake. Reviewed-by: Paulo Zanoni > > Fixes: d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on > stepping info") > Cc: Ping Gao > Cc: Zhenyu Wang > Cc: Zhi Wang > Cc: > Sig

[Intel-gfx] [PATCH] drm/i915: Remove stolen object spam

2016-11-16 Thread Chris Wilson
We don't spam the debug when we create a normal object, nor when we allocate their pages. Yet we do for stolen objects, and since these are quite frequently used (at least once per context), the resulting spam floods the dmesg in CI. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Tomeu Vizoso
On 15 November 2016 at 09:27, Jani Nikula wrote: > On Tue, 15 Nov 2016, David Weinehall wrote: >> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >>> On Thu, 06 Oct 2016, Tomeu Vizoso wrote: >>> > diff --git a/drivers/gpu/drm/i915/intel_display.c >>> > b/drivers/gpu/drm/i915/intel_

[Intel-gfx] ✗ Fi.CI.BAT: failure for HAX drm/i915: Enable guc submission

2016-11-16 Thread Patchwork
== Series Details == Series: HAX drm/i915: Enable guc submission URL : https://patchwork.freedesktop.org/series/15402/ State : failure == Summary == Series 15402v1 HAX drm/i915: Enable guc submission https://patchwork.freedesktop.org/api/1.0/series/15402/revisions/1/mbox/ Test drv_module_relo

[Intel-gfx] [PATCH 2/2] drm/i915/guc: Split hw submission for replay after GPU reset

2016-11-16 Thread Chris Wilson
Something I missed before sending off the partial series was that the non-scheduler guc reset path was broken (in the full series, this is pushed to the execlists reset handler). The issue is that after a reset, we have to refill the GuC workqueues, which we do by resubmitting the requests. However

[Intel-gfx] [PATCH 1/2] HAX drm/i915: Enable guc submission

2016-11-16 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index d46ffe7086bc..599b913d8906 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_p

Re: [Intel-gfx] [RFC i-g-t 0/4] intel-gpu-tools: Add support for the Chamelium

2016-11-16 Thread Tomeu Vizoso
On 15 November 2016 at 22:44, Lyude Paul wrote: > I'm fine with libsoup as well, I'll check it out and probably move all > of the code over to using that instead. Cool. > On Tue, 2016-11-15 at 12:44 +0100, Tomeu Vizoso wrote: >> On 11 November 2016 at 18:53, Lyude Paul wrote: >> > > > - While

Re: [Intel-gfx] [PATCH v4 3/8] drm/i915: Decode system memory bandwidth

2016-11-16 Thread Mahesh Kumar
Hi, On Friday 04 November 2016 12:36 AM, Paulo Zanoni wrote: Em Qui, 2016-10-13 às 16:28 +0530, Kumar, Mahesh escreveu: This patch adds support to decode system memory bandwidth which will be used for arbitrated display memory percentage calculation in GEN9 based system. Changes from v1: -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: drop checks for early Skylake revisions

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915/gvt: drop checks for early Skylake revisions URL : https://patchwork.freedesktop.org/series/15400/ State : success == Summary == Series 15400v1 drm/i915/gvt: drop checks for early Skylake revisions https://patchwork.freedesktop.org/api/1.0/series/15400/rev

Re: [Intel-gfx] [PATCH i-g-t v7] tests/kms_plane_multiple: CRC based atomic correctness test

2016-11-16 Thread Kahola, Mika
Thanks for the review! Cheers, Mika > -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Wednesday, November 16, 2016 11:48 AM > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Cc: Latvala, Petri ; dan...@ffwll.ch > Subject: Re: [PATCH i-g

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_lowres: Plane visibility after atomic modesets

2016-11-16 Thread Kahola, Mika
> -Original Message- > From: Daniel Stone [mailto:dan...@fooishbar.org] > Sent: Tuesday, November 15, 2016 3:20 PM > To: Kahola, Mika > Cc: intel-gfx > Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_lowres: Plane > visibility > after atomic modesets > > Hi Mika, > > On 15 Nov

[Intel-gfx] [PATCH 2/3] drm/i915/opregion: fill in the CADL from connector list, not DIDL

2016-11-16 Thread Jani Nikula
This is essentially the same thing as duplicating DIDL now that the connector list has the ACPI device IDs. Cc: Peter Wu Cc: Rainer Koenig Cc: Jan-Marek Glogowski Cc: Maarten Lankhorst Cc: Marcos Paulo de Souza Cc: Paolo Stivanin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_op

[Intel-gfx] [PATCH 3/3] drm/i915/opregion: put internal panels to the front of CADL

2016-11-16 Thread Jani Nikula
The attempts to update CADL based on the actual active connectors have not been successful. That is the right thing to do ultimately, but there must be something we're still missing. In the mean time, change the dumb CADL initialization we currently have to put internal panels in front of the CADL

[Intel-gfx] [PATCH 1/3] drm/i915: make i915 the source of acpi device ids for _DOD

2016-11-16 Thread Jani Nikula
The graphics driver is supposed to define the DIDL, which are used for _DOD, not the BIOS. Restore that behaviour. This is basically a revert of commit 3143751ff51a163b77f7efd389043e038f3e008e Author: Zhang Rui Date: Mon Mar 29 15:12:16 2010 +0800 drm/i915: set DIDL using the ACPI video o

[Intel-gfx] [PATCH 0/3] drm/i915/opregion: proper handling of DIDL, and some hacks on CADL

2016-11-16 Thread Jani Nikula
Another spin of [1]. The pain point seems to be the CADL update based on the list of active connectors. So I left it out for now, and instead just hack it to ensure CADL contains the internal displays. Let's see if this sticks. It shouldn't prevent us from fixing CADL update properly down the line

Re: [Intel-gfx] [CI 08/10] drm/i915/scheduler: Execute requests in order of priorities

2016-11-16 Thread Jani Nikula
This patch, or commit 20311bd35060435badba8a0d46b06d5d184abaf7 Author: Chris Wilson Date: Mon Nov 14 20:41:03 2016 + drm/i915/scheduler: Execute requests in order of priorities tricks sparse into warnings. It makes me unhappy to see the sparse warnings accumulate because that will ev

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add more keywords to firmware loading message

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915: Add more keywords to firmware loading message URL : https://patchwork.freedesktop.org/series/15397/ State : success == Summary == Series 15397v1 drm/i915: Add more keywords to firmware loading message https://patchwork.freedesktop.org/api/1.0/series/15397

[Intel-gfx] [CI] HAX drm/i915: Enable guc submission

2016-11-16 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index d46ffe7086bc..599b913d8906 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_p

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 10:54:15AM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB > upon insertion > URL : https://patchwork.freedesktop.org/series/15396/ > State : failure > > == Summary == > > Series 15396v1 Ser

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-11-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion URL : https://patchwork.freedesktop.org/series/15396/ State : failure == Summary == Series 15396v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15396

Re: [Intel-gfx] [PATCH] drm/i915: Add more keywords to firmware loading message

2016-11-16 Thread Imre Deak
On ke, 2016-11-16 at 11:33 +0200, Mika Kuoppala wrote: > To find out what firmware we actually loaded (from dmesg) the explicit > 'dmc' and 'firmware' are missing from the info printout. Add them. > > Cc: Imre Deak > Signed-off-by: Mika Kuoppala Reviewed-by: Imre Deak > --- >  drivers/gpu/drm

Re: [Intel-gfx] [PATCH i-g-t 3/4 v5] tests/drv_module_reload: Convert sh script to C version.

2016-11-16 Thread Petri Latvala
On Thu, Nov 03, 2016 at 06:36:45PM +0200, Jani Nikula wrote: > On Thu, 03 Nov 2016, Marius Vlad wrote: > > v5: > > - reworked gem_info to gem_sanitychecks (Chris Wilson) > > - remove subgroups/subtests for gem_exec_store and gem_sanitycheck > > (Chris Wilson) > > > > v4: > > - adjust test to make

[Intel-gfx] [PATCH] drm/i915/gvt: drop checks for early Skylake revisions

2016-11-16 Thread Jani Nikula
We no longer cater for pre-production revisions of Skylake. Fixes: d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on stepping info") Cc: Ping Gao Cc: Zhenyu Wang Cc: Zhi Wang Cc: Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 6 ++ 1 file changed, 2 insertio

  1   2   >