[Intel-gfx] [Regression report] Weekly regression report WW47

2016-11-21 Thread Jairo Miramontes
Total regressions: 47 This week regressions:0 +---+-+++ | BugId | Summary | Created on | Bisect | +---+-+++ Previous regressions:47

[Intel-gfx] [PATCH i-g-t] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

2016-11-21 Thread Manasi Navare
This is the userspace component of the Displayport Compliance testing software required for compliance testing of the I915 Display Port driver. This must be running in order to successfully complete Display Port compliance testing. This app and the kernel code that accompanies it has been written

[Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2016-11-21 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: In file included from include/linux/pci.h:30:0, from drivers/gpu/vga/vgaarb.c:40: drivers/gpu/vga/vgaarb.c: In function 'vga_arb_device_init':

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add a helper function to return DP link rate index

2016-11-21 Thread kbuild test robot
Hi Manasi, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20161117] [cannot apply to v4.9-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bxt: Correct dual-link MIPI port control.

2016-11-21 Thread Patchwork
== Series Details == Series: drm/i915/bxt: Correct dual-link MIPI port control. URL : https://patchwork.freedesktop.org/series/15690/ State : success == Summary == Series 15690v1 drm/i915/bxt: Correct dual-link MIPI port control.

[Intel-gfx] [PATCH i-g-t 0/3] Various fixes for non-Intel compatibility

2016-11-21 Thread Lyude
Here's a couple of fixes I ended up needing when I was working on trying to get the chamelium tests to pass on the other GPUs I've got available. This should make both igt_display_init() and kmstest_force_connector() work properly on most non-intel hardware. Lyude (3): igt_kms: Don't assume we

[Intel-gfx] [PATCH i-g-t 3/3] igt_kms: Don't require intel hardware for kmstest_force_connector

2016-11-21 Thread Lyude
Due to the unconditional call to intel_get_drm_devid() in kmstest_force_connector(), trying to use this function on anything that isn't intel hardware results in the current fixture being skipped. So, don't try to get the devid in kmstest_force_connector() unless we're on an Intel chipset.

[Intel-gfx] [PATCH i-g-t 2/3] igt_kms: Change the max number of pipes to 6

2016-11-21 Thread Lyude
Unfortunately the assumption that we only have 6 display pipes available is specific to Intel, and seems to be breaking igt_display_init() on both radeon and nouveau since this causes us not to leave enough space in the igt_display_t struct to hold information for all 6 pipes. So, up the max to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: Add a helper function to return DP link rate index

2016-11-21 Thread Patchwork
== Series Details == Series: drm/i915/dp: Add a helper function to return DP link rate index URL : https://patchwork.freedesktop.org/series/15689/ State : failure == Summary == CC [M] drivers/gpu/drm/i915/intel_tv.o LD sound/pci/built-in.o CC [M]

[Intel-gfx] [PATCH i-g-t 1/3] igt_kms: Don't assume we have cursor planes if we have primary ones

2016-11-21 Thread Lyude
On certain models of nvidia and AMD GPUs, we can have a primary plane without any DRM plane for the cursor plane. Check for this so we don't segfault on non-intel hardware. Signed-off-by: Lyude --- lib/igt_kms.c | 27 +++ lib/igt_kms.h | 1 + 2 files

[Intel-gfx] [PATCH] drm/i915/bxt: Correct dual-link MIPI port control.

2016-11-21 Thread Bob Paauwe
For BXT, there is only one bit that enables/disables dual-link mode and not different bits depending on which pipe is being used. Signed-off-by: Bob Paauwe --- drivers/gpu/drm/i915/intel_dsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH] drm/i915/dp: Add a helper function to return DP link rate index

2016-11-21 Thread Manasi Navare
Common rates array is used to keep track of common rates supported between DP sink and source. This helper function returns the index of a specific link rate in this common rates array. This is in prep with patches for DP Link training compliance tests that need an index for the link rate

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-21 Thread Manasi Navare
On Mon, Nov 21, 2016 at 08:46:19PM +, Chris Wilson wrote: > On Mon, Nov 21, 2016 at 11:00:52AM -0800, Manasi Navare wrote: > > On Mon, Nov 21, 2016 at 04:48:07PM +0100, Daniel Vetter wrote: > > > On Mon, Nov 21, 2016 at 11:10:45AM +0100, Daniel Vetter wrote: > > > > On Mon, Nov 21, 2016 at

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-21 Thread Chris Wilson
On Mon, Nov 21, 2016 at 11:00:52AM -0800, Manasi Navare wrote: > On Mon, Nov 21, 2016 at 04:48:07PM +0100, Daniel Vetter wrote: > > On Mon, Nov 21, 2016 at 11:10:45AM +0100, Daniel Vetter wrote: > > > On Mon, Nov 21, 2016 at 09:42:57AM +, Chris Wilson wrote: > > > > On Mon, Nov 21, 2016 at

Re: [Intel-gfx] [PATCH v5 6/8] drm/i915: Add intel_atomic_get_existing_crtc_state function

2016-11-21 Thread Paulo Zanoni
Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: > This patch Adds a function to extract intel_crtc_state from the > atomic_state, if not available it returns NULL. Reviewed-by: Paulo Zanoni > Signed-off-by: Mahesh Kumar > --- >  

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lspcon: Fix ParadTech PS175 adaptor detection

2016-11-21 Thread Patchwork
== Series Details == Series: drm/i915/lspcon: Fix ParadTech PS175 adaptor detection URL : https://patchwork.freedesktop.org/series/15682/ State : success == Summary == Series 15682v1 drm/i915/lspcon: Fix ParadTech PS175 adaptor detection

[Intel-gfx] [PATCH 2/4] drm/i915/lspcon: Add dp_to_lspcon helper()

2016-11-21 Thread Imre Deak
We need to get to LSPCON in the next patch, so factor out the helper for it. While at it also remove the redundant GEN9 check. Cc: Shashank Sharma Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_dp.c | 7 +++

[Intel-gfx] [PATCH 1/4] drm/i915/lspcon: Ensure AUX CH is awake while in DP Sleep state

2016-11-21 Thread Imre Deak
Some LSPCON adaptors won't properly wake up in response to an AUX request after the adaptor was placed to a DP Sink Sleep state (via writing 0x2 to DP_SET_POWER). Based on the DP 1.4 specification 5.2.5, the sink may place the AUX CH into a low-power state while in Sleep state, but should wake it

[Intel-gfx] [PATCH 3/4] drm/i915/lspcon: Wait for expected LSPCON mode to settle

2016-11-21 Thread Imre Deak
Some LSPCON adaptors may return an incorrect LSPCON mode right after waking from DP Sleep state. This is the case at least for the ParadTech PS175 adaptor, both when waking because of exiting the DP Sleep to active state, or due to any other AUX CH transfer. We can determine the current expected

[Intel-gfx] [PATCH 4/4] drm/i915/lspcon: Remove unused force change mode parameter

2016-11-21 Thread Imre Deak
All callers asked for a forced change but the function ignored this parameter. It doesn't seem to be necessary to force the change in any case so let's just remove the parameter. Cc: Shashank Sharma Signed-off-by: Imre Deak ---

[Intel-gfx] [PATCH 0/4] drm/i915/lspcon: Fix ParadTech PS175 adaptor detection

2016-11-21 Thread Imre Deak
Patch 1 should fix the occasional detection problem seen on one SKL-6770HQ machine in CI with a ParadTech PS175 LSPCON adaptor on board. Patch 3 fixes a potential problem while changing the LSPCON mode or starting link training while the mode is still settling as reported by the adaptor. Cc:

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-21 Thread Manasi Navare
On Mon, Nov 21, 2016 at 04:48:07PM +0100, Daniel Vetter wrote: > On Mon, Nov 21, 2016 at 11:10:45AM +0100, Daniel Vetter wrote: > > On Mon, Nov 21, 2016 at 09:42:57AM +, Chris Wilson wrote: > > > On Mon, Nov 21, 2016 at 10:38:20AM +0100, Daniel Vetter wrote: > > > > On Fri, Nov 18, 2016 at

Re: [Intel-gfx] [PATCH v5 4/8] drm/i915/bxt: Enable IPC support

2016-11-21 Thread Paulo Zanoni
Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: > This patch adds IPC support for platforms. This patch enables IPC > only for BXT/KBL platform as for SKL recommendation is to keep is > disabled. > IPC (Isochronous Priority Control) is the hardware feature, which > dynamically controles

[Intel-gfx] [RFC i-g-t v2 4/5] igt_kms: Add helpers for watching for sysfs hotplug events

2016-11-21 Thread Lyude
This adds some basic helpers for connecting to udev and watching for sysfs hotplug events. Signed-off-by: Lyude --- lib/igt_kms.c | 109 ++ lib/igt_kms.h | 6 2 files changed, 115 insertions(+) diff --git

[Intel-gfx] [RFC i-g-t v2 5/5] Add support for hotplug testing with the Chamelium

2016-11-21 Thread Lyude
For the purpose of testing things such as hotplugging and bad monitors, the ChromeOS team ended up designing a neat little device known as the Chamelium. More information on this can be found here: https://www.chromium.org/chromium-os/testing/chamelium This adds support for a couple of

[Intel-gfx] [RFC i-g-t v2 2/5] igt_aux: Add igt_set_autoresume_delay()

2016-11-21 Thread Lyude
The default autoresume delay is about 5 seconds. It's possible on a system that's not very fast this might not be a long enough time, since an asynchronous hotplug event we scheduled on the chamelium that was intended to happen during suspend could happen before we actually manage to suspend. So,

[Intel-gfx] [RFC i-g-t v2 3/5] igt_aux: Add some list helpers from wayland

2016-11-21 Thread Lyude
Since we're going to be using lists for keeping track of EDIDs we've allocated on the chamelium, add some generic list helpers from the wayland project. Signed-off-by: Lyude Changes since v1: - Rename list helpers to be more like those from the Linux kernel --- lib/igt_aux.c

[Intel-gfx] [RFC i-g-t v2 1/5] igt_aux: Add igt_skip_without_suspend_support()

2016-11-21 Thread Lyude
Since all of the chamelium calls are blocking, we need to be able to make suspend/resume tests with it multi-threaded. As such, it's not the best idea to rely on igt_system_suspend_autoresume() for skipping tests on systems without suspend/resume support since we could accidentally leave the

[Intel-gfx] [RFC i-g-t v2 0/5] intel-gpu-tools: Add support for the Chamelium

2016-11-21 Thread Lyude
This is the next version of the patchset for adding Chamelium support into intel-gpu-tools. The major changes (described in more details in the actual patches): - Connector mappings are specified in a configuration file, no more guessing - Some fixes for tests that were throwing false negatives -

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Use smaller 8/3X MIPI clock divider value for dual link.

2016-11-21 Thread Bob Paauwe
On Sat, 19 Nov 2016 11:20:56 +0100 David Weinehall wrote: > On Fri, Nov 18, 2016 at 02:11:56PM -0800, Bob Paauwe wrote: > > For a single link (channel) DSI panel we want to use a larger divider > > and keep the clock rate down to save power when in DPI/video mode. However > >

Re: [Intel-gfx] [PATCH v5 3/8] drm/i915/kbl: IPC workaround for kabylake

2016-11-21 Thread Paulo Zanoni
Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: > IPC (Isoch Priority Control) may cause underflows. > > KBL WA: When IPC is enabled, watermark latency values must be > increased > by 4us across all levels. This brings level 0 up to 6us. > > Signed-off-by: Mahesh Kumar

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Don't deref context->file_priv ERR_PTR upon reset

2016-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Don't deref context->file_priv ERR_PTR upon reset URL : https://patchwork.freedesktop.org/series/15658/ State : failure == Summary == Series 15658v1 drm/i915: Don't deref context->file_priv ERR_PTR upon reset

Re: [Intel-gfx] [PATCH v5 2/8] drm/i915/bxt: IPC WA for Broxton

2016-11-21 Thread Paulo Zanoni
Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: > If IPC is enabled in BXT, display underruns are observed. > WA: The Line Time programmed in the WM_LINETIME register should be > half of the actual calculated Line Time. > > Programmed Line Time = 1/2*Calculated Line Time > >

Re: [Intel-gfx] [PATCH v5 1/8] drm/i915/skl: Add variables to check x_tile and y_tile

2016-11-21 Thread Paulo Zanoni
Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: > This patch adds variable to check for X_tiled & y_tiled planes, > instead > of always checking against framebuffer-modifiers. > > Changes: >  - Created separate patch as per Paulo's comment >  - Added x_tiled variable as well > Changes

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/3] drm/i915: Disable hangcheck when wedged (rev2)

2016-11-21 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Disable hangcheck when wedged (rev2) URL : https://patchwork.freedesktop.org/series/15543/ State : warning == Summary == Series 15543v2 Series without cover letter

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop the machine as we install the wedged submit_request handler

2016-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Stop the machine as we install the wedged submit_request handler URL : https://patchwork.freedesktop.org/series/15652/ State : success == Summary == Series 15652v1 drm/i915: Stop the machine as we install the wedged submit_request handler

Re: [Intel-gfx] [PATCH i-g-t v8 02/21] tests/sw_sync: Add sw_sync test

2016-11-21 Thread Chris Wilson
On Mon, Nov 21, 2016 at 10:29:03AM -0500, robert.f...@collabora.com wrote: > From: Robert Foss > > Add initial tests for sw_sync. > > Signed-off-by: Robert Foss > Signed-off-by: Gustavo Padovan >

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-21 Thread Daniel Vetter
On Mon, Nov 21, 2016 at 11:10:45AM +0100, Daniel Vetter wrote: > On Mon, Nov 21, 2016 at 09:42:57AM +, Chris Wilson wrote: > > On Mon, Nov 21, 2016 at 10:38:20AM +0100, Daniel Vetter wrote: > > > On Fri, Nov 18, 2016 at 09:44:49AM -0800, Manasi Navare wrote: > > > > On Fri, Nov 18, 2016 at

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move the release of PT page to the upper caller

2016-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Move the release of PT page to the upper caller URL : https://patchwork.freedesktop.org/series/15651/ State : success == Summary == Series 15651v1 drm/i915: Move the release of PT page to the upper caller

[Intel-gfx] [PATCH i-g-t v8 19/21] tests/sw_sync: Add subtest test_sync_merge_invalid

2016-11-21 Thread robert . foss
From: Robert Foss Add subtest test_sync_merge_invalid that tests merging invalid fences. Signed-off-by: Robert Foss --- tests/sw_sync.c | 41 + 1 file changed, 41 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t v8 07/21] tests/sw_sync: Add subtest test_sync_merge

2016-11-21 Thread robert . foss
From: Robert Foss Add subtest test_sync_merge that tests merging fences and the validity of the resulting merged fence. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 67

[Intel-gfx] [PATCH i-g-t v8 21/21] tests/sw_sync: Add subtest test_sync_busy_unixsocket

2016-11-21 Thread robert . foss
From: Robert Foss Add subtest test_sync_busy_fork which increments the timeline in a forked child process, where the timeline fd has been sent through a UNIX socket. Signed-off-by: Robert Foss --- tests/sw_sync.c | 103

[Intel-gfx] [PATCH i-g-t v8 17/21] lib/sw_sync: Add igt_require_sw_sync to enable skipping on no sw_sync support

2016-11-21 Thread robert . foss
From: Robert Foss Add igt_require_sw_sync to provide tests to skip if sw_sync support isn't available on the host machine. Signed-off-by: Robert Foss --- lib/sw_sync.c | 22 ++ lib/sw_sync.h | 1 + 2 files changed, 23

[Intel-gfx] [PATCH i-g-t v8 06/21] tests/sw_sync: Add subtest test_sync_busy

2016-11-21 Thread robert . foss
From: Robert Foss This subtest verifies that waiting on fences works properly. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 51 +++ 1 file

[Intel-gfx] [PATCH i-g-t v8 16/21] tests/sw_sync: Add subtest test_timeline_closed_signaled

2016-11-21 Thread robert . foss
From: Robert Foss Add subtest test_timeline_closed_signaled that verifies that a signaled fence stays signaled after its timeline has been closed. Signed-off-by: Robert Foss --- tests/sw_sync.c | 18 ++ 1 file changed, 18

[Intel-gfx] [PATCH i-g-t v8 01/21] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-11-21 Thread robert . foss
From: Robert Foss Base functions to help testing the Sync File Framework (explicit fencing mechanism ported from Android). These functions allow you to create, use and destroy timelines and fences. Signed-off-by: Robert Foss Signed-off-by:

[Intel-gfx] [PATCH i-g-t v8 03/21] tests/sw_sync: Add subtest test_alloc_fence

2016-11-21 Thread robert . foss
From: Robert Foss Add subtest alloc_fence that verifies that it's possible to allocate a fence on a timeline. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 16 1 file

[Intel-gfx] [PATCH i-g-t v8 00/21] Implement sw_sync test

2016-11-21 Thread robert . foss
From: Robert Foss This series implements the sw_sync test and the lib/sw_sync helper functions for said test. The sw_sync subtests range from very basic tests of the sw_sync functionality, to stress testing and randomized tests. Changes since v1: Added

[Intel-gfx] [PATCH i-g-t v8 14/21] tests/sw_sync: Add subtest test_sync_expired_merge

2016-11-21 Thread robert . foss
From: Rafael Antognolli This test creates an already expired fence, then creates a merged fence out of that expired one (passed twice to the merge operation), and finally closes the merged fence. It shows that if the refcounts are wrong on the original expired fence,

[Intel-gfx] [PATCH i-g-t v8 09/21] tests/sw_sync: Add subtest test_sync_multi_consumer

2016-11-21 Thread robert . foss
From: Robert Foss This subtest verifies the access ordering of multiple consumer threads. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 103

[Intel-gfx] [PATCH i-g-t v8 15/21] tests/sw_sync: Add subtest test_timeline_closed

2016-11-21 Thread robert . foss
From: Robert Foss This subtest verifies that the fences of a timeline are not signalled when a timelne is closed. Signed-off-by: Robert Foss --- tests/sw_sync.c | 17 + 1 file changed, 17 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t v8 04/21] tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline

2016-11-21 Thread robert . foss
From: Robert Foss This subtests tests that creating fences on negative timelines fail. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t v8 11/21] tests/sw_sync: Add subtest test_sync_random_merge

2016-11-21 Thread robert . foss
From: Robert Foss This subtest verifies that creating many timelines and merging random fences from each timeline with eachother results in merged fences that are fully functional. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom

[Intel-gfx] [PATCH i-g-t v8 20/21] tests/sw_sync: Add subtest test_sync_busy_fork

2016-11-21 Thread robert . foss
From: Robert Foss Add subtest test_sync_busy_fork which increments the timeline in a forked child process. Signed-off-by: Robert Foss --- tests/sw_sync.c | 39 +++ 1 file changed, 39 insertions(+) diff

[Intel-gfx] [PATCH i-g-t v8 08/21] tests/sw_sync: Add subtest test_sync_merge_same

2016-11-21 Thread robert . foss
From: Robert Foss This subtest verifies merging a fence with itself does not fail. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 27 +++ 1 file changed, 27

[Intel-gfx] [PATCH i-g-t v8 12/21] tests/sw_sync: Add subtest test_sync_multi_timeline_wait

2016-11-21 Thread robert . foss
From: Robert Foss This subtest verifies that waiting, timing out on a wait and that counting fences in various states works. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 66

[Intel-gfx] [PATCH i-g-t v8 05/21] tests/sw_sync: Add subtest test_alloc_merge_fence

2016-11-21 Thread robert . foss
From: Robert Foss This subtest verifies that merging two fences works in the simples possible case. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 23 +++ 1 file

[Intel-gfx] [PATCH i-g-t v8 13/21] tests/sw_sync: Add subtest test_sync_multi_producer_single_consumer

2016-11-21 Thread robert . foss
From: Robert Foss This subtest runs a single consumer thread and multiple producer thread that are synchronized using multiple timelines. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 139

[Intel-gfx] [PATCH i-g-t v8 10/21] tests/sw_sync: Add subtest test_sync_multi_consumer_producer

2016-11-21 Thread robert . foss
From: Robert Foss This test verifies that stressing the kernel by creating multiple consumer/producer threads that wait on a single timeline to be incremented by another conumer/producer thread does not fail. And that the order amongst the threads is maintained.

[Intel-gfx] [PATCH i-g-t v8 18/21] tests/sw_sync: Add igt_require check for sw_sync feature

2016-11-21 Thread robert . foss
From: Robert Foss Make sure that this test is skipped if the sw_sync feature is missing from the host system. Signed-off-by: Robert Foss --- lib/sw_sync.c | 1 + tests/sw_sync.c | 3 +++ 2 files changed, 4 insertions(+) diff --git

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Remove plane config from intel_dump_pipe_config

2016-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Remove plane config from intel_dump_pipe_config URL : https://patchwork.freedesktop.org/series/15650/ State : warning == Summary == Series 15650v1 drm/i915: Remove plane config from intel_dump_pipe_config

Re: [Intel-gfx] [i-g-t PATCH v8 4/5] igt/kms_flip: Use new igt_spin_batch

2016-11-21 Thread Tomeu Vizoso
On 21 November 2016 at 10:25, Abdiel Janulgue wrote: > v7: Reuse NSEC_PER_SEC defines > v8: Don't wait on the fb, it must be busy. Exit the spin batch > when flip is queued (Chris Wilson) > > Cc: Chris Wilson > Cc: Daniel Vetter

Re: [Intel-gfx] [i-g-t PATCH v8 5/5] igt/kms_busy.c: Use new igt_spin_batch

2016-11-21 Thread Tomeu Vizoso
Looks good to me. Reviewed-by: Tomeu Vizoso Cheers, Tomeu On 21 November 2016 at 10:25, Abdiel Janulgue wrote: > v7: Adapt to api rename > v8: Tidy up finish_fb_busy (Chris Wilson) > > Cc: Chris Wilson >

Re: [Intel-gfx] [PATCH] drm/i915: Try to group more logically in intel_dump_pipe_config

2016-11-21 Thread Ville Syrjälä
On Mon, Nov 21, 2016 at 10:44:46AM +, Tvrtko Ursulin wrote: > > > On 18/11/2016 11:19, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Keep parameters relating to the pipe and crtc respectively together. > > > > Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [i-g-t PATCH v9 1/3] igt/gem_wait: Use new igt_spin_batch

2016-11-21 Thread Tomeu Vizoso
On 21 November 2016 at 13:07, Abdiel Janulgue wrote: > v7: Adapt to api rename > v8: Restore sanitycheck wait on the recursive batch and > avoid using C99 locals (Chris Wilson) > v9: Explicitly quit the batch instead of timing out right away > > Cc: Chris

[Intel-gfx] [i-g-t PATCH v8 1/5] lib: Make signal helper definitions reusable

2016-11-21 Thread Abdiel Janulgue
v2: Remove definition in benchmarks/gem_syslatency.c More and more test-cases are using this. Signed-off-by: Abdiel Janulgue --- benchmarks/gem_syslatency.c | 4 lib/igt_aux.c | 11 --- lib/igt_aux.h | 10 ++

Re: [Intel-gfx] [i-g-t PATCH v9 2/5] lib: add igt_dummyload

2016-11-21 Thread Tomeu Vizoso
On 21 November 2016 at 10:25, Abdiel Janulgue wrote: > A lot of igt testcases need some GPU workload to make sure a race > window is big enough. Unfortunately having a fixed amount of > workload leads to spurious test failures or overly long runtimes > on some

Re: [Intel-gfx] [i-g-t PATCH v7 1/5] lib: Make signal helper definitions reusable

2016-11-21 Thread Tomeu Vizoso
On 21 November 2016 at 10:25, Abdiel Janulgue wrote: > More and more test-cases are using this. > > Signed-off-by: Abdiel Janulgue > --- > lib/igt_aux.c | 11 --- > lib/igt_aux.h | 10 ++ >

Re: [Intel-gfx] [PATCH 37/37] drm/i915: Implement .get_format_info() hook for CCS

2016-11-21 Thread Ville Syrjälä
On Fri, Nov 18, 2016 at 03:31:48PM -0800, Ben Widawsky wrote: > On 16-11-18 21:53:13, Ville Syrjälä wrote: > >From: Ville Syrjälä > > > >By providing our own format information for the CCS formats, we should > >be able to make framebuffer_check() do the right thing

Re: [Intel-gfx] [PATCH 36/37] drm: Add mode_config .get_format_info() hook

2016-11-21 Thread Ville Syrjälä
On Mon, Nov 21, 2016 at 03:42:34PM +0200, Laurent Pinchart wrote: > Hi Ville, > > On Monday 21 Nov 2016 15:31:57 Ville Syrjälä wrote: > > On Mon, Nov 21, 2016 at 03:23:19PM +0200, Laurent Pinchart wrote: > > > On Monday 21 Nov 2016 15:18:23 Ville Syrjälä wrote: > > >> On Sun, Nov 20, 2016 at

Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-21 Thread Ville Syrjälä
On Fri, Nov 18, 2016 at 04:20:32PM +0200, Jani Nikula wrote: > The platform flags in device info are (mostly) mutually > exclusive. Replace the flags with an enum. Add the platform enum also > for platforms that previously didn't have a flag, and give them codename > logging in dmesg. > >

Re: [Intel-gfx] [PATCH 37/37] drm/i915: Implement .get_format_info() hook for CCS

2016-11-21 Thread Tvrtko Ursulin
On 21/11/2016 13:27, Ville Syrjälä wrote: On Mon, Nov 21, 2016 at 08:42:13AM +, Tvrtko Ursulin wrote: Hi, On 18/11/2016 19:53, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä By providing our own format information for the CCS formats, we should

Re: [Intel-gfx] [PATCH 36/37] drm: Add mode_config .get_format_info() hook

2016-11-21 Thread Laurent Pinchart
Hi Ville, On Monday 21 Nov 2016 15:31:57 Ville Syrjälä wrote: > On Mon, Nov 21, 2016 at 03:23:19PM +0200, Laurent Pinchart wrote: > > On Monday 21 Nov 2016 15:18:23 Ville Syrjälä wrote: > >> On Sun, Nov 20, 2016 at 10:13:10AM +0200, Laurent Pinchart wrote: > >>> On Friday 18 Nov 2016 21:53:12

Re: [Intel-gfx] [PATCH 36/37] drm: Add mode_config .get_format_info() hook

2016-11-21 Thread Ville Syrjälä
On Mon, Nov 21, 2016 at 03:23:19PM +0200, Laurent Pinchart wrote: > Hi Ville, > > On Monday 21 Nov 2016 15:18:23 Ville Syrjälä wrote: > > On Sun, Nov 20, 2016 at 10:13:10AM +0200, Laurent Pinchart wrote: > > > On Friday 18 Nov 2016 21:53:12 ville.syrj...@linux.intel.com wrote: > > >> From: Ville

Re: [Intel-gfx] [PATCH 37/37] drm/i915: Implement .get_format_info() hook for CCS

2016-11-21 Thread Ville Syrjälä
On Mon, Nov 21, 2016 at 08:42:13AM +, Tvrtko Ursulin wrote: > > Hi, > > On 18/11/2016 19:53, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > By providing our own format information for the CCS formats, we should > > be able to make

[Intel-gfx] [PATCH] drm/i915: Don't deref context->file_priv ERR_PTR upon reset

2016-11-21 Thread Chris Wilson
When a user context is closed, it's file_priv backpointer is replaced by ERR_PTR(-EBADF); be careful not to chase this invalid pointer after a hang and a GPU reset. Signed-off-by: Chris Wilson Fixes: b083a0870c79 ("drm/i915: Add per client max context ban limit") Cc:

Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-21 Thread Jani Nikula
On Mon, 21 Nov 2016, Tvrtko Ursulin wrote: > On 21/11/2016 09:27, Jani Nikula wrote: >> On Fri, 18 Nov 2016, Tvrtko Ursulin wrote: >>> On 18/11/2016 14:20, Jani Nikula wrote: The platform flags in device info are (mostly)

Re: [Intel-gfx] [PATCH 36/37] drm: Add mode_config .get_format_info() hook

2016-11-21 Thread Laurent Pinchart
Hi Ville, On Monday 21 Nov 2016 15:18:23 Ville Syrjälä wrote: > On Sun, Nov 20, 2016 at 10:13:10AM +0200, Laurent Pinchart wrote: > > On Friday 18 Nov 2016 21:53:12 ville.syrj...@linux.intel.com wrote: > >> From: Ville Syrjälä > >> > >> Allow drivers to return a

Re: [Intel-gfx] [PATCH 36/37] drm: Add mode_config .get_format_info() hook

2016-11-21 Thread Ville Syrjälä
On Sun, Nov 20, 2016 at 10:13:10AM +0200, Laurent Pinchart wrote: > Hi Ville, > > Thank you for the patch. > > On Friday 18 Nov 2016 21:53:12 ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Allow drivers to return a custom drm_format_info

Re: [Intel-gfx] [PATCH] drm/i915: Add more keywords to firmware loading message

2016-11-21 Thread Mika Kuoppala
Imre Deak writes: > On ke, 2016-11-16 at 11:33 +0200, Mika Kuoppala wrote: >> To find out what firmware we actually loaded (from dmesg) the explicit >> 'dmc' and 'firmware' are missing from the info printout. Add them. >> >> Cc: Imre Deak >>

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Wipe hang stats as an embedded struct

2016-11-21 Thread Mika Kuoppala
Chris Wilson writes: > On Wed, Nov 16, 2016 at 05:20:34PM +0200, Mika Kuoppala wrote: >> Bannable property, banned status, guilty and active counts are >> properties of i915_gem_context. Make them so. >> >> v2: rebase >> >> Cc: Chris Wilson

[Intel-gfx] [PATCH v2] drm/i915: Stop the machine as we install the wedged submit_request handler

2016-11-21 Thread Chris Wilson
In order to prevent a race between the old callback submitting an incomplete request and i915_gem_set_wedged() installing its nop handler, we must ensure that the swap occurs when the machine is idle (stop_machine). v2: move context lost from out of BKL. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-21 Thread Chris Wilson
On Mon, Nov 21, 2016 at 02:21:39PM +0200, David Weinehall wrote: > On Fri, Nov 18, 2016 at 01:58:35PM +, Chris Wilson wrote: > > On Fri, Nov 18, 2016 at 03:36:45PM +0200, David Weinehall wrote: > > > On resume we unbind+bind our VMA-mappings. This patch simplifies > > > this a bit by

[Intel-gfx] [PATCH v2] drm/i915: Stop the machine as we install the wedged submit_request handler

2016-11-21 Thread Chris Wilson
In order to prevent a race between the old callback submitting an incomplete request and i915_gem_set_wedged() installing its nop handler, we must ensure that the swap occurs when the machine is idle (stop_machine). v2: move context lost from out of BKL. Signed-off-by: Chris Wilson

[Intel-gfx] [i-g-t PATCH v9 1/3] igt/gem_wait: Use new igt_spin_batch

2016-11-21 Thread Abdiel Janulgue
v7: Adapt to api rename v8: Restore sanitycheck wait on the recursive batch and avoid using C99 locals (Chris Wilson) v9: Explicitly quit the batch instead of timing out right away Cc: Chris Wilson Cc: Daniel Vetter Cc: Tomeu Vizoso

Re: [Intel-gfx] [i-g-t PATCH v8 3/5] igt/gem_wait: Use new igt_spin_batch

2016-11-21 Thread Abdiel Janulgue
On 11/21/2016 01:33 PM, Tomeu Vizoso wrote: > On 21 November 2016 at 10:25, Abdiel Janulgue > wrote: >> v7: Adapt to api rename >> v8: Restore sanitycheck wait on the recursive batch and >> avoid using C99 locals (Chris Wilson) >> >> Cc: Chris Wilson

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use num_scalers instead of SKL_NUM_SCALERS in debugfs

2016-11-21 Thread Ander Conselvan De Oliveira
On Sun, 2016-11-20 at 18:16 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Use num_scalers instead of SKL_NUM_SCALERS in debugfs > URL   : https://patchwork.freedesktop.org/series/15621/ > State : success > > == Summary == > > Series 15621v1 drm/i915: Use num_scalers

[Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-21 Thread Zhi Wang
a PT page will be released if it doesn't contain any meaningful mappings during PPGTT page table shrinking. The PT entry in the upper level will be set to a scratch entry. Normally this works nicely, but in virtualization world, the PPGTT page table is tracked by hypervisor. Releasing the PT page

[Intel-gfx] [PATCH] drm/i915: Remove plane config from intel_dump_pipe_config

2016-11-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I am told the way it is done is not safe. Signed-off-by: Tvrtko Ursulin Suggested-by: Maarten Lankhorst Cc: Maarten Lankhorst Cc: Ville Syrjälä

Re: [Intel-gfx] [PATCH] drm/i915: Use num_scalers instead of SKL_NUM_SCALERS in debugfs

2016-11-21 Thread Ander Conselvan De Oliveira
On Sun, 2016-11-20 at 23:20 +0530, sunil.kam...@intel.com wrote: > From: "A.Sunil Kamath" > > Better to use num_scaler itself while printing scaler_info. > This fixes a bug of printing information for the missing > second scaler on pipe C for SKL platform. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add a warning on shutdown if signal threads still active (rev2)

2016-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Add a warning on shutdown if signal threads still active (rev2) URL : https://patchwork.freedesktop.org/series/15641/ State : success == Summary == Series 15641v2 drm/i915: Add a warning on shutdown if signal threads still active

Re: [Intel-gfx] [PATCH] drm/i915: Use user, not driver, DRM_DEBUG for 2 context ioctls

2016-11-21 Thread Joonas Lahtinen
On ma, 2016-11-21 at 11:31 +, Chris Wilson wrote: > For the context ioctls, we record a debug, but we use the > DRM_DEBUG_DRIVER for what is clearly a user, not driver, action. Use > DRM_DEBUG instead. > > Signed-off-by: Chris Wilson You could phrase the commit

Re: [Intel-gfx] [i-g-t PATCH v8 3/5] igt/gem_wait: Use new igt_spin_batch

2016-11-21 Thread Tomeu Vizoso
On 21 November 2016 at 10:25, Abdiel Janulgue wrote: > v7: Adapt to api rename > v8: Restore sanitycheck wait on the recursive batch and > avoid using C99 locals (Chris Wilson) > > Cc: Chris Wilson > Cc: Daniel Vetter

Re: [Intel-gfx] [PATCH v2 00/37] drm: Deduplicate fb format information (v2)

2016-11-21 Thread Christian König
Patches #2 and #3 are Reviewed-by: Christian König . The rest is Acked-by: Christian König . Regards, Christian. Am 18.11.2016 um 20:52 schrieb ville.syrj...@linux.intel.com: From: Ville Syrjälä Second

[Intel-gfx] [PATCH] drm/i915: Use user, not driver, DRM_DEBUG for 2 context ioctls

2016-11-21 Thread Chris Wilson
For the context ioctls, we record a debug, but we use the DRM_DEBUG_DRIVER for what is clearly a user, not driver, action. Use DRM_DEBUG instead. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_context.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Intel-gfx] [PATCH] drm/i915: Do not log disabled planes in pipe config

2016-11-21 Thread Maarten Lankhorst
Op 21-11-16 om 11:50 schreef Tvrtko Ursulin: > > On 18/11/2016 14:19, Ville Syrjälä wrote: >> On Fri, Nov 18, 2016 at 03:13:14PM +0100, Maarten Lankhorst wrote: >>> Op 18-11-16 om 12:40 schreef Tvrtko Ursulin: From: Tvrtko Ursulin It just says "plane X

[Intel-gfx] [CI] drm/i915: Add a warning on shutdown if signal threads still active

2016-11-21 Thread Chris Wilson
When unloading the module, it is expected that we have finished executing all requests and so the signal threads should be idle. Add a warning in case there are any residual requests in the signaler rbtrees at that point. v2: We can also warn if there are any waiters Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Add a warning on shutdown if signal threads still active

2016-11-21 Thread Tvrtko Ursulin
On 21/11/2016 10:48, Chris Wilson wrote: On Mon, Nov 21, 2016 at 10:42:37AM +, Tvrtko Ursulin wrote: On 21/11/2016 09:40, Chris Wilson wrote: When unloading the module, it is expected that we have finished executing all requests and so the signal threads should be idle. Add a warning in

Re: [Intel-gfx] [PATCH] drm/i915: Do not log disabled planes in pipe config

2016-11-21 Thread Tvrtko Ursulin
On 18/11/2016 14:19, Ville Syrjälä wrote: On Fri, Nov 18, 2016 at 03:13:14PM +0100, Maarten Lankhorst wrote: Op 18-11-16 om 12:40 schreef Tvrtko Ursulin: From: Tvrtko Ursulin It just says "plane X disabled" which does not seem very useful. Signed-off-by: Tvrtko

Re: [Intel-gfx] [PATCH] drm/i915: Add a warning on shutdown if signal threads still active

2016-11-21 Thread Chris Wilson
On Mon, Nov 21, 2016 at 10:42:37AM +, Tvrtko Ursulin wrote: > > On 21/11/2016 09:40, Chris Wilson wrote: > >When unloading the module, it is expected that we have finished > >executing all requests and so the signal threads should be idle. Add a > >warning in case there are any residual

  1   2   >