== Series Details ==
Series: drm/i915/skl: Do not write the replay bit of the ring mode register for
Gen 9
URL : https://patchwork.freedesktop.org/series/19875/
State : success
== Summary ==
Series 19875v1 drm/i915/skl: Do not write the replay bit of the ring mode
register for Gen 9
The reply bit of the ring mode register is only valid on Gen 8.
Therefore do not write this for Gen 9.
Signed-off-by: Kelvin Gardiner
---
drivers/gpu/drm/i915/intel_lrc.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git
On 16/02/17 06:18, Oscar Mateo wrote:
Starting with intel_guc_loader, down to intel_guc_submission
and finally to intel_guc_log.
Signed-off-by: Oscar Mateo
---
drivers/gpu/drm/i915/i915_guc_submission.c | 94 +
drivers/gpu/drm/i915/intel_guc_loader.c| 19
== Series Details ==
Series: drm/i915: Extract the in-fence from a dma-buf reservation object (rev2)
URL : https://patchwork.freedesktop.org/series/19874/
State : success
== Summary ==
Series 19874v2 drm/i915: Extract the in-fence from a dma-buf reservation object
On Fri, Feb 17, 2017 at 02:59:44PM +, Tvrtko Ursulin wrote:
>
> On 17/02/2017 11:55, Chris Wilson wrote:
> >As a backup to waiting on a user-interrupt from the GPU, we use a heavy
> >and frequent timer to wake up the waiting process should we detect an
> >inconsistency whilst waiting. After
The dma-buf holds an array of fences, which unlike the sync_file are not
sealed and may be modified at runtime. For the purpose of computing
dependencies, we can take a snapshot of the fences within the
dma-buf's reservation object (converting them into a fence-array) and
uses that as our input
== Series Details ==
Series: series starting with [1/2] dma-fence: Flag when a fence-array is using
signal-on-any
URL : https://patchwork.freedesktop.org/series/19865/
State : success
== Summary ==
Series 19865v1 Series without cover letter
The dma-buf holds an array of fences, which unlike the sync_file are not
sealed and may be modified at runtime. For the purpose of computing
dependencies, we can take a snapshot of the fences within the
dma-buf's reservation object (converting them into a fence-array) and
uses that as our input
== Series Details ==
Series: drm/i915: Assert that the request->tail is always qword aligned
URL : https://patchwork.freedesktop.org/series/19860/
State : success
== Summary ==
Series 19860v1 drm/i915: Assert that the request->tail is always qword aligned
On Fri, Feb 17, 2017 at 06:37:23PM -0200, Paulo Zanoni wrote:
> Em Sex, 2017-02-17 às 15:49 +0200, Ville Syrjälä escreveu:
> > On Fri, Feb 17, 2017 at 11:22:05AM -0200, Paulo Zanoni wrote:
> > >
> > > Each x_modeset_calc_cdclk() has to do the same platform checks
> > > twice,
> > > so extract
Em Sex, 2017-02-17 às 15:49 +0200, Ville Syrjälä escreveu:
> On Fri, Feb 17, 2017 at 11:22:05AM -0200, Paulo Zanoni wrote:
> >
> > Each x_modeset_calc_cdclk() has to do the same platform checks
> > twice,
> > so extract them to a single function. This way, the platform checks
> > are all in the
On Fri, Feb 17, 2017 at 09:04:44PM +0100, Uwe Kleine-König wrote:
> Hello Ville,
>
> On Fri, Feb 17, 2017 at 05:01:59PM +0200, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > In order to make cursor updates actually safe wrt. watermark
Hello Ville,
On Fri, Feb 17, 2017 at 05:01:59PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> In order to make cursor updates actually safe wrt. watermark programming
> we have to clear the legacy_cursor_update flag in the atomic state.
== Series Details ==
Series: drm/i915: Fix clearing of BIOS power well requests (rev2)
URL : https://patchwork.freedesktop.org/series/19699/
State : success
== Summary ==
Series 19699v2 drm/i915: Fix clearing of BIOS power well requests
== Series Details ==
Series: drm: handle override/firmware edid at the lowest level (rev2)
URL : https://patchwork.freedesktop.org/series/19764/
State : success
== Summary ==
Series 19764v2 drm: handle override/firmware edid at the lowest level
== Series Details ==
Series: series starting with [CI,1/6] drm/i915: Remove temporary allocation of
dma addresses when rotating
URL : https://patchwork.freedesktop.org/series/19852/
State : success
== Summary ==
Series 19852v1 Series without cover letter
The code currently assumes that all fence arrays it sees are the normal
signal-on-all variety, and decomposes the array into its individual
fences so that it can extract the native i915 fences. If the fence array
is using signal-on-any, we should not decompose as we must not wait on
them all, just
Indicate that the fence array will be signaled on the first completion
(signal-on-any mode) as opposed to waiting for all to be signaled.
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Gustavo Padovan
Cc: Daniel Vetter
== Series Details ==
Series: drm/i915: Remove temporary allocation of dma addresses when rotating
(rev2)
URL : https://patchwork.freedesktop.org/series/19850/
State : success
== Summary ==
Series 19850v2 drm/i915: Remove temporary allocation of dma addresses when
rotating
On Tue, Feb 07, 2017 at 10:12:38PM +, Srivatsa, Anusha wrote:
> Hi,
>
> Please consider pulling i915 updates to linux-firmware.git.
>
> The following changes since commit 6d3bc8886517d171068fd1263176b8b5c51df204:
>
> Fix permissions on ti-connectivity firmware from 05e9fe59 (2017-01-13
>
If there's no primary plane, pipe->plane_primary == -1, and the assert
meant to check that it's valid will access pipe->planes[-1].
Fix that to check that pipe->plane_primary has been set instead.
Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support
Signed-off-by: Brian Starkey
The dynamic plane support means that if there's no cursor plane, then
there is no space in the pipe->planes array for it, and thus assigning
a "drm_plane-less" plane is out-of-bounds and leads to heap corruption
and later crashes.
The "drm_plane-less" cursor plane isn't included in n_planes
The dynamic plane support means that there should never be gaps in the
pipe->planes array. This means we should never need to move the cursor
plane from the last slot to another.
Remove the unnecessary code, and add an assert that makes sure nothing
strange happened that broke the assignment
In the loop looking for planes on a pipe, we always want to free up
the drm_plane afterwards.
Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support
Signed-off-by: Brian Starkey
---
Hi,
This series cleans up igt_display_init a bit.
- Fixes a memory
Remove a bunch of branches, functionally equivalent.
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 34 ++
1 file changed, 10 insertions(+), 24 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 4ca9145726e2..783c891aebf1
== Series Details ==
Series: drm/i915: reduce cursor size for GEN5 hardware (rev4)
URL : https://patchwork.freedesktop.org/series/18822/
State : success
== Summary ==
Series 18822v4 drm/i915: reduce cursor size for GEN5 hardware
== Series Details ==
Series: drm/i915: Only apply legacy PDE overflow detection to 3lvl machines
(rev2)
URL : https://patchwork.freedesktop.org/series/19845/
State : success
== Summary ==
Series 19845v2 drm/i915: Only apply legacy PDE overflow detection to 3lvl
machines
== Series Details ==
Series: series starting with [1/2] drm/i915: Skip clflushes for all non-page
backed objects
URL : https://patchwork.freedesktop.org/series/19846/
State : failure
== Summary ==
Series 19846v1 Series without cover letter
The hardware requires that the tail pointer only advance in qword units,
so assert that the value we write is aligned to qwords, and similarly
enforce this restriction onto the request->tail.
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
Cc:
On Fri, Feb 17, 2017 at 04:28:13PM +, Tvrtko Ursulin wrote:
>
> On 17/02/2017 15:12, Chris Wilson wrote:
> >The object already stores (computed on the fly) the index to dma address
> >so use it instead of reallocating a large temporary array every time we
> >bind a rotated framebuffer.
>
>
Reviewed-by: Daniele Ceraolo Spurio
On 16/02/17 06:31, Oscar Mateo wrote:
I guess no one has needed to change the verbosity level of the GuC logs.
Signed-off-by: Oscar Mateo
---
tools/intel_guc_logger.c | 2 +-
1 file changed, 1
On 17/02/2017 15:12, Chris Wilson wrote:
The object already stores (computed on the fly) the index to dma address
so use it instead of reallocating a large temporary array every time we
bind a rotated framebuffer.
On the other hand how big is the radix tree for a large framebuffer? I
A significant cost in setting up a wait is the overhead of enabling the
interrupt. As we disable the interrupt whenever the queue of waiters is
empty, if we are frequently waiting on alternating batches, we end up
re-enabling the interrupt on a frequent basis. We do want to disable the
interrupt
As execlists and other non-semaphore multi-engine devices coordinate
between engines using interrupts, we can shave off a few 10s of
microsecond of scheduling latency by doing the fence signaling from the
interrupt as opposed to a RT kthread. (Realistically the delay adds
about 1% to an individual
Atm, in the power well sync_hw hook we are clearing all BIOS request
bits, not just the one corresponding to the given power well. This could
turn off an unrelated power well inadvertently if it didn't have a
request bit set in the driver request register.
This didn't cause a problem so far,
This is v2 of [1], addressing Ander's comments.
[1]
https://lists.freedesktop.org/archives/intel-gfx/2017-February/120006.html
Cc: Ander Conselvan de Oliveira
Cc: David Weinehall
Cc: Ville Syrjälä
Imre Deak
Atm, power wells that BIOS has enabled, but which we don't explicitly
enable during power domain initialization would get disabled as we clear
the BIOS request bit in the given power well sync_hw hook. To prevent
this copy over any set request bits in the BIOS request register to the
driver
So far the sync_hw hook wasn't called for power wells not belonging to
any power domain, that is the GEN9 PW1 and MISC_IO power wells. This
wasn't a problem so far since the goal of the sync_hw hook - to clear
the corresponding BIOS request bit - was guaranteed by clearing the
whole BIOS request
Verify that the refcount of all power wells match their HW enabled
state at the end of modeset HW state readout.
Also add documentation on how the reference count for each power well is
supposed to be acquired during initialization and HW state readout.
Suggested by Ander.
Cc: Ander Conselvan
Doing an explicit enable/disable in the power well sync_hw hook based on
the power well's reference count is redundant, since by the time these
hooks are called all the power wells are enabled and have a reference.
So remove the redundant toggling.
This is needed by a follow-up patchset that adds
On 2/17/2017 at 2:30 PM, "Jani Nikula" wrote:
>
>On Fri, 17 Feb 2017, Eric Johansson
>wrote:
>> Hello,
>>
>> I have an HP EliteOne 800 G2 AiO which according to "lspci -v"
>has a
>> Intel Corporation Sky Lake Integrated Graphics (rev 06). I
On Fri, Feb 17, 2017 at 05:20:50PM +0200, Jani Nikula wrote:
> v2 of cover.1487241304.git.jani.nikula@intel.com">http://mid.mail-archive.com/cover.1487241304.git.jani.nikula@intel.com
lgtm. For the series
Reviewed-by: Ville Syrjälä
--
Ville Syrjälä
Intel OTC
igt_pipe_crc_new() is skipped for non-Intel devices, but the later calls
to collect_crcs_mask() will attempt to retrieve CRC values if the
pipe_crcs pointers are non-NULL.
Zero-initialise pipe_crcs to avoid accessing garbage pointers on
non-Intel devices.
Signed-off-by: Brian Starkey
On Fri, Feb 17, 2017 at 01:17:22PM -0200, Paulo Zanoni wrote:
> Em Sex, 2017-02-17 às 16:05 +0200, Ville Syrjälä escreveu:
> > On Fri, Feb 17, 2017 at 11:22:07AM -0200, Paulo Zanoni wrote:
> > >
> > > Possible problems of the current if-ladder:
> > > - It's a huge if ladder with almost a
== Series Details ==
Series: Small clocking code refactor
URL : https://patchwork.freedesktop.org/series/19840/
State : success
== Summary ==
Series 19840v1 Small clocking code refactor
https://patchwork.freedesktop.org/api/1.0/series/19840/revisions/1/mbox/
fi-bdw-5557u total:252
Skip DDC probe for forced connector status. Don't try to read the EDID
if the connector is forced off. Skipping probe for forced on connectors
will make more sense when drm_do_get_edid() will handle override and
firmware EDIDs.
Suggested-by: Ville Syrjälä
Make the firmware loader more generic and generally useful.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid_load.c| 17 -
drivers/gpu/drm/drm_probe_helper.c | 8 +++-
include/drm/drm_edid.h | 7 ---
3 files changed, 15
Handle debugfs override edid and firmware edid at the low level to
transparently and completely replace the real edid. Previously, we
practically only used the modes from the override EDID, and none of the
other data. This also prevents actual EDID reads when the EDID is to be
overridden, but
Make the drm_edid_to_eld() function useful for resetting, not just
setting, the ELD and HDMI VSDB data, without debug warnings about
missing CEA extensions.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
v2 of cover.1487241304.git.jani.nikula@intel.com">http://mid.mail-archive.com/cover.1487241304.git.jani.nikula@intel.com
BR,
Jani.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Em Sex, 2017-02-17 às 16:05 +0200, Ville Syrjälä escreveu:
> On Fri, Feb 17, 2017 at 11:22:07AM -0200, Paulo Zanoni wrote:
> >
> > Possible problems of the current if-ladder:
> > - It's a huge if ladder with almost a different check for each of
> > our platforms.
> > - It mixes 3
On Fri, 2017-02-17 at 14:06 +0200, Ander Conselvan de Oliveira wrote:
> Now that the pre-csc degamma table is set up correctly in Geminilake,
> pipe CSC can be enabled without causing a black screen.
>
> v2: Rebase.
> Signed-off-by: Ander Conselvan de Oliveira
>
When the timer expires for checking on interrupt processing, check to
see if any interrupts arrived within the last time period. If real
interrupts are still being delivered, we can be reassured that we
haven't missed the final interrupt as the waiter will still be woken.
Only once all activity
The object already stores (computed on the fly) the index to dma address
so use it instead of reallocating a large temporary array every time we
bind a rotated framebuffer.
Signed-off-by: Chris Wilson
Cc: Matthew Auld
Cc: Joonas Lahtinen
If an interrupt has been posted, and we were spinning on the active
seqno waiting for it to advance but it did not, then we can expect that
it will not see its advance in the immediate future and should call into
the irq-seqno barrier. We can stop spinning at this point, and leave the
difficulty
If we wait upon the full (i.e. all shared fences, or upon an exclusive fence)
reservation object successfully, we know that all fences beneath it have
been signaled, so long as no new fences were added whilst we slept. If the
reservation_object remains the same, as detected by its seqcount, we can
As a backup to waiting on a user-interrupt from the GPU, we use a heavy
and frequent timer to wake up the waiting process should we detect an
inconsistency whilst waiting. After seeing a "missed interrupt", the
next time we wait, we restart the heavy timer. This patch is more
reluctant to restart
If the waiter was currently running, assume it hasn't had a chance
to process the pending interupt (e.g, low priority task on a loaded
system) and wait until it sleeps before declaring a missed interrupt.
References: https://bugs.freedesktop.org/show_bug.cgi?id=99816
Signed-off-by: Chris Wilson
The object already stores (computed on the fly) the index to dma address
so use it instead of reallocating a large temporary array every time we
bind a rotated framebuffer.
Signed-off-by: Chris Wilson
Cc: Matthew Auld
Cc: Joonas Lahtinen
The object already stores (computed on the fly) the index to dma address
so use it instead of reallocating a large temporary array every time we
bind a rotated framebuffer.
Signed-off-by: Chris Wilson
Cc: Matthew Auld
Cc: Joonas Lahtinen
On 17/02/2017 11:55, Chris Wilson wrote:
As a backup to waiting on a user-interrupt from the GPU, we use a heavy
and frequent timer to wake up the waiting process should we detect an
inconsistency whilst waiting. After seeing a "missed interrupt", the
next time we wait, we restart the heavy
From: Ville Syrjälä
In order to make cursor updates actually safe wrt. watermark programming
we have to clear the legacy_cursor_update flag in the atomic state. That
will cause the regular atomic update path to do the necessary vblank
wait after the plane update if
On 17/02/2017 14:41, Chris Wilson wrote:
On Fri, Feb 17, 2017 at 02:26:04PM +, Tvrtko Ursulin wrote:
On 14/02/2017 09:54, Chris Wilson wrote:
@@ -1036,12 +1011,11 @@ long i915_wait_request(struct drm_i915_gem_request *req,
if (flags & I915_WAIT_LOCKED)
== Series Details ==
Series: GuC Scrub vol. 1 (rev3)
URL : https://patchwork.freedesktop.org/series/16856/
State : success
== Summary ==
Series 16856v3 GuC Scrub vol. 1
https://patchwork.freedesktop.org/api/1.0/series/16856/revisions/3/mbox/
fi-bdw-5557u total:252 pass:241 dwarn:0
On 14/02/2017 09:54, Chris Wilson wrote:
A request is assigned a global seqno only when it is on the hardware
execution queue. The global seqno can be used to maintain a list of
requests on the same engine in retirement order, for example for
constructing a priority queue for waiting. Prior to
On Fri, Feb 17, 2017 at 02:26:04PM +, Tvrtko Ursulin wrote:
>
> On 14/02/2017 09:54, Chris Wilson wrote:
> >@@ -1036,12 +1011,11 @@ long i915_wait_request(struct drm_i915_gem_request
> >*req,
> > if (flags & I915_WAIT_LOCKED)
> > add_wait_queue(errq, );
> >
> >-if
On Fri, Feb 17, 2017 at 02:05:57PM +0100, Arkadiusz Hiler wrote:
Typo in subject s/firwmare/firmware
> Currently fw->path values can represent one of three possible states:
>
> 1) NULL - device without the uC
> 2) '\0' - device with the uC but have no firmware
> 3) else - device with the uC
On 14/02/2017 09:54, Chris Wilson wrote:
On reflection, we are only using the execute fence as a waitqueue on the
global_seqno and not using it for dependency tracking between fences
(unlike the submit and dma fences). By only treating it as a waitqueue,
we can then treat it similar to the
== Series Details ==
Series: GLK MIPI DSI VIDEO MODE PATCHES (rev6)
URL : https://patchwork.freedesktop.org/series/16542/
State : failure
== Summary ==
Series 16542v6 GLK MIPI DSI VIDEO MODE PATCHES
https://patchwork.freedesktop.org/api/1.0/series/16542/revisions/6/mbox/
Test gem_exec_basic:
Prevent the overflow check from firing on machines with the full 4lvl
page tables, that are not restricted to GEN8_LEGACY_PDES.
v2: Also fix the off-by-one in the compare
Fixes: 894ccebee2b0 ("drm/i915: Micro-optimise gen8_ppgtt_insert_entries()")
Signed-off-by: Chris Wilson
On Fri, Feb 17, 2017 at 04:07:50PM +0200, Ville Syrjälä wrote:
> On Fri, Feb 17, 2017 at 01:59:09PM +, Chris Wilson wrote:
> > Prevent the overflow check from firing on machines with the full 4lvl
> > page tables, that are not restricted to GEN8_LEGACY_PDES.
> >
> > Fixes: 894ccebee2b0
On Fri, Feb 17, 2017 at 01:59:09PM +, Chris Wilson wrote:
> Prevent the overflow check from firing on machines with the full 4lvl
> page tables, that are not restricted to GEN8_LEGACY_PDES.
>
> Fixes: 894ccebee2b0 ("drm/i915: Micro-optimise gen8_ppgtt_insert_entries()")
> Signed-off-by: Chris
Generalise the skip for physical and stolen objects by skipping anything
we do not have a valid address inside the sg.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
Flushing the cachelines for an object is slow, can be as much as 100ms
for a large framebuffer. We currently do this under the struct_mutex BKL
on execution or on pageflip. But now with the ability to add fences to
obj->resv for both flips and execbuf (and we naturally wait on the fence
before CPU
On Fri, Feb 17, 2017 at 04:02:02PM +0200, Jani Nikula wrote:
> On Thu, 16 Feb 2017, Ville Syrjälä wrote:
> > On Thu, Feb 16, 2017 at 12:36:43PM +0200, Jani Nikula wrote:
> >> Make the function useful for resetting, not just setting, the ELD.
> >>
> >>
On Fri, Feb 17, 2017 at 11:22:07AM -0200, Paulo Zanoni wrote:
> Possible problems of the current if-ladder:
> - It's a huge if ladder with almost a different check for each of
> our platforms.
> - It mixes 3 different types of checks: IS_GENX, IS_PLATFORM and
> IS_GROUP_OF_PLATFORMS.
>
On 14/02/2017 09:54, Chris Wilson wrote:
It had only one callsite and existed to keep the code clearer. Now
having shared the wait-on-error between phases and with plans to change
the wait-for-execute in the next few patches, remove the out of line
wait loop and move it into the main body of
On Fri, Feb 17, 2017 at 02:05:56PM +0100, Arkadiusz Hiler wrote:
> Current version of intel_guc_init_hw() does a lot:
> - cares about submission
> - loads huc
> - implement WA
>
> This change offloads some of the logic to intel_uc_load(), which now
> cares about the above.
>
> v2: rename
On Thu, 16 Feb 2017, Ville Syrjälä wrote:
> On Thu, Feb 16, 2017 at 12:36:43PM +0200, Jani Nikula wrote:
>> Make the function useful for resetting, not just setting, the ELD.
>>
>> Signed-off-by: Jani Nikula
>> ---
>>
Prevent the overflow check from firing on machines with the full 4lvl
page tables, that are not restricted to GEN8_LEGACY_PDES.
Fixes: 894ccebee2b0 ("drm/i915: Micro-optimise gen8_ppgtt_insert_entries()")
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
On Fri, Feb 17, 2017 at 02:05:55PM +0100, Arkadiusz Hiler wrote:
> Let intel_guc_fetch_fw() focus on determining and fetching the correct
> firmware.
>
> This patch introduces intel_sanitize_uc_params() that is called from
> intel_sanitize_options().
Function name mentioned here does not match
== Series Details ==
Series: Geminilake pipe CSC (rev4)
URL : https://patchwork.freedesktop.org/series/18596/
State : success
== Summary ==
Series 18596v4 Geminilake pipe CSC
https://patchwork.freedesktop.org/api/1.0/series/18596/revisions/4/mbox/
fi-bdw-5557u total:252 pass:241
On Fri, Feb 17, 2017 at 11:22:04AM -0200, Paulo Zanoni wrote:
> The functions are pretty much the same, except for the CDCLK and VCO
> calculations. Add BDW support to vlv_modeset_calc_cdclk() and add
> BXT/GLK support to skl_modeset_calc_cdclk(). The two reamining
> functions are still very
On Fri, Feb 17, 2017 at 11:22:05AM -0200, Paulo Zanoni wrote:
> Each x_modeset_calc_cdclk() has to do the same platform checks twice,
> so extract them to a single function. This way, the platform checks
> are all in the same place, and the platform-common code gets rid of
> all the
On 12 February 2017 at 21:53, Chris Wilson wrote:
> If we wait up on the full (i.e. all shared fences, or upon an exclusive fence)
s/up on/upon
> reservation object successfully, we know that all fences beneath it have
> been signaled, so long as no new fences were
On Fri, Feb 17, 2017 at 02:05:54PM +0100, Arkadiusz Hiler wrote:
> intel_uc_fw_fetch() is confusingly named in the light of recent changes.
>
> It's also in the worng place - 'guc_loader.h' - it's used for both guc
Typo s/worng/wrong
> and huc, which was reflected in name, but not it's
We need to make sure that TEST_ONLY really only touches the free-standing
state objects and nothing else. Test approach here is the following:
- Create a config and submit it with TEST_ONLY.
- do dpms off/on cycle with the current config to reconfigure hw
- read back all legacy state to make sure
On Fri, Feb 17, 2017 at 02:05:53PM +0100, Arkadiusz Hiler wrote:
> Trying to have subject_verb_object ordering and more descriptive names,
> the intel_huc_init() and intel_guc_init() functions are renamed:
>
> * `intel_guc` is the subject, so those functions now take intel_guc
>structure,
On Fri, 17 Feb 2017, Eric Johansson wrote:
> Hello,
>
> I have an HP EliteOne 800 G2 AiO which according to "lspci -v" has a
> Intel Corporation Sky Lake Integrated Graphics (rev 06). I have
> previously installed Ubuntu 16.04.1 LTS with kernel 4.4 on the
> computer and
Hi
I've been trying to understand the clocking code and spotted some
possible improvements. None of these changes are actually necessary
for anything, but IMHO they make the code a little easier to read and
later extend. Feel free to bikeshed or even NAK my proposals.
Thanks,
Paulo
Paulo Zanoni
Each x_modeset_calc_cdclk() has to do the same platform checks twice,
so extract them to a single function. This way, the platform checks
are all in the same place, and the platform-common code gets rid of
all the platform-specific checks, which IMHO makes the code easier to
read.
Signed-off-by:
The IS_G4X macro is defined as IS_G45 || IS_GM45. We have two points
in our code where we have an if statement checking for GM45 followed
by an else if statement checking for IS_G4X. This can be confusing
since the IS_G4X check won't be catching the previously-checked GM45.
Someone quickly trying
Possible problems of the current if-ladder:
- It's a huge if ladder with almost a different check for each of
our platforms.
- It mixes 3 different types of checks: IS_GENX, IS_PLATFORM and
IS_GROUP_OF_PLATFORMS.
- As demonstrated by the recent IS_G4X commit, it's not easy to be
The functions are pretty much the same, except for the CDCLK and VCO
calculations. Add BDW support to vlv_modeset_calc_cdclk() and add
BXT/GLK support to skl_modeset_calc_cdclk(). The two reamining
functions are still very similar, except for the fact that the vlv
version doesn't touch the VCO.
On Fri, Feb 17, 2017 at 02:05:52PM +0100, Arkadiusz Hiler wrote:
> Used to obtain "dev_priv" from huc struct pointer.
> We already have similar thing for guc.
>
> Cc: Michal Wajdeczko
> Signed-off-by: Arkadiusz Hiler
Reviewed-by: Michal
On Fri, Feb 17, 2017 at 02:05:51PM +0100, Arkadiusz Hiler wrote:
I think one line with description will not kill us ;)
Reviewed-by: Michal Wajdeczko
> Cc: Michal Wajdeczko
> Signed-off-by: Arkadiusz Hiler
>
On Fri, Feb 17, 2017 at 02:05:50PM +0100, Arkadiusz Hiler wrote:
> GuC historically has two "startup" functions called _init() and _setup()
>
> Then HuC came with it's _init() and _load().
>
> This commit renames intel_guc_setup() and intel_huc_load() to
> *uc_init_hw() as they called from the
Current version of intel_guc_init_hw() does a lot:
- cares about submission
- loads huc
- implement WA
This change offloads some of the logic to intel_uc_load(), which now
cares about the above.
v2: rename guc_hw_reset and fix typo in define name (M. Wajdeczko)
Cc: Anusha Srivatsa
Currently fw->path values can represent one of three possible states:
1) NULL - device without the uC
2) '\0' - device with the uC but have no firmware
3) else - device with the uC and we have firmware
Second case is used only to WARN at a later stage.
We can WARN right away and merge cases
intel_uc_fw_fetch() is confusingly named in the light of recent changes.
It's also in the worng place - 'guc_loader.h' - it's used for both guc
and huc, which was reflected in name, but not it's location, so let's
move it to 'intel_uc.c'.
We can make a intel_uc_fw callback out of it, to avoid
1 - 100 of 158 matches
Mail list logo