Re: [Intel-gfx] [PATCH 00/20] ICELAKE DSI DRIVER

2018-06-26 Thread Chauhan, Madhav
> -Original Message- > From: Chauhan, Madhav > Sent: Friday, June 15, 2018 3:51 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; Zanoni, Paulo R > ; Shankar, Uma ; Vivi, > Rodrigo ; Chauhan, Madhav > > Subject: [PATCH 00/20] ICELAKE DSI DRIVER > > From ICELAKE platform onward

Re: [Intel-gfx] [PATCH] ALSA: hda - Handle pm failure during hotplug

2018-06-26 Thread Takashi Iwai
On Wed, 27 Jun 2018 08:25:32 +0200, Chris Wilson wrote: > > Obtaining the runtime pm wakeref can fail, especially in a hotplug > scenario where i915.ko has been unloaded. If we do not catch the > failure, we end up with an unbalanced pm. > > References: 222bde03881c ("ALSA: hda - Fix mutex deadlo

[Intel-gfx] [PATCH] ALSA: hda - Handle pm failure during hotplug

2018-06-26 Thread Chris Wilson
Obtaining the runtime pm wakeref can fail, especially in a hotplug scenario where i915.ko has been unloaded. If we do not catch the failure, we end up with an unbalanced pm. References: 222bde03881c ("ALSA: hda - Fix mutex deadlock at HDMI/DP hotplug") Signed-off-by: Chris Wilson Cc: Ville Syrjäl

Re: [Intel-gfx] [PATCH] drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Lucas De Marchi
On Tue, Jun 26, 2018 at 1:56 PM Anusha Srivatsa wrote: > > This patch addresses Interrupts from south display engine (SDE). > > ICP has two registers - SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC. > Introduce these registers and their intended values. > > Introduce icp_irq_handler(). > > The icp_irq_post

Re: [Intel-gfx] [PATCH v7 1/5] drm/i915/psr: Remove intel_crtc_state parameter from disable_source()

2018-06-26 Thread Dhinakaran Pandiyan
On Tue, 2018-06-26 at 13:16 -0700, José Roberto de Souza wrote: > It was only used in VLV/CHV so after the removal of the PSR support > for those platforms it is not necessary any more. > > v7: Rebased > Pushed this to -dinq, thanks for your patience. > Reviewed-by: Dhinakaran Pandiyan > Cc: Ro

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915/icp: Add Interrupt Support URL : https://patchwork.freedesktop.org/series/45443/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382_full -> Patchwork_9432_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_943

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix assert_plane() warning on bootup with external display (rev4)

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Fix assert_plane() warning on bootup with external display (rev4) URL : https://patchwork.freedesktop.org/series/44909/ State : failure == Summary == CALLscripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] driv

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: mark expected switch fall-through (rev2)

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915: mark expected switch fall-through (rev2) URL : https://patchwork.freedesktop.org/series/45088/ State : failure == Summary == Applying: drm/i915: mark expected switch fall-through error: patch failed: drivers/gpu/drm/i915/i915_utils.h:40 error: drivers/gpu

[Intel-gfx] [PATCH v4] drm/i915: Fix assert_plane() warning on bootup with external display

2018-06-26 Thread Azhar Shaikh
On KBL, WHL RVPs, booting up with an external display connected, triggers below warning, when the BiOS brings up the external display too. This warning is not seen during hotplug. [3.615226] [ cut here ] [3.619829] plane 1A assertion failure (expected on, current of

Re: [Intel-gfx] [PATCH] drm/i915: mark expected switch fall-through

2018-06-26 Thread Gustavo A. R. Silva
Hi Jani, On 06/21/2018 03:03 AM, Jani Nikula wrote: > On Wed, 20 Jun 2018, "Gustavo A. R. Silva" wrote: >> On 06/20/2018 02:06 PM, Rodrigo Vivi wrote: >>> On Wed, Jun 20, 2018 at 08:31:00AM -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/atomic-helper: Use old/new state in drm_atomic_helper_commit_planes_on_crtc()

2018-06-26 Thread Patchwork
== Series Details == Series: drm/atomic-helper: Use old/new state in drm_atomic_helper_commit_planes_on_crtc() URL : https://patchwork.freedesktop.org/series/45440/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382_full -> Patchwork_9431_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH] drm/i915/icl: Add power well support

2018-06-26 Thread Paulo Zanoni
Em Ter, 2018-06-26 às 17:22 +0300, Imre Deak escreveu: > Add the definition for ICL power wells and their mapping to power > domains. On ICL there are 3 power well control registers, we'll > select > the correct one based on higher bits of the power well ID. The offset > for the control and status

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v7,1/5] drm/i915/psr: Remove intel_crtc_state parameter from disable_source()

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [v7,1/5] drm/i915/psr: Remove intel_crtc_state parameter from disable_source() URL : https://patchwork.freedesktop.org/series/45436/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382_full -> Patchwork_9430_full = == Summar

Re: [Intel-gfx] [PATCH] drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Paulo Zanoni
Em Ter, 2018-06-26 às 13:52 -0700, Anusha Srivatsa escreveu: > This patch addresses Interrupts from south display engine (SDE). > > ICP has two registers - SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC. > Introduce these registers and their intended values. > > Introduce icp_irq_handler(). > > The icp_ir

Re: [Intel-gfx] [PATCH 09/10] drm/vc4: Use drm_crtc_mask()

2018-06-26 Thread Eric Anholt
Ville Syrjala writes: > From: Ville Syrjälä > > Use drm_crtc_mask() where appropriate. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailma

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/10] drm: Add drm_plane_mask()

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm: Add drm_plane_mask() URL : https://patchwork.freedesktop.org/series/45433/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382_full -> Patchwork_9429_full = == Summary - WARNING == Minor unknown changes coming

Re: [Intel-gfx] [RFC][PATCH] Makefile: globally enable VLA warning

2018-06-26 Thread Kees Cook
On Tue, Jun 26, 2018 at 1:21 PM, Joe Perches wrote: > On Tue, 2018-06-26 at 10:40 -0700, Kees Cook wrote: >> This is the patch I've got prepared now that fixes for all VLAs have been >> sent to maintainers (some are still under review/adjustment, but there >> aren't any unexplored cases left). My

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915/icp: Add Interrupt Support URL : https://patchwork.freedesktop.org/series/45443/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382 -> Patchwork_9432 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic-helper: Use old/new state in drm_atomic_helper_commit_planes_on_crtc()

2018-06-26 Thread Patchwork
== Series Details == Series: drm/atomic-helper: Use old/new state in drm_atomic_helper_commit_planes_on_crtc() URL : https://patchwork.freedesktop.org/series/45440/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382 -> Patchwork_9431 = == Summary - SUCCESS == No regress

[Intel-gfx] [PATCH] drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Anusha Srivatsa
This patch addresses Interrupts from south display engine (SDE). ICP has two registers - SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC. Introduce these registers and their intended values. Introduce icp_irq_handler(). The icp_irq_postinstall() takes care of enabling all PCH interrupt sources, to unmask t

Re: [Intel-gfx] [PATCH 6/8] drm/nouveau: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread kbuild test robot
Hi Ville, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on v4.18-rc2 next-20180626] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v7,1/5] drm/i915/psr: Remove intel_crtc_state parameter from disable_source()

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [v7,1/5] drm/i915/psr: Remove intel_crtc_state parameter from disable_source() URL : https://patchwork.freedesktop.org/series/45436/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382 -> Patchwork_9430 = == Summary - SUCCES

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Second attempt at fixing the fb-helper .best_encoder() mess

2018-06-26 Thread Patchwork
== Series Details == Series: drm: Second attempt at fixing the fb-helper .best_encoder() mess URL : https://patchwork.freedesktop.org/series/45422/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4381_full -> Patchwork_9428_full = == Summary - WARNING == Minor unknown chan

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix assert_plane() warning on bootup with external display

2018-06-26 Thread Shaikh, Azhar
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Tuesday, June 26, 2018 6:01 AM >To: Shaikh, Azhar >Cc: intel-gfx@lists.freedesktop.org; Navare, Manasi D > >Subject: Re: [PATCH v2] drm/i915: Fix assert_plane() warning on bootup with >external display

[Intel-gfx] [PATCH] drm/atomic-helper: Use old/new state in drm_atomic_helper_commit_planes_on_crtc()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Update drm_atomic_helper_commit_planes_on_crtc() to use explicit old/new states instead of relying on obj->state. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic_helper.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/driver

Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/psr: Lockless version of psr_wait_for_idle

2018-06-26 Thread Tarun Vyas
On Tue, Jun 26, 2018 at 09:42:11AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2018-06-26 09:26:57) > > On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote: > > > This is a lockless version of the exisiting psr_wait_for_idle(). > > > We want to wait for PSR to idle out inside intel_p

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/10] drm: Add drm_plane_mask()

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm: Add drm_plane_mask() URL : https://patchwork.freedesktop.org/series/45433/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382 -> Patchwork_9429 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [RFC][PATCH] Makefile: globally enable VLA warning

2018-06-26 Thread Joe Perches
On Tue, 2018-06-26 at 10:40 -0700, Kees Cook wrote: > This is the patch I've got prepared now that fixes for all VLAs have been > sent to maintainers (some are still under review/adjustment, but there > aren't any unexplored cases left). My intention would be to have this land > at the end of the n

Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/psr: Lockless version of psr_wait_for_idle

2018-06-26 Thread Tarun Vyas
On Tue, Jun 26, 2018 at 12:43:42PM -0700, Dhinakaran Pandiyan wrote: > On Tue, 2018-06-26 at 10:26 +0200, Daniel Vetter wrote: > > On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote: > > > > > > This is a lockless version of the exisiting psr_wait_for_idle(). > > > We want to wait for PSR

[Intel-gfx] [PATCH v7 2/5] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

2018-06-26 Thread José Roberto de Souza
eDP spec states that sink device will do a short pulse in HPD line when there is a PSR/PSR2 error that needs to be handled by source, this is handling the first and most simples error: DP_PSR_SINK_INTERNAL_ERROR. Here taking the safest approach and disabling PSR(at least until the next modeset), t

[Intel-gfx] [PATCH v7 5/5] drm/i915/psr: Enable CRC check in the static frame on the sink side

2018-06-26 Thread José Roberto de Souza
Sink can be configured to calculate the CRC over the static frame and compare with the CRC calculated and transmited in the VSC SDP by source, if there is a mismatch sink will do a short pulse in HPD and set DP_PSR_LINK_CRC_ERROR in DP_PSR_ERROR_STATUS. Spec: 7723 v6: andling DP_PSR_LINK_CRC_ERRO

[Intel-gfx] [PATCH v7 3/5] drm/i915/psr: Handle PSR errors

2018-06-26 Thread José Roberto de Souza
Sink will interrupt source when it have any PSR error. DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR is a PSR2 but already handling it here. The only missing error to be handled is DP_PSR_LINK_CRC_ERROR that will be taken in care in a futher patch. v6: not handling DP_PSR_LINK_CRC_ERROR here v5: handling al

[Intel-gfx] [PATCH v7 4/5] drm/i915/psr: Avoid PSR exit max time timeout

2018-06-26 Thread José Roberto de Souza
Specification requires that max time should be masked from bdw and forward but it can be also safely enabled to hsw. This will make PSR exits more deterministic and only when really needed. If this was used to fix a issue in some panel than can only self-refresh for a few seconds, that panel will i

[Intel-gfx] [PATCH v7 1/5] drm/i915/psr: Remove intel_crtc_state parameter from disable_source()

2018-06-26 Thread José Roberto de Souza
It was only used in VLV/CHV so after the removal of the PSR support for those platforms it is not necessary any more. v7: Rebased Reviewed-by: Dhinakaran Pandiyan Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_psr.c | 5 ++--- 1 file changed, 2 insertions

Re: [Intel-gfx] [PATCH 10/10] drm/vmwgfx: Use drm_plane_mask() & co.

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:16PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_{plane,connector}_mask() where appropriate. > > Cc: VMware Graphics > Cc: Sinclair Yeh > Cc: Thomas Hellstrom > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 09/10] drm/vc4: Use drm_crtc_mask()

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:15PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_crtc_mask() where appropriate. > > Cc: Eric Anholt > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [Intel-gfx] [PATCH 08/10] drm/sun4i: Use drm_crtc_mask()

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:14PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_crtc_mask() where appropriate. > > Cc: Maxime Ripard > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/sun4i/sun4i_crtc.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_lv

Re: [Intel-gfx] [PATCH 07/10] drm/rockchip: Use drm_crtc_mask()

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:13PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_crtc_mask() where appropriate. > > Cc: Sandy Huang > Cc: "Heiko Stübner" > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- >

Re: [Intel-gfx] [PATCH 06/10] drm/imx: Use drm_plane_mask()

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:12PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_plane_mask() where appropriate. > > Cc: Philipp Zabel > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/imx/ipuv3-crtc.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Use drm_plane_mask() & co.

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:11PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_{plane,crtc,encoder,connector}_mask() where appropriate. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_display.c | 14 +++--- > drivers/g

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm: Add drm_plane_mask()

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm: Add drm_plane_mask() URL : https://patchwork.freedesktop.org/series/45433/ State : warning == Summary == $ dim checkpatch origin/drm-tip cf6d660dc7b3 drm: Add drm_plane_mask() -:115: WARNING:SPACING: space prohibited between functi

Re: [Intel-gfx] [PATCH 04/10] drm: Add drm_connector_mask()

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:10PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add drm_connector_mask() which returns the 1< We already have an identical drm_crtc_mask() for crtcs. > > Mostly performed with coccinelle: > @@ > @@ > - (1< + drm_connector_mask( > ...) > - ) > > @@ > @

Re: [Intel-gfx] [PATCH 03/10] drm: Add drm_encoder_mask()

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:09PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add drm_encoder_mask() which returns the 1< We already have an identical drm_crtc_mask() for crtcs. > > Mostly performed with coccinelle: > @@ > @@ > - (1< + drm_encoder_mask( > ...) > - ) > > @@ > @@ >

Re: [Intel-gfx] [PATCH 02/10] drm: Use drm_crtc_mask()

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:08PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_crtc_mask() where appropriate. > > Mostly performed with coccinelle: > @@ > @@ > - (1< + drm_crtc_mask( > ...) > - ) > > @@ > @@ > - 1< + drm_crtc_mask( > ...) > > @@ > @@ > - BIT(drm_crtc_ind

Re: [Intel-gfx] [PATCH 01/10] drm: Add drm_plane_mask()

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:07PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add drm_plane_mask() which returns the 1< We already have an identical drm_crtc_mask() for crtcs. > > Mostly performed with coccinelle: > @@ > @@ > - (1< + drm_plane_mask( > ...) > - ) > > @@ > @@ > - 1<

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Paulo Zanoni
Em Ter, 2018-06-26 às 11:32 -0700, Srivatsa, Anusha escreveu: > > From: Zanoni, Paulo R > Sent: Monday, June 25, 2018 4:17 PM > To: Srivatsa, Anusha; intel-gfx@lists.freedesktop.org > Cc: Pandiyan, Dhinakaran > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/i

[Intel-gfx] ✗ Fi.CI.IGT: failure for Makefile: globally enable VLA warning

2018-06-26 Thread Patchwork
== Series Details == Series: Makefile: globally enable VLA warning URL : https://patchwork.freedesktop.org/series/45421/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4381_full -> Patchwork_9427_full = == Summary - FAILURE == Serious unknown changes coming with Patchwork

[Intel-gfx] [PATCH 07/10] drm/rockchip: Use drm_crtc_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_crtc_mask() where appropriate. Cc: Sandy Huang Cc: "Heiko Stübner" Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drive

[Intel-gfx] [PATCH 04/10] drm: Add drm_connector_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Add drm_connector_mask() which returns the 1< --- drivers/gpu/drm/drm_atomic.c | 6 +++--- include/drm/drm_connector.h | 8 +++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 684c9d3a1d6c

[Intel-gfx] [PATCH 10/10] drm/vmwgfx: Use drm_plane_mask() & co.

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_{plane,connector}_mask() where appropriate. Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwg

[Intel-gfx] [PATCH 09/10] drm/vc4: Use drm_crtc_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_crtc_mask() where appropriate. Cc: Eric Anholt Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vc4/vc4_crtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index dcadf793ee

[Intel-gfx] [PATCH 08/10] drm/sun4i: Use drm_crtc_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_crtc_mask() where appropriate. Cc: Maxime Ripard Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/sun4i/sun4i_crtc.c | 2 +- drivers/gpu/drm/sun4i/sun4i_lvds.c | 2 +- drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff

[Intel-gfx] [PATCH 01/10] drm: Add drm_plane_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Add drm_plane_mask() which returns the 1< --- drivers/gpu/drm/drm_atomic.c| 4 ++-- drivers/gpu/drm/drm_framebuffer.c | 2 +- drivers/gpu/drm/drm_simple_kms_helper.c | 2 +- include/drm/drm_plane.h | 14 -- 4 files changed, 16

[Intel-gfx] [PATCH 02/10] drm: Use drm_crtc_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_crtc_mask() where appropriate. Mostly performed with coccinelle: @@ @@ - (1< --- drivers/gpu/drm/drm_crtc.c | 4 ++-- drivers/gpu/drm/drm_simple_kms_helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.

[Intel-gfx] [PATCH 05/10] drm/i915: Use drm_plane_mask() & co.

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_{plane,crtc,encoder,connector}_mask() where appropriate. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 14 +++--- drivers/gpu/drm/i915/intel_display.h | 4 ++-- drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++--- 3 files changed,

[Intel-gfx] [PATCH 06/10] drm/imx: Use drm_plane_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_plane_mask() where appropriate. Cc: Philipp Zabel Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/imx/ipuv3-crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c index e83af0f

[Intel-gfx] [PATCH 03/10] drm: Add drm_encoder_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Add drm_encoder_mask() which returns the 1< --- drivers/gpu/drm/drm_atomic_helper.c | 10 +- include/drm/drm_encoder.h | 16 ++-- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/d

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/psr: Warn for erroneous enabling of both PSR1 and PSR2.

2018-06-26 Thread Dhinakaran Pandiyan
On Tue, 2018-06-26 at 08:50 -0700, Rodrigo Vivi wrote: > On Tue, Jun 26, 2018 at 02:05:22AM -0700, Dhinakaran Pandiyan wrote: > > > > Depending whether PSR1 or PSR2 was configured, we print a warning > > if the > > corresponding control mmio indicated PSR was erroneously enabled. > > As > > Chris

Re: [Intel-gfx] [PATCH v3] drm/i915/ddi: Get AUX power domain for DP main link too

2018-06-26 Thread Manasi Navare
On Tue, Jun 26, 2018 at 09:03:48PM +0300, Imre Deak wrote: > On Tue, Jun 26, 2018 at 10:40:26AM -0700, Paulo Zanoni wrote: > > Em Seg, 2018-06-25 às 16:55 -0700, Souza, Jose escreveu: > > > On Thu, 2018-06-21 at 21:44 +0300, Imre Deak wrote: > > > > So far we got an AUX power domain reference only

Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/psr: Lockless version of psr_wait_for_idle

2018-06-26 Thread Dhinakaran Pandiyan
On Tue, 2018-06-26 at 10:26 +0200, Daniel Vetter wrote: > On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote: > > > > This is a lockless version of the exisiting psr_wait_for_idle(). > > We want to wait for PSR to idle out inside intel_pipe_update_start. > > At the time of a pipe update, w

Re: [Intel-gfx] [PATCHv2] lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Andy Shevchenko
On Tue, Jun 26, 2018 at 8:46 PM, Dmitry Safonov wrote: > On Tue, 2018-06-26 at 20:04 +0300, Andy Shevchenko wrote >> > #define RATELIMIT_STATE_INIT(name, interval_init, burst_init) >> > {\ >> > - .lock = >> > __RAW_SPIN_LOCK_UNLOCKED(name.lock), \ >> >> n

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Second attempt at fixing the fb-helper .best_encoder() mess

2018-06-26 Thread Patchwork
== Series Details == Series: drm: Second attempt at fixing the fb-helper .best_encoder() mess URL : https://patchwork.freedesktop.org/series/45422/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4381 -> Patchwork_9428 = == Summary - SUCCESS == No regressions found. Ext

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Srivatsa, Anusha
From: Zanoni, Paulo R Sent: Monday, June 25, 2018 4:17 PM To: Srivatsa, Anusha; intel-gfx@lists.freedesktop.org Cc: Pandiyan, Dhinakaran Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/icp: Add Interrupt Support Em Qua, 2018-06-20 às 14:36 -0700, Anusha Sriv

[Intel-gfx] ✓ Fi.CI.IGT: success for lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Patchwork
== Series Details == Series: lib/ratelimit: Lockless ratelimiting URL : https://patchwork.freedesktop.org/series/45416/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9426_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_94

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Second attempt at fixing the fb-helper .best_encoder() mess

2018-06-26 Thread Patchwork
== Series Details == Series: drm: Second attempt at fixing the fb-helper .best_encoder() mess URL : https://patchwork.freedesktop.org/series/45422/ State : warning == Summary == $ dim checkpatch origin/drm-tip eebb696c2139 drm/fb-helper: Eliminate the .best_encoder() usage b75ca3e84ab2 drm/i91

[Intel-gfx] ✓ Fi.CI.BAT: success for Makefile: globally enable VLA warning

2018-06-26 Thread Patchwork
== Series Details == Series: Makefile: globally enable VLA warning URL : https://patchwork.freedesktop.org/series/45421/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4381 -> Patchwork_9427 = == Summary - SUCCESS == No regressions found. External URL: https://patchwo

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Makefile: globally enable VLA warning

2018-06-26 Thread Patchwork
== Series Details == Series: Makefile: globally enable VLA warning URL : https://patchwork.freedesktop.org/series/45421/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: Makefile: globally enable VLA warning - +drivers/gpu/drm/ati_pcigart.c:184:52:expected unsigned int [un

Re: [Intel-gfx] [PATCH v3] drm/i915/ddi: Get AUX power domain for DP main link too

2018-06-26 Thread Imre Deak
On Tue, Jun 26, 2018 at 10:40:26AM -0700, Paulo Zanoni wrote: > Em Seg, 2018-06-25 às 16:55 -0700, Souza, Jose escreveu: > > On Thu, 2018-06-21 at 21:44 +0300, Imre Deak wrote: > > > So far we got an AUX power domain reference only for the duration > > > of > > > DP > > > AUX transfers. However, th

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove delayed FBC activation.

2018-06-26 Thread Ville Syrjälä
On Mon, Jun 25, 2018 at 06:37:58PM +0200, Maarten Lankhorst wrote: > The only time we should start FBC is when we have waited a vblank > after the atomic update. What about front buffer tracking? Is this going to leave FBC permanently disabled unless there are flips/plane updates? I think there a

Re: [Intel-gfx] [PATCH 1/8] drm/fb-helper: Eliminate the .best_encoder() usage

2018-06-26 Thread Alex Deucher
On Tue, Jun 26, 2018 at 1:47 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of using the .best_encoder() hook to figure out whether a given > connector+crtc combo will work, let's instead do what userspace does and > just iterate over all the encoders for the connector, and then check

[Intel-gfx] [PATCH 8/8] drm/tilcdc: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Jyri Sarha Cc: Tomi Valkeinen Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/tilcdc/tilcdc_external.c | 5 +++--

[Intel-gfx] [PATCH 6/8] drm/nouveau: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Ben Skeggs Cc: nouv...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/nouveau/nouveau_conn

[Intel-gfx] [PATCH 7/8] drm/radeon: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: Harry Wentland Cc: amd-...@lists.freedesktop.o

[Intel-gfx] [PATCH 2/8] drm/i915: Nuke intel_mst_best_encoder()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä With the fb-helper no longer relying on the non-atomic .best_encoder() we can eliminate the hook from the MST encoder. Cc: Dhinakaran Pandiyan Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp_mst.c | 10 -- 1 file changed, 10 deletions(-) diff --git

[Intel-gfx] [PATCH 5/8] drm/msm: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- d

[Intel-gfx] [PATCH 4/8] drm/amdgpu: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: Harry Wentland Cc: amd-...@lists.freedesktop.o

[Intel-gfx] [PATCH 3/8] drm: Add drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Add a convenience macro for iterating connector->encoder_ids[]. Isolates the users from the implementation details. Also use ARRAY_SIZE() when populating the array to avoid spreading knowledge about the array size all over. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/

[Intel-gfx] [PATCH 1/8] drm/fb-helper: Eliminate the .best_encoder() usage

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Instead of using the .best_encoder() hook to figure out whether a given connector+crtc combo will work, let's instead do what userspace does and just iterate over all the encoders for the connector, and then check each crtc against each encoder's possible_crtcs bitmask. Cc: D

[Intel-gfx] [PATCH 0/8] drm: Second attempt at fixing the fb-helper .best_encoder() mess

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Daniel pointed out that there should be a way to do what userspace does and not require any .best_encoder() stuff in the fb-helper. So this series does just that. Well, most of the series is actually just extra polish that happened by accident. But the real thing is in there s

Re: [Intel-gfx] [PATCHv2] lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Dmitry Safonov
Hi Andy, thanks for the review, On Tue, 2018-06-26 at 20:04 +0300, Andy Shevchenko wrote [..] > > #define RATELIMIT_STATE_INIT(name, interval_init, burst_init) > > {\ > > - .lock = > > __RAW_SPIN_LOCK_UNLOCKED(name.lock), \ > > name is now redundant, isn'

Re: [Intel-gfx] [PATCH v3] drm/i915/ddi: Get AUX power domain for DP main link too

2018-06-26 Thread Paulo Zanoni
Em Seg, 2018-06-25 às 16:55 -0700, Souza, Jose escreveu: > On Thu, 2018-06-21 at 21:44 +0300, Imre Deak wrote: > > So far we got an AUX power domain reference only for the duration > > of > > DP > > AUX transfers. However, the following suggests that we also need > > these > > for main link functio

[Intel-gfx] [RFC][PATCH] Makefile: globally enable VLA warning

2018-06-26 Thread Kees Cook
This is the patch I've got prepared now that fixes for all VLAs have been sent to maintainers (some are still under review/adjustment, but there aren't any unexplored cases left). My intention would be to have this land at the end of the next merge window after all the pending VLA patches have land

Re: [Intel-gfx] [PATCH] drm/i915/psr: Kill useless function pointers.

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:27:49AM +0200, Daniel Vetter wrote: > On Mon, Jun 25, 2018 at 10:25:36PM -0700, Rodrigo Vivi wrote: > > At some point we introduced the function pointers > > on PSR code to help with VLV/CHV separation logic > > because it had a different HW implementation from PSR. > >

Re: [Intel-gfx] [PATCHv2] lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Andy Shevchenko
On Tue, Jun 26, 2018 at 7:24 PM, Dmitry Safonov wrote: > Currently ratelimit_state is protected with spin_lock. If the .lock is > taken at the moment of ___ratelimit() call, the message is suppressed to > make ratelimiting robust. > > That results in the following issue issue: > CPU0

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Patchwork
== Series Details == Series: lib/ratelimit: Lockless ratelimiting URL : https://patchwork.freedesktop.org/series/45416/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9426 = == Summary - SUCCESS == No regressions found. External URL: https://patchwor

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Block enabling FBC until flips have been completed

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Block enabling FBC until flips have been completed URL : https://patchwork.freedesktop.org/series/45349/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9425_full = == Summary - WARNING

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Patchwork
== Series Details == Series: lib/ratelimit: Lockless ratelimiting URL : https://patchwork.freedesktop.org/series/45416/ State : warning == Summary == $ dim checkpatch origin/drm-tip a8dce76165a9 lib/ratelimit: Lockless ratelimiting -:74: ERROR:ASSIGN_IN_IF: do not use assignment in if conditio

[Intel-gfx] [PATCHv2] lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Dmitry Safonov
Currently ratelimit_state is protected with spin_lock. If the .lock is taken at the moment of ___ratelimit() call, the message is suppressed to make ratelimiting robust. That results in the following issue issue: CPU0 CPU1 -- ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Add power well support

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915/icl: Add power well support URL : https://patchwork.freedesktop.org/series/45409/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9424_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_94

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/psr: Warn for erroneous enabling of both PSR1 and PSR2.

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 02:05:22AM -0700, Dhinakaran Pandiyan wrote: > Depending whether PSR1 or PSR2 was configured, we print a warning if the > corresponding control mmio indicated PSR was erroneously enabled. As > Chris pointed out, it makes more sense to check for both the mmio's > since we exp

Re: [Intel-gfx] [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Harry Wentland
On 2018-06-26 11:01 AM, Harry Wentland wrote: > On 2018-06-15 03:52 PM, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> To pick the correct MST encoder i915 wants to know which crtc is going >> to be feeding us. To that end let's pass the crtc to the .best_encoder() >> hook. The atomic variant a

Re: [Intel-gfx] [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Ville Syrjälä
On Tue, Jun 26, 2018 at 05:23:25PM +0200, Daniel Vetter wrote: > On Fri, Jun 15, 2018 at 10:52:21PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > To pick the correct MST encoder i915 wants to know which crtc is going > > to be feeding us. To that end let's pass the crtc to the .best

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Block enabling FBC until flips have been completed

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Block enabling FBC until flips have been completed URL : https://patchwork.freedesktop.org/series/45349/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9425 = == Summary - SUCCESS == No r

Re: [Intel-gfx] [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Daniel Vetter
On Fri, Jun 15, 2018 at 10:52:21PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > To pick the correct MST encoder i915 wants to know which crtc is going > to be feeding us. To that end let's pass the crtc to the .best_encoder() > hook. The atomic variant already knows the crtc via the conn

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Add power well support

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915/icl: Add power well support URL : https://patchwork.freedesktop.org/series/45409/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9424 = == Summary - SUCCESS == No regressions found. External URL: https://patchwor

Re: [Intel-gfx] [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Harry Wentland
On 2018-06-15 03:52 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > To pick the correct MST encoder i915 wants to know which crtc is going > to be feeding us. To that end let's pass the crtc to the .best_encoder() > hook. The atomic variant already knows the crtc via the connector state, > but

Re: [Intel-gfx] [PATCH] drm/dp: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT

2018-06-26 Thread Atwood, Matthew S
ill uprev by EOD From: Navare, Manasi D Sent: Monday, June 25, 2018 5:39 PM To: Atwood, Matthew S Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo; ble...@chromium.org; Zanoni, Paulo R Subject: Re: [Intel-gfx] [PATCH] drm/dp: implement EXTENDED_RECEIVER_

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Add power well support

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915/icl: Add power well support URL : https://patchwork.freedesktop.org/series/45409/ State : warning == Summary == $ dim checkpatch origin/drm-tip 409dfff082a1 drm/i915/icl: Add power well support -:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: enable P010, P012, P016 formats for primary and sprite planes

2018-06-26 Thread Maarten Lankhorst
Op 12-06-18 om 13:16 schreef Juha-Pekka Heikkila: > Enabling of P010, P012 and P016 formats. These formats will > extend NV12 for larger bit depths. > > Signed-off-by: Juha-Pekka Heikkila Patch series looks good. Reviewed-by: Maarten Lankhorst I only wish we had IGT support already, I'll poke u

[Intel-gfx] [PATCH] drm/i915/icl: Add power well support

2018-06-26 Thread Imre Deak
Add the definition for ICL power wells and their mapping to power domains. On ICL there are 3 power well control registers, we'll select the correct one based on higher bits of the power well ID. The offset for the control and status flags within this register is based on the lower bits of the ID a

  1   2   >