Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it

2020-04-14 Thread Lucas De Marchi
On Tue, Apr 14, 2020 at 4:03 PM José Roberto de Souza wrote: > > Right now dp.regs.dp_tp_ctl/status are only set during the encoder > pre_enable() hook, what is causing all reads and writes to those > registers to go to offset 0x0 before pre_enable() is executed. > > So if i915 takes the BIOS

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it URL : https://patchwork.freedesktop.org/series/75946/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17303

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/3] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it URL : https://patchwork.freedesktop.org/series/75946/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

[Intel-gfx] ✓ Fi.CI.BAT: success for Tigerlake workaround updates

2020-04-14 Thread Patchwork
== Series Details == Series: Tigerlake workaround updates URL : https://patchwork.freedesktop.org/series/75944/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17302 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Tigerlake workaround updates

2020-04-14 Thread Patchwork
== Series Details == Series: Tigerlake workaround updates URL : https://patchwork.freedesktop.org/series/75944/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label gpu/i915:layout, other

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Tigerlake workaround updates

2020-04-14 Thread Patchwork
== Series Details == Series: Tigerlake workaround updates URL : https://patchwork.freedesktop.org/series/75944/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 ___ Intel-gfx mailing list

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use single set of AUX powerwell ops for gen11+

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Use single set of AUX powerwell ops for gen11+ URL : https://patchwork.freedesktop.org/series/75943/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17301 Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Use single set of AUX powerwell ops for gen11+

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Use single set of AUX powerwell ops for gen11+ URL : https://patchwork.freedesktop.org/series/75943/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v5,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch URL : https://patchwork.freedesktop.org/series/75941/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17300

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v5,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v5,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch URL : https://patchwork.freedesktop.org/series/75941/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm-intel tree

2020-04-14 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/display/intel_dp_mst.c between commit: 743acd115070 ("drm/i915: Get rid of silly void* from MST code") from the drm-intel tree and commit: 20c22ad32957 ("drm/dp_mst: Remove

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v5,1/8] drm/i915/display: Move out code to return the digital_port of the aux ch URL : https://patchwork.freedesktop.org/series/75941/ State : warning == Summary == $ dim checkpatch origin/drm-tip 960c21212bc2 drm/i915/display: Move out code

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2020-04-14 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: MAINTAINERS between commitis: 4400b7d68f6e ("MAINTAINERS: sort entries by entry name") 3b50142d8528 ("MAINTAINERS: sort field names for all entries") from Linus' tree and commits: 8edb69970739 ("MAINTAINERS:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Fix HDCP failures when SRM fw is missing (rev2)

2020-04-14 Thread Patchwork
== Series Details == Series: drm: Fix HDCP failures when SRM fw is missing (rev2) URL : https://patchwork.freedesktop.org/series/75938/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17299 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm: Fix HDCP failures when SRM fw is missing (rev2)

2020-04-14 Thread Patchwork
== Series Details == Series: drm: Fix HDCP failures when SRM fw is missing (rev2) URL : https://patchwork.freedesktop.org/series/75938/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Fix HDCP failures when SRM fw is missing (rev2)

2020-04-14 Thread Patchwork
== Series Details == Series: drm: Fix HDCP failures when SRM fw is missing (rev2) URL : https://patchwork.freedesktop.org/series/75938/ State : warning == Summary == $ dim checkpatch origin/drm-tip e0a6dea979f6 drm: Fix HDCP failures when SRM fw is missing -:6: ERROR:GIT_COMMIT_ID: Please use

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Try to smooth RPS spikes

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Try to smooth RPS spikes URL : https://patchwork.freedesktop.org/series/75927/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17298

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/gt: Try to smooth RPS spikes

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Try to smooth RPS spikes URL : https://patchwork.freedesktop.org/series/75927/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Try to smooth RPS spikes

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Try to smooth RPS spikes URL : https://patchwork.freedesktop.org/series/75927/ State : warning == Summary == $ dim checkpatch origin/drm-tip fa2b7bf5aa68 drm/i915/gt: Try to smooth RPS spikes -:13: WARNING:TYPO_SPELLING:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Synchronize active and retire callbacks

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Synchronize active and retire callbacks URL : https://patchwork.freedesktop.org/series/75924/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17297 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Synchronize active and retire callbacks

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Synchronize active and retire callbacks URL : https://patchwork.freedesktop.org/series/75924/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Synchronize active and retire callbacks

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Synchronize active and retire callbacks URL : https://patchwork.freedesktop.org/series/75924/ State : warning == Summary == $ dim checkpatch origin/drm-tip b0e2d2d0b0c3 drm/i915: Synchronize active and retire callbacks -:10: WARNING:COMMIT_LOG_LONG_LINE:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v6,1/4] drm/i915/perf: break OA config buffer object in 2

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v6,1/4] drm/i915/perf: break OA config buffer object in 2 URL : https://patchwork.freedesktop.org/series/75920/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17296

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v6,1/4] drm/i915/perf: break OA config buffer object in 2

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v6,1/4] drm/i915/perf: break OA config buffer object in 2 URL : https://patchwork.freedesktop.org/series/75920/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/4] drm/i915/perf: break OA config buffer object in 2

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v6,1/4] drm/i915/perf: break OA config buffer object in 2 URL : https://patchwork.freedesktop.org/series/75920/ State : warning == Summary == $ dim checkpatch origin/drm-tip 29791c84c5a1 drm/i915/perf: break OA config buffer object in 2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Always defer fenced work to the worker

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Always defer fenced work to the worker URL : https://patchwork.freedesktop.org/series/75917/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17295 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Always defer fenced work to the worker

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Always defer fenced work to the worker URL : https://patchwork.freedesktop.org/series/75917/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix indirect context size calculation

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Fix indirect context size calculation URL : https://patchwork.freedesktop.org/series/75916/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17294 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix indirect context size calculation

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Fix indirect context size calculation URL : https://patchwork.freedesktop.org/series/75916/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it

2020-04-14 Thread Souza, Jose
On Tue, 2020-04-14 at 22:33 +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915/display: Load > DP_TP_CTL/STATUS offset before use it > URL : https://patchwork.freedesktop.org/series/75898/ > State : failure > > == Summary == > > Applying:

[Intel-gfx] [PATCH 3/3] drm/i915/hdmi: Add missing sequence

2020-04-14 Thread José Roberto de Souza
It was missing the step 7.b - "If not type-C static connection, configure PORT_CL_DW10 Static Power Down to power up all lanes of the DDI". BSpec: 53339 BSpec: 49191 Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 ++ 1 file changed, 10

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD URL : https://patchwork.freedesktop.org/series/75899/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17293

[Intel-gfx] [PATCH 1/3] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it

2020-04-14 Thread José Roberto de Souza
Right now dp.regs.dp_tp_ctl/status are only set during the encoder pre_enable() hook, what is causing all reads and writes to those registers to go to offset 0x0 before pre_enable() is executed. So if i915 takes the BIOS state and don't do a modeset any following link retraing will fail. In the

[Intel-gfx] [PATCH 2/3] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi()

2020-04-14 Thread José Roberto de Souza
Getting it only once also removing intel_hdmi that is used only once and can be easily accessed by dig_port->hdmi. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v4,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD URL : https://patchwork.freedesktop.org/series/75899/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD URL : https://patchwork.freedesktop.org/series/75899/ State : warning == Summary == $ dim checkpatch origin/drm-tip e720179743cc drm/dp: DRM DP helper for reading Ignore MSA from

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Shrink the RPS evalution intervals

2020-04-14 Thread Francisco Jerez
Francisco Jerez writes: > Chris Wilson writes: > >> Quoting Francisco Jerez (2020-04-14 22:00:25) >>> Chris Wilson writes: >>> >>> > Quoting Francisco Jerez (2020-04-14 20:39:48) >>> >> Chris Wilson writes: >>> >> >>> >> > Quoting Chris Wilson (2020-04-14 17:14:23) >>> >> >> Try to make RPS

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam URL : https://patchwork.freedesktop.org/series/75895/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17291 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it URL : https://patchwork.freedesktop.org/series/75898/ State : failure == Summary == Applying: drm/i915/display: Load DP_TP_CTL/STATUS offset before use it Applying: Revert

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Shrink the RPS evalution intervals

2020-04-14 Thread Francisco Jerez
Chris Wilson writes: > Quoting Francisco Jerez (2020-04-14 22:00:25) >> Chris Wilson writes: >> >> > Quoting Francisco Jerez (2020-04-14 20:39:48) >> >> Chris Wilson writes: >> >> >> >> > Quoting Chris Wilson (2020-04-14 17:14:23) >> >> >> Try to make RPS dramatically more responsive by

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Shrink the RPS evalution intervals

2020-04-14 Thread Francisco Jerez
Chris Wilson writes: > Quoting Francisco Jerez (2020-04-14 20:39:48) >> Chris Wilson writes: >> >> > Quoting Chris Wilson (2020-04-14 17:14:23) >> >> Try to make RPS dramatically more responsive by shrinking the evaluation >> >> intervales by a factor of 100! The issue is as we now park the

Re: [Intel-gfx] [PATCH] drm/i915: Use single set of AUX powerwell ops for gen11+

2020-04-14 Thread Souza, Jose
On Tue, 2020-04-14 at 13:57 -0700, Matt Roper wrote: > AUX power wells sometimes need additional handling besides just > programming the specific power well registers: > * Type-C PHY's also require additional Type-C register programming > * ICL combo PHY's require additional workarounds > * TGL

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam URL : https://patchwork.freedesktop.org/series/75895/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label

Re: [Intel-gfx] [PATCH 3/3] drm/i915/tgl: Initialize multicast register steering for workarounds

2020-04-14 Thread Souza, Jose
On Tue, 2020-04-14 at 14:11 -0700, Matt Roper wrote: > Even though the bspec is missing gen12 register details for the MCR > selector register (0xFDC), this is confirmed by hardware folks to be > a > mistake; the register does exist and we do indeed need to steer > multicast register reads to an

Re: [Intel-gfx] [PATCH i-g-t] lib: Use read() for timerfd timeout detection

2020-04-14 Thread Chris Wilson
Quoting Dixit, Ashutosh (2020-04-14 22:37:44) > On Tue, 14 Apr 2020 12:05:09 -0700, Chris Wilson wrote: > > > > The poll() is proving unreliable, where our tests timeout without the > > spinner being terminated. Let's try a blocking read instead! > > Weird, wondering if all we need to do is set

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Shrink the RPS evalution intervals

2020-04-14 Thread Chris Wilson
Quoting Francisco Jerez (2020-04-14 22:00:25) > Chris Wilson writes: > > > Quoting Francisco Jerez (2020-04-14 20:39:48) > >> Chris Wilson writes: > >> > >> > Quoting Chris Wilson (2020-04-14 17:14:23) > >> >> Try to make RPS dramatically more responsive by shrinking the evaluation > >> >>

Re: [Intel-gfx] [PATCH 2/3] drm/i915/tgl: Add Wa_14010477008:tgl

2020-04-14 Thread Souza, Jose
On Tue, 2020-04-14 at 14:11 -0700, Matt Roper wrote: > Media decompression support should not be advertised on any display > planes for steppings A0-C0. Reviewed-by: José Roberto de Souza > > Bspec: 53273 > Fixes: 2dfbf9d2873a ("drm/i915/tgl: Gen-12 display can decompress > surfaces compressed

Re: [Intel-gfx] [PATCH 1/3] drm/i915/tgl: Extend Wa_1409767108:tgl to B0 stepping

2020-04-14 Thread Souza, Jose
On Tue, 2020-04-14 at 14:11 -0700, Matt Roper wrote: > Cc: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c >

Re: [Intel-gfx] [PATCH 1/3] drm/i915/tgl: Extend Wa_1409767108:tgl to B0 stepping

2020-04-14 Thread Souza, Jose
Reviewed-by: José Roberto de Souza On Tue, 2020-04-14 at 14:11 -0700, Matt Roper wrote: > Cc: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH i-g-t] lib: Use read() for timerfd timeout detection

2020-04-14 Thread Dixit, Ashutosh
On Tue, 14 Apr 2020 12:05:09 -0700, Chris Wilson wrote: > > The poll() is proving unreliable, where our tests timeout without the > spinner being terminated. Let's try a blocking read instead! Weird, wondering if all we need to do is set TFD_NONBLOCK on the fd? > > Closes:

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Shrink the RPS evalution intervals

2020-04-14 Thread Chris Wilson
Quoting Francisco Jerez (2020-04-14 20:39:48) > Chris Wilson writes: > > > Quoting Chris Wilson (2020-04-14 17:14:23) > >> Try to make RPS dramatically more responsive by shrinking the evaluation > >> intervales by a factor of 100! The issue is as we now park the GPU > >> rapidly upon idling, a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: extended Wa_2006604312 to ehl

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/ehl: extended Wa_2006604312 to ehl URL : https://patchwork.freedesktop.org/series/75894/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17290 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/ehl: extended Wa_2006604312 to ehl

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/ehl: extended Wa_2006604312 to ehl URL : https://patchwork.freedesktop.org/series/75894/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label

[Intel-gfx] [PATCH 1/3] drm/i915/tgl: Extend Wa_1409767108:tgl to B0 stepping

2020-04-14 Thread Matt Roper
Cc: Matt Atwood Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c index

[Intel-gfx] [PATCH 0/3] Tigerlake workaround updates

2020-04-14 Thread Matt Roper
A recent bspec update updated Wa_1409767108 and added Wa_14010477008 to the TGL list. Also, register 0xFDC details are missing from the gen12 section of the bspec, but we have offline confirmation from the hardware folks that this register does indeed still exist and behave as it did on gen11, so

[Intel-gfx] [PATCH 3/3] drm/i915/tgl: Initialize multicast register steering for workarounds

2020-04-14 Thread Matt Roper
Even though the bspec is missing gen12 register details for the MCR selector register (0xFDC), this is confirmed by hardware folks to be a mistake; the register does exist and we do indeed need to steer multicast register reads to an appropriate instance the same as we did on gen11. Note that

[Intel-gfx] [PATCH 2/3] drm/i915/tgl: Add Wa_14010477008:tgl

2020-04-14 Thread Matt Roper
Media decompression support should not be advertised on any display planes for steppings A0-C0. Bspec: 53273 Fixes: 2dfbf9d2873a ("drm/i915/tgl: Gen-12 display can decompress surfaces compressed by the media engine") Cc: Matt Atwood Signed-off-by: Matt Roper ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Shrink the RPS evalution intervals

2020-04-14 Thread Francisco Jerez
Chris Wilson writes: > Quoting Francisco Jerez (2020-04-14 20:39:48) >> Chris Wilson writes: >> >> > Quoting Chris Wilson (2020-04-14 17:14:23) >> >> Try to make RPS dramatically more responsive by shrinking the evaluation >> >> intervales by a factor of 100! The issue is as we now park the

[Intel-gfx] [PATCH] drm/i915: Use single set of AUX powerwell ops for gen11+

2020-04-14 Thread Matt Roper
AUX power wells sometimes need additional handling besides just programming the specific power well registers: * Type-C PHY's also require additional Type-C register programming * ICL combo PHY's require additional workarounds * TGL & EHL combo PHY's can be treated like any other power well

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Use ARRAY_SIZE instead of hardcoded size (rev2)

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Use ARRAY_SIZE instead of hardcoded size (rev2) URL : https://patchwork.freedesktop.org/series/75888/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17289 Summary

Re: [Intel-gfx] [PATCH v4 9/9] drm/i915: Add missing deinitialization cases of load failure

2020-04-14 Thread Souza, Jose
On Tue, 2020-04-14 at 21:29 +0300, Imre Deak wrote: > On Mon, Apr 13, 2020 at 09:45:15AM -0700, José Roberto de Souza > wrote: > > The intel_display_power_put_async() used in TC cold sequences made > > easy to hit the missing deinitialization of driver in case of load > > failure as seen in the

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gvt: Use ARRAY_SIZE instead of hardcoded size (rev2)

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Use ARRAY_SIZE instead of hardcoded size (rev2) URL : https://patchwork.freedesktop.org/series/75888/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Use ARRAY_SIZE instead of hardcoded size (rev2)

2020-04-14 Thread Joe Perches
On Tue, 2020-04-14 at 20:30 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gvt: Use ARRAY_SIZE instead of hardcoded size (rev2) > URL : https://patchwork.freedesktop.org/series/75888/ > State : warning This seems an odd message to receive as I was simply making suggestions

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Use ARRAY_SIZE instead of hardcoded size (rev2)

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Use ARRAY_SIZE instead of hardcoded size (rev2) URL : https://patchwork.freedesktop.org/series/75888/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7523f4bbc30d drm/i915/gvt: Use ARRAY_SIZE instead of hardcoded size -:16:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/9] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v4,1/9] drm/i915/display: Move out code to return the digital_port of the aux ch URL : https://patchwork.freedesktop.org/series/75886/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17288

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v4,1/9] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v4,1/9] drm/i915/display: Move out code to return the digital_port of the aux ch URL : https://patchwork.freedesktop.org/series/75886/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Shrink the RPS evalution intervals

2020-04-14 Thread Chris Wilson
Quoting Francisco Jerez (2020-04-14 20:39:48) > Chris Wilson writes: > > > Quoting Chris Wilson (2020-04-14 17:14:23) > >> Try to make RPS dramatically more responsive by shrinking the evaluation > >> intervales by a factor of 100! The issue is as we now park the GPU > >> rapidly upon idling, a

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/9] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-14 Thread Patchwork
== Series Details == Series: series starting with [v4,1/9] drm/i915/display: Move out code to return the digital_port of the aux ch URL : https://patchwork.freedesktop.org/series/75886/ State : warning == Summary == $ dim checkpatch origin/drm-tip 07f7e1eaedcd drm/i915/display: Move out code

[Intel-gfx] [PATCH v5 6/8] drm/i915/tc/tgl: Implement TC cold sequences

2020-04-14 Thread José Roberto de Souza
TC ports can enter in TCCOLD to save power and is required to request to PCODE to exit this state before use or read to TC registers. For TGL there is a new MBOX command to do that with a parameter to ask PCODE to exit and block TCCOLD entry or unblock TCCOLD entry. So adding a new power domain

[Intel-gfx] [PATCH v5 1/8] drm/i915/display: Move out code to return the digital_port of the aux ch

2020-04-14 Thread José Roberto de Souza
Moving the code to return the digital port of the aux channel also removing the intel_phy_is_tc() to make it generic. digital_port will be needed in icl_tc_phy_aux_power_well_enable() so adding it as a parameter to icl_tc_port_assert_ref_held(). While at at removing the duplicated call to

[Intel-gfx] [PATCH v5 7/8] drm/i915/tc: Catch TC users accessing FIA registers without enable aux

2020-04-14 Thread José Roberto de Souza
As described in "drm/i915/tc/icl: Implement TC cold sequences" users of TC functions should held aux power well during access to avoid read garbage due HW in TC cold state. v3: - renamed is_tc_cold_blocked() to assert_tc_cold_blocked() - restored the removed 0x checks Reviewed-by: Imre

[Intel-gfx] [PATCH v5 8/8] drm/i915/tc: Do not warn when aux power well of static TC ports timeout

2020-04-14 Thread José Roberto de Souza
This is a expected timeout of static TC ports not conneceted, so not throwing warnings that would taint CI. v3: - moved checks to tc_phy_aux_timeout_expected() v4: - moved and add comments to tc_phy_aux_timeout_expected() v5: - only checking tc_legacy_port for TC ports Signed-off-by: José

[Intel-gfx] [PATCH v5 2/8] drm/i915/display: Add intel_legacy_aux_to_power_domain()

2020-04-14 Thread José Roberto de Souza
This is a similar function to intel_aux_power_domain() but it do not care about TBT ports, this will be needed by ICL TC sequences. v2: - renamed to intel_legacy_aux_to_power_domain() Cc: Imre Deak Cc: Cooper Chiou Cc: Kai-Heng Feng Reviewed-by: Imre Deak Tested-by: You-Sheng Yang

[Intel-gfx] [PATCH v5 5/8] drm/i915/tc: Skip ref held check for TC legacy aux power wells

2020-04-14 Thread José Roberto de Souza
As part of ICL TC cold exit sequences we need to request aux power well before lock the access to TC ports, so skiping the intel_tc_port_ref_held() check for TC legacy ports. Reviewed-by: Imre Deak Tested-by: You-Sheng Yang Signed-off-by: José Roberto de Souza ---

[Intel-gfx] [PATCH v5 4/8] drm/i915/tc/icl: Implement TC cold sequences

2020-04-14 Thread José Roberto de Souza
This is required for legacy/static TC ports as IOM is not aware of the connection and will not trigger the TC cold exit. Just request PCODE to exit TCCOLD is not enough as it could enter again before driver makes use of the port, to prevent it BSpec states that aux powerwell should be held. So

[Intel-gfx] [PATCH v5 3/8] drm/i915/display: Split hsw_power_well_enable() into two

2020-04-14 Thread José Roberto de Souza
This is a preparation for ICL TC cold exit sequences. v2: - renamed new functions to hsw_power_well_enable_prepare()/complete() Signed-off-by: José Roberto de Souza Reviewed-by: Imre Deak Tested-by: You-Sheng Yang --- .../drm/i915/display/intel_display_power.c| 39 +++ 1

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Shrink the RPS evalution intervals

2020-04-14 Thread Francisco Jerez
Chris Wilson writes: > Quoting Chris Wilson (2020-04-14 17:14:23) >> Try to make RPS dramatically more responsive by shrinking the evaluation >> intervales by a factor of 100! The issue is as we now park the GPU >> rapidly upon idling, a short or bursty workload such as the composited >> desktop

Re: [Intel-gfx] [PATCH 1/3] drm/i915/perf: Reduce cpu overhead for blocking perf OA reads

2020-04-14 Thread Dixit, Ashutosh
On Tue, 14 Apr 2020 12:09:42 -0700, Dixit, Ashutosh wrote: > > On Tue, 14 Apr 2020 09:59:48 -0700, Umesh Nerlige Ramappa wrote: > > On Mon, Apr 13, 2020 at 11:58:18PM -0700, Dixit, Ashutosh wrote: > > > On Mon, 13 Apr 2020 22:08:47 -0700, Dixit, Ashutosh wrote: > > >> > > >> On Mon, 13 Apr 2020

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: add OA interrupt support (rev9)

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/perf: add OA interrupt support (rev9) URL : https://patchwork.freedesktop.org/series/54280/ State : success == Summary == CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17287 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/perf: add OA interrupt support (rev9)

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/perf: add OA interrupt support (rev9) URL : https://patchwork.freedesktop.org/series/54280/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/i915_perf_types.h:240: warning: Incorrect use of kernel-doc

Re: [Intel-gfx] [PATCH 1/3] drm/i915/perf: Reduce cpu overhead for blocking perf OA reads

2020-04-14 Thread Dixit, Ashutosh
On Tue, 14 Apr 2020 09:59:48 -0700, Umesh Nerlige Ramappa wrote: > On Mon, Apr 13, 2020 at 11:58:18PM -0700, Dixit, Ashutosh wrote: > > On Mon, 13 Apr 2020 22:08:47 -0700, Dixit, Ashutosh wrote: > >> > >> On Mon, 13 Apr 2020 08:48:20 -0700, Umesh Nerlige Ramappa wrote: > >> > > >> > A condition in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: add OA interrupt support (rev9)

2020-04-14 Thread Patchwork
== Series Details == Series: drm/i915/perf: add OA interrupt support (rev9) URL : https://patchwork.freedesktop.org/series/54280/ State : warning == Summary == $ dim checkpatch origin/drm-tip e5020136b3c9 drm/i915/perf: Reduce cpu overhead for blocking perf OA reads 260dadb836a3 drm/i915:

[Intel-gfx] [PATCH i-g-t] lib: Use read() for timerfd timeout detection

2020-04-14 Thread Chris Wilson
The poll() is proving unreliable, where our tests timeout without the spinner being terminated. Let's try a blocking read instead! Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1676 Signed-off-by: Chris Wilson --- lib/igt_dummyload.c | 11 ++- 1 file changed, 6

[Intel-gfx] [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-14 Thread Sean Paul
From: Sean Paul The SRM cleanup in 79643fddd6eb2 ("drm/hdcp: optimizing the srm handling") inadvertently altered the behavior of HDCP auth when the SRM firmware is missing. Before that patch, missing SRM was interpreted as the device having no revoked keys. With that patch, if the SRM fw file is

Re: [Intel-gfx] [PATCH v4 6/9] drm/i915/tc/tgl: Implement TC cold sequences

2020-04-14 Thread Imre Deak
On Tue, Apr 14, 2020 at 08:41:50PM +0300, Souza, Jose wrote: > On Tue, 2020-04-14 at 20:39 +0300, Imre Deak wrote: > > On Mon, Apr 13, 2020 at 09:45:12AM -0700, José Roberto de Souza > > wrote: > > > TC ports can enter in TCCOLD to save power and is required to > > > request > > > to PCODE to exit

[Intel-gfx] [PATCH] drm: Fix HDCP failures when SRM fw is missing

2020-04-14 Thread Sean Paul
From: Sean Paul The SRM cleanup in 79643fddd6eb2 ("drm/hdcp: optimizing the srm handling") inadvertently altered the behavior of HDCP auth when the SRM firmware is missing. Before that patch, missing SRM was interpreted as the device having no revoked keys. With that patch, if the SRM fw file is

Re: [Intel-gfx] [PATCH] drm/i915/icl: Update forcewake firmware ranges

2020-04-14 Thread Matt Roper
On Mon, Apr 13, 2020 at 02:00:03AM -0700, Radhakrishna Sripada wrote: > Some workarounds are not sticking across suspend resume cycles. The > forcewake ranges table has been updated and would reflect the hardware > appropriately. > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1222

Re: [Intel-gfx] [PATCH v4 9/9] drm/i915: Add missing deinitialization cases of load failure

2020-04-14 Thread Imre Deak
On Mon, Apr 13, 2020 at 09:45:15AM -0700, José Roberto de Souza wrote: > The intel_display_power_put_async() used in TC cold sequences made > easy to hit the missing deinitialization of driver in case of load > failure as seen in the stack trace bellow. > > intel_modeset_driver_remove_noirq() had

Re: [Intel-gfx] [PATCH v4 8/9] drm/i915/tc: Do not warn when aux power well of static TC ports timeout

2020-04-14 Thread Souza, Jose
On Tue, 2020-04-14 at 20:47 +0300, Imre Deak wrote: > On Mon, Apr 13, 2020 at 09:45:14AM -0700, José Roberto de Souza > wrote: > > This is a expected timeout of static TC ports not conneceted, so > > not throwing warnings that would taint CI. > > > > v3: > > - moved checks to

Re: [Intel-gfx] [PATCH v4 8/9] drm/i915/tc: Do not warn when aux power well of static TC ports timeout

2020-04-14 Thread Imre Deak
On Mon, Apr 13, 2020 at 09:45:14AM -0700, José Roberto de Souza wrote: > This is a expected timeout of static TC ports not conneceted, so > not throwing warnings that would taint CI. > > v3: > - moved checks to tc_phy_aux_timeout_expected() > > v4: > - moved and add comments to

Re: [Intel-gfx] [PATCH v22 01/13] drm/i915: Start passing latency as parameter

2020-04-14 Thread Ville Syrjälä
On Thu, Apr 09, 2020 at 06:47:18PM +0300, Stanislav Lisovskiy wrote: > We need to start passing memory latency as a > parameter when calculating plane wm levels, > as latency can get changed in different > circumstances(for example with or without SAGV). > So we need to be more flexible on that

Re: [Intel-gfx] [PATCH v22 06/13] drm/i915: Add pre/post plane updates for SAGV

2020-04-14 Thread Ville Syrjälä
On Thu, Apr 09, 2020 at 06:47:23PM +0300, Stanislav Lisovskiy wrote: > Lets have a unified way to handle SAGV changes, > espoecially considering the upcoming Gen12 changes. > > Current "standard" way of doing this in commit_tail > is pre/post plane updates, when everything which > has to be

Re: [Intel-gfx] [PATCH v4 6/9] drm/i915/tc/tgl: Implement TC cold sequences

2020-04-14 Thread Souza, Jose
On Tue, 2020-04-14 at 20:39 +0300, Imre Deak wrote: > On Mon, Apr 13, 2020 at 09:45:12AM -0700, José Roberto de Souza > wrote: > > TC ports can enter in TCCOLD to save power and is required to > > request > > to PCODE to exit this state before use or read to TC registers. > > > > For TGL there is

Re: [Intel-gfx] [PATCH v22 04/13] drm/i915: Add intel_atomic_get_bw_*_state helpers

2020-04-14 Thread Ville Syrjälä
On Thu, Apr 09, 2020 at 06:47:21PM +0300, Stanislav Lisovskiy wrote: > Add correspondent helpers to be able to get old/new bandwidth > global state object. > > v2: - Fixed typo in function call > v3: - Changed new functions naming to use convention proposed > by Jani Nikula, i.e intel_bw_*

Re: [Intel-gfx] [PATCH v4 6/9] drm/i915/tc/tgl: Implement TC cold sequences

2020-04-14 Thread Imre Deak
On Mon, Apr 13, 2020 at 09:45:12AM -0700, José Roberto de Souza wrote: > TC ports can enter in TCCOLD to save power and is required to request > to PCODE to exit this state before use or read to TC registers. > > For TGL there is a new MBOX command to do that with a parameter to ask > PCODE to

Re: [Intel-gfx] [PATCH v22 02/13] drm/i915: Eliminate magic numbers "0" and "1" from color plane

2020-04-14 Thread Ville Syrjälä
On Thu, Apr 09, 2020 at 06:47:19PM +0300, Stanislav Lisovskiy wrote: > According to many computer science sources - magic values > in code _are_ _bad_. For many reasons: the reason is that "0" > or "1" or whatever magic values confuses and doesn't give any > info why this parameter is this value

Re: [Intel-gfx] [PATCH v4 4/9] drm/i915/tc/icl: Implement TC cold sequences

2020-04-14 Thread Imre Deak
On Mon, Apr 13, 2020 at 09:45:10AM -0700, José Roberto de Souza wrote: > This is required for legacy/static TC ports as IOM is not aware of > the connection and will not trigger the TC cold exit. > > Just request PCODE to exit TCCOLD is not enough as it could enter > again before driver makes use

Re: [Intel-gfx] [PATCH v23 05/13] drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv

2020-04-14 Thread Ville Syrjälä
On Fri, Apr 10, 2020 at 03:24:32PM +0300, Stanislav Lisovskiy wrote: > Addressing one of the comments, recommending to extract platform > specific code from intel_can_enable_sagv as a preparation, before > we are going to add support for tgl+. > > v2: - Removed whitespace > > Signed-off-by:

Re: [Intel-gfx] [PATCH 1/3] drm/i915/perf: Reduce cpu overhead for blocking perf OA reads

2020-04-14 Thread Umesh Nerlige Ramappa
On Mon, Apr 13, 2020 at 11:58:18PM -0700, Dixit, Ashutosh wrote: On Mon, 13 Apr 2020 22:08:47 -0700, Dixit, Ashutosh wrote: On Mon, 13 Apr 2020 08:48:20 -0700, Umesh Nerlige Ramappa wrote: > > A condition in wait_event_interruptible seems to be checked twice before > waiting on the event to

Re: [Intel-gfx] [RESEND PATCH] drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms

2020-04-14 Thread Ville Syrjälä
On Tue, Apr 14, 2020 at 01:32:49PM +0300, Kai Vehmanen wrote: > Hey, > > On Thu, 9 Apr 2020, Ville Syrjälä wrote: > > > On Thu, Apr 09, 2020 at 05:14:01PM +0300, Kai Vehmanen wrote: > > > type of content free ping, but I still dare to seek your input on what is > > > the proper way to get

  1   2   >