It was missing the step 7.b - "If not type-C static connection,
configure PORT_CL_DW10 Static Power Down to power up all lanes of the
DDI".

BSpec: 53339
BSpec: 49191
Signed-off-by: José Roberto de Souza <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c 
b/drivers/gpu/drm/i915/display/intel_ddi.c
index de5cb25053e3..94fa37d22e2c 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3330,6 +3330,7 @@ static void intel_ddi_pre_enable_hdmi(struct 
intel_atomic_state *state,
 {
        struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
        struct intel_digital_port *dig_port = enc_to_dig_port(encoder);
+       enum phy phy = intel_port_to_phy(dev_priv, encoder->port);
        int level = intel_ddi_hdmi_level(encoder);
 
        intel_dp_dual_mode_set_tmds_output(&dig_port->hdmi, true);
@@ -3357,6 +3358,15 @@ static void intel_ddi_pre_enable_hdmi(struct 
intel_atomic_state *state,
 
        intel_ddi_enable_pipe_clock(crtc_state);
 
+       if (intel_phy_is_combo(dev_priv, phy)) {
+               bool lane_reversal =
+                       dig_port->saved_port_bits & DDI_BUF_PORT_REVERSAL;
+
+               intel_combo_phy_power_up_lanes(dev_priv, phy, false,
+                                              crtc_state->lane_count,
+                                              lane_reversal);
+       }
+
        dig_port->set_infoframes(encoder, crtc_state->has_infoframe, crtc_state,
                                 conn_state);
 }
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to