Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Initialize reserved and unspecified MOCS indices

2020-06-08 Thread Francisco Jerez
Joonas Lahtinen writes: > + Jason and Ken > > Quoting Francisco Jerez (2020-06-05 00:34:57) >> Ayaz A Siddiqui writes: >> >> > In order to avoid functional breakage of mis-programmed applications that >> > have grown to depend on unused MOCS entries, we are programming >> > those entries to be

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Disabling FBC when PSR2 SU update enabled

2020-06-08 Thread Patchwork
== Series Details == Series: Disabling FBC when PSR2 SU update enabled URL : https://patchwork.freedesktop.org/series/78138/ State : failure == Summary == Applying: Disabling FBC when PSR2 SU update enabled Using index info to reconstruct a base tree... M

[Intel-gfx] [PATCH v2] Disabling FBC when PSR2 SU update enabled

2020-06-08 Thread Jason Le
--- drivers/gpu/drm/i915/display/intel_fbc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c index 52bc7483adb5..1505d93c6685 100644 --- a/drivers/gpu/drm/i915/display/intel_fbc.c +++

[Intel-gfx] [PATCH AUTOSEL 5.6 163/606] drm/i915: Propagate error from completed fences

2020-06-08 Thread Sasha Levin
From: Chris Wilson commit bc850943486887e3859597a266767f95db90aa72 upstream. We need to preserve fatal errors from fences that are being terminated as we hook them up. Fixes: ef4688497512 ("drm/i915: Propagate fence errors") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Matthew Auld

[Intel-gfx] [PATCH AUTOSEL 5.6 162/606] drm/i915/gvt: Init DPLL/DDI vreg for virtual display instead of inheritance.

2020-06-08 Thread Sasha Levin
From: Colin Xu commit f965b68188ab59a40a421ced1b05a2fea638465c upstream. Init value of some display vregs rea inherited from host pregs. When host display in different status, i.e. all monitors unpluged, different display configurations, etc., GVT virtual display setup don't consistent thus may

[Intel-gfx] [PATCH AUTOSEL 5.6 037/606] drm/i915/tgl+: Fix interrupt handling for DP AUX transactions

2020-06-08 Thread Sasha Levin
From: Imre Deak commit 4457a9db2bdec2360ddb15242341696108167886 upstream. Unmask/enable AUX interrupts on all ports on TGL+. So far the interrupts worked only on port A, which meant each transaction on other ports took 10ms. Cc: # v5.4+ Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä

[Intel-gfx] [PATCH AUTOSEL 5.6 031/606] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

2020-06-08 Thread Sasha Levin
From: Peter Jones commit 82152d424b6cb6fc1ede7d03d69c04e786688740 upstream. This was sort of annoying me: random:~$ dmesg | tail -1 [523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size

[Intel-gfx] [PATCH AUTOSEL 5.6 003/606] drm/i915: Handle idling during i915_gem_evict_something busy loops

2020-06-08 Thread Sasha Levin
From: Chris Wilson [ Upstream commit 955da9d77435acac066139e9d7f7723ce7204a1d ] i915_gem_evict_something() is charged with finding a slot within the GTT that we may reuse. Since our goal is not to stall, we first look for a slot that only overlaps idle vma. To this end, on the first pass we

Re: [Intel-gfx] [PATCH] drm/i915/display: Avoid PSR and FBC features concurently.

2020-06-08 Thread Le, Jason V
I had a meeting with an Intel Display Architect. The expected behavior for the driver is PSR2-SU enabling should disable FBC. I will update the patch to limit fbc disabling for PSR2-SU only, not PSR1. Please look at the HSD below for expected driver implementation.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tc: fix the reset of ln0

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915/tc: fix the reset of ln0 URL : https://patchwork.freedesktop.org/series/78132/ State : success == Summary == CI Bug Log - changes from CI_DRM_8601_full -> Patchwork_17912_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: fix the reset of ln0

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915/tc: fix the reset of ln0 URL : https://patchwork.freedesktop.org/series/78132/ State : success == Summary == CI Bug Log - changes from CI_DRM_8601 -> Patchwork_17912 Summary --- **SUCCESS**

[Intel-gfx] [PATCH v5 12/13] drm/i915: Use debug category printer for welcome message

2020-06-08 Thread Sean Paul
From: Sean Paul The welcome printer is meant to be gated on DRM_UT_DRIVER, so use the debug category printer to avoid dumping the message in the wrong place. Signed-off-by: Sean Paul Changes in v5: -Added to the set --- drivers/gpu/drm/i915/i915_drv.c | 3 ++- 1 file changed, 2

[Intel-gfx] [PATCH v5 09/13] drm/i915: Change infoframe debug checks to specify syslog

2020-06-08 Thread Sean Paul
From: Sean Paul Since the logs protected by these checks specifically target syslog, use the new drm_debug_syslog_enabled() call to avoid triggering these prints when only trace is enabled. Signed-off-by: Sean Paul Changes in v5: -Added to the set ---

Re: [Intel-gfx] [PATCH] drm/i915/tc: fix the reset of ln0

2020-06-08 Thread Souza, Jose
On Mon, 2020-06-08 at 13:54 -0700, José Roberto de Souza wrote: > On Mon, 2020-06-08 at 13:45 -0700, Khaled Almahallawy wrote: > > Setting ln0 similar to ln1 > Hum guess would good to have a Fixes tag to the patch adding the line fixed. > Reviewed-by: José Roberto de Souza > > >

[Intel-gfx] [PATCH v5 03/13] drm/i915/utils: Replace dev_printk with drm helpers

2020-06-08 Thread Sean Paul
From: Sean Paul Use drm logging helpers to add support for the upcoming tracefs implementation. Signed-off-by: Sean Paul Changes in v5: -Added to the set --- drivers/gpu/drm/i915/i915_utils.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 02/28] drm/i915/selftests: Make the hanging request non-preemptible

2020-06-08 Thread Mika Kuoppala
Chris Wilson writes: > In some of our hangtests, we try to reset an active engine while it is > spinning inside the recursive spinner. However, we also try to flood the > engine with requests that preempt the hang, and so should disable the > preemption to be sure that we reset the right

Re: [Intel-gfx] [PATCH] drm/i915/tc: fix the reset of ln0

2020-06-08 Thread Souza, Jose
On Mon, 2020-06-08 at 13:45 -0700, Khaled Almahallawy wrote: > Setting ln0 similar to ln1 Reviewed-by: José Roberto de Souza > > Signed-off-by: Khaled Almahallawy > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 01/28] drm/i915: Adjust the sentinel assert to match implementation

2020-06-08 Thread Mika Kuoppala
Chris Wilson writes: > From: Tvrtko Ursulin > > Sentinels are supposed to be last reqeusts in the elsp queue, not the > only one, so adjust the assert accordingly. s/reqeusts/requests > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 14 +++--- > 1 file

[Intel-gfx] [PATCH] drm/i915/tc: fix the reset of ln0

2020-06-08 Thread Khaled Almahallawy
Setting ln0 similar to ln1 Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 96eaa4b39c68..1c0c369573e7

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev2)

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev2) URL : https://patchwork.freedesktop.org/series/78128/ State : success == Summary == CI Bug Log - changes from CI_DRM_8601_full -> Patchwork_17911_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c URL : https://patchwork.freedesktop.org/series/78126/ State : success == Summary == CI Bug Log - changes from CI_DRM_8601_full -> Patchwork_17910_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev2)

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev2) URL : https://patchwork.freedesktop.org/series/78128/ State : success == Summary == CI Bug Log - changes from CI_DRM_8601 -> Patchwork_17911

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c URL : https://patchwork.freedesktop.org/series/78126/ State : success == Summary == CI Bug Log - changes from CI_DRM_8601 -> Patchwork_17910 Summary

[Intel-gfx] [PATCH v2] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

2020-06-08 Thread Imre Deak
DSC is not supported on DP MST streams so just return -EINVAL when reading/writing the i915_dsc_fec_support debugfs file for such connectors. This also fixes an OOPS, caused by the encoder->digport cast, which is not valid for MST encoders. v2: - Check encoder, which is unset for an MST

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/mm: remove invalid entry based optimization

2020-06-08 Thread Patchwork
== Series Details == Series: drm/mm: remove invalid entry based optimization URL : https://patchwork.freedesktop.org/series/78125/ State : success == Summary == CI Bug Log - changes from CI_DRM_8601_full -> Patchwork_17909_full Summary

Re: [Intel-gfx] [PATCH] drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c

2020-06-08 Thread Chris Wilson
Quoting Rodrigo Vivi (2020-06-08 18:46:53) > Alexandre Oliva has recently removed these files from Linux Libre > with concerns that the sources weren't available. > > The sources are available on IGT repository, and only open source > tools are used to generate the {ivb,hsw}_clear_kernel.c files.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c URL : https://patchwork.freedesktop.org/series/78126/ State : warning == Summary == $ dim checkpatch origin/drm-tip 62de4aea38dc drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c -:26:

[Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

2020-06-08 Thread Imre Deak
DSC is not supported on DP MST streams so just return -EINVAL when reading/writing the i915_dsc_fec_support debugfs file for such connectors. This also fixes an OOPS, caused by the encoder->digport cast, which is not valid for MST encoders. Signed-off-by: Imre Deak ---

[Intel-gfx] [PATCH] drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c

2020-06-08 Thread Rodrigo Vivi
Alexandre Oliva has recently removed these files from Linux Libre with concerns that the sources weren't available. The sources are available on IGT repository, and only open source tools are used to generate the {ivb,hsw}_clear_kernel.c files. However, the remaining concern from Alexandre Oliva

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/mm: remove invalid entry based optimization

2020-06-08 Thread Patchwork
== Series Details == Series: drm/mm: remove invalid entry based optimization URL : https://patchwork.freedesktop.org/series/78125/ State : success == Summary == CI Bug Log - changes from CI_DRM_8601 -> Patchwork_17909 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/mm: remove invalid entry based optimization

2020-06-08 Thread Patchwork
== Series Details == Series: drm/mm: remove invalid entry based optimization URL : https://patchwork.freedesktop.org/series/78125/ State : warning == Summary == $ dim checkpatch origin/drm-tip 700bb6db2857 drm/mm: remove invalid entry based optimization -:40: WARNING:NO_AUTHOR_SIGN_OFF:

Re: [Intel-gfx] A panic and a hang in the i915 drm driver

2020-06-08 Thread David Howells
Jani Nikula wrote: > David, please try [1]. Assuming you mean this: https://patchwork.freedesktop.org/patch/366958/?series=77635=1 yes, that works. Tested-by: David Howells ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915/display: Avoid PSR and FBC features concurently.

2020-06-08 Thread Souza, Jose
On Sun, 2020-06-07 at 23:56 -0700, Jason Le wrote: > Issue: Enble both PSR and FBC caused some fickers on some eDP panels (eg. > Panel GIS > 13.5" QHD Glare NE135FBM-N41/NC135GFL02). Disbling either PSR or FBC > will solve this flicker issue. > > Both PSR and FBC features save power when render

[Intel-gfx] [PATCH] drm/mm: remove invalid entry based optimization

2020-06-08 Thread Christian König
When the current entry is rejected as candidate for the search it does not mean that we can abort the subtree search. It is perfectly possible that only the alignment, but not the size is the reason for the rejection. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c | 6 ++ 1

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Prevent enabling breadcrumbs on the virtual engine (rev2)

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Prevent enabling breadcrumbs on the virtual engine (rev2) URL : https://patchwork.freedesktop.org/series/78117/ State : success == Summary == CI Bug Log - changes from CI_DRM_8600_full -> Patchwork_17908_full

Re: [Intel-gfx] [PATCH 8/9] drm/shmem-helpers: Ensure get_pages is not called on imported dma-buf

2020-06-08 Thread Daniel Vetter
On Mon, Jun 08, 2020 at 04:40:26PM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.06.20 um 15:12 schrieb Daniel Vetter: > > On Thu, May 14, 2020 at 09:30:04AM +0200, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 11.05.20 um 11:35 schrieb Daniel Vetter: > >>> Just a bit of light paranoia. Also

[Intel-gfx] ✓ Fi.CI.IGT: success for Add debugfs for requesting HDCP version

2020-06-08 Thread Patchwork
== Series Details == Series: Add debugfs for requesting HDCP version URL : https://patchwork.freedesktop.org/series/78115/ State : success == Summary == CI Bug Log - changes from CI_DRM_8600_full -> Patchwork_17906_full Summary ---

Re: [Intel-gfx] [PATCH 8/9] drm/shmem-helpers: Ensure get_pages is not called on imported dma-buf

2020-06-08 Thread Thomas Zimmermann
Hi Am 03.06.20 um 15:12 schrieb Daniel Vetter: > On Thu, May 14, 2020 at 09:30:04AM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 11.05.20 um 11:35 schrieb Daniel Vetter: >>> Just a bit of light paranoia. Also sprinkle this check over >>> drm_gem_shmem_get_sg_table, which should only be called

Re: [Intel-gfx] pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-06-08 Thread Daniel Vetter
On Sat, Jun 06, 2020 at 10:25:45PM +0200, Hans de Goede wrote: > Hi All, > > This patch series converts the i915 driver's cpde for controlling the > panel's backlight with an external PWM controller to use the atomic PWM API. > > Initially the plan was for this series to consist of 2 parts: > 1.

Re: [Intel-gfx] [PATCH v2 03/15] pwm: lpss: Add range limit check for the base_unit register value

2020-06-08 Thread Hans de Goede
Hi, On 6/8/20 2:51 PM, Andy Shevchenko wrote: On Mon, Jun 08, 2020 at 01:07:12PM +0200, Hans de Goede wrote: On 6/8/20 5:50 AM, Andy Shevchenko wrote: On Sun, Jun 07, 2020 at 08:18:28PM +0200, Hans de Goede wrote: When the user requests a high enough period ns value, then the calculations in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Prevent enabling breadcrumbs on the virtual engine (rev2)

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Prevent enabling breadcrumbs on the virtual engine (rev2) URL : https://patchwork.freedesktop.org/series/78117/ State : success == Summary == CI Bug Log - changes from CI_DRM_8600 -> Patchwork_17908

Re: [Intel-gfx] [PATCH v2 04/15] pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()

2020-06-08 Thread Andy Shevchenko
On Mon, Jun 08, 2020 at 01:13:01PM +0200, Hans de Goede wrote: > On 6/8/20 5:55 AM, Andy Shevchenko wrote: > > On Sun, Jun 07, 2020 at 08:18:29PM +0200, Hans de Goede wrote: > > > According to the data-sheet the way the PWM controller works is that > > > each input clock-cycle the base_unit gets

[Intel-gfx] [PATCH v2] drm/i915/gt: Prevent enabling breadcrumbs on the virtual engine

2020-06-08 Thread Chris Wilson
The virtual engines are not connected directly to hardware, so do not generate interrupts themselves, nor do we expect to enable breadcrumb tracking on them. However, if we clear out a stale virtual request, we will process the breadcrumbs on the current virtual engine. Here, we only need to add

Re: [Intel-gfx] [PATCH v2 03/15] pwm: lpss: Add range limit check for the base_unit register value

2020-06-08 Thread Andy Shevchenko
On Mon, Jun 08, 2020 at 01:07:12PM +0200, Hans de Goede wrote: > On 6/8/20 5:50 AM, Andy Shevchenko wrote: > > On Sun, Jun 07, 2020 at 08:18:28PM +0200, Hans de Goede wrote: > > > When the user requests a high enough period ns value, then the > > > calculations in pwm_lpss_prepare() might result

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Prevent enabling breadcrumbs on the virtual engine

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Prevent enabling breadcrumbs on the virtual engine URL : https://patchwork.freedesktop.org/series/78117/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8600 -> Patchwork_17907

[Intel-gfx] ✓ Fi.CI.BAT: success for Add debugfs for requesting HDCP version

2020-06-08 Thread Patchwork
== Series Details == Series: Add debugfs for requesting HDCP version URL : https://patchwork.freedesktop.org/series/78115/ State : success == Summary == CI Bug Log - changes from CI_DRM_8600 -> Patchwork_17906 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add debugfs for requesting HDCP version

2020-06-08 Thread Patchwork
== Series Details == Series: Add debugfs for requesting HDCP version URL : https://patchwork.freedesktop.org/series/78115/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Init lspcon chip dynamically

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915: Init lspcon chip dynamically URL : https://patchwork.freedesktop.org/series/78114/ State : failure == Summary == Applying: drm/i915: Init lspcon chip dynamically Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH v2 04/15] pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()

2020-06-08 Thread Hans de Goede
Hi, On 6/8/20 5:55 AM, Andy Shevchenko wrote: On Sun, Jun 07, 2020 at 08:18:29PM +0200, Hans de Goede wrote: According to the data-sheet the way the PWM controller works is that each input clock-cycle the base_unit gets added to a N bit counter and that counter overflowing determines the PWM

Re: [Intel-gfx] [PATCH v2 03/15] pwm: lpss: Add range limit check for the base_unit register value

2020-06-08 Thread Hans de Goede
Hi, On 6/8/20 5:50 AM, Andy Shevchenko wrote: On Sun, Jun 07, 2020 at 08:18:28PM +0200, Hans de Goede wrote: When the user requests a high enough period ns value, then the calculations in pwm_lpss_prepare() might result in a base_unit value of 0. But according to the data-sheet the way the

[Intel-gfx] [PATCH] drm/i915/gt: Prevent enabling breadcrumbs on the virtual engine

2020-06-08 Thread Chris Wilson
The virtual engines are not connected directly to hardware, so do not generate interrupts themselves, nor do we expect to enable breadcrumb tracking on them. However, if we clear out a stale virtual request, we will process the breadcrumbs on the current virtual engine. Here, we only need to add

[Intel-gfx] [PATCH v2 2/2] drm/i915: Add a new debugfs to request HDCP version

2020-06-08 Thread Ankit Nautiyal
As per the current HDCP design, the driver selects the highest version of HDCP that can be used to satisfy the content-protection requirements of the user. Due to this, the content-protection tests cannot test a lower version of HDCP, if the platform and the display panel, both support higher HDCP

[Intel-gfx] [PATCH v2 0/2] Add debugfs for requesting HDCP version

2020-06-08 Thread Ankit Nautiyal
Currently, for a given content-protection request, the kernel selects the highest version of HDCP supported by the panel and the platform. This makes the testing/debugging difficult for lower versions of HDCP. E.g. In case both the lower and the higher HDCP versions are supported then the higher

[Intel-gfx] [PATCH v2 1/2] drm/i915: Add support for considering HDCP ver requested via debugfs

2020-06-08 Thread Ankit Nautiyal
For testing and debugging each HDCP version separately, a debugfs entry for requesting a specific version is required. The version requested via debugfs needs to be stored in hdcp structure. This can then be considered while enabling HDCP, provided the platform and the display supports the

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Initialize reserved and unspecified MOCS indices

2020-06-08 Thread Joonas Lahtinen
+ Jason and Ken Quoting Francisco Jerez (2020-06-05 00:34:57) > Ayaz A Siddiqui writes: > > > In order to avoid functional breakage of mis-programmed applications that > > have grown to depend on unused MOCS entries, we are programming > > those entries to be equal to fully cached ("L3 + LLC")

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Remove unneeded hack now for CDCLK"

2020-06-08 Thread Jani Nikula
On Mon, 08 Jun 2020, "Lisovskiy, Stanislav" wrote: > On Mon, Jun 08, 2020 at 11:21:14AM +0300, Jani Nikula wrote: >> On Mon, 08 Jun 2020, Stanislav Lisovskiy >> wrote: >> > This reverts commit 82ea174dc5425d4e85e25d0c4ba961a2e494392a. >> > >> >> Please explain why. What's going on, why we

Re: [Intel-gfx] [PATCH 01/28] drm/i915: Adjust the sentinel assert to match implementation

2020-06-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-06-08 08:44:01) > > On 07/06/2020 23:20, Chris Wilson wrote: > > From: Tvrtko Ursulin > > > > Sentinels are supposed to be last reqeusts in the elsp queue, not the > > only one, so adjust the assert accordingly. > > > > Signed-off-by: Tvrtko Ursulin > > --- > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Avoid PSR and FBC features concurently.

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Avoid PSR and FBC features concurently. URL : https://patchwork.freedesktop.org/series/78107/ State : success == Summary == CI Bug Log - changes from CI_DRM_8599_full -> Patchwork_17904_full

[Intel-gfx] [PATCH v5] drm/i915: Init lspcon chip dynamically

2020-06-08 Thread Kai-Heng Feng
On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port becomes useless and never responds to cable hotplugging: [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon [3.031945] [drm:intel_ddi_init [i915]] *ERROR* LSPCON init failed on port D Seems like the

Re: [Intel-gfx] A panic and a hang in the i915 drm driver

2020-06-08 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: maanantai 8. kesäkuuta 2020 10.49 > To: David Howells ; Joonas Lahtinen > ; Vivi, Rodrigo > Cc: intel-gfx@lists.freedesktop.org; linux-ker...@vger.kernel.org; dri- > de...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Remove unneeded hack now for CDCLK"

2020-06-08 Thread Lisovskiy, Stanislav
On Mon, Jun 08, 2020 at 11:21:14AM +0300, Jani Nikula wrote: > On Mon, 08 Jun 2020, Stanislav Lisovskiy > wrote: > > This reverts commit 82ea174dc5425d4e85e25d0c4ba961a2e494392a. > > > > Please explain why. What's going on, why we need the revert. > > It's fine to reply here, the commit

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "drm/i915: Remove unneeded hack now for CDCLK"

2020-06-08 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Remove unneeded hack now for CDCLK" URL : https://patchwork.freedesktop.org/series/78106/ State : success == Summary == CI Bug Log - changes from CI_DRM_8599_full -> Patchwork_17903_full

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Remove unneeded hack now for CDCLK"

2020-06-08 Thread Jani Nikula
On Mon, 08 Jun 2020, Stanislav Lisovskiy wrote: > This reverts commit 82ea174dc5425d4e85e25d0c4ba961a2e494392a. > Please explain why. What's going on, why we need the revert. It's fine to reply here, the commit message can be amended by whoever applies the patch. BR, Jani. > Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Avoid PSR and FBC features concurently.

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Avoid PSR and FBC features concurently. URL : https://patchwork.freedesktop.org/series/78107/ State : success == Summary == CI Bug Log - changes from CI_DRM_8599 -> Patchwork_17904 Summary

Re: [Intel-gfx] A panic and a hang in the i915 drm driver

2020-06-08 Thread Jani Nikula
On Sun, 07 Jun 2020, David Howells wrote: > Hi, > > I'm seeing the attached oops and panic from the i915 drm driver. I've tried > bisecting it, but there's a problem in that one of the merged branches causes > the machine to hang without output. Cc: Ville and GG, I thought this was fixed

Re: [Intel-gfx] [PATCH 01/28] drm/i915: Adjust the sentinel assert to match implementation

2020-06-08 Thread Tvrtko Ursulin
On 07/06/2020 23:20, Chris Wilson wrote: From: Tvrtko Ursulin Sentinels are supposed to be last reqeusts in the elsp queue, not the only one, so adjust the assert accordingly. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_lrc.c | 14 +++--- 1 file changed, 3

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Avoid PSR and FBC features concurently.

2020-06-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Avoid PSR and FBC features concurently. URL : https://patchwork.freedesktop.org/series/78107/ State : warning == Summary == $ dim checkpatch origin/drm-tip dee7c897c6ed drm/i915/display: Avoid PSR and FBC features concurently. -:6:

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915: Remove unneeded hack now for CDCLK"

2020-06-08 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Remove unneeded hack now for CDCLK" URL : https://patchwork.freedesktop.org/series/78106/ State : success == Summary == CI Bug Log - changes from CI_DRM_8599 -> Patchwork_17903 Summary ---

[Intel-gfx] [PATCH] Revert "drm/i915: Remove unneeded hack now for CDCLK"

2020-06-08 Thread Stanislav Lisovskiy
This reverts commit 82ea174dc5425d4e85e25d0c4ba961a2e494392a. Signed-off-by: Stanislav Lisovskiy Fixes: cd1915460861 ("drm/i915: Adjust CDCLK accordingly to our DBuf bw needs") --- drivers/gpu/drm/i915/display/intel_cdclk.c | 12 1 file changed, 12 insertions(+) diff --git

[Intel-gfx] [PATCH] drm/i915/display: Avoid PSR and FBC features concurently.

2020-06-08 Thread Jason Le
Issue: Enble both PSR and FBC caused some fickers on some eDP panels (eg. Panel GIS 13.5" QHD Glare NE135FBM-N41/NC135GFL02). Disbling either PSR or FBC will solve this flicker issue. Both PSR and FBC features save power when render is not busy. When PSR is active, saving power achieved by