Re: [Intel-gfx] [PATCH v2 05/27] drm/i915/gvt: Verify VFIO-pinned page is THP when shadowing 2M gtt entry

2023-03-16 Thread Yan Zhao
On Fri, Mar 10, 2023 at 04:22:36PM -0800, Sean Christopherson wrote: > When shadowing a GTT entry with a 2M page, explicitly verify that the > first page pinned by VFIO is a transparent hugepage instead of assuming > that page observed by is_2MB_gtt_possible() is the same page pinned by >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/audio: update audio keepalive clock values

2023-03-16 Thread Patchwork
== Series Details == Series: drm/i915/audio: update audio keepalive clock values URL : https://patchwork.freedesktop.org/series/115300/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872_full -> Patchwork_115300v1_full

[Intel-gfx] [PATCH] drm/i915/gt: Consider multi-gt at all places

2023-03-16 Thread Tejas Upadhyay
In order to make igt_live_test work in proper way, we need to consider multi-gt in all tests where igt_live_test is used as well as at other random places where multi-gt should be considered. Cc: Andi Shyti Signed-off-by: Tejas Upadhyay --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 13

Re: [Intel-gfx] [PATCH v6 02/12] drm/i915/mtl: Synchronize i915/BIOS on C6 enabling

2023-03-16 Thread Dixit, Ashutosh
On Thu, 16 Mar 2023 20:43:39 -0700, Dixit, Ashutosh wrote: > > On Wed, 15 Mar 2023 18:00:51 -0700, Umesh Nerlige Ramappa wrote: > > > > From: Vinay Belgaumkar > > Hi Vinay, > > > If BIOS enables/disables C6, i915 should do the same. > > So MTL bios has a control for enabling/disabling C6? Both

Re: [Intel-gfx] [PATCH v6 12/12] drm/i915/perf: Wa_14017512683: Disable OAM if media C6 is enabled in BIOS

2023-03-16 Thread Dixit, Ashutosh
On Wed, 15 Mar 2023 18:01:01 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, Mostly looks good but one nit below. > OAM does not work with media C6 enabled on some steppings of MTL. > Disable OAM if we detect that media C6 was enabled in bios. > > Signed-off-by: Umesh Nerlige Ramappa > --- >

Re: [Intel-gfx] [PATCH v6 11/12] drm/i915/perf: Pass i915 object to perf revision helper

2023-03-16 Thread Dixit, Ashutosh
On Wed, 15 Mar 2023 18:01:00 -0700, Umesh Nerlige Ramappa wrote: > > In some cases, perf revision may rely on specific steppings of a > platform. To determine the platform, pass i915 object to the perf > revision helper. Reviewed-by: Ashutosh Dixit

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: perform uc late init after probe error injection (rev2)

2023-03-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: perform uc late init after probe error injection (rev2) URL : https://patchwork.freedesktop.org/series/115137/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872_full -> Patchwork_115137v2_full

Re: [Intel-gfx] [PATCH v2 03/27] drm/i915/gvt: remove interface intel_gvt_is_valid_gfn

2023-03-16 Thread Yan Zhao
Tested-by: Yan Zhao On Fri, Mar 10, 2023 at 04:22:34PM -0800, Sean Christopherson wrote: > From: Yan Zhao > > Currently intel_gvt_is_valid_gfn() is called in two places: > (1) shadowing guest GGTT entry > (2) shadowing guest PPGTT leaf entry, > which was introduced in commit cc753fbe1ac4 >

Re: [Intel-gfx] [PATCH v2 01/27] drm/i915/gvt: Verify pfn is "valid" before dereferencing "struct page"

2023-03-16 Thread Yan Zhao
Reviewed-by: Yan Zhao On Fri, Mar 10, 2023 at 04:22:32PM -0800, Sean Christopherson wrote: > Check that the pfn found by gfn_to_pfn() is actually backed by "struct > page" memory prior to retrieving and dereferencing the page. KVM > supports backing guest memory with VM_PFNMAP, VM_IO, etc., and

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915_pm_rps: Enable waitboost tests for SLPC

2023-03-16 Thread Dixit, Ashutosh
On Tue, 14 Mar 2023 11:06:40 -0700, Vinay Belgaumkar wrote: > > Waitboost is supported with SLPC. Re-enable the tests so > we have coverage. Reviewed-by: Ashutosh Dixit

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/audio: update audio keepalive clock values

2023-03-16 Thread Patchwork
== Series Details == Series: drm/i915/audio: update audio keepalive clock values URL : https://patchwork.freedesktop.org/series/115300/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872 -> Patchwork_115300v1 Summary

Re: [Intel-gfx] [PATCH] drm/i915/selftests: keep same cache settings as timeline

2023-03-16 Thread Yang, Fei
>> From: Fei Yang >> >> On MTL, objects allocated through i915_gem_object_create_internal() are >> mapped as uncached in GPU by default because HAS_LLC is false. However >> in the live_hwsp_read selftest these watcher objects are mapped as WB >> on CPU side. The conseqence is that the updates

Re: [Intel-gfx] [PATCH v6 02/12] drm/i915/mtl: Synchronize i915/BIOS on C6 enabling

2023-03-16 Thread Dixit, Ashutosh
On Wed, 15 Mar 2023 18:00:51 -0700, Umesh Nerlige Ramappa wrote: > > From: Vinay Belgaumkar Hi Vinay, > If BIOS enables/disables C6, i915 should do the same. So MTL bios has a control for enabling/disabling C6? Both RC6 and MC6 individually or collectively? What happens if bios has disabled

Re: [Intel-gfx] [PATCH v7 15/22] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Friday, March 17, 2023 11:07 AM > > > From: Tian, Kevin > > Sent: Friday, March 17, 2023 10:14 AM > > > > > From: Liu, Yi L > > > Sent: Thursday, March 16, 2023 8:55 PM > > > > > > +void vfio_iommufd_physical_detach_ioas(struct vfio_device *vdev) > > > +{ > > > +

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Simplify vcs/bsc engine selection

2023-03-16 Thread Patchwork
== Series Details == Series: drm/i915: Simplify vcs/bsc engine selection URL : https://patchwork.freedesktop.org/series/115271/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872_full -> Patchwork_115271v1_full Summary

Re: [Intel-gfx] [PATCH v7 15/22] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-03-16 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Friday, March 17, 2023 10:14 AM > > > From: Liu, Yi L > > Sent: Thursday, March 16, 2023 8:55 PM > > > > +void vfio_iommufd_physical_detach_ioas(struct vfio_device *vdev) > > +{ > > + lockdep_assert_held(>dev_set->lock); > > + > > + if

[Intel-gfx] ✗ Fi.CI.BAT: failure for More MTL WA and powerwell patches (rev2)

2023-03-16 Thread Patchwork
== Series Details == Series: More MTL WA and powerwell patches (rev2) URL : https://patchwork.freedesktop.org/series/115292/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12872 -> Patchwork_115292v2 Summary ---

Re: [Intel-gfx] [PATCH v7 22/22] docs: vfio: Add vfio device cdev description

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:56 PM > > This gives notes for userspace applications on device cdev usage. > > Signed-off-by: Yi Liu Reviewed-by: Kevin Tian

Re: [Intel-gfx] [PATCH v7 19/22] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-16 Thread Tian, Kevin
> From: Yi Liu > Sent: Thursday, March 16, 2023 8:56 PM > > + > +static int vfio_device_cdev_enable_noiommu(struct vfio_device *device) > +{ > + if (!vfio_device_is_noiommu(device)) > + return -EINVAL; > + > + if (!capable(CAP_SYS_RAWIO)) > + return -EPERM; > + > +

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/regs: split display regs by function

2023-03-16 Thread Patchwork
== Series Details == Series: drm/i915/regs: split display regs by function URL : https://patchwork.freedesktop.org/series/115269/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872_full -> Patchwork_115269v1_full Summary

Re: [Intel-gfx] [PATCH v7 17/22] vfio-iommufd: Add detach_ioas support for emulated VFIO devices

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:55 PM > + > +void vfio_iommufd_emulated_detach_ioas(struct vfio_device *vdev) > +{ > + lockdep_assert_held(>dev_set->lock); > + > + if (WARN_ON(!vdev->iommufd_access) || !vdev->iommufd_attached) > + return; > + ditto the

Re: [Intel-gfx] [PATCH v7 15/22] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:55 PM > > +void vfio_iommufd_physical_detach_ioas(struct vfio_device *vdev) > +{ > + lockdep_assert_held(>dev_set->lock); > + > + if (WARN_ON(!vdev->iommufd_device) || !vdev->iommufd_attached) > + return; > + the 2nd check

Re: [Intel-gfx] [PATCH v7 16/22] iommufd/device: Add iommufd_access_detach() API

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:55 PM > > From: Nicolin Chen > > Previously, the detach routine is only done by the destroy(). And it was > called by vfio_iommufd_emulated_unbind() when the device runs close(), so > all the mappings in iopt were cleaned in that setup, when

Re: [Intel-gfx] [PATCH v7 14/22] vfio: Record devid in vfio_device_file

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:55 PM > > .bind_iommufd() will generate an ID to represent this bond, which is > needed by userspace for further usage. Store devid in vfio_device_file > to avoid passing the pointer in multiple places. > > Signed-off-by: Yi Liu

Re: [Intel-gfx] [PATCH v7 13/22] vfio-iommufd: Split bind/attach into two steps

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:55 PM > > to align with the coming vfio device cdev support. > > Signed-off-by: Yi Liu Reviewed-by: Kevin Tian

Re: [Intel-gfx] [PATCH v7 12/22] vfio-iommufd: Move noiommu support out of vfio_iommufd_bind()

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:55 PM > > @@ -192,6 +192,15 @@ static int vfio_device_group_open(struct > vfio_device_file *df) > vfio_device_group_get_kvm_safe(device); > > df->iommufd = device->group->iommufd; > + if (device->group->iommufd &&

Re: [Intel-gfx] [PATCH v7 11/22] vfio: Make vfio_device_first_open() to accept NULL iommufd for noiommu

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:55 PM > > vfio_device_first_open() requires the caller to provide either a valid > iommufd (the group path in iommufd compat mode) or a valid container > (the group path in legacy container mode). As preparation for noiommu > support in device

Re: [Intel-gfx] [PATCH v7 06/22] kvm/vfio: Accept vfio device file from userspace

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:55 PM > > This defines KVM_DEV_VFIO_FILE* and make alias with > KVM_DEV_VFIO_GROUP*. > Old userspace uses KVM_DEV_VFIO_GROUP* works as well. > > Reviewed-by: Jason Gunthorpe > Tested-by: Terrence Xu > Tested-by: Nicolin Chen > Tested-by:

Re: [Intel-gfx] [PATCH v7 03/22] vfio: Remove vfio_file_is_group()

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:55 PM > > since no user of vfio_file_is_group() now. > > Signed-off-by: Yi Liu Reviewed-by: Kevin Tian

Re: [Intel-gfx] [PATCH 7/7] vfio/pci: Accept device fd in VFIO_DEVICE_PCI_HOT_RESET ioctl

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:42 PM > > Now user can also provide an array of device fds as a 3rd method to verify > the reset ownership. It's not useful at this point when the device fds are > acquired via group fds. But it's necessary when moving to device cdev which >

[Intel-gfx] ✓ Fi.CI.IGT: success for Introduce new methods for verifying ownership in vfio PCI hot reset

2023-03-16 Thread Patchwork
== Series Details == Series: Introduce new methods for verifying ownership in vfio PCI hot reset URL : https://patchwork.freedesktop.org/series/115264/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872_full -> Patchwork_115264v1_full

Re: [Intel-gfx] [PATCH 6/7] vfio: Accpet device file from vfio PCI hot reset path

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:42 PM > > This extends both vfio_file_is_valid() and vfio_file_has_dev() to accept > device file from the vfio PCI hot reset. > > Signed-off-by: Yi Liu Reviewed-by: Kevin Tian

Re: [Intel-gfx] [PATCH 5/7] vfio: Refine vfio file kAPIs for vfio PCI hot reset

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:42 PM > > This prepares vfio core to accept vfio device file from the vfio PCI > hot reset path. vfio_file_is_group() is still kept for KVM usage. > > Signed-off-by: Yi Liu Reviewed-by: Kevin Tian

Re: [Intel-gfx] [PATCH 4/7] vfio/pci: Renaming for accepting device fd in hot reset path

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:42 PM > @@ -2469,7 +2469,8 @@ static int vfio_pci_dev_set_hot_reset(struct > vfio_device_set *dev_set, >* cannot race being opened by another user simultaneously. >* >* Otherwise all opened

Re: [Intel-gfx] [PATCH 3/7] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:42 PM > > as an alternative method for ownership check when iommufd is used. In > this case all opened devices in the affected dev_set are verified to > be bound to a same valid iommufd value to allow reset. It's simpler > and faster as user

Re: [Intel-gfx] [PATCH v2 5/5] vfio: Check the presence for iommufd callbacks in __vfio_register_dev()

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:15 PM > > After making the no-DMA drivers (samples/vfio-mdev) providing iommufd > callbacks, __vfio_register_dev() should check the presence of the iommufd > callbacks if CONFIG_IOMMUFD is enabled. > > Reviewed-by: Jason Gunthorpe >

Re: [Intel-gfx] [PATCH v2 4/5] vfio/mdev: Uses the vfio emulated iommufd ops set in the mdev sample drivers

2023-03-16 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 16, 2023 8:15 PM > > This harmonizes the no-DMA devices (the vfio-mdev sample drivers) with > the emulated devices (gvt-g, vfio-ap etc.). It makes it easier to add > BIND_IOMMUFD user interface which requires to return an iommufd ID to > represent the

Re: [Intel-gfx] [PATCH v2 2/5] vfio-iommufd: No need to record iommufd_ctx in vfio_device

2023-03-16 Thread Tian, Kevin
> From: Yi Liu > Sent: Thursday, March 16, 2023 8:15 PM > > iommufd_ctx is stored in vfio_device for emulated devices per > bind_iommufd. > However, as iommufd_access is created in bind, no more need to stored it > since iommufd_access implicitly stores it. > > Reviewed-by: Jason Gunthorpe >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: perform uc late init after probe error injection (rev2)

2023-03-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: perform uc late init after probe error injection (rev2) URL : https://patchwork.freedesktop.org/series/115137/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872 -> Patchwork_115137v2

Re: [Intel-gfx] [PATCH v11 06/11] drm/i915/dp: Consider output_format while computing dsc bpp for mode_valid

2023-03-16 Thread Ville Syrjälä
On Tue, Mar 14, 2023 at 04:34:10PM +0530, Ankit Nautiyal wrote: > During modevalid step, the pipe bpp is computed assuming RGB output > format. When checking with DSC, consider the output_format and compute > the input bpp for DSC appropriately. > > v2: For DP-MST we currently use RGB output

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-16 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, March 17, 2023 8:23 AM > > On Thu, 16 Mar 2023 23:29:21 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson > > > Sent: Friday, March 17, 2023 2:46 AM > > > > > > On Wed, 15 Mar 2023 23:31:23 + > > > "Tian, Kevin" wrote: > > > > > > > > From:

Re: [Intel-gfx] [PATCH v11 05/11] drm/i915/dp: Rearrange check for illegal mode and comments in mode_valid

2023-03-16 Thread Ville Syrjälä
On Tue, Mar 14, 2023 at 04:34:09PM +0530, Ankit Nautiyal wrote: > Check for MODE_H_ILLEGAL before calculating max rates, lanes etc. > Move comments about compressed bpp U6.4 format closer to where it is used. > > Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH v11 04/11] drm/i915/display: Use sink_format instead of ycbcr420_output flag

2023-03-16 Thread Ville Syrjälä
On Tue, Mar 14, 2023 at 04:34:08PM +0530, Ankit Nautiyal wrote: > Start passing the sink_format, to all functions that take a bool > ycbcr420_output as parameter. This will make the functions generic, > and will serve as a slight step towards 4:2:2 support later. > > v2: Rebased. > >

Re: [Intel-gfx] [PATCH v11 01/11] drm/i915/display: Add new member to configure PCON color conversion

2023-03-16 Thread Ville Syrjälä
On Tue, Mar 14, 2023 at 04:34:05PM +0530, Ankit Nautiyal wrote: > The decision to use DFP output format conversion capabilities should be > during compute_config phase. > > This patch adds new member to crtc_state to represent the final > output_format to the sink. In case of a DFP this can be

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-16 Thread Alex Williamson
On Thu, 16 Mar 2023 23:29:21 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Friday, March 17, 2023 2:46 AM > > > > On Wed, 15 Mar 2023 23:31:23 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson > > > > Sent: Thursday, March 16, 2023 6:53 AM > > > > I'm afraid

Re: [Intel-gfx] [PATCH] drm/i915/selftests: keep same cache settings as timeline

2023-03-16 Thread Matt Roper
On Wed, Mar 15, 2023 at 11:08:00AM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > On MTL, objects allocated through i915_gem_object_create_internal() are > mapped as uncached in GPU by default because HAS_LLC is false. However > in the live_hwsp_read selftest these watcher objects are

Re: [Intel-gfx] [PATCH dii-client v1.1] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step

2023-03-16 Thread Lucas De Marchi
On Thu, Mar 16, 2023 at 01:41:43PM -0700, Radhakrishna Sripada wrote: From: Madhumitha Tolakanahalli Pradeep Wa_22011802037 was being applied to all graphics_ver 11 & 12. This patch updates the if statement to apply the W/A to right platforms and extends it to MTL-M:A0. it should be any A

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Simplify vcs/bsc engine selection

2023-03-16 Thread Patchwork
== Series Details == Series: drm/i915: Simplify vcs/bsc engine selection URL : https://patchwork.freedesktop.org/series/115271/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872 -> Patchwork_115271v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/display: Audio keep alive timestamp cdclk divisors

2023-03-16 Thread Taylor, Clinton A
Wrong patch sent in error. PLease ignore this version. -Clint On Thu, 2023-03-16 at 14:46 -0700, Clint Taylor wrote: > From: "Taylor, Clinton A" > > Use BSPEC values for the Audio Keep alive M and N values as included in > the cdclk BSPEC pages for display > 13 > > BSPEC: 54034, 55409 > Cc:

Re: [Intel-gfx] [PATCH v11 03/11] drm/i915/dp: Replace intel_dp.dfp members with the new crtc_state sink_format

2023-03-16 Thread Ville Syrjälä
On Tue, Mar 14, 2023 at 04:34:07PM +0530, Ankit Nautiyal wrote: > The decision to use DFP output format conversion capabilities should be > during compute_config phase. > > This patch uses the members of intel_dp->dfp to only store the > format conversion capabilities of the DP device and uses

[Intel-gfx] [PATCH] drm/i915/audio: update audio keepalive clock values

2023-03-16 Thread Clint Taylor
BSPEC has updated the cdclk audio keepalives AUD_TS_CDCLK_M value to 60 for all supported platforms and refclks. BSPEC: 54034 BSPEC: 55409 BSPEC: 65243 Cc: Kai Vehmanen Cc: Uma Shankar Cc: Ville Syrjälä Signed-off-by: Clint Taylor --- drivers/gpu/drm/i915/display/intel_audio.c | 6 +- 1

Re: [Intel-gfx] [Freedreno] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-03-16 Thread Abhinav Kumar
On 3/16/2023 9:36 AM, Abhinav Kumar wrote: On 3/16/2023 9:23 AM, Dmitry Baryshkov wrote: On 16/03/2023 18:13, Abhinav Kumar wrote: On 3/16/2023 9:03 AM, Dmitry Baryshkov wrote: Hi, [removed previous conversation] Hi Dmitry and Abhinav, Just wanted to follow up on this thread. I've

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-16 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, March 17, 2023 2:46 AM > > On Wed, 15 Mar 2023 23:31:23 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson > > > Sent: Thursday, March 16, 2023 6:53 AM > > > I'm afraid this proposal reduces or eliminates the handshake we have > > > with

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/regs: split display regs by function

2023-03-16 Thread Patchwork
== Series Details == Series: drm/i915/regs: split display regs by function URL : https://patchwork.freedesktop.org/series/115269/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872 -> Patchwork_115269v1 Summary ---

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-16 Thread Rob Clark
On Thu, Mar 16, 2023 at 3:22 PM Sebastian Wick wrote: > > On Thu, Mar 16, 2023 at 5:29 PM Rob Clark wrote: > > > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > > > > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Clark wrote: > > > > On Wed, Mar 15, 2023 at 6:53 AM Jonas Ådahl

Re: [Intel-gfx] [PATCH 2/7] drm/tegra: allow compile test on !ARM

2023-03-16 Thread kernel test robot
://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-tegra-allow-compile-test-on-ARM/20230316-172205 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r

Re: [Intel-gfx] [PATCH 4/7] drm/debugfs: rework debugfs directory creation v2

2023-03-16 Thread kernel test robot
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.3-rc2 next-20230316] [cannot apply to drm-tip/drm-tip tegra/for-next] [If your patch

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tc: Fix a few TypeC / MST issues

2023-03-16 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix a few TypeC / MST issues URL : https://patchwork.freedesktop.org/series/115270/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12872 -> Patchwork_115270v1 Summary ---

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-16 Thread Sebastian Wick
On Thu, Mar 16, 2023 at 5:29 PM Rob Clark wrote: > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Clark wrote: > > > On Wed, Mar 15, 2023 at 6:53 AM Jonas Ådahl wrote: > > > > > > > > On Fri, Mar 10, 2023 at 09:38:18AM -0800, Rob Clark

[Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Improve GuC load error reporting

2023-03-16 Thread John . C . Harrison
From: John Harrison There are multiple ways in which the GuC load can fail. The driver was reporting the status register as is, but not everyone can read the matrix unfiltered. So add decoding of the common error cases. Also, remove the comment about interrupt based load completion checking

[Intel-gfx] [PATCH v2 0/2] Improvements to GuC load failure handling

2023-03-16 Thread John . C . Harrison
From: John Harrison Add more decoding of the GuC load failures. Also include information about GT frequency to see if timeouts are due to a failure to boost the clocks. Finally, increase the timeout to accommodate situations where the clock boost does fail. v2: Reduce timeout in release builds,

[Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Allow for very slow GuC loading

2023-03-16 Thread John . C . Harrison
From: John Harrison A failure to load the GuC is occasionally observed where the GuC log actually showed that the GuC had loaded just fine. The implication being that the load just took ever so slightly longer than the 200ms timeout. Given that the actual time should be tens of milliseconds at

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev8)

2023-03-16 Thread Patchwork
== Series Details == Series: Add vfio_device cdev for iommufd support (rev8) URL : https://patchwork.freedesktop.org/series/113696/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113696/revisions/8/mbox/ not applied Applying: vfio: Allocate per

[Intel-gfx] [PATCH] drm/i915/display: Audio keep alive timestamp cdclk divisors

2023-03-16 Thread Clint Taylor
From: "Taylor, Clinton A" Use BSPEC values for the Audio Keep alive M and N values as included in the cdclk BSPEC pages for display > 13 BSPEC: 54034, 55409 Cc: Kai Vehmanen Cc: Uma Shankar Cc: Ville Syrjälä Signed-off-by: Taylor, Clinton A --- drivers/gpu/drm/i915/display/intel_audio.c |

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce new methods for verifying ownership in vfio PCI hot reset

2023-03-16 Thread Patchwork
== Series Details == Series: Introduce new methods for verifying ownership in vfio PCI hot reset URL : https://patchwork.freedesktop.org/series/115264/ State : success == Summary == CI Bug Log - changes from CI_DRM_12872 -> Patchwork_115264v1

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-16 Thread Nicolin Chen
On Thu, Mar 16, 2023 at 01:22:58PM +, Liu, Yi L wrote: > > And regarding the new baseline for the replace series and the > > nesting series, it'd be nicer to have another one git-merging > > your cdev v7 branch on top of Jason's iommufd_hwpt branch. We > > could wait for him updating to

Re: [Intel-gfx] [PATCH v10 00/15] dma-fence: Deadline awareness

2023-03-16 Thread Rob Clark
On Wed, Mar 8, 2023 at 7:53 AM Rob Clark wrote: > > From: Rob Clark > > This series adds a deadline hint to fences, so realtime deadlines > such as vblank can be communicated to the fence signaller for power/ > frequency management decisions. > > This is partially inspired by a trick i915 does,

Re: [Intel-gfx] [PATCH 5.4.y] drm/i915: Don't use BAR mappings for ring buffers with LLC

2023-03-16 Thread John Harrison
On 3/15/2023 10:57, Greg KH wrote: On Wed, Mar 15, 2023 at 10:07:53AM -0700, John Harrison wrote: On 3/15/2023 00:51, Greg KH wrote: On Mon, Mar 13, 2023 at 07:22:11PM -0700, john.c.harri...@intel.com wrote: From: John Harrison Direction from hardware is that ring buffers should never be

[Intel-gfx] [PATCH dii-client v1.1] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step

2023-03-16 Thread Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep Wa_22011802037 was being applied to all graphics_ver 11 & 12. This patch updates the if statement to apply the W/A to right platforms and extends it to MTL-M:A0. v1.1: Fix checkpatch warning. Signed-off-by: Madhumitha Tolakanahalli Pradeep

[Intel-gfx] [PATCH 5/5] drm/i915/mtl: WA to clear RDOP clock gating

2023-03-16 Thread Radhakrishna Sripada
From: Haridhar Kalvala Workaround implementation to clear RDOP clock gating. Bspec: 33453 Signed-off-by: Haridhar Kalvala Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Intel-gfx] [PATCH 4/5] drm/i915/mtl: Synchronize i915/BIOS on C6 enabling

2023-03-16 Thread Radhakrishna Sripada
From: Vinay Belgaumkar If BIOS enables/disables C6, i915 should do the same. Also, retain this value across driver reloads. This is needed only for MTL as of now due to an existing bug in OA which needs C6 disabled for it to function. BIOS behavior is also different across platforms in terms of

[Intel-gfx] [PATCH 3/5] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step

2023-03-16 Thread Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep Wa_22011802037 was being applied to all graphics_ver 11 & 12. This patch updates the if statement to apply the W/A to right platforms and extends it to MTL-M:A0. Signed-off-by: Madhumitha Tolakanahalli Pradeep Signed-off-by: Radhakrishna Sripada ---

[Intel-gfx] [PATCH 2/5] drm/i915/mtl: Re-use ADL-P's "DC off" power well

2023-03-16 Thread Radhakrishna Sripada
From: Matt Roper As with ADL-P, MTL's "DC off" power well should be a dependency of the PGC and PGD power wells, not the entire PG2 well. In fact, the DC5/DC6 requirements between the two platforms are the same, so the Xe_LPD "DC off" well definition can just be re-used for Xe_LPD+. Bspec:

[Intel-gfx] [PATCH 0/5] More MTL WA and powerwell patches

2023-03-16 Thread Radhakrishna Sripada
This series adds 2 MTL WA's, 2 patches to fix re-use "DC off" power wells and another patch to sync BIOS and driver for C6 enabling. Haridhar Kalvala (1): drm/i915/mtl: WA to clear RDOP clock gating Madhumitha Tolakanahalli Pradeep (1): drm/i915/mtl: Extend Wa_22011802037 to MTL A-step Matt

[Intel-gfx] [PATCH 1/5] drm/i915: Use separate "DC off" power well for ADL-P and DG2

2023-03-16 Thread Radhakrishna Sripada
From: Matt Roper Although ADL-P and DG2 both use the same general power well setup, the DC5/DC6 requirements are slightly different which means each platform should have its own "DC off" power well. DG2 (i.e., Xe_HPD IP) requires that DC5 be disabled whenever PG2 is active. However ADL-P

[Intel-gfx] ✗ Fi.CI.BAT: failure for vfio: Make emulated devices prepared for vfio device cdev (rev3)

2023-03-16 Thread Patchwork
== Series Details == Series: vfio: Make emulated devices prepared for vfio device cdev (rev3) URL : https://patchwork.freedesktop.org/series/114846/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12871 -> Patchwork_114846v3

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-16 Thread Alex Williamson
On Wed, 15 Mar 2023 23:31:23 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Thursday, March 16, 2023 6:53 AM > > > > On Wed, 8 Mar 2023 05:28:51 -0800 > > Yi Liu wrote: > > > > > This is another method to issue PCI hot reset for the users that bounds > > > device to a

Re: [Intel-gfx] [PATCH] drm/i915/gem: Clarify seemingly unaccounted obj refcount inc

2023-03-16 Thread Das, Nirmoy
On 3/15/2023 11:54 AM, Nirmoy Das wrote: Add a comment why there is a obj refcount inc before installing the vm_ops for the mmap call. Also remove the invalid older comment as drm API(drm_gem_prime_mmap()) will hold an obj reference before calling this driver mmap callback so we can't have

Re: [Intel-gfx] [PATCH 1/2] drm/i915/psr: Fix Wa_16013835468 and Wa_14015648006

2023-03-16 Thread Ville Syrjälä
On Tue, Mar 14, 2023 at 11:01:41AM +0200, Jouni Högander wrote: > PSR WM optimization should be disabled based on any wm level being > disabled. Currently it's disabled always when using delayed vblank. > > Bspec: 71580 > > Signed-off-by: Jouni Högander > --- >

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: prevent forcewake releases during BAR resize

2023-03-16 Thread Andrzej Hajda
On 08.03.2023 14:36, Andrzej Hajda wrote: Tests on DG2 machines show that releasing forcewakes during BAR resize results later in forcewake ack timeouts. Since forcewakes can be realeased asynchronously the simplest way to prevent it is to get all forcewakes for duration of BAR resizing. v2:

Re: [Intel-gfx] [PATCH v6 0/2] drm/i915: add guard page to ggtt->error_capture

2023-03-16 Thread Andrzej Hajda
On 10.03.2023 10:23, Andrzej Hajda wrote: This patch tries to diminish plague of DMAR read errors present in CI for ADL*, RPL*, DG2 platforms, see for example [1] (grep DMAR). CI is usually tolerant for these errors, so the scale of the problem is not really visible. To show it I have counted

[Intel-gfx] [RFC PATCH 2/2] drm/i915/display: Implement fb_mmap callback function

2023-03-16 Thread Nirmoy Das
If stolen memory allocation fails for fbdev, the driver will fallback to system memory. Calculation of smem_start is wrong for such framebuffer objs if the platform comes with no gmadr or no aperture. Solve this by adding fb_mmap callback which will use GTT if aperture is available otherwise will

[Intel-gfx] [RFC PATCH 1/2] drm/i915: Add a function to mmap framebuffer obj

2023-03-16 Thread Nirmoy Das
Implement i915_gem_fb_mmap() to enable fb_ops.fb_mmap() callback for i915's framebuffer objects. v2: add a comment why i915_gem_object_get() needed(Andi). Cc: Matthew Auld Cc: Andi Shyti Cc: Ville Syrjälä Cc: Jani Nikula Cc: Imre Deak Signed-off-by: Nirmoy Das ---

Re: [Intel-gfx] [PATCH] drm/i915/huc: Cancel HuC delayed load timer on reset.

2023-03-16 Thread Teres Alexis, Alan Previn
Reviewed-by: Alan Previn P.S. side note - while reviewing this, i wish we got rid of those "ops_on/off->intel_uc_funcname" macro obsfucations since i couldnt find intel_uc_sanitize but did find the direct call - so inconsistent. On Mon, 2023-03-13 at 13:55 -0700, Ceraolo Spurio, Daniele

[Intel-gfx] [PATCH] drm/i915/gem: Flush lmem contents after construction

2023-03-16 Thread Nirmoy Das
From: Chris Wilson i915_gem_object_create_lmem_from_data() lacks the flush of the data written to lmem to ensure the object is marked as dirty and the writes flushed to the backing store. Once created, we can immediately release the obj->mm.mapping caching of the vmap. Fixes: 7acbbc7cf485

Re: [Intel-gfx] [PATCH 0/7] drm/i915/regs: split display regs by function

2023-03-16 Thread Das, Nirmoy
On 3/16/2023 2:29 PM, Jani Nikula wrote: Shave off 1.2k lines from i915_reg.h. Jani Nikula (7): drm/i915/pps: split out PPS regs to a separate file drm/i915/tv: split out TV regs to a separate file drm/i915/aux: split out DP AUX regs to a separate file drm/i915/fdi: split out FDI

Re: [Intel-gfx] [Freedreno] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-03-16 Thread Abhinav Kumar
On 3/16/2023 9:23 AM, Dmitry Baryshkov wrote: On 16/03/2023 18:13, Abhinav Kumar wrote: On 3/16/2023 9:03 AM, Dmitry Baryshkov wrote: Hi, [removed previous conversation] Hi Dmitry and Abhinav, Just wanted to follow up on this thread. I've gone over the MSM-specific DSC params for

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-16 Thread Rob Clark
On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Clark wrote: > > On Wed, Mar 15, 2023 at 6:53 AM Jonas Ådahl wrote: > > > > > > On Fri, Mar 10, 2023 at 09:38:18AM -0800, Rob Clark wrote: > > > > On Fri, Mar 10, 2023 at 7:45 AM Jonas Ådahl

Re: [Intel-gfx] [Freedreno] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-03-16 Thread Dmitry Baryshkov
On 16/03/2023 18:13, Abhinav Kumar wrote: On 3/16/2023 9:03 AM, Dmitry Baryshkov wrote: Hi, [removed previous conversation] Hi Dmitry and Abhinav, Just wanted to follow up on this thread. I've gone over the MSM-specific DSC params for DP and DSI and have found a few shared calculations

Re: [Intel-gfx] [Freedreno] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-03-16 Thread Abhinav Kumar
On 3/16/2023 9:03 AM, Dmitry Baryshkov wrote: Hi, [removed previous conversation] Hi Dmitry and Abhinav, Just wanted to follow up on this thread. I've gone over the MSM-specific DSC params for DP and DSI and have found a few shared calculations and variables between both DSI and DP

Re: [Intel-gfx] [PATCH v5 02/12] drm/i915/mtl: Synchronize i915/BIOS on C6 enabling

2023-03-16 Thread Umesh Nerlige Ramappa
On Wed, Mar 15, 2023 at 05:09:22PM -0700, Umesh Nerlige Ramappa wrote: From: Vinay Belgaumkar If BIOS enables/disables C6, i915 should do the same. Also, retain this value across driver reloads. This is needed only for MTL as of now due to an existing bug in OA which needs C6 disabled for it

Re: [Intel-gfx] [Freedreno] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-03-16 Thread Dmitry Baryshkov
Hi, [removed previous conversation] > > Hi Dmitry and Abhinav, > > Just wanted to follow up on this thread. I've gone over the MSM-specific > DSC params for DP and DSI and have found a few shared calculations and > variables between both DSI and DP paths: > > - (as mentioned earlier in the

Re: [Intel-gfx] [PATCH] drm/i915: Simplify vcs/bsc engine selection

2023-03-16 Thread Das, Nirmoy
On 3/16/2023 3:27 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin No need to look at the mask of present engines when we already have a count stored ever since e2d0ff3525b9 ("drm/i915: Count engine instances per uabi class"). Signed-off-by: Tvrtko Ursulin Cc: Jonathan Cavitt

[Intel-gfx] [PULL] drm-misc-next

2023-03-16 Thread Maarten Lankhorst
Hi Dave, Daniel, Here's the new weekly pull request for v6.4-rc1. I've omitted the diffstat, as it was huge because v6.3-rc1 was backmerged. Cheers, ~Maarten drm-misc-next-2023-03-16: drm-misc-next for v6.4-rc1: Cross-subsystem Changes: - Add drm_bridge.h to drm_bridge maintainers. Core

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for Provision to ignore long HPDs in CI systems (rev5)

2023-03-16 Thread Imre Deak
On Wed, Feb 15, 2023 at 10:57:54PM +, Patchwork wrote: > == Series Details == > > Series: Provision to ignore long HPDs in CI systems (rev5) > URL : https://patchwork.freedesktop.org/series/109475/ > State : success Thanks for the patchset, pushed it to din. > > == Summary == > > CI Bug

[Intel-gfx] [PULL] drm-misc-fixes

2023-03-16 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2023-03-16: Short summary of fixes pull: * fix info leak in edid * build fix for accel/ * ref-counting fix for fbdev deferred I/O * driver fixes The following changes since commit

[Intel-gfx] [PATCH] drm/i915: Simplify vcs/bsc engine selection

2023-03-16 Thread Tvrtko Ursulin
From: Tvrtko Ursulin No need to look at the mask of present engines when we already have a count stored ever since e2d0ff3525b9 ("drm/i915: Count engine instances per uabi class"). Signed-off-by: Tvrtko Ursulin Cc: Jonathan Cavitt --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 10

Re: [Intel-gfx] [PATCH] drm/i915/opregion: Fix CONFIG_ACPI=n builds adding missing intel_opregion_cleanup() prototype

2023-03-16 Thread Imre Deak
On Tue, Mar 14, 2023 at 10:43:50AM +0100, Das, Nirmoy wrote: > > On 3/14/2023 10:27 AM, Imre Deak wrote: > > Add the missing intel_opregion_cleanup() prototype fixing CONFIG_ACPI=n > > builds. > > > > Fixes: 3e226e4a2180 ("drm/i915/opregion: Cleanup opregion after errors > > during driver

[Intel-gfx] [PATCH 7/7] drm/i915/dsb: split out DSB regs to a separate file

2023-03-16 Thread Jani Nikula
Clean up i915_reg.h by splitting out DSB regs to display/intel_dsb_regs.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dsb.c | 1 + drivers/gpu/drm/i915/display/intel_dsb_regs.h | 67 +++ drivers/gpu/drm/i915/i915_reg.h | 56

[Intel-gfx] [PATCH 6/7] drm/i915/psr: split out PSR regs to a separate file

2023-03-16 Thread Jani Nikula
Clean up i915_reg.h by splitting out PSR regs to display/intel_psr_regs.h. Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_debugfs.c | 1 + drivers/gpu/drm/i915/display/intel_psr.c | 1 + drivers/gpu/drm/i915/display/intel_psr_regs.h | 260 ++

  1   2   3   >