[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsi: ICL+ DSI modeset sequence fixes (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/dsi: ICL+ DSI modeset sequence fixes (rev2) URL : https://patchwork.freedesktop.org/series/116926/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253_full -> Patchwork_116926v2_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: further device info cleanups

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915: further device info cleanups URL : https://patchwork.freedesktop.org/series/119086/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13253_full -> Patchwork_119086v1_full Summary ---

Re: [Intel-gfx] [PATCH V2] PCI: Move VMD ASPM/LTR fix to PCI quirk

2023-06-09 Thread David E. Box
On Fri, 2023-06-09 at 17:46 -0500, Bjorn Helgaas wrote: > On Fri, Jun 09, 2023 at 03:09:26PM -0700, David E. Box wrote: > > Hi Bjorn, > > > > On Thu, 2023-06-08 at 15:52 -0500, Bjorn Helgaas wrote: > > > On Tue, Apr 11, 2023 at 02:33:23PM -0700, David E. Box wrote: > > > > In commit f492edb40b54

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: implement internal workqueues (rev4)

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev4) URL : https://patchwork.freedesktop.org/series/118947/ State : success == Summary == CI Bug Log - changes from CI_DRM_13252_full -> Patchwork_118947v4_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc/slpc: Apply min softlimit correctly

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Apply min softlimit correctly URL : https://patchwork.freedesktop.org/series/119162/ State : success == Summary == CI Bug Log - changes from CI_DRM_13257 -> Patchwork_119162v1 Summary ---

Re: [Intel-gfx] [PATCH V2] PCI: Move VMD ASPM/LTR fix to PCI quirk

2023-06-09 Thread Bjorn Helgaas
On Fri, Jun 09, 2023 at 03:09:26PM -0700, David E. Box wrote: > Hi Bjorn, > > On Thu, 2023-06-08 at 15:52 -0500, Bjorn Helgaas wrote: > > On Tue, Apr 11, 2023 at 02:33:23PM -0700, David E. Box wrote: > > > In commit f492edb40b54 ("PCI: vmd: Add quirk to configure PCIe ASPM and > > > LTR") the VMD

Re: [Intel-gfx] [PATCH V2] PCI: Move VMD ASPM/LTR fix to PCI quirk

2023-06-09 Thread David E. Box
Hi Bjorn, On Thu, 2023-06-08 at 15:52 -0500, Bjorn Helgaas wrote: > On Tue, Apr 11, 2023 at 02:33:23PM -0700, David E. Box wrote: > > In commit f492edb40b54 ("PCI: vmd: Add quirk to configure PCIe ASPM and > > LTR") the VMD driver calls pci_enabled_link_state as a callback from > > pci_bus_walk.

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Apply min softlimit correctly

2023-06-09 Thread Vinay Belgaumkar
We were skipping when min_softlimit was equal to RPn. We need to apply it rergardless as efficient frequency will push the SLPC min to RPe. This will break scenarios where user sets a min softlimit < RPe before reset and then performs a GT reset. Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc: Allow

[Intel-gfx] ✓ Fi.CI.BAT: success for Get optimal audio frequency and channels (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: Get optimal audio frequency and channels (rev2) URL : https://patchwork.freedesktop.org/series/119121/ State : success == Summary == CI Bug Log - changes from CI_DRM_13257 -> Patchwork_119121v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Get optimal audio frequency and channels (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: Get optimal audio frequency and channels (rev2) URL : https://patchwork.freedesktop.org/series/119121/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Restore HSW/BDW PSR1 (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/psr: Restore HSW/BDW PSR1 (rev2) URL : https://patchwork.freedesktop.org/series/116814/ State : success == Summary == CI Bug Log - changes from CI_DRM_13256 -> Patchwork_116814v2 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for x86/mm: Fix PAT bit missing from page protection modify mask (rev3)

2023-06-09 Thread Patchwork
== Series Details == Series: x86/mm: Fix PAT bit missing from page protection modify mask (rev3) URL : https://patchwork.freedesktop.org/series/116883/ State : success == Summary == CI Bug Log - changes from CI_DRM_13256 -> Patchwork_116883v3

Re: [Intel-gfx] [PATCH v12 00/24] Add vfio_device cdev for iommufd support

2023-06-09 Thread Matthew Rosato
On 6/2/23 8:16 AM, Yi Liu wrote: > Existing VFIO provides group-centric user APIs for userspace. Userspace > opens the /dev/vfio/$group_id first before getting device fd and hence > getting access to device. This is not the desired model for iommufd. Per > the conclusion of community

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Cleanup usage of phy lane reset

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Cleanup usage of phy lane reset URL : https://patchwork.freedesktop.org/series/119138/ State : success == Summary == CI Bug Log - changes from CI_DRM_13256 -> Patchwork_119138v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for fdinfo memory stats (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: fdinfo memory stats (rev2) URL : https://patchwork.freedesktop.org/series/119082/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13256 -> Patchwork_119082v2 Summary --- **FAILURE**

Re: [Intel-gfx] [RFC 2/4] drm/i915/display: Update access of has_audio param

2023-06-09 Thread Golani, Mitulkumar Ajitkumar
Hi @Jani Nikula > -Original Message- > From: Jani Nikula > Sent: 09 June 2023 15:09 > To: Golani, Mitulkumar Ajitkumar ; > intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [RFC 2/4] drm/i915/display: Update access of > has_audio param > > On Fri, 09 Jun 2023, Mitul Golani >

Re: [Intel-gfx] [RFC 1/4] drm/i915/hdmi: Add audio config related params in crtc_state

2023-06-09 Thread Golani, Mitulkumar Ajitkumar
Hi @Jani Nikula > -Original Message- > From: Jani Nikula > Sent: 09 June 2023 15:06 > To: Golani, Mitulkumar Ajitkumar ; > intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [RFC 1/4] drm/i915/hdmi: Add audio config related > params in crtc_state > > On Fri, 09 Jun 2023, Mitul

Re: [Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-09 Thread Sui Jingfeng
On 2023/6/10 00:48, Bjorn Helgaas wrote: On Fri, Jun 09, 2023 at 10:27:39AM +0800, Sui Jingfeng wrote: On 2023/6/9 03:19, Bjorn Helgaas wrote: On Thu, Jun 08, 2023 at 07:43:22PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, which

Re: [Intel-gfx] [RFC 1/4] drm/i915/hdmi: Add audio config related params in crtc_state

2023-06-09 Thread Golani, Mitulkumar Ajitkumar
Hi @Jani Nikula > -Original Message- > From: Jani Nikula > Sent: 09 June 2023 15:08 > To: Golani, Mitulkumar Ajitkumar ; > intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [RFC 1/4] drm/i915/hdmi: Add audio config related > params in crtc_state > > On Fri, 09 Jun 2023, Mitul

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-09 Thread Mitul Golani
Initialize the source audio capabilities for HDMI in crtc_state property by setting them to their maximum supported values, including max_channel and max_frequency. This allows for the calculation of HDMI audio source capabilities with respect to the available mode bandwidth. These capabilities

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-09 Thread Mitul Golani
Compute SADs that takes into account the supported rate and channel based on the capabilities of the audio source. This wrapper function should encapsulate the logic for determining the supported rate and channel and should return a set of SADs that are compatible with the source. --v1: - call

[Intel-gfx] [RFC 1/3] drm/i915/hdmi: Optimize source audio parameter handling

2023-06-09 Thread Mitul Golani
To enhance the relationship between the has_audio and the source audio parameter, create a separate crtc_state audio property and add the has_audio parameter into it. Additionally, update the access of the has_audio parameter from the crtc_state pointer as it is wrapped under the audio. These

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-09 Thread Mitul Golani
Currently we do not check if there is enough bandwidth for audio, and what channels and freq it can really support. Also sometimes there can be HW constraints e.g. GLK where audio channels supported are only 2. https://patchwork.freedesktop.org/series/107647/ Obtain the optimal audio rate and

[Intel-gfx] ✗ Fi.CI.BAT: failure for Move stolen memory handling details into i915_gem_stolen

2023-06-09 Thread Patchwork
== Series Details == Series: Move stolen memory handling details into i915_gem_stolen URL : https://patchwork.freedesktop.org/series/119123/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13256 -> Patchwork_119123v1 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Get optimal audio frequency and channels

2023-06-09 Thread Patchwork
== Series Details == Series: Get optimal audio frequency and channels URL : https://patchwork.freedesktop.org/series/119121/ State : success == Summary == CI Bug Log - changes from CI_DRM_13256 -> Patchwork_119121v1 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn

2023-06-09 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn URL : https://patchwork.freedesktop.org/series/119067/ State : success == Summary == CI Bug Log - changes from CI_DRM_13250_full -> Patchwork_119067v1_full

Re: [Intel-gfx] [PATCH 6/8] drm: Add drm_gem_prime_fd_to_handle_obj

2023-06-09 Thread Rob Clark
On Fri, Jun 9, 2023 at 7:12 AM Tvrtko Ursulin wrote: > > > On 09/06/2023 13:44, Iddamsetty, Aravind wrote: > > On 09-06-2023 17:41, Tvrtko Ursulin wrote: > >> From: Tvrtko Ursulin > >> > >> I need a new flavour of the drm_gem_prime_fd_to_handle helper, one which > >> will return a reference to a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Cable type identification for DP2.1

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/dp: Cable type identification for DP2.1 URL : https://patchwork.freedesktop.org/series/119109/ State : success == Summary == CI Bug Log - changes from CI_DRM_13255 -> Patchwork_119109v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

2023-06-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names URL : https://patchwork.freedesktop.org/series/119106/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13255 -> Patchwork_119106v1

[Intel-gfx] [linux-next:master] BUILD REGRESSION 53ab6975c12d1ad86c599a8927e8c698b144d669

2023-06-09 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 53ab6975c12d1ad86c599a8927e8c698b144d669 Add linux-next specific files for 20230609 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202306081708.gtvacxsh-...@intel.com https

Re: [Intel-gfx] [PATCH v2] drm/i915/gsc: take a wakeref for the proxy-init-completion check

2023-06-09 Thread Ceraolo Spurio, Daniele
On 6/8/2023 4:07 PM, Alan Previn wrote: Ensure intel_gsc_uc_fw_init_done and intel_gsc_uc_fw_proxy_init takes a wakeref before reading GSC Shim registers. NOTE: another patch in review also adds a call from selftest to this same function. (https://patchwork.freedesktop.org/series/117713/)

Re: [Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-09 Thread Bjorn Helgaas
On Fri, Jun 09, 2023 at 10:27:39AM +0800, Sui Jingfeng wrote: > On 2023/6/9 03:19, Bjorn Helgaas wrote: > > On Thu, Jun 08, 2023 at 07:43:22PM +0800, Sui Jingfeng wrote: > > > From: Sui Jingfeng > > > > > > The vga_is_firmware_default() function is arch-dependent, which doesn't > > > sound

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/psr: Restore HSW/BDW PSR1 (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/psr: Restore HSW/BDW PSR1 (rev2) URL : https://patchwork.freedesktop.org/series/116814/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Restore HSW/BDW PSR1 (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/psr: Restore HSW/BDW PSR1 (rev2) URL : https://patchwork.freedesktop.org/series/116814/ State : warning == Summary == Error: dim checkpatch failed 8d0ed154f842 drm/i915: Re-init clock gating on coming out of PC8+ 611fbc172ab6 drm/i915/psr: Fix BDW PSR AUX

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for x86/mm: Fix PAT bit missing from page protection modify mask (rev3)

2023-06-09 Thread Patchwork
== Series Details == Series: x86/mm: Fix PAT bit missing from page protection modify mask (rev3) URL : https://patchwork.freedesktop.org/series/116883/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-09 Thread Yang, Fei
> Hi Carl, > besides this, ask a dumb question. How we retrieve the pat_index from a shared resource though dma_buf fd? maybe we need to know whether it could be CPU cached if we want map it. Of course, looks there are no real usage to access it though CPU. Just use it

Re: [Intel-gfx] [PATCH v7 9/9] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-06-09 Thread Jason Gunthorpe
On Fri, Jun 09, 2023 at 12:13:58AM +, Liu, Yi L wrote: > > Other than this and the couple other comments, the series looks ok to > > me. We still need acks from Jason for iommufd on 3-5. Thanks, > > Thanks, perhaps one more version after getting feedback from Jason. Yes, perhaps today I

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Fix spelling mistake "initate" -> "initiate"

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix spelling mistake "initate" -> "initiate" URL : https://patchwork.freedesktop.org/series/119063/ State : success == Summary == CI Bug Log - changes from CI_DRM_13249_full -> Patchwork_119063v1_full

[Intel-gfx] [PATCH v2 13/13] drm/i915/psr: Re-enable PSR1 on hsw/bdw

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä All known issues fixed now, so re-enable PSR1 on hsw/bdw. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_device.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c

[Intel-gfx] [PATCH v2 12/13] drm/i915/psr: Allow PSR with sprite enabled on hsw/bdw

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä Can't see why we'd want the sprite blocking PSR entry. Mask it out. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 4 drivers/gpu/drm/i915/display/intel_psr.c | 4 2 files changed, 8 insertions(+) diff --git

[Intel-gfx] [PATCH v2 11/13] drm/i915/psr: Don't skip both TP1 and TP2/3 on hsw/bdw

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä WA 0479 says: "Do not skip both TP1 and TP2/TP3". Let's just stick the minimum 100us TP2/3 time in there to avoid that. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_psr.c | 9 + 1 file changed, 9 insertions(+) diff --git

[Intel-gfx] [PATCH v2 10/13] drm/i915/psr: Do no mask display register writes on hsw/bdw

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä hsw/bdw lack the pipe register vs. display register distinction in their PSR masking capabilities. So to keep our CURSURFLIVE tricks working we need to just unmask all display register writes on these platforms. The downside being that any display regitster (eg. even SWF

[Intel-gfx] [PATCH v2 09/13] drm/i915/psr: Implement WaPsrDPRSUnmaskVBlankInSRD:hsw

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä Bspec asks us to unmask "vblank to registers" in the DPRS unit. Note that I was unable to observe any change in hardware behviour due to this bit on HSW. But let's do this anyway in case it matters in some cases, and the corresponding bit on BDW is abolutely critical as

[Intel-gfx] [PATCH v2 08/13] drm/i915/psr: Implement WaPsrDPAMaskVBlankInSRD:hsw

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä Implement WaPsrDPAMaskVBlankInSRD:hsw, which makes the hardware generate the extra vblank between link training and first frame being transmitted. This is the same thing that's controlled by TRANS_CHICKEN[21] on skl+ (but due to the funky double buffering it's effectively

[Intel-gfx] [PATCH v2 07/13] drm/i915/psr: Restore PSR interrupt handler for HSW

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä Add the PSR interrupt handling code back for HSW. Looks like the removal was never completed anyway since the irq setup code was lest untouched. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_irq.c | 14 ++ 1 file changed, 14

[Intel-gfx] [PATCH v2 06/13] drm/i915/psr: HSW/BDW have no PSR2

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä Deal with HSW/BDW in transcoder_has_psr2(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_psr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c

[Intel-gfx] [PATCH v2 05/13] drm/i915/psr: Bring back HSW/BDW PSR AUX CH registers/setup

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä Reintroduce the special PSR AUX CH setup for hsw/bdw. Not all of it was even removed (BDW AUX data registers were left behind). Update the code to use REG_BIT() & co. while at it. v2: Define the SRD_AUX_CTL bits in terms of DP_AUX_CTL bits (Jouni) Add a comment

[Intel-gfx] [PATCH v2 04/13] drm/i915/psr: Reintroduce HSW PSR1 registers

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä Add back hsw'w special SRD/PSR1 registers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_psr.c | 20 +++ drivers/gpu/drm/i915/display/intel_psr_regs.h | 4 2 files changed, 20 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH v2 03/13] drm/i915/psr: Wrap PSR1 register with functions

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä In preparation for re-introducing HSW's different PSR1 register offeets let's just wrap all the registers into functions. Avoids having to make the register macros more complex. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_psr.c | 99

[Intel-gfx] [PATCH v2 02/13] drm/i915/psr: Fix BDW PSR AUX CH data register offsets

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä The multiplication got replaced by an addition in some cleanup. This means we never write the correct data to some of the BDW PSR data registers and thus we fail to actually wake up the panel from PSR. Fixes: 4ab4fa103217 ("drm/i915/psr: Make PSR registers relative to

[Intel-gfx] [PATCH v2 00/13] drm/i915/psr: Restore HSW/BDW PSR1

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä Fix all the obvious issues affecting HSW/BDW PSR1 and restore it back to life. The PC8+ vs. init_clock_gating() problem also affects some non-PSR workarounds as well. v2: Rebase (due to irq code movement mostly) Deal with review comments wrt. the AUX setup Ville

[Intel-gfx] [PATCH v2 01/13] drm/i915: Re-init clock gating on coming out of PC8+

2023-06-09 Thread Ville Syrjala
From: Ville Syrjälä PC8+ clobbers a bunch of displays registers which need to be restored by hand or else we lost a bunch of workarounds. The important ones for us are at least CHICKEN_PAR2* and CHICKEN_PIPESL*. Curiously at least some CHICKEN_PAR1* registers are preserved by the

Re: [Intel-gfx] [PATCH 6/8] drm: Add drm_gem_prime_fd_to_handle_obj

2023-06-09 Thread Tvrtko Ursulin
On 09/06/2023 13:44, Iddamsetty, Aravind wrote: On 09-06-2023 17:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin I need a new flavour of the drm_gem_prime_fd_to_handle helper, one which will return a reference to a newly created GEM objects (if created), in order to enable tracking of

[Intel-gfx] ✓ Fi.CI.IGT: success for fbcon: Reschedule cursor worker if try lock fails

2023-06-09 Thread Patchwork
== Series Details == Series: fbcon: Reschedule cursor worker if try lock fails URL : https://patchwork.freedesktop.org/series/119060/ State : success == Summary == CI Bug Log - changes from CI_DRM_13249_full -> Patchwork_119060v1_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Cleanup usage of phy lane reset

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Cleanup usage of phy lane reset URL : https://patchwork.freedesktop.org/series/119138/ State : warning == Summary == Error: dim checkpatch failed 2c4d880e398d drm/i915/mtl: Cleanup usage of phy lane reset -:58: WARNING:LONG_LINE: line length of 104

Re: [Intel-gfx] [PATCH v3] x86/mm: Fix PAT bit missing from page protection modify mask

2023-06-09 Thread Juergen Gross
On 09.06.23 15:01, Janusz Krzysztofik wrote: Visible glitches have been observed when running graphics applications on Linux under Xen hypervisor. Those observations have been confirmed with failures from kms_pwrite_crc Intel GPU test that verifies data coherency of DRM frame buffer objects

[Intel-gfx] [PATCH v3] x86/mm: Fix PAT bit missing from page protection modify mask

2023-06-09 Thread Janusz Krzysztofik
Visible glitches have been observed when running graphics applications on Linux under Xen hypervisor. Those observations have been confirmed with failures from kms_pwrite_crc Intel GPU test that verifies data coherency of DRM frame buffer objects using hardware CRC checksums calculated by display

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for fdinfo memory stats (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: fdinfo memory stats (rev2) URL : https://patchwork.freedesktop.org/series/119082/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fdinfo memory stats (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: fdinfo memory stats (rev2) URL : https://patchwork.freedesktop.org/series/119082/ State : warning == Summary == Error: dim checkpatch failed 67ba6f7b318b dma-fence: Bypass signaling annotation from dma_fence_is_signaled bc390e8b6613 drm/i915: Track buffer objects

Re: [Intel-gfx] [PATCH 6/8] drm: Add drm_gem_prime_fd_to_handle_obj

2023-06-09 Thread Iddamsetty, Aravind
On 09-06-2023 17:41, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I need a new flavour of the drm_gem_prime_fd_to_handle helper, one which > will return a reference to a newly created GEM objects (if created), in > order to enable tracking of imported i915 GEM objects in the following >

[Intel-gfx] [PATCH] drm/i915/mtl: Cleanup usage of phy lane reset

2023-06-09 Thread Mika Kahola
>From PICA message bus we wait for acknowledgment from read/write commands. In case of an error, we reset the bus for the next command. Current implementation ends up resetting message bus twice in cases where error is not the timeout. Since, we only need to reset message bus once, let's move

Re: [Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

2023-06-09 Thread Sui Jingfeng
Hi, On 2023/6/9 03:12, Bjorn Helgaas wrote: Start with verb and capitalize to match ("Deal only with ...") On Thu, Jun 08, 2023 at 07:43:21PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function

[Intel-gfx] [PATCH 6/8] drm: Add drm_gem_prime_fd_to_handle_obj

2023-06-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I need a new flavour of the drm_gem_prime_fd_to_handle helper, one which will return a reference to a newly created GEM objects (if created), in order to enable tracking of imported i915 GEM objects in the following patch. Minor code reshuffule and only trivial additions on

[Intel-gfx] [PATCH 8/8] drm/i915: Implement fdinfo memory stats printing

2023-06-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories.

[Intel-gfx] [PATCH 7/8] drm/i915: Track imported dma-buf objects in memory stats

2023-06-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We want to be able to show memory usage of imported dma-buf opjects in the fdinfo stats. To achieve this we wrap drm_gem_prime_fd_to_handle(_obj) in i915_gem_prime_fd_to_handle and append some client management at the end. Signed-off-by: Tvrtko Ursulin Cc: Aravind

[Intel-gfx] [PATCH 5/8] drm/i915: Account ring buffer and context state storage

2023-06-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 ++ drivers/gpu/drm/i915/i915_drm_client.c | 10 ++

[Intel-gfx] [PATCH 3/8] drm/i915: Record which clients own a VM

2023-06-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 ---

[Intel-gfx] [PATCH 4/8] drm/i915: Track page table backing store usage

2023-06-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c

[Intel-gfx] [PATCH 1/8] dma-fence: Bypass signaling annotation from dma_fence_is_signaled

2023-06-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin For dma_fence_is_signaled signaling critical path annotations are an annoying cause of false positives when using dma_fence_is_signaled and indirectly higher level helpers such as dma_resv_test_signaled etc. Drop the critical path annotation since the "is signaled" API does

[Intel-gfx] [PATCH 2/8] drm/i915: Track buffer objects belonging to clients

2023-06-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to show per client memory usage lets start tracking which objects belong to which clients. We start with objects explicitly created by object creation UAPI and track it on a new per client lists, protected by a new per client lock. In order for delayed destruction

[Intel-gfx] [PATCH v3 0/8] fdinfo memory stats

2023-06-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I added tracking of most classes of objects which contribute to client's memory footprint and accouting along the similar lines as in Rob's msm code. Then printing it out to fdinfo using the drm helper Rob added. Accounting by keeping per client lists may not be the most

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Track buffer objects belonging to clients

2023-06-09 Thread Tvrtko Ursulin
On 09/06/2023 05:16, Iddamsetty, Aravind wrote: On 08-06-2023 20:21, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In order to show per client memory usage lets start tracking which objects belong to which clients. We start with objects explicitly created by object creation UAPI and track it

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/dp: On AUX xfer timeout restart freshly (rev2)

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/display/dp: On AUX xfer timeout restart freshly (rev2) URL : https://patchwork.freedesktop.org/series/119055/ State : success == Summary == CI Bug Log - changes from CI_DRM_13249_full -> Patchwork_119055v2_full

Re: [Intel-gfx] [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-09 Thread Andi Shyti
Hi Carl, > > > besides this, ask a dumb question. > > > How we retrieve the pat_index from a shared resource though dma_buf fd? > > > maybe we need to know whether it could be CPU cached if we want map it. > > > Of course, looks there are no real usage to access it though CPU. > > > Just use it

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Move stolen memory handling details into i915_gem_stolen

2023-06-09 Thread Patchwork
== Series Details == Series: Move stolen memory handling details into i915_gem_stolen URL : https://patchwork.freedesktop.org/series/119123/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Move stolen memory handling details into i915_gem_stolen

2023-06-09 Thread Patchwork
== Series Details == Series: Move stolen memory handling details into i915_gem_stolen URL : https://patchwork.freedesktop.org/series/119123/ State : warning == Summary == Error: dim checkpatch failed 7c50baebe654 drm/i915: Move stolen memory handling into i915_gem_stolen -:42:

Re: [Intel-gfx] [RFC 2/4] drm/i915/display: Update access of has_audio param

2023-06-09 Thread Jani Nikula
On Fri, 09 Jun 2023, Mitul Golani wrote: > Update access of has_audio param from crtc_state pointer > as it is wrapped under audio_config. This should be squashed with the change moving the member in order to not break the build. BR, Jani. > > Signed-off-by: Mitul Golani > --- >

Re: [Intel-gfx] [RFC 1/4] drm/i915/hdmi: Add audio config related params in crtc_state

2023-06-09 Thread Jani Nikula
On Fri, 09 Jun 2023, Mitul Golani wrote: > Add source audio-related config params in crtc_state. > These params can be supported frequency, supported channel, > and audio support, which can be further computed based on > source capabilities. > > Signed-off-by: Mitul Golani > --- >

Re: [Intel-gfx] [RFC 1/4] drm/i915/hdmi: Add audio config related params in crtc_state

2023-06-09 Thread Jani Nikula
On Fri, 09 Jun 2023, Mitul Golani wrote: > Add source audio-related config params in crtc_state. > These params can be supported frequency, supported channel, > and audio support, which can be further computed based on > source capabilities. > > Signed-off-by: Mitul Golani > --- >

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: Init DDI outputs based on port_mask on skl+

2023-06-09 Thread Jani Nikula
On Thu, 08 Jun 2023, Ville Syrjälä wrote: > On Fri, Jun 02, 2023 at 05:41:50PM +0300, Jani Nikula wrote: >> This reflects current code, but apparently commit e341c618acde >> ("drm/i915/adl_s: Initialize display for ADL-S") stopped initializing >> DSI for ADL-S. It does support DSI. > > Not

Re: [Intel-gfx] [PATCH] drm/i915/tc: Use standard ternary operator instead of GCC extension

2023-06-09 Thread Jani Nikula
On Thu, 08 Jun 2023, Gil Dekel wrote: > The ternary expression: > > x ? : y > > is a GCC extension and is not a part of C/C++ standard. > > Use the canonical form instead to reduce dependency over GCC extension. Thanks for the patch, but no thanks, we'll keep it as it is. It's acceptable use

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Get optimal audio frequency and channels

2023-06-09 Thread Patchwork
== Series Details == Series: Get optimal audio frequency and channels URL : https://patchwork.freedesktop.org/series/119121/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 3/3] drm/i915/fbc: Moved fence related code away from intel_fbc

2023-06-09 Thread Jouni Högander
As a preparation for Xe move HW fence details away from intel_fbc code. Add new functions to check support for legacy fencing and fence id and use these in fbc code. Xe doesn't support legacy fencing. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fbc.c | 12 ++--

[Intel-gfx] [PATCH 2/3] drm/i915/fbc: Make FBC check stolen at use time

2023-06-09 Thread Jouni Högander
As a preparation for Xe change stolen memory initialization check to be done in use-time instead of during initialization. In case of xe, stolen memory is initialised much later so it can't be checked during init. There is no specific reason to check this in init for i915 either -> perform the

[Intel-gfx] [PATCH 1/3] drm/i915: Move stolen memory handling into i915_gem_stolen

2023-06-09 Thread Jouni Högander
We are preparing for Xe. Xe stolen memory handling differs from i915 so we want to move stolen memory handling details into i915_gem_stolen. Also add a common type for fbc compressed fb and use it from fbc code instead of underlying type directly. This way we can have common type i915_stolen_fb

[Intel-gfx] [PATCH 0/3] Move stolen memory handling details into i915_gem_stolen

2023-06-09 Thread Jouni Högander
We are preparing for Xe driver. Stolen memory handling will be different in Xe driver. Due to this we want to remove all stolen memory handling details away from FBC code. Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Ville Syrjälä Cc: Maarten Lankhorst Jouni Högander (3): drm/i915: Move stolen

[Intel-gfx] [RFC 4/4] drm/i915/display: Initialize and compute HDMI Audio source cap

2023-06-09 Thread Mitul Golani
Initialize the audio capabilities for HDMI by setting them to their maximum supported values and then call a function to compute these capabilities into SADs. The audio capabilities for HDMI include parameters such as supported frequency and channel configurations. By computing these capabilities

[Intel-gfx] [RFC 2/4] drm/i915/display: Update access of has_audio param

2023-06-09 Thread Mitul Golani
Update access of has_audio param from crtc_state pointer as it is wrapped under audio_config. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16

[Intel-gfx] [RFC 3/4] drm/i915/display: Add wrapper to Compute SAD

2023-06-09 Thread Mitul Golani
Compute SADs that takes into account the supported rate and channel based on the capabilities of the audio source. This wrapper function should encapsulate the logic for determining the supported rate and channel and should return a set of SADs that are compatible with the source. Signed-off-by:

[Intel-gfx] [RFC 1/4] drm/i915/hdmi: Add audio config related params in crtc_state

2023-06-09 Thread Mitul Golani
Add source audio-related config params in crtc_state. These params can be supported frequency, supported channel, and audio support, which can be further computed based on source capabilities. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display_types.h | 12 +---

[Intel-gfx] [RFC 0/4] Get optimal audio frequency and channels

2023-06-09 Thread Mitul Golani
Currently we do not check if there is enough bandwidth for audio, and what channels and freq it can really support. Also sometimes there can be HW constraints e.g. GLK where audio channels supported are only 2. https://patchwork.freedesktop.org/series/107647/ Obtain the optimal audio rate and

Re: [Intel-gfx] [PATCH] drm/i915/dp: Cable type identification for DP2.1

2023-06-09 Thread Jani Nikula
On Fri, 09 Jun 2023, Animesh Manna wrote: > For DP alt mode display driver get the information > about cable speed and cable type through TCSS_DDI_STATUS > register which will be updated by type-c platform driver. > Accodingly Update dpcd 0x110 with cable information before > link training start.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dp: Cable type identification for DP2.1

2023-06-09 Thread Patchwork
== Series Details == Series: drm/i915/dp: Cable type identification for DP2.1 URL : https://patchwork.freedesktop.org/series/119109/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

2023-06-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names URL : https://patchwork.freedesktop.org/series/119106/ State : warning == Summary == Error: dim checkpatch failed f0c7baf40bbf drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test

[Intel-gfx] [PATCH] drm/i915/dp: Cable type identification for DP2.1

2023-06-09 Thread Animesh Manna
For DP alt mode display driver get the information about cable speed and cable type through TCSS_DDI_STATUS register which will be updated by type-c platform driver. Accodingly Update dpcd 0x110 with cable information before link training start. This change came part of DP2.1 SCR. Note: This