[Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in verify_crtc_state

2023-10-09 Thread Suraj Kandpal
Free hw_crtc_state in verify_crtc_state after we are done using this or else it's just a resource leak. Fixes: 2745bdda2095 ("drm/i915: Stop clobbering old crtc state during state check") Signed-off-by: Suraj Kandpal Reviewed-by: Ville Syrjälä ---

[Intel-gfx] ✓ Fi.CI.BAT: success for More print message helper updates (rev2)

2023-10-09 Thread Patchwork
== Series Details == Series: More print message helper updates (rev2) URL : https://patchwork.freedesktop.org/series/124853/ State : success == Summary == CI Bug Log - changes from CI_DRM_13732 -> Patchwork_124853v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for More print message helper updates (rev2)

2023-10-09 Thread Patchwork
== Series Details == Series: More print message helper updates (rev2) URL : https://patchwork.freedesktop.org/series/124853/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More print message helper updates (rev2)

2023-10-09 Thread Patchwork
== Series Details == Series: More print message helper updates (rev2) URL : https://patchwork.freedesktop.org/series/124853/ State : warning == Summary == Error: dim checkpatch failed e57654f9ec79 drm/i915/gt: More use of GT specific print helpers -:163: CHECK:MACRO_ARG_REUSE: Macro argument

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add bigjoiner force enable option to debugfs (rev2)

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Add bigjoiner force enable option to debugfs (rev2) URL : https://patchwork.freedesktop.org/series/124730/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13731_full -> Patchwork_124730v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Temporarily force MTL into uncached mode

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915/gt: Temporarily force MTL into uncached mode URL : https://patchwork.freedesktop.org/series/124866/ State : success == Summary == CI Bug Log - changes from CI_DRM_13732 -> Patchwork_124866v1 Summary

Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in verify_crtc_state

2023-10-09 Thread Kandpal, Suraj
> -Original Message- > From: Ville Syrjälä > Sent: Monday, October 9, 2023 6:08 PM > To: Kandpal, Suraj > Cc: Jani Nikula ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in > verify_crtc_state > > On Mon, Oct 09, 2023 at

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915/dsb: Allocate command buffer from local memory

2023-10-09 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dsb: Allocate command buffer from local memory URL : https://patchwork.freedesktop.org/series/124818/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13730_full -> Patchwork_124818v1_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for More print message helper updates

2023-10-09 Thread Patchwork
== Series Details == Series: More print message helper updates URL : https://patchwork.freedesktop.org/series/124853/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13732 -> Patchwork_124853v1 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for More print message helper updates

2023-10-09 Thread Patchwork
== Series Details == Series: More print message helper updates URL : https://patchwork.freedesktop.org/series/124853/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More print message helper updates

2023-10-09 Thread Patchwork
== Series Details == Series: More print message helper updates URL : https://patchwork.freedesktop.org/series/124853/ State : warning == Summary == Error: dim checkpatch failed 9ac3d314aeb4 drm/i915/gt: More use of GT specific print helpers -:163: CHECK:MACRO_ARG_REUSE: Macro argument reuse

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Free crtc_state in verify_crtc_state

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915/display: Free crtc_state in verify_crtc_state URL : https://patchwork.freedesktop.org/series/124811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13730_full -> Patchwork_124811v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/bridge_connector: implement OOB HPD handling (rev5)

2023-10-09 Thread Patchwork
== Series Details == Series: drm/bridge_connector: implement OOB HPD handling (rev5) URL : https://patchwork.freedesktop.org/series/120395/ State : success == Summary == CI Bug Log - changes from CI_DRM_13731 -> Patchwork_120395v5 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/bridge_connector: implement OOB HPD handling (rev5)

2023-10-09 Thread Patchwork
== Series Details == Series: drm/bridge_connector: implement OOB HPD handling (rev5) URL : https://patchwork.freedesktop.org/series/120395/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Define and use GuC and CTB TLB invalidation routines (rev4)

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines (rev4) URL : https://patchwork.freedesktop.org/series/124744/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13731 -> Patchwork_124744v4

[Intel-gfx] [PATCH] drm/i915/gt: Temporarily force MTL into uncached mode

2023-10-09 Thread Jonathan Cavitt
FIXME: CAT errors are cropping up on MTL. This removes them, but the real root cause must still be diagnosed. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/intel_gt.c | 6 +- drivers/gpu/drm/i915/gt/intel_lrc.c| 5 - drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 -

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Define and use GuC and CTB TLB invalidation routines (rev4)

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines (rev4) URL : https://patchwork.freedesktop.org/series/124744/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Define and use GuC and CTB TLB invalidation routines (rev4)

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines (rev4) URL : https://patchwork.freedesktop.org/series/124744/ State : warning == Summary == Error: dim checkpatch failed 36647bbe0ce7 drm/i915: Add GuC TLB Invalidation device info flags 07632c06461f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix VLV color state readout

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Fix VLV color state readout URL : https://patchwork.freedesktop.org/series/124824/ State : success == Summary == CI Bug Log - changes from CI_DRM_13731 -> Patchwork_124824v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lnl: Remove watchdog timers for PSR (rev2)

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915/lnl: Remove watchdog timers for PSR (rev2) URL : https://patchwork.freedesktop.org/series/124715/ State : success == Summary == CI Bug Log - changes from CI_DRM_13731 -> Patchwork_124715v2 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add bigjoiner force enable option to debugfs (rev2)

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Add bigjoiner force enable option to debugfs (rev2) URL : https://patchwork.freedesktop.org/series/124730/ State : success == Summary == CI Bug Log - changes from CI_DRM_13731 -> Patchwork_124730v2

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/dsb: Allocate command buffer from local memory

2023-10-09 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dsb: Allocate command buffer from local memory URL : https://patchwork.freedesktop.org/series/124818/ State : success == Summary == CI Bug Log - changes from CI_DRM_13730 -> Patchwork_124818v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/dsb: Allocate command buffer from local memory

2023-10-09 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dsb: Allocate command buffer from local memory URL : https://patchwork.freedesktop.org/series/124818/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Free crtc_state in verify_crtc_state

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915/display: Free crtc_state in verify_crtc_state URL : https://patchwork.freedesktop.org/series/124811/ State : success == Summary == CI Bug Log - changes from CI_DRM_13730 -> Patchwork_124811v1 Summary

Re: [Intel-gfx] [PATCH 09/19] drm/i915/dp: Use connector DSC DPCD in intel_dp_dsc_max_sink_compressed_bppx16()

2023-10-09 Thread Lisovskiy, Stanislav
On Fri, Oct 06, 2023 at 04:37:17PM +0300, Imre Deak wrote: > Use the connector's DSC DPCD capabilities in > intel_dp_dsc_max_sink_compressed_bppx16(). > > Signed-off-by: Imre Deak Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_dp.c | 19 +++ > 1

Re: [Intel-gfx] [PATCH 08/19] drm/i915/dp: Use connector DSC DPCD in intel_dp_supports_dsc()

2023-10-09 Thread Lisovskiy, Stanislav
On Fri, Oct 06, 2023 at 04:37:16PM +0300, Imre Deak wrote: > Use the connector's DSC DPCD capabilities in intel_dp_supports_dsc(). > > Signed-off-by: Imre Deak Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: More use of GT specific print helpers

2023-10-09 Thread John Harrison
On 10/9/2023 13:02, Andi Shyti wrote: Hi John, ... if (intf_id >= INTEL_GSC_NUM_INTERFACES) { - drm_warn_once(>i915->drm, "GSC irq: intf_id %d is out of range", intf_id); + gt_warn_once(gt, "GSC irq: intf_id %d is out of range", intf_id);

Re: [Intel-gfx] [PATCH 07/19] drm/i915/dp: Use connector DSC DPCD in intel_dp_supports_fec()

2023-10-09 Thread Lisovskiy, Stanislav
On Fri, Oct 06, 2023 at 04:37:15PM +0300, Imre Deak wrote: > Use the connector's DSC DPCD capabilities in intel_dp_supports_fec(). > > Signed-off-by: Imre Deak Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_dp.c | 7 +-- > 1 file changed, 5 insertions(+), 2

Re: [Intel-gfx] [PATCH 06/19] drm/i915/dp: Use connector DSC DPCD in intel_dp_dsc_compute_max_bpp()

2023-10-09 Thread Lisovskiy, Stanislav
On Fri, Oct 06, 2023 at 04:37:14PM +0300, Imre Deak wrote: > Use the connector's DSC DPCD capabilities in intel_dp_dsc_compute_max_bpp() > instead of the version stored in the encoder. > > Signed-off-by: Imre Deak Reviewed-by: Stanislav Lisovskiy > --- >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: More use of GT specific print helpers

2023-10-09 Thread Andi Shyti
Hi John, ... > > > if (intf_id >= INTEL_GSC_NUM_INTERFACES) { > > > - drm_warn_once(>i915->drm, "GSC irq: intf_id %d is out of > > > range", intf_id); > > > + gt_warn_once(gt, "GSC irq: intf_id %d is out of range", > > > intf_id); > > > return; > > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: More use of GT specific print helpers

2023-10-09 Thread John Harrison
On 10/9/2023 12:54, Andi Shyti wrote: Hi John, ... --- a/drivers/gpu/drm/i915/i915_driver.c +++ b/drivers/gpu/drm/i915/i915_driver.c @@ -71,6 +71,7 @@ #include "gem/i915_gem_pm.h" #include "gt/intel_gt.h" #include "gt/intel_gt_pm.h" +#include "gt/intel_gt_print.h" #include

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: More use of GT specific print helpers

2023-10-09 Thread John Harrison
On 10/9/2023 12:50, Andi Shyti wrote: Hi John, ... if (intf_id >= INTEL_GSC_NUM_INTERFACES) { - drm_warn_once(>i915->drm, "GSC irq: intf_id %d is out of range", intf_id); + gt_warn_once(gt, "GSC irq: intf_id %d is out of range", intf_id);

Re: [Intel-gfx] [PATCH 2/2] drm/i915: More use of GT specific print helpers

2023-10-09 Thread Andi Shyti
Hi John, ... > --- a/drivers/gpu/drm/i915/i915_driver.c > +++ b/drivers/gpu/drm/i915/i915_driver.c > @@ -71,6 +71,7 @@ > #include "gem/i915_gem_pm.h" > #include "gt/intel_gt.h" > #include "gt/intel_gt_pm.h" > +#include "gt/intel_gt_print.h" > #include "gt/intel_rc6.h" > > #include

Re: [Intel-gfx] [PATCH] drm/print: Add drm_dbg_ratelimited

2023-10-09 Thread John Harrison
On 10/9/2023 12:43, Andi Shyti wrote: Hi John, From: Nirmoy Das Add a function for ratelimitted debug print. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld Reviewed-by: Andi Shyti Signed-off-by: Nirmoy Das

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: More use of GT specific print helpers

2023-10-09 Thread Andi Shyti
Hi John, ... > if (intf_id >= INTEL_GSC_NUM_INTERFACES) { > - drm_warn_once(>i915->drm, "GSC irq: intf_id %d is out of > range", intf_id); > + gt_warn_once(gt, "GSC irq: intf_id %d is out of range", > intf_id); > return; > } > > if

Re: [Intel-gfx] [PATCH] drm/print: Add drm_dbg_ratelimited

2023-10-09 Thread Andi Shyti
Hi John, > > > From: Nirmoy Das > > > > > > Add a function for ratelimitted debug print. > > > > > > Cc: Maarten Lankhorst > > > Cc: Maxime Ripard > > > Cc: Thomas Zimmermann > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Reviewed-by: Matthew Auld > > > Reviewed-by: Andi Shyti > >

Re: [Intel-gfx] Regression in linux-next

2023-10-09 Thread Wysocki, Rafael J
Hi, On 10/9/2023 7:10 AM, Borah, Chaitanya Kumar wrote: Hello Rafael Thanks for the report, I think that this is a lockdep assertion failing. If that is correct, it should be straightforward to fix. I'll take care of this early next week. Thanks! Thank you for your response. Please let us

Re: [Intel-gfx] [PATCH] drm/i915: Fix VLV color state readout

2023-10-09 Thread Ville Syrjälä
On Mon, Oct 09, 2023 at 06:36:30PM +0300, Jani Nikula wrote: > On Mon, 09 Oct 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > VLV was missed when the color.get_config() hook was added. > > Remedy that. > > Oops, how did I manage that?! Thanks for the fix, vlv_color_funcs is a fairly

Re: [Intel-gfx] [PATCH v8 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-09 Thread John Harrison
On 10/9/2023 01:56, Tvrtko Ursulin wrote: On 06/10/2023 19:20, Jonathan Cavitt wrote: From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation.  We should use this interface when invalidating the engine and GuC TLBs. Add

Re: [Intel-gfx] [PATCH] drm/print: Add drm_dbg_ratelimited

2023-10-09 Thread John Harrison
On 10/9/2023 09:52, Andi Shyti wrote: Hi, From: Nirmoy Das Add a function for ratelimitted debug print. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld Reviewed-by: Andi Shyti Signed-off-by: Nirmoy Das

[Intel-gfx] [PATCH 2/2] drm/i915: More use of GT specific print helpers

2023-10-09 Thread John . C . Harrison
From: John Harrison Update a bunch of GT related print messages in non-GT files to use the GT specific helpers. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_gsc_uc.c | 8 +++- drivers/gpu/drm/i915/i915_driver.c| 3 ++- drivers/gpu/drm/i915/i915_perf.c

[Intel-gfx] [PATCH 1/2] drm/i915/gt: More use of GT specific print helpers

2023-10-09 Thread John . C . Harrison
From: John Harrison A bunch of print messages got missed in the update to using sub-system specific helpers. So update those. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 29 + drivers/gpu/drm/i915/gt/intel_gsc.c | 11

[Intel-gfx] [PATCH 0/2] More print message helper updates

2023-10-09 Thread John . C . Harrison
From: John Harrison There was an update a while back to use sub-system specific print helpers that implicitly add sub-system specific information to the print. It seems a bunch of GT related messages got missed in that update. So update them now. Signed-off-by: John Harrison John Harrison

Re: [Intel-gfx] [PATCH i-g-t v2 10/11] lib/kunit: Fetch a list of test cases in advance

2023-10-09 Thread Kamil Konieczny
Hi Janusz, On 2023-10-09 at 14:28:01 +0200, Janusz Krzysztofik wrote: > Recent improvements to the kernel kunit framework allow us to obtain a > list of test cases provided by a kunit test module without actually > running them. Use that feature to get a list of expected test cases > before we

[Intel-gfx] [PATCH v7 3/3 RESEND] drm/bridge_connector: implement oob_hotplug_event

2023-10-09 Thread Dmitry Baryshkov
Implement the oob_hotplug_event() callback. Translate it to the HPD notification sent to the HPD bridge in the chain. Reviewed-by: Janne Grunau Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bridge_connector.c | 31 +++--- 1 file changed, 28 insertions(+), 3

[Intel-gfx] [PATCH v7 1/3 RESEND] drm: Add HPD state to drm_connector_oob_hotplug_event()

2023-10-09 Thread Dmitry Baryshkov
From: Bjorn Andersson In some implementations, such as the Qualcomm platforms, the display driver has no way to query the current HPD state and as such it's impossible to distinguish between disconnect and attention events. Add a parameter to drm_connector_oob_hotplug_event() to pass the HPD

[Intel-gfx] [PATCH v7 2/3 RESEND] drm/bridge_connector: stop filtering events in drm_bridge_connector_hpd_cb()

2023-10-09 Thread Dmitry Baryshkov
In some cases the bridge drivers would like to receive hotplug events even in the case new status is equal to the old status. In the DP case this is used to deliver "attention" messages to the DP host. Stop filtering the events in the drm_bridge_connector_hpd_cb() and let drivers decide whether

[Intel-gfx] [PATCH v7 0/3 RESEND] drm/bridge_connector: implement OOB HPD handling

2023-10-09 Thread Dmitry Baryshkov
This is a resend, since the previous submission got no responses. The patches have been reviewed/acked by several maintainers. Can we please gain some attention and either get it merged or understand what should be changed / improved. This series is required to delivere HPD events from altmode

[Intel-gfx] [PATCH v9 6/7] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck

2023-10-09 Thread Jonathan Cavitt
For the gt_tlb live selftest, when operating on the GSC engine, increase the timeout from 10 ms to 200 ms because the GSC engine is a bit slower than the rest. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/selftest_tlb.c | 11 +-- 1 file changed, 9 insertions(+), 2

[Intel-gfx] [PATCH v9 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-09 Thread Jonathan Cavitt
From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to intel_gt_invalidate_tlb, invalidating the GuC TLBs and falling back

[Intel-gfx] [PATCH v9 5/7] drm/i915: No TLB invalidation on wedged GT

2023-10-09 Thread Jonathan Cavitt
It is not an error for GuC TLB invalidations to fail when the GT is wedged or disabled, so do not process a wait failure as one in guc_send_invalidate_tlb. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 18

[Intel-gfx] [PATCH v9 4/7] drm/i915: No TLB invalidation on suspended GT

2023-10-09 Thread Jonathan Cavitt
In case of GT is suspended, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison ---

[Intel-gfx] [PATCH v9 7/7] drm/i915: Enable GuC TLB invalidations for MTL

2023-10-09 Thread Jonathan Cavitt
Enable GuC TLB invalidations for MTL. Though more platforms than just MTL support GuC TLB invalidations, MTL is presently the only platform that requires it for any purpose, so only enable it there for now to minimize cross-platform impact. Signed-off-by: Jonathan Cavitt ---

[Intel-gfx] [PATCH v9 0/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-09 Thread Jonathan Cavitt
Implement GuC-based TLB invalidations and use them on MTL. v2: - Add missing supporting patches. v3: - Split suspend/resume changes and multi-gt support into separate patches. - Only perform GuC TLB invalidation functions when supported. - Move intel_guc_is_enabled check function to usage

[Intel-gfx] [PATCH v9 1/7] drm/i915: Add GuC TLB Invalidation device info flags

2023-10-09 Thread Jonathan Cavitt
Add device info flags for if GuC TLB Invalidation is enabled. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/intel_device_info.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v9 2/7] drm/i915/guc: Add CT size delay helper

2023-10-09 Thread Jonathan Cavitt
Add a helper function to the GuC CT buffer that reports the expected time to process all outstanding requests. As of now, there is no functionality to check number of requests in the buffer, so the helper function just reports 2 seconds, or 1ms per request up to the maximum number of requests the

Re: [Intel-gfx] [PATCH i-g-t v2 09/11] lib/kunit: Prepare for KTAP parsing after modprobe completed

2023-10-09 Thread Kamil Konieczny
Hi Janusz, On 2023-10-09 at 14:28:00 +0200, Janusz Krzysztofik wrote: > We are going to add support for reading a list of kunit test cases > provided by a kunit test module prior to executing those test cases. That - ^^ Two

Re: [Intel-gfx] [PATCH i-g-t v2 08/11] lib/kunit: Provide all results cleanup helper

2023-10-09 Thread Kamil Konieczny
Hi Janusz, On 2023-10-09 at 14:27:59 +0200, Janusz Krzysztofik wrote: > Planned changes require a couple of loops around kunit_result_free(). > Since we already have such loop, move it into a helper in preparation for > future uses. > > Signed-off-by: Janusz Krzysztofik Reviewed-by: Kamil

Re: [Intel-gfx] [PATCH i-g-t v2 11/11] lib/kunit: Execute kunit test cases only when needed

2023-10-09 Thread Kamil Konieczny
Hi Janusz, On 2023-10-09 at 14:28:02 +0200, Janusz Krzysztofik wrote: > IGT user interface allows to request execution of only those dynamic sub- > subtests that match a user provided name pattern. If the user pattern > doesn't match any names of test cases provided by a kunit test module used >

Re: [Intel-gfx] [PATCH i-g-t v2 07/11] lib/ktap: Drop workaround for missing top level KTAP headers

2023-10-09 Thread Kamil Konieczny
Hi Janusz, On 2023-10-09 at 14:27:58 +0200, Janusz Krzysztofik wrote: > A workaround was implemented in IGT KTAP parser so it could accepted KTAP > reports with missing top level KTAP version and test suite plan headers. > Since kernel side commit c95e7c05c139 ("kunit: Report the count of test >

Re: [Intel-gfx] [PATCH] drm/print: Add drm_dbg_ratelimited

2023-10-09 Thread Andi Shyti
Hi, > From: Nirmoy Das > > Add a function for ratelimitted debug print. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Reviewed-by: Matthew Auld > Reviewed-by: Andi Shyti > Signed-off-by: Nirmoy Das > Signed-off-by: Andi

Re: [Intel-gfx] [PATCH 1/2] drm/i915: drop -Wall and related disables from cflags as redundant

2023-10-09 Thread Nathan Chancellor
On Sun, Oct 08, 2023 at 12:28:46AM +0900, Masahiro Yamada wrote: > On Fri, Oct 6, 2023 at 9:35 PM Jani Nikula wrote: > > > > The kernel top level Makefile, and recently scripts/Makefile.extrawarn, > > have included -Wall, and the disables -Wno-format-security and > > $(call

Re: [Intel-gfx] [PATCH v2] drm/i915/uapi: fix doc typos

2023-10-09 Thread Rodrigo Vivi
On Sun, Oct 08, 2023 at 02:49:40PM -0700, Randy Dunlap wrote: > Correct typo of "its". > Add commas for clarity. > Capitalize L3. > > Signed-off-by: Randy Dunlap > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: intel-gfx@lists.freedesktop.org > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: Fix VLV color state readout

2023-10-09 Thread Jani Nikula
On Mon, 09 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > VLV was missed when the color.get_config() hook was added. > Remedy that. Oops, how did I manage that?! Thanks for the fix, Reviewed-by: Jani Nikula > Not really sure what the final plan here was since a bunch of > color

Re: [Intel-gfx] [PATCH v8 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-09 Thread Cavitt, Jonathan
-Original Message- From: Tvrtko Ursulin Sent: Monday, October 9, 2023 1:57 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; Chang, Yu bruce ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Harrison, John C ; Das, Nirmoy ;

[Intel-gfx] [PATCH] drm/i915: Fix VLV color state readout

2023-10-09 Thread Ville Syrjala
From: Ville Syrjälä VLV was missed when the color.get_config() hook was added. Remedy that. Not really sure what the final plan here was since a bunch of color related readout was left in intel_display.c anyway, but that's for anothr day to figure out... Cc: Jani Nikula Fixes: 9af09dfcdfa1

Re: [Intel-gfx] [PATCH v2] drm/i915/lnl: Remove watchdog timers for PSR

2023-10-09 Thread Ville Syrjälä
On Mon, Oct 09, 2023 at 05:13:03PM +0300, Mika Kahola wrote: > Currently we are not using watchdog timers for PSR/PSR2 > with Lunarlake. The patch removes the use of these timers > from the driver code. That still doesn't seem to say that the timers were removed from the hardware. Or at least I

Re: [Intel-gfx] [PATCH 01/19] drm/i915/dp: Sanitize DPCD revision check in intel_dp_get_dsc_sink_cap()

2023-10-09 Thread Ville Syrjälä
On Fri, Oct 06, 2023 at 04:37:09PM +0300, Imre Deak wrote: > Check only the eDP or the DP specific DPCD revision depending on the > sink type. Pass the corresponding revision to the function, which allows > getting the DSC caps of a branch device (in an MST topology, which has > its own DPCD and

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Define and use GuC and CTB TLB invalidation routines (rev3)

2023-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines (rev3) URL : https://patchwork.freedesktop.org/series/124744/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13728_full -> Patchwork_124744v3_full

[Intel-gfx] [PATCH v2] drm/i915/lnl: Remove watchdog timers for PSR

2023-10-09 Thread Mika Kahola
Currently we are not using watchdog timers for PSR/PSR2 with Lunarlake. The patch removes the use of these timers from the driver code. BSpec: 69895 v2: Reword commit message (Ville) Drop HPD mask from LNL (Ville) Revise masking logic (Jouni) Signed-off-by: Mika Kahola ---

Re: [Intel-gfx] [PATCH 05/19] drm/i915/dp: Use connector DSC DPCD in i915_dsc_fec_support_show()

2023-10-09 Thread Lisovskiy, Stanislav
On Fri, Oct 06, 2023 at 04:37:13PM +0300, Imre Deak wrote: > Use the connector's DSC DPCD capabilities in i915_dsc_fec_support_show() > instead of the version stored in the encoder. Atm the two are identical, > but a follow-up patch will store the (MST) connector specific version > in the

Re: [Intel-gfx] [PATCH 19/19] drm/i915/dp: Remove unused DSC caps from intel_dp

2023-10-09 Thread Lisovskiy, Stanislav
On Fri, Oct 06, 2023 at 04:37:27PM +0300, Imre Deak wrote: > The previous patches converted all users of the DSC DPCD caps to look > these up from the connector, so remove the version stored in intel_dp. > > A follow-up patchset will read out the MST connector specific > capabilities in

Re: [Intel-gfx] [PATCH 04/19] drm/i915/dp: Use i915/intel connector local variables in i915_dsc_fec_support_show()

2023-10-09 Thread Lisovskiy, Stanislav
On Fri, Oct 06, 2023 at 04:37:12PM +0300, Imre Deak wrote: > Cahce the i915 specific device and connector pointers in > i915_dsc_fec_support_show(). Typo cahce/cache. Would say more like "store", but doesn't matter. Reviewed-by: Stanislav Lisovskiy > > Signed-off-by: Imre Deak > --- >

Re: [Intel-gfx] [PATCH 03/19] drm/i915/dp_mst: Set connector DSC capabilities and decompression AUX

2023-10-09 Thread Lisovskiy, Stanislav
On Fri, Oct 06, 2023 at 04:37:11PM +0300, Imre Deak wrote: > Similarly to eDP and SST-DP connectors read out the DSC capabilities for > MST connectors as well. Atm these will match the root port's DSC caps > and only used after a follow-up change enables the decompression for > each stream

[Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2023-10-09 Thread Stanislav Lisovskiy
For validation purposes, it might be useful to be able to force Bigjoiner mode, even if current dotclock/resolution do not require that. Lets add such to option to debugfs. v2: - Apparently intel_dp_need_bigjoiner can't be used, when debugfs entry is created so lets just check manually

Re: [Intel-gfx] [PATCH v8 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-09 Thread Nirmoy Das
Hi Tvrtko, On 10/9/2023 2:54 PM, Tvrtko Ursulin wrote: +static long must_wait_woken(struct wait_queue_entry *wq_entry, long timeout) +{ +    /* + * This is equivalent to wait_woken() with the exception that + * we do not wake up early if the kthread task has been completed. + *

[Intel-gfx] [PATCH 3/4] drm/i915/dsb: Re-instate DSB for LUT updates

2023-10-09 Thread Ville Syrjala
From: Ville Syrjälä With all the known issues sorted out we can start to use DSB to load the LUTs. Reviewed-by: Uma Shankar Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[Intel-gfx] [PATCH 4/4] drm/i915: Do state check for color management changes

2023-10-09 Thread Ville Syrjala
From: Ville Syrjälä In order to validate LUT programming more thoroughly let's do a state check for all color management updates as well. Not sure we really want this outside CI. It is rather heavy and color management updates could become rather common with all the HDR/etc. stuff happening.

[Intel-gfx] [PATCH 2/4] drm/i915/dsb: Correct DSB command buffer cache coherency settings

2023-10-09 Thread Ville Syrjala
From: Ville Syrjälä The display engine does not snoop the caches so shoukd to mark the DSB command buffer as I915_CACHE_NONE. i915_gem_object_create_internal() always gives us I915_CACHE_LLC on LLC platforms. And to make things 100% correct we should also clflush at the end, if necessary. Note

[Intel-gfx] [PATCH 1/4] drm/i915/dsb: Allocate command buffer from local memory

2023-10-09 Thread Ville Syrjala
From: Ville Syrjälä Using system memory for the DSB command buffer doesn't appear to work. On DG2 it seems like the hardware internally replaces the actual memory reads with zeroes, and so we end up executing a bunch of NOOPs instead of whatever commands we put in the buffer. To determine that I

Re: [Intel-gfx] [PATCH] drm/i915/display: Reset message bus after each read/write operation

2023-10-09 Thread Gustavo Sousa
Quoting Rodrigo Vivi (2023-10-05 12:13:34-03:00) >On Thu, Oct 05, 2023 at 03:05:31AM -0400, Kahola, Mika wrote: >> > -Original Message- >> > From: Vivi, Rodrigo >> > Sent: Wednesday, October 4, 2023 3:56 PM >> > To: Kahola, Mika >> > Cc: intel-gfx@lists.freedesktop.org >> > Subject: Re:

Re: [Intel-gfx] [PATCH v8 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-09 Thread Tvrtko Ursulin
On 09/10/2023 13:12, Nirmoy Das wrote: On 10/6/2023 8:20 PM, Jonathan Cavitt wrote: From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add

Re: [Intel-gfx] [PATCH v8 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-09 Thread Tvrtko Ursulin
On 09/10/2023 12:40, Andi Shyti wrote: Hi, ... @@ -131,11 +132,23 @@ void intel_gt_invalidate_tlb_full(struct intel_gt *gt, u32 seqno) return; with_intel_gt_pm_if_awake(gt, wakeref) { + struct intel_guc *guc = >uc.guc; +

Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in verify_crtc_state

2023-10-09 Thread Jani Nikula
On Mon, 09 Oct 2023, "Kandpal, Suraj" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: Monday, October 9, 2023 4:07 PM >> To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org >> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in >> verify_crtc_state >> >> On

[Intel-gfx] [PATCH i-g-t v2 11/11] lib/kunit: Execute kunit test cases only when needed

2023-10-09 Thread Janusz Krzysztofik
IGT user interface allows to request execution of only those dynamic sub- subtests that match a user provided name pattern. If the user pattern doesn't match any names of test cases provided by a kunit test module used with the subtest to be run then no results from any dynamic sub-subtests will

[Intel-gfx] [PATCH i-g-t v2 10/11] lib/kunit: Fetch a list of test cases in advance

2023-10-09 Thread Janusz Krzysztofik
Recent improvements to the kernel kunit framework allow us to obtain a list of test cases provided by a kunit test module without actually running them. Use that feature to get a list of expected test cases before we enter a loop around igt_dynamic(). Once done, enter the igt_dynamic() section

[Intel-gfx] [PATCH i-g-t v2 09/11] lib/kunit: Prepare for KTAP parsing after modprobe completed

2023-10-09 Thread Janusz Krzysztofik
We are going to add support for reading a list of kunit test cases provided by a kunit test module prior to executing those test cases. That will be done by first loading kunit modules in list only mode, then reading the list from /dev/kmsg with our KTAP parser. Since that parsing will be

[Intel-gfx] [PATCH i-g-t v2 08/11] lib/kunit: Provide all results cleanup helper

2023-10-09 Thread Janusz Krzysztofik
Planned changes require a couple of loops around kunit_result_free(). Since we already have such loop, move it into a helper in preparation for future uses. Signed-off-by: Janusz Krzysztofik --- lib/igt_kmod.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff

[Intel-gfx] [PATCH i-g-t v2 06/11] tests/kms_selftest: Let subtest names match suite names

2023-10-09 Thread Janusz Krzysztofik
There is a rule specified in Kunit Test Style and Nomenclature guidelines [1] that states modules should be named after the test suite, followed by _test. Of course, that rule applies only to modules that provide one test suite per module. As long as that rule is obeyed by authors of Kunit test

[Intel-gfx] [PATCH i-g-t v2 07/11] lib/ktap: Drop workaround for missing top level KTAP headers

2023-10-09 Thread Janusz Krzysztofik
A workaround was implemented in IGT KTAP parser so it could accepted KTAP reports with missing top level KTAP version and test suite plan headers. Since kernel side commit c95e7c05c139 ("kunit: Report the count of test suites in a module"), included in the mainline kernel since v6.6-rc1, has fixed

[Intel-gfx] [PATCH i-g-t v2 05/11] lib/kunit: Omit suite name prefix if the same as subtest name

2023-10-09 Thread Janusz Krzysztofik
Kunit test modules usually contain one test suite, named after the module name with the trailing "_test" or "_kunit" suffix omitted. Since we follow the same convention when we derive subtest names from module names, there is a great chance that those two names match. Take this into account when

[Intel-gfx] [PATCH i-g-t v2 04/11] lib/kunit: Parse KTAP report from the main process thread

2023-10-09 Thread Janusz Krzysztofik
There was an attempt to parse KTAP reports in the background while a kunit test module is loading. However, since dynamic sub-subtests can be executed only from the main thread, that attempt was not quite successful, as IGT results from all executed kunit test cases were generated only after

[Intel-gfx] [PATCH i-g-t v2 03/11] lib/kunit: Fix misplaced igt_kunit() doc

2023-10-09 Thread Janusz Krzysztofik
When igt_kunit() was converted to a helper and wrapped with a new function promoted to take the name and role of the library API, related documentation was left unchanged and still placed in front the demoted function. Update that documentation and move it to where it now belongs. Signed-off-by:

[Intel-gfx] [PATCH i-g-t v2 01/11] lib/kunit: Fix handling of potential errors from F_GETFL

2023-10-09 Thread Janusz Krzysztofik
Function fcntl(..., F_GETFL, ...) that returns file status flags may also return a negative error code. Handle that error instead of blindly using the returned value as flags. Signed-off-by: Janusz Krzysztofik Reviewed-by: Kamil Konieczny --- lib/igt_kmod.c | 4 ++-- 1 file changed, 2

[Intel-gfx] [PATCH i-g-t v2 02/11] lib/kunit: Be more verbose on errors

2023-10-09 Thread Janusz Krzysztofik
Use a more verbose variant of igt_fail() when failing a dynamic sub- subtest on kernel taint. Also, print a debug message on string duplication failure. Signed-off-by: Janusz Krzysztofik Reviewed-by: Kamil Konieczny --- lib/igt_kmod.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Intel-gfx] [PATCH i-g-t v2 00/11] Kunit fixes and improvements

2023-10-09 Thread Janusz Krzysztofik
v2: Add a new patch that provides all results cleanup helper, - split out changes in handling of modprobe errors and kernel taints from "Fetch a list of test cases in advance" to separate patches (Kamil), - prepare for KTAP parsing after modprobe completed in a separate patch, - drop

[Intel-gfx] ✓ Fi.CI.BAT: success for Refactor i915 HDCP for XE (rev6)

2023-10-09 Thread Patchwork
== Series Details == Series: Refactor i915 HDCP for XE (rev6) URL : https://patchwork.freedesktop.org/series/123955/ State : success == Summary == CI Bug Log - changes from CI_DRM_13728 -> Patchwork_123955v6 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in verify_crtc_state

2023-10-09 Thread Ville Syrjälä
On Mon, Oct 09, 2023 at 10:58:22AM +, Kandpal, Suraj wrote: > > > > -Original Message- > > From: Jani Nikula > > Sent: Monday, October 9, 2023 4:07 PM > > To: Kandpal, Suraj ; > > intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state

Re: [Intel-gfx] [PATCH] drm/i915/guc: Annotate struct ct_incoming_msg with __counted_by

2023-10-09 Thread Andi Shyti
Hi Kees, On Fri, Oct 06, 2023 at 01:17:45PM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Refactor i915 HDCP for XE (rev6)

2023-10-09 Thread Patchwork
== Series Details == Series: Refactor i915 HDCP for XE (rev6) URL : https://patchwork.freedesktop.org/series/123955/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

  1   2   >