Re: [Intel-gfx] [PATCH 2/4] drm/i915/dp: Fix UHBR link M/N values

2023-11-13 Thread Imre Deak
On Tue, Nov 14, 2023 at 05:29:35AM +0200, Murthy, Arun R wrote: > > > -Original Message- > > From: Intel-gfx On Behalf Of Imre > > Deak > > Sent: Tuesday, November 14, 2023 1:41 AM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH 2/4] drm/i915/dp: Fix UHBR link M/N

Re: [Intel-gfx] [PATCH 2/4] drm/i915/dp: Fix UHBR link M/N values

2023-11-13 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Tuesday, November 14, 2023 1:41 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 2/4] drm/i915/dp: Fix UHBR link M/N values > > The link M/N ratio is the data rate / link symbol clock rate,

[Intel-gfx] linux-next: build warning after merge of the drm-intel tree

2023-11-13 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected indentation. Documentation/gpu/drm-kms-helpers:296:

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Stephen Rothwell
Hi Luben, BTW, cherry picking commits does not avoid conflicts - in fact it can cause conflicts if there are further changes to the files affected by the cherry picked commit in either the tree/branch the commit was cheery picked from or the destination tree/branch (I have to deal with these all

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Luben Tuikov
On 2023-11-13 21:45, Stephen Rothwell wrote: > Hi Luben, > > On Mon, 13 Nov 2023 20:32:40 -0500 Luben Tuikov wrote: >> >> On 2023-11-13 20:08, Luben Tuikov wrote: >>> On 2023-11-13 15:55, Stephen Rothwell wrote: Hi all, Commit 0da611a87021 ("dma-buf: add

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Stephen Rothwell
Hi Luben, On Mon, 13 Nov 2023 20:32:40 -0500 Luben Tuikov wrote: > > On 2023-11-13 20:08, Luben Tuikov wrote: > > On 2023-11-13 15:55, Stephen Rothwell wrote: > >> Hi all, > >> > >> Commit > >> > >> 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") > >> > >> is missing a Signed-off-by

[Intel-gfx] ✗ Fi.CI.BAT: failure for Selftest for FAST_REQUEST feature (rev2)

2023-11-13 Thread Patchwork
== Series Details == Series: Selftest for FAST_REQUEST feature (rev2) URL : https://patchwork.freedesktop.org/series/126044/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13871 -> Patchwork_126044v2 Summary ---

Re: [Intel-gfx] [PATCH 1/4] drm/i915/dp: Account for channel coding efficiency on UHBR links

2023-11-13 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Tuesday, November 14, 2023 1:41 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/4] drm/i915/dp: Account for channel coding > efficiency on UHBR links > > Apply the correct BW allocation

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Selftest for FAST_REQUEST feature (rev2)

2023-11-13 Thread Patchwork
== Series Details == Series: Selftest for FAST_REQUEST feature (rev2) URL : https://patchwork.freedesktop.org/series/126044/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/huc: Stop printing about unsupported HuC on MTL

2023-11-13 Thread John Harrison
On 11/13/2023 07:36, Daniele Ceraolo Spurio wrote: On 11/9/2023 6:06 PM, John Harrison wrote: On 11/9/2023 15:54, Daniele Ceraolo Spurio wrote: On MTL, the HuC is only supported on the media GT, so our validation check on the module parameter detects an inconsistency on the root GT (the

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Luben Tuikov
On 2023-11-13 20:08, Luben Tuikov wrote: > On 2023-11-13 15:55, Stephen Rothwell wrote: >> Hi all, >> >> Commit >> >> 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") >> >> is missing a Signed-off-by from its committer. >> > > In order to merge the scheduler changes necessary for the Xe

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Luben Tuikov
On 2023-11-13 15:55, Stephen Rothwell wrote: > Hi all, > > Commit > > 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") > > is missing a Signed-off-by from its committer. > In order to merge the scheduler changes necessary for the Xe driver, those changes were based on drm-tip,

[Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Fix for potential false positives in GuC hang selftest

2023-11-13 Thread John . C . Harrison
From: John Harrison Noticed that the hangcheck selftest is submitting a non-preemptoble spinner. That means that even if the GuC does not die, the heartbeat will still kick in and trigger a reset. Which is rather defeating the purpose of the test - to verify that the heartbeat will kick in if

[Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Add a selftest for FAST_REQUEST errors

2023-11-13 Thread John . C . Harrison
From: John Harrison There is a mechanism for reporting errors from fire and forget H2G messages. This is the only way to find out about almost any error in the GuC backend submission path. So it would be useful to know that it is working. v2: Fix some dumb over-complications and a couple of

[Intel-gfx] [PATCH v2 0/2] Selftest for FAST_REQUEST feature

2023-11-13 Thread John . C . Harrison
From: John Harrison Add a selftest to verify that the FAST_REQUEST mechanism (getting errors back from fire-and-forget H2G commands) is functional. Also fix up a potential false positive in the GuC hang selftest. v2: Fix some dumb over-complications and typos - review feedback from Daniele.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip pxp init if gt is wedged (rev3)

2023-11-13 Thread Patchwork
== Series Details == Series: drm/i915: Skip pxp init if gt is wedged (rev3) URL : https://patchwork.freedesktop.org/series/125658/ State : success == Summary == CI Bug Log - changes from CI_DRM_13870 -> Patchwork_125658v3 Summary ---

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/tests/drm_mm_test.c between commit: 2ba157983974 ("drm/tests: Fix incorrect argument in drm_test_mm_insert_range") from Linus' tree and commit: 078a5b498d6a ("drm/tests: Remove slow tests") from

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/accel/ivpu/ivpu_job.c between commit: 6309727ef271 ("kthread: add kthread_stop_put") from Linus' tree and commit: 57c7e3e4800a ("accel/ivpu: Stop job_done_thread on suspend") from the drm-misc tree. I

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/accel/ivpu/ivpu_ipc.c between commit: b0873eead1d1 ("accel/ivpu: Do not use wait event interruptible") from Linus' tree and commit: 57c7e3e4800a ("accel/ivpu: Stop job_done_thread on suspend") from the

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/accel/ivpu/ivpu_drv.c between commit: 828d63042aec ("accel/ivpu: Don't enter d0i3 during FLR") from Linus' tree and commit: 57c7e3e4800a ("accel/ivpu: Stop job_done_thread on suspend") from the drm-misc

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Initialize residency registers earlier (rev2)

2023-11-13 Thread Patchwork
== Series Details == Series: drm/i915: Initialize residency registers earlier (rev2) URL : https://patchwork.freedesktop.org/series/125780/ State : success == Summary == CI Bug Log - changes from CI_DRM_13870 -> Patchwork_125780v2 Summary

Re: [Intel-gfx] [PATCH v3] drm/i915: Skip pxp init if gt is wedged

2023-11-13 Thread Teres Alexis, Alan Previn
On Mon, 2023-11-13 at 14:49 -0800, Zhanjun Dong wrote: > The gt wedged could be triggered by missing guc firmware file, HW not > working, etc. Once triggered, it means all gt usage is dead, therefore we > can't enable pxp under this fatal error condition. > > alan:skip alan: this looks good (as

Re: [Intel-gfx] [PATCH] drm/i915: Initialize residency registers earlier

2023-11-13 Thread Teres Alexis, Alan Previn
On Mon, 2023-10-30 at 16:45 -0700, Belgaumkar, Vinay wrote: alan:skip > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c > @@ -608,11 +608,13 @@ void intel_rc6_init(struct intel_rc6 *rc6) > /* Disable runtime-pm until we can save the GPU state with rc6 pctx */ > rpm_get(rc6); > > - if

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file

2023-11-13 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file URL : https://patchwork.freedesktop.org/series/126352/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file

2023-11-13 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file URL : https://patchwork.freedesktop.org/series/126352/ State : warning == Summary == Error: dim checkpatch failed e709bd08c34c drm/i915/display: Separate xe and i915

Re: [Intel-gfx] [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-13 Thread kernel test robot
Hi Imre, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-dp-Fix-UHBR-link-M-N-values/20231114-043135 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link:

Re: [Intel-gfx] [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-13 Thread kernel test robot
Hi Imre, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-dp-Fix-UHBR-link-M-N-values/20231114-043135 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/dp: Account for channel coding efficiency on UHBR links

2023-11-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dp: Account for channel coding efficiency on UHBR links URL : https://patchwork.freedesktop.org/series/126350/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13870 -> Patchwork_126350v1

[Intel-gfx] [PATCH v3] drm/i915: Skip pxp init if gt is wedged

2023-11-13 Thread Zhanjun Dong
The gt wedged could be triggered by missing guc firmware file, HW not working, etc. Once triggered, it means all gt usage is dead, therefore we can't enable pxp under this fatal error condition. v2: Updated commit message. v3: Updated return code check. Signed-off-by: Zhanjun Dong ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/dp: Account for channel coding efficiency on UHBR links

2023-11-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dp: Account for channel coding efficiency on UHBR links URL : https://patchwork.freedesktop.org/series/126350/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: move *_crtc_clock_get() to intel_dpll.c

2023-11-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: move *_crtc_clock_get() to intel_dpll.c URL : https://patchwork.freedesktop.org/series/126345/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13870 -> Patchwork_126345v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: move *_crtc_clock_get() to intel_dpll.c

2023-11-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: move *_crtc_clock_get() to intel_dpll.c URL : https://patchwork.freedesktop.org/series/126345/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: move *_crtc_clock_get() to intel_dpll.c

2023-11-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: move *_crtc_clock_get() to intel_dpll.c URL : https://patchwork.freedesktop.org/series/126345/ State : warning == Summary == Error: dim checkpatch failed 55d6d32443b1 drm/i915: move *_crtc_clock_get() to intel_dpll.c -:342:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Tune down FEC detection timeout error message

2023-11-13 Thread Patchwork
== Series Details == Series: drm/i915/dp: Tune down FEC detection timeout error message URL : https://patchwork.freedesktop.org/series/126340/ State : success == Summary == CI Bug Log - changes from CI_DRM_13870 -> Patchwork_126340v1

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Audio fastset, and some fixes (rev2)

2023-11-13 Thread Patchwork
== Series Details == Series: drm/i915: Audio fastset, and some fixes (rev2) URL : https://patchwork.freedesktop.org/series/126041/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/126041/revisions/2/mbox/ not applied Applying: drm/i915: Check pipe

Re: [Intel-gfx] [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Wolfram Sang
> We're not in a hurry. It's just my experience with patch series' affecting > multiple subsystems that typically the decision was to apply the full > series via one tree. Also to avoid inquires from maintainers like: > Shall I take it or are you going to take it? > Of course there may be

Re: [Intel-gfx] [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
On 13.11.2023 18:49, Wolfram Sang wrote: > >> Preferably this series should be applied via the i2c tree. > > Are we in a hurry here, i.e. does it block further development of the > i801 smbus driver? My gut feeling says the patches should rather go via > drm and fbdev trees, but I may be

Re: [Intel-gfx] [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
On 13.11.2023 18:50, Jani Nikula wrote: > On Mon, 13 Nov 2023, Heiner Kallweit wrote: >> On 13.11.2023 13:17, Jani Nikula wrote: >>> On Mon, 13 Nov 2023, Heiner Kallweit wrote: After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver

Re: [Intel-gfx] [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Wolfram Sang
> Preferably this series should be applied via the i2c tree. Are we in a hurry here, i.e. does it block further development of the i801 smbus driver? My gut feeling says the patches should rather go via drm and fbdev trees, but I may be convinced otherwise. signature.asc Description: PGP

[Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Stephen Rothwell
Hi all, Commit 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpVEQIISTHPP.pgp Description: OpenPGP digital signature

[Intel-gfx] [PATCH 3/3] drm/i915/display: In intel_framebuffer_init switch to use intel_bo_to_drm_bo

2023-11-13 Thread Juha-Pekka Heikkila
Use intel_bo_to_drm_bo instead of >base. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c index

[Intel-gfx] [PATCH 2/3] drm/i915/display: in skl_surf_address check for dpt-vma

2023-11-13 Thread Juha-Pekka Heikkila
touch dpt_vma->node only if dpt-vma is not NULL Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c

[Intel-gfx] [PATCH 1/3] drm/i915/display: Separate xe and i915 common dpt code into own file

2023-11-13 Thread Juha-Pekka Heikkila
Here created intel_dpt_common.c to hold intel_dpt_configure which is needed for both xe and i915. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_dpt.c | 26

Re: [Intel-gfx] [PATCH] drm/i915: eliminate warnings

2023-11-13 Thread Rodrigo Vivi
On Mon, Nov 13, 2023 at 11:36:13AM +0800, heminhong wrote: > Current, the dewake_scanline variable is defined as unsigned int, > an unsigned int variable that is always greater than or equal to 0. > when _intel_dsb_commit function is called by intel_dsb_commit function, > the dewake_scanline

[Intel-gfx] [PATCH 3/4] drm/i915/dp_mst: Fix PBN / MTP_TU size calculation for UHBR rates

2023-11-13 Thread Imre Deak
Atm the allocated MST PBN value is calculated from the TU size (number of allocated MTP slots) as PBN = TU * pbn_div pbn_div being the link BW for each MTP slot. For DP 1.4 link rates this worked, as pbn_div there is guraranteed to be an integer number, however on UHBR this isn't the case. To

[Intel-gfx] [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-13 Thread Imre Deak
The current way of calculating the pbn_div value, the link BW per each MTP slot, worked only for DP 1.4 link rates. Fix things up for UHBR rates calculating with the correct channel coding efficiency based on the link rate. On UHBR the resulting pbn_div value is not an integer (vs. DP 1.4 where

[Intel-gfx] [PATCH 1/4] drm/i915/dp: Account for channel coding efficiency on UHBR links

2023-11-13 Thread Imre Deak
Apply the correct BW allocation overhead and channel coding efficiency on UHBR link rates, similarly to DP1.4 link rates. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 10 -- 1 file changed, 10 deletions(-) diff --git

[Intel-gfx] [PATCH 2/4] drm/i915/dp: Fix UHBR link M/N values

2023-11-13 Thread Imre Deak
The link M/N ratio is the data rate / link symbol clock rate, fix things up accordingly. On DP 1.4 this ratio was correct as the link symbol clock rate in that case matched the link data rate (in bytes/sec units, the symbol size being 8 bits), however it wasn't correct for UHBR rates where the

[Intel-gfx] ✓ Fi.CI.BAT: success for Fuse submount_lookup needs to be initialized

2023-11-13 Thread Patchwork
== Series Details == Series: Fuse submount_lookup needs to be initialized URL : https://patchwork.freedesktop.org/series/126336/ State : success == Summary == CI Bug Log - changes from CI_DRM_13869 -> Patchwork_126336v1 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fuse submount_lookup needs to be initialized

2023-11-13 Thread Patchwork
== Series Details == Series: Fuse submount_lookup needs to be initialized URL : https://patchwork.freedesktop.org/series/126336/ State : warning == Summary == Error: dim checkpatch failed 919b794dcf31 fuse: ensure submount_lookup is initialized on alloc 75bb4ac3057d fuse: share lookup state

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: eliminate warnings

2023-11-13 Thread Patchwork
== Series Details == Series: drm/i915: eliminate warnings URL : https://patchwork.freedesktop.org/series/126338/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13869 -> Patchwork_126338v1 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/ttm: replace busy placement with flags v3

2023-11-13 Thread Patchwork
== Series Details == Series: drm/ttm: replace busy placement with flags v3 URL : https://patchwork.freedesktop.org/series/126330/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13869 -> Patchwork_126330v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/ttm: replace busy placement with flags v3

2023-11-13 Thread Patchwork
== Series Details == Series: drm/ttm: replace busy placement with flags v3 URL : https://patchwork.freedesktop.org/series/126330/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/ttm: replace busy placement with flags v3

2023-11-13 Thread Patchwork
== Series Details == Series: drm/ttm: replace busy placement with flags v3 URL : https://patchwork.freedesktop.org/series/126330/ State : warning == Summary == Error: dim checkpatch failed ecd11ffa98ca drm/ttm: replace busy placement with flags v3 -:296: WARNING:UNSPECIFIED_INT: Prefer

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-13 Thread Teres Alexis, Alan Previn
On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: > On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: > > On Thu, 2023-09-28 at 13:46 +0100, Tvrtko Ursulin wrote: > > > On 27/09/2023 17:36, Teres Alexis, Alan Previn wrote: alan:snip > > > It is not possible to wait for lost G2H in

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev3)

2023-11-13 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev3) URL : https://patchwork.freedesktop.org/series/126250/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13869 -> Patchwork_126250v3

Re: [Intel-gfx] [PATCH v2] Remove custom dumb_map_offset implementations in i915 driver

2023-11-13 Thread Jani Nikula
On Sat, 11 Nov 2023, Dipam Turkar wrote: > Making i915 use drm_gem_create_mmap_offset() instead of its custom > implementations for associating GEM object with a fake offset. It would probably help a lot if your commit messages explained what you are trying to achieve and, especially, why. This

Re: [Intel-gfx] [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-13 Thread Jani Nikula
On Mon, 13 Nov 2023, Heiner Kallweit wrote: > On 13.11.2023 13:17, Jani Nikula wrote: >> On Mon, 13 Nov 2023, Heiner Kallweit wrote: >>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >>>

Re: [Intel-gfx] [PATCH 0/4] drm/i915: Fix LUT rounding

2023-11-13 Thread Jani Nikula
On Fri, 13 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > The current LUT rounding is generating weird results. Adjust > it to follow the OpenGL int<->float conversion rules. Reviewed-by: Jani Nikula > > Ville Syrjälä (4): > drm: Fix color LUT rounding > drm/i915: Adjust LUT

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev3)

2023-11-13 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev3) URL : https://patchwork.freedesktop.org/series/126250/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

Re: [Intel-gfx] [PATCH] drm/i915/dp: Tune down FEC detection timeout error message

2023-11-13 Thread Jani Nikula
On Mon, 13 Nov 2023, Imre Deak wrote: > At least a Realtek DP branch device with the > > OUI 00-e0-4c dev-ID Dp1.4 HW-rev 1.0 SW-rev 131.1 > > device identification doesn't report detecting the FEC decoding start > symbol. Tune down the corresponding error to a debug message. > > Signed-off-by:

[Intel-gfx] [PATCH 4/4] drm/i915: move sideband regs to vlv_sideband_reg.h

2023-11-13 Thread Jani Nikula
Move the VLV/CHV sideband doorbell and data/addr MMIO registers as well as the DPIO register definitions to vlv_sideband_reg.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 374 --- drivers/gpu/drm/i915/vlv_sideband_reg.h | 377

[Intel-gfx] [PATCH 3/4] drm/i915: convert vlv_dpio_read()/write() from pipe to phy

2023-11-13 Thread Jani Nikula
vlv_dpio_read() and vlv_dpio_write() really operate on the phy, not pipe. Passing the pipe instead of the phy as parameter is supposed to be a convenience, but when the caller has the phy, it becomes an inconvenience. See e.g. chv_dpio_cmn_power_well_enable() and assert_chv_phy_powergate().

[Intel-gfx] [PATCH 2/4] drm/i915: add vlv_pipe_to_phy() helper to replace DPIO_PHY()

2023-11-13 Thread Jani Nikula
Add a helper with better typing and handing for bogus input, and better in line with vlv_dig_port_to_channel(), vlv_dig_port_to_phy(), and vlv_pipe_to_channel(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 14 ++

[Intel-gfx] [PATCH 1/4] drm/i915: move *_crtc_clock_get() to intel_dpll.c

2023-11-13 Thread Jani Nikula
Considering what the functions do, intel_dpll.c is a more suitable location, and lets us make some functions static while at it. This also means intel_display.c no longer does any DPIO access. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 171 -

Re: [Intel-gfx] [PATCH] drm/i915/gsc: Assign a uabi class number to the GSC CS

2023-11-13 Thread Tvrtko Ursulin
On 13/11/2023 15:51, Daniele Ceraolo Spurio wrote: On 11/10/2023 4:00 AM, Tvrtko Ursulin wrote: On 09/11/2023 23:53, Daniele Ceraolo Spurio wrote: The GSC CS is not exposed to the user, so we skipped assigning a uabi class number for it. However, the trace logs use the uabi class and

Re: [Intel-gfx] [PATCH 11/11] drm/i915: Implement audio fastset

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > There's no real why we'd need a full modeset for audio changes. +reason Reviewed-by: Jani Nikula > So let's allow audio to be toggled during fastset. In case the > ELD changes while has_audio isn't changing state we force

Re: [Intel-gfx] [PATCH] drm/i915/gsc: Assign a uabi class number to the GSC CS

2023-11-13 Thread Daniele Ceraolo Spurio
On 11/10/2023 4:00 AM, Tvrtko Ursulin wrote: On 09/11/2023 23:53, Daniele Ceraolo Spurio wrote: The GSC CS is not exposed to the user, so we skipped assigning a uabi class number for it. However, the trace logs use the uabi class and instance to identify the engine, so leaving uabi class

Re: [Intel-gfx] [PATCH 10/11] drm/i915: Push audio_{enable, disable}() to the pre/post pane update stage

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Relocate the audio enable/disable from the full modeset hooks into > the common pre/post plane update stage of the commit. Audio fastset > is within easy reach now. > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Hoist the encoder->audio_{enable, disable}() calls higher up

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Push he encoder->audio_{enable,disable}() calls out from the *the > encoder->{enable,disable}() hooks. Moving towards audio fastset. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/g4x_dp.c| 2

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Hoist the encoder->audio_{enable, disable}() calls higher up

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Push he encoder->audio_{enable,disable}() calls out from the > encoder->{enable,disable}() hooks. Moving towards audio fastset. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH 08/11] drm/i915: Convert audio enable/disable into encoder vfuncs

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Add encoder vfuncs for audio enable/disable. This will enable > audio to be enable/disabe during fastsets. An encoder hook *enabled/disabled Reviewed-by: Jani Nikula > is necessary as on pre-hsw platforms different encoder

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Split g4x+ HDMI audio presence detect from port enable

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Follow the hsw+ approach toggle the audio presence detect > when we set up the ELD, instead of doing it when turning the > port on/off. > > This will facilitate audio enable/disable to happen during > fastsets instead of

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Split g4x+ DP audio presence detect from port enable

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Follow the hsw+ approach toggle the audio presence detect > when we set up the ELD, instead of doing it when turning the > port on/off. > > This will facilitate audio enable/disable to happen during > fastsets instead of

Re: [Intel-gfx] [PATCH 05/11] drm/i915: Wrap g4x+ DP/HDMI audio enable/disable

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Put a wrapper around the intel_audio_codec_{enable,disable}() > calls in the g4x+ DP/HDMI code. We shall move the presence > detect enable/disable into the wrappers later. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani

Re: [Intel-gfx] [PATCH] drm/i915/huc: Stop printing about unsupported HuC on MTL

2023-11-13 Thread Daniele Ceraolo Spurio
On 11/9/2023 6:06 PM, John Harrison wrote: On 11/9/2023 15:54, Daniele Ceraolo Spurio wrote: On MTL, the HuC is only supported on the media GT, so our validation check on the module parameter detects an inconsistency on the root GT (the modparams asks to enable HuC, but the support is not

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Push audio enable/disable further out

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Push the audio enable/disable to be the last/first thing > respectively that is done in the encoder enable/disable hooks. > The goal is to move it further out of these encoder hooks entirely. > > Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Polish some RMWs

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Doing the if-else around RMWs is kinda silly. Just set/clear the > apporiate bits with a single RMW. > > Also unify the coding style a bit icl_wa_cursorclkgating() while at it. > > Signed-off-by: Ville Syrjälä Reviewed-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Use int for entry setup frames

2023-11-13 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Use int for entry setup frames URL : https://patchwork.freedesktop.org/series/126325/ State : success == Summary == CI Bug Log - changes from CI_DRM_13868 -> Patchwork_126325v1 Summary ---

Re: [Intel-gfx] [PATCH 02/11] drm/i915: Call intel_pre_plane_updates() also for pipes getting enabled

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > We used to call intel_pre_plane_updates() for any pipe going through > a modeset whether the pipe was previously enabled or not. This in > fact needed to apply all the necessary clock gating workarounds/etc. > Restore the

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Check pipe active state in {planes, vrr}_{enabling, disabling}()

2023-11-13 Thread Jani Nikula
On Mon, 06 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > {planes,vrr}_{enabling,disabling}() are supposed to indicate > whether the specific hardware feature is supposed to be enabling > or disabling. That can only makes sense if the pipe is active > overall. So check for that before

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Remove return type from i915_drm_client_remove_object

2023-11-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Remove return type from i915_drm_client_remove_object URL : https://patchwork.freedesktop.org/series/126323/ State : success == Summary == CI Bug Log - changes from CI_DRM_13868 -> Patchwork_126323v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Remove return type from i915_drm_client_remove_object

2023-11-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Remove return type from i915_drm_client_remove_object URL : https://patchwork.freedesktop.org/series/126323/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] [PATCH] drm/i915/dp: Tune down FEC detection timeout error message

2023-11-13 Thread Imre Deak
At least a Realtek DP branch device with the OUI 00-e0-4c dev-ID Dp1.4 HW-rev 1.0 SW-rev 131.1 device identification doesn't report detecting the FEC decoding start symbol. Tune down the corresponding error to a debug message. Signed-off-by: Imre Deak ---

[Intel-gfx] [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[Intel-gfx] [v5 PATCH 2/2] fuse: share lookup state between submount and its parent

2023-11-13 Thread Krister Johansen
Fuse submounts do not perform a lookup for the nodeid that they inherit from their parent. Instead, the code decrements the nlookup on the submount's fuse_inode when it is instantiated, and no forget is performed when a submount root is evicted. Trouble arises when the submount's parent is

[Intel-gfx] [PATCH] drm/i915: eliminate warnings

2023-11-13 Thread heminhong
Current, the dewake_scanline variable is defined as unsigned int, an unsigned int variable that is always greater than or equal to 0. when _intel_dsb_commit function is called by intel_dsb_commit function, the dewake_scanline variable may have an int value. So the dewake_scanline variable is

Re: [Intel-gfx] [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
On 13.11.2023 13:17, Jani Nikula wrote: > On Mon, 13 Nov 2023, Heiner Kallweit wrote: >> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >> Class-based device auto-detection is a legacy mechanism and

[Intel-gfx] [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[Intel-gfx] [PATCH 1/2] fuse: ensure submount_lookup is initialized on alloc

2023-11-13 Thread Krister Johansen
When introduced, the submount lookup reference tracking neglected to set an initial value in the fuse inode as part of fuse_inode_alloc. Users running with SLUB_DEBUG enabled caught and reported this error. Fix by ensuring that this value is always initialized to NULL. Signed-off-by: Krister

[Intel-gfx] [PATCH 0/2] Fuse submount_lookup needs to be initialized

2023-11-13 Thread Krister Johansen
Hi Miklos, I got a couple of bug reports[1][2] this morning from teams that are tracking regresssions in linux-next. My patch 513dfacefd71 ("fuse: share lookup state between submount and its parent") is causing panics in the fuse unmount path. The reports came from users with SLUB_DEBUG enabled,

Re: [Intel-gfx] Regression on linux-next (next-20231107)

2023-11-13 Thread Krister Johansen
Hi Chaitanya, On Thu, Nov 09, 2023 at 05:00:09PM +, Borah, Chaitanya Kumar wrote: > Hello Krister, > > Hope you are doing well. I am Chaitanya from the linux graphics team in Intel. > > This mail is regarding a regression we are seeing in our CI runs[1] for some > machines (dg2 and

Re: [Intel-gfx] [PATCH] drm: i915: Adapt to -Walloc-size

2023-11-13 Thread Sam James
Jani Nikula writes: > On Tue, 07 Nov 2023, Sam James wrote: >> GCC 14 introduces a new -Walloc-size included in -Wextra which errors out >> like: >> ``` >> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c: In function >> ‘eb_copy_relocations’: >>

Re: [Intel-gfx] [PATCH 0/2] Fuse submount_lookup needs to be initialized

2023-11-13 Thread Miklos Szeredi
On Thu, 9 Nov 2023 at 23:37, Krister Johansen wrote: > Either should do, but I wasn't sure which approach was preferable. An incremental is better in this situation. Applied and pushed. > Thanks, and my apologies for the inconvenience. Really no need to apologize, this happens and the best

Re: [Intel-gfx] [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-13 Thread Jani Nikula
On Mon, 13 Nov 2023, Heiner Kallweit wrote: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be used in new code. So we can

[Intel-gfx] [PATCH] drm/ttm: replace busy placement with flags v3

2023-11-13 Thread Somalapuram Amaranath
Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TTM_PL_FLAG_IDLE for i915 v3: fix auto build test ERROR on drm-tip/drm-tip Signed-off-by: Christian König ---

[Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames

2023-11-13 Thread Mika Kahola
At least one TGL had regression when using u8 types for entry setup frames calculation. So, let's switch to use ints instead. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_psr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 2/2] drm/i915: Add __rcu annotation to cursor when iterating client objects

2023-11-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin __rcu annotation is needed to avoid the sparse warnings such as: .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in comparison expression (different address spaces): .../i915_drm_client.c:92:9: sparse:struct list_head [noderef] __rcu *

[Intel-gfx] [PATCH 1/2] drm/i915: Remove return type from i915_drm_client_remove_object

2023-11-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There is no need to return anything in the version which was merged and also the implementation of the !CONFIG_PROC_FS wasn't returning anything, causing a build failure there. Signed-off-by: Tvrtko Ursulin Fixes: e4ae85e364fc ("drm/i915: Add ability for tracking buffer

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev2)

2023-11-13 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev2) URL : https://patchwork.freedesktop.org/series/126250/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13867 -> Patchwork_126250v2

  1   2   >