RE: [PATCH v2 04/21] drm/i915/dp: Add support to notify MST connectors to retry modesets

2024-02-22 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Wednesday, February 21, 2024 2:48 AM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Hogander, Jouni > Subject: [PATCH v2 04/21] drm/i915/dp: Add support to notify MST connectors to >

RE: [PATCH v2 03/21] drm/i915: Fix display bpp limit computation during system resume

2024-02-22 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Imre > Deak > Sent: Wednesday, February 21, 2024 2:48 AM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: [PATCH v2 03/21] drm/i915: Fix display bpp limit computation during > system resume > > The

RE: [PATCH v2 02/21] drm/dp: Add support for DP tunneling

2024-02-22 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Wednesday, February 21, 2024 2:48 AM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Ville Syrjälä > Subject: [PATCH v2 02/21] drm/dp: Add support for DP tunneling > > Add support for

✓ Fi.CI.IGT: success for IO and fast wake lines calculation and increase fw sync length (rev2)

2024-02-22 Thread Patchwork
== Series Details == Series: IO and fast wake lines calculation and increase fw sync length (rev2) URL : https://patchwork.freedesktop.org/series/130173/ State : success == Summary == CI Bug Log - changes from CI_DRM_14319_full -> Patchwork_130173v2_full

✗ Fi.CI.IGT: failure for drm/i915/selftests: Fix dependency of some timeouts on HZ

2024-02-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix dependency of some timeouts on HZ URL : https://patchwork.freedesktop.org/series/130249/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14316_full -> Patchwork_130249v1_full

✓ Fi.CI.BAT: success for drm/i915: Add missing ; to __assign_str() macros in tracepoint code

2024-02-22 Thread Patchwork
== Series Details == Series: drm/i915: Add missing ; to __assign_str() macros in tracepoint code URL : https://patchwork.freedesktop.org/series/130279/ State : success == Summary == CI Bug Log - changes from CI_DRM_14322 -> Patchwork_130279v1

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add missing ; to __assign_str() macros in tracepoint code

2024-02-22 Thread Patchwork
== Series Details == Series: drm/i915: Add missing ; to __assign_str() macros in tracepoint code URL : https://patchwork.freedesktop.org/series/130279/ State : warning == Summary == Error: dim checkpatch failed 871d6a86ca24 drm/i915: Add missing ; to __assign_str() macros in tracepoint code

✓ Fi.CI.BAT: success for drm/i915/panelreplay: Move out psr_init_dpcd() from init_connector()

2024-02-22 Thread Patchwork
== Series Details == Series: drm/i915/panelreplay: Move out psr_init_dpcd() from init_connector() URL : https://patchwork.freedesktop.org/series/130276/ State : success == Summary == CI Bug Log - changes from CI_DRM_14322 -> Patchwork_130276v1

✓ Fi.CI.BAT: success for ALSA/ASoC: Conditionally skip i915 init and cleanups

2024-02-22 Thread Patchwork
== Series Details == Series: ALSA/ASoC: Conditionally skip i915 init and cleanups URL : https://patchwork.freedesktop.org/series/130271/ State : success == Summary == CI Bug Log - changes from CI_DRM_14321 -> Patchwork_130271v1 Summary

✗ Fi.CI.SPARSE: warning for ALSA/ASoC: Conditionally skip i915 init and cleanups

2024-02-22 Thread Patchwork
== Series Details == Series: ALSA/ASoC: Conditionally skip i915 init and cleanups URL : https://patchwork.freedesktop.org/series/130271/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

✓ Fi.CI.BAT: success for drm/i915/mtl: Update workaround 14018778641 (rev3)

2024-02-22 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update workaround 14018778641 (rev3) URL : https://patchwork.freedesktop.org/series/119517/ State : success == Summary == CI Bug Log - changes from CI_DRM_14321 -> Patchwork_119517v3 Summary

✗ Fi.CI.BUILD: failure for series starting with [1/3] sna: stop using obsolete type aliases

2024-02-22 Thread Patchwork
== Series Details == Series: series starting with [1/3] sna: stop using obsolete type aliases URL : https://patchwork.freedesktop.org/series/130259/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/130259/revisions/1/mbox/ not applied Applying:

Re: [PATCH] drm/i915/guc: Add Compute context hint

2024-02-22 Thread Belgaumkar, Vinay
On 2/22/2024 7:32 AM, Tvrtko Ursulin wrote: On 21/02/2024 21:28, Rodrigo Vivi wrote: On Wed, Feb 21, 2024 at 09:42:34AM +, Tvrtko Ursulin wrote: On 21/02/2024 00:14, Vinay Belgaumkar wrote: Allow user to provide a context hint. When this is set, KMD will send a hint to GuC which

✓ Fi.CI.BAT: success for LNL display

2024-02-22 Thread Patchwork
== Series Details == Series: LNL display URL : https://patchwork.freedesktop.org/series/130255/ State : success == Summary == CI Bug Log - changes from CI_DRM_14320 -> Patchwork_130255v1 Summary --- **SUCCESS** No regressions

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-22 Thread Matt Roper
On Thu, Feb 22, 2024 at 11:03:27PM +0100, Andi Shyti wrote: > Hi Matt, > > first of all thanks a lot for the observations you are raising. > > On Wed, Feb 21, 2024 at 12:51:04PM -0800, Matt Roper wrote: > > On Wed, Feb 21, 2024 at 01:12:18AM +0100, Andi Shyti wrote: > > > On Tue, Feb 20, 2024 at

✗ Fi.CI.SPARSE: warning for LNL display

2024-02-22 Thread Patchwork
== Series Details == Series: LNL display URL : https://patchwork.freedesktop.org/series/130255/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-22 Thread Andi Shyti
Hi Matt, first of all thanks a lot for the observations you are raising. On Wed, Feb 21, 2024 at 12:51:04PM -0800, Matt Roper wrote: > On Wed, Feb 21, 2024 at 01:12:18AM +0100, Andi Shyti wrote: > > On Tue, Feb 20, 2024 at 03:39:18PM -0800, Matt Roper wrote: > > > On Tue, Feb 20, 2024 at

Re: [PATCH 07/12] drm/i915: Use drm_printer more extensively in intel_crtc_state_dump()

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 15, 2024 at 06:40:50PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Convert all the direct drm_dbg_kms() stuff in intel_crtc_state_dump() > over to drm_printf() since we now have the drm_printer around. looking all this I ask myself if it is really a good idea to move from

Re: [PATCH 06/12] drm/i915: Convert intel_dpll_dump_hw_state() to drm_printer

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 15, 2024 at 06:40:49PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Utilize drm_printer in pipe_config_pll_mismatch() to avoid > a bit of code duplication. > > To achieve this we need to plumb the printer all way to the > dpll_mgr .dump_hw_state() functions. Those are also

Re: [PATCH 05/12] drm/i915: Convert pipe_config_buffer_mismatch() to drm_printer

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 15, 2024 at 06:40:48PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Utilize drm_printer in pipe_config_infoframe_mismatch() to avoid > a bit of code duplication. > > print_hex_dump() doesn't know anything about the printer so > it still needs the DRM_UT_KMS check and

Re: [PATCH 04/12] drm/i915: Convert pipe_config_infoframe_mismatch() to drm_printer

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 15, 2024 at 06:40:47PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Utilize drm_printer in pipe_config_infoframe_mismatch() to avoid > a bit of code duplication. > > hdmi_infoframe_log() can't use the printer of course, but for that > we can just figure out which loglevel

Re: [PATCH 03/12] drm/i915: Include CRTC info in VSC SDP mismatch prints

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 15, 2024 at 06:40:46PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Most crtc state mismatches include the CRTC id+name in the > prints. Also include it in the VSC SDP mismatches. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c | 13

Re: [PATCH 02/12] drm/i915: Include CRTC info in infoframe mismatch prints

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 15, 2024 at 06:40:45PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Most crtc state mismatches include the CRTC id+name in the > prints. Also include it in the infoframe mismatches. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c | 14

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 15, 2024 at 06:40:44PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_crtc_check_fastset() is done per-pipe, so it would be nice > to know which pipe it was that failed its checkup. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c

Re: [PATCH] drm/i915/mtl: Update workaround 14018778641

2024-02-22 Thread Matt Roper
On Thu, Feb 22, 2024 at 07:27:15PM +0530, Tejas Upadhyay wrote: > Applying WA 14018778641 only on Compute engine has impact on 14018778641 is not a workaround number. The only lineage numbers that are relevant to this programming are Wa_18018781329 (for DG2) and Wa_14018575942 (for MTL/ARL).

Re: [PATCH v1 5/6] drm/i915/xe2lpd: Load DMC

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 22, 2024 at 02:56:33PM +0200, Vinod Govindapillai wrote: > From: Balasubramani Vivekanandan > > Load DMC for XE2LPD. The value 0x8000 is the maximum payload size for > any xe2lpd dmc firmware. > > Signed-off-by: Balasubramani Vivekanandan > > Signed-off-by: Dnyaneshwar Bhadane

Re: [PATCH 2/2] drm/i915: Support replaying GPU hangs with captured context image

2024-02-22 Thread Rodrigo Vivi
On Wed, Feb 21, 2024 at 02:22:45PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > When debugging GPU hangs Mesa developers are finding it useful to replay > the captured error state against the simulator. But due various simulator > limitations which prevent replicating all hangs, one

Re: [PATCH 1/2] drm/i915: Shadow default engine context image in the context

2024-02-22 Thread Rodrigo Vivi
On Wed, Feb 21, 2024 at 02:22:44PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > To enable adding override of the default engine context image let us start > shadowing the per engine state in the context. > > Signed-off-by: Tvrtko Ursulin > Cc: Lionel Landwerlin > Cc: Carlos Santa

Re: [PATCH 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 22, 2024 at 06:53:12PM +0100, Cezary Rojewski wrote: > On 2024-02-22 6:24 PM, Ville Syrjälä wrote: > > On Thu, Feb 22, 2024 at 06:06:11PM +0100, Cezary Rojewski wrote: > > > Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends > > > removed support for i915 for all

Re: [PATCH v1 5/6] drm/i915/xe2lpd: Load DMC

2024-02-22 Thread Gustavo Sousa
Quoting Lucas De Marchi (2024-02-22 11:26:57-03:00) >On Thu, Feb 22, 2024 at 02:56:33PM +0200, Vinod Govindapillai wrote: >>From: Balasubramani Vivekanandan >> >>Load DMC for XE2LPD. The value 0x8000 is the maximum payload size for >>any xe2lpd dmc firmware. >> >>Signed-off-by: Balasubramani

✗ Fi.CI.BAT: failure for Enable Adaptive Sync SDP Support for DP (rev10)

2024-02-22 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev10) URL : https://patchwork.freedesktop.org/series/126829/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14319 -> Patchwork_126829v10 Summary ---

PR for Xe2LPD DMC v2.18

2024-02-22 Thread Gustavo Sousa
The following changes since commit 78b99e9ebad8e4e24dded99842f94a8a7db3a5e8: Merge branch 'robot/pr-0-1708610465' into 'main' (2024-02-22 14:24:47 +) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware xe2lpd_dmc_2.18 for you to fetch changes up to

✗ Fi.CI.SPARSE: warning for Enable Adaptive Sync SDP Support for DP (rev10)

2024-02-22 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev10) URL : https://patchwork.freedesktop.org/series/126829/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

RE: GuC issue

2024-02-22 Thread Harrison, John C
Hello, That worked better. The complaint is that the engine mapping table is invalid. See the i915 code in guc_mapping_table_init () in gt/uc/intel_guc_ads.c for an example of how to initialise the table. John. -Original Message- From: mak...@wezdecki.pl Sent: Wednesday, February

Re: [PATCH] drm/i915: Add missing ; to __assign_str() macros in tracepoint code

2024-02-22 Thread Steven Rostedt
On Thu, 22 Feb 2024 14:04:20 -0500 Rodrigo Vivi wrote: > > Note, I have patches that depend on this fix, so if one of the maintainers > > would like to just give me an "Acked-by", I'll take it through my tree. I > > doubt it will have any conflicts, unless you are planning on changing the > >

✓ Fi.CI.BAT: success for IO and fast wake lines calculation and increase fw sync length (rev2)

2024-02-22 Thread Patchwork
== Series Details == Series: IO and fast wake lines calculation and increase fw sync length (rev2) URL : https://patchwork.freedesktop.org/series/130173/ State : success == Summary == CI Bug Log - changes from CI_DRM_14319 -> Patchwork_130173v2

✗ Fi.CI.SPARSE: warning for IO and fast wake lines calculation and increase fw sync length (rev2)

2024-02-22 Thread Patchwork
== Series Details == Series: IO and fast wake lines calculation and increase fw sync length (rev2) URL : https://patchwork.freedesktop.org/series/130173/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v3 2/2] drm/dp: drop the size parameter from drm_dp_vsc_sdp_pack()

2024-02-22 Thread Rodrigo Vivi
On Tue, Feb 20, 2024 at 11:53:47AM -0800, Abhinav Kumar wrote: > Currently the size parameter of drm_dp_vsc_sdp_pack() is always > the size of struct dp_sdp. Hence lets drop this parameter and > use sizeof() directly. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Abhinav Kumar it looks

Re: [PATCH v3 2/2] drm/dp: drop the size parameter from drm_dp_vsc_sdp_pack()

2024-02-22 Thread Rodrigo Vivi
On Tue, Feb 20, 2024 at 11:53:47AM -0800, Abhinav Kumar wrote: > Currently the size parameter of drm_dp_vsc_sdp_pack() is always > the size of struct dp_sdp. Hence lets drop this parameter and > use sizeof() directly. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Abhinav Kumar > --- >

Re: [PATCH] drm/i915: Add missing ; to __assign_str() macros in tracepoint code

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 22, 2024 at 01:43:49PM -0500, Steven Rostedt wrote: > On Thu, 22 Feb 2024 13:30:57 -0500 > Steven Rostedt wrote: > > > From: "Steven Rostedt (Google)" > > > > I'm working on improving the __assign_str() and __string() macros to be > > more efficient, and removed some unneeded

✓ Fi.CI.IGT: success for HDCP MST Type1 fixes (rev4)

2024-02-22 Thread Patchwork
== Series Details == Series: HDCP MST Type1 fixes (rev4) URL : https://patchwork.freedesktop.org/series/129925/ State : success == Summary == CI Bug Log - changes from CI_DRM_14314_full -> Patchwork_129925v4_full Summary ---

Re: [PATCH] drm/i915: Add missing ; to __assign_str() macros in tracepoint code

2024-02-22 Thread Steven Rostedt
On Thu, 22 Feb 2024 20:42:59 +0200 Ville Syrjälä wrote: > On Thu, Feb 22, 2024 at 01:30:57PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > I'm working on improving the __assign_str() and __string() macros to be > > more efficient, and removed some unneeded

Re: [PATCH] drm/i915: Add missing ; to __assign_str() macros in tracepoint code

2024-02-22 Thread Ville Syrjälä
On Thu, Feb 22, 2024 at 01:30:57PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > I'm working on improving the __assign_str() and __string() macros to be > more efficient, and removed some unneeded semicolons. This triggered a bug > in the build as some of the __assign_str()

Re: [PATCH] drm/i915: Add missing ; to __assign_str() macros in tracepoint code

2024-02-22 Thread Steven Rostedt
On Thu, 22 Feb 2024 13:30:57 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > I'm working on improving the __assign_str() and __string() macros to be > more efficient, and removed some unneeded semicolons. This triggered a bug > in the build as some of the __assign_str()

[PATCH] drm/i915: Add missing ; to __assign_str() macros in tracepoint code

2024-02-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" I'm working on improving the __assign_str() and __string() macros to be more efficient, and removed some unneeded semicolons. This triggered a bug in the build as some of the __assign_str() macros in intel_display_trace was missing a terminating semicolon. Fixes:

[PATCH] drm/i915/panelreplay: Move out psr_init_dpcd() from init_connector()

2024-02-22 Thread Animesh Manna
Move psr_init_dpcd() from init-connector to connector-detect function. Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_dp.c | 3 +++ drivers/gpu/drm/i915/display/intel_psr.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

✓ Fi.CI.BAT: success for drm/i915/selftests: Fix dependency of some timeouts on HZ

2024-02-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix dependency of some timeouts on HZ URL : https://patchwork.freedesktop.org/series/130249/ State : success == Summary == CI Bug Log - changes from CI_DRM_14316 -> Patchwork_130249v1

Re: [PATCH 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

2024-02-22 Thread Cezary Rojewski
On 2024-02-22 6:24 PM, Ville Syrjälä wrote: On Thu, Feb 22, 2024 at 06:06:11PM +0100, Cezary Rojewski wrote: Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends removed support for i915 for all CNL-based platforms. HDAudio library, however, still treats such platforms as

Re: [PATCH] drm/i915: Fix possible null pointer dereference after drm_dbg_printer conversion

2024-02-22 Thread Maxime Ripard
On Mon, 19 Feb 2024 13:14:23 +, Tvrtko Ursulin wrote: > Request can be NULL if no guilty request was identified so simply use > engine->i915 instead. > > Applied to drm/drm-misc (drm-misc-next-fixes). Thanks! Maxime

[PULL] drm-misc-fixes

2024-02-22 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-02-22: A list handling fix and 64bit division on 32bit platform fix for the drm/buddy allocator, a cast warning and an initialization fix for nouveau, a bridge handling fix for meson, an initialisation fix for ivpu, a SPARC build

Re: [PATCH 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

2024-02-22 Thread Ville Syrjälä
On Thu, Feb 22, 2024 at 06:06:11PM +0100, Cezary Rojewski wrote: > Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends > removed support for i915 for all CNL-based platforms. HDAudio library, > however, still treats such platforms as valid candidates for i915 > binding. Update

Re: [PATCH v1 0/6] LNL display

2024-02-22 Thread Govindapillai, Vinod
Hi. On Thu, 2024-02-22 at 13:04 -0300, Gustavo Sousa wrote: > Hi, guys. > > (This is a re-send, because I *think* my MUA badly formed the address to > the mailing list.) > > Quoting Govindapillai, Vinod (2024-02-22 11:39:32-03:00) > > Hi, > > > > Well.. sorry.. I didn't know Gustavo is

[PATCH 4/4] ALSA: hda: Reuse for_each_pcm_streams()

2024-02-22 Thread Cezary Rojewski
Use the macro to improve readability. Signed-off-by: Cezary Rojewski --- sound/pci/hda/hda_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 12f02cdc9659..2cac337f5263 100644 --- a/sound/pci/hda/hda_codec.c

[PATCH 2/4] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing

2024-02-22 Thread Cezary Rojewski
If i915 does not support given platform but the hardware i.e.: HDAudio codec is still there, the codec-probing procedure will succeed for such device but the follow up initialization will always end up with -ENODEV. While bus could filter out address '2' which Intel's HDMI/DP codecs always

[PATCH 3/4] ASoC: codecs: hda: Cleanup error messages

2024-02-22 Thread Cezary Rojewski
Be cohesive and use same pattern in each error message. Signed-off-by: Cezary Rojewski --- sound/soc/codecs/hda.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/hda.c b/sound/soc/codecs/hda.c index d9e7cd8aada2..8a9d0674555e 100644 ---

[PATCH 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

2024-02-22 Thread Cezary Rojewski
Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends removed support for i915 for all CNL-based platforms. HDAudio library, however, still treats such platforms as valid candidates for i915 binding. Update query mechanism to reflect changes made in drm tree. At the same time,

[PATCH 0/4] ALSA/ASoC: Conditionally skip i915 init and cleanups

2024-02-22 Thread Cezary Rojewski
A small set of changes to improve initialization of the audio stack on HDAudio devices and pair of cleanups. While I did touch i915_pciids.h header which is part of drm, I'd like the changes to go through Mark's tree entirely - being cohesive with the rest of the code by adding LKF IDs where they

Re: Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-22 Thread Lucas De Marchi
On Thu, Feb 22, 2024 at 06:51:52AM -0800, Yury Norov wrote: On Mon, Feb 19, 2024 at 11:13:57PM -0600, Lucas De Marchi wrote: On Fri, Feb 09, 2024 at 08:53:25AM -0800, Yury Norov wrote: > On Wed, Feb 07, 2024 at 11:45:20PM -0800, Lucas De Marchi wrote: > > Implement fixed-type BIT() to help

Re: [PATCH v1 0/6] LNL display

2024-02-22 Thread Gustavo Sousa
Hi, guys. (This is a re-send, because I *think* my MUA badly formed the address to the mailing list.) Quoting Govindapillai, Vinod (2024-02-22 11:39:32-03:00) >Hi, > >Well.. sorry.. I didn't know Gustavo is already working on this! >@Gustavo, pls ignore this series if you are arealdy working on

Re: [PATCH] drm/i915/guc: Add Compute context hint

2024-02-22 Thread Tvrtko Ursulin
On 21/02/2024 21:28, Rodrigo Vivi wrote: On Wed, Feb 21, 2024 at 09:42:34AM +, Tvrtko Ursulin wrote: On 21/02/2024 00:14, Vinay Belgaumkar wrote: Allow user to provide a context hint. When this is set, KMD will send a hint to GuC which results in special handling for this context. SLPC

Re: Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2024 at 06:49:59AM -0800, Yury Norov wrote: > On Wed, Feb 21, 2024 at 03:59:06PM -0600, Lucas De Marchi wrote: ... > +#define __GENMASK(t, h, l) \ > + ((~0 - (1 << (l)) + 1) & (~0 >> (BITS_PER_LONG - 1 - (h What's wrong on using the UL/ULL() macros? Also it would be

Re: [PATCH v1 0/6] LNL display

2024-02-22 Thread Govindapillai, Vinod
Hi, Well.. sorry.. I didn't know Gustavo is already working on this! @Gustavo, pls ignore this series if you are arealdy working on this. Please let me know On Thu, 2024-02-22 at 08:02 -0600, Lucas De Marchi wrote: > +Gustavo as he was looking at upstreaming these patches. > > Were the issues

Re: [PATCH v1 5/6] drm/i915/xe2lpd: Load DMC

2024-02-22 Thread Lucas De Marchi
On Thu, Feb 22, 2024 at 02:56:33PM +0200, Vinod Govindapillai wrote: From: Balasubramani Vivekanandan Load DMC for XE2LPD. The value 0x8000 is the maximum payload size for any xe2lpd dmc firmware. Signed-off-by: Balasubramani Vivekanandan Signed-off-by: Dnyaneshwar Bhadane ---

Re: [PATCH v1 0/6] LNL display

2024-02-22 Thread Lucas De Marchi
+Gustavo as he was looking at upstreaming these patches. Were the issues with mdclk handling pointed out at latest attempt fixed? From the changelog it doesn't seem so. https://lore.kernel.org/all/20230908224303.gx2706...@mdroper-desk1.amr.corp.intel.com/ and also worth taking a look at

RE: linux-next: build failure after merge of the drm-misc tree

2024-02-22 Thread Biju Das
Hi Geert, Thanks for the feedback. > -Original Message- > From: Geert Uytterhoeven > Sent: Thursday, February 22, 2024 8:29 AM > Subject: Re: linux-next: build failure after merge of the drm-misc tree > > Hi Biju, > > On Thu, Feb 22, 2024 at 9:14 AM Biju Das > wrote: > > >

RE: linux-next: build failure after merge of the drm-misc tree

2024-02-22 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Thursday, February 22, 2024 8:32 AM > To: Biju Das > Subject: Re: linux-next: build failure after merge of the drm-misc tree > > Hi Biju, > > On Thu, Feb 22, 2024 at 08:14:14AM +, Biju Das wrote: > > >

[PATCH 2/3] sna: use GCPtr instead of GC *

2024-02-22 Thread Enrico Weigelt, metux IT consult
Xserver includes have explicit pointer types for quite all kind of structs (at least those used by drivers), which are used all over the Xserver. Thus it's much cleaner to use those everywhere. This commit also clears the road to fix a horrible nightmare of hacks just needed to circumvent naming

[PATCH 1/3] sna: stop using obsolete type aliases

2024-02-22 Thread Enrico Weigelt, metux IT consult
The Xserver has been moved to using pixman for all matrix operations, back in 2008, but left some #define's so drivers still compile. Since 1.5 decades have passed now, it's time to fix remaining drivers still using the old name, so we can drop these #define's from the Xserver includes.

misc fixes for xf86-video-drive

2024-02-22 Thread Enrico Weigelt, metux IT consult
Hello folks, here's a small queue of pretty trivial fixes / cleanups. * sna: stop using obsolete type aliases * sna: use GCPtr instead of GC * * backlight: use system() instead of System() have fun, --mtx

[PATCH 3/3] backlight: use system() instead of System()

2024-02-22 Thread Enrico Weigelt, metux IT consult
The Xserver's System() function is a special wrapper for calling a program (xkbcomp) as an unprivileged user, when the Xserver is running as suid-root. (which today only needed on a few platforms, eg. Solaris). Therefore it's not suited for being called by arbitrary drivers. In this specific

RE: linux-next: build failure after merge of the drm-misc tree

2024-02-22 Thread Biju Das
Hi All, > -Original Message- > From: Stephen Rothwell > Sent: Thursday, February 22, 2024 1:46 AM > Subject: linux-next: build failure after merge of the drm-misc tree > > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: >

PR for MTL DMC v2.21

2024-02-22 Thread Gustavo Sousa
The following changes since commit 97b693d243f0bb464819fa3f8326edd4091032e4: Merge branch 'mediatek' into 'main' (2024-02-20 15:13:01 +) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware mtl_dmc_2.21 for you to fetch changes up to

[PULL] drm-misc-next

2024-02-22 Thread Thomas Zimmermann
Hi Dave, Sima, this is the weekly PR for drm-misc-next. It's the usual set of fixes and driver updates. Statistics computation for shared GEM BOs has been updated to take imported DMA bufs into account. This can result in different output from fdinfo files, which could be seen as a UAPI change.

[PATCH] drm/i915/mtl: Update workaround 14018778641

2024-02-22 Thread Tejas Upadhyay
Applying WA 14018778641 only on Compute engine has impact on some apps like chrome. Updating this WA to apply on Render engine as well as it is helping with performance on Chrome. Note: There is no concern from media team thus not applying WA on media engines. We will revisit if any issues

Re: [PATCH v7 3/3] drm/buddy: Add defragmentation support

2024-02-22 Thread Arunpravin Paneer Selvam
Hi Christian, On 2/21/2024 7:58 PM, Christian König wrote: Am 21.02.24 um 13:18 schrieb Arunpravin Paneer Selvam: Add a function to support defragmentation. Thinking more about it maybe you want to call this function differently. Essentially we are force merging pages even if their cleared

[PATCH v1 6/6] drm/xe/lnl: Enable the display support

2024-02-22 Thread Vinod Govindapillai
From: Balasubramani Vivekanandan Enable the display support for LUNARLAKE Signed-off-by: Balasubramani Vivekanandan Signed-off-by: Lucas De Marchi Reviewed-by: Matt Roper --- drivers/gpu/drm/xe/xe_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/xe_pci.c

[PATCH v1 5/6] drm/i915/xe2lpd: Load DMC

2024-02-22 Thread Vinod Govindapillai
From: Balasubramani Vivekanandan Load DMC for XE2LPD. The value 0x8000 is the maximum payload size for any xe2lpd dmc firmware. Signed-off-by: Balasubramani Vivekanandan Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_dmc.c | 9 - 1 file changed, 8

[PATCH v1 4/6] drm/i915/xe2lpd: Update mbus on post plane updates

2024-02-22 Thread Vinod Govindapillai
From: Stanislav Lisovskiy According to BSpec we need to write the MBUS CTL and DBUF CTL both for increasing CDCLK case (pre plane) and for decreasing CDCLK case (post plane). Make sure those updates are in place for Xe2-LPD. Since the mbus update is not only on pre-enable anymore, also rename

[PATCH v1 2/6] drm/i915/lnl: Add programming for CDCLK change

2024-02-22 Thread Vinod Govindapillai
From: Ravi Kumar Vodapalli Add programming sequence for changes on CDCLK for Lunar Lake platforms. It's mostly the same as MTL, but with some additional programming for the squash and crawling steps when a change in mdclk/cdclk ratio is observed. v2: Remove wrong changes for

[PATCH v1 3/6] drm/i915/xe2lpd: Write DBuf after CDCLK change in post plane

2024-02-22 Thread Vinod Govindapillai
From: Stanislav Lisovskiy Previously we always updated DBuf MBUS CTL and DBUF CTL regs after CDCLK has been changed(CDCLK_CTL), however for Xe2-LPD we can't do like that anymore. According to BSpec, we have to first update DBuf regs and then write CDCLK regs, when CDCLK is decreased, which we do

[PATCH v1 1/6] drm/i915/lnl: Introduce MDCLK_CDCLK ratio to DBuf

2024-02-22 Thread Vinod Govindapillai
From: Stanislav Lisovskiy When we change MDCLK/CDCLK the BSpec now instructs us to write a ratio between MDCLK/CDCLK to MBUS CTL and DBUF CTL registers during that change. Previsouly DBuf state and CDCLK were not anyhow coupled together. Now at compute stage when we know which CDCLK/MDCLK we

[PATCH v1 0/6] LNL display

2024-02-22 Thread Vinod Govindapillai
Rest of the cdclk patches as well as the patches to enable the display in LNL Balasubramani Vivekanandan (2): drm/i915/xe2lpd: Load DMC drm/xe/lnl: Enable the display support Ravi Kumar Vodapalli (1): drm/i915/lnl: Add programming for CDCLK change Stanislav Lisovskiy (3): drm/i915/lnl:

[PATCH 2/6] drm: Add Adaptive Sync SDP logging

2024-02-22 Thread Mitul Golani
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - use as_sdp instead of async [Ankit] - Correct define placeholders to where it is being actually used.

[PATCH 6/6] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-22 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c| 5 + drivers/gpu/drm/i915/display/intel_display_device.h | 1 +

[PATCH 5/6] drm/i915/display: Compute vrr_vsync params

2024-02-22 Thread Mitul Golani
Compute vrr_vsync_start/end which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Update, VSYNC_START/END macros to VRR_VSYNC_START/END.(Ankit) - Update bit fields of VRR_VSYNC_START/END.(Ankit) Signed-off-by: Mitul Golani ---

[PATCH 3/6] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-22 Thread Mitul Golani
Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] - Remove unrelated comments and changes. [Jani]

[PATCH 4/6] drm/i915/display: Compute AS SDP parameters.

2024-02-22 Thread Mitul Golani
Add necessary functions definitions to enable and compute AS SDP data. The new `intel_dp_compute_as_sdp` function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Add DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx().[Ankit]

[PATCH 1/6] drm/dp: Add an support to indicate if sink supports AS SDP

2024-02-22 Thread Mitul Golani
Add an API which indicates the sink support Adaptive Sync SDP, which can be used by the rest of the DP programming. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display/drm_dp_helper.h | 2 ++ 2 files changed, 27

[PATCH 0/6] Enable Adaptive Sync SDP Support for DP

2024-02-22 Thread Mitul Golani
An Adaptive Sync SDP allows a DP protocol converter to forward Adaptive Sync video with minimal buffering overhead within the converter. An Adaptive-Sync-capable DP protocol converter indicates its support by setting the related bit in the DPCD register. Computes AS SDP values based on the

[PATCH v2 5/5] drm/i915/display: Increase number of fast wake precharge pulses

2024-02-22 Thread Jouni Högander
Increasing number of fast wake sync pulses seem to fix problems with certain PSR panels. This should be ok for other panels as well as the eDP specification allows 10...16 precharge pulses and we are still within that range. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9739

[PATCH v2 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond

2024-02-22 Thread Jouni Högander
IO buffer wake time used for IO wake calculation is dependent on port clock on LunarLake and beyond. Take this into account in get_io_buffer_wake_time. Bspec: 65450 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 9 - 1 file changed, 8 insertions(+), 1

[PATCH v2 3/5] drm/i915/psr: Calculate IO wake and fast wake lines for DISPLAY_VER < 12

2024-02-22 Thread Jouni Högander
Bspec mentions 50 us for IO wake time and 32 us for fast wake time. 32 us is most probably wrong as it doesn't meet the specification as fast wake time is calculated in Bspec like this: 10..16 us (precharge) + 8 us (preamble) + 4 us (phy_wake) + 20 us (tfw_exit_latency) Instead of using these

[PATCH v2 2/5] drm/i915/psr: Improve fast and IO wake lines calculation

2024-02-22 Thread Jouni Högander
Current fast and IO wake lines calculation is assuming fast wake sync length is 18 pulses. Let's improve this by checking actual length. Add getter for IO buffer wake time and return 10 us there which was assumed with static 42 us IO wake time. Upcoming patches will extent this for different

[PATCH v2 1/5] drm/i915/display: Make intel_dp_aux_fw_sync_len available for PSR code

2024-02-22 Thread Jouni Högander
ALPM AUX-Wake fast wake sync pulse count is needed by PSR to calculate IO wake and fast wake lines. Convert intel_dp_aux_fw_sync_len as non-static to make it available for PSR code. u8 is enough for fw sync pulse length. Signed-off-by: Jouni Högander ---

[PATCH v2 0/5] IO and fast wake lines calculation and increase fw sync length

2024-02-22 Thread Jouni Högander
This patch set is improving IO and fast wake lines calculation in PSR code: Use actual fast wake sync pulse count in calculation Implement getter for IO buffer wake times and use that. Better presentation on how these are calculated. Use calculation for display version < 12 as well. Also number

[PATCH] drm/i915/selftests: Fix dependency of some timeouts on HZ

2024-02-22 Thread Janusz Krzysztofik
Third argument of i915_request_wait() accepts a timeout value in jiffies. Most users pass either a simple HZ based expression, or a result of msecs_to_jiffies(), or MAX_SCHEDULE_TIMEOUT, or a very small number not exceeding 4 if applicable as that value. However, there is one user --

[PULL] drm-intel-fixes

2024-02-22 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-fixes for v6.8-rc6. Just a single fixup patch for TV mode. Best Regards, Joonas *** drm-intel-fixes-2024-02-22: - Fixup for TV mode The following changes since commit b401b621758e46812da61fa58a67c3fd8d91de0d: Linux 6.8-rc5 (2024-02-18 12:56:25 -0800)

[PULL] drm-xe-fixes

2024-02-22 Thread Thomas Hellstrom
Hi, Dave Sima The Xe pull request for 6.8-rc6 The uAPI fixes / adjustments we've been discussing are starting to appear, and I will hopefully have the rest for next week's PR. In addition two driver fixes. drm-xe-fixes-2024-02-22: UAPI Changes: - Remove support for persistent exec_queues - Drop

✓ Fi.CI.BAT: success for HDCP MST Type1 fixes (rev4)

2024-02-22 Thread Patchwork
== Series Details == Series: HDCP MST Type1 fixes (rev4) URL : https://patchwork.freedesktop.org/series/129925/ State : success == Summary == CI Bug Log - changes from CI_DRM_14314 -> Patchwork_129925v4 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for HDCP MST Type1 fixes (rev4)

2024-02-22 Thread Patchwork
== Series Details == Series: HDCP MST Type1 fixes (rev4) URL : https://patchwork.freedesktop.org/series/129925/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

  1   2   >