Re: [PATCH v4 0/4] TTM unlockable restartable LRU list iteration

2024-03-07 Thread Somalapuram, Amaranath
Patches are tested on AMD platform. Repeated stress test on Unigine Heaven, memory full (VRAM + GTT + system SWAP), then free. No errors/warning in kernel log. Any suggestion specific tests? Regards, S.Amarnath On 3/6/2024 12:31 PM, Thomas Hellström wrote: This patch-set is a prerequisite for

[PATCH] drm/i915: Rename ICL_PORT_TX_DW6 bits

2024-03-07 Thread Ville Syrjala
From: Ville Syrjälä Our definitions for bit 7 and bit 0 of ICL_PORT_TX_DW6 are swapped. Functionally it doesn't matter as we always set both bits, but let's rename the bits to match bspec 100%. And while at it, add the definition for bits 1-6 as well, just to have it all fully documented.

Re: [PATCH 0/3] drm/i915: Make crtc disable more atomic

2024-03-07 Thread Ville Syrjälä
On Tue, Mar 05, 2024 at 10:47:27AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Make the crtc disable more atomic (in terms of plane disable). > > And also also track which pipes need disabling in the same way > as skl_commit_modeset_enables(), which should make the whole > thing bit

Re: [PATCH v16 9/9] drm/i915/display: Read/Write Adaptive Sync SDP

2024-03-07 Thread Nautiyal, Ankit K
On 3/7/2024 11:23 AM, Mitul Golani wrote: Add read/write calls for Adaptive Sync SDP. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [PATCH v16 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-07 Thread Nautiyal, Ankit K
On 3/7/2024 11:23 AM, Mitul Golani wrote: Compute vrr_vsync_start/end, which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit) - Updated bit fields of

Re: [PATCH v16 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-03-07 Thread Nautiyal, Ankit K
On 3/7/2024 11:23 AM, Mitul Golani wrote: Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] -

✓ Fi.CI.BAT: success for drm/i915/guc: Update w/a 14019159160

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update w/a 14019159160 URL : https://patchwork.freedesktop.org/series/130890/ State : success == Summary == CI Bug Log - changes from CI_DRM_14407 -> Patchwork_130890v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915/guc: Update w/a 14019159160

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update w/a 14019159160 URL : https://patchwork.freedesktop.org/series/130890/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Update w/a 14019159160

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update w/a 14019159160 URL : https://patchwork.freedesktop.org/series/130890/ State : warning == Summary == Error: dim checkpatch failed 3d8264155c79 drm/i915/guc: Update w/a 14019159160 -:20: WARNING:LONG_LINE_COMMENT: line length of 108 exceeds 100

[PATCH] drm/i915/guc: Update w/a 14019159160

2024-03-07 Thread John . C . Harrison
From: John Harrison An existing workaround has been extended in both platforms affected and implementation complexity. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 3 ++- drivers/gpu/drm/i915/gt/uc/intel_guc.c| 3 ++-

Re: [PATCH v4 1/3] drm/i915/gt: Disable HW load balancing for CCS

2024-03-07 Thread Andi Shyti
Hi John, ... > > > > + > > > > + /* > > > > +* Wa_14019159160: disable the automatic CCS load > > > > balancing > > > I'm still a bit concerned that this doesn't really match what this > > > specific workaround is asking us to do. There seems to be an agreement >

Re: [PATCH v4 3/3] drm/i915/gt: Enable only one CCS for compute workload

2024-03-07 Thread Andi Shyti
Hi Matt, > > +static void intel_gt_apply_ccs_mode(struct intel_gt *gt) > > +{ > > + u32 mode; > > + int cslice; > > + > > + if (!IS_DG2(gt->i915)) > > + return; > > + > > + /* Set '0' as a default CCS id to all the cslices */ > > + mode = 0; > > + > > + for (cslice = 0;

✓ Fi.CI.BAT: success for drm: debug logging improvements

2024-03-07 Thread Patchwork
== Series Details == Series: drm: debug logging improvements URL : https://patchwork.freedesktop.org/series/130881/ State : success == Summary == CI Bug Log - changes from CI_DRM_14406 -> Patchwork_130881v1 Summary --- **SUCCESS**

✗ Fi.CI.SPARSE: warning for drm: debug logging improvements

2024-03-07 Thread Patchwork
== Series Details == Series: drm: debug logging improvements URL : https://patchwork.freedesktop.org/series/130881/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm: debug logging improvements

2024-03-07 Thread Patchwork
== Series Details == Series: drm: debug logging improvements URL : https://patchwork.freedesktop.org/series/130881/ State : warning == Summary == Error: dim checkpatch failed f26d79b2e37e drm/modes: add drm_mode_print() to dump mode in drm_printer f62d2d0fd5bd drm/probe-helper: switch to drm

✓ Fi.CI.BAT: success for drm/i915: Fix VMA UAF on destroy against deactivate race (rev7)

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev7) URL : https://patchwork.freedesktop.org/series/129026/ State : success == Summary == CI Bug Log - changes from CI_DRM_14406 -> Patchwork_129026v7

✗ Fi.CI.SPARSE: warning for drm/i915: Fix VMA UAF on destroy against deactivate race (rev7)

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev7) URL : https://patchwork.freedesktop.org/series/129026/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/i915: Use container_of_const()

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Use container_of_const() URL : https://patchwork.freedesktop.org/series/130868/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14406 -> Patchwork_130868v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915: Use container_of_const()

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Use container_of_const() URL : https://patchwork.freedesktop.org/series/130868/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-03-07 Thread Lucas De Marchi
On Thu, Feb 29, 2024 at 10:06:02PM -0600, Lucas De Marchi wrote: On Thu, Feb 29, 2024 at 08:27:30PM +0200, Andy Shevchenko wrote: On Thu, Feb 29, 2024 at 12:21:34PM -0600, Lucas De Marchi wrote: On Thu, Feb 29, 2024 at 12:49:57PM +0200, Andy Shevchenko wrote: On Wed, Feb 28, 2024 at

RE: [PATCH i-g-t v2 0/2] lib/kunit: Execute test cases synchronously

2024-03-07 Thread Cavitt, Jonathan
All patches LGTM Acked-by: Jonathan Cavitt -Jonathan Cavitt -Original Message- From: Intel-gfx On Behalf Of Janusz Krzysztofik Sent: Tuesday, February 27, 2024 7:11 AM To: igt-...@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org; Kamil

Re: [PATCH 17/22] drm/i915/pxp: fix i915_pxp_tee_interface.h kernel-doc warnings

2024-03-07 Thread Jani Nikula
On Thu, 07 Mar 2024, Lucas De Marchi wrote: > On Wed, Mar 06, 2024 at 08:31:22PM +0200, Jani Nikula wrote: >>Make documentation match code. >> >>Signed-off-by: Jani Nikula >>--- >> include/drm/i915_pxp_tee_interface.h | 19 --- >> 1 file changed, 12 insertions(+), 7 deletions(-)

Re: [PATCH 6/6] drm/client: switch to drm device based logging, and more

2024-03-07 Thread Jani Nikula
On Thu, 07 Mar 2024, Jani Nikula wrote: > Switch to drm device based logging and WARNs, and unify connector and > crtc logging formats. Pass drm device around a bit more to be able to do > this. Forgot to mention that I also stop logging about -ENOMEM, instead of converting that over to drm

Re: [PATCH 5/6] drm/sysfs: switch to drm device based logging

2024-03-07 Thread Jani Nikula
On Thu, 07 Mar 2024, Jani Nikula wrote: > @@ -489,7 +489,6 @@ void drm_sysfs_connector_hotplug_event(struct > drm_connector *connector) > drm_dbg_kms(connector->dev, > "[CONNECTOR:%d:%s] generating connector hotplug event\n", > connector->base.id,

[PATCH 6/6] drm/client: switch to drm device based logging, and more

2024-03-07 Thread Jani Nikula
Switch to drm device based logging and WARNs, and unify connector and crtc logging formats. Pass drm device around a bit more to be able to do this. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_client_modeset.c | 129 +++ 1 file changed, 70 insertions(+), 59

[PATCH 4/6] drm/modes: switch to drm device based error logging

2024-03-07 Thread Jani Nikula
Prefer drm_err() over DRM_ERROR(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_modes.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 0fff5a8d4d81..bf0f745dd9bd 100644 ---

[PATCH 5/6] drm/sysfs: switch to drm device based logging

2024-03-07 Thread Jani Nikula
Prefer drm_dbg_kms() and drm_dbg_lease() over DRM_DEBUG_KMS() and DRM_DEBUG() to debug log the drm device info. Fix some debug categories and unify connector logging while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_sysfs.c | 21 ++--- 1 file changed, 10

[PATCH 3/6] drm/modes: switch drm_mode_prune_invalid() to use struct drm_printer

2024-03-07 Thread Jani Nikula
Use device based debug logging for the mode via drm_printer. This changes the output from the format: [drm:drm_mode_debug_printmodeline] Modeline "6144x3456": 60 1378800 6144 6192 6224 6464 3456 3459 3464 3555 0x48 0x9 [drm:drm_mode_prune_invalid] Not using 6144x3456 mode: CLOCK_HIGH to

[PATCH 2/6] drm/probe-helper: switch to drm device based logging

2024-03-07 Thread Jani Nikula
Prefer drm_dbg_kms() over DRM_DEBUG_KMS() to debug log the drm device info. Also use drm_mode_print() for drm device specific debug logging the probed modes. This changes the probed modes output from the format: [drm:drm_helper_probe_single_connector_modes] [CONNECTOR:290:DP-5] probed modes :

[PATCH 1/6] drm/modes: add drm_mode_print() to dump mode in drm_printer

2024-03-07 Thread Jani Nikula
Add a printer based function for dumping the modeline, so it's not limited to KMS debug. Note: The printed output intentionally does not have the "Modeline" prefix. Prefix, if any, is for the caller to decide when initializing drm_printer. Signed-off-by: Jani Nikula ---

[PATCH 0/6] drm: debug logging improvements

2024-03-07 Thread Jani Nikula
Switch a handful of places over to drm device based logging and WARNs, unify connector and crtc logging, etc. Jani Nikula (6): drm/modes: add drm_mode_print() to dump mode in drm_printer drm/probe-helper: switch to drm device based logging drm/modes: switch drm_mode_prune_invalid() to use

Re: [PATCH v4 1/3] drm/i915/gt: Disable HW load balancing for CCS

2024-03-07 Thread John Harrison
On 3/7/2024 12:02, Andi Shyti wrote: Hi Matt, On Wed, Mar 06, 2024 at 03:46:09PM -0800, Matt Roper wrote: On Wed, Mar 06, 2024 at 02:22:45AM +0100, Andi Shyti wrote: The hardware should not dynamically balance the load between CCS engines. Wa_14019159160 recommends disabling it across all

Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-07 Thread Imre Deak
On Thu, Mar 07, 2024 at 09:46:22AM -0500, Rodrigo Vivi wrote: > On Thu, Mar 07, 2024 at 02:30:46AM +0200, Ville Syrjälä wrote: > > On Wed, Mar 06, 2024 at 07:15:45PM -0500, Rodrigo Vivi wrote: > > > This patch brings no functional change. Since at this point of > > > the code we are already

Re: [PATCH v4 1/3] drm/i915/gt: Disable HW load balancing for CCS

2024-03-07 Thread Andi Shyti
Hi Matt, On Wed, Mar 06, 2024 at 03:46:09PM -0800, Matt Roper wrote: > On Wed, Mar 06, 2024 at 02:22:45AM +0100, Andi Shyti wrote: > > The hardware should not dynamically balance the load between CCS > > engines. Wa_14019159160 recommends disabling it across all > > platforms. > > > > Fixes:

✗ Fi.CI.IGT: failure for drm/i915/dp: Enable AUX based backlight for HDR (rev3)

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915/dp: Enable AUX based backlight for HDR (rev3) URL : https://patchwork.freedesktop.org/series/130729/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14402_full -> Patchwork_130729v3_full

Re: [PATCH 1/1] drm/i915: Allow bigjoiner for MST

2024-03-07 Thread Manasi Navare
Thanks Vidya for the v3, this LGTM, Reviewed-by: Manasi Navare Manasi On Wed, Mar 6, 2024 at 9:31 PM Vidya Srinivas wrote: > > We need bigjoiner support with MST functionality > for MST monitor resolutions > 5K to work. > Adding support for the same. > > v2: Addressed review comments from

Re: [PATCH v4] drm/i915/dp: Increase idle pattern wait timeout to 2ms

2024-03-07 Thread Gustavo Sousa
Quoting Shekhar Chauhan (2024-03-05 00:58:00-03:00) >The driver currently waits 1ms for idle patterns, >but for LNL and later platforms, it requires a I would say "for Xe2LPD and possibly future display IPs, it requires". I feel the requirement is not necessarily tied to the platform itself.

Re: [PATCH 17/22] drm/i915/pxp: fix i915_pxp_tee_interface.h kernel-doc warnings

2024-03-07 Thread Lucas De Marchi
On Wed, Mar 06, 2024 at 08:31:22PM +0200, Jani Nikula wrote: Make documentation match code. Signed-off-by: Jani Nikula --- include/drm/i915_pxp_tee_interface.h | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/include/drm/i915_pxp_tee_interface.h

Re: [PATCH 16/22] drm/i915/hdcp: fix i915_hdcp_interface.h kernel-doc warnings

2024-03-07 Thread Lucas De Marchi
On Wed, Mar 06, 2024 at 08:31:21PM +0200, Jani Nikula wrote: Make the documentation match code. Signed-off-by: Jani Nikula --- include/drm/i915_hdcp_interface.h | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/include/drm/i915_hdcp_interface.h

Re: [PATCH 3/4] drm/i915: Use pw_idx to derive PHY for ICL_LANE_ENABLE_AUX override

2024-03-07 Thread Ville Syrjälä
On Tue, Mar 05, 2024 at 05:14:54PM +0200, Imre Deak wrote: > On Thu, Feb 29, 2024 at 10:03:56PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We don't actually know whether we should be picking the PHY > > simply based on the AUX_CH/power well, or based on the VBT > > defined

Re: [PATCH 15/22] drm/i915: fix i915_gsc_proxy_mei_interface.h kernel-doc

2024-03-07 Thread Lucas De Marchi
On Wed, Mar 06, 2024 at 08:31:20PM +0200, Jani Nikula wrote: There's no proper way to document function pointer members, but at least silence the warnings. Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [PATCH i-g-t v2 1/2] lib/kunit: Execute test cases synchronously

2024-03-07 Thread Kamil Konieczny
Hi Janusz, On 2024-02-27 at 16:10:41 +0100, Janusz Krzysztofik wrote: > Up to now we were loading a KUnit test module in test execution mode only > once per subtest, in background, and then, in parallel with execution of > test cases while the module was loading, we were looking through dmesg for

Re: [PATCH i-g-t v2 2/2] lib/kunit: Minimize code duplication

2024-03-07 Thread Kamil Konieczny
Hi Janusz, On 2024-02-27 at 16:10:42 +0100, Janusz Krzysztofik wrote: > A new helper has been introduced recently, used for fetching KTAP results > of a single test case. Since that helper is called for that purpose > only after the test module is loaded with all other test cases filtered > out,

Re: [PATCH v4 3/5] drm/i915/psr: Calculate IO wake and fast wake lines for DISPLAY_VER < 12

2024-03-07 Thread Ville Syrjälä
On Wed, Mar 06, 2024 at 10:34:25AM +0200, Jouni Högander wrote: > Bspec mentions 50 us for IO wake time and 32 us for fast wake time. 32 us > is most probably wrong as it doesn't meet the specification as fast wake > time is calculated in Bspec like this: > > 10..16 us (precharge) + 8 us

Re: [PATCH v4 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond

2024-03-07 Thread Ville Syrjälä
On Wed, Mar 06, 2024 at 10:34:26AM +0200, Jouni Högander wrote: > IO buffer wake time used for IO wake calculation is dependent on port clock > on LunarLake and beyond. Take this into account in get_io_buffer_wake_time. > > Bspec: 65450 > > Signed-off-by: Jouni Högander > --- >

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-07 Thread Matthew Auld
On 07/03/2024 12:25, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 3/6/2024 11:19 PM, Matthew Auld wrote: On 04/03/2024 16:32, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the

Re: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-07 Thread Jani Nikula
On Thu, 07 Mar 2024, Geert Uytterhoeven wrote: > Hi Jani, > > On Thu, Mar 7, 2024 at 9:44 AM Jani Nikula wrote: >> On Thu, 07 Mar 2024, kernel test robot wrote: >> > kernel test robot noticed the following build errors: >> >> So I'm trying to make include/drm/ttm/ttm_caching.h self-contained by

Re: [PATCH 00/22] drm: fix headers, add header test facility

2024-03-07 Thread Jani Nikula
On Thu, 07 Mar 2024, Thomas Zimmermann wrote: > Hi > > Am 06.03.24 um 19:31 schrieb Jani Nikula: >> First, fix a bunch of issues in drm headers, uncovered with the last >> patch. A few kernel-doc warnings are just brushed under the carpet for >> now, with a FIXME comment. Otherwise, pretty

[PATCH 4/4] drm/i915: Drop pointless (void*) cast

2024-03-07 Thread Ville Syrjala
From: Ville Syrjälä Remove the pointless (void*) cast, the incoming pointer is already the correct type. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c

[PATCH 3/4] drm/i915: Use container_of_const() for states

2024-03-07 Thread Ville Syrjala
From: Ville Syrjälä commit 64f6a5d1922b ("container_of: add container_of_const() that preserves const-ness of the pointer") is nice. Let's use it so that we don't accidentally cast away the const from our state pointers. The only thing I don't particularly like about container_of_const() is

[PATCH 2/4] drm/i915: Don't cast away const

2024-03-07 Thread Ville Syrjala
From: Ville Syrjälä The connector state passed to .atomic_get_property() is const. We should preserve that when downcasting to our version. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/4] drm/i915/dsi: Use enc_to_intel_dsi()

2024-03-07 Thread Ville Syrjala
From: Ville Syrjälä Use enc_to_intel_dsi() instead hand rolling it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 3 +-- drivers/gpu/drm/i915/display/vlv_dsi.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 0/4] drm/i915: Use container_of_const()

2024-03-07 Thread Ville Syrjala
From: Ville Syrjälä Start using container_of_const() for some extra const safety. Ville Syrjälä (4): drm/i915/dsi: Use enc_to_intel_dsi() drm/i915: Don't cast away const drm/i915: Use container_of_const() for states drm/i915: Drop pointless (void*) cast

[PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-07 Thread Rodrigo Vivi
This patch brings no functional change. Since at this point of the code we are already asserting a wakeref was held, it means that we are with runtime_pm 'in_use' and in practical terms we are only bumping the pm_runtime usage counter and moving on. However, xe driver has a lockdep annotation

Re: [PATCH 04/22] drm/amdgpu: make amd_asic_type.h self-contained

2024-03-07 Thread Jani Nikula
On Thu, 07 Mar 2024, Alex Deucher wrote: > On Wed, Mar 6, 2024 at 1:43 PM Jani Nikula wrote: >> >> Include for u8. >> >> Signed-off-by: Jani Nikula > > Acked-by: Alex Deucher > > Do you want me to pick this up? Otherwise, feel free to take it via > whatever tree makes sense. Thanks, I'd like

Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-07 Thread Rodrigo Vivi
On Thu, Mar 07, 2024 at 02:30:46AM +0200, Ville Syrjälä wrote: > On Wed, Mar 06, 2024 at 07:15:45PM -0500, Rodrigo Vivi wrote: > > This patch brings no functional change. Since at this point of > > the code we are already asserting a wakeref was held, it means > > that we are with runtime_pm

Re: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-07 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240307] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH 04/22] drm/amdgpu: make amd_asic_type.h self-contained

2024-03-07 Thread Alex Deucher
On Wed, Mar 6, 2024 at 1:43 PM Jani Nikula wrote: > > Include for u8. > > Signed-off-by: Jani Nikula Acked-by: Alex Deucher Do you want me to pick this up? Otherwise, feel free to take it via whatever tree makes sense. Alex > --- > include/drm/amd_asic_type.h | 3 +++ > 1 file changed, 3

Re: [PATCH v3] drm/ci: update device type for volteer devices

2024-03-07 Thread Helen Koike
On 07/03/2024 10:21, Helen Koike wrote: On 06/03/2024 23:18, Vignesh Raman wrote: Volteer devices in the collabora lab are categorized under the asus-cx9400-volteer device type. The majority of these units has an Intel Core i5-1130G7 CPU, while some of them have a Intel Core i7-1160G7 CPU

Re: [V2 1/2] drm/i915/drrs: Refactor CPU transcoder DRRS check

2024-03-07 Thread Jani Nikula
On Wed, 28 Feb 2024, Bhanuprakash Modem wrote: > Rename cpu_transcoder_has_drrs() to intel_cpu_transcoder_has_drrs() > and make it as non-static, therefore it can be re-used. > > V2: > - Move helpers to intel_drrs.[ch] (Jani) > - Fix commit message (Jani) > > Cc: Jani Nikula > Cc: Ankit

[PULL] drm-misc-next-fixes

2024-03-07 Thread Thomas Zimmermann
Hi Dave, Sima, this is the weekly PR for drm-misc-next-fixes. Best regards Thomas drm-misc-next-fixes-2024-03-07: Short summary of fixes pull: - i915: Fix applying placement flags - fbdev: Fix build on PowerMacs after header cleanup The following changes since commit

Re: [RFC v2 2/4] drm/i915/display: add generic to_intel_display() macro

2024-03-07 Thread Rodrigo Vivi
On Thu, Mar 07, 2024 at 01:28:57PM +0200, Jani Nikula wrote: > On Wed, 06 Mar 2024, Rodrigo Vivi wrote: > > On Wed, Mar 06, 2024 at 02:24:36PM +0200, Jani Nikula wrote: > >> Convert various pointers to struct intel_display * using _Generic(). > >> > >> Add some macro magic to make adding new

Re: [PATCH v3] drm/ci: update device type for volteer devices

2024-03-07 Thread Helen Koike
On 06/03/2024 23:18, Vignesh Raman wrote: Volteer devices in the collabora lab are categorized under the asus-cx9400-volteer device type. The majority of these units has an Intel Core i5-1130G7 CPU, while some of them have a Intel Core i7-1160G7 CPU instead. So due to this difference, new

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-07 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 3/6/2024 11:19 PM, Matthew Auld wrote: On 04/03/2024 16:32, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each

✓ Fi.CI.BAT: success for drm/i915/dp: Enable AUX based backlight for HDR (rev3)

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915/dp: Enable AUX based backlight for HDR (rev3) URL : https://patchwork.freedesktop.org/series/130729/ State : success == Summary == CI Bug Log - changes from CI_DRM_14402 -> Patchwork_130729v3 Summary

Re: [PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-07 Thread Ville Syrjälä
On Thu, Mar 07, 2024 at 05:27:31AM +, Kandpal, Suraj wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: Wednesday, March 6, 2024 5:57 PM > > To: Kandpal, Suraj > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma ; > > Nautiyal, Ankit K > > Subject: Re: [PATCH]

Re: [RFC v2 2/4] drm/i915/display: add generic to_intel_display() macro

2024-03-07 Thread Jani Nikula
On Wed, 06 Mar 2024, Rodrigo Vivi wrote: > On Wed, Mar 06, 2024 at 02:24:36PM +0200, Jani Nikula wrote: >> Convert various pointers to struct intel_display * using _Generic(). >> >> Add some macro magic to make adding new conversions easier, and somewhat >> abstract the need to cast each generic

✓ Fi.CI.BAT: success for Introduce drm sharpening property (rev2)

2024-03-07 Thread Patchwork
== Series Details == Series: Introduce drm sharpening property (rev2) URL : https://patchwork.freedesktop.org/series/129888/ State : success == Summary == CI Bug Log - changes from CI_DRM_14401 -> Patchwork_129888v2 Summary ---

✗ Fi.CI.SPARSE: warning for Introduce drm sharpening property (rev2)

2024-03-07 Thread Patchwork
== Series Details == Series: Introduce drm sharpening property (rev2) URL : https://patchwork.freedesktop.org/series/129888/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Introduce drm sharpening property (rev2)

2024-03-07 Thread Patchwork
== Series Details == Series: Introduce drm sharpening property (rev2) URL : https://patchwork.freedesktop.org/series/129888/ State : warning == Summary == Error: dim checkpatch failed 4fe845215e02 drm: Introduce sharpness mode property 65b8e0c3c5e8 drm/i915/display: Compute the scaler filter

[PULL] drm-xe-fixes

2024-03-07 Thread Thomas Hellstrom
Hi Dave, Sima A single error path fix for 6.8 final (-rc8). Thanks, Thomas drm-xe-fixes-2024-03-07: Driver Changes: - An error path fix. The following changes since commit 90d35da658da8cff0d4ecbb5113f5fac9d00eb72: Linux 6.8-rc7 (2024-03-03 13:02:52 -0800) are available in the Git

[PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-07 Thread Suraj Kandpal
As of now whenerver HDR is switched on we use the PWM to change the backlight as opposed to AUX based backlight changes in terms of nits. This patch writes to the appropriate DPCD registers to enable aux based backlight using values in nits. --v2 -Fix max_cll and max_fall assignment [Jani] -Fix

✓ Fi.CI.BAT: success for drm: add missing header guards to drm_crtc_internal.h (rev2)

2024-03-07 Thread Patchwork
== Series Details == Series: drm: add missing header guards to drm_crtc_internal.h (rev2) URL : https://patchwork.freedesktop.org/series/130822/ State : success == Summary == CI Bug Log - changes from CI_DRM_14401 -> Patchwork_130822v2

✗ Fi.CI.SPARSE: warning for drm: add missing header guards to drm_crtc_internal.h (rev2)

2024-03-07 Thread Patchwork
== Series Details == Series: drm: add missing header guards to drm_crtc_internal.h (rev2) URL : https://patchwork.freedesktop.org/series/130822/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm: add missing header guards to drm_crtc_internal.h (rev2)

2024-03-07 Thread Patchwork
== Series Details == Series: drm: add missing header guards to drm_crtc_internal.h (rev2) URL : https://patchwork.freedesktop.org/series/130822/ State : warning == Summary == Error: dim checkpatch failed 6394cb645816 drm/crtc: make drm_crtc_internal.h self-contained 4cb3460431f8 drm: add

Re: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-07 Thread Geert Uytterhoeven
Hi Jani, On Thu, Mar 7, 2024 at 9:44 AM Jani Nikula wrote: > On Thu, 07 Mar 2024, kernel test robot wrote: > > kernel test robot noticed the following build errors: > > So I'm trying to make include/drm/ttm/ttm_caching.h self-contained by > including with [1], but it fails like below. > > Cc:

✗ Fi.CI.IGT: failure for drm/i915: Unpin cursor fb only after vblank.

2024-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Unpin cursor fb only after vblank. URL : https://patchwork.freedesktop.org/series/130746/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14393_full -> Patchwork_130746v1_full Summary

Re: [PATCH 00/22] drm: fix headers, add header test facility

2024-03-07 Thread Jani Nikula
On Thu, 07 Mar 2024, Thomas Zimmermann wrote: > Hi > > Am 06.03.24 um 19:31 schrieb Jani Nikula: >> First, fix a bunch of issues in drm headers, uncovered with the last >> patch. A few kernel-doc warnings are just brushed under the carpet for >> now, with a FIXME comment. Otherwise, pretty

Re: [PATCH 00/22] drm: fix headers, add header test facility

2024-03-07 Thread Thomas Zimmermann
Hi Am 06.03.24 um 19:31 schrieb Jani Nikula: First, fix a bunch of issues in drm headers, uncovered with the last patch. A few kernel-doc warnings are just brushed under the carpet for now, with a FIXME comment. Otherwise, pretty straightforward stuff. Nice, thanks a lot. For the FIXME

[PULL] drm-misc-fixes

2024-03-07 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-03-07: A connector status polling fix, a timings fix for the Himax83102-j02 panel, a deadlock fix for nouveau, A controversial format fix for udl that got reverted to allow further discussion, and a build fix for the drm/buddy

Re: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-07 Thread Jani Nikula
t-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-crtc-make-drm_crtc_internal-h-self-contained/20240307-023603 > base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next > patch link: > https://lore.kernel.org/r/e22

[PATCH v2 5/5] drm/i915/display: Load the lut values and enable sharpness

2024-03-07 Thread Nemesa Garg
Load the lut values during pipe enable. v2: Add the display version check Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_crtc.c| 3 +++ drivers/gpu/drm/i915/display/intel_display.c | 14 +- drivers/gpu/drm/i915/display/skl_scaler.c| 13 - 3

[PATCH 4/5] drm/i915/display: Add registers and compute the strength

2024-03-07 Thread Nemesa Garg
Add new registers and related bits. Compute the strength value and tap value based on display mode. Signed-off-by: Nemesa Garg --- .../drm/i915/display/intel_display_types.h| 1 + .../drm/i915/display/intel_sharpen_filter.c | 81 +++

[PATCH v2 3/5] drm/i915/display: Enable the second scaler

2024-03-07 Thread Nemesa Garg
The strength value should be greater than zero to set to the scaler flag true and if the second scaler is free then it can be used for sharpening purpose. v2: Modify the condition for checking pipe scaler availability Signed-off-by: Nemesa Garg ---

[PATCH 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-03-07 Thread Nemesa Garg
Scaler coefficient values are based on experiments and vary for different tap value/win size. These values are normalized by taking the sum of all values and then dividing each value with a sum. Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/Makefile | 1 +

[PATCH 1/5] drm: Introduce sharpness mode property

2024-03-07 Thread Nemesa Garg
This allows the user to set the intensity so as to get the sharpness effect. It is useful in scenario when the output is blurry and user want to sharpen the pixels. Signed-off-by: Nemesa Garg --- drivers/gpu/drm/drm_atomic_uapi.c | 4 drivers/gpu/drm/drm_crtc.c| 17

[PATCH] drm: add missing header guards to drm_crtc_internal.h

2024-03-07 Thread Jani Nikula
Including the file twice can lead to errors. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_crtc_internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h index c0c5d79ed4c9..0c693229a1c9 100644 ---

[PATCH 0/5] Introduce drm sharpening property

2024-03-07 Thread Nemesa Garg
Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural

[PATCH v2] drm/crtc: make drm_crtc_internal.h self-contained

2024-03-07 Thread Jani Nikula
Forward declare struct drm_printer and include . v2: Include (kernel test robot) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_crtc_internal.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h index

Re: linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2024-03-07 Thread Joonas Lahtinen
Quoting Stephen Rothwell (2024-03-07 04:10:27) > Hi all, > > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/drm/i915/display/intel_dp.c > > between commit: > > 984318aaf7b6 ("drm/i915/panelreplay: Move out psr_init_dpcd() from > init_connector()") > > from

[PULL] drm-intel-fixes

2024-03-07 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes the final drm-intel-fixes for v6.8. This PR will appear to contain more patches than it does. It's 4 patches on top of drm-fixes after Sima pulled the previous PR as you can observe from git log. Fixes for kernel crash on UHD 730, boot delay regression on PSR, DP DSC