✓ Fi.CI.BAT: success for drm/i915/guc: Fix the fix for reset lock confusion

2024-03-29 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix the fix for reset lock confusion URL : https://patchwork.freedesktop.org/series/131833/ State : success == Summary == CI Bug Log - changes from CI_DRM_14509 -> Patchwork_131833v1 Summary

Re: ✗ Fi.CI.IGT: failure for Disable automatic load CCS load balancing (rev14)

2024-03-29 Thread Andi Shyti
Hi, On Sat, Mar 30, 2024 at 12:03:08AM -, Patchwork wrote: > Patch Details > > Series: Disable automatic load CCS load balancing (rev14) > URL: https://patchwork.freedesktop.org/series/129951/ > State: failure > Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129951v14/ >

[PATCH] drm/i915/guc: Fix the fix for reset lock confusion

2024-03-29 Thread John . C . Harrison
From: John Harrison The previous fix for the circlular lock splat about the busyness worker wasn't quite complete. Even though the reset-in-progress flag is cleared at the start of intel_uc_reset_finish, the entire function is still inside the reset mutex lock. Not sure why the patch appeared to

✓ Fi.CI.IGT: success for ALPM AUX-Less (rev8)

2024-03-29 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev8) URL : https://patchwork.freedesktop.org/series/129938/ State : success == Summary == CI Bug Log - changes from CI_DRM_14505_full -> Patchwork_129938v8_full Summary --- **SUCCESS**

Re: [PATCH 05/11] drm/i915/dp_mst: Account with the DSC DPT bpp limit on MTL

2024-03-29 Thread Manasi Navare
Hi Imre, While we are adding these checks here for DSC for MST, I see that in intel_dp_mst_mode_valid_ctx() we still check against DISPLAY_VER() > 10 for checking for DSC where as in all other places we rely on runtime has_dsc and check for HAS_DSC(), can we fix that and use HAS_DSC() in this

Re: [PATCH 09/13] drm/i915: Add debugs for mbus joining and dbuf ratio programming

2024-03-29 Thread Gustavo Sousa
Quoting Ville Syrjala (2024-03-27 14:45:40-03:00) >From: Ville Syrjälä > >Add some debugs so that we can actually observe what is >actually happening during the mbus/dbuf programming steps. >We can just shove them into fairly low level functions as >none of them are called during any critical

Re: [PATCH 08/13] drm/i915: Extract intel_dbuf_mdclk_min_tracker_update()

2024-03-29 Thread Gustavo Sousa
Quoting Ville Syrjala (2024-03-27 14:45:39-03:00) >From: Ville Syrjälä > >Extact the stuff that writes the dbuf/mbus ration stuff >into its own function. Will help with correctly sequencing >the operations done during mbus programming. > >Signed-off-by: Ville Syrjälä Reviewed-by: Gustavo Sousa

Re: [PATCH 07/13] drm/i915: Extract intel_dbuf_mbus_join_update()

2024-03-29 Thread Gustavo Sousa
Quoting Ville Syrjala (2024-03-27 14:45:38-03:00) >From: Ville Syrjälä > >Extact the stuff that writes the joining bits in MBUS_CTL >into its own function. Will help with correctly sequencing >the operations done during mbus programming. > >Signed-off-by: Ville Syrjälä Reviewed-by: Gustavo

✓ Fi.CI.BAT: success for Add support for partial mapping

2024-03-29 Thread Patchwork
== Series Details == Series: Add support for partial mapping URL : https://patchwork.freedesktop.org/series/131817/ State : success == Summary == CI Bug Log - changes from CI_DRM_14508 -> Patchwork_131817v1 Summary --- **SUCCESS**

Re: [PATCH 06/13] drm/i915: Relocate intel_mbus_dbox_update()

2024-03-29 Thread Gustavo Sousa
Quoting Ville Syrjala (2024-03-27 14:45:37-03:00) >From: Ville Syrjälä > >intel_mbus_dbox_update() will become static soon. Relocate it >into a place that avoids having to add a forward declaration >for it. > >Signed-off-by: Ville Syrjälä Reviewed-by: Gustavo Sousa >--- >

Re: [PATCH 12/13] drm/i915: Use a plain old int for the cdclk/mdclk ratio

2024-03-29 Thread Gustavo Sousa
Quoting Ville Syrjala (2024-03-27 14:45:43-03:00) >From: Ville Syrjälä > >No point in throwing around u8 when we're dealing with >just an integer. Use a plain old boring 'int'. Learned and noted :-) Thanks for fixing that. Should we also modify the member mdclk_cdclk_ratio of intel_dbuf_state?

✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping

2024-03-29 Thread Patchwork
== Series Details == Series: Add support for partial mapping URL : https://patchwork.freedesktop.org/series/131817/ State : warning == Summary == Error: dim checkpatch failed 6f4f712513fb drm/i915/gem: Increment vma offset when mapping fb objects 4e6365336a63 drm/i915/gem: Calculate object

Re: [PATCH 11/13] drm/i915: Implement vblank synchronized MBUS join changes

2024-03-29 Thread Gustavo Sousa
Quoting Ville Syrjala (2024-03-27 14:45:42-03:00) >From: Stanislav Lisovskiy > >Currently we can't change MBUS join status without doing a modeset, >because we are lacking mechanism to synchronize those with vblank. >However then this means that we can't do a fastset, if there is a need >to

Re: [PATCH v0 02/14] drm/amdgpu,drm/radeon: Make I2C terminology more inclusive

2024-03-29 Thread Andi Shyti
Hi, On Fri, Mar 29, 2024 at 10:28:14AM -0700, Easwar Hariharan wrote: > On 3/29/2024 10:16 AM, Andi Shyti wrote: > > Hi Easwar, > > > > On Fri, Mar 29, 2024 at 05:00:26PM +, Easwar Hariharan wrote: > >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > > > > I don't

Re: v6.7+ stable backport request for drm/i915

2024-03-29 Thread Ville Syrjälä
On Fri, Mar 29, 2024 at 02:15:12PM +0100, Greg KH wrote: > On Tue, Mar 19, 2024 at 09:38:45PM +0200, Ville Syrjälä wrote: > > Hi stable team, > > > > Please backport the following the commits to 6.7/6.8 to fix > > some i915 type-c/thunderbolt PLL issues: > > commit 92b47c3b8b24 ("drm/i915:

Re: [PATCH v0 02/14] drm/amdgpu,drm/radeon: Make I2C terminology more inclusive

2024-03-29 Thread Andi Shyti
Hi Easwar, On Fri, Mar 29, 2024 at 05:00:26PM +, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" I don't understand why we forget that i3c is 1.1.1 :-) > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix

Re: [PATCH 04/13] drm/i915/cdclk: Indicate whether CDCLK change happens during pre or post plane update

2024-03-29 Thread Gustavo Sousa
Quoting Ville Syrjala (2024-03-27 14:45:35-03:00) >From: Ville Syrjälä > >Currently we just get a plain "Changing CDCLK to ..." in the >logs. It would actually be interesting to see whether we're >doing the programming during the pre or post plane phase of >the commit. Include that information in

Re: [PATCH 02/13] drm/i915/cdclk: Fix voltage_level programming edge case

2024-03-29 Thread Gustavo Sousa
Quoting Ville Syrjala (2024-03-27 14:45:33-03:00) >From: Ville Syrjälä > >Currently we only consider the relationship of the >old and new CDCLK frequencies when determining whether >to do the repgramming from intel_set_cdclk_pre_plane_update() >or intel_set_cdclk_post_plane_update(). > >It is

[PATCH v2 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping

2024-03-29 Thread Andi Shyti
To enable partial memory mapping of GPU virtual memory, it's necessary to introduce an offset to the object's memory (obj->mm.pages) scatterlist. This adjustment compensates for instances when userspace mappings do not start from the beginning of the object. Based on a patch by Chris Wilson.

[PATCH v2 1/2] drm/i915/gem: Increment vma offset when mapping fb objects

2024-03-29 Thread Andi Shyti
Until now the "vm_pgoff" was not used and there has been no need to set its offset. But now, because we want to support partial mappings with a given offset, we need it to be set. Suggested-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 ++ 1 file

[PATCH v2 0/2] Add support for partial mapping

2024-03-29 Thread Andi Shyti
Hi, this series based on a previous work from Chris adds support for partial mapping. A preparatory patch was needed in order to set the vm_pgoff when mapping frame buffer objects. Indeed I was receiving a negative offset at first. Andi Changelog: == v1 -> v2: - Enable support for CPU

Re: [PATCH] drm/i915/guc: Remove bogus null check

2024-03-29 Thread Dan Carpenter
On Fri, Mar 29, 2024 at 08:09:38AM +0100, Andi Shyti wrote: > Hi Rodrigo, > > On Thu, Mar 28, 2024 at 09:39:17PM -0400, Rodrigo Vivi wrote: > > On Thu, Mar 28, 2024 at 10:41:55PM +0100, Andi Shyti wrote: > > > On Thu, Mar 28, 2024 at 05:31:07PM -0400, Rodrigo Vivi wrote: > > > > This null check

Re: [PATCH 01/13] drm/i915/cdclk: Fix CDCLK programming order when pipes are active

2024-03-29 Thread Gustavo Sousa
Quoting Ville Syrjala (2024-03-27 14:45:32-03:00) >From: Ville Syrjälä > >Currently we always reprogram CDCLK from the >intel_set_cdclk_pre_plane_update() when using squahs/crawl. >The code only works correctly for the cd2x update or full >modeset cases, and it was simply never updated to deal

Re: [PATCH 05/13] spi: add driver for intel graphics on-die spi device

2024-03-29 Thread Lucas De Marchi
On Thu, Mar 28, 2024 at 02:22:28PM +0200, Alexander Usyskin wrote: Add auxiliary driver for intel discrete graphics on-die spi device. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Lucas De Marchi did you mean to Cc me? I never gave my s-o-b afair. The order of the s-o-b in

Re: [PULL] drm-intel-fixes

2024-03-29 Thread Rodrigo Vivi
On Fri, Mar 29, 2024 at 06:23:54AM -0400, Musial, Ewelina wrote: > Hi Rodrigo, > > When I opened dashboard early morning all results were available, so I don't > think there was any issue during night. > It could be long reporting queue - reporting through AWS takes ages but this > is not an

Re: v6.7+ stable backport request for drm/i915

2024-03-29 Thread Greg KH
On Tue, Mar 19, 2024 at 09:38:45PM +0200, Ville Syrjälä wrote: > Hi stable team, > > Please backport the following the commits to 6.7/6.8 to fix > some i915 type-c/thunderbolt PLL issues: > commit 92b47c3b8b24 ("drm/i915: Replace a memset() with zero initialization") > commit ba407525f824

Re: [PATCH] drm/ttm: remove unused paramter

2024-03-29 Thread Christian König
Am 29.03.24 um 12:10 schrieb Christian König: Am 25.03.24 um 08:45 schrieb Jesse Zhang: remove the unsed the paramter in the function ttm_bo_bounce_temp_buffer and ttm_bo_add_move_fence. Signed-off-by: Jesse Zhang Good catch, Reviewed-by: Christian König Please rebase that patch on top

Re: [PATCH] drm/ttm: remove unused paramter

2024-03-29 Thread Christian König
Am 25.03.24 um 08:45 schrieb Jesse Zhang: remove the unsed the paramter in the function ttm_bo_bounce_temp_buffer and ttm_bo_add_move_fence. Signed-off-by: Jesse Zhang Good catch, Reviewed-by: Christian König Regards, Christian. --- drivers/gpu/drm/ttm/ttm_bo.c | 10 -- 1 file

RE: [PULL] drm-intel-fixes

2024-03-29 Thread Musial, Ewelina
Hi Rodrigo, When I opened dashboard early morning all results were available, so I don't think there was any issue during night. It could be long reporting queue - reporting through AWS takes ages but this is not an issue with reporting, this is how AWS works. Regards, Ewelina -Original

✓ Fi.CI.BAT: success for drm/i915: Fix i915_display_info output when connectors are not active

2024-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Fix i915_display_info output when connectors are not active URL : https://patchwork.freedesktop.org/series/131798/ State : success == Summary == CI Bug Log - changes from CI_DRM_14506 -> Patchwork_131798v1

Re: [PATCH] drm/i915/guc: Remove bogus null check

2024-03-29 Thread Andi Shyti
Hi Rodrigo, On Thu, Mar 28, 2024 at 09:39:17PM -0400, Rodrigo Vivi wrote: > On Thu, Mar 28, 2024 at 10:41:55PM +0100, Andi Shyti wrote: > > On Thu, Mar 28, 2024 at 05:31:07PM -0400, Rodrigo Vivi wrote: > > > This null check is bogus because we are already using 'ce' stuff > > > in many places

✓ Fi.CI.BAT: success for drm/i915: Bigjoiner modeset sequence redesign and MST support

2024-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Bigjoiner modeset sequence redesign and MST support URL : https://patchwork.freedesktop.org/series/131797/ State : success == Summary == CI Bug Log - changes from CI_DRM_14506 -> Patchwork_131797v1

✗ Fi.CI.SPARSE: warning for drm/i915: Bigjoiner modeset sequence redesign and MST support

2024-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Bigjoiner modeset sequence redesign and MST support URL : https://patchwork.freedesktop.org/series/131797/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Bigjoiner modeset sequence redesign and MST support

2024-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Bigjoiner modeset sequence redesign and MST support URL : https://patchwork.freedesktop.org/series/131797/ State : warning == Summary == Error: dim checkpatch failed e16878b1bab4 drm/i915: Disable port sync when bigjoiner is used 61c083f1c409 drm/i915:

✓ Fi.CI.BAT: success for drm/i915/guc: Remove bogus null check

2024-03-29 Thread Patchwork
== Series Details == Series: drm/i915/guc: Remove bogus null check URL : https://patchwork.freedesktop.org/series/131795/ State : success == Summary == CI Bug Log - changes from CI_DRM_14506 -> Patchwork_131795v1 Summary ---

✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Remove bogus null check

2024-03-29 Thread Patchwork
== Series Details == Series: drm/i915/guc: Remove bogus null check URL : https://patchwork.freedesktop.org/series/131795/ State : warning == Summary == Error: dim checkpatch failed 8cb79e76e55a drm/i915/guc: Remove bogus null check -:17: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be