Re: [Intel-gfx] [PATCH 04/15] drm/arm: Use per-plane rotation property

On Fri, Jul 22, 2016 at 04:43:05PM +0300, Ville Syrjälä wrote: From: Ville Syrjälä <ville.syrj...@linux.intel.com> The global mode_config.rotation_property is going away, switch over to per-plane rotation_property. Cc: Liviu Dudau <liviu.du...@arm.com> Cc: Brian Starkey <brian.

Re: [Intel-gfx] [PATCH i-g-t v4 00/11] tests/kms_atomic_transition add fence testing

Hi Robert, Some minor comments on 5, 6, 9, 10 and 11. With those addressed, the whole series is: Reviewed-by: Brian Starkey <brian.star...@arm.com> Thanks! -Brian P.S. Immediately after hitting send I realised I should have trimmed that blob from my reply. Sorry for bouncing tha

Re: [Intel-gfx] [PATCH i-g-t v4 09/11] tests/kms_atomic_transition: add out_fences tests

On Tue, Jan 31, 2017 at 08:25:18PM -0500, Robert Foss wrote: Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 16 + tests/kms_atomic_transition.c | 153

Re: [Intel-gfx] [PATCH i-g-t v4 05/11] lib/igt_kms: Add support for the IN_FENCE_FD property

On Tue, Jan 31, 2017 at 08:25:14PM -0500, Robert Foss wrote: Add support dor the IN_FENCE_FD property to enable setting in fences for atomic commits. trivial... s/dor/for/ Signed-off-by: Robert Foss --- lib/igt_kms.c | 25 + lib/igt_kms.h |

Re: [Intel-gfx] [PATCH i-g-t v4 06/11] lib/igt_kms: Add support for the OUT_FENCE_PTR property

On Tue, Jan 31, 2017 at 08:25:15PM -0500, Robert Foss wrote: From: Gustavo Padovan Add support for the OUT_FENCE_PTR property to enable setting out fences for atomic commits. Signed-off-by: Gustavo Padovan Signed-off-by:

Re: [Intel-gfx] [PATCH i-g-t v4 11/11] lib/igt_kms: Added igt_pipe_get_last_out_fence()

On Tue, Jan 31, 2017 at 08:25:20PM -0500, Robert Foss wrote: Added the igt_pipe_get_last_out_fence() helper function that wraps accesses to pipe->fence_out. Signed-off-by: Robert Foss --- lib/igt_kms.c | 8 lib/igt_kms.h | 1 + 2 files changed, 9 insertions(+)

Re: [Intel-gfx] [PATCH i-g-t v3 06/11] lib/igt_kms: Add support for the IN_FENCE_FD property

On Mon, Jan 30, 2017 at 08:58:42PM -0500, Robert Foss wrote: Add support dor the IN_FENCE_FD property to enable setting in fences for atomic commits. Signed-off-by: Robert Foss --- lib/igt_kms.c | 20 lib/igt_kms.h | 5 + 2 files changed, 25

Re: [Intel-gfx] [PATCH i-g-t v3 05/11] lib/igt_kms: Added igt_pipe_get_last_out_fence()

On Mon, Jan 30, 2017 at 08:58:41PM -0500, Robert Foss wrote: Added the igt_pipe_get_last_out_fence() helper function that wraps accesses to pipe->fence_out. Signed-off-by: Robert Foss --- lib/igt_kms.c | 8 lib/igt_kms.h | 1 + 2 files changed, 9 insertions(+)

Re: [Intel-gfx] [PATCH i-g-t v3 10/11] tests/kms_atomic_transition: add out_fences tests

On Mon, Jan 30, 2017 at 08:58:46PM -0500, Robert Foss wrote: Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 35 ++ tests/kms_atomic_transition.c | 148

Re: [Intel-gfx] [PATCH i-g-t v3 11/11] tests/kms_atomic_transition: add in_fences tests

On Mon, Jan 30, 2017 at 08:58:47PM -0500, Robert Foss wrote: From: Gustavo Padovan Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 3 +++

Re: [Intel-gfx] [PATCH i-g-t v3 08/11] tests/kms_atomic: stress possible fence settings

This one lgtm, just need to swap all the uint64_t out_fence_ptrs for int32_t. -Brian On Mon, Jan 30, 2017 at 08:58:44PM -0500, Robert Foss wrote: From: Gustavo Padovan Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss

Re: [Intel-gfx] [PATCH i-g-t v3 07/11] lib/igt_kms: Add support for the OUT_FENCE_PTR property

On Mon, Jan 30, 2017 at 08:58:43PM -0500, Robert Foss wrote: From: Gustavo Padovan Add support for the OUT_FENCE_PTR property to enable setting out fences for atomic commits. Signed-off-by: Gustavo Padovan Signed-off-by:

Re: [Intel-gfx] [PATCH i-g-t v2 1/5] lib/igt_kms: Fix drm_plane leak

-A-128x128-top-edge igt@kms_ccs@bad-rotation-90 igt@kms_busy@flip-blt-A igt@kms_mmap_write_crc There were no changes to any test on 11 hosts (ILK to KBL). (3 fails on bad-rotation-90 stays just as they were) Thanks, Brian On Mon, Feb 20, 2017 at 11:02:44AM +, Brian Starkey wrote: In the loop

[Intel-gfx] [PATCH i-g-t v2 3/5] lib/igt_kms: Fix possible out-of-bounds access

If there's no primary plane, pipe->plane_primary == -1, and the assert meant to check that it's valid will access pipe->planes[-1]. Fix that to check that pipe->plane_primary has been set instead. Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support Signed-off-by: Bria

[Intel-gfx] [PATCH i-g-t v2 5/5] lib/igt_kms: Remove redundant cursor code

ent logic. Signed-off-by: Brian Starkey <brian.star...@arm.com> Reviewed-by: Robert Foss <robert.f...@collabora.com> --- lib/igt_kms.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 60c4c260bf2d..8751c97f7a06 1

[Intel-gfx] [PATCH i-g-t v2 1/5] lib/igt_kms: Fix drm_plane leak

In the loop looking for planes on a pipe, we always want to free up the drm_plane afterwards. Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support Signed-off-by: Brian Starkey <brian.star...@arm.com> Reviewed-by: Robert Foss <robert.f...@collabora.com> --- lib/igt_

[Intel-gfx] [PATCH i-g-t v2 2/5] lib/igt_kms: Neaten up pipe->planes[] assignment

Remove a bunch of branches, functionally equivalent. Changes since v1: - Added back display->has_cursor_plane assignment Signed-off-by: Brian Starkey <brian.star...@arm.com> Reviewed-by: Robert Foss <robert.f...@collabora.com> --- lib/igt_kms.c | 33 ++

[Intel-gfx] [PATCH i-g-t v2 4/5] lib/igt_kms: Fix memory corruption when there's no cursor plane

't included in n_planes anyway, which means there's no way to ever access it/know that it's there - so just remove it entirely. Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support Signed-off-by: Brian Starkey <brian.star...@arm.com> Reviewed-by: Robert Foss <robert.f...@c

Re: [Intel-gfx] [PATCH i-g-t 2/5] lib/igt_kms: Neaten up pipe->planes[] assignment

On Sun, Feb 19, 2017 at 03:41:45PM -0500, Robert Foss wrote: On 2017-02-17 12:54 PM, Brian Starkey wrote: Remove a bunch of branches, functionally equivalent. Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_kms.c | 34 ++ 1 file chang

Re: [Intel-gfx] [PATCH i-g-t 1/5] lib/igt_kms: Fix drm_plane leak

On Sun, Feb 19, 2017 at 03:39:48PM -0500, Robert Foss wrote: On 2017-02-17 12:54 PM, Brian Starkey wrote: In the loop looking for planes on a pipe, we always want to free up the drm_plane afterwards. Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support Signed-off-by: Brian

[Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Initialize pipe_crcs to avoid segfault

igt_pipe_crc_new() is skipped for non-Intel devices, but the later calls to collect_crcs_mask() will attempt to retrieve CRC values if the pipe_crcs pointers are non-NULL. Zero-initialise pipe_crcs to avoid accessing garbage pointers on non-Intel devices. Signed-off-by: Brian Starkey <brian.s

[Intel-gfx] [PATCH i-g-t 4/5] lib/igt_kms: Fix memory corruption when there's no cursor plane

't included in n_planes anyway, which means there's no way to ever access it/know that it's there - so just remove it entirely. Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_kms.c |6 -- 1 file change

[Intel-gfx] [PATCH i-g-t 5/5] lib/igt_kms: Remove redundant cursor code

ent logic. Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_kms.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index ef7bfd1a8108..6fbe67139d98 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1824,20

[Intel-gfx] [PATCH i-g-t 3/5] lib/igt_kms: Fix possible out-of-bounds access

If there's no primary plane, pipe->plane_primary == -1, and the assert meant to check that it's valid will access pipe->planes[-1]. Fix that to check that pipe->plane_primary has been set instead. Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support Signed-off-by: Bria

[Intel-gfx] [PATCH i-g-t 2/5] lib/igt_kms: Neaten up pipe->planes[] assignment

Remove a bunch of branches, functionally equivalent. Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_kms.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 4ca9145726e2..783c89

[Intel-gfx] [PATCH i-g-t 1/5] lib/igt_kms: Fix drm_plane leak

In the loop looking for planes on a pipe, we always want to free up the drm_plane afterwards. Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support Signed-off-by: Brian Starkey <brian.star...@arm.com> --- Hi, This series cleans up igt_display_init a bit. - Fixes a memor

Re: [Intel-gfx] [PATCH i-g-t] lib: use the local intel_aub.h file

might as well use it ;-) Cc: Brian Starkey <brian.star...@arm.com> Reported-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- An alternative would be to $ git mv tools/intel_aub.h lib/stubs/drm/ and drop the intel_aub.h referenc

Re: [Intel-gfx] [PATCH i-g-t v2] configure.ac: correctly manage DRM_INTEL_{CFLAGS, LIBS}

ble" we do it locally. In either case the CFLAGS is not propagated through, this one can get build issues regardless of the actual state of the toggle. v2: Add -I for the include directive and correctly propagate $(top_srcdir). Cc: Brian Starkey <brian.star...@arm.com> Cc: Robert

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

On Tue, Nov 22, 2016 at 02:12:59PM +0100, Daniel Vetter wrote: On Tue, Nov 22, 2016 at 12:37:47PM +, Brian Starkey wrote: On Tue, Nov 22, 2016 at 12:10:52PM +, Chris Wilson wrote: > On Tue, Nov 22, 2016 at 11:54:57AM +0000, Brian Starkey wrote: > > On Tue, Nov 22, 2016 at 1

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

On Tue, Nov 22, 2016 at 12:10:52PM +, Chris Wilson wrote: On Tue, Nov 22, 2016 at 11:54:57AM +, Brian Starkey wrote: On Tue, Nov 22, 2016 at 11:06:00AM +, Chris Wilson wrote: >On Tue, Nov 22, 2016 at 10:53:51AM +0000, Brian Starkey wrote: >>Hi Gustavo, >>

Re: [Intel-gfx] [PATCH 06/12] lib/igt_kms: Add support for the IN_FENCE_FD property

Hi, On Mon, Nov 14, 2016 at 06:59:20PM +0900, Gustavo Padovan wrote: From: Robert Foss Add support dor the IN_FENCE_FD property to enable setting in fences for atomic commits. Signed-off-by: Robert Foss --- lib/igt_kms.c | 20

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

On Tue, Nov 22, 2016 at 11:06:00AM +, Chris Wilson wrote: On Tue, Nov 22, 2016 at 10:53:51AM +, Brian Starkey wrote: Hi Gustavo, A little late to the party here, but I was blocked by our internal contributions process... I didn't see these end up in my checkout yet though, so I guess

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

On Tue, Nov 22, 2016 at 02:56:49PM +0100, Daniel Vetter wrote: On Tue, Nov 22, 2016 at 01:50:53PM +, Brian Starkey wrote: On Tue, Nov 22, 2016 at 02:12:59PM +0100, Daniel Vetter wrote: > On Tue, Nov 22, 2016 at 12:37:47PM +0000, Brian Starkey wrote: > > On Tue, Nov 22, 2016 at 1

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

Hi Gustavo, A little late to the party here, but I was blocked by our internal contributions process... I didn't see these end up in my checkout yet though, so I guess they aren't picked up yet. On Mon, Nov 14, 2016 at 06:59:21PM +0900, Gustavo Padovan wrote: From: Gustavo Padovan

Re: [Intel-gfx] [PATCH i-g-t v2 10/12] tests/kms_atomic_transition: add out_fences tests

On Wed, Dec 14, 2016 at 04:05:07AM -0500, Robert Foss wrote: From: Gustavo Padovan Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 22

Re: [Intel-gfx] [PATCH i-g-t v2 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

Hi, On Wed, Dec 14, 2016 at 04:05:04AM -0500, Robert Foss wrote: From: Gustavo Padovan Add support for the OUT_FENCE_PTR property to enable setting out fences for atomic commits. Signed-off-by: Gustavo Padovan Signed-off-by:

Re: [Intel-gfx] [PATCH i-g-t v2 06/12] lib/igt_kms: Add support for the IN_FENCE_FD property

Hi, On Wed, Dec 14, 2016 at 04:05:03AM -0500, Robert Foss wrote: Add support dor the IN_FENCE_FD property to enable setting in fences for atomic commits. Signed-off-by: Robert Foss --- lib/igt_kms.c | 20 lib/igt_kms.h | 5 + 2 files changed,

Re: [Intel-gfx] [PATCH i-g-t v2 08/12] tests/kms_atomic: stress possible fence settings

Hi, On Wed, Dec 14, 2016 at 04:05:05AM -0500, Robert Foss wrote: From: Gustavo Padovan Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- tests/kms_atomic.c | 186

Re: [Intel-gfx] [PATCH i-g-t v2 08/12] tests/kms_atomic: stress possible fence settings

On Fri, Dec 16, 2016 at 03:35:36AM -0500, Robert Foss wrote: On 2016-12-14 11:39 AM, Brian Starkey wrote: Hi, On Wed, Dec 14, 2016 at 04:05:05AM -0500, Robert Foss wrote: From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: Gustavo Padovan <gustavo.pado...@collab

Re: [Intel-gfx] [PATCH i-g-t v2 10/12] tests/kms_atomic_transition: add out_fences tests

On Fri, Dec 16, 2016 at 03:59:00AM -0500, Robert Foss wrote: On 2016-12-14 11:57 AM, Brian Starkey wrote: On Wed, Dec 14, 2016 at 04:05:07AM -0500, Robert Foss wrote: From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: Gustavo Padovan <gustavo.pado...@collab

Re: [Intel-gfx] [PATCH i-g-t v2 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

On Fri, Dec 16, 2016 at 03:21:45AM -0500, Robert Foss wrote: On 2016-12-14 11:13 AM, Brian Starkey wrote: Hi, On Wed, Dec 14, 2016 at 04:05:04AM -0500, Robert Foss wrote: From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Add support for the OUT_FENCE_PTR property to enable s

[Intel-gfx] [PATCH i-g-t] lib/igt_kms: Fix erroneous assert

In trying to fix igt_display_init() for devices without cursors, I actually made matters worse. Fix the assert. Fixes: 545aa3398223 lib/igt_kms: Remove redundant cursor code Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_kms.c | 10 +- 1 file changed, 5 inse

Re: [Intel-gfx] [PATCH] drm: Document code of conduct

Keith Packard <kei...@keithp.com> Cc: tfh...@err.no Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> --- Documentation/gpu/introduction.rst | 11 +++ 1 file changed, 11 insertions(+) LGTM, thanks. Acked-by: Brian Starkey <

Re: [Intel-gfx] [PATCH i-g-t 7/7] lib/igt_kms: Use kernel command line mode if specified

On Tue, Apr 25, 2017 at 07:58:18PM +0300, Ville Syrjälä wrote: On Tue, Apr 25, 2017 at 05:45:13PM +0100, Brian Starkey wrote: If "video=" is specified on the kernel command-line, use it to override the default mode in kmstest_get_connector_default_mode. If a mode override wa

[Intel-gfx] [PATCH i-g-t 4/7] lib/igt_debugfs: Remove igt_debugfs_t

It's not used anymore, so remove it. Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_debugfs.c |5 - 1 file changed, 5 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index 7584be5f9cc1..f5ed3dafee8a 100644 --- a/lib/igt_debugfs.c +++ b/lib/igt_deb

[Intel-gfx] [PATCH i-g-t RESEND 1/7] lib/igt_kms: Fix erroneous assert

In trying to fix igt_display_init() for devices without cursors, I actually made matters worse. Fix the assert. Fixes: 545aa3398223 lib/igt_kms: Remove redundant cursor code Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_kms.c | 10 +- 1 file changed, 5 inse

[Intel-gfx] [PATCH i-g-t 6/7] igt: lib/igt_crc: Split out CRC functionality

Separate out the CRC code for better compartmentalisation. Should ease the addition of more/different CRC sources in the future. Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/Makefile.sources |2 + lib/igt_chamelium.h |1 + lib/igt

[Intel-gfx] [PATCH i-g-t 3/7] lib: Stop igt_get_all_cairo_formats memory leak

igt_get_all_cairo_formats() allocates the format list on the heap, but returns it in a const pointer. Change this so that callers can free the array without a warning, and free the array in all callers. Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_fb.c |4 +++

[Intel-gfx] [PATCH i-g-t 0/7] Misc fixes and cleanup

allows "video=" on the kernel command-line to override a connector's default mode. I don't know if that's widely useful, but we like to use it on our FPGA platforms. All comments/feedback welcome, Thanks, Brian Brian Starkey (7): lib/igt_kms: Fix erroneous assert lib/ig

[Intel-gfx] [PATCH i-g-t 2/7] lib/igt_kms: Fix override_mode handling

. Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_kms.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 5837a9f112a6..474aa005b9fa 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1575,9 +15

[Intel-gfx] [PATCH i-g-t 5/7] lib/igt_debugfs: Only use valid values in igt_crc_to_str()

Not all elements in the crc array may be valid, so only use the valid ones to generate the string. Signed-off-by: Brian Starkey <brian.star...@arm.com> --- lib/igt_debugfs.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c

[Intel-gfx] [PATCH i-g-t 7/7] lib/igt_kms: Use kernel command line mode if specified

If "video=" is specified on the kernel command-line, use it to override the default mode in kmstest_get_connector_default_mode. If a mode override was provided on the command-line, it was probably for good reason so we should honor it. Signed-off-by: Brian Starkey <brian.st

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib: Stop igt_get_all_cairo_formats memory leak

On Tue, Apr 25, 2017 at 02:43:13PM -0300, Gabriel Krisman Bertazi wrote: Brian Starkey <brian.star...@arm.com> writes: igt_get_all_cairo_formats() allocates the format list on the heap, but returns it in a const pointer. Change this so that callers can free the array without a w

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi, On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark Cc: Daniel Stone Cc: Kristian H. Kristensen Signed-off-by: Ben Widawsky ---

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi Daniel, On Wed, May 03, 2017 at 03:07:40PM +0100, Daniel Stone wrote: Hi Brian, On 3 May 2017 at 15:03, Brian Starkey <brian.star...@arm.com> wrote: On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote: formats_offset is the end of the fixed-size element, which is cur

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote: Hi Brian, On 3 May 2017 at 13:51, Brian Starkey <brian.star...@arm.com> wrote: On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: + modifiers_size = + sizeof(struct drm_format_mo

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi Daniel, On Wed, May 03, 2017 at 12:47:18PM +0100, Daniel Stone wrote: Hi Brian, On 3 May 2017 at 12:00, Brian Starkey <brian.star...@arm.com> wrote: Having just caught up on IRC I'm sure I'm far too late for this party, but... Wouldn't this whole thing be a whole lot s

Re: [Intel-gfx] [PATCH 2/3] drm: Create a format/modifier blob

Hi, Having just caught up on IRC I'm sure I'm far too late for this party, but... Wouldn't this whole thing be a whole lot simpler if "IN_FORMATS" stored "pointers" to separate blobs for the format and modifier lists? struct drm_format_modifier_blob { #define FORMAT_BLOB_CURRENT 1 /*

Re: [Intel-gfx] [RFC 2/7] drm: Add Plane CTM property

Hi Uma, On Tue, Nov 07, 2017 at 05:36:26PM +0530, Uma Shankar wrote: Add a blob property for plane CSC usage. v2: Rebase Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic.c| 10 ++ drivers/gpu/drm/drm_atomic_helper.c |3 +++

Re: [Intel-gfx] [RFC 1/7] drm: Add Plane Degamma properties

Hi, On Tue, Nov 07, 2017 at 05:36:25PM +0530, Uma Shankar wrote: Add Plane Degamma as a blob property and plane degamma size as a range property. v2: Rebase Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic.c| 12

Re: [Intel-gfx] [RFC 1/7] drm: Add Plane Degamma properties

On Tue, Nov 07, 2017 at 05:49:56PM +, Brian Starkey wrote: In one of the previous discussions[1] related to per-plane color management, Lionel suggested that the 16-bit color lut entries weren't enough when considering HDR. It might be worth creating a new gamma lut format with 32-bit

Re: [Intel-gfx] [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

au <liviu.du...@arm.com> Cc: Brian Starkey <brian.star...@arm.com> Cc: Mali DP Maintainers <mal...@foss.arm.com> Cc: Johnson Lin <johnson@intel.com> Cc: Uma Shankar <uma.shan...@intel.com> Cc: Shashank Sharma <shashank.sha...@intel.com> Signed-off-by: Ville Syr

Re: [Intel-gfx] [RFC v4 3/8] drm: Add Plane CTM property

Hi, On Wed, Aug 22, 2018 at 12:53:58PM +0300, Ville Syrjälä wrote: On Wed, Aug 22, 2018 at 08:40:19AM +, Lankhorst, Maarten wrote: fre 2018-08-17 klockan 19:48 +0530 skrev Uma Shankar: > Add a blob property for plane CSC usage. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments.

Re: [Intel-gfx] [PATCH 1/5] drm/fourcc: Add is_yuv field to drm_format_info to denote if the format is yuv

and it will prevent duplication of similar logic. This looks like a good idea to me. I wonder if the two "has_alpha" and "is_yuv" bools should be bitfields to reduce the footprint (not sure what the general DRM attitude to bitfields is), but either way: Reviewed-by: Brian Starkey Signe

Re: [Intel-gfx] [PATCH 1/2] drm: Add color management LUT validation helpers

r_lut_check(lut, DRM_COLOR_LUT_EQUAL_CHANNELS | DRM_COLOR_LUT_INCREASING); Not sure if it would turn out messy with the different loop bounds. Either way, for mali-dp it makes no difference, and probably LUTs aren't changing all the time so: Reviewed-by: Brian Starkey > + > + return

Re: [Intel-gfx] [PATCH v2 1/2] drm: Add color management LUT validation helper (v2)

e > equal. Let's add a helper function that drivers can use to test that a > userspace-provided LUT is valid and doesn't violate hardware > requirements. > > v2: > - Combine into a single helper that just takes a bitmask of the tests >to apply. (Brian Starkey) >

Re: [Intel-gfx] [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

Hi, On Fri, Nov 30, 2018 at 04:34:54PM +0100, Hans Verkuil wrote: > On 11/30/18 16:16, Ville Syrjälä wrote: > > On Fri, Nov 30, 2018 at 03:48:00PM +0100, Hans Verkuil wrote: > >> On 11/30/18 15:29, Ville Syrjälä wrote: > >>> On Fri, Nov 30, 2018 at 03:20:59PM +0100, Andrzej Hajda wrote: > Hi

Re: [Intel-gfx] [v4 2/3] drm: Add DP colorspace property

Hi Uma, On Tue, Nov 27, 2018 at 10:10:42PM +0530, Uma Shankar wrote: > This patch adds a DP colorspace property, enabling > userspace to switch to various supported colorspaces. > This will help enable BT2020 along with other colorspaces. > > v2: Addressed Maarten and Ville's review comments.

Re: [Intel-gfx] [v4 0/3] Add Colorspace connector property interface

On Wed, Nov 28, 2018 at 02:29:53PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of > >Brian Starkey > >Sent: Wednesday, November 28, 2018 5:27 PM > >To: Shan

Re: [Intel-gfx] [v4 0/3] Add Colorspace connector property interface

Hi, On Tue, Nov 27, 2018 at 10:10:40PM +0530, Uma Shankar wrote: > This patch series creates a new connector property to program > colorspace to sink devices. Modern sink devices support more > than 1 type of colorspace like 601, 709, BT2020 etc. This helps > to switch based on content type which

Re: [Intel-gfx] [PATCH v3 2/3] drm: Add CRTC background color property (v3)

Hi Matt, On Thu, Nov 15, 2018 at 02:13:45PM -0800, Matt Roper wrote: >Some display controllers can be programmed to present non-black colors >for pixels not covered by any plane (or pixels covered by the >transparent regions of higher planes). Compositors that want a UI with >a solid color

Re: [Intel-gfx] [PATCH v4 2/3] drm: Add CRTC background color property (v4)

sentation of the u64, it can >still be confusing to look at code that uses 'rgba' terminology, but >stores values with argb ordering. (Ville) > > v4: > - Drop the bgcolor_changed flag. (Ville, Brian Starkey) > - Clarify in kerneldoc that background color is expected t

Re: [Intel-gfx] [v6 1/2] drm: Add colorspace connector property

Hi Uma, On Thu, Dec 27, 2018 at 11:22:37PM +0530, Uma Shankar wrote: > This patch adds a colorspace connector property, enabling > userspace to switch to various supported colorspaces. > This will help enable BT2020 along with other colorspaces. > > v2: Addressed Maarten and Ville's review

Re: [Intel-gfx] [v6 0/2] Add Colorspace connector property interface

Hi Uma, On Thu, Dec 27, 2018 at 11:22:36PM +0530, Uma Shankar wrote: > This patch series creates a new connector property to program > colorspace to sink devices. Modern sink devices support more > than 1 type of colorspace like 601, 709, BT2020 etc. This helps > to switch based on content type

Re: [Intel-gfx] [v6 05/13] drm: Implement HDR output metadata set and get property handling

Hi, On Wed, Mar 20, 2019 at 04:18:18PM +0530, Uma Shankar wrote: > This patch implements get() and set() functions for HDR output > metadata property.The blob data is received from userspace and > saved in connector state, the same is returned as blob in get > property call to userspace. > > v2:

Re: [Intel-gfx] [v6 03/13] drm: Parse Colorimetry data block from EDID

Hi Uma, On Wed, Mar 20, 2019 at 04:18:16PM +0530, Uma Shankar wrote: > CEA 861.3 spec adds colorimetry data block for HDMI. > Parsing the block to get the colorimetry data from > panel. > While code which parses these parts (patches 2 and 3) out of EDID could be useful - it doesn't seem to

Re: [Intel-gfx] [v6 06/13] drm: Enable HDR infoframe support

On Wed, Mar 20, 2019 at 04:18:19PM +0530, Uma Shankar wrote: > Enable Dynamic Range and Mastering Infoframe for HDR > content, which is defined in CEA 861.3 spec. > > The metadata will be computed based on blending > policy in userspace compositors and passed as a connector > property blob to

Re: [Intel-gfx] [v6 01/13] drm: Add HDR source metadata property

Hi Uma, On Wed, Mar 20, 2019 at 04:18:14PM +0530, Uma Shankar wrote: > This patch adds a blob property to get HDR metadata > information from userspace. This will be send as part > of AVI Infoframe to panel. > > v2: Rebase and modified the metadata structure elements > as per Ville's POC

Re: [Intel-gfx] [v6 13/13] video/hdmi: Add const variants for drm infoframe

Hi, On Wed, Mar 20, 2019 at 04:18:26PM +0530, Uma Shankar wrote: > Added the const version of infoframe for DRM metadata > for HDR. > > Signed-off-by: Uma Shankar Unless there's a strong reason not to, I think this can be squashed into patch 6. > --- > drivers/video/hdmi.c | 63 >

Re: [Intel-gfx] [RFC v1 1/7] drm/i915: Add gamma mode property

Hi, On Fri, Mar 22, 2019 at 01:06:01PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Roper, Matthew D > >Sent: Friday, March 22, 2019 2:50 AM > >To: Shankar, Uma > >Cc: intel-gfx@lists.freedesktop.org; Lankhorst, Maarten > >; Syrjala, Ville ; > >Sharma, > >Shashank >

Re: [Intel-gfx] [RFC v1 1/7] drm/i915: Add gamma mode property

On Fri, Mar 22, 2019 at 04:02:57PM +0200, Ville Syrjälä wrote: > On Fri, Mar 22, 2019 at 01:39:04PM +0000, Brian Starkey wrote: > > Hi, > > > > On Fri, Mar 22, 2019 at 01:06:01PM +, Shankar, Uma wrote: > > > > > > > > > >-Original Mes

Re: [Intel-gfx] [PATCH] drm: Constify drm_color_lut_check()

On Tue, Jan 29, 2019 at 07:06:09PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_color_lut_check() doens't modify the passed in blob so s/doens't/doesn't/ Otherwise, LGTM. Reviewed-by: > let's make it const. > > Also s/uint32_y/u32/ while at it. > > Cc: Matt Roper >

Re: [Intel-gfx] [v7 1/2] drm: Add colorspace connector property

Hi Uma, On Tue, Jan 29, 2019 at 01:30:43PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > >Sent: Tuesday, January 29, 2019 5:54 PM > >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >

Re: [Intel-gfx] [PATCH i-g-t v5 0/6] igt: Add support for testing writeback connectors

he v3 and v4 > updates to them. > > Best regards, > Liviu > > Changelog: > - v5: Addressed comments from Brian Starkey. Old v4 changes are here: >https://lists.freedesktop.org/archives/igt-dev/2018-November/006806.html I just replied with two super minor things, but otherw

Re: [Intel-gfx] [PATCH i-g-t v5 5/6] lib/igt_kms: Add igt_output_clone_pipe for cloning

Hi, On Tue, Jan 15, 2019 at 05:47:46PM +, Liviu Dudau wrote: > From: Brian Starkey > diff --git a/lib/igt_kms.h b/lib/igt_kms.h > index 13d3a9ceb..acb27982b 100644 > --- a/lib/igt_kms.h > +++ b/lib/igt_kms.h > @@ -349,6 +349,9 @@ struct igt_pipe { >

Re: [Intel-gfx] [PATCH i-g-t v5 1/6] lib/igt_kms: Add writeback support

Hi Liviu, On Tue, Jan 15, 2019 at 05:47:42PM +, Liviu Dudau wrote: > From: Brian Starkey [snip] > > +/** > + * igt_output_set_writeback_fb: > + * @output: Target output > + * @fb: Target framebuffer > + * > + * This function sets the given @fb to be used a

[Intel-gfx] [PATCH V6 i-g-t 6/6] kms_writeback: Add tests using a cloned output

Update the connector search to also optionally attempt to find a non-writeback connector to clone to. Add a subtest which is the same as writeback-check-output, but also clones to the second connector. Signed-off-by: Brian Starkey [rebased and addressed comments by Maarten] Signed-off-by: Liviu

[Intel-gfx] [PATCH V6 i-g-t 5/6] lib/igt_kms: Add igt_output_clone_pipe for cloning

An output can be added as a clone of any other output(s) attached to a pipe using igt_output_clone_pipe() v5: Drop field out_fence_requested from struct igt_pipe (Brian Starkey) Signed-off-by: Brian Starkey --- lib/igt_kms.c | 100 +++--- lib

[Intel-gfx] [PATCH V6 i-g-t 1/6] lib/igt_kms: Add writeback support

Add support in igt_kms for writeback connectors, with the ability to attach framebuffers. v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before drmModeGetResources() Signed-off-by: Brian Starkey [rebased and updated to the latest igt style] Signed-off-by: Liviu Dudau --- lib/igt_kms.c

[Intel-gfx] [PATCH V6 i-g-t 2/6] kms_writeback: Add initial writeback tests

Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and WRITEBACK_FB_ID properties on writeback connectors, ensuring their behaviour is correct. Signed-off-by: Brian Starkey [rebased and updated do_writeback_test() function to address feedback] Signed-off-by: Liviu Dudau

[Intel-gfx] [PATCH V6 i-g-t 4/6] kms_writeback: Add writeback-check-output

Add a test which makes commits using the writeback connector, and checks the output buffer hash to make sure it is/isn't written as appropriate. Signed-off-by: Brian Starkey --- tests/kms_writeback.c | 124 ++ 1 file changed, 124 insertions(+) diff --git

[Intel-gfx] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

advantage of word-access speedup), we can do the hash on a cached copy, which is much faster (10x speedup on my platform). v6: use igt_memcpy_from_wc() instead of plain memcpy, as suggested by Chris Wilson Signed-off-by: Brian Starkey [rebased and updated to the most recent API] Signed-off

[Intel-gfx] [PATCH v7 i-g-t 4/4] kms_writeback: Add writeback-check-output

message if sync_fence_wait fail - Replace color_idx variable by i - Use in_fb instead of out_fb for getting the expected CRC - Drop unnecessary parentheses - Replace igt_fb_mod_to_tiling to DRM_FORMAT_MOD_LINEAR Signed-off-by: Brian Starkey [rebased and updated the patch to address feedback

[Intel-gfx] [PATCH v7 i-g-t 1/4] lib/igt_kms: Add writeback support

Add support in igt_kms for writeback connectors, with the ability to attach framebuffers. v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before drmModeGetResources() Signed-off-by: Brian Starkey [rebased and updated to the latest igt style] Signed-off-by: Liviu Dudau Signed-off

[Intel-gfx] [PATCH v7 i-g-t 2/4] kms_writeback: Add initial writeback tests

_to_tiling to DRM_FORMAT_MOD_LINEAR - Rename tests - Replace int ret by unsigned int fd_id when calling igt_create_fb Signed-off-by: Brian Starkey [rebased and updated do_writeback_test() function to address feedback] Signed-off-by: Liviu Dudau [rebased and updated the patch to address feedback]

[Intel-gfx] [PATCH v7 i-g-t 3/4] lib: Add function to hash a framebuffer

ole stride, just copy fb->width * cpp since we're only going to read that v5: use igt_memcpy_from_wc() instead of plain memcpy, as suggested by Chris Wilson Signed-off-by: Brian Starkey [rebased and updated to the most recent API] Signed-off-by: Liviu Dudau [rebased and updated the patch to a