bits into intel_lrc.h. (Chris)
>
> v5:
> - Change USES_FULL_48BIT(dev) to USES_FULL_48BIT(dev_priv) (Tvrtko)
>
> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Chris Wilson <ch...@ch
e buffer (so no more sleeping in atomic).
> Magic!
>
You could also mention that you mangle the relocation <-> page logic,
so this is not purely about caching. Or maybe even split it.
Below comments, those addressed;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
(Joonas)
>
> v6:
>
> - When !CONFIG_DRM_I915_GVT, make GVT code as dead code then compiler
> could automatically eliminate them for us. (Chris)
> - Always initialize the notifier header, so it could be switched on/off
> at runtime. (Chris)
>
> v5:
>
> - Only compil
On to, 2016-06-09 at 12:29 +0100, Chris Wilson wrote:
> Since we know the write domain, we can drop the local variable and make
> the code look a tiny bit simpler.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lah
ret = -ENODEV;
> - }
> -
> + ret = relocate_entry(obj, reloc, cache, target_offset);
> if (ret)
> return ret;
>
> /* and update the user's relocation entry */
> reloc->presumed_offset = target_offset;
> -
> return 0;
>
ret;
> - }
> + if (ret)
> + goto err_unpin;
> +
> *needs_clflush = 0;
> }
>
> if ((*needs_clflush & CLFLUSH_AFTER) == 0)
> obj->cache_dirty = true;
>
> +out:
> intel_fb_obj_invalidate(obj, ORIGIN_CPU);
> obj->dirty = 1;
> + /* return with the pages pinned */
> return 0;
> +
> +err_unpin:
> + i915_gem_object_unpin_pages(obj);
> + return ret;
> }
>
> /* Per-page copy function for the shmem pread fastpath.
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
e, dev_priv) {
> + struct intel_context *ce =
Here I would name it as "kce", to make explicit it's about kernel
context engines.
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> + _priv->kernel_context->e
m_remove_node(_info.space[i]);
> + }
Maybe add a counterpart vgt_deballoon_space for vgt_balloon_space and
use it in intel_vgt_deballoon and here. That way the code will be more
readable.
Regards, Joonas
> return ret;
> }
--
Joonas Lahtinen
Open Source Technology Center
In
off-by: Zhi Wang <zhi.a.w...@intel.com>
With Chris's suggestion of renaming to addressing_mode,
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/i915_gem_context.c | 2 ++
> drive
* submission, stop picking
> > + */
> > + if (req0->ctx->enable_lrc_single_submission)
> enable_ is a bad verb here, force_ would be more apt.
>
> s/lrc/execlists/
>
> ctx->execlist
; Signed-off-by: Zhi Wang <zhi.a.w...@intel.com>
It's good idea to add Cc: in patches resulting from discussions (or
Suggested-by:). Then it would be easier to spot for me if I was not
reviewing the series as whole.
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> ---
t; return ret;
> }
> diff --git a/drivers/gpu/drm/i915/i915_vgpu.h
> b/drivers/gpu/drm/i915/i915_vgpu.h
> index 07e67d5..f8917c6 100644
> --- a/drivers/gpu/drm/i915/i915_vgpu.h
> +++ b/drivers/gpu/drm/i915/i915_vgpu.h
> @@ -27,7 +27,7 @@
> #include "i915_pv
i.e. does it get
> used elsewhere) I thought we mentioned this as probably premature
> optimisation and should favour speeding up a no-op call_chain() if
> required. So can we have callbacks in the notifier but need to disable
> notification? If so, that is never explained.
>
By my origin
e() to avoid any implications about "parking" the
> context first.
>
> v2: Tweak an error message if the wait fails for the ilk vtd w/a
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
&g
On ti, 2016-06-07 at 15:29 +, Wang, Zhi A wrote:
>
> >
> > -Original Message-
> > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com]
> > Sent: Friday, June 03, 2016 12:40 PM
> > To: Wang, Zhi A <zhi.a.w...@intel.com>; intel-gfx
d patch. (Joonas)
>
> v3:
> - Use offsetof to calculate the member offset of PVINFO structure (Joonas)
>
> Signed-off-by: Zhi Wang <zhi.a.w...@intel.com>
Assuming this is just code motion patch per description;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
oading stage, to free the
> + * resources owned by a GVT device.
> + *
> + */
> +void intel_gvt_clean_device(struct drm_i915_private *dev_priv)
> +{
> + struct intel_gvt *gvt = _priv->gvt;
> +
> + if (WARN_ON(!gvt->initialized))
> + return;
> +
>
gt; > int pin_count;
> > bool initialised;
> > } engine[I915_NUM_ENGINES];
> > + u32 lrc_ring_buffer_size;
> u32 ring_size;
>
My Reviewed-by: can be kept with that change.
Regards, Joonas
> There is no reason wh
we instead opt to simply
> exit if i915.modeset is disabled.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Looks fine to me.
Reviewed-by:
On pe, 2016-06-03 at 12:36 +, Tian, Kevin wrote:
> >
> > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com]
> > Sent: Friday, May 27, 2016 7:32 PM
> >
> > On pe, 2016-05-27 at 10:05 +, Wang, Zhi A wrote:
> > >
> > > For me I
On ke, 2016-06-08 at 12:06 +0100, Chris Wilson wrote:
> On Wed, Jun 08, 2016 at 11:53:15AM +0100, Chris Wilson wrote:
> >
> > On Tue, Jun 07, 2016 at 02:31:07PM +0300, Joonas Lahtinen wrote:
> > >
> > > On pe, 2016-06-03 a
off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/d
_i915_private *dev_priv)
> -{
> - if (!dev_priv->mm.busy)
> - return;
> -
> - dev_priv->mm.busy = false;
> -
> - if (INTEL_GEN(dev_priv) >= 6)
> - gen6_rps_idle(dev_priv);
> -
> - intel_runtime_pm_put(dev_priv);
> -}
> -
> static void intel_crtc_destroy(struct drm_crtc *crtc)
> {
> struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 712bd0debb91..35bb9a23cd2d 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4850,7 +4850,7 @@ void gen6_rps_boost(struct drm_i915_private *dev_priv,
> /* This is intentionally racy! We peek at the state here, then
> * validate inside the RPS worker.
> */
> - if (!(dev_priv->mm.busy &&
> + if (!(dev_priv->gt.awake &&
> dev_priv->rps.enabled &&
> dev_priv->rps.cur_freq < dev_priv->rps.max_freq_softlimit))
> return;
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h
> b/drivers/gpu/drm/i915/intel_ringbuffer.h
> index 166f1a3829b0..d0cd9a1aa80e 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
> @@ -372,13 +372,13 @@ struct intel_engine_cs {
> };
>
> static inline bool
> -intel_engine_initialized(struct intel_engine_cs *engine)
> +intel_engine_initialized(const struct intel_engine_cs *engine)
> {
> return engine->i915 != NULL;
> }
>
> static inline unsigned
> -intel_engine_flag(struct intel_engine_cs *engine)
> +intel_engine_flag(const struct intel_engine_cs *engine)
> {
> return 1 << engine->id;
> }
I think majority of our functions are not const-correct, I remember
some grunting on the subject when I tried to change some to be. But I'm
all for it myself.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
d-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i91
hris Wilson <ch...@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h| 6 --
On to, 2016-06-09 at 14:35 +0100, Chris Wilson wrote:
> On Thu, Jun 09, 2016 at 04:06:59PM +0300, Joonas Lahtinen wrote:
> >
> > On to, 2016-06-09 at 12:29 +0100, Chris Wilson wrote:
> > >
> > > There is an improbable, but not impossible, case that if we leave th
_64B_CONTEXT
> +};
I think these should be prefixed somehow?
> +#define GEN8_CTX_ADDRESSING_MODE_SHIFT 3
> +#define GEN8_CTX_ADDRESSING_MODE(dev_priv) (USES_FULL_48BIT_PPGTT(dev_priv)
> ?\
> + LEGACY_64B_CONTEXT : \
> + LEGACY_32B_CONTEXT)
> +
I'
sure if it will be worth the #if when vmid would be zero in
DOM0 always.
Regards, Joonas
> req1 = cursor;
> WARN_ON(req1->elsp_submitted);
> break;
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ate the member offset of PVINFO structure
>
Split this patch in two; one to do the move, then other to convert to
offsetof and with that, both patches;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Signed-off-by: Zhi Wang <zhi.a.w...@intel.com>
> ---
&
}
> +
> + dev_priv->gvt = intel_gvt_create_device(dev_priv);
> + if (IS_ERR(dev_priv->gvt)) {
> + DRM_DEBUG_DRIVER("GVT-g is disabled\n");
> + dev_priv->gvt = NULL;
> + return 0;
> + }
> + return 0;
> +}
On to, 2016-06-02 at 12:36 -0400, Zhi Wang wrote:
> This patch introduces an option for configuring the ring buffer size
> of a LRC context after the context creation.
>
> Signed-off-by: Zhi Wang <zhi.a.w...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lah
_NOTIFIER_HEAD(>status_notifier);
>
> return 0;
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.h
> b/drivers/gpu/drm/i915/intel_lrc.h
> index e133c33..7a7ae8d 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.h
> +++ b/drivers/gpu/drm/i915/intel_lrc.h
> @@ -68,6 +68,11 @@ enum {
>
> DRM_ERROR("VGT balloon fail\n");
> - intel_vgt_deballoon();
> + intel_vgt_deballoon(dev_priv);
This function (and any others similar to it) needs to be changed to
have a proper goto teardown path as a follow-up patch. Destructors/fini
functions are only expected t
-+--+
> + * | GGTT memory space |
> + * +------+
> + */
> +
> +/* GGTT memory space owned by host */
> +#define INTEL_GVT_HOST_LOW_GM_SIZE
us_change_notification = true;
> + ctx->enable_lrc_single_submission = true;
> + ctx->lrc_ring_buffer_size = 512 * PAGE_SIZE; /* Max ring buffer size */
> +out:
> + mutex_unlock(>struct_mutex);
> + return ctx;
> +}
> +
> static void i915_gem_context_unpin(struct i915_gem_context *ctx,
> struct intel_engine_cs *engine)
> {
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
i915_gpu_idle(dev_priv->dev)) {
> + if (i915_gem_wait_for_idle(dev_priv)) {
> DRM_ERROR("Couldn't idle GPU\n");
This wait_for scheme and the error message do not make sense together.
> /* Wait a bit, in hopes it avoids th
ot upset userspace. */
> + DRM_DEBUG_DRIVER("KMS and UMS disabled.\n");
> + return 0;
> + }
> +
> + return pci_register_driver(_pci_driver);
> +}
> +
> +static void __exit i915_exit(void)
> +{
> + if (!i915_pci_
on of a few extern keywords;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
> ---
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/i915_drv.c | 450 +
air amount that we can tidy by hand.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
With actual working command lines for people to deal with the conflict
pain;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> ---
>
> This will cause a fair amount
07 416 1128622 1138ae i915.ko (after)
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.inte
e security problem like leaking
> BIOS configuration to VM, better we could elaborate more ideas and
> figure out a better approach. Let’s discuss. J
>
> Thanks,
> Zhi.
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
__
lden MMIO snapshot for strange SKUs.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ontext funcs for greater symmetry with
> intel_lrc. One more step towards unifying behaviour between the two
> classes of engines and towards fixing another bug in i915_switch_context
> vs requests.
>
Much better.
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
>
n.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_sysfs.c | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c
> b/drivers/gpu/drm/i915/i915_sysfs.c
> index 02507bfc8def..
e() to avoid any implications about "parking" the
> context first.
>
> v2: Tweak an error message if the wait fails for the ilk vtd w/a
>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk
_cleanup_engine(struct intel_engine_cs *engine)
> {
> struct drm_i915_private *dev_priv;
> + struct i915_gem_context *kctx;
> + struct intel_context *ce;
>
> if (!intel_engine_initialized(engine))
> return;
> @@ -2327,6 +2350,14 @@ void intel
itch to only when operating on the default context. This is mostly
> a no-op as full-ppgtt only exists with execlists at present which skips
> the context switch anyway.
>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Signed-off-by: Chris Wilson <ch...@chr
var = this_cpu_ptr() to var = get_cpu_ptr()
> v3: Actually use get_cpu_ptr (not get_cpu_var). Drop the spinlock
> removal, concentrate on the immediate bug fix.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96293
> Signed-off-by: Chris Wilson <ch...@chris-wil
ut of memory. Here, we can instead schedule a task to run
> on the other CPU to do the flush before trying again.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Joerg Roedel <j...@8bytes.org>
On ti, 2016-05-31 at 22:01 +0800, Zhiyuan Lv wrote:
> Hi Joonas,
>
> On Fri, May 27, 2016 at 02:32:25PM +0300, Joonas Lahtinen wrote:
> >
> > On pe, 2016-05-27 at 10:05 +, Wang, Zhi A wrote:
> > >
> > > For me I think maybe i915 could save the sn
On pe, 2016-02-05 at 22:16 +0800, Zhiyuan Lv wrote:
> Hi Joonas,
>
> On Fri, Feb 05, 2016 at 03:40:49PM +0200, Joonas Lahtinen wrote:
> > Hi,
> >
> > On pe, 2016-02-05 at 18:03 +0800, Zhiyuan Lv wrote:
> > > Hi Joonas,
> > >
> > > Thanks
on structure refinement.
> - Change the register access behavior just like what i915 does.
>
> For other comments, see my comments below. :)
>
> On 01/29/16 21:57, Joonas Lahtinen wrote:
> > Hi,
> >
> > TL;DR Overall, we have same problem as with the scheduler
gpu.h
> b/drivers/gpu/drm/i915/i915_vgpu.h
> index 942490a..b8a49e6 100644
> --- a/drivers/gpu/drm/i915/i915_vgpu.h
> +++ b/drivers/gpu/drm/i915/i915_vgpu.h
> @@ -24,6 +24,7 @@
> #ifndef _I915_VGPU_H_
> #define _I915_VGPU_H_
>
> +#include "gvt/params.
rds,
> -Zhiyuan
>
> On Thu, Feb 04, 2016 at 01:27:08PM +0200, Joonas Lahtinen wrote:
> > Hi,
> >
> > On to, 2016-01-28 at 18:21 +0800, Zhi Wang wrote:
> > > From: Bing Niu <bing@intel.com>
> > >
> > > This patch introduces host gra
linux/device.h", dev_dbg definition is a macro
too, like almost all the printing functions. I'd rather see it as
i915_dbg. Arguments with side effects can be handled nicely as can be
seen.
We really should increase the priority of modernizing the debugging
infrastructure for i915 (and as a depende
Hi,
See the file MAINTAINERS and add Cc: lines according to "XEN HYPERVISOR
INTERFACE". Also I think it'll be useful to split the i915 changes to a
separate patch next int he series (as the reviewer will be different).
We will have to wait for Xen maintainers to take a position on this. Is
there
elopment
<intel-gfx@lists.freedesktop.org>
Signed-off-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
---
kernel/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 5b9d396..6a13f24 100644
--- a/kernel/cpu.c
+++ b/kernel/cp
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
isor.
> - */
> - uint32_t rsv4;
> - uint32_t display_ready; /* ready for display owner switch */
> -
> - uint32_t rsv5[4];
> -
> - uint32_t g2v_notify;
> - uint32_t rsv6[7];
> -
> - struct {
> - uint32_t lo;
> -
PU among multiple virtual machines on a time-sharing basis. Each
> + * virtual machine is presented a virtual GPU (vGPU), which has equivalent
> + * features as the underlying physical GPU (pGPU), so i915 driver can run
> + * seamlessly in a virtual machine. This file provides t
t; + mappable_size = dev_priv->gvt.host_low_gm_sz_in_mb << 20;
> + unmappable_base = dev_priv->gtt.mappable_end;
> + unmappable_size = dev_priv->gvt.host_high_gm_sz_in_mb << 20;
> + } else if (intel_vgpu_active
nts
> + * of GVT and the necessary components used by GVT in i915 driver.
> + */
> +
> +/**
> + * intel_gvt_init - initialize GVT components at the beginning of i915
> + * driver loading.
> + * @dev: drm device *
> + *
> + * This function is called at the beginning of the
On ti, 2016-02-23 at 15:16 +0200, Joonas Lahtinen wrote:
> >
> > On to, 2016-02-18 at 19:42 +0800, Zhi Wang wrote:
> > From: Bing Niu <bing@intel.com>
> >
> > This patch introduces host graphics memory/fence partition when GVT-g
> > is enabled.
&
Hi,
The below answers are reasonable. So v6 should be the version.
Regards, Joonas
On pe, 2016-02-19 at 17:03 +, John Harrison wrote:
> On 19/02/2016 13:03, Joonas Lahtinen wrote:
> >
> > Hi,
> >
> > Now the code is in reviewable chunks, excellent!
> >
vt wrap. Let's just expose
> pgt_device directly. I believe all other information can be encapsulated
> under pgt_device.
>
> btw to match other description in the code, is it clear to rename pgt_device
> to gvt_device?
>
> Another minor thing needs Joonas' feedback. Is it usual to
l the problem happens again.
>
> Many thanks,
> Adam.
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Joonas Lahtinen
Open Source Technology Center
Intel
es not this lead to plenty of unnecessary storing and restoring of
the context parameters?
I would imagine this to destroy performance.
Regards, Joonas
>
> So it's not necessary to allocate multiple GVT context here.
>
> Thanks
> Kevin
--
Joonas Lahtinen
Open Source Technolo
pushing information to i915.
> >
> > btw to match other description in the code, is it clear to rename pgt_device
> > to gvt_device?
> >
> For the name of GVT physical device, if we use "gvt_device", it looks a
> bit weird when both "gvt_device
On to, 2016-01-14 at 18:50 +0200, Imre Deak wrote:
> On la, 2015-12-19 at 09:58 +, Chris Wilson wrote:
> > Once all the preparations are complete, we are ready to write the
> > modesetting to the hardware. During this phase, we will be making
> > lots
> > of HW register access, so take a top
Hi,
Comments below this pre text.
Many of the comments are related to the indent and style of the code.
That stuff is important to fix for future maintainability. In order for
the future review to be more effective, I'd like to next see a v5 of
the series where the code quality concerns have
enabled()/put_ref() pair.
>
> Kudos to Ville and Joonas for the ideas of this new interface.
>
A couple variables could be initialized at declaration, other than
that;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> CC: Mika Kuoppala <mika.kuopp...@intel.com&
Hi,
According to scripts/get_maintainer.pl Ingo or Peter would be more
appropriate to merge.
Added them as To:
On ke, 2016-02-03 at 22:42 +0530, Gautham R Shenoy wrote:
> Hello Joonas,
>
> On Wed, Feb 03, 2016 at 04:24:28PM +0200, Joonas Lahtinen wrote:
> > Use d
gt;
Cc: Paul E. McKenney <paul...@linux.vnet.ibm.com>
Cc: Gautham R. Shenoy <e...@linux.vnet.ibm.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Signed-off-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
---
kernel/cpu.c | 87 +---
Hi,
On ma, 2016-02-15 at 18:06 +0100, Peter Zijlstra wrote:
> On Mon, Feb 15, 2016 at 03:17:55PM +0100, Peter Zijlstra wrote:
> > On Mon, Feb 15, 2016 at 02:36:43PM +0200, Joonas Lahtinen wrote:
> > > Instead of implementing a custom locked reference counting, use lockref.
&g
On ti, 2016-02-16 at 10:14 +0100, Peter Zijlstra wrote:
> On Tue, Feb 16, 2016 at 10:49:36AM +0200, Joonas Lahtinen wrote:
> > I originally thought of implementing this more similar to what you
> > specify, but then I came across a discussion in the mailing list where
> > it
On ti, 2016-02-16 at 12:07 +0100, Peter Zijlstra wrote:
> On Tue, Feb 16, 2016 at 12:51:03PM +0200, Joonas Lahtinen wrote:
> > Quoting my original patch;
> >
> > "See the Bugzilla link for more details.
>
> If its not in the Changelog it doesn't exist. Pa
ny
> pother planar format for that matter) yet.
>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Fixes: 9e759ff1f4a0 ("drm/i915: Return correct size for rotated views")
> Signed-off-by: Ville Syrjälä
have been caught by cpuhp_lock_*
lockdep tracking.
So I'll move the discussion to linux-pm list to change the CPUfreq code. Thanks
for the comments.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi,
On ma, 2016-02-15 at 18:06 +0100, Peter Zijlstra wrote:
> On Mon, Feb 15, 2016 at 03:17:55PM +0100, Peter Zijlstra wrote:
> > On Mon, Feb 15, 2016 at 02:36:43PM +0200, Joonas Lahtinen wrote:
> > > Instead of implementing a custom locked reference counting, use lockref.
&g
Hi,
Adding Daniel as CC to comment below.
On to, 2016-02-18 at 14:22 +, John Harrison wrote:
> On 20/01/2016 13:18, Joonas Lahtinen wrote:
> > On Mon, 2016-01-11 at 18:42 +, john.c.harri...@intel.com wrote:
> > > From: John Harrison <john
into a separate function.
> Squashed down the i915_scheduler.c sections of various patches into
> this patch. Thus the later patches simply hook in existing code into
> various parts of the driver rather than adding the code as well. Added
> documentation to various functions. Re-worked
rite(>rwsem);
>
> pm_suspend(...)
> ...disable_nonboot_cpus()
> _cpu_down()
> cpu_hotplug_begin(); // Locks cpu_hotplug.lock
> __cpu_notify(CPU_DOWN_PREPARE, ...);
> ...cpufreq_offlin
to process such tasks asynchronously.
>
> v2: Updated to reduce mutex lock usage. The lock is now only held for
> the minimum time within the remove function rather than for the whole
> of the worker thread's operation.
>
> v5: Removed objectionable white space and added some documenta
nction documentation and removed apparently objectionable
> white space. [Joonas Lahtinen]
>
> Used lighter weight spinlocks.
>
> For: VIZ-1587
> Signed-off-by: John Harrison <john.c.harri...@intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> -
hen optionally request
> it's worker thread be woken up after all completion processing is
> complete.
>
> v4: Downgraded a BUG_ON to a WARN_ON as the latter is preferred.
>
> v5: Squashed the i915_scheduler.c portions down into the 'start of
> scheduler' patch. [Joonas La
t's
important that we do not consider just a single use-case and rule other
options out. Especially if the timer system is already been tested some
and could serve both scenarios.
Regards, Joonas
>
> cheers,
> Gerd
>
--
Joonas Lahtinen
Open Source Technology Center
Intel Corpo
nit functions nicely, one
could use the function names directly. By stripping parts of it if
needed to shorten them.
Regards, Joonas
> so extensibility for more testing seems fine.
> -Chris
>
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
e time come when it fails.
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>
Cc: Daniel Vetter <dan...@ffwll.ch>
Signed-off-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
[Rebased and changed 1ull ->
t;mika.kuopp...@linux.intel.com>
Signed-off-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/drm/i915/i915_gem_gtt.c
i
On pe, 2016-03-18 at 08:21 +, Chris Wilson wrote:
> On Fri, Mar 18, 2016 at 09:53:08AM +0200, Joonas Lahtinen wrote:
> >
> > Reference variable value from pointer, not assumed pointer destination.
> >
> > Since:
> >
> > commit c44ef60e437019b8ca
"
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
iff --git a/drivers/gpu/drm/i915/i915_params.h
> b/drivers/gpu/drm/i915/i915_params.h
> index bd5026b..b691026 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -59,6 +59,7 @@ struct i915_params {
> bool enable_guc_submission;
> bool verbose_state_checks;
> bool nuclear_pageflip;
> + unsigned int inject_load_failure;
Duh, add it above the bools, this struct was cleaned once already :P
Regards, Joonas
> };
>
> extern struct i915_params i915 __read_mostly;
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
e added?
Regards, Joonas
>
> On 07/03/2016 12:31, Joonas Lahtinen wrote:
> >
> > Hi,
> >
> > On to, 2016-02-18 at 14:27 +, john.c.harri...@intel.com wrote:
> > >
> > > From: John Harrison <john.c.harri...@intel.com>
> > >
Use less pointers with the probing code, making it much less confusing
to read.
Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk>
Signed-off-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
---
drivers/gpu/drm/i915/i9
Refer to Global GTT consistencly as GGTT, thus rename dev_priv->gtt
to dev_priv->ggtt and struct i915_gtt to struct i915_ggtt.
Fix a couple of whitespace problems while at it.
Signed-off-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c
dfail:0 fail:0 skip:17
> ilk-hp8440p total:196 pass:126 dwarn:1 dfail:4 fail:2 skip:63
> ivb-t430stotal:196 pass:169 dwarn:0 dfail:0 fail:0 skip:27
> skl-i7k-2total:196 pass:173 dwarn:0 dfail:0 fail:0 skip:23
> skl-nuci5total:196 pass:185 dwarn:0 dfail:0
hris Wilson <ch...@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/dr
ible, as all the requests will be considered completed by this
> point, it just brings the HWS into line with expectations for external
> viewers.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Joonas
On ke, 2016-04-06 at 11:10 +0100, Chris Wilson wrote:
> On Wed, Apr 06, 2016 at 12:58:43PM +0300, Joonas Lahtinen wrote:
> >
> > On ke, 2016-04-06 at 00:57 +0100, Chris Wilson wrote:
> > >
> > > An oversight is that when we wrap the seqno, we need to reset the
d-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Comment below, but anyway;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> --
201 - 300 of 2892 matches
Mail list logo
