e/linux-2.6/commit/?h=prescheduler=33dc0f3f6d065cf76abd9ad9778c182519fb49a8
>
> is what I've been trying to get in for the year or so.
Well, the remaining bits could be moved like that, yep.
But I'd do it as a second patch on top of this, for easier review.
Re
Ursulin <tvrtko.ursu...@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Hmm, there really isn't any single commit for Fixes, and it's not a
regression, so fine as is.
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
On to, 2017-02-02 at 15:02 +, Chris Wilson wrote:
> We never assign or use the ppgtt->enable() callback, so remove it.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joo
On ke, 2017-01-18 at 16:27 +, Chris Wilson wrote:
> On Wed, Jan 18, 2017 at 05:56:13PM +0200, Joonas Lahtinen wrote:
> >
> > On ke, 2017-01-18 at 12:18 +, Chris Wilson wrote:
> > >
> > > -subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror
> > &g
izes’
> defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_
On la, 2017-01-21 at 17:29 +, Chris Wilson wrote:
> For easy recognisability, we want the kernel context to have id 0 and
> all user contexts to have non-zero ids.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lah
_CTX_STATUS_PREEMPTED);
This is good for now, Mika has to update it for the SVM code, though.
(Counterpart at intel_lr_context_descriptor_update).
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
ggest better names for the functions, so;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On la, 2017-01-21 at 09:25 +, Chris Wilson wrote:
> Convert I915_PRIORITY_DISPLAY to an enum for easier ranking with new
> priorities in later patches.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.
kfree(engine);
> + dev_priv->engine[id] = NULL;
> + continue;
> + }
> +
> + mask |= ENGINE_MASK(id);
> + }
As discussed in IRC, this loop is broken after first erroring init.
Looking for
mutex clear and prevents boosting priority uselessly
> for when we are waiting for idle.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc:
multaneously.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Any specific testcase where this helped?
Code itself does what the text says;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Techn
hould not matter, I wonder if this is covered well
enough in CI that we're confident to skip such writes?
Code is;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
__
dword from elsp submission (i.e. includes the group id as well as the
> context id). Include this check as well.
> v3: Only check against lrc_desc (as this contains the hw_id check)
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti..
On ma, 2017-01-23 at 09:57 +, Chris Wilson wrote:
> On Mon, Jan 23, 2017 at 11:41:12AM +0200, Joonas Lahtinen wrote:
> >
> > On la, 2017-01-21 at 14:50 +, Chris Wilson wrote:
> > >
> > > In order to reset the GPU early on in the module load sequence, we
Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
Ditto.
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahti
Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahti
wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas La
.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
__
.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
This is on par with the current trend.
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahti
it's well isolated to one patch, so should make bisecting easier
during testing;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx ma
helper.free_work);
> + WARN_ON(!llist_empty(_priv->atomic_helper.free_list));
Maybe make this while(!llist_empty) flush_work() to begin with? There's
exactly no locking in place to prevent that from happening?
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards,
(base == 0 || add_overflows(base, ggtt->stolen_size))
Looks good.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Convert all scripts to use /bin/sh shebang and fix all shellcheck
reported problems.
Signed-off-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc: Petri Latvala <petri.latv...@intel.com>
Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
Cc: Jani Nikula <jani.nik...@
ARLY_SDV(dev_priv) ||
> - IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> + bool pre = false;
> +
> + pre |= IS_HSW_EARLY_SDV(dev_priv);
> + pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
Did you compare the asm with "pre = pre || ..."?
Reviewed-by: Joonas
;
Correct use of taint flags. I think CPU_OUT_OF_SPEC could be more
correct flag, though?
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
In
i <rodrigo.v...@intel.com>
> Cc: Jani Nikula <jani.nik...@intel.com>
> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
ient barriers between the execution and the assert in retirement.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Inte
_stolen_to_dma(struct
> drm_i915_private *dev_priv)
> base = tom - tseg_size - ggtt->stolen_size;
> }
>
> - if (base == 0)
> + if (base == 0 || base + ggtt->stolen_size <= base)
range_overflows?
Regards, Joonas
--
Joonas Lahtinen
g count, u32
> value)
> +{
It smells like goto err; in this function.
> +}
Other than that, -EMAGIC, too many numbers and weakly named variables,
can't really follow the test.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
> + if (err == -EINTR && !signal_pending(current))
> + err = 0;
> + if (err)
> + break;
> + }
> +
> + if (WARN(err > 0 || err == -ENOTTY,
> + "%s returned %d, conflic
,
> + 0);
> + if (err) {
> + pr_err("i915_gem_gtt_insert (pass 1) failed at
> %llu/%llu with err=%d\n",
pass 3?
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
O
rs, but
regardless;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesk
this once already, but here goes;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https:/
;mika.kuopp...@intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
__
Reviewed-by: Jonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
gt; - if (IS_ERR(vma))
> + if (unlikely(IS_ERR(vma)))
> return vma;
I bet we have many spots similar to this, any ideas how we could get
some good code coverage testing data from the selftests? I think we
only now optimize when it appears during debugging some specific
problem.
son.co.uk>
> > + GEM_BUG_ON(vma->size > vm->total);
>
> Seconds thoughts, it is probably wiser to bail here with
> ERR_PTR(-E2BIG); We don't check in execbuf and this stops from having to
> write patch 2 as well.
I had similar thoughts, so slap my R-b for tha
On to, 2017-01-19 at 19:26 +, Chris Wilson wrote:
> Before moving the vma between the VM active/inactive lists, assert that
> the node is still allocated.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linu
On ma, 2017-02-20 at 13:12 +0100, Maarten Lankhorst wrote:
> Op 20-02-17 om 13:03 schreef Chris Wilson:
> >
> > On Mon, Feb 20, 2017 at 01:32:42PM +0200, Joonas Lahtinen wrote:
> > >
> > > Smells like a helper function? While that helper is finding t
t;
> Cc: Sumit Semwal <sumit.sem...@linaro.org>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
> @@ -151,6 +151,26 @@ reservation_object_lock(struct reservation_object *obj,
> }
>
> /**
> + * reserva
On ti, 2017-02-21 at 09:17 +, Chris Wilson wrote:
> Replace the calls to ww_mutex_lock(>lock) with the helper
> reservation_object_lock(resv) and similarly for unlock.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.
this must add:
>
> Fixes: 3c779a49bd7c ("drm/i915: Avoid BIT(max) - 1 and use GENMASK(max - 1,
> 0)")
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vet...@
wilson.co.uk>
> Cc: Matthew Auld <matthew.william.a...@gmail.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> +rotate_pages(struct drm_i915_gem_object *obj,
> + const struct intel_rotation_p
ash Goel <akash.g...@intel.com>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Matthew Auld <matthew.a...@intel.com>
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -3389,7 +3389,13 @@ int
}
> -
> + i915_gem_object_flush_to_display(obj);
.._flush_if_display() and this is
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel
original fix has been appropriate, when adding
stop_machine for a software bug :P
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing li
n.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
hris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
ht
m_clflush.h and use a new name, split out some
> extras into separate patches.
>
> Suggested-by: Akash Goel <akash.g...@intel.com>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc:
er requires us to copy it for
> > > the error state, or remember to lock it when reading (in case it used
> > > with 0600).
> > >
> > > v2: Use __always_inline and __builtin_strcmp
> > >
> > > Signed-off-by: Chris Wilson <ch...@chris-wilson.
On ke, 2017-02-22 at 09:41 +, Chris Wilson wrote:
> For use in the next patch, take the current is-coherent helper and add
> it to i915_gem_object.h
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.
n Gen8 production steppings, so we should be able to drop it entirely.
>
> Thanks,
> Daniele
Yeah, should be removed completely.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
I
Hi,
Seems like there were couple too many steps away from "just reordering
code", and indeed it's not working with GuC enabled, so have to spend
some time to see why.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel C
Patch title s/reeerve/reserve/.
On ke, 2017-02-22 at 11:45 +, Chris Wilson wrote:
> Move the companion functions next to each other.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joona
gt; Fixes: 8d28ba4568f4 ("drm/i915: Exercise filling the top/bottom portions of
> the ppgtt")
> Signed-off-by: Matthew Auld <matthew.a...@intel.com>
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
&g
ng the dev_priv as param)
> * fetch being the verb
> * uc_fw being the subject
>
> v2: settle on intel_uc_fetch_fw name (M. Wajdeczko)
>
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Michal Wajd
+err_relaychan:
> + guc_log_relay_channel_destroy(guc);
> +err_vaddr:
> > + i915_gem_object_unpin_map(guc->log.vma->obj);
> +
> > + return ret;
> }
> @@ -609,17 +615,24 @@ int i915_guc_log_control(struct drm_i915_private
> *dev_priv, u64 control_val)
>
ignal-on-any, we should not decompose as we must not wait on
> them all, just the first in *that* set.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> CC: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.u
roy(_priv->guc);
>
> OCD nitpick: i915_guc_log_unregister is not simmetric with
> i915_guc_log_register after this change, because intel_guc_log_destroy()
> is destroying the vma, which was not created by guc_log_late_setup().
Yeah, destroy should be hoisted to calling function.
turn false;
> }
You can drop the braces, too.
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On ke, 2017-02-15 at 18:28 -0800, Daniele Ceraolo Spurio wrote:
>
> On 14/02/17 05:53, Joonas Lahtinen wrote:
> >
> > Started adding proper teardown to guc_client_alloc, ended up removing
> > quite a few dead ends where errors communicating with the GuC were
> >
let's
> move it to 'intel_uc.c'.
>
> We can make a intel_uc_fw callback out of it, to avoid leaking it
> outside `intel_uc.c`
>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Michal Winiarski <michal.winiar...@intel.com>
> Signed-off-by: Arkadiusz Hiler
On ke, 2017-02-22 at 16:29 +0100, Arkadiusz Hiler wrote:
> On Wed, Feb 22, 2017 at 03:59:01PM +0200, Joonas Lahtinen wrote:
> >
> > > + * @huc: intel_huc struct
> > > *
> > > * Called early during driver load, but after GEM is initialised. The
> > &
p being named) aware that -1 have special meaning.
>
> Now the version cross-check looks like that:
>
> if (uc_fw->major_ver_found != uc_fw->major_ver_wanted ||
> uc_fw->minor_ver_found < uc_fw->minor_ver_wanted) {
What Chris proposed, together with tweaking th
mware pending, path %s\n", fw_path);
> guc->fw.fetch(dev_priv, >fw);
This was function pointer was discussed in other thread.
With above addressed;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
's so
convoluted), but it's in the better direction (and it was previously
so).
+++ b/drivers/gpu/drm/i915/intel_uc.h
> @@ -29,6 +29,8 @@
> #include "intel_ringbuffer.h"
>
> #include "i915_vma.h"
> +/* WaEnableGuCBootHashCheckNotSet:skl,bxt */
> +#defin
iniar...@intel.com>
> Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Ah, you already had this patch :)
Reviewed-by: Joonas Lahtinen <joo
quot; there's EXPORT_SYMBOL (which is not needed
here).
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.o
i915_reset(req->i915);
I'm no the expert here, but this reads funnily; "if reset in progress,
do reset".
This was pre-existing code, so;
Reviewed-by: Joonas Lahtinen <joonas.laht...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel
x.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
rt GVT code as well.
>
> v8:
> * Rename *out++ to *cs++.
>
> v9:
> * Fix GVT out to cs conversion in GVT.
>
> v10:
> * Rebase for new intel_ring_begin in selftests.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Cc: Chris Wilson <ch...
ng->anything->i915...
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.fr
: d8fc70b7367b ("drm/i915: Make power domain masks 64 bit long")
> Cc: Jani Nikula <jani.nik...@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
> Cc: Ville Syrjälä <ville.syrj...@linux.in
t, request);
>
> list_add_tail(>ring_link, >request_list);
> request->emitted_jiffies = jiffies;
>
> - i915_gem_mark_busy(engine);
> + if (!request->i915->gt.active_requests++)
> + i915_gem_mark_busy(engine);
This kinda hides the
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@
deep into the low-level functions it'll be more difficult
> to do any reworks in the future.
Indeed, the ctx_index should move. I'd like to keep it __ prefixed
function, because the client needs the desc updated for the function to
be meaningful.
So I'll make it __guc_
symmetry/proximity (Michal/Daniele)
- Fix __reserve_doorbell accounting for high priority (Daniele)
- Call __update_doorbell_desc! (Daniele)
- Isolate __guc_{,de}allocate_doorbell (Michal/Daniele)
Signed-off-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc:
On pe, 2017-02-10 at 14:36 +, Chris Wilson wrote:
> On Fri, Feb 10, 2017 at 03:30:10PM +0200, Joonas Lahtinen wrote:
> >
> > +static unsigned long __reserve_cacheline(struct intel_guc* guc)
> > {
> > - const uint32_t cacheline_size = cache_line_size
On pe, 2017-02-10 at 11:55 -0800, Daniele Ceraolo Spurio wrote:
>
> On 10/02/17 05:30, Joonas Lahtinen wrote:
> > +static bool __test_doorbell(struct i915_guc_client *client)
> > +{
> > + return test_bit(client->doorbell_id, client->guc->doorbell_bitmap);
On pe, 2017-02-10 at 16:11 +0100, Michal Wajdeczko wrote:
> On Fri, Feb 10, 2017 at 03:30:10PM +0200, Joonas Lahtinen wrote:
> >
> > Started adding proper teardown to guc_client_alloc, ended up removing
> > quite a few dead ends where errors communicating with the GuC were
on <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
ht
vrtko Ursulin <tvrtko.ursu...@linux.intel.com>
I already did, but here goes again;
Acked-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On ke, 2017-02-08 at 18:18 -0800, Michel Thierry wrote:
> Bring the test/set/clear bit functions we have into a single place.
>
> Signed-off-by: Michel Thierry <michel.thie...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
On ke, 2017-02-08 at 18:18 -0800, Michel Thierry wrote:
> igt_core must be really important, but no need to do it twice.
>
> Signed-off-by: Michel Thierry <michel.thie...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas
t; + wmb();
> + i915_gem_object_unpin_map(request[id]->batch->obj);
recursive_batch_release()
With the helper;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Ce
istency with BIT()
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On to, 2017-02-02 at 09:08 +, Chris Wilson wrote:
> Primarily to emphasize the difference between just advancing the
> breadcrumb using a bare request and the overhead of dispatching an
> execbuffer.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewe
small <-> large
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Code is more understandable now;
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
__
On ke, 2017-02-08 at 18:18 -0800, Michel Thierry wrote:
> Keeping macros names unique. We'll soon have a bit operations header
> file and BIT is already taken.
>
> Signed-off-by: Michel Thierry <michel.thie...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linu
On ke, 2017-02-08 at 18:18 -0800, Michel Thierry wrote:
> It will make sense once we use the BIT macro.
>
> Signed-off-by: Michel Thierry <michel.thie...@intel.com>
Squash this to the later patch that actually uses these.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technolo
On to, 2017-02-02 at 09:09 +, Chris Wilson wrote:
> Use the live tests against the mock ppgtt for quick testing on all
> platforms of the VMA layer.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.inte
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On ke, 2017-02-08 at 18:18 -0800, Michel Thierry wrote:
> BIT macro already defined in the new bitops header.
>
> Signed-off-by: Michel Thierry <michel.thie...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
O
tel_ring_emit(ring, MI_ARB_ON_OFF | MI_ARB_DISABLE);
> + *out++ = MI_ARB_ON_OFF | MI_ARB_DISABLE;
I expressed my concern in the previous iteration of this series months
ago, and here goes again; Lets try to keep the writes easily greppable.
So intel_ring_emit (or better name)
tel.com>
> +++ b/.gitignore
> @@ -81,6 +81,7 @@ core
> *.swo
> *.swp
> *.dirstamp
> +.*
You need to at least have "!.gitignore" to avoid ignoring further
changes :)
Regards, Joonas
> cscope.*
> TAGS
> build-au
*ctx_pool_vma;
s/ctx_pool_vma/ctx_pool/ would bring out the dependency explicitly.
> + void *ctx_pool_vaddr;
> struct ida ctx_ids;
>
> struct i915_guc_client *execbuf_client;
This needs a rebase on top of my cleanup, but is very welcome
improvement.
The types of variable
;
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gf
functions, which are then be
called from central point where more can be added, without changing the
existing ones. So this applies to intel_uc_init, too.
It'll be easier to add these generic functions iff we start repeating
calls to a bunch of functions, and we can then see patterns emerging.
Re
i?id=92448
> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
Explanation makes sense, only Google hits seem to be on Mesa detecting
the feature and later, removing the detection when unused.
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
J
801 - 900 of 2892 matches
Mail list logo
