Hey,
On 31-07-14 20:58, Jesse Barnes wrote:
Expose an ioctl to create Android fences based on the Android sync point
infrastructure (which in turn is based on DMA-buf fences). Just a
sketch at this point, no testing has been done.
There are a couple of goals here:
1) allow applications
op 05-08-14 01:18, Jesse Barnes schreef:
Expose an ioctl to create Android fences based on the Android sync point
infrastructure (which in turn is based on DMA-buf fences). Just a
sketch at this point, no testing has been done.
There are a couple of goals here:
1) allow applications and
op 05-08-14 16:59, Jesse Barnes schreef:
On Tue, 5 Aug 2014 09:44:00 +0200
Daniel Vetter dan...@ffwll.ch wrote:
On Tue, Aug 5, 2014 at 1:18 AM, Jesse Barnes jbar...@virtuousgeek.org
wrote:
+#define DRM_IOCTL_I915_GEM_FENCE DRM_IOWR
(DRM_COMMAND_BASE +
Op 30-07-13 10:13, Chris Wilson schreef:
On Tue, Jul 30, 2013 at 03:04:22PM +1000, Dave Airlie wrote:
Hey,
so I put a patch into intel driver a while ago to avoid doing a bo
flush using map/unmap for output slave device if the kernel has vmap
flushing
However on reflection I realised this
with the duct-tape
approach for now.
Cc: Chris Wilson ch...@chris-wilson.co.uk
Reported-by: Maarten Lankhorst maarten.lankho...@canonical.com
Cc: Maarten Lankhorst maarten.lankho...@canonical.com
Tested-by: Armin K. kre...@email.com (v1)
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
Acked
, but other than that it looks to be a reasonably self-contained w/a
for this perplexing problem.
Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
-Chris
And completely wrong, version I pushed to ubuntu's xorg-server for comparison:
8--
Nacked-by: Maarten Lankhorst maarten.lankho
Hey,
Op 19-03-13 11:27, Chris Wilson schreef:
On Tue, Mar 19, 2013 at 11:02:14AM +0100, Maarten Lankhorst wrote:
Hey,
Op 19-03-13 10:21, Chris Wilson schreef:
On Mon, Mar 18, 2013 at 01:51:44PM -0700, Bryce Harrington wrote:
Update: Squashes a couple commits to avoid potential hang if
git
Op 19-03-13 12:10, Dave Airlie schreef:
Because of the delayed fput in recent kernels, it is possible for plymouth
to exit and not drop master right away.
It's put onto a workqueue to be freed slightly later. Xorg-server starts in
the meantime, opens a fd, but because the fd
hasn't been
Hey,
Op 19-03-13 22:13, Chris Wilson schreef:
On Tue, Mar 19, 2013 at 11:50:47AM +0100, Maarten Lankhorst wrote:
The drmSetMaster call is needed, but the spinning is really just waiting for
the workqueue to run.
bryce's patch never worked, it just caused it to try drmsetinterfaceversion
Op 20-03-13 09:40, Maarten Lankhorst schreef:
Hey,
Op 19-03-13 22:13, Chris Wilson schreef:
On Tue, Mar 19, 2013 at 11:50:47AM +0100, Maarten Lankhorst wrote:
The drmSetMaster call is needed, but the spinning is really just waiting
for the workqueue to run.
bryce's patch never worked
For those who want to run valgrind, but do not necessarily want to debug intel.
:-)
---
diff --git a/configure.ac b/configure.ac
index de3990d..e084e84 100644
--- a/configure.ac
+++ b/configure.ac
@@ -440,12 +440,12 @@ AM_CONDITIONAL(FULL_DEBUG, test x$DEBUG = xfull)
if test x$DEBUG = xno; then
Op 12-09-13 17:06, Peter Zijlstra schreef:
Hi Dave,
So I'm poking around the preemption code and stumbled upon:
drivers/gpu/drm/i915/i915_gem.c:set_need_resched();
drivers/gpu/drm/ttm/ttm_bo_vm.c:set_need_resched();
drivers/gpu/drm/ttm/ttm_bo_vm.c:
Op 12-09-13 17:36, Daniel Vetter schreef:
On Thu, Sep 12, 2013 at 5:06 PM, Peter Zijlstra pet...@infradead.org wrote:
So I'm poking around the preemption code and stumbled upon:
drivers/gpu/drm/i915/i915_gem.c:set_need_resched();
drivers/gpu/drm/ttm/ttm_bo_vm.c:
Op 12-09-13 18:44, Thomas Hellstrom schreef:
On 09/12/2013 05:45 PM, Maarten Lankhorst wrote:
Op 12-09-13 17:36, Daniel Vetter schreef:
On Thu, Sep 12, 2013 at 5:06 PM, Peter Zijlstra pet...@infradead.org
wrote:
So I'm poking around the preemption code and stumbled upon:
drivers/gpu/drm
Op 13-09-13 08:44, Thomas Hellstrom schreef:
On 09/12/2013 11:50 PM, Maarten Lankhorst wrote:
Op 12-09-13 18:44, Thomas Hellstrom schreef:
On 09/12/2013 05:45 PM, Maarten Lankhorst wrote:
Op 12-09-13 17:36, Daniel Vetter schreef:
On Thu, Sep 12, 2013 at 5:06 PM, Peter Zijlstra pet
Op 13-09-13 09:46, Thomas Hellstrom schreef:
On 09/13/2013 09:16 AM, Maarten Lankhorst wrote:
Op 13-09-13 08:44, Thomas Hellstrom schreef:
On 09/12/2013 11:50 PM, Maarten Lankhorst wrote:
Op 12-09-13 18:44, Thomas Hellstrom schreef:
On 09/12/2013 05:45 PM, Maarten Lankhorst wrote:
Op 12-09
Op 13-09-13 10:23, Thomas Hellstrom schreef:
On 09/13/2013 09:51 AM, Maarten Lankhorst wrote:
Op 13-09-13 09:46, Thomas Hellstrom schreef:
On 09/13/2013 09:16 AM, Maarten Lankhorst wrote:
Op 13-09-13 08:44, Thomas Hellstrom schreef:
On 09/12/2013 11:50 PM, Maarten Lankhorst wrote:
Op 12-09
Hey,
Op 13-09-13 11:00, Peter Zijlstra schreef:
On Fri, Sep 13, 2013 at 10:41:54AM +0200, Daniel Vetter wrote:
On Fri, Sep 13, 2013 at 10:29 AM, Peter Zijlstra pet...@infradead.org
wrote:
On Fri, Sep 13, 2013 at 09:46:03AM +0200, Thomas Hellstrom wrote:
if (!bo_tryreserve()) {
up_read
Op 24-09-13 11:03, Thomas Hellstrom schreef:
On 09/24/2013 09:34 AM, Maarten Lankhorst wrote:
Op 24-09-13 09:22, Thomas Hellstrom schreef:
On 09/23/2013 05:33 PM, Maarten Lankhorst wrote:
Hey,
Op 13-09-13 11:00, Peter Zijlstra schreef:
On Fri, Sep 13, 2013 at 10:41:54AM +0200, Daniel Vetter
Op 24-09-13 12:33, Thomas Hellstrom schreef:
On 09/24/2013 12:11 PM, Maarten Lankhorst wrote:
Op 24-09-13 11:36, Daniel Vetter schreef:
On Tue, Sep 24, 2013 at 11:03:37AM +0200, Thomas Hellstrom wrote:
On 09/24/2013 09:34 AM, Maarten Lankhorst wrote:
Op 24-09-13 09:22, Thomas Hellstrom
Allocate and copy all kernel memory before doing reservations. This prevents a
locking
inversion between mmap_sem and reservation_class, and allows us to drop the
trylocking
in ttm_bo_vm_fault without upsetting lockdep.
Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com
---
diff
op 08-10-13 16:33, Jerome Glisse schreef:
On Tue, Oct 08, 2013 at 04:14:40PM +0200, Maarten Lankhorst wrote:
Allocate and copy all kernel memory before doing reservations. This prevents
a locking
inversion between mmap_sem and reservation_class, and allows us to drop the
trylocking
, schrieb Jerome Glisse:
On Tue, Oct 08, 2013 at 04:14:40PM +0200, Maarten Lankhorst wrote:
Allocate and copy all kernel memory before doing reservations. This
prevents a locking
inversion between mmap_sem and reservation_class, and allows us to drop
the trylocking
in ttm_bo_vm_fault without
On 03-12-14 20:49, Jesse Barnes wrote:
Expose an ioctl to create Android fences based on the Android sync point
infrastructure (which in turn is based on DMA-buf fences). Just a
sketch at this point, no testing has been done.
There are a couple of goals here:
1) allow applications and
Hey,
On 14-01-15 15:09, Tvrtko Ursulin wrote:
Hi,
On 12/03/2014 07:49 PM, Jesse Barnes wrote:
From: Maarten Lankhorst maarten.lankho...@canonical.com
This allows users of dma fences to create a android fence.
I couldn't figure out the motivation here vs. just exporting
Op 28-01-15 om 13:54 schreef Sumit Semwal:
At present, dma_buf_export() takes a series of parameters, which
makes it difficult to add any new parameters for exporters, if required.
Make it simpler by moving all these parameters into a struct, and pass
the struct * as parameter to
Assume the function is locked with drm_modeset_lock_all for now.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
Changes since RFC v1:
- Get rid of the crtc-state-active assignment in intel_crtc_control,
it caused the whole state to be confused.
- Convert some places
This kills off most of the transitional sers and uses atomic plane updates
in the modeset path to update everything.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
Changes since v1:
- Add atomic and sprite planes during a modeset too so they
will be restored.
- Drop
No need to repeatedly call update_watermarks, or update_fbc.
For update_watermarks once should be enough after disabling crtc's
and swapping the state.
Down to a single call to update_watermarks in .crtc_enable
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
There is no v1
Op 17-04-15 om 21:22 schreef Dave Gordon:
On 07/04/15 12:18, Maarten Lankhorst wrote:
Hey,
Op 07-04-15 om 12:59 schreef John Harrison:
On 07/04/2015 10:18, Maarten Lankhorst wrote:
Hey,
Op 20-03-15 om 18:48 schreef john.c.harri...@intel.com:
From: John Harrison john.c.harri...@intel.com
From: Maarten Lankhorst maarten.lankho...@linux.intel.com
Now that the dpll updates are (mostly) atomic, the .off() code is no longer
used,
and there are no more callers for intel_put_shared_dpll. Move all the updates
done in intel_crtc_disable to intel_modeset_update_state, one less special
changed flags
as the commit that actually triggers the regression.
Cc: Matt Roper matthew.d.ro...@intel.com
Cc: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
Reported-and-Tested-by: Kenneth Graunke kenn...@whitecape.org
Signed-off-by: Maarten Lankhorst maarten.lankho
Removed some occurences, roughly based on where the errors of
removing crtc-config occured. Because it's used a lot in this
file the changes are done in passes.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 205
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
A follow up patch will make intel_modeset_compute_config() deal with
multiple crtcs, so move crtc specific stuff into the lower level crtc
specific function.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
crtc-config is gone, swap swap swap. :D
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_atomic.c | 36 ++--
drivers/gpu/drm/i915/intel_display.c | 7 +--
2 files changed, 7 insertions(+), 36 deletions
This is now unused, goodbye. :-)
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 2 --
drivers/gpu/drm/i915/intel_drv.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm
drm_atomic_helper_swap_state up.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
drivers/gpu/drm/i915/intel_display.c | 106 +++
drivers/gpu/drm/i915/intel_drv.h | 1 -
3 files changed, 19 insertions(+), 89
This prevents unnecessarily updating power domains, while still
enabling all power domains on initial setup.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 52
1 file changed, 41 insertions(+), 11
-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/drm_atomic.c | 91
include/drm/drm_atomic.h | 4 ++
include/drm/drm_crtc.h | 4 ++
3 files changed, 74 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm
This removes a lot of users for crtc-config.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_crt.c | 21 ++
drivers/gpu/drm/i915/intel_ddi.c | 78 +---
drivers/gpu/drm/i915/intel_display.c | 36
This should be safe.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 82 ++--
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_ddi.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index c5a9e36d6a0e..388f02a8e6e1 100644
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_psr.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 5ee0fa57ed19
No longer any different from state-enable.
v2: Keep track of enabled crtc's for calling intel_crtc_restore_mode.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 63 +++-
drivers/gpu/drm/i915
...@intel.com
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_atomic.c | 22 +--
drivers/gpu/drm/i915/intel_display.c | 311 ---
drivers/gpu/drm/i915/intel_drv.h | 3 +
3 files changed, 230 insertions(+), 106
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c
b/drivers/gpu/drm/i915/intel_audio.c
index c4312177b0ee..dd74fd3157ee 100644
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 18 --
drivers/gpu/drm/i915/intel_display.c | 68 +---
drivers/gpu/drm/i915/intel_drv.h | 1 -
3 files changed, 39 insertions(+), 48 deletions
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_hdmi.c | 58 +++
1 file changed, 35 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu/drm/i915/intel_hdmi.c
index
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_dp_mst.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c
b/drivers/gpu/drm/i915/intel_dp_mst.c
index 4992c8025520..4ecbc58c4e04 100644
, and this is not handled correctly otherwise.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_atomic_plane.c | 59 ++-
drivers/gpu/drm/i915/intel_display.c | 655 ++
drivers/gpu/drm/i915/intel_drv.h | 2 +-
drivers
Convert the rest of the file, but remove crtc-config in a separate
commit to hopefully allow easier bisecting.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 351 ++-
drivers/gpu/drm/i915/intel_dp.c
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/i915_drv.h | 3 +-
drivers/gpu/drm/i915/intel_display.c | 207 ++-
drivers/gpu/drm/i915/intel_dp.c | 2 +
drivers/gpu/drm/i915/intel_drv.h | 10
Don't walk the crtc_state twice if there's no need for it.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
It makes more sense there, since these are computation steps that can
fail.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 70
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_pm.c | 96 -
1 file changed, 46 insertions(+), 50 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index eda1b22c3111
: Make __intel_set_mode() take only atomic state as argument
drm/i915: Use global atomic state for staged pll config
drm/i915: Support modeset across multiple pipes
drm/i915: Move cdclk and pll setup to intel_modeset_compute_config()
drm/i915: Read hw state into an atomic state struct
Maarten
Assume the function is locked with drm_modeset_lock_all for now.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/i915_irq.c | 2 +-
drivers/gpu/drm/i915/intel_display.c | 79 ++--
2 files changed, 50 insertions
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_overlay.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_overlay.c
b/drivers/gpu/drm/i915/intel_overlay.c
index 5fd2d5ac02e2..fa0ff6974dcc
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_fbc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 6abb83432d4d..098461ce1fe4 100644
No need to repeatedly call update_watermarks, or update_fbc.
For update_watermarks once should be enough after disabling crtc's
and swapping the state.
Down to a single call to update_watermarks in .crtc_enable
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu
Must start somewhere to get rid of crtc-config.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/i915_irq.c | 13 ++---
drivers/gpu/drm/i915/intel_display.c | 6 ++
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git
Done as a separate commit to allow better bisecting.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 50 +---
1 file changed, 7 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/i915
Another abuser gone.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 42 -
1 file changed, 27 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_fbdev.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
b/drivers/gpu/drm/i915/intel_fbdev.c
index 4e7e7da2e03b
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 15 ---
drivers/gpu/drm/i915/intel_drv.h | 5 -
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_dsi.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 3f28b046751b..ec5f4509dc87 100644
for the atomic state.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index
Small behavioral change: DPLL_DVO_2X_MODE may stay enabled during modeset
for I830 if new state requires it, instead of being disabled and enabled
again.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 140
crtc.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 108 +++
1 file changed, 45 insertions(+), 63 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 16 +---
drivers/gpu/drm/i915/intel_drv.h | 6 --
2 files changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_sdvo.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c
b/drivers/gpu/drm/i915/intel_sdvo.c
index 6a68098f8b08..93b31d66a1ab
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
drivers/gpu/drm/i915/intel_atomic.c | 49
drivers/gpu/drm/i915/intel_display.c | 111
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_atomic.c | 10 +++---
drivers/gpu/drm/i915/intel_sprite.c | 4 ++--
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_atomic.c
b/drivers/gpu/drm/i915
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 109 +--
drivers/gpu/drm/i915/intel_drv.h | 2 +
2 files changed, 81 insertions(+), 30 deletions(-)
diff --git a/drivers/gpu/drm/i915
There are cases where we want to test if a given object is
part of the state, but don't want to add them if they're not.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/drm_atomic.c | 18 +++-
include/drm/drm_atomic.h | 50
the
previous state.
As a nice bonus this kills off encoder-new_encoder,
connector-new_enabled and crtc-new_enabled. They were used only
to restore the state after a modeset.
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan.de.olive...@intel.com
Signed-off-by: Maarten Lankhorst
to haswell.
- Use first loop to iterate over newly enabled crtc's only.
This increases readability.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 100 ---
drivers/gpu/drm/i915/intel_drv.h | 3
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
It makes more sense there, since these are computation steps that can
fail.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 70
intel_crtc-config will be removed eventually, so use crtc-hwmode.
drm_atomic_helper_update_legacy_modeset_state updates hwmode,
but crtc-active will eventually be gone too. Set dotclock to zero
to indicate the crtc is inactive.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
This is useful when calculating vblank in drivers that support it.
During a modeset the atomic state may not match the hardware state,
so if the driver wants to wait on a vblank they'll want to use
crtc-hwmode rather than crtc-state-adjusted_mode.
Signed-off-by: Maarten Lankhorst maarten.lankho
Now that the helper is exported there's no need to duplicate
this code any more.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 61 +++-
1 file changed, 4 insertions(+), 57 deletions(-)
diff --git
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
A follow up patch will make intel_modeset_compute_config() deal with
multiple crtcs, so move crtc specific stuff into the lower level crtc
specific function.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
crtc-config is a pointer to the current crtc-state, and will be
removed eventually. Same for crtc-active, instead use crtc-state-active.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 42 -
1 file
-active.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 18 --
drivers/gpu/drm/i915/intel_display.c | 64 +---
drivers/gpu/drm/i915/intel_drv.h | 1 -
3 files changed, 37 insertions(+), 46
ander.conselvan.de.olive...@intel.com
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index c6277a4a1f2f..cd1b16b25716 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -30,7
Op 13-05-15 om 22:23 schreef Maarten Lankhorst:
This is useful when calculating vblank in drivers that support it.
During a modeset the atomic state may not match the hardware state,
so if the driver wants to wait on a vblank they'll want to use
crtc-hwmode rather than crtc-state-adjusted_mode
Op 18-05-15 om 17:45 schreef Daniel Vetter:
On Wed, May 13, 2015 at 10:23:41PM +0200, Maarten Lankhorst wrote:
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
Now that we can subclass drm_atomic_state we can also use it to keep
track of all the pll settings
Op 18-05-15 om 17:36 schreef Daniel Vetter:
On Wed, May 13, 2015 at 10:23:38PM +0200, Maarten Lankhorst wrote:
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
A follow up patch will make intel_modeset_compute_config() deal with
multiple crtcs, so move crtc specific
Op 18-05-15 om 17:30 schreef Daniel Vetter:
On Wed, May 13, 2015 at 10:23:37PM +0200, Maarten Lankhorst wrote:
crtc_state-enable means a crtc is configured, but it may be turned
off for dpms. Until the previous commit crtc_state-active was not
updated on crtc off, but now that we do we should
Op 11-05-15 om 19:11 schreef Daniel Vetter:
On Mon, May 11, 2015 at 04:24:40PM +0200, Maarten Lankhorst wrote:
@@ -6079,26 +6059,29 @@ void intel_crtc_control(struct drm_crtc *crtc, bool
enable)
enum intel_display_power_domain domain;
unsigned long domains;
+if (enable
Op 11-05-15 om 19:28 schreef Daniel Vetter:
On Mon, May 11, 2015 at 04:24:42PM +0200, Maarten Lankhorst wrote:
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
Same comment about the terse commit message as in the previous patch.
---
drivers/gpu/drm/i915/intel_display.c
Op 12-05-15 om 08:59 schreef Daniel Vetter:
On Mon, May 11, 2015 at 04:24:45PM +0200, Maarten Lankhorst wrote:
This should be safe.
Usual request: A few more details about what you've changed to help guide
the review would be great. E.g. which functions from the atomic helpers
you're trying
Op 11-05-15 om 19:00 schreef Daniel Vetter:
On Mon, May 11, 2015 at 04:24:39PM +0200, Maarten Lankhorst wrote:
This prevents unnecessarily updating power domains, while still
enabling all power domains on initial setup.
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
Op 18-05-15 om 18:28 schreef Ville Syrjälä:
On Mon, May 18, 2015 at 05:49:23PM +0200, Daniel Vetter wrote:
On Wed, May 13, 2015 at 10:23:46PM +0200, Maarten Lankhorst wrote:
intel_crtc-config will be removed eventually, so use crtc-hwmode.
drm_atomic_helper_update_legacy_modeset_state updates
Op 12-05-15 om 12:11 schreef Daniel Vetter:
On Mon, May 11, 2015 at 04:25:10PM +0200, Maarten Lankhorst wrote:
Removed some occurences, roughly based on where the errors of
removing crtc-config occured. Because it's used a lot in this
file the changes are done in passes.
Signed-off
Op 12-05-15 om 11:43 schreef Daniel Vetter:
On Mon, May 11, 2015 at 04:25:08PM +0200, Maarten Lankhorst wrote:
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 109
+--
drivers/gpu/drm/i915
Op 12-05-15 om 12:03 schreef Daniel Vetter:
On Mon, May 11, 2015 at 4:25 PM, Maarten Lankhorst
maarten.lankho...@linux.intel.com wrote:
@@ -11953,16 +11930,14 @@ check_shared_dpll_state(struct drm_device *dev)
for_each_intel_crtc(dev, crtc) {
if (crtc
Op 12-05-15 om 15:03 schreef Daniel Vetter:
On Mon, May 11, 2015 at 04:25:13PM +0200, Maarten Lankhorst wrote:
crtc-config is gone, swap swap swap. :D
Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com
---
drivers/gpu/drm/i915/intel_atomic.c | 36
Op 12-05-15 om 15:29 schreef Daniel Vetter:
This is useful for drivers which have their own modeset infrastructure
but want to reuse most of the legacy state frobbery from the helpers.
i915 wants this.
Cc: Maarten Lankhorst maarten.lankho...@linux.intel.com
Signed-off-by: Daniel Vetter
1 - 100 of 5249 matches
Mail list logo
