[Intel-gfx] [v2] drm/i915/tgl: Add Wa_1606054188:tgl

2020-01-31 Thread Matt Atwood
On Tiger Lake we do not support source keying in the pixel formats P010, P012, P016. v2: Move WA to end of function. Create helper function for format check. Less verbose debugging messaging. Bspec: 52890 Cc: Matt Roper Cc: Manasi Navare CC: Ville Syrjälä Signed-off-by: Matt Atwood

[Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl

2020-01-31 Thread Matt Atwood
On Tiger Lake we do not support source keying in the pixel formats P010, P012, P016. v2: Move WA to end of function. Create helper function for format check. Less verbose debugging messaging. v3: whitespace Bspec: 52890 Cc: Matt Roper Cc: Manasi Navare CC: Ville Syrjälä Signed-off-by: Matt

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Implement Wa_1606931601

2020-02-07 Thread Matt Atwood
. > - Rename register definitions with TGL_ prefix > v4: Bspec changed. Again. Add WA to rcs_ WA list. > > Cc: Daniele Ceraolo Spurio > Cc: Matt Roper See whitespace fix, Reviewed-by: Matt Atwood > Signed-off-by: Anusha Srivatsa > --- > drivers/gpu/drm/i915/gt/intel_work

[Intel-gfx] [PATCH] drm/i915/gt/tgl: implement Wa_1409085225

2020-02-18 Thread Matt Atwood
Disable Push Constant buffer addition for A0, which can cause FIFO underruns. Fix a minor white space issue while we're here. Bspec: 52890 Cc: Rafael Antognolli Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 ++ drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1409085225, Wa_14010229206

2020-02-20 Thread Matt Atwood
Disable Push Constant buffer addition for TGL. v2: typos, add additional Wa reference v3: use REG_BIT macro, move to rcs_engine_wa_init, clean up commit message. Bspec: 52890 Cc: Rafael Antognolli Cc: Matt Roper Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5

[Intel-gfx] [PATCH 1/2] drm/i915: Extend Wa_1606931601 for all steppings.

2020-02-20 Thread Matt Atwood
From: Anusha Srivatsa According to BSpec. Wa_1606931601 applies for all TGL steppings.This patch moves the WA implementation out of A0 only block of rcs_engine_wa_init(). The WA is has also been referred to by an alternate name Wa_1607090982. Bspec: 46045,52890 Fixes: 3873fd1a43c7 ("drm/i915:

[Intel-gfx] [PATCH] drm/i915/tgl: add Wa_1409085225, Wa_14010229206

2020-02-19 Thread Matt Atwood
Disable Push Constant buffer addition, which can cause FIFO underruns. Fix a minor white space issue while we're here. v2: typos, add additional Wa reference Bspec: 52890 Cc: Rafael Antognolli Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 9 + drivers

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Program MBUS with rmw during initialization

2020-02-20 Thread Matt Atwood
few specific bits. > > Bspec: 49213 > Bspec: 50096 > Fixes: 4cb4585e5a7f ("drm/i915/icl: initialize MBus during display init") > Cc: Stanislav Lisovskiy Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display_po

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Program MBUS_ABOX{1, 2}_CTL during display init

2020-02-20 Thread Matt Atwood
2: > - Program registers with rmw to preserve contents of unrelated bits. > - Switch to the new display uncore helpers. > > Bspec: 49213 > Bspec: 50096 > Cc: Stanislav Lisovskiy Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/display/int

[Intel-gfx] [PATCH v2] drm/i915: add Wa_14010594013: icl,ehl

2020-01-13 Thread Matt Atwood
The bspec tells us we need to set this bit to avoid potential underruns. v2: use new register write convention (Anshuman) add bspec 7386 ref. Bspec: 7386 Bspec: 33450 Bspec: 33451 Cc: Anshuman Gupta Reviewed-by: Rodrigo Vivi Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/i915_reg.h | 1

[Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl

2020-01-16 Thread Matt Atwood
On Tiger Lake we do not support source keying in the pixel formats P010, P012, P016. Bspec: 52890 Cc: Matt Roper Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/display/intel_sprite.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH] drm/i915: add Wa_14010594013: icl,ehl

2020-01-09 Thread Matt Atwood
The bspec tells us we need to set this bit to avoid potential underruns. Bspec: 33450 Bspec: 33451 Bspec: 33452 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915/tgl: Wa_14011059788

2020-04-15 Thread Matt Atwood
Reflect recent Bspec changes Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/intel_pm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index b632b6bb9c3e..30b45c0de6fb 100644 --- a/drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH v2] drm/i915/tgl: Wa_14011059788

2020-04-15 Thread Matt Atwood
Reflect recent Bspec changes v2: fix whitespace, typo Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/intel_pm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index b632b6bb9c3e..3d12a0617c84 100644 --- a/drivers

Re: [Intel-gfx] [PATCH v2] drm/i915/icl: Update forcewake firmware ranges

2020-04-17 Thread Matt Atwood
tel/issues/1222 > > v2: Simplify the table and use 0 for some unused ranges(Matt) > > Cc: Matt Roper Reviewed-by: Matt Atwood > Signed-off-by: Radhakrishna Sripada > --- > drivers/gpu/drm/i915/intel_uncore.c | 31 - > 1 file changed, 17 inserti

[Intel-gfx] [PATCH] drm/i915/ehl: extended Wa_2006604312 to ehl

2020-04-13 Thread Matt Atwood
Reflect recent bspec changes. Bspec: 33451 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/display/intel_display.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index

[Intel-gfx] [PATCH] drm/i915/ehl: Wa_22010271021

2020-05-19 Thread Matt Atwood
Reflect recent Bspec changes. Bspec: 33451 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index 90a2b9e399b0

Re: [Intel-gfx] [PATCH] Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Matt Atwood
; > Let's try applying the HBR3 fix again. > > The link training failure still happens the same way on fi-icl-u2. Previously this only failed on a specific TGL CI system, did you get failures on both this go around? ICL passed last time. > > > > > > > This r

[Intel-gfx] [PATCH] drm/i915: Apply Wa_14011264657:gen11+

2020-08-12 Thread Matt Atwood
Add minimum width to planes, variable with specific formats for gen11+ to reflect recent bspec changes. Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/display/intel_display.c | 54 +--- 1 file changed, 46 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+"

2020-07-02 Thread Matt Atwood
The initial CI results did not include a TGL system which includes a panel that is having issues with patch. Revert while we triage. This reverts commit 680c45c767f63e35f063d3ea04f388a9f7ae7079. --- drivers/gpu/drm/i915/display/intel_dp.c | 28 +++-- 1 file changed, 17

[Intel-gfx] [PATCH v2] Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+"

2020-07-02 Thread Matt Atwood
The initial CI results did not include a TGL system which includes a panel that is having issues with patch. Revert while we triage. This reverts commit 680c45c767f63e35f063d3ea04f388a9f7ae7079. Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/display/intel_dp.c | 28

[Intel-gfx] [PATCH v2] drm/i915/dp: Correctly advertise HBR3 for GEN11+

2020-06-30 Thread Matt Atwood
. v2: Alter intel_dp_set_source_rates final position (Ville/Manasi). Remove outdated comment (Ville). Slight optimization of control flow in intel_dp_init_connector. Slight rewording in commit message. Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/display/intel_dp.c | 28

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1409371443

2020-06-25 Thread Matt Atwood
On Mon, Jun 01, 2020 at 06:49:10PM -0700, Aditya Swarup wrote: > Set GMBUS0 Pin Pair Select to 1 at boot and each FLR exit. > Return GMBUS0 Pin Pair Select to 1 after GMBUS transactions are done. > > Cc: Michal Wajdeczko > Cc: Piotr Piórkowski > Cc: Matt Roper > Cc: Jose Souza >

Re: [Intel-gfx] [PATCH] drm/i915: Extend Wa_14010685332 to all ICP+ PCH's

2020-06-25 Thread Matt Atwood
O Wed, Jun 17, 2020 at 11:00:06AM -0700, Matt Roper wrote: > This workaround now also applies to TGL and RKL, so extend the PCH test > to just capture everthing ICP and beyond. > > Signed-off-by: Matt Roper Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/i915_irq.c |

[Intel-gfx] [PATCH] drm/i915: implement Wa_14011508470;gen12

2020-06-24 Thread Matt Atwood
Update code to reflect recent bspec changes Bspec: 52890 Bspec: 53508 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/display/intel_display_power.c | 8 drivers/gpu/drm/i915/i915_reg.h| 6 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915/gt: Implement WA_1406941453

2020-06-24 Thread Matt Atwood
On Thu, Jun 11, 2020 at 04:31:08PM -0700, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > Enable HW Default flip for small PL. > > bspec: 52890 > bspec: 53508 > bspec: 53273 > > Signed-off-by: Clint Taylor Reviewed-by: Matt Atwood >

[Intel-gfx] [PATCH] drm/i915: Apply Wa_14011264657:gen11+

2020-06-16 Thread Matt Atwood
Add minimum width to planes, variable with specific formats, for gen11+. Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/display/intel_display.c | 55 +--- 1 file changed, 47 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers

Re: [Intel-gfx] [PATCH] drm/i915: Apply Wa_14011264657:gen11+

2020-06-16 Thread Matt Atwood
On Tue, Jun 16, 2020 at 07:39:09PM +0300, Ville Syrjälä wrote: > On Tue, Jun 16, 2020 at 09:34:06AM -0700, Matt Atwood wrote: > > Add minimum width to planes, variable with specific formats, for gen11+. > > How did this suddenly become gen11+? Wasn't it rkl only before? gen11

Re: [Intel-gfx] [PATCH] drm/i915: Apply Wa_14011264657:gen11+

2020-07-24 Thread Matt Atwood
On Tue, Jun 16, 2020 at 08:34:07PM +0300, Ville Syrjälä wrote: > On Tue, Jun 16, 2020 at 09:34:06AM -0700, Matt Atwood wrote: > > Add minimum width to planes, variable with specific formats, for gen11+. > > > > Signed-off-by: Matt Atwood > > --- > > drivers/gpu

Re: [Intel-gfx] [PATCH v3 22/30] drm/i915/dg2: Define MOCS table for DG2

2021-07-29 Thread Matt Atwood
On Fri, Jul 23, 2021 at 10:42:31AM -0700, Matt Roper wrote: > Bspec: 45101, 45427 > Cc: Ramalingam C (v5) > Signed-off-by: Matt Roper Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/gt/intel_mocs.c | 35 +++- > 1 file changed, 34 inserti

Re: [Intel-gfx] [PATCH v3 21/30] drm/i915/dg2: Report INSTDONE_GEOM values in error state

2021-07-29 Thread Matt Atwood
with gslice steering. > > Cc: Lionel Landwerlin > Signed-off-by: Matt Roper > Acked-by: Lionel Landwerlin Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c| 7 +++ > drivers/gpu/drm/i915/gt/intel_engine_types.h | 3 +++ > drivers/gpu/d

Re: [Intel-gfx] [PATCH v3 23/30] drm/i915/dg2: Add MPLLB programming for SNPS PHY

2021-07-29 Thread Matt Atwood
gt; the code in future patches. > > Bspec: 54032 > Bspec: 53881 > Cc: Lucas De Marchi > Signed-off-by: Matt Roper > Signed-off-by: Vandita Kulkarni > Signed-off-by: Jani Nikula > Signed-off-by: Nidhi Gupta Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/Makefile

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add workaround numbers to GEN7_COMMON_SLICE_CHICKEN1 whitelisting

2021-12-01 Thread Matt Atwood
José Roberto de Souza Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c > b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915: Implement Wa_1508744258"

2021-11-30 Thread Matt Atwood
58") > > So this can be propagated to older kernels, will add while applying. > > > > > Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/4145 > > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Atwood > > --- > > drivers/gpu/drm/i915/gt/i

Re: [Intel-gfx] [PATCH v2 09/50] drm/i915/xehp: Xe_HP forcewake support

2021-07-20 Thread Matt Atwood
y: Daniele Ceraolo Spurio > Signed-off-by: Stuart Summers > Signed-off-by: Matt Roper Reviewed-by: Matt Atwood > --- > .../drm/i915/gt/intel_execlists_submission.c | 4 + > drivers/gpu/drm/i915/intel_uncore.c | 336 +++--- > drivers/gpu/drm/i915/intel_un

Re: [Intel-gfx] [PATCH v2 12/50] drm/i915/xehp: New engine context offsets

2021-07-20 Thread Matt Atwood
> Signed-off-by: Venkata Ramana Nayana > Signed-off-by: Akeem G Abodunrin > Signed-off-by: Matt Roper Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 65 ++--- > 1 file changed, 59 insertions(+), 6 deletions(-) > > diff

Re: [Intel-gfx] [PATCH v2 08/50] drm/i915/xehp: Extra media engines - Part 3 (reset)

2021-07-20 Thread Matt Atwood
On Tue, Jul 13, 2021 at 08:14:58PM -0700, Matt Roper wrote: > From: John Harrison > > Xe_HP can have a lot of extra media engines. This patch adds the reset > support for them. > > Signed-off-by: John Harrison > Signed-off-by: Matt Roper Reviewed-by: Matt Atwood > ---

Re: [Intel-gfx] [PATCH v2 11/50] drm/i915/xehp: Handle new device context ID format

2021-07-20 Thread Matt Atwood
On Tue, Jul 13, 2021 at 08:15:01PM -0700, Matt Roper wrote: > From: Stuart Summers > > Xe_HP changes the format of the context ID from past platforms. > > Signed-off-by: Stuart Summers > Signed-off-by: Umesh Nerlige Ramappa > Signed-off-by: Matt Roper Rev

Re: [Intel-gfx] [PATCH v2 02/50] drm/i915: Fork DG1 interrupt handler

2021-07-19 Thread Matt Atwood
has_master_unit_irq feature flag with an IP version test. > > Bspec: 50875 > Cc: Daniele Spurio Ceraolo > Cc: Stuart Summers > Signed-off-by: Paulo Zanoni > Signed-off-by: Lucas De Marchi > Signed-off-by: Tomasz Lis > Signed-off-by: Matt Roper Reviewed-by: M

Re: [Intel-gfx] [PATCH v2 03/50] drm/i915/xehp: VDBOX/VEBOX fusing registers are enable-based

2021-07-19 Thread Matt Atwood
> To simplify things we do not add a new register definition but just stop > inverting the fusing masks before processing them. > > Bspec: 52615 > Cc: Daniele Ceraolo Spurio > Signed-off-by: Tvrtko Ursulin > Signed-off-by: Matt Roper > Reviewed-by: Lucas De Marchi Review

Re: [Intel-gfx] [PATCH v2 45/50] drm/i915/dg2: Classify DG2 PHY types

2021-07-16 Thread Matt Atwood
ot; PHY > units. As such, we don't want intel_phy_is_combo to take us down legacy > programming paths, so just return false from it on DG2. Instead add a > new intel_phy_is_snps() that will return true for all DG2 PHYs. > > Cc: Anusha Srivatsa > Cc: Matt Atwood > S

Re: [Intel-gfx] [PATCH v2 43/50] drm/i915/dg2: Add vswing programming for SNPS phys

2021-07-16 Thread Matt Atwood
On Tue, Jul 13, 2021 at 08:15:33PM -0700, Matt Roper wrote: > Vswing programming for SNPS PHYs is just a single step -- look up the > value that corresponds to the voltage level from a table and program it > into the SNPS_PHY_TX_EQ register. > > Bspec: 53920 > Cc: Matt At

Re: [Intel-gfx] [PATCH v2 46/50] drm/i915/dg2: Wait for SNPS PHY calibration during display init

2021-07-16 Thread Matt Atwood
On Tue, Jul 13, 2021 at 08:15:36PM -0700, Matt Roper wrote: > Initialization of the PHY is handled by the hardware/firmware, but the > driver should wait up to 25ms for the PHY to report that its calibration > has completed. > > Bspec: 49189 > Bspec: 50107 > Cc: Matt Atwood

Re: [Intel-gfx] [PATCH v2 42/50] drm/i915/dg2: Add MPLLB programming for HDMI

2021-07-16 Thread Matt Atwood
4032 > Cc: Matt Atwood > Signed-off-by: Matt Roper > Signed-off-by: Vandita Kulkarni Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 14 +- > drivers/gpu/drm/i915/display/intel_display.c | 47 +++ > drivers/gpu/drm/i915/display/intel_h

Re: [Intel-gfx] [PATCH 05/10] drm/i915/bios: Enable parse of two integrated panels eDP data

2021-07-27 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:33PM -0700, José Roberto de Souza wrote: > Continuing the conversion from single integrated VBT data to two, now > handling eDP data. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Atwood > -

Re: [Intel-gfx] [PATCH 06/10] drm/i915/bios: Enable parse of two integrated panels PSR data

2021-07-27 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:34PM -0700, José Roberto de Souza wrote: > Continuing the conversion from single integrated VBT data to two, now > handling PSR data. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Atwood > -

Re: [Intel-gfx] [PATCH 01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port()

2021-07-26 Thread Matt Atwood
ts to be parsed to be parsed like any other DDI > port. > This will be helpful to integrate into just one function the parse of > information about integrated panels(eDP and DSI). > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reviewed-by: Matt A

Re: [Intel-gfx] [PATCH 02/10] drm/i915/bios: Start to support two integrated panels

2021-07-26 Thread Matt Atwood
global > one. > Other VBT blocks will be converted in following patches. > > While at is also nucking lvds_dither as it is not used. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Atwood > --- > drivers/g

Re: [Intel-gfx] [PATCH 03/10] drm/i915/bios: Enable parse of two integrated panels timing data

2021-07-26 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:31PM -0700, José Roberto de Souza wrote: > Continuing the conversion from single integrated VBT data to two. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Review-by: Matt Atwood > --- > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 04/10] drm/i915/bios: Enable parse of two integrated panels backlight data

2021-07-26 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:32PM -0700, José Roberto de Souza wrote: > Continuing the conversion from single integrated VBT data to two, now > handling backlight data. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Atwood

Re: [Intel-gfx] [PATCH 01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port()

2021-07-26 Thread Matt Atwood
ts to be parsed to be parsed like any other DDI > port. > This will be helpful to integrate into just one function the parse of > information about integrated panels(eDP and DSI). > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reviewed-by: Matt A

Re: [Intel-gfx] [PATCH 10/10] drm/i915/display/tgl+: Use PPS index from vbt

2021-07-28 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:38PM -0700, José Roberto de Souza wrote: > Tigerlake and newer has two instances of PPS, to support up to two > eDP panels. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reveiwed-by: Matt Atwood > --- &g

Re: [Intel-gfx] [PATCH 09/10] drm/i915/bios: Only use opregion panel index for display ver 8 and older

2021-07-28 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:37PM -0700, José Roberto de Souza wrote: > On newer platform this opregion call always fails, also it do not > support multiple panels so dropping it. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Review

Re: [Intel-gfx] [PATCH 07/10] drm/i915/bios: Enable parse of two DSI panels data

2021-07-28 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:35PM -0700, José Roberto de Souza wrote: > Continuing the conversion from single integrated VBT data to two, now > handling DSI data. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Atwood > -

Re: [Intel-gfx] [PATCH 08/10] drm/i915/bios: Nuke panel_type

2021-07-28 Thread Matt Atwood
On Wed, Jul 21, 2021 at 10:43:36PM -0700, José Roberto de Souza wrote: > All the users was converted now we can drop it. > > Cc: Jani Nikula > Cc: Ville Syrjälä > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/disp

Re: [Intel-gfx] [PATCH 2/6] drm/i915/gt: Move SFC lock bits to intel_engine_regs.h

2022-02-15 Thread Matt Atwood
he driver. > after nit fix, Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_engine_regs.h | 17 + > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 19 --- > drivers/gpu/drm/i915/gt/intel_reset.c

Re: [Intel-gfx] [PATCH 1/6] drm/i915/gt: Drop duplicate register definition for VDBOX_CGCTL3F18

2022-02-15 Thread Matt Atwood
offset, drop the copy from intel_gt_regs.h > Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > b/drivers/gpu

Re: [Intel-gfx] [PATCH 3/6] drm/i915/gt: Use parameterized RING_MI_MODE

2022-02-15 Thread Matt Atwood
On Tue, Feb 08, 2022 at 09:11:37PM -0800, Matt Roper wrote: > We have both a parameterized RING_MI_MODE() macro and an RCS-specific > MI_MODE; drop the latter and use the former everywhere. > Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drive

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Use consistent offset notation in intel_gt_regs.h

2022-02-15 Thread Matt Atwood
On Tue, Feb 08, 2022 at 09:11:39PM -0800, Matt Roper wrote: > Switch all register offsets to use lowercase hex values for consistency. > Also strip any unnecessary leading 0's. For example, "_MMIO(0x0D08)" > becomes "_MMIO(0xd08)." > Reviewed-by: Matt Atw

Re: [Intel-gfx] [PATCH 4/6] drm/i915/gt: Cleanup spacing of intel_gt_regs.h

2022-02-15 Thread Matt Atwood
s too long, in which >case a single tab is used. > > Final diff for this patch is empty if whitespace is ignored: > > $ git diff -w > $ > Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h |

Re: [Intel-gfx] [PATCH 6/6] drm/i915/gt: Order GT registers by MMIO offset

2022-02-15 Thread Matt Atwood
> A couple duplicated/unused register definitions are dropped while doing > this re-order: GEN11_GT_INTR_DW{0,1}, GEN11_IIR_REG{0,1}_SELECTOR, and > GEN11_INTR_IDENTITY_REG{0,1} aren't used anywhere in the driver because > we have other parameterized macros referencing those registers. >

Re: [Intel-gfx] [PATCH v2 08/18] drm/i915/guc: Convert engine record to iosys_map

2022-02-15 Thread Matt Atwood
hew Brost > Cc: Daniele Ceraolo Spurio Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 14 ++ > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.h | 3 ++- > .../gpu/drm/i915/gt/uc/intel_guc_submission.c

Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-11 Thread Matt Atwood
On Thu, Mar 10, 2022 at 12:26:12PM +, Tvrtko Ursulin wrote: > > On 10/03/2022 05:18, Matt Atwood wrote: > > Newer platforms have DSS that aren't necessarily available for both > > geometry and compute, two queries will need to exist. This introduces > > the first, whe

[Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-16 Thread Matt Atwood
flags from hosting 2 8 bit numbers to holding a i915_engine_class_instance struct Cc: Ashutosh Dixit Cc: Matt Roper Cc: Joonas Lahtinen UMD (mesa): https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14143 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/i915_query.c | 68

[Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-09 Thread Matt Atwood
Dixit Cc: Matt Roper Cc: Joonas Lahtinen UMD (mesa): https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14143 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/i915_query.c | 68 ++- include/uapi/drm/i915_drm.h | 24 +++ 2 files changed, 65

[Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-09 Thread Matt Atwood
(mesa): https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14143 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/i915_query.c | 68 ++- include/uapi/drm/i915_drm.h | 24 +++ 2 files changed, 65 insertions(+), 27 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH v4 RFC] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-30 Thread Matt Atwood
flags from hosting 2 8 bit numbers to holding a i915_engine_class_instance struct v4: add error if non rcs engine passed. Cc: Ashutosh Dixit Cc: Matt Roper Cc: Joonas Lahtinen UMD (mesa): https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14143 Signed-off-by: Matt Atwood --- drivers/gpu

Re: [Intel-gfx] [PATCH v2 02/18] iosys-map: Add a few more helpers

2022-02-08 Thread Matt Atwood
> Cc: Thomas Zimmermann > Cc: Mauro Carvalho Chehab > Cc: dri-de...@lists.freedesktop.org > Cc: linux-ker...@vger.kernel.org Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > include/linux/iosys-map.h | 202 ++ >

Re: [Intel-gfx] [PATCH v2 03/18] drm/i915/gt: Add helper for shmem copy to iosys_map

2022-02-08 Thread Matt Atwood
; Cc: Matthew Auld > Cc: Thomas Hellström > Cc: Maarten Lankhorst Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/shmem_utils.c | 32 +++ > drivers/gpu/drm/i915/gt/shmem_utils.h | 3 +++ > 2 files changed, 35 inse

Re: [Intel-gfx] [PATCH v2 04/18] drm/i915/guc: Keep iosys_map of ads_blob around

2022-02-10 Thread Matt Atwood
itialization by abstracting the IO vs system memory. > > Cc: Matt Roper > Cc: Thomas Hellström > Cc: Daniel Vetter > Cc: John Harrison > Cc: Matthew Brost > Cc: Daniele Ceraolo Spurio Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 05/18] drm/i915/guc: Add read/write helpers for ADS blob

2022-02-10 Thread Matt Atwood
el Vetter > Cc: John Harrison > Cc: Matthew Brost > Cc: Daniele Ceraolo Spurio Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH v2 06/18] drm/i915/guc: Convert golden context init to iosys_map

2022-02-10 Thread Matt Atwood
f > destination > > Cc: Matt Roper > Cc: Thomas Hellström > Cc: Daniel Vetter > Cc: John Harrison > Cc: Matthew Brost > Cc: Daniele Ceraolo Spurio Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c |

Re: [Intel-gfx] [PATCH v2 07/18] drm/i915/guc: Convert policies update to iosys_map

2022-02-10 Thread Matt Atwood
t > Cc: Daniele Ceraolo Spurio Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 41 -- > 1 file changed, 23 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/in

Re: [Intel-gfx] [PATCH v6] drm/i915: Add Wa_18022495364

2023-09-14 Thread Matt Atwood
On Fri, Sep 15, 2023 at 01:10:32AM +0530, Dnyaneshwar Bhadane wrote: > Invalidate instruction and State cache bit using INDIRECT_CTX on > every gpu context switch for gen12. > The goal of this workaround is to actually perform an explicit > invalidation of that cache (by re-writing the register)

Re: [Intel-gfx] [PATCH 1/4] drm/i915/dg2: Recognize pre-production hardware

2023-08-16 Thread Matt Atwood
on detection. > Bspec: 44477 > Signed-off-by: Matt Roper Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/i915_driver.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_driver.c > b/drivers/gpu/drm/i915/i915_driver.c >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Tidy workaround definitions

2023-08-16 Thread Matt Atwood
e the number of condition blocks and to more consistently follow > the "newest platform first" convention. Code movement only; no > functional change. > > Signed-off-by: Matt Roper Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 100 ++

Re: [Intel-gfx] [PATCH 2/4] drm/i915/dg2: Drop pre-production display workarounds

2023-08-16 Thread Matt Atwood
; now-unused IS_DG2_DISPLAY_STEP macro. Bspec: 44477, 72197 > > Signed-off-by: Matt Roper Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 > drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/dg2: Drop pre-production GT workarounds

2023-08-17 Thread Matt Atwood
Matt Roper > Acked-by: Jani Nikula Reviewed-by: Matt Atwood > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 34 +--- > drivers/gpu/drm/i915/gt/intel_mocs.c| 21 +- > drivers/gpu/drm/i915/gt/intel_rc6.c | 6 +- > drivers/gpu/drm/i915/gt/intel_workarounds.c |

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pvc: Add initial PVC workarounds

2022-05-31 Thread Matt Atwood
On Fri, May 27, 2022 at 09:33:48AM -0700, Matt Roper wrote: > From: Stuart Summers > > Bspec: 64027 Reviewed-by: Matt Atwood > Signed-off-by: Stuart Summers > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_engine_regs.h | 5 +- > drivers/gpu/drm

Re: [Intel-gfx] [PATCH 1/2] drm/i915/pvc: Extract stepping information from PCI revid

2022-05-31 Thread Matt Atwood
gt; Unlike past platforms, steppings for these components are represented by > specific bitfields within the PCI revision ID, and we shouldn't make > assumptions about the non-CT, non-BD bits staying 0. Let's update our > stepping code accordingly. > > Bspec: 44484 Reviewed-by: Matt Atwoo

Re: [Intel-gfx] [PATCH] drm/i915/display/adl_p: Updates to HDMI combo PHY voltage swing table

2022-05-26 Thread Matt Atwood
On Thu, May 26, 2022 at 12:19:35PM +0530, Balasubramani Vivekanandan wrote: > New updates to HDMI combo PHY voltage swing tables. Actually with this > update (bspec updated on 08/17/2021), the values are reverted back to be > same as icelake for HDMI combo PHY. > > Bspec: 49291 Re

Re: [Intel-gfx] [PATCH] drm/i915/display/adlp: More updates to voltage swing table

2022-06-02 Thread Matt Atwood
On Thu, Jun 02, 2022 at 07:27:19PM +0530, Balasubramani Vivekanandan wrote: > Voltage swing table updated for eDP HBR3 > > Bspec: 49291 Pending CI results Reviewed-by: Matt Atwood > Signed-off-by: Balasubramani Vivekanandan > > --- > drivers/gpu/drm/i915/display/inte

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/uncore: Reorganize and document shadow and forcewake tables

2022-05-24 Thread Matt Atwood
handling to its own dedicated file in the > near future and further enhance this with true kerneldoc. But this is a > good intermediate step to help clarify the behavior a bit. > > Cc: Stuart Summers Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drive

Re: [Intel-gfx] [PATCH v3 2/5] drm/i915/pvc: Add forcewake support

2022-05-24 Thread Matt Atwood
On Tue, May 10, 2022 at 11:02:25PM -0700, Matt Roper wrote: > Add PVC's forcewake ranges. > > v2: > - Drop replicated comment completely; move general cleanup of the >documentation to a separate patch. > > Bspec: 67609 > Cc: Daniele Ceraolo Spurio > Cc: Stuart

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/pvc: Remove additional 3D flags from PIPE_CONTROL

2022-05-24 Thread Matt Atwood
a whole > lacks a 3D pipeline. Add those restrictions here. > > v2: > - Replace LACKS_3D_PIPELINE checks with !HAS_3D_PIPELINE and add >has_3d_pipeline to all platforms except PVC. (Lucas) > > Bspec: 47112 > Cc: Lucas De Marchi Reviewed-by: Matt Atwood > S

Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/pvc: Add new BCS engines to GuC engine list

2022-05-24 Thread Matt Atwood
On Tue, May 10, 2022 at 11:02:27PM -0700, Matt Roper wrote: > Intialize ADS system info to reflect the availablity of new BCS engines > > Original-author: CQ Tang > Cc: Stuart Summers > Cc: John Harrison Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > dr

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/guc: XEHPSDV and PVC do not use HuC

2022-05-24 Thread Matt Atwood
On Tue, May 10, 2022 at 11:02:28PM -0700, Matt Roper wrote: > From: Daniele Ceraolo Spurio > > Disable HuC loading since it is not used on these platforms. > > Cc: Stuart Summers Reviewed-by: Matt Atwood > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Matt Ro

Re: [Intel-gfx] [PATCH] drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr

2022-07-08 Thread Matt Atwood
ave some additional features coming in > the future that will also need to loop over each DSS and steer some > register accesses accordingly. > Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 34 ++- >

Re: [Intel-gfx] [PATCH] drm/i915: Drain freed object after suspend display

2022-06-29 Thread Matt Atwood
ally freed when > mm.free_work executed and that can happen very late in the suspend > process causing issues. > So here draining all freed objects released by display fixing suspend > issues. > Reviewed-by: Matt Atwood > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/

Re: [Intel-gfx] [PATCH] Revert "drm/i915/dg2: Add preemption changes for Wa_14015141709"

2022-08-29 Thread Matt Atwood
_SLICE_CS_CHICKEN1[14] is once again set by the > kernel. > Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-)

Re: [Intel-gfx] [PATCH] drm/i915/ats-m: Add thread execution tuning setting

2022-08-29 Thread Matt Atwood
> better performance. We'll add a new "tuning" feature flag to the ATS-M > device info to enable/disable this setting. > > Bspec: 68331 > Cc: Lucas De Marchi Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.

[Intel-gfx] [PATCH 2/2] drm/i915/dg2: Introduce Wa_18019271663

2022-10-25 Thread Matt Atwood
Wa_18019271663 applies to all DG2 steppings and skus. Bspec:45809 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 7 --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH 1/2] drm/i915/dg2: Introduce Wa_18018764978

2022-10-25 Thread Matt Atwood
Wa_18018764978 applies to specific steppings of DG2 (G11 C0+, G11 and G12 A0+). Bspec: 66622 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dg2: Introduce Wa_18019271663

2022-10-28 Thread Matt Atwood
On Thu, Oct 27, 2022 at 02:28:53PM -0300, Gustavo Sousa wrote: > On Tue, Oct 25, 2022 at 11:03:35AM -0700, Matt Atwood wrote: > > Wa_18019271663 applies to all DG2 steppings and skus. > > > > Bspec:45809 > > Could we also add the reference to the BSpec containing the

[Intel-gfx] [PATCH] drm/i915/dg2: introduce Wa_22015475538

2022-09-20 Thread Matt Atwood
Wa_22015475538 applies to all DG2 (and ATSM) skus. The workaround implementation is identical to Wa_16011620976. LSC_CHICKEN_BIT_0_UDW is a general render register instead of rcs so adding this move to the proper wa init function. bspec:54077 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: Add initial gt workarounds

2023-01-05 Thread Matt Atwood
On Tue, Jan 03, 2023 at 04:18:27PM -0800, Matt Roper wrote: > On Thu, Dec 15, 2022 at 03:30:55PM -0800, Matt Atwood wrote: > > From: Matt Roper > > > > This patch introduces initial gt workarounds for the MTL platform. > > > > v2: drop redundant/stale comments

[Intel-gfx] [PATCH v3] drm/i915/mtl: Add initial gt workarounds

2023-01-05 Thread Matt Atwood
From: Matt Roper This patch introduces initial gt workarounds for the MTL platform. v2: drop redundant/stale comments specifying wa platforms affected (Lucas). v3: drop additional redundant stale comments (MattR) Bspec: 66622 Signed-off-by: Matt Roper Signed-off-by: Matt Atwood --- drivers

[Intel-gfx] [Patch v2] drm/i915/mtl: Initial display workarounds

2022-12-02 Thread Matt Atwood
From: Jouni Högander This patch introduces initial workarounds for mtl platform v2: switch IS_MTL_DISPLAY_STEP to use IS_METEORLAKE from testing display ver. (Tvrtko) Bspec: 66624 Signed-off-by: Matt Atwood Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fbc.c | 4

[Intel-gfx] [PATCH v3] drm/i915/mtl: Initial display workarounds

2022-12-07 Thread Matt Atwood
From: Jouni Högander This patch introduces initial workarounds for mtl platform v2: switch IS_MTL_DISPLAY_STEP to use IS_METEORLAKE from testing display ver. (Tvrtko) v3: clerical issues, extend 16015201720 to mtl. Bspec: 66624 Signed-off-by: Matt Atwood Signed-off-by: Jouni Högander

Re: [Intel-gfx] [Patch v2] drm/i915/mtl: Initial display workarounds

2022-12-07 Thread Matt Atwood
On Fri, Dec 02, 2022 at 11:00:29AM -0800, Matt Roper wrote: > On Fri, Dec 02, 2022 at 08:51:43AM -0800, Matt Atwood wrote: > > From: Jouni Högander > > > > This patch introduces initial workarounds for mtl platform > > It looks like this patch is only dealing

  1   2   >