[Intel-gfx] [PATCH] drm/i915: Return early when pipes are not available

ELD. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206 Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c

[Intel-gfx] [PATCH FOR CI v2] drm/i915: Generalize transcoder looping

To make looping through transcoders in intel_ddi.c more generic, let's switch to use 'for_each_pipe()' macro to do this. v2: Add a notion that we are dealing with transcoders instead of pipes (Jani) Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Mika Kahola <

Re: [Intel-gfx] [PATCH v2] drm/i915: Generalize transcoder looping

On Wed, 2017-11-08 at 21:54 +0200, Ville Syrjälä wrote: > On Mon, Nov 06, 2017 at 03:29:45PM +0200, Mika Kahola wrote: > > > > To make looping through transcoders in intel_ddi.c more generic, > > let's switch > > to use 'for_each_pipe()' macro to do this. > &

[Intel-gfx] [PATCH v2] drm/i915: Generalize transcoder looping

To make looping through transcoders in intel_ddi.c more generic, let's switch to use 'for_each_pipe()' macro to do this. v2: Add a notion that we are dealing with transcoders instead of pipes (Jani) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_ddi.

Re: [Intel-gfx] [PATCH] drm/i915: Generalize transcoder looping

On Wed, 2017-11-01 at 17:26 +0200, Jani Nikula wrote: > On Wed, 01 Nov 2017, Mika Kahola <mika.kah...@intel.com> wrote: > > > > To make looping through transcoders in intel_ddi.c more generic, > > let's switch > > to use 'for_each_pipe()' macro to do this. &g

[Intel-gfx] [PATCH] drm/i915: Generalize transcoder looping

To make looping through transcoders in intel_ddi.c more generic, let's switch to use 'for_each_pipe()' macro to do this. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

[Intel-gfx] [PATCH v2] drm/i915/cnl: Symmetric scalers for each pipe

For Cannonlake the number of scalers for each pipe is 2. Let's increase the number of scalers for pipe C. v2: Use INTEL_GEN() instead of IS_CANNONLAKE() Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_device_info.c | 5 - 1 file changed, 4 insertions

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_lowres: Rework tests to work without fbcon.

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Fri, 2017-10-13 at 16:58 +0200, Maarten Lankhorst wrote: > kmstest_get_crtc was skipping because at that point the crtc was not > active yet, instead we should only use igt_assert_plane_visible > directly. Unexport kmstest_

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_atomic: Convert/rewrite tests to use igt_kms framework, v2.

On Fri, 2017-10-20 at 12:08 +0200, Maarten Lankhorst wrote: > Op 20-10-17 om 12:02 schreef Mika Kahola: > > > > On Thu, 2017-10-12 at 17:33 +0200, Maarten Lankhorst wrote: > > > > > > Now that we can set individual properties through the igt_kms > > >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_concurrent: Fix testcase fails.

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-19 at 13:15 +0200, Maarten Lankhorst wrote: > igt_pipe_refresh was added for the forked helper, we could just call > it > from the fork to prevent races against MODE_ID. > > The static 1024x768 mode is a

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_atomic: Convert/rewrite tests to use igt_kms framework, v2.

On Thu, 2017-10-12 at 17:33 +0200, Maarten Lankhorst wrote: > Now that we can set individual properties through the igt_kms api, > we no longer need to duplicate functionality from igt_kms. Set > invalid > properties directly, and rewrite kms_atomic.c to use igt_display. > This will allow us to

Re: [Intel-gfx] [PATCH i-g-t v2 05/14] lib/igt_kms: Allow setting any output property through the !atomic paths

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > Everything except CRTC_ID can be set in the legacy paths, > we even have 2, the legacy and universal path. Excercise both. :D > > Signed-off-by: Maarten Lankhor

Re: [Intel-gfx] [PATCH i-g-t v2 02/14] lib/igt_kms: Rework plane properties to be more atomic, v5.

On Thu, 2017-10-19 at 11:44 +0200, Maarten Lankhorst wrote: > Op 19-10-17 om 11:08 schreef Mika Kahola: > > > > On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > > > > > > In the future I want to allow tests to commit more properties, > > &

Re: [Intel-gfx] [PATCH i-g-t v2 12/14] tests/kms_color: Rework tests slightly to work better with new atomic api

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > igt_pipe_get_property is about to be removed, so use > igt_pipe_obj_get_prop instead. This requires adding 2 more properties > to the crtc property list. Also get rid o

Re: [Intel-gfx] [PATCH i-g-t v2 13/14] tests/chamelium: Remove reliance on output->config.pipe

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > IGT has an api that can find a matching pipe for a given connector, > so use that. > > igt_output_override_mode already forces a modeset on an affected pipe > si

Re: [Intel-gfx] [PATCH i-g-t v2 11/14] lib/igt_kms: Remove igt_crtc_set_background()

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > This can be handled by generic properties. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > --- >  lib/igt_kms

Re: [Intel-gfx] [PATCH i-g-t v2 10/14] lib/igt_kms: Remove igt_pipe_get_property

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > igt_pipe_get_property has been replaced by igt_pipe_obj_get_prop. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > --- >  lib/igt_k

Re: [Intel-gfx] [PATCH i-g-t v2 09/14] lib/igt_kms: Add igt_$obj_get_prop functions

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > Some tests need to get the current kernel value for properties > as part of the test. Add get_prop functions that will retrieve > the current kernel value. > > S

Re: [Intel-gfx] [PATCH i-g-t v2] lib/igt_kms: Add igt_$obj_has_prop functions, v2.

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 17:33 +0200, Maarten Lankhorst wrote: > This allows test to test whether a property is supported, in > a nice and clean way. It removes the need for special case > functions like igt_plane_supports_rotatio

Re: [Intel-gfx] [PATCH i-g-t v2 06/14] lib/igt_kms: Export property blob functions for output/pipe/plane, v2.

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > With the replace_prop_blob functions we can safely replace the blob > for > any property, without having to care about error handling ourselves. > > This w

Re: [Intel-gfx] [PATCH i-g-t v2 07/14] lib/igt_kms: Unexport broadcast rgb API.

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > Setting broadcast rgb was only used by chamelium, but is now handled > in igt_display by default. This means that chamelium doesn't need to > set it, and thi

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Use cdclk_state->voltage on CNL

  > >  static void cnl_cdclk_pll_disable(struct drm_i915_private > > *dev_priv) > > @@ -1594,8 +1600,7 @@ static void cnl_set_cdclk(struct > > drm_i915_private *dev_priv, > >   > > intel_update_cdclk(dev_priv); > >   > > +   dev_priv-&

Re: [Intel-gfx] [PATCH i-g-t v2 04/14] lib/igt_kms: Allow setting any plane property through the universal path

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > Blacklist some explicit atomic properties. We could theoretically set > them but that's not what the legacy path is for. :) > > When adding new properties, this m

Re: [Intel-gfx] [PATCH i-g-t v2 03/14] lib/igt_kms: Rework pipe properties to be more atomic, v7.

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote: > In the future I want to allow tests to commit more properties, > but for this to work I have to fix all properties to work better > with atomic commit. Instead of spec

Re: [Intel-gfx] [PATCH i-g-t v2 02/14] lib/igt_kms: Rework plane properties to be more atomic, v5.

;   > -/** > - * igt_atomic_populate_plane_req: > - * @req: A pointer to drmModeAtomicReq > - * @plane: A pointer igt_plane_t > - * @prop: one of igt_atomic_plane_properties > - * @value: the value to add > - */ > -#define igt_atomic_populate_plane_req(req, plane

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Clean up some cdclk switch statements

On Wed, 2017-10-18 at 23:48 +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > Redo some switch statements in the cdclk code to use a common > fall through for the default case. Makes everything look a bit > more uniform > >

Re: [Intel-gfx] [PATCH] drm/i915: Cache max number of pipes

On Thu, 2017-10-12 at 09:55 +0300, Jani Nikula wrote: > On Thu, 12 Oct 2017, Mika Kahola <mika.kah...@intel.com> wrote: > > > > CI system spotted an error on CFL system when running IGT tests > > with > > display disabled. In this case, the 'INTEL_INFO(dev_priv)

[Intel-gfx] [PATCH] drm/i915: Get rid of hardcoded pipes

Favor for_each_pipe() macro when looping through pipes. This patch is related to miscellenous fixes to reduce dependency on I915_MAX_PIPES. https://patchwork.freedesktop.org/series/30336/ Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp_mst.

[Intel-gfx] [PATCH] drm/i915: Cache max number of pipes

hes the maximum number of available pipes. Reference: https://bugs.freedesktop.org/show_bug.cgi?id=103206 Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_audio.c | 2 +- drivers/gpu/drm/i915/intel_device_i

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Symmetric scalers for each pipe

On Wed, 2017-10-11 at 15:43 +0300, Ville Syrjälä wrote: > On Mon, Oct 09, 2017 at 03:26:07PM +0300, Mika Kahola wrote: > > > > For Cannonlake the number of scalers for each pipe is 2. Let's > > increase > > the number of scalers for pipe C. > > > &g

[Intel-gfx] [PATCH FOR CI 3/5] drm/i915: Fold IRQ pipe masks

Fold IRQ pipe masks into one loop instead of hardcoding per pipe. Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --g

[Intel-gfx] [PATCH FOR CI 4/5] drm/i915: Favor for_each_pipe() macro

Favor for_each_pipe() macro when looping through pipes. v2: use 'enum pipe pipe' instead of 'i' Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_pipe_crc.c | 8 1 file changed,

[Intel-gfx] [PATCH FOR CI 5/5] drm/i915: Cleanup South Error Interrupts

Cleanup and parametrize the handling of South Error Interrupts (SERR_INT). Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 12 drivers/gpu/drm/i915/i915_reg.h | 3

[Intel-gfx] [PATCH FOR CI 2/5] drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation

Remove dependency for I915_MAX_PIPES by replacing it with for_each_pipe() macro. v2: use 'enum pipe pipe' instead of 'i' Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Ramalingam C <ramalinga...@intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.co

[Intel-gfx] [PATCH FOR CI 1/5] drm/i915: Don't relay on I915_MAX_PIPES

Let's remove the dependency on I915_MAX_PIPES. Instead, get the number of pipes from platform information. Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Ramalingam C <ramalinga...@intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- dr

[Intel-gfx] [PATCH FOR CI 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

This patch series introduces fixes to reduce dependency for I915_MAX_PIPES and minor optimizations to reduce hardcoding. Mika Kahola (5): drm/i915: Don't relay on I915_MAX_PIPES drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation drm/i915: Fold IRQ pipe masks drm/i915: Favor

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

On Tue, 2017-10-10 at 02:20 -0700, Kenneth Graunke wrote: > On Thursday, September 14, 2017 12:53:01 AM PDT Mika Kahola wrote: > > > > This patch series introduces fixes to reduce dependency for > > I915_MAX_PIPES and minor optimizations to reduce hardcoding. > > >

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

On Tue, 2017-10-10 at 12:19 +0300, Ville Syrjälä wrote: > On Thu, Sep 14, 2017 at 10:53:01AM +0300, Mika Kahola wrote: > > > > This patch series introduces fixes to reduce dependency for > > I915_MAX_PIPES and minor optimizations to reduce hardcoding. > > > >

[Intel-gfx] [PATCH] drm/i915/cnl: Symmetric scalers for each pipe

For Cannonlake the number of scalers for each pipe is 2. Let's increase the number of scalers for pipe C. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_device_info.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/dr

Re: [Intel-gfx] [PATCH 11/13] drm/i915/cnl: Only request voltage frequency switching when needed.

block > - s/need/needs: When adding doc needs sounded better. > > Cc: Mika Kahola <mika.kah...@intel.com> > Cc: Paulo Zanoni <paulo.r.zan...@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> > --- >  drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Unify and export gen9+ port_clock calculation.

On Wed, 2017-10-04 at 14:26 -0700, Rodrigo Vivi wrote: > On Wed, Oct 04, 2017 at 07:38:16PM +, Rodrigo Vivi wrote: > > > > On Wed, Oct 04, 2017 at 06:39:19AM +0000, Mika Kahola wrote: > > > > > > On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > &

Re: [Intel-gfx] [PATCH 10/13] drm/i915/cnl: Unify dvfs level selection.

sounded ambiguous > because we could be getting the current level at pcode. > > Cc: Mika Kahola <mika.kah...@intel.com> > Cc: Paulo Zanoni <paulo.r.zan...@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> > --- >  drivers/gpu/drm/i915/int

Re: [Intel-gfx] [PATCH i-g-t 2/2] lib/igt_kms: Disable crtc in legacy path when output is unset

kms_color.c:1053 > 7  0xf610 in __real_main1189 () at kms_color.c:1206 > 8  0xcbc7 in main (argc=, argv= out>) at kms_color.c:1189 > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Mika Kahola <mika.kah...@int

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_color: Unset plane fb on teardown, v2.

d 1's stack > ==1804==  160 bytes below stack pointer > > Add the missing calls to igt_plane_set_fb, and fix the crash. > > Changes since v1: > - Fix compilation! > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Mika Kahola <mika.kah..

Re: [Intel-gfx] [PATCH 09/13] drm/i915/cnl: Invert dvfs default level.

z, use level 1. Else, use level 2." Should we add check for DDI clock rate as well here? > > v2: Rebase moving it up to avoid some temporary code > duplication. > > Cc: Mika Kahola <mika.kah...@intel.com> > Cc: Paulo Zanoni <paulo.r.zan...@intel.com> > Signed

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Unify and export gen9+ port_clock calculation.

On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > On Cannonlake the DVFS level selection depends on the > port clock. > > So let's re-org in a way that we can easily export without > duplicating any code. > > v2: Rebased on changes on previous patches > >

Re: [Intel-gfx] [PATCH 03/13] drm/i915/skl: Extract skl_calc_pll_link following bxt, cnl style.

essing up the HDMI clocks. (Caught by CI). > > Cc: Mika Kahola <mika.kah...@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com> > --- >  drivers/gpu/drm/i915/intel_ddi.c | 21 ++--- >  1 fi

Re: [Intel-gfx] [PATCH i-g-t v4 5/7] lib/igt_kms: Rework plane properties to be more atomic, v4.

&= ~(1 << (prop)) > + > +#define igt_plane_set_prop_value(plane, prop, value) \ > + do { \ > + plane->values[prop] = value; \ > + igt_plane_set_prop_changed(plane, prop); \ > + } while (0) >   >  /** >   * igt_atomic_populate_crtc_r

Re: [Intel-gfx] [PATCH 02/13] drm/i915/cnl: Extract cnl_calc_pll_link following bxt style.

On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > No functional change. Just spliting the function for > better port clock handling later. > > v2: Put link_clock *=2 inside the function only for DP, > otherwise we mess up clocks on HDMI. (Caught by CI). > > Cc:

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Let's use more enum intel_dpll_id pll_id.

On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > No functional change expected. Just let's use this enum > when possible and also same standard pll_id name > so we can rework gen9+ port clock later. > > Cc: Mika Kahola <mika.kah...@intel.com> > Cc: Paulo Zanoni &

Re: [Intel-gfx] [PATCH i-g-t v4 4/7] lib/igt_kms: Rework connector properties to be more atomic, v2.

erty changed flags, and try to > commit all properties. > > Changs since v1: > - Mention which properties we set to what. > - Assert the property to be set is valid. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Mika Kahola <mika

Re: [Intel-gfx] [PATCH i-g-t v4 3/7] lib/igt_kms: Commit primary plane when a modeset is forced on a pipe

t will fail > on exhaust-fences because the bad-tiling subtest wasn't able to > disable pipe C correctly. > > Testcase: kms_rotation_crc > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com> > ---

Re: [Intel-gfx] [PATCH i-g-t v4 2/7] lib/igt_kms: Change output->pending_crtc_idx_mask to output->pending_pipe

r to change output->pending_crtc_idx_mask > to > an enum pipe, because only a single choice may be given for a pipe. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com>

Re: [Intel-gfx] [PATCH i-g-t v4 1/7] tests: Stop looking at plane private members

On Fri, 2017-09-29 at 11:59 +0200, Maarten Lankhorst wrote: > Most of these tests have no reason to look at those members, > so try other ways of getting the information. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Mika Kahola <

Re: [Intel-gfx] [PATCH i-g-t v4 7/7] igt/kms_rotation_crc : Fix flip tests for sprite plane

arten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com> > --- >  tests/kms_rotation_crc.c | 23 +-- >  1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotatio

Re: [Intel-gfx] [PATCH i-g-t v2 8/8] tests: Rename kms_pipe_color to kms_color

arten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com> > --- >  tests/Makefile.sources  | 2 +- >  tests/{kms_pipe_color.c => kms_color.c} | 4 ++-- >  2 files changed, 3 insertions(+), 3 deletions(-) >  renam

Re: [Intel-gfx] [PATCH] drm/i915: Also discard second CRC on gen8+ platforms.

for all gen8+ platforms and > make our CI a bit more stable. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102374 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101309 > Cc: Mika Kahola <mika.kah...@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com&g

Re: [Intel-gfx] [PATCH] drm/i915: Also discard second CRC on gen8+ platforms.

This fixes my issue with GLK+MIPI/DSI when running IGT test kms_frontbuffer_tracking --r basic Tested-by: Mika Kahola <mika.kah...@intel.com> On Wed, 2017-09-27 at 17:20 -0700, Rodrigo Vivi wrote: > One of the differences I spotted for GEN8+ platforms when > compared to old

Re: [Intel-gfx] [PATCH v7] drm/i915/edp: Be less aggressive about changing link config on eDP

al > > > culprits here were addressed by some of the recent link training > > > changes > > > that Manasi has implemented, and PSR on Skylake is definitely > > > more happy > > > with these changes in-place. > > > > > > v2 and v3: Rebase

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's

seems to be affected by this https://bugs.freedesktop.org/show_bug.cgi?id=102374 > > On Fri, Sep 22, 2017 at 5:40 AM Mika Kahola <mika.kah...@intel.com> > wrote: > > It seems that at least with GLK with MIPI/DSI display, the first > > collected > > CRC is bogus

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Try harder to collect CRC's

It seems that at least with GLK with MIPI/DSI display, the first collected CRC is bogus. To fix this, try to collect two CRC's instead of one. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101309 Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_frontbuffer_trac

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

otal:2313 pass:1242 > > dwarn:0   dfail:0   fail:12  skip:1059 time:9338s > > > > == Logs == > > > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patc > > hwork_5692/shards.html > > ___ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

otal:2313 pass:1242 > > dwarn:0   dfail:0   fail:12  skip:1059 time:9338s > > > > == Logs == > > > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patc > > hwork_5692/shards.html > > ___ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/5] drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation

From: "Kahola, Mika" Remove dependency for I915_MAX_PIPES by replacing it with for_each_pipe() macro. Signed-off-by: Ramalingam C Signed-off-by: Kahola, Mika --- drivers/gpu/drm/i915/intel_display.c | 5 -

[Intel-gfx] [PATCH 5/5] drm/i915: Cleanup South Error Interrupts

Cleanup and parametrize the handling of South Error Interrupts (SERR_INT). Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 12 drivers/gpu/drm/i915/i915_reg.h | 3 --- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/d

[Intel-gfx] [PATCH 1/5] drm/i915: Don't relay on I915_MAX_PIPES

Let's remove the dependency on I915_MAX_PIPES. Instead, get the number of pipes from platform information. Signed-off-by: Ramalingam C <ramalinga...@intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_audio.c| 2 +- drivers/

[Intel-gfx] [PATCH 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

This patch series introduces fixes to reduce dependency for I915_MAX_PIPES and minor optimizations to reduce hardcoding. Kahola, Mika (1): drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation Mika Kahola (4): drm/i915: Don't relay on I915_MAX_PIPES drm/i915: Fold IRQ pipe masks

[Intel-gfx] [PATCH 4/5] drm/i915: Favor for_each_pipe() macro

Favor for_each_pipe() macro when looping through pipes. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_pipe_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe

[Intel-gfx] [PATCH 3/5] drm/i915: Fold IRQ pipe masks

Fold IRQ pipe masks into one loop instead of hardcoding per pipe. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH] drm/i915/dsi: Silence atomic update failure with DSI panel

On Thu, 2017-09-07 at 13:29 +0200, Maarten Lankhorst wrote: > Op 05-09-17 om 15:35 schreef Mika Kahola: > > > > It appears that we cannot trust scanline counters when MIPI/DSI > > display is > > connected. In CI system this appears as flickering errors that > >

Re: [Intel-gfx] [PATCH] drm/i915/dsi: Silence atomic update failure with DSI panel

On Tue, 2017-09-05 at 18:11 +0200, Daniel Vetter wrote: > On Tue, Sep 05, 2017 at 04:35:04PM +0300, Mika Kahola wrote: > > > > It appears that we cannot trust scanline counters when MIPI/DSI > > display is > > connected. In CI system this appears as flickering errors t

[Intel-gfx] [PATCH] drm/i915/dsi: Silence atomic update failure with DSI panel

://bugs.freedesktop.org/show_bug.cgi?id=102403 Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_sprite.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c

Re: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"

The revert patch solved the issue *ERROR* Video mode command 0x0041 send failed. on my setup with APL+MIPI/DSI single link combo. Tested-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-09-05 at 15:14 +0530, Vidya Srinivas wrote: > From: Uma Shankar <uma.shan.

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's

On Mon, 2017-09-04 at 18:04 +0300, Ville Syrjälä wrote: > On Mon, Sep 04, 2017 at 10:59:32AM +0300, Mika Kahola wrote: > > > > On Fri, 2017-09-01 at 16:43 +0300, Ville Syrjälä wrote: > > > > > > On Fri, Sep 01, 2017 at 10:51:00AM +0300, Mika Kahola wrote: &g

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's

On Fri, 2017-09-01 at 16:43 +0300, Ville Syrjälä wrote: > On Fri, Sep 01, 2017 at 10:51:00AM +0300, Mika Kahola wrote: > > > > According to spec we should send SHUTDOWN before > > MIPI_SEQ_DISPLAY_OFF for > > v3+ VBT's. Testing with VBT v3 the current implementation y

[Intel-gfx] [PATCH 0/2] drm/i915/dsi: Fix error on DSI video mode command

Mika Kahola (2): drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's drm/i915/dsi: Replace MIPI command error message with debug message drivers/gpu/drm/i915/intel_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 ___ Intel-gfx

[Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's

or higher. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404 Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 2/2] drm/i915/dsi: Replace MIPI command error message with debug message

Error message indicating that the same MIPI command is sent consecutively is perhaps too strongly said. Let's replace that as a debug message instead. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_atomic: subtest atomic_invalid_params requires CRTC

In my view, this is a valid check. Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-08-29 at 13:32 +0300, Marta Lofstedt wrote: > Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_para > ms. > This leads to segfault on machines where the subtest shou

Re: [Intel-gfx] [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID

On Thu, 2017-08-17 at 14:06 +0300, Mika Kahola wrote: > Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01) Tested also with APL + MIPI/DSI setup. > > Tested-by: Mika Kahola <mika.kah...@intel.com> > > On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote

Re: [Intel-gfx] [PATCH 3/3] drm/i915/cnl: Avoid old DDI translation functions on Cannonlake.

for Cannonlake. > This patch only removes unecessary steps probably saving > us from some useless warnings. > > Cc: Clint Taylor <clinton.a.tay...@intel.com> > Cc: Mika Kahola <mika.kah...@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> > --- &g

Re: [Intel-gfx] [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID

Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01) Tested-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote: > The commit 213e08ad60ba > ("drm/i915/bxt: add bxt dsi gpio element support") > enables GPIO

Re: [Intel-gfx] [PATCH 2/3] drm/i915/cnl: Dump the right pll registers when dumping pipe config.

On Thu, 2017-07-06 at 13:54 -0700, Rodrigo Vivi wrote: > Different from SKL we don't need ctrl1 and cfgcr2, but > we need to dump cfgcr0 amd cfgcr1 instead. With minor typo fixed in commit message, this is Reviewed-by: Mika Kahola <mika.kah...@intel.com> > > v2: rebase

Re: [Intel-gfx] [PATCH 1/3] drm/i915/cnl: Add allowed DP rates for Cannonlake.

. > > Cc: Clint Taylor <clinton.a.tay...@intel.com> > Cc: Mika Kahola <mika.kah...@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> > --- >  drivers/gpu/drm/i915/intel_dp.c | 6 ++ >  1 file changed, 6 insertions(+) > > diff --git a/

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib/igt_kms: Remove vblank wait after plane update.

On Mon, 2017-08-07 at 10:42 +0200, Maarten Lankhorst wrote: > Op 04-08-17 om 10:07 schreef Mika Kahola: > > > > On Wed, 2017-08-02 at 12:29 +0200, Maarten Lankhorst wrote: > > > > > > With the conversion to atomic, this is already handled in the > > >

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib/igt_kms: Remove vblank wait after plane update.

} > - >   return 0; >  } >   > diff --git a/lib/igt_kms.h b/lib/igt_kms.h > index 35428f3e9675..d18a92600933 100644 > --- a/lib/igt_kms.h > +++ b/lib/igt_kms.h > @@ -323,7 +323,6 @@ typedef struct { >  struct igt_pipe { >   igt_display_t *display; >   enum pipe p

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests: Add kms_atomic_interruptible test.

; + break; > + } > + > + igt_subtest("legacy-cursor") > + for_each_pipe_with_valid_output(, pipe, > output) { > + run_plane_test(, pipe, output, > test_setplane, DRM_PLANE_TYPE_CURSOR, COMMIT_LEGACY); > +

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_aux: Export statistics of signal helper.

t a/lib/igt_aux.h b/lib/igt_aux.h > index 499a16796ebb..7e080089dcbc 100644 > --- a/lib/igt_aux.h > +++ b/lib/igt_aux.h > @@ -55,6 +55,8 @@ extern int num_trash_bos; >  /* generally useful helpers */ >  void igt_fork_signal_helper(void); >  void igt_stop_signal_helper(void); > +i

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_plane_multiple: Fix reference CRC

es > > this anomaly in the test. > > > > While at it, remove unnecesary struct for test data as we only need > > reference CRC here. > > > > The problem was caught by CI system and at least affects on HSW > > platform. > > > > V2: Don't c

[Intel-gfx] [PATCH i-g-t v2] tests/kms_plane_multiple: Fix reference CRC

system and at least affects on HSW platform. V2: Don't change function that collects CRC for reference CRC Fix CRC pointers Remove unnecessary struct for holding test data Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_multiple.c | 25 +-

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

On Wed, 2017-08-02 at 15:42 +0300, Petri Latvala wrote: > After a bit of digging into this n_words conundrum that I also could > not understand, I found the issue Mika described. > > kms_plane_multiple et al basically do > > igt_crc_t crc; > > > and then they pass to test-internal helper

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

On Wed, 2017-08-02 at 14:16 +0200, Daniel Vetter wrote: > On Wed, Aug 2, 2017 at 2:06 PM, Mika Kahola <mika.kah...@intel.com> > wrote: > > > > On Wed, 2017-08-02 at 13:36 +0200, Daniel Vetter wrote: > > > > > > On Mon, Jul 31, 20

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

t; > > Daniel Vetter > > > Sent: Monday, July 31, 2017 11:13 AM > > > To: Kahola, Mika <mika.kah...@intel.com> > > > Cc: intel-gfx <intel-gfx@lists.freedesktop.org> > > > Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: > &

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

platform. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_multiple.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c index f6c6223..08f184a 100644 --- a/tests/kms_plane_multiple.c

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: Reset GPU before running subtests

On Wed, 2017-06-07 at 11:24 +0100, Chris Wilson wrote: > Quoting Mika Kahola (2017-06-07 09:00:10) > > > > On Tue, 2017-06-06 at 14:23 +0100, Chris Wilson wrote: > > > > > > Quoting Mika Kahola (2017-06-06 13:33:14) > > > > > > > > >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: Reset GPU before running subtests

On Tue, 2017-06-06 at 14:23 +0100, Chris Wilson wrote: > Quoting Mika Kahola (2017-06-06 13:33:14) > > > > On Tue, 2017-06-06 at 15:27 +0300, Ville Syrjälä wrote: > > > > > > On Tue, Jun 06, 2017 at 03:20:46PM +0300, Mika Kahola wrote: > > > > >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: Reset GPU before running subtests

On Tue, 2017-06-06 at 15:27 +0300, Ville Syrjälä wrote: > On Tue, Jun 06, 2017 at 03:20:46PM +0300, Mika Kahola wrote: > > > > It has been noticed by our CI BAT testing that in some 1%-3% > > probability > > kms_pipe_crc_basic subtest read-crc-pipe-x-frame-sequence f

[Intel-gfx] [PATCH i-g-t] tests/kms_pipe_crc_basic: Reset GPU before running subtests

://bugs.freedesktop.org/show_bug.cgi?id=100367 Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_pipe_crc_basic.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index f49b434..e1940e6 100644 --- a

Re: [Intel-gfx] [PATCH] drm/i915: Workaround VLV/CHV DSI scanline counter hardware fail

The patch does what it says. Tested-by: Mika Kahola <mika.kah...@intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2016-12-15 at 19:47 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > The scanlin

Re: [Intel-gfx] [PATCH i-g-t v3] lib/igt_kms: Force outputs to use full range RGB

for sure what is the color range in use. Reviewed-by: Mika Kahola <mika.kah...@intel.com> >  > v2: Add more details to the commit message. > v3: Force all tests to use full range. > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Signed-off-by: Ander Conselvan de

<    1   2   3   4   5   6   7   8   9   10   >