ppening for several
> versions of the series, including mine. I would've applied the early
> patches already if I'd gotten some test results.
What gives is the part of the patch that contains
-#define INTEL_CRTC_FUNCS \
-.gamma_set = drm_atomic_helper_legacy_gamma_set, \
ositives are frustrating.
> -Chris
Do you have a link to a test run where this happened? This patch
didn't change the between-tests abort checks.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Jan 07, 2021 at 09:49:23AM +, Chris Wilson wrote:
> Quoting Petri Latvala (2021-01-07 09:40:02)
> > On Wed, Jan 06, 2021 at 09:41:37AM +, Chris Wilson wrote:
> > > Quoting Janusz Krzysztofik (2020-12-04 19:50:07)
> > > > We may still be interested i
problem is fixed.
Meaning, something like:
==
tests/kms_plane_alpha_blend: Don't set primary fb color in
coverage-vs-premult-vs-constant
Similar change has already been done in tests xxx and yyy.
This fixes CRC mismatches seen with some Gen11 sy
-0
The default view in the CI results only shows tests that have
issues. "view -> shards all" from the top shows all tests.
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5907/shards-all.html?testfilter=kms_big_fb
--
Petri Latvala
___
Inte
d read() checks the buffer
with __builtin_object_size() that it has room for the read. Which it
can only do here if the address is a literal.
Reviewed-by: Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
drmModeConnector and caused this SIGSEGV fault
> when release it. Make sure drmModeConnector is available before
> free it can avoid this issue.
>
> Signed-off-by: Lee Shawn C
Reviewed-by: Petri Latvala
> ---
> tests/kms_dp_dsc.c | 5 +++--
> 1 file changed, 3 inser
ike
that). Because overall timeout got triggered, igt_results was invoked
against that shard execution in jenkins master host, overwriting the
DUT-written one, and because the journal didn't state the subtest
started, it was parsed as being incomplete.
The logs unfortunately were not able to
On Mon, Oct 18, 2021 at 07:10:02PM +0300, Imre Deak wrote:
> On Mon, Oct 18, 2021 at 06:42:38PM +0300, Petri Latvala wrote:
> > On Mon, Oct 18, 2021 at 03:10:54PM +0300, Imre Deak wrote:
> > > Hi Petri, Tomi,
> > >
> > > could you check the failure below?
>
t; #define DRM_I915_QUERY_MEMORY_REGIONS 4
> +#define DRM_I915_QUERY_HWCONFIG_TABLE 5
> /* Must be kept compact -- no holes and well documented */
Please update i915_drm.h with a copy from the kernel and state in the
commit message which kernel commit sha it's from. If this change i
On Thu, Sep 16, 2021 at 10:27:41AM -0700, John Harrison wrote:
> On 9/16/2021 01:59, Petri Latvala wrote:
> > On Wed, Sep 15, 2021 at 02:55:58PM -0700, john.c.harri...@intel.com wrote:
> > > From: Rodrigo Vivi
> > >
> > > Newer platforms have an embe
lib/i915/gem_mman.c
> > @@ -497,6 +497,43 @@ void *gem_mmap_offset__cpu(int fd, uint32_t handle,
> > uint64_t offset,
> > return ptr;
> > }
> >
> > +#define LOCAL_I915_MMAP_OFFSET_FIXED 4
>
> Cc: @Petri Latvala
>
> This use of LOCAL declarations
On Wed, Jul 28, 2021 at 06:53:50PM -0700, Dixit, Ashutosh wrote:
> On Tue, 27 Jul 2021 23:08:40 -0700, Petri Latvala wrote:
> >
> > On Tue, Jul 27, 2021 at 07:01:24PM -0700, Dixit, Ashutosh wrote:
> > > On Mon, 26 Jul 2021 05:03:04 -0700, Matthew Auld wrote:
> > >
t happens before syncing the
files to AWS. The file sync can fail or take an undetermined amount of
time so it's done asynchronously. Typically the files get synced
within around 2 minutes of posting to patchwork but sometimes (~once a
month) sync fails and the files get there as part of the next test
result sync job.
--
Petri Latvala
On Tue, May 11, 2021 at 05:51:12PM +0100, Matthew Auld wrote:
> Sync to get gem_create_ext and the regions query stuff.
Kernel commit sha in commit message please.
--
Petri Latvala
>
> Signed-off-by: Matthew Auld
> ---
> include/drm-uapi/i
o: Can that break? Can we have cases where the
query gives garbage? Can it give two million smem regions? Can it give
0 regions, or -1 regions? And what happens then?
Is it just gem_create_ext that's hiding behind CONFIG_BROKEN or also
the querying?
--
Petri Latvala
On Wed, May 19, 2021 at 11:45:17AM +0100, Matthew Auld wrote:
> On Wed, 19 May 2021 at 09:49, Petri Latvala wrote:
> >
> > On Wed, May 19, 2021 at 09:13:37AM +0100, Matthew Auld wrote:
> > > On Tue, 11 May 2021 at 17:52, Matthew Auld wrote:
> > > >
> &
On Wed, May 19, 2021 at 12:36:17PM +0100, Matthew Auld wrote:
> On Wed, 19 May 2021 at 12:00, Petri Latvala wrote:
> >
> > On Wed, May 19, 2021 at 11:45:17AM +0100, Matthew Auld wrote:
> > > On Wed, 19 May 2021 at 09:49, Petri Latvala
> > > wrote:
> > &g
b.c | 2 +-
> tests/prime_busy.c | 1 +
> tests/prime_mmap.c | 2 +-
> tests/prime_mmap_kms.c | 2 +-
> tests/prime_self_import.c | 2 +-
> tests/prime_vgem.c | 1 +
> tools/intel_reg.c | 2 +-
> 149 files changed, 1447 insertions(+), 134 deletions(-)
> create mode 100644 lib/i915/gem_create.h
> create mode 100644 lib/i915/intel_memory_region.c
> create mode 100644 lib/i915/intel_memory_region.h
Series is
Acked-by: Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
oi(tmp),
> + "Request expiry not supported!");
Newline missing at the end.
--
Petri Latvala
> + free(tmp);
>
> - igt_params_save_and_set(i915, "request_timeout_ms",
> -
: Lyude Paul mailto:ly...@redhat.com>>
> > Date: Mon Apr 15 14:57:23 2019 -0400
> >
> > and applied it
> > it fixed the one problem
> >
> > then I looked at previous head
> >
> > commit f052e49a43cc9704ea5f240df15dd9d3dfed68ab (origin/master, origin/HEAD)
> > Author: Simon Ser mailto:simon@intel.com>>
> > Date: Wed Apr 24 19:15:26 2019 +0300
> >
> > It sure seems that tree is stale.
That tree's master ref does not get updated. It's only for storing tags.
That test result comparison was too long to fit into patchwork so the
build information at the bottom is missing, but the BAT results have
it:
IGT_6193: 080869f804cb86b25a38889e5ce9a870571cd8c4 @
https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
--
Petri Latvala
On Mon, Sep 06, 2021 at 11:04:13AM +0100, Tvrtko Ursulin wrote:
>
> On 03/09/2021 14:01, Petri Latvala wrote:
> > On Fri, Sep 03, 2021 at 12:29:51PM +0100, Tvrtko Ursulin wrote:
> > >
> > > On 03/09/2021 01:31, jim.cro...@gmail.com wrote:
> > > >
> &
e3090477fbde066ff314a7e9721ee0f
> Fixes: 1815d9c86e30 ("drm: add a locked version of drm_is_current_master")
> Cc: Desmond Cheong Zhi Xi
> Cc: Emil Velikov
> Cc: sta...@vger.kernel.org
> Signed-off-by: Daniel Vetter
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
>
On Thu, Apr 01, 2021 at 12:43:16PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Correcting a brain malfunction while typing in Makefile.sources.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Petri Latvala
> ---
> tests/Makefile.sources | 2 +-
> 1 f
On Thu, Apr 08, 2021 at 10:13:16PM +0200, Daniel Vetter wrote:
> On Thu, Apr 01, 2021 at 03:03:49PM +0300, Petri Latvala wrote:
> > On Thu, Apr 01, 2021 at 12:43:16PM +0100, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > Correcting
stats. (Tvrtko Ursulin)
- - igt_runner can now limit the disk space used by a single test. (Petri
Latvala)
And many other bug fixes, improvements, cleanups and new tests.
Full changelog:
Abhinav Kumar (5):
tools: rename intel_dp_compliance_hotplug to igt_dp_compliance_hotplug
lib
this in a separate section with a comment (commit message seems
sufficient) that explains why it's blacklisted.
With that,
Acked-by: Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
return fd;
> - }
> + if (forced && chipset == DRIVER_ANY && strcmp(forced, dev_name))
> + goto err;
Yep, an obvious logic error by me.
Reviewed-by: Petri Latvala
and merging this momentarily.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
e_display=1",
> -"live_selftests", "live");
> + const char *env = getenv("SELFTESTS");
> + char opts[1024];
> +
> + igt_assert(snprintf(opts, sizeof(opts),
> + "mock_selftests=-1 di
On Mon, Apr 01, 2019 at 04:39:24PM +0200, Guillaume Tucker wrote:
> The MIPS architecture doesn't provide the hardware atomics that are
> required for the "create-clear" sub-test such as
> __sync_add_and_fetch(). As a simple and pragmatic solution, disable
> this sub-test when building for MIPS.
_legacy:2984) CRITICAL: completed 382 cursor updated in a period
> of 30 flips, we expect to complete approximately 3840 updates, with the
> threshold set at 1920
> Subtest 2x-cursor-vs-flip-legacy failed.
>
> 2x-cursor-vs-flip-atomic and 2x-long-cursor-vs-flip-atomic also flipped
>
off-by: Chris Wilson
> Cc: Arkadiusz Hiler
> Cc: Petri Latvala
Acked-by: Petri Latvala
> ---
> tests/Makefile.sources| 5 -
> tests/{ => i915}/kms_fence_pin_leak.c | 0
> tests/meson.build | 2 +-
> 3 files changed, 5 insertions(
off-by: Chris Wilson
> ---
Remove those subtests, put them in benchmarks/ along with an ezbench
integration script?
Acked-by: Petri Latvala
> tests/intel-ci/blacklist.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
s 0.
If select() returns 0, errno is unspecified, the main reason for the
separation.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
her it's correct and/or required to add your own S-o-b to
resends is another matter.
> Maybe we need some clarification on this?
>
> https://lists.freedesktop.org/archives/intel-gfx/2018-November/183291.html
That was about a kernel patch, and kernel patches are _very_ strict
about having to add your S-o-b.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ce: The first gem_shrink line removes the
reclaims-and-oom* subtests, and the second line (the one you added)
then removes the 'reclaim' subtest, resulting in all gem_shrink
subtests blacklisted.
--
Petri Latvala
___
Intel-gfx
On Mon, Jan 07, 2019 at 11:12:30AM +, Tvrtko Ursulin wrote:
>
> On 07/01/2019 11:01, Petri Latvala wrote:
> > On Fri, Jan 04, 2019 at 03:37:09PM +, Tvrtko Ursulin wrote:
> > > diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> > > in
On Sat, Sep 07, 2019 at 07:12:56PM +0100, Chris Wilson wrote:
> The curse of using libigt where it is not wanted; in this case calling
> drop-caches while we hold the forcewake is a recipe for a long wait.
>
> Signed-off-by: Chris Wilson
For the series:
Reviewed-by: P
Signed-off-by: Chris Wilson
Reviewed-by: Petri Latvala
> ---
> tests/kms_frontbuffer_tracking.c | 58 ++--
> 1 file changed, 56 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c
> b/tests/kms_frontbuffer_trackin
7;s debugfs filename to
hdcp_sink_capability? Ram?
Agreed, for a DRIVER_ANY-using test generic names are preferrable, but
this needs some kind of a transition plan. If i915's filename is
staying as is, both names need to be tried.
--
Petri Latvala
___
. Thanks.
> -Chris
But without telling Martin to file cibuglog filters for known issues?
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
=110764
> Signed-off-by: Chris Wilson
Reviewed-by: Petri Latvala
> ---
> tests/prime_vgem.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
> index 09e3373be..69ae8c9b0 100644
> --- a/tes
On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote:
> We want to check if the long option conflicts with one from the core.
> The check for conflicting short option already exists just above.
No, this one is checking that the val (the 0) doesn't conflict.
--
Pe
any ascii char that could be
> used in the individual test.
>
> While at it, fix the coding style to use tab rather than space.
>
> Signed-off-by: Lucas De Marchi
This is much better than requiring additional opts to begin from a particular
number.
Reviewed-by: Petri Latvala
On Wed, May 29, 2019 at 04:27:35PM -0700, Lucas De Marchi wrote:
> This is usually used by long options when working with enum to set long
> option values. So replace the strchr() with a memchr() to take that into
> account.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Petr
Lucas De Marchi
Reviewed-by: Petri Latvala
> ---
> tests/testdisplay.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> index b4f0d45f..32590547 100644
> --- a/tests/testdisplay.c
> +++
On Wed, May 29, 2019 at 04:27:37PM -0700, Lucas De Marchi wrote:
> We also accept the short option -h.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Petri Latvala
Please send (CC or otherwise) IGT patches to igt-dev in the future, please.
> ---
> lib/igt_core.c | 2 +-
&g
it wasn't seen in
> testing?
The new incarnation happens with a wedged GPU. That's a case that's
hard to come by in testing.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, Jun 03, 2019 at 11:39:25AM +0100, Tvrtko Ursulin wrote:
>
> On 03/06/2019 11:32, Petri Latvala wrote:
> > On Mon, Jun 03, 2019 at 11:19:48AM +0100, Tvrtko Ursulin wrote:
> > >
> > > On 29/05/2019 14:24, Chris Wilson wrote:
&g
On 6/5/19 12:38 AM, Lucas De Marchi wrote:
On Fri, May 31, 2019 at 07:55:45AM -0700, Lucas De Marchi wrote:
On Fri, May 31, 2019 at 12:59:35PM +0300, Petri Latvala wrote:
On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote:
We want to check if the long option conflicts with one
/tests/core_hotunplug.c
> @@ -0,0 +1,222 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright © 2019 Intel Corporation
> + */
And why GPL-2.0?
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://
ool \
> + gcc flex bison libatomic meson ninja-build xdotool \
Possibly the same comment on fedora but I'm not aware of how they
split their gcc package. Anyway, the file to check for is
'libatomic.so'.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
applies here.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Jun 14, 2019 at 02:24:53PM +0300, Ser, Simon wrote:
> On Fri, 2019-06-14 at 13:00 +0300, Petri Latvala wrote:
> > On Thu, Jun 13, 2019 at 02:53:20PM +0100, Guillaume Tucker wrote:
> > > Add libatomic to the Fedora docker image so it can link binaries that
> > &g
s_sanity_check(int fd)
> free(regions);
> }
>
> +#define rounddown(x, y) (x - (x % y))
> +#define SZ_64K (1ULL << 16)
> +
> +static void fill_unallocated(int fd, struct drm_i915_query_item *item, int
> idx,
> + bool cpu_access)
> +{
ert_f(0, "unterminated batch did not trigger an hang!");
> + igt_assert_f(0, "unterminated batch did not trigger a hang!");
Ouch, this is a bug that could use a drive-by fix in this same commit:
Add a newline after that text.
With that
at wants to load the module with different params, we save some
time.
If loading the module again doesn't work we should see some fireworks
in CI results elsewhere anyway. Due to module loading problems we used
to limit them to known places (reloading tests, selftests, ...) so we
might need to revisit this topic later. But no need to FUD it at this
time.
--
Petri Latvala
5 missing lmem_size modparam support\n");
> + igt_assert_eq(igt_i915_driver_load(NULL), 0);
> + }
Does the driver load truly fail with an unknown param?
--
Petri Latvala
> +
> + i915 = __drm_open_driver(DRIVER_INTEL);
>
params_get() handily tells you if lmem_size exists.
igt_debug might not be good for that kind of a print, log buffer isn't
dumped on igt_runner timeouts. igt_info maybe, igt_warn might be
overkill.
--
Petri Latvala
> igt_require_gem(i915);
param.
>
> Signed-off-by: CQ Tang
> Signed-off-by: Matthew Auld
> Cc: Thomas Hellström
> Cc: Nirmoy Das
> Cc: Petri Latvala
> Reviewed-by: Thomas Hellström
> Reviewed-by: Nirmoy Das
> ---
> tests/i915/gem_lmem_swapping.c | 12 +++-
>
ard.pci_slot_name : IGPU_PCI);
Checked all usage of 'clients' below this, and everything handles NULL
properly.
That said, nothing seems to free() it, am I reading that correctly?
Anyway, that can be left for another patch, this change is
Reviewed-by: Petri Latvala
> init_engine_classes(engines);
> if (clients) {
> clients->num_classes = engines->num_classes;
> --
> 2.32.0
>
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Petri Latvala
> ---
> lib/igt_drm_fdinfo.c | 8
> lib/igt_drm_fdinfo.h | 4 ++--
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c
> index b422f67a4ace..250d9e
On Fri, May 27, 2022 at 11:50:42AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Be nice and explicitly free all memory on exit.
>
> Also fix a Valgrind reported unitilised conditional jump.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Petri Latvala
Re
to be more "parallel" it would be better to avoid use-after-free.
>
> With this:
>
> Reviewed-by: Zbigniew Kempczyński
Tvrtko is away this week so I made this change and merged.
--
Petri Latvala
>
> --
> Zbigniew
>
> > }
> >
> > /**
> > --
> > 2.32.0
> >
to remove __user tells me you didn't
get this header through `make headers_install`.
Also please include the used kernel sha in the commit message.
I tried to replicate this with the current drm-tip version and there
are some differences. Most probably because of not using
headers_install f
}
>
> + igt_describe("Test reponse to an invalid query call");
Typo, reponse -> response.
--
Petri Latvala
> igt_subtest("query-garbage")
> test_query_garbage(fd);
>
> + igt_describe("Test response to inva
("drm/i915: drop bo->moving dependency")
> Signed-off-by: Matthew Auld
> Cc: Christian König
> Cc: Lucas De Marchi
> Cc: Daniel Vetter
> Reviewed-by: Christian König #v1
For the record, patchwork is disabled at this time. Trybot is still up
if you want CI to ve
me to give them beyond
> 'SHORT_PREEMPT_TIMEOUT' or some such. And the whole point of the helper
> function is that the values are programmed in one place only and not used
> anywhere else. So there is no worry about repetition of magic numbers.
In about one year ev
On Wed, Nov 03, 2021 at 11:49:47AM -0700, John Harrison wrote:
> On 11/3/2021 02:36, Petri Latvala wrote:
> > On Tue, Nov 02, 2021 at 06:45:38PM -0700, John Harrison wrote:
> > > On 11/2/2021 16:34, Matthew Brost wrote:
> > > > On Thu, Oct 21, 2021 at 04:40:40PM -0
erge are fed to cibuglog only if there's
failures to keep the cpu usage required by test listing under
control. Because of that, handling premerge failures like this is a
bit awkward. Recommendation for this is to just ignore it, looks like
snb just had a bad day running anything.
On Fri, Nov 12, 2021 at 12:02:24PM +0200, Petri Latvala wrote:
> On Thu, Nov 11, 2021 at 09:57:34PM +0200, Vudum, Lakshminarayana wrote:
> > spec@arb_gpu_shader_fp64@execution@built-in-functions@fs-abs-dvec3 test is
> > not in CI bug log yet.
> >
> > So, I can address
gine_init_whitelist(struct intel_engine_cs
> *engine)
>
> wa_init_start(w, "whitelist", engine->name);
>
> - if (IS_XEHPSDV(i915))
> + if (IS_DG2(i915))
> + dg2_whitelist_build(engine);
> + else if (IS_XEHPSDV(i915))
>
erread]
>68 | pthread_setspecific(__igt_is_main_thread, (void*) 0x1);
> | ^~
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Petri Latvala
> ---
> lib/igt_core.c | 6 --
> lib/igt_thread.c | 4 +++-
On Fri, Nov 19, 2021 at 03:34:54PM +, Tvrtko Ursulin wrote:
>
> On 19/11/2021 13:53, Petri Latvala wrote:
> > On Fri, Nov 19, 2021 at 12:59:42PM +, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > .../lib/igt_thread.c: In functi
On Fri, Nov 19, 2021 at 05:41:08PM +0200, Petri Latvala wrote:
> On Fri, Nov 19, 2021 at 03:34:54PM +, Tvrtko Ursulin wrote:
> > On 19/11/2021 13:53, Petri Latvala wrote:
> > > On Fri, Nov 19, 2021 at 12:59:42PM +, Tvrtko Ursulin wrote:
> > Okay I wasn't suff
> Cc: Daniel Vetter
>
> Will someone ack this or we carry this code until it ships, if it hasn't
> already?
Does that question mean client busyness will some day return?
Either way,
Acked-by: Petri Latvala
>
> Regards,
>
> Tvrtko
>
> &
>
> igt_warn_on_f(gen > LAST_KNOWN_GEN,
> - "GEN not recognized! Test needs to be
> updated to run.");
> + "GEN not recognized! Test needs to be updated to
> run.");
>
is a value
* to cairo_format_t.
*
* To prevent going outside the enum, make cairo_format_t an int and define
* ourselves.
*/
#define CAIRO_FORMAT_RGB96F (6)
#define CAIRO_FORMAT_RGBA128F (7)
#define cairo_format_t int
#endif
and
igt_skip_on_f(status == CAIRO_STATUS_INVALID_FORMAT &&am
ssues, go to the project's
main page [2] and customize your notification settings from the bell
icon on the top of the page.
Signed-off-by: Petri Latvala
Signed-off-by: Arkadiusz Hiler
[1]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues
[2]: https://gitlab.freedesktop.org/drm/igt
om the point of view of reading a particular test.
>
> A comment above the test function seems more appropriate, at least you don't
> have to look at 2 different places to find out about a particular test.
>
>
> Unless there is some untold goal here, like producing
/Makefile.sources | 5 +
> cve/cve-2019-0155.c | 470 +++
> cve/meson.build | 12 ++
> meson.build | 1 +
Why do we need a new source directory and new install directory for
this? Can't this be in tools/?
--
Petri Latvala
___
On Fri, Nov 22, 2019 at 09:20:11AM +, Chris Wilson wrote:
> Quoting Petri Latvala (2019-11-22 09:14:07)
> > On Thu, Nov 21, 2019 at 05:19:30PM +0200, Mika Kuoppala wrote:
> > > Add vulnerability checker for cve-2019-0155
> > >
> > > v2: sync, bailout early
y: Chris Wilson
> ---
> tests/Makefile.sources | 3 -
> tests/i915/gem_cpu_reloc.c | 309 -
> tests/meson.build | 1 -
Remove igt@gem_cpu_reloc@basic from fast-feedback.testlist too.
--
Petri Latvala
__
1, t->name);
> + /* no set-domain as we want to verify the pagefault is async */
> + ptr[256] = 0;
> + igt_reset_timeout();
> +
> + munmap(ptr, 4096);
> + }
> +
> +
(i915, engine);
> > > > + igt_subtest_f("%s-invalid", name)
> > > > + test_invalid(i915, engine);
> > > > + igt_subtest_f("%s-timeout", name)
> > > > + test_timeout(i915, engine);
> > > > + }
> > > > +
> > > > + free(name);
> > > > + close(engine);
> > > > + }
> > >
> > > You probably should use __for_each_static_engine and then open sysfs
> > > nodes based on that. Gets around the dynamic subtests no-no at least.
> >
> > Defeatist!
>
> Well I have challenged this status quo a few times and now I am embracing
> it, or should I say disagreeing and committing, so bonus points all round.
> :)
Perhaps next week I'll get around to reshaping the dynamic subtests
series. Watch this space!
(Meanwhile, I hope it goes without saying, dynamic subtests are indeed
a no-no)
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
v2: Check i915_* if device is i915, otherwise check the generic name.
>
> Signed-off-by: Bhawanpreet Lakha
Merged, thanks for the patch and reviews!
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.fr
d speed up BAT on the
> > ratelimiting fi-kbl-soraka, while losing no coverage overall -- and
> > hopefully without losing any of the predictive failure coverage in BAT.
> > This stagnant bit of uAPI/uABI will remain checked by the irregular idle
> > runs.
> >
> >
r.
> Fix it.
>
> Signed-off-by: Janusz Krzysztofik
> Reviewed-by: Ewelina Musial
> ---
> Assuming the R-b: from Ewelina is sufficient, can someone push this,
> please? I can't do that myself as I have no push permissions.
>
Pushed,
and dynamic engine enumeration.
> >
> > This patch makes one more step in that direction by removing the
> > dependency on the static list when generating probed engine names.
> >
> > Signed-off-by: Tvrtko Ursulin
> > Cc: Andi Shyti
> &
On Thu, Jan 23, 2020 at 12:01:34PM +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Quick fixup to the test so correct way of iterating the static engine list
> is used. More comprehensive fixes to the test are in progress.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed
igned-off-by: Chris Wilson
> Cc: Petri Latvala
> ---
> tests/intel-ci/blacklist.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index 948b47569..184c23c37 100644
> --- a/tests
Lakshmi, see below.
On Tue, Mar 17, 2020 at 09:53:51AM +0100, Janusz Krzysztofik wrote:
> Hi,
>
> On Mon, 2020-03-16 at 19:25 +, Patchwork wrote:
> > == Series Details ==
> >
> > Series: tests/gem_userptr_blits: Refresh other now MMAP_GTT dependent
> > subtests (rev2)
> > URL : https://pa
On Mon, Mar 30, 2020 at 06:55:32PM -0300, Melissa Wen wrote:
> Typo found in word transparent.
> Correct the word transparant, replacing the last letter -a- with -e-
> (transpar-a-nt to transpar-e-nt).
>
> Signed-off-by: Melissa Wen
Reviewed-by: Petri Latvala
Martin, test r
On Mon, Mar 30, 2020 at 06:56:36PM -0300, Melissa Wen wrote:
> Generalize description of fd since it is not restricted to i915 driver fd
>
> Signed-off-by: Melissa Wen
Reviewed-by: Petri Latvala
Please send future IGT patches to igt-...@lists.freedesktop.o
On Mon, Apr 06, 2020 at 09:53:09AM +0100, Chris Wilson wrote:
> An important ingredient to using igt_subtest_with_dynamic is to include
> an igt_dynamic at some point.
>
> Reported-by: Petri Latvala
> Fixes: 311cb1b360b7 ("i915/perf_pmu: Dynamic active engine tests"
gt; > On ARM (32bits), this cast creates a compilation error since the
> > > pointer size isn't an uint64_t.
> >
> > Does casting to uintptr_t before uint64_t fix it?
>
> It does yep. Casting to uintptr_t alone also works
to_user_pointer(out_fence_ptr)
--
Petri L
gt; helper,
> - call igt_abort_on_f() on device reopen failure (Petri),
> - if any timeout set with igt_set_timeout() inside a subtest expires,
> call igt_abort_on_f() from a follow-up igt_fixture (Petri),
> - when running on a i915 device, require GEM and call
>
On Fri, Jan 31, 2020 at 02:12:33PM +0100, Janusz Krzysztofik wrote:
> I'm adding a cover letter in case it is required for having a related
> kernel side patch been tested with this one.
For the record, Test-With doesn't require the IGT side to have a cover
letter.
-
On Mon, Feb 10, 2020 at 10:11:35AM +, Chris Wilson wrote:
> In hindsignt,
Your h is damaged.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ase.c
> @@ -0,0 +1,346 @@
> +// Copyright (C) 2020 Intel Corporation
> +//
> +// SPDX-License-Identifier: MIT
We don't use SPDX headers in IGT, please use the MIT license comment
block instead.
--
Petri Latvala
> +
> +#include
> +
> +#include
> +
> +#inc
1 - 100 of 508 matches
Mail list logo
