On Mon, Apr 06, 2020 at 09:53:09AM +0100, Chris Wilson wrote: > An important ingredient to using igt_subtest_with_dynamic is to include > an igt_dynamic at some point. > > Reported-by: Petri Latvala <[email protected]> > Fixes: 311cb1b360b7 ("i915/perf_pmu: Dynamic active engine tests") > Signed-off-by: Chris Wilson <[email protected]> > Cc: Petri Latvala <[email protected]>
Thanks, Reviewed-by: Petri Latvala <[email protected]> If someone (tm) is feeling like there's not enough to do, perf_pmu could use a refactoring with the dynamic subtests to do igt_subtest_with_dynamic() { igt_require(system-wide things); igt_dynamic_f() { igt_require(engine-specific thing); } } so that skips happen for a whole subtest at a time for things like gen checks. _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
