Re: [PATCH v2] drm/xe/guc: Add GuC based register capture for error capture

2024-01-16 Thread Dong, Zhanjun
Basically follows i915 design . Sysfs command process. Xe switched to devcoredump, adopted command line process with captured list. Signed-off-by: Zhanjun Dong Zhanjun Dong (9): drm/xe/guc: Add register defines for GuC based register capture drm/xe/guc: Expose dss per group

Re: [Intel-gfx] [PATCH] drm/i915: Skip pxp init if gt is wedged

2023-11-01 Thread Dong, Zhanjun
On 2023-10-31 5:38 p.m., Teres Alexis, Alan Previn wrote: On Fri, 2023-10-27 at 10:13 +0300, Jani Nikula wrote: On Thu, 26 Oct 2023, Zhanjun Dong wrote: alan:snip I'll note that nobody checks intel_pxp_init() return status, so this silently skips PXP. BR, Jani. alan:snip + if

Re: [Intel-gfx] [PATCH 3/3] drm/i915/mtl: Add counters for engine busyness ticks

2023-10-19 Thread Dong, Zhanjun
See comments inline below. Zhanjun On 2023-09-22 6:25 p.m., john.c.harri...@intel.com wrote: From: Umesh Nerlige Ramappa In new version of GuC engine busyness, GuC provides engine busyness ticks as a 64 bit counter. Add a new counter to relay this value to the user as is. Signed-off-by:

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-22 Thread Dong, Zhanjun
> -Original Message- > From: Daniel Vetter > Sent: August 22, 2023 9:51 AM > To: Dong, Zhanjun > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > Harrison, > John C ; Andi Shyti ; > Daniel Vetter > Subject: Re: [PATCH v5] drm/i

Re: [Intel-gfx] [PATCH v4] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-08 Thread Dong, Zhanjun
Hi Daniel, On 2023-08-03 9:03 a.m., Daniel Vetter wrote: On Thu, 27 Jul 2023 at 22:13, Zhanjun Dong wrote: This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset. Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version

Re: [Intel-gfx] [PATCH v4] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-08 Thread Dong, Zhanjun
Hi Andi, On 2023-08-03 8:36 a.m., Andi Shyti wrote: Hi Zhanjun, On Thu, Jul 27, 2023 at 01:13:23PM -0700, Zhanjun Dong wrote: This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset. Switched from cancel_delayed_work_sync to cancel_delayed_work, the

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting

2023-06-23 Thread Dong, Zhanjun
Hi Fei, Thanks for review. I put my answers inline below. Regards, Zhanjun On 2023-06-22 6:20 p.m., Yang, Fei wrote: > The previouse i915_gem_object_create_internal already set it with proper > value before function return. This hard coded setting is incorrect for > platforms like MTL, thus

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting

2023-06-22 Thread Dong, Zhanjun
Resend to restart the CI, https://patchwork.freedesktop.org/series/119485/ Was stuck. Regards, Zhanjun On 2023-06-22 11:26 a.m., Zhanjun Dong wrote: The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect

Re: [Intel-gfx] [PATCH v3] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-15 Thread Dong, Zhanjun
V3 is to follow John's suggestion option 1. The better option is in discussion and might have boarder impact. Meanwhile we can start with option 1, check CI system report and see if issue getting better. Regards, Zhanjun Dong On 2023-06-15 5:15 p.m., Zhanjun Dong wrote: This attempts to

Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-08 Thread Dong, Zhanjun
moving forward. Regards, Zhanjun Dong From: Harrison, John C Sent: June 7, 2023 4:17 PM To: Dong, Zhanjun ; intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Nerlige Ramappa, Umesh ; Ceraolo Spurio, Daniele Subject: Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking

Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-08 Thread Dong, Zhanjun
Hi Andi, Thanks for comments. Info would be updated on next revision, which is on the way. Regards, Zhanjun Dong On 2023-06-07 8:19 p.m., Andi Shyti wrote: Hi Dong, On Wed, Jun 07, 2023 at 12:03:50PM -0700, Zhanjun Dong wrote: This attempts to avoid circular locking dependency between

Re: [Intel-gfx] [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-06-08 Thread Dong, Zhanjun
> -Original Message- > From: Teres Alexis, Alan Previn > Sent: June 8, 2023 2:31 PM > To: Dong, Zhanjun ; intel- > g...@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Subject: Re: [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes > befo

Re: [Intel-gfx] [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-06-08 Thread Dong, Zhanjun
See my comments below. > -Original Message- > From: Alan Previn > Sent: May 30, 2023 1:01 PM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Alan Previn > > Subject: [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before > selftests > > On MTL,

Re: [Intel-gfx] [PATCH] drm/i915: Set wedged if enable guc communication failed

2023-03-02 Thread Dong, Zhanjun
Thanks Jani. Updated patch sent, let me know if you have any comments. Regards, Zhanjun > -Original Message- > From: Jani Nikula > Sent: February 27, 2023 6:30 AM > To: Dong, Zhanjun ; intel- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Dong,

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check for ct enabled while waiting for response

2022-07-13 Thread Dong, Zhanjun
> -Original Message- > From: Dixit, Ashutosh > Sent: July 12, 2022 3:48 PM > To: Dong, Zhanjun > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Check for ct enabled while > waiting for respons

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response

2022-06-14 Thread Dong, Zhanjun
Thanks for all comments, I will update code and prepare for next version. Regards, Zhanjun -Original Message- From: Dixit, Ashutosh Sent: June 14, 2022 12:28 PM To: Dong, Zhanjun Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Teres Alexis, Alan Previn