Re: [PATCH v3 4/5] ASoC: codecs: hda: Cleanup error messages

2024-02-28 Thread Mark Brown
On Mon, Feb 26, 2024 at 01:44:31PM +0100, Cezary Rojewski wrote: > Be cohesive and use same pattern in each error message. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v3 3/5] ASoC: Intel: avs: Ignore codecs with no suppoting driver

2024-02-28 Thread Mark Brown
the HDAudio controller if this is the case. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v3 2/5] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing

2024-02-28 Thread Mark Brown
V. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-12 Thread Mark Brown
an alternative would be to split the patch. > > Missing Acks so far: > > - Jean Delvare / Guenter Roeck for drivers/hwmon/pwm-fan.c > > - Javier Martinez Canillas for drivers/gpu/drm/solomon/ssd130x.c > > - Liam Girdwood / Mark Brown for drivers/regulator/pwm-regul

Re: [Intel-gfx] [PATCH 00/10] drm/i915/spi: spi access for discrete graphics

2023-09-27 Thread Mark Brown
On Wed, Sep 27, 2023 at 02:11:47PM +, Usyskin, Alexander wrote: > There is a Discreet Graphic device with embedded SPI (controller & flash). > The embedded SPI is not visible to OS. > There is another HW in the chip that gates access to the controller and > exposes registers for: > region

Re: [Intel-gfx] [PATCH 00/10] drm/i915/spi: spi access for discrete graphics

2023-09-21 Thread Mark Brown
On Wed, Sep 20, 2023 at 09:00:08PM +, Winkler, Tomas wrote: > > This sounds like there's some sort of MFD rather than or as well as a flash > > chip, or possibly multiple SPI devices? > Yes, the driver doesn't talk to SPI controller directly it goes via > another layer, so all SPI standard

Re: [Intel-gfx] [PATCH 00/10] drm/i915/spi: spi access for discrete graphics

2023-09-20 Thread Mark Brown
On Wed, Sep 20, 2023 at 01:52:07PM +, Usyskin, Alexander wrote: > I've tried to register spi controller with a spi-mem ops, but I can't find a > way to connect to mtd subsystem. > I took spi-intel as example, which connects to spi-nor but it relies on JDEC > ID of flash to configure itself.

Re: [Intel-gfx] [PATCH 00/10] drm/i915/spi: spi access for discrete graphics

2023-09-12 Thread Mark Brown
On Tue, Sep 12, 2023 at 03:21:02PM +0200, Miquel Raynal wrote: > alexander.usys...@intel.com wrote on Tue, 12 Sep 2023 13:15:58 +: > > > No SPI controllers are directly visible to userspace, some SPI devices > > > are selectively exposed but that needs to be explicitly requested and is > > >

Re: [Intel-gfx] [PATCH 00/10] drm/i915/spi: spi access for discrete graphics

2023-09-12 Thread Mark Brown
On Tue, Sep 12, 2023 at 10:50:22AM +, Usyskin, Alexander wrote: > The spi controller on discreet graphics card is not visible to user-space. > Spi access flows are supported by another hardware module and relevant > registers are > available on graphics device memory bar. No SPI controllers

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-18 Thread Mark Brown
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? According to Nathan (CCed) there's still issues with the interaction with the PowerPC

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-17 Thread Mark Brown
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? I don't have any PowerPC toolchains set up - I guess one of the community builders might

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix implicit use of struct pci_dev

2021-12-13 Thread Mark Brown
On Tue, Dec 14, 2021 at 01:36:33AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix implicit use of struct pci_dev > URL : https://patchwork.freedesktop.org/series/97975/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10995_full ->

Re: [Intel-gfx] [PATCH v2] kernel/locking: Add context to ww_mutex_trylock.

2021-09-10 Thread Mark Brown
On Thu, Sep 09, 2021 at 11:32:18AM +0200, Maarten Lankhorst wrote: > This is also useful in regulator_lock_nested, which may avoid dropping > regulator_nesting_mutex in the uncontended path, so use it there. Acked-by: Mark Brown signature.asc Description: PGP signature

[Intel-gfx] linux-next: manual merge of the drm-intel tree with Linus' tree

2021-08-02 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/display/intel_display.c between commit: b4bde5554f70 ("drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs()") from Linus' tree and commits: cad83b405fe4 ("drm/i915/display:

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

2021-08-02 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/intel_device_info.c between commit: 0f9ed3b2c9ec ("drm/i915/display/cnl+: Handle fused off DSC") from the drm-intel-fixes tree and commit: a4d082fc194a ("drm/i915: rename/remove CNL

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm-next tree

2021-07-27 Thread Mark Brown
On Tue, Jul 27, 2021 at 01:41:30PM +0200, Daniel Vetter wrote: > On Tue, Jul 27, 2021 at 1:15 PM Mark Brown wrote: > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.h > > between commit: > > ebc9ac7c3dfe

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm-next tree

2021-07-27 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/vmwgfx/vmwgfx_drv.h between commit: ebc9ac7c3dfe ("drm/vmwgfx: Update device headers") from the drm-next tree and commit: be4f77ac6884 ("drm/vmwgfx: Cleanup fifo mmio handling") from the drm-misc

Re: [Intel-gfx] (subset) [PATCH 1/3] gpu: drm: replace occurrences of invalid character

2021-05-20 Thread Mark Brown
On Wed, 19 May 2021 10:15:35 +0200, Mauro Carvalho Chehab wrote: > There are some places at drm that ended receiving a > REPLACEMENT CHARACTER U+fffd ('�'), probably because of > some bad charset conversion. > > Fix them by using what it seems to be the proper > character. Applied to

Re: [Intel-gfx] [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-06 Thread Mark Brown
On Tue, Apr 06, 2021 at 09:30:36AM +0200, Uwe Kleine-König wrote: > Given that lowlevel drivers usually cannot implement exactly what a > consumer requests with pwm_apply_state() there is some rounding involved. Acked-by: Mark Brown signature.asc Description: PGP sig

Re: [Intel-gfx] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Mark Brown
On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote: > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple

Re: [Intel-gfx] [PATCH v2 25/79] docs: convert docs to ReST and rename to *.rst

2019-04-27 Thread Mark Brown
On Fri, Apr 26, 2019 at 06:46:09AM -0300, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > This is massively CCed covering a large range of subsystems and is patch > > 25 of a 79 patch series so I've no context for what's going on here or > > why... > You can s

Re: [Intel-gfx] [PATCH v2 25/79] docs: convert docs to ReST and rename to *.rst

2019-04-25 Thread Mark Brown
On Mon, Apr 22, 2019 at 10:27:14AM -0300, Mauro Carvalho Chehab wrote: > Convert the PM documents to ReST, in order to allow them to > build with Sphinx. This is massively CCed covering a large range of subsystems and is patch 25 of a 79 patch series so I've no context for what's going on here or

Re: [Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Mark Brown
On Wed, Oct 18, 2017 at 02:33:37PM +, Deucher, Alexander wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > Your conflict change affectively reverted

Re: [Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Mark Brown
On Wed, Oct 18, 2017 at 02:30:50PM +, Deucher, Alexander wrote: > The patch below effectively reverts 1e4448648333a. If you drop the patch > below, you should be fine. As I said in my followup mail I've dropped all these patches due to build failures, please resend both the pull request

Re: [Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Mark Brown
On Wed, Oct 18, 2017 at 10:57:33AM +0100, Mark Brown wrote: > I fixed it up (see below) and can carry the fix as necessary. This > is now fixed as far as linux-next is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your tree >

[Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Mark Brown
Hi all, Today's linux-next merge of the sound-asoc tree got a conflict in: drivers/gpu/drm/amd/include/amd_shared.h between commit: cfa289fd4986c ("drm/amdgpu: rename amdgpu_dpm_funcs to amd_pm_funcs") from the drm-misc tree and commit: 1e4448648333a ("drm/amdgpu Moving amdgpu asic

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

2017-10-18 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_gem_evict.c between commit: 99b169d3c2052 ("drm/i915: Fix eviction when the GGTT is idle but full") from the drm-intel-fixes tree and commit: 9c1477e83e629 ("drm/i915/selftests: Exercise

Re: [Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

2017-10-17 Thread Mark Brown
On Tue, Oct 17, 2017 at 10:11:53AM +0200, Arnd Bergmann wrote: > This merge seems fine, but it seems there was another merge > against the akpm tree that introduced a build error by reintroducing > the spin_lock_irqsave() without restoring the local variable: > drivers/gpu/drm/i915/i915_gem.c:

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

2017-10-16 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_gem.c between commit: b85577b72837e ("drm/i915: Order two completing nop_submit_request") from the drm-intel-fixes tree and commit: 5d031f4e1618b ("drm/i915: Stop asserting on set-wedged

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

2017-10-12 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_gem.c between commit: b85577b72837ee ("drm/i915: Order two completing nop_submit_request") from the drm-intel-fixes tree and commit: af7a8ffad9c58d ("drm/i915: Use rcu instead of

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

2017-10-12 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/intel_display.c between commit: 7b50f7b24cd6c ("rm/i915: Read timings from the correct transcoder in intel_crtc_mode_get()") from the drm-intel-fixes tree and commit: de330815677d8

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree

2017-10-11 Thread Mark Brown
On Tue, Oct 10, 2017 at 08:03:00AM +0100, Mark Brown wrote: > Hi all, > > After merging the drm-misc-fixes tree, today's linux-next build > (x86_allmodconfig) failed like this: > > CC [M] drivers/gpu/drm/i915/i915_gem_evict.o > drivers/gpu/drm/i915/i915_gem

Re: [Intel-gfx] [PATCH v2 5/5] ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()

2017-05-31 Thread Mark Brown
On Wed, May 31, 2017 at 10:41:52PM +0300, Andy Shevchenko wrote: > acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 > bytes. Instead we convert them to use guid_t type. At the same time we > convert current users. Acked-by: Mark Brown <broo...@kernel.org>

Re: [Intel-gfx] [PATCH 3/7] ALSA: add shell for Intel HDMI LPE audio driver

2016-12-15 Thread Mark Brown
On Thu, Dec 15, 2016 at 12:14:30PM +0100, Takashi Iwai wrote: > The interaction between i915 and audio is simple, yes, it just exposes > a few things, mmio ptr, irq, etc. But still I don't understand why > multiple layers of indirect accesses are needed *inside* lpe audio > driver itself. For

Re: [Intel-gfx] [RFC PATCH v2 0/8] Add support for Legacy Hdmi audio

2016-11-11 Thread Mark Brown
On Thu, Nov 10, 2016 at 10:35:09AM -0600, Pierre-Louis Bossart wrote: > On 11/9/16 7:19 AM, Mark Brown wrote: > > None of which is at all unusal. The Intel hardware really doesn't seem > > like the sort of special snowflake that people appear to believe it to > >

Re: [Intel-gfx] [RFC PATCH v2 0/8] Add support for Legacy Hdmi audio

2016-11-09 Thread Mark Brown
On Sun, Nov 06, 2016 at 11:42:31PM -0700, Pierre-Louis Bossart wrote: > I am all for convergence when it makes sense but I don't see how > hdmi-codec.h provides equivalent functionality for BYT/CHT with what was > suggested in this patchset -derived from VED patches- and discussed earlier > with

Re: [Intel-gfx] [PATCH v5 07/24] regulator: pwm: use pwm_get_args() where appropriate

2016-04-15 Thread Mark Brown
On Thu, Apr 14, 2016 at 09:17:27PM +0200, Boris Brezillon wrote: > The PWM framework has clarified the concept of reference PWM config > (the platform dependent config retrieved from the DT or the PWM > lookup table) and real PWM state. Acked-by: Mark Brown <broo...@kernel.org>

Re: [Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-04-12 Thread Mark Brown
On Tue, Apr 12, 2016 at 10:37:22AM +0200, Boris Brezillon wrote: > Mark Brown <broo...@kernel.org> wrote: > > On Thu, Apr 07, 2016 at 11:54:31PM +0200, Boris Brezillon wrote: > > I'm not sure there's a strong one, we don't really use the class device > > for anythin

Re: [Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-04-11 Thread Mark Brown
On Thu, Apr 07, 2016 at 11:54:31PM +0200, Boris Brezillon wrote: > Is there any reason for calling set_machine_constraints() after > device_register() in regulator_register()? I'm not sure there's a strong one, we don't really use the class device for anything, but without doing a full audit I

Re: [Intel-gfx] [PATCH v5 27/46] regulator: pwm: adjust PWM config at probe time

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 10:03:50PM +0200, Boris Brezillon wrote: > The PWM attached to a PWM regulator device might have been previously > configured by the bootloader. > Make sure the bootloader and linux config are in sync, and adjust the PWM > config if that's not the case. Ac

Re: [Intel-gfx] [PATCH v5 28/46] regulator: pwm: swith to the atomic PWM API

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 10:03:51PM +0200, Boris Brezillon wrote: > pwm_config/enable/disable() have been deprecated in favor of > pwm_apply_state(). > Replace all those calls with the equivalent pwm_get/apply_state(). Acked-by: Mark Brown <broo...@kernel.org> signature.asc D

Re: [Intel-gfx] [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

2016-03-30 Thread Mark Brown
ce > rounded the set_duty_cycle request. > Moreover, this value is not valid until someone has modified the regulator > output. Acked-by: Mark Brown <broo...@kernel.org> signature.asc Description: PGP signature ___ Intel-gfx mailing list Inte

Re: [Intel-gfx] linux-next: manual merge of the drm-intel tree with the tree

2014-09-03 Thread Mark Brown
On Wed, Sep 03, 2014 at 02:31:46PM +0100, Mark Brown wrote: @@ -3923,7 +3942,9 @@ static void valleyview_irq_uninstall(struct drm_device *dev) I915_WRITE(VLV_MASTER_IER, 0); - for_each_pipe(pipe) + intel_hpd_irq_uninstall(dev_priv); + + for_each_pipe(dev_priv, pipe

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the tree

2014-09-03 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict which I'm not really sure of and commit b47d1189da119e (drm/i915: Use dev_priv as first argument of for_each_pipe()) from the drm-intel tree. I fixed it up (see below) and can carry the fix as necessary (no action is

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the tree

2014-03-09 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in between commit 27d50c82714f6 (ACPI / i915: Fix incorrect acpi/acpi.h inclusions via linux/acpi_io.h) from tree and commit 2fae6a860ca9 (drm/i915: Go OCD on the Makefile) from the drm-intel tree. I fixed it up (see

[Intel-gfx] linux-next: manual merge of the drm-intel tree

2013-10-10 Thread Mark Brown
Today's linux-next merge of the drm-intel tree got additional conflicts in drivers/gpu/drm/i915/intel_drv.h as a result of interactions between 6aba5b6cf098 (drm/i915/dp: get rid of intel_dp-link_configuration) and various commits from Paulo Zanoni staticising functions. I've fixed up by changing

[Intel-gfx] Conflict in merge of the the drm-intel tree

2013-10-04 Thread Mark Brown
While merging the drm-intel tree into -next there were conflicts in drivers/gpu/drm/i915/intel_dp.c between 0cc4b69960 (drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio) in the drm tree and 18b5992c37 (drm/i915: Calculate PSR register offsets from base + gen) from the

[Intel-gfx] Build failure after merge of the drm-intel tree

2013-10-03 Thread Mark Brown
for today: From 4f4dccef92d64393e2a7e867f7c2755c09178c48 Mon Sep 17 00:00:00 2001 From: Mark Brown broo...@linaro.org Date: Thu, 3 Oct 2013 18:10:55 +0100 Subject: [PATCH] drm/i915: Resolve interaction with drm-fixes tree Signed-off-by: Mark Brown broo...@linaro.org --- drivers/gpu/drm/i915