Re: [Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement
Hi Rodrigo/Andi,
> -Original Message-
> From: Vivi, Rodrigo
> Sent: Wednesday, September 6, 2023 7:38 PM
> To: Andi Shyti
> Cc: Sripada, Radhakrishna ; intel-
> g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement
>
> On Wed, Sep 06, 2023 at 11:25:35AM +0200, Andi Shyti wrote:
> > Hi Radhakrishna,
> >
> > On Tue, Sep 05, 2023 at 12:36:24PM -0700, Radhakrishna Sripada wrote:
> > > Meteorlake has been very usable for a while now, all of uapi changes
> > > related to fundamental platform usage have been finalized and all
> > > required firmware blobs are available. Recent CI results have also
> > > been healthy, so we're ready to drop the force_probe requirement and
> > > enable the platform by default.
> > >
> > > Cc: Rodrigo Vivi
> > > Cc: Tvrtko Ursulin
> > > Cc: Joonas Lahtinen
> > > Cc: Jani Nikula
> > > Signed-off-by: Radhakrishna Sripada
> >
> > Please keep me in the loop as well... It's been a year I've been
> > working for this patch to work :)
Sure will do.
> >
> > > ---
> > > drivers/gpu/drm/i915/i915_pci.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_pci.c
> b/drivers/gpu/drm/i915/i915_pci.c
> > > index df7c261410f7..fe748906c06f 100644
> > > --- a/drivers/gpu/drm/i915/i915_pci.c
> > > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > > @@ -836,7 +836,6 @@ static const struct intel_device_info mtl_info = {
> > > .has_pxp = 1,
> > > .memory_regions = REGION_SMEM | REGION_STOLEN_LMEM,
> > > .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),
> > > - .require_force_probe = 1,
> >
> > What's the thinking behind this patch? Are you trying to
> > understand how CI behaves?
>
> CI uses kernel config to force_probe. MTL is already being tested there.
> Also there's no 'CI' or 'HAX' tag on this patch.
> So I would assume this is the ask to remove the protection.
> But based on this question from Andi and knowing that he is working on
> the MTL w/a I'm assuming that this is not the right time yet to remove
> this protection.
>
> Please ensure all the diligence is taken before sending this patch again.
>
> Also ensure that the current CI failures are fixed (gt_pm and gt_engines)
> and that CI has a stable green picture.
Sure Rodrigo. I believe the changes in
https://patchwork.freedesktop.org/series/123329/
are significant enough to not remove force_probe at this time.
Will wait for a later time till CI comes clean.
Thanks,
Radhakrishna
>
> Thanks,
> Rodrigo.
>
> >
> > Andi
> >
> > > MTL_CACHELEVEL,
> > > };
> > >
> > > --
> > > 2.34.1
Re: [Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement
On Wed, Sep 06, 2023 at 11:25:35AM +0200, Andi Shyti wrote:
> Hi Radhakrishna,
>
> On Tue, Sep 05, 2023 at 12:36:24PM -0700, Radhakrishna Sripada wrote:
> > Meteorlake has been very usable for a while now, all of uapi changes
> > related to fundamental platform usage have been finalized and all
> > required firmware blobs are available. Recent CI results have also
> > been healthy, so we're ready to drop the force_probe requirement and
> > enable the platform by default.
> >
> > Cc: Rodrigo Vivi
> > Cc: Tvrtko Ursulin
> > Cc: Joonas Lahtinen
> > Cc: Jani Nikula
> > Signed-off-by: Radhakrishna Sripada
>
> Please keep me in the loop as well... It's been a year I've been
> working for this patch to work :)
>
> > ---
> > drivers/gpu/drm/i915/i915_pci.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c
> > b/drivers/gpu/drm/i915/i915_pci.c
> > index df7c261410f7..fe748906c06f 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -836,7 +836,6 @@ static const struct intel_device_info mtl_info = {
> > .has_pxp = 1,
> > .memory_regions = REGION_SMEM | REGION_STOLEN_LMEM,
> > .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),
> > - .require_force_probe = 1,
>
> What's the thinking behind this patch? Are you trying to
> understand how CI behaves?
CI uses kernel config to force_probe. MTL is already being tested there.
Also there's no 'CI' or 'HAX' tag on this patch.
So I would assume this is the ask to remove the protection.
But based on this question from Andi and knowing that he is working on
the MTL w/a I'm assuming that this is not the right time yet to remove
this protection.
Please ensure all the diligence is taken before sending this patch again.
Also ensure that the current CI failures are fixed (gt_pm and gt_engines)
and that CI has a stable green picture.
Thanks,
Rodrigo.
>
> Andi
>
> > MTL_CACHELEVEL,
> > };
> >
> > --
> > 2.34.1
Re: [Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement
> > Meteorlake has been very usable for a while now, all of uapi changes > > related to fundamental platform usage have been finalized and all > > required firmware blobs are available. Recent CI results have also > > been healthy, so we're ready to drop the force_probe requirement and > > enable the platform by default. > > > > Cc: Rodrigo Vivi > > Cc: Tvrtko Ursulin > > Cc: Joonas Lahtinen > > Cc: Jani Nikula > > Signed-off-by: Radhakrishna Sripada > > Please keep me in the loop as well... It's been a year I've been > working for this patch to work :) not just me, but also (in alphabetical order): Andrzej Hajda Chris Wilson Janusz Krzysztofik Jonathan Cavitt Nirmoy Das Thanks! Andi
Re: [Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement
Hi Radhakrishna,
On Tue, Sep 05, 2023 at 12:36:24PM -0700, Radhakrishna Sripada wrote:
> Meteorlake has been very usable for a while now, all of uapi changes
> related to fundamental platform usage have been finalized and all
> required firmware blobs are available. Recent CI results have also
> been healthy, so we're ready to drop the force_probe requirement and
> enable the platform by default.
>
> Cc: Rodrigo Vivi
> Cc: Tvrtko Ursulin
> Cc: Joonas Lahtinen
> Cc: Jani Nikula
> Signed-off-by: Radhakrishna Sripada
Please keep me in the loop as well... It's been a year I've been
working for this patch to work :)
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index df7c261410f7..fe748906c06f 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -836,7 +836,6 @@ static const struct intel_device_info mtl_info = {
> .has_pxp = 1,
> .memory_regions = REGION_SMEM | REGION_STOLEN_LMEM,
> .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),
> - .require_force_probe = 1,
What's the thinking behind this patch? Are you trying to
understand how CI behaves?
Andi
> MTL_CACHELEVEL,
> };
>
> --
> 2.34.1
[Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement
Meteorlake has been very usable for a while now, all of uapi changes
related to fundamental platform usage have been finalized and all
required firmware blobs are available. Recent CI results have also
been healthy, so we're ready to drop the force_probe requirement and
enable the platform by default.
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
Cc: Joonas Lahtinen
Cc: Jani Nikula
Signed-off-by: Radhakrishna Sripada
---
drivers/gpu/drm/i915/i915_pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index df7c261410f7..fe748906c06f 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -836,7 +836,6 @@ static const struct intel_device_info mtl_info = {
.has_pxp = 1,
.memory_regions = REGION_SMEM | REGION_STOLEN_LMEM,
.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),
- .require_force_probe = 1,
MTL_CACHELEVEL,
};
--
2.34.1
