Re: [Intel-gfx] [PATCH] drm/i915: Add i915 perf infrastructure

2016-10-20 Thread Joonas Lahtinen
On ke, 2016-10-19 at 17:35 +0100, Robert Bragg wrote: > I'll add a default: with MISSING_CASE as that looks like an i915- > specific convention; though it seems like a real shame to defer > missing case issues to runtime errors instead of taking advantage of > the compiler complaining at build time

Re: [Intel-gfx] [PATCH] drm/i915: Add i915 perf infrastructure

2016-10-19 Thread Robert Bragg
On Wed, Oct 12, 2016 at 12:41 PM, Joonas Lahtinen < joonas.lahti...@linux.intel.com> wrote: > On ti, 2016-10-11 at 12:03 -0700, Robert Bragg wrote: > > > > + case DRM_I915_PERF_PROP_MAX: > > > > + BUG(); > > > > > > We already handle this case above, but I guess

Re: [Intel-gfx] [PATCH] drm/i915: Add i915 perf infrastructure

2016-10-12 Thread Joonas Lahtinen
On ti, 2016-10-11 at 12:03 -0700, Robert Bragg wrote: > > > +               case DRM_I915_PERF_PROP_MAX: > > > +                       BUG(); > > > > We already handle this case above, but I guess we still need this in > > order to silence gcc... > > right, and preferable to having a default: cas

Re: [Intel-gfx] [PATCH] drm/i915: Add i915 perf infrastructure

2016-10-11 Thread Robert Bragg
On Fri, Oct 7, 2016 at 10:10 AM, Matthew Auld < matthew.william.a...@gmail.com> wrote: > On 14 September 2016 at 16:32, Robert Bragg wrote: > > > + > > +int i915_perf_open_ioctl_locked(struct drm_device *dev, > > + struct drm_i915_perf_open_param *param, > > +

Re: [Intel-gfx] [PATCH] drm/i915: Add i915 perf infrastructure

2016-10-07 Thread Matthew Auld
On 14 September 2016 at 16:32, Robert Bragg wrote: > Adds base i915 perf infrastructure for Gen performance metrics. > > This adds a DRM_IOCTL_I915_PERF_OPEN ioctl that takes an array of uint64 > properties to configure a stream of metrics and returns a new fd usable > with standard VFS system cal

[Intel-gfx] [PATCH] drm/i915: Add i915 perf infrastructure

2016-09-14 Thread Robert Bragg
Adds base i915 perf infrastructure for Gen performance metrics. This adds a DRM_IOCTL_I915_PERF_OPEN ioctl that takes an array of uint64 properties to configure a stream of metrics and returns a new fd usable with standard VFS system calls including read() to read typed and sized records; ioctl()