Re: [Intel-gfx] [PATCH i-g-t] tools/intel_reg: Fix segfault in intel_reg dump

2018-02-02 Thread Mika Kuoppala
Mika Kuoppala writes: > We need to zero out the builtin reg spec we are parsing into. > Otherwise engine will be uninitialized and we segfault when trying > to find engine and accessing reg->engine in later stage. > Chris combined both file and builting based

[Intel-gfx] [PATCH i-g-t] tools/intel_reg: Fix segfault in intel_reg dump

2018-02-02 Thread Mika Kuoppala
We need to zero out the builtin reg spec we are parsing into. Otherwise engine will be uninitialized and we segfault when trying to find engine and accessing reg->engine in later stage. v2: use {} (Jani) Fixes: 7f0be0e7d9be ("tools/intel_reg: Add reading and writing registers through engine")

Re: [Intel-gfx] [PATCH i-g-t] tools/intel_reg: Fix segfault in intel_reg dump

2018-02-02 Thread Jani Nikula
On Fri, 02 Feb 2018, Mika Kuoppala wrote: > We need to zero out the builtin reg spec we are parsing into. > Otherwise engine will be uninitialized and we segfault when trying > to find engine and accessing reg->engine in later stage. > > Fixes: 7f0be0e7d9be

[Intel-gfx] [PATCH i-g-t] tools/intel_reg: Fix segfault in intel_reg dump

2018-02-02 Thread Mika Kuoppala
We need to zero out the builtin reg spec we are parsing into. Otherwise engine will be uninitialized and we segfault when trying to find engine and accessing reg->engine in later stage. Fixes: 7f0be0e7d9be ("tools/intel_reg: Add reading and writing registers through engine") Bugzilla: