On 6 August 2014 00:51, Rodrigo Vivi rodrigo.v...@intel.com wrote:
From: Ramalingam C ramalinga...@intel.com
This change uses the HPD pins live status bit from
South Display Engine(SDE) to identify the HDMI hotplug state.
ibx_digital_port_connected?
I think a lot of this patch exists
On Wed, Aug 6, 2014 at 3:32 AM, Zhao, Yakui yakui.z...@intel.com wrote:
After the GPU hang occurs on BSD ring during decoding, it needs to
specify the corresponding BSD ring to read the decoding status registers
related with the BSD ring.
Can this be regarded as one open-source
On Tue, Aug 05, 2014 at 10:07:13AM -0700, Rodrigo Vivi wrote:
BDW has many other Display Engine interrupts and GT interrupts registers.
Collecting it properly on gpu_error_state.
On debugfs all was properly listed already but besides we were also listing
old
DEIER and GTIER that doesn't
On Wed, Aug 06, 2014 at 09:55:27AM +0530, sonika.jin...@intel.com wrote:
From: Sonika Jindal sonika.jin...@intel.com
Reset rotation property to 0.
v2: Resetting after disabling the plane
Signed-off-by: Sonika Jindal sonika.jin...@intel.com
Reviewed-by: Ville Syrjälä
On Tue, Aug 05, 2014 at 07:51:14AM -0700, Rodrigo Vivi wrote:
From: Chris Wilson ch...@chris-wilson.co.uk
If we try to execute on a known ring, but it has failed to be
initialised correctly, report that the GPU is hung rather than the
command invalid. This leaves us reporting EINVAL only if
On Tue, Aug 05, 2014 at 07:51:16AM -0700, Rodrigo Vivi wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
If the object is already UC leave it as UC instead of automagically
promoting it to WT in i915_gem_object_pin_to_display_plane() when
the hardware is WT capable.
Supposedly the
From: Sonika Jindal sonika.jin...@intel.com
Reset rotation property to 0.
v2: Resetting after disabling the plane
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Sonika Jindal sonika.jin...@intel.com
Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
From: Chris Wilson ch...@chris-wilson.co.uk
i915.ko has a custom fbdev initialisation routine that aims to preserve
the current mode set by the BIOS, unless overruled by the user. The
user's wishes are determined by what, if any, mode is specified on the
command line (via the video= parameter).
On Wed, Aug 06, 2014 at 09:56:45AM +0200, Daniel Vetter wrote:
On Tue, Aug 05, 2014 at 07:51:14AM -0700, Rodrigo Vivi wrote:
From: Chris Wilson ch...@chris-wilson.co.uk
If we try to execute on a known ring, but it has failed to be
initialised correctly, report that the GPU is hung rather
On Tue, Aug 05, 2014 at 07:51:15AM -0700, Rodrigo Vivi wrote:
From: Chris Wilson ch...@chris-wilson.co.uk
In the move over to use BIOS connector configs, we lost the ability to
force a specific set of connectors on or off. Try to remedy that by
dropping back to the old behavior if we detect
On Tue, Aug 05, 2014 at 07:51:17AM -0700, Rodrigo Vivi wrote:
From: Chris Wilson ch...@chris-wilson.co.uk
We duplicated the legacy physical HWS setup routine for no good reason.
Combine it with the more recent virtual HWS setup for simplicity.
Signed-off-by: Chris Wilson
-Original Message-
From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch]
Sent: Monday, August 04, 2014 3:19 PM
To: Intel Graphics Development
Cc: Daniel Vetter; Thierry, Michel; Ville Syrjälä
Subject: [PATCH] drm/i915: Initialize the aliasing ppgtt as part of global gtt
Stuffing
On Tue, Aug 05, 2014 at 07:51:18AM -0700, Rodrigo Vivi wrote:
From: Jesse Barnes jbar...@virtuousgeek.org
sanitize_enable_ppgtt is the function that checks all the conditions,
honoring a forced ppgtt status or doing auto-detect as necessary. Just
make sure it returns the right value in all
On Tue, Aug 05, 2014 at 07:51:19AM -0700, Rodrigo Vivi wrote:
From: Jesse Barnes jbar...@virtuousgeek.org
Put hw limitations first, disabling ppgtt if necessary right away.
After that, check user passed args or auto-detect and do the right
thing, falling back to aliasing PPGTT if the user
On Tue, Aug 05, 2014 at 07:51:20AM -0700, Rodrigo Vivi wrote:
From: Deepak S deepa...@linux.intel.com
We might be leaving the PGU Frequency (and thus vnn) high during the suspend.
Flusing the delayed work queue should take care of this.
Signed-off-by: Deepak S deepa...@linux.intel.com
On Tue, Aug 05, 2014 at 07:51:23AM -0700, Rodrigo Vivi wrote:
From: Vandana Kannan vandana.kan...@intel.com
Adding relevant read out comparison code, in check_crtc_state, for the new
member of crtc_config, dp_m2_n2, which was introduced to store link_m_n
values for a DP downclock mode (if
On Tue, Aug 05, 2014 at 07:51:25AM -0700, Rodrigo Vivi wrote:
From: Michel Thierry michel.thie...@intel.com
After unclaimed register detection was enabled for BDW, I started seeing
warnings while reading registers 0x4400c (DEIER) and 0x4401c (GTIER).
From Gen8, DEIER has been split per
On Wed, Aug 06, 2014 at 08:18:52AM +, Thierry, Michel wrote:
-Original Message-
From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch]
Sent: Monday, August 04, 2014 3:19 PM
To: Intel Graphics Development
Cc: Daniel Vetter; Thierry, Michel; Ville Syrjälä
Subject: [PATCH]
The current refcounting scheme is that the fb lookup idr also holds a
reference. This works out nicely bacause thus far we've always
explicitly cleaned up idr entries for framebuffers:
- Userspace fbs get removed in the rmfb ioctl or when the drm file
gets closed.
- Kernel fbs (for fbdev
On Wed, Aug 06, 2014 at 09:12:32AM +0100, Chris Wilson wrote:
On Wed, Aug 06, 2014 at 09:56:45AM +0200, Daniel Vetter wrote:
On Tue, Aug 05, 2014 at 07:51:14AM -0700, Rodrigo Vivi wrote:
From: Chris Wilson ch...@chris-wilson.co.uk
If we try to execute on a known ring, but it has
On Wed, Aug 06, 2014 at 01:26:00PM +0530, sonika.jin...@intel.com wrote:
From: Sonika Jindal sonika.jin...@intel.com
Reset rotation property to 0.
v2: Resetting after disabling the plane
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Sonika Jindal sonika.jin...@intel.com
-Original Message-
From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel
Vetter
Sent: Wednesday, August 06, 2014 9:31 AM
To: Thierry, Michel
Cc: Daniel Vetter; Intel Graphics Development
Subject: Re: [PATCH] drm/i915: Initialize the aliasing ppgtt as part of
On Wed, Aug 06, 2014 at 08:44:34AM +, Thierry, Michel wrote:
-Original Message-
From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel
Vetter
Sent: Wednesday, August 06, 2014 9:31 AM
To: Thierry, Michel
Cc: Daniel Vetter; Intel Graphics Development
-Original Message-
From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf
Of Daniel Vetter
Sent: Wednesday, August 06, 2014 9:28 AM
To: Vivi, Rodrigo
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 14/15] drm/i915: capture_reg_state
-Original Message-
From: Lespiau, Damien
Sent: Friday, August 01, 2014 3:42 PM
To: Daniel, Thomas
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 34/43] drm/i915/bdw: Make sure gpu reset
still works with Execlists
On Thu, Jul 24, 2014 at 05:04:42PM +0100,
-Original Message-
From: Lespiau, Damien
Sent: Friday, August 01, 2014 3:46 PM
To: Daniel, Thomas
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 34/43] drm/i915/bdw: Make sure gpu reset
still works with Execlists
On Thu, Jul 24, 2014 at 05:04:42PM +0100,
In drm/i915 we want to get at the video= cmdline modes even when we
don't have fbdev support enabled, so that users can always override
the kernel's initial mode selection.
But that gives us a direct depency upon the parsing code in the fbdev
subsystem. Since it's so little code just extract
On Wed, Aug 6, 2014 at 11:43 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote:
In drm/i915 we want to get at the video= cmdline modes even when we
don't have fbdev support enabled, so that users can always override
the kernel's initial mode selection.
But that gives us a direct depency upon the
From: Ville Syrjälä ville.syrj...@linux.intel.com
If there are pending page flips when the fd gets closed those page
flips may have events associated to them. When the page flip eventually
completes it will queue the event to file_priv-event_list, but that
may be too late and file_priv-event_list
From: Ville Syrjälä ville.syrj...@linux.intel.com
Warn when there are events on the file_priv-event_list just before
file_priv gets freed. This can occur if the driver doesn't clean up
pending page flip events in -preclose().
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
On Wed, Aug 6, 2014 at 3:10 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote:
The current refcounting scheme is that the fb lookup idr also holds a
reference. This works out nicely bacause thus far we've always
explicitly cleaned up idr entries for framebuffers:
- Userspace fbs get removed in
From: Sonika Jindal sonika.jin...@intel.com
Rename the defines to have levels instead of values for vswing and pre-emph
levels as the values may differ in other scenarios like low vswing of eDP 1.4
where the values are different.
v2: Keeping old and new defines (Danvet), adding description in
From: Ville Syrjälä ville.syrj...@linux.intel.com
This is mostly a repost of the earlier series [1]. Most of the patches
have been reviewed, but I have added quite a few new ones to the end to
fix various issues.
[1] http://lists.freedesktop.org/archives/dri-devel/2014-May/060518.html
Ville
From: Ville Syrjälä ville.syrj...@linux.intel.com
Make sure drm_vblank_get() never succeeds when called between
drm_vblank_off() and drm_vblank_on(). Borrow a trick from the
old drm_vblank_{pre,post}_modeset() functions and just bump
the refcount in drm_vblank_off() and drop it in
From: Ville Syrjälä ville.syrj...@linux.intel.com
Clearing the timestamps causes us to send zeroed timestamps to userspace
if they get sent out in response to the drm_vblank_off(). It's better
to send the very latest timestamp and count instead.
Testcase: igt/kms_flip/modeset-vs-vblank-race
From: Ville Syrjälä ville.syrj...@linux.intel.com
v2: Drop the drm_vblank_off() (Daniel)
Use drm_crtc_vblank_{get,put}()
Reviewed-by: Matt Roper matthew.d.ro...@intel.com
Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
From: Ville Syrjälä ville.syrj...@linux.intel.com
Move drm_update_vblank_count() to avoid forward a declaration.
No functional change.
Reviewed-by: Matt Roper matthew.d.ro...@intel.com
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
drivers/gpu/drm/drm_irq.c | 128
From: Ville Syrjälä ville.syrj...@linux.intel.com
If the vblank irq has already been disabled (via the disable timer) when
we call drm_vblank_off() sample the counter and timestamp one last time.
This will make the sure that the user space visible counter will account
for time between vblank irq
From: Ville Syrjälä ville.syrj...@linux.intel.com
Currently both drm_irq.c and several drivers call drm_vblank_put()
while holding event_lock. Now that drm_vblank_put() can disable the
vblank interrupt directly it may need to grab vbl_lock and
vblank_time_lock. That causes deadlocks since we take
From: Ville Syrjälä ville.syrj...@linux.intel.com
Declare a local struct drm_vblank_crtc * and use that
instead of having to do dig it out via 'dev-vblank[crtc]'
everywhere.
Performed with the following coccinelle incantation,
and a few manual whitespace cleanups:
@@
identifier func,member;
From: Ville Syrjälä ville.syrj...@linux.intel.com
Currently it's possible that the following will happen:
1. drm_wait_vblank() calls drm_vblank_get()
2. drm_vblank_off() gets called
3. drm_wait_vblank() calls drm_queue_vblank_event() which
adds the event to the queue event though vblank
From: Ville Syrjälä ville.syrj...@linux.intel.com
When drm_vblank_on() is called the hardware vblank counter may have
been reset, so we can't trust that the old values sampled prior to
drm_vblank_off() have anything to do with the new values.
So update the .last count in drm_vblank_on() to make
From: Ville Syrjälä ville.syrj...@linux.intel.com
Add a flag to drm_device which will cause the vblank code to bypass the
disable timer and always disable the vblank interrupt immediately when
the last reference is dropped.
v2: Add some notes about the flag to the kernel doc
Reviewed-by: Matt
From: Ville Syrjälä ville.syrj...@linux.intel.com
If the user is interested in getting accurate vblank sequence
numbers all the time they may disable the vblank disable timer
entirely. In that case it seems appropriate to kick start the
vblank interrupts already from drm_vblank_on().
v2: Adapt
From: Ville Syrjälä ville.syrj...@linux.intel.com
If we already have a timestamp for the current vblank counter, don't
update it with a new timestmap. Small errors can creep in between two
timestamp queries for the same vblank count, which could be confusing to
userspace when it queries the
From: Ville Syrjälä ville.syrj...@linux.intel.com
During vblank disable the code tries to guess based on the
timestamps whether we just missed one vblank or not. And if so
it increments the counter. However it forgets to store the new
timestamp to the approriate slot in our timestamp ring buffer.
From: Ville Syrjälä ville.syrj...@linux.intel.com
Now that the vblank races are plugged, we can opt out of using
the vblank disable timer and just let vblank interrupts get
disabled immediately when the last reference is dropped.
Gen2 is the exception since it has no hardware frame counter.
From: Ville Syrjälä ville.syrj...@linux.intel.com
We should update the last in drm_update_vblank_count() to avoid applying
the diff more than once. This could occur eg. if drm_vblank_off() gets
called multiple times for the crtc.
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
From: Ville Syrjälä ville.syrj...@linux.intel.com
We call drm_vblank_off() during crtc sanitation to make sure the
software and hardware states agree. However drm_vblank_off() will
try to update the vblank timestamp and sequence number which lands
us in some trouble.
As the pipe is disabled the
From: Ville Syrjälä ville.syrj...@linux.intel.com
Now that drm_update_vblank_count() can be called even when we're not
about to enable the vblank interrupts we shouldn't print debug messages
stating otherwise.
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
From: Ville Syrjälä ville.syrj...@linux.intel.com
The kernel might mistakenly send out a zeroed vblank timestamp when
the vblank wait gets terminated early due to crtc disable. Add an
assertion to catch that.
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
tests/kms_flip.c | 3
From: Ville Syrjälä ville.syrj...@linux.intel.com
update_scanline_offset() in intel_sanitize_crtc() was supposed to
be called only for active crtcs. But due to some underrun patches it
now gets updated for all crtcs on gmch platforms.
Move the update_scanline_offset() to the very beginning of
In drm/i915 we want to get at the video= cmdline modes even when we
don't have fbdev support enabled, so that users can always override
the kernel's initial mode selection.
But that gives us a direct depency upon the parsing code in the fbdev
subsystem. Since it's so little code just extract
On Wed, Aug 06, 2014 at 07:11:28AM -0400, Rob Clark wrote:
On Wed, Aug 6, 2014 at 3:10 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote:
The current refcounting scheme is that the fb lookup idr also holds a
reference. This works out nicely bacause thus far we've always
explicitly cleaned up
On Wed, Aug 06, 2014 at 12:27:32PM +0200, Geert Uytterhoeven wrote:
On Wed, Aug 6, 2014 at 11:43 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote:
In drm/i915 we want to get at the video= cmdline modes even when we
don't have fbdev support enabled, so that users can always override
the
On Wed, Aug 06, 2014 at 02:02:51PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
If there are pending page flips when the fd gets closed those page
flips may have events associated to them. When the page flip eventually
completes it will queue
From: Chris Wilson ch...@chris-wilson.co.uk
i915.ko has a custom fbdev initialisation routine that aims to preserve
the current mode set by the BIOS, unless overruled by the user. The
user's wishes are determined by what, if any, mode is specified on the
command line (via the video= parameter).
In drm/i915 we want to get at the video= cmdline modes even when we
don't have fbdev support enabled, so that users can always override
the kernel's initial mode selection.
But that gives us a direct depency upon the parsing code in the fbdev
subsystem. Since it's so little code just extract
On Wed, Aug 06, 2014 at 02:49:57PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
If we already have a timestamp for the current vblank counter, don't
update it with a new timestmap. Small errors can creep in between two
timestamp queries for
Hi Daniel,
I think this new patch fixes your issues with the previous one, can you please
let me know.
Thanks,
Alistair.
-Original Message-
From: Mcaulay, Alistair
Sent: Tuesday, August 05, 2014 9:47 AM
To: intel-gfx@lists.freedesktop.org
Cc: Mcaulay, Alistair
Subject: [PATCH
On Wed, Aug 06, 2014 at 02:49:58PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
We should update the last in drm_update_vblank_count() to avoid applying
the diff more than once. This could occur eg. if drm_vblank_off() gets
called multiple
On Wed, Aug 06, 2014 at 02:56:14PM +0200, Daniel Vetter wrote:
On Wed, Aug 06, 2014 at 02:49:57PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
If we already have a timestamp for the current vblank counter, don't
update it with a new
On Wed, Aug 06, 2014 at 02:49:59PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
During vblank disable the code tries to guess based on the
timestamps whether we just missed one vblank or not. And if so
it increments the counter. However it
On Wed, Aug 6, 2014 at 8:37 AM, Daniel Vetter dan...@ffwll.ch wrote:
On Wed, Aug 06, 2014 at 07:11:28AM -0400, Rob Clark wrote:
On Wed, Aug 6, 2014 at 3:10 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote:
The current refcounting scheme is that the fb lookup idr also holds a
reference. This
From: Ville Syrjälä ville.syrj...@linux.intel.com
kms_flip_event_leak will issue a page flip and close the file
descriptor before the flip has finished. This may cause the kernel
to leak the page flip event. The test itself won't actually fail but
if the kernel notices the leak and WARNs piglit
On Wed, Aug 06, 2014 at 02:49:52PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
Currently it's possible that the following will happen:
1. drm_wait_vblank() calls drm_vblank_get()
2. drm_vblank_off() gets called
3. drm_wait_vblank() calls
On Wed, Aug 06, 2014 at 02:50:00PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
We call drm_vblank_off() during crtc sanitation to make sure the
software and hardware states agree. However drm_vblank_off() will
try to update the vblank
On Wed, Aug 06, 2014 at 03:08:25PM +0200, Daniel Vetter wrote:
On Wed, Aug 06, 2014 at 02:49:58PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
We should update the last in drm_update_vblank_count() to avoid applying
the diff more than
On Wed, Aug 06, 2014 at 03:23:01PM +0200, Daniel Vetter wrote:
On Wed, Aug 06, 2014 at 02:49:52PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
Currently it's possible that the following will happen:
1. drm_wait_vblank() calls
On Wed, Aug 06, 2014 at 03:30:17PM +0200, Daniel Vetter wrote:
On Wed, Aug 06, 2014 at 02:50:00PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
We call drm_vblank_off() during crtc sanitation to make sure the
software and hardware states
On Wed, Aug 06, 2014 at 09:12:42AM -0400, Rob Clark wrote:
On Wed, Aug 6, 2014 at 8:37 AM, Daniel Vetter dan...@ffwll.ch wrote:
On Wed, Aug 06, 2014 at 07:11:28AM -0400, Rob Clark wrote:
On Wed, Aug 6, 2014 at 3:10 AM, Daniel Vetter daniel.vet...@ffwll.ch
wrote:
The current refcounting
On Wed, Aug 06, 2014 at 02:02:51PM +0300, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
If there are pending page flips when the fd gets closed those page
flips may have events associated to them. When the page flip eventually
completes it will queue
2014-08-05 18:51 GMT-03:00 Matt Roper matthew.d.ro...@intel.com:
On Tue, Aug 05, 2014 at 06:34:38PM -0300, Paulo Zanoni wrote:
2014-07-28 20:47 GMT-03:00 Matt Roper matthew.d.ro...@intel.com:
On Mon, Jul 28, 2014 at 03:37:15PM -0300, Paulo Zanoni wrote:
From: Paulo Zanoni
On Wed, Aug 06, 2014 at 04:30:29PM +0300, Ville Syrjälä wrote:
On Wed, Aug 06, 2014 at 03:08:25PM +0200, Daniel Vetter wrote:
On Wed, Aug 06, 2014 at 02:49:58PM +0300, ville.syrj...@linux.intel.com
wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
We should update the last
On Wed, Aug 06, 2014 at 11:11:41AM -0300, Paulo Zanoni wrote:
2014-08-05 18:51 GMT-03:00 Matt Roper matthew.d.ro...@intel.com:
On Tue, Aug 05, 2014 at 06:34:38PM -0300, Paulo Zanoni wrote:
2014-07-28 20:47 GMT-03:00 Matt Roper matthew.d.ro...@intel.com:
On Mon, Jul 28, 2014 at 03:37:15PM
On Tue, Aug 05, 2014 at 02:41:54PM +0100, Damien Lespiau wrote:
On Tue, Aug 05, 2014 at 08:47:54AM -0500, Jeff McGee wrote:
+
+ /* Copy SSEU info to the const device info with pointer magic */
+ *(struct intel_sseu_info *)dev_priv-info.sseu = sseu_info;
I've thought
From: Michel Thierry michel.thie...@intel.com
VMAs should take a reference of the address space they use.
Now, when the fd is closed, it will release the ref that the context was
holding, but it will still be referenced by any vmas that are still
active.
ppgtt_release() should then only be
Stuff in headers really aught to have this.
Reviewed-by: Michel Thierry michel.thie...@intel.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h | 11 ++-
drivers/gpu/drm/i915/i915_gem.c | 2 +-
2 files changed, 7 insertions(+), 6 deletions(-)
This essentially unbreaks non-ppgtt operation where we'd scribble over
random memory.
While at it give the vm_to_ppgtt function a proper prefix and make it
a bit more paranoid.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h | 10 +-
We already needs this just as a safety check in case the preallocation
reservation dance fails. But we definitely need this to be able to
move tha aliasing ppgtt setup back out of the context code to this
place, where it belongs.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
Hardware contexts reference a ppgtt, not the other way round. And the
only user of this (in debugfs) actually only cares about which file
the ppgtt is associated with. So give it what it wants.
While at it give the ppgtt create function a proper nameplace.
Reviewed-by: Michel Thierry
Include depency hell ftw! So need to move this into a real function.
Also fix up the header include order in i915_drv.h: The rule is to
always include core headers first, then local stuff.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h | 7 ---
A subsequent patch will no longer initialize the aliasing ppgtt if we
have full ppgtt enabled, since we simply don't need that any more.
Unfortunately a few places check for the aliasing ppgtt instead of
checking for ppgtt in general. Fix them up.
One special case are the gtt offset and size
So when reviewing Michel's patch I've noticed a few things and cleaned
them up:
- The early checks in ppgtt_release are now redundant: The inactive
list should always be empty now, so we can ditch these checks. Even
for the aliasing ppgtt (though that's a different confusion) since
we tear
There's a bit a confusion since we track the global gtt,
the aliasing and real ppgtt in the ctx-vm pointer. And not
all callers really bother to check for the different cases and just
presume that it points to a real ppgtt.
Now looking closely we don't actually need -vm to always point at an
Address space cleanup isn't really a job for the low-level cleanup
callbacks. Without this change we can't reuse the low-level cleanup
callback for the aliasing ppgtt cleanup.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 8 +++-
1 file
Stuffing this into the context setup code doesn't make a lot of sense.
Also reusing the real ppgtt setup code makes even less sense since the
aliasing ppgtt isn't a real address space. Leaving all that stuff
unitialized will make sure that we catch any abusers promptly.
This is also a prep work
Now that all the flow is streamlined the rule is simple: We create
a new ppgtt for a new context when we have full ppgtt enabled.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_gem_context.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
We still have locking hilarity between the console_lock and the world,
so really don't bother with it if at all possible. This shuts up a
locdep splat I'm seeing after a system s/r cycle followed by reloading
i915.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
Also remove related WARN_ONs which seem to have been hit since a rather
long time. But apperently no one noticed since our module reload is
already WARNING-infested :(
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_dma.c | 4
We want to move the aliasing ppgtt cleanup back into the global
gtt cleanup code for symmetric, but first we need to create such
a place.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_dma.c | 4 ++--
drivers/gpu/drm/i915/i915_gem_gtt.c | 20
On Tue, Aug 05, 2014 at 04:50:16PM +0200, Daniel Vetter wrote:
On Tue, Aug 5, 2014 at 4:03 PM, Jeff McGee jeff.mc...@intel.com wrote:
Also, usual broken record request: I need open-source userspace using
this (mesa, ddx, libva).
-Daniel
This is kind of chicken-and-egg problem that I
Modify drain latency computation to use it for any plane. Same function can be
used for primary, cursor and sprite planes.
v2: Adressed review comments by Imre and Ville.
- Moved clock round up in separate patch
- Added WARN check for clock and pixel size
- Simplified bit masking
On Tue, 5 Aug 2014 07:51:15 -0700
Rodrigo Vivi rodrigo.v...@intel.com wrote:
From: Chris Wilson ch...@chris-wilson.co.uk
In the move over to use BIOS connector configs, we lost the ability to
force a specific set of connectors on or off. Try to remedy that by
dropping back to the old
On Wed, Aug 06, 2014 at 09:43:44AM -0500, Jeff McGee wrote:
On Tue, Aug 05, 2014 at 04:50:16PM +0200, Daniel Vetter wrote:
On Tue, Aug 5, 2014 at 4:03 PM, Jeff McGee jeff.mc...@intel.com wrote:
Also, usual broken record request: I need open-source userspace using
this (mesa, ddx, libva).
On Thu, Aug 07, 2014 at 01:58:24AM +0530, Gajanan Bhat wrote:
Modify drain latency computation to use it for any plane. Same function can be
used for primary, cursor and sprite planes.
v2: Adressed review comments by Imre and Ville.
- Moved clock round up in separate patch
- Added
On Wed, Aug 06, 2014 at 10:30:50AM +0800, Xiang, Haihao wrote:
Enable gem_media_fill test for CHV platform. In addition to differences in
media IP blocks from Broadwell, the command sequence also differs for
programming the media pipeline, e.g., should not send a MEDIA_STATE_FLUSH
right
Hi,
alistair.mcau...@intel.com writes:
From: McAulay, Alistair alistair.mcau...@intel.com
This patch is to address Daniels concerns over different code during reset:
http://lists.freedesktop.org/archives/intel-gfx/2014-June/047758.html
The reason for aiming as hard as possible to use the
On Wed, Aug 6, 2014 at 10:07 AM, Daniel Vetter dan...@ffwll.ch wrote:
On Wed, Aug 06, 2014 at 09:12:42AM -0400, Rob Clark wrote:
On Wed, Aug 6, 2014 at 8:37 AM, Daniel Vetter dan...@ffwll.ch wrote:
On Wed, Aug 06, 2014 at 07:11:28AM -0400, Rob Clark wrote:
On Wed, Aug 6, 2014 at 3:10 AM,
Stuffing this into the context setup code doesn't make a lot of sense.
Also reusing the real ppgtt setup code makes even less sense since the
aliasing ppgtt isn't a real address space. Leaving all that stuff
unitialized will make sure that we catch any abusers promptly.
This is also a prep work
1 - 100 of 107 matches
Mail list logo
