On Thu, Jan 12, 2017 at 09:17:06PM +, Chris Wilson wrote:
> On Mon, Jan 09, 2017 at 11:19:32AM +, Chris Wilson wrote:
> > On a non-llc system, the objects are created with .cache_level =
> > CACHE_NONE and so the transition to uncached for scanout is a no-op.
> > However, if the object was
Hi Dave,
As promised a few more core fixes. One more pending for the mst issue on
driver load, but Dave Hansen didn't yet send in the tested-by, so I
figured I'll hold that one off.
cu in Hobart!
Cheers, Daniel
The following changes since commit 9afe69d5a9495f8b023017e4c328fa717e00f092:
Mer
On Wed, Jan 11, 2017 at 09:09:02PM +, Chris Wilson wrote:
> Some pieces of code are independent of hardware but are very tricky to
> exercise through the normal userspace ABI or via debugfs hooks. Being
> able to create mock unit tests and execute them through CI is vital.
> Start by adding a c
Hi,
On 11/01/2017 23:59, Andy Shevchenko wrote:
On Wed, Jan 11, 2017 at 1:58 PM, Tvrtko Ursulin wrote:
Since the scatterlist length field is an unsigned int, make
sure that sg_alloc_table_from_pages does not overflow it while
coallescing pages to a single entry.
/*
+ * Since the above le
On 12/01/2017 21:35, Chris Wilson wrote:
In the next few patches, we will depend upon there being no
uninitialised bits inside the ggtt_view. To ensure this we add the
__packed attribute and double check with a build on that gcc hasn't
expanded the struct to include some padding bytes.
Signed-o
On Fri, Jan 13, 2017 at 08:44:34AM +, Tvrtko Ursulin wrote:
>
> On 12/01/2017 21:35, Chris Wilson wrote:
> >In the next few patches, we will depend upon there being no
> >uninitialised bits inside the ggtt_view. To ensure this we add the
> >__packed attribute and double check with a build on t
On 13/01/2017 08:47, Chris Wilson wrote:
On Fri, Jan 13, 2017 at 08:44:34AM +, Tvrtko Ursulin wrote:
On 12/01/2017 21:35, Chris Wilson wrote:
In the next few patches, we will depend upon there being no
uninitialised bits inside the ggtt_view. To ensure this we add the
__packed attribute a
On 12/01/2017 21:35, Chris Wilson wrote:
In preparation for the next patch to convert to using an anonymous union
and leaving the excess bytes in the union uninitialised, we first need
to make sure we do not compare using those uninitialised bytes. We also
want to preserve the compactness of the
On 12/01/2017 21:35, Chris Wilson wrote:
As we now use a compact memcmp in i915_vma_compare(), we can forgo
clearing the entire view and only set the precise parameters used in
this view.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 1 -
1 file changed, 1 deletion(-)
dif
On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote:
> Test the low-level i915_address_space interfaces to sanity check the
> live insertion/removal of address ranges.
>
> Signed-off-by: Chris Wilson
> +static u64 scale(u64 offset, unsigned int shift)
> +{
> + return offset << shift;
> +}
On 12/01/2017 21:35, Chris Wilson wrote:
Save a lot of characters by making the union anonymous, with the
side-effect of ignoring unset bits when comparing views.
Side-effect is not happening in this patch. Always tricky what to do
with commit messages for split patches. :) Maybe just rewrite
On Fri, Jan 13, 2017 at 10:59:52AM +0200, Joonas Lahtinen wrote:
> On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote:
> > + struct i915_address_space *vm,
> > + u64 hole_start, u64 hole_end)
> > +{
> > + I915_RND_STATE(prng);
>
> Just to remind that this prng
On Fri, Jan 13, 2017 at 09:04:46AM +, Tvrtko Ursulin wrote:
>
> On 12/01/2017 21:35, Chris Wilson wrote:
> >Save a lot of characters by making the union anonymous, with the
> >side-effect of ignoring unset bits when comparing views.
>
> Side-effect is not happening in this patch. Always trick
On Mon, Jan 02, 2017 at 03:21:13PM +0100, Hans de Goede wrote:
> Hi,
>
> On 02-01-17 15:12, Ville Syrjälä wrote:
> > On Sun, Jan 01, 2017 at 09:14:00PM +0100, Hans de Goede wrote:
> >> The punit on baytrail / cherrytrail systems is not only accessed through
> >> the iosf_mbi functions, but also by
On Thu, Jan 12, 2017 at 10:56:17AM -0800, Ben Widawsky wrote:
> On 17-01-12 20:32:07, Ville Syrjälä wrote:
> >On Thu, Jan 12, 2017 at 10:00:55AM -0800, Ben Widawsky wrote:
> >> On 17-01-12 12:51:20, Ville Syrjälä wrote:
> >> >On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote:
> >> >> Thi
On Thu, Jan 12, 2017 at 07:27:03PM +, Daniel Stone wrote:
> Hi,
>
> On 12 January 2017 at 18:11, Ville Syrjälä
> wrote:
> > On Thu, Jan 12, 2017 at 05:50:15PM +, Daniel Stone wrote:
> >> struct drm_plane {
> >> struct {
> >> uint32_t format;
> >> uint64_t modifiers[];
Hey,
On 13 January 2017 at 09:37, Ville Syrjälä
wrote:
> On Thu, Jan 12, 2017 at 07:27:03PM +, Daniel Stone wrote:
>> It would make sense, but then gbm_surface_create_with_modifiers takes
>> a fixed pixel format and a list of acceptable modifiers (which to me
>> seems like the right way aroun
On Thu, Jan 12, 2017 at 12:37:46PM -0800, Rodrigo Vivi wrote:
> On Tue, Dec 20, 2016 at 03:29:54PM +0200, Ville Syrjälä wrote:
> > On Tue, Dec 20, 2016 at 03:10:53PM +0200, Ander Conselvan De Oliveira wrote:
> > > On Mon, 2016-12-19 at 19:28 +0200, ville.syrj...@linux.intel.com wrote:
> > > > From:
On 13/01/2017 08:31, Chris Wilson wrote:
On Wed, Jan 11, 2017 at 09:09:02PM +, Chris Wilson wrote:
Some pieces of code are independent of hardware but are very tricky to
exercise through the normal userspace ABI or via debugfs hooks. Being
able to create mock unit tests and execute them thr
On Fri, Jan 13, 2017 at 10:12:16AM +, Tvrtko Ursulin wrote:
>
> On 13/01/2017 08:31, Chris Wilson wrote:
> >On Wed, Jan 11, 2017 at 09:09:02PM +, Chris Wilson wrote:
> >>Some pieces of code are independent of hardware but are very tricky to
> >>exercise through the normal userspace ABI or
Naming this pair will become useful shortly...
Signed-off-by: Chris Wilson
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_gem_gtt.h | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h
b/drivers/gpu/drm/i915/i915_gem_gt
In the next few patches, we will depend upon there being no
uninitialised bits inside the ggtt_view. To ensure this we add the
__packed attribute and double check with a build bug that gcc hasn't
expanded the struct to include some padding bytes.
Signed-off-by: Chris Wilson
Reviewed-by: Tvrtko Ur
Ok, ok, this cover note only exists to continue the run on joke of my
mispellings!
Everything but
[5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union
has a r-b, so this is a good time to complain if this is too much of a
hack.
-Chris
___
Int
In preparation for the next patch to convert to using an anonymous union
and leaving the excess bytes in the union uninitialised, we first need
to make sure we do not compare using those uninitialised bytes. We also
want to preserve the compactness of the code, avoiding a second call to
memcmp or i
It is only being used to clear a struct and set the type, after which it
is overwritten. Since we no longer check the unset bits of the union,
skipping the clear is permissible.
Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ---
drivers/gp
Reading the ggtt_views is much more pleasant without the extra
characters from specifying the union (i.e. ggtt_view.partial rather than
ggtt_view.params.partial). To make this work inside i915_vma_compare()
with only a single memcmp requires us to ensure that there are no
uninitialised bytes within
As we now use a compact memcmp in i915_vma_compare(), we can forgo
clearing the entire view and only set the precise parameters used in
this view.
Signed-off-by: Chris Wilson
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_gem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drive
Since commit 058d88c4330f ("drm/i915: Track pinned VMA"), there is only
one user of i915_ggtt_view_normal rodate. Just treat NULL as no special
view in pin_to_display() like everywhere else.
Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
On 01/13/2017 11:26 AM, Ville Syrjälä wrote:
It also feels quite hand wavy since the punit could do whatever at
any time AFAIK. Eg. if there's some thermal event or something the
punit might kick into action. So trying to protect this from the OS
side might not be able to avoid these problems ent
On 13/01/2017 10:22, Chris Wilson wrote:
On Fri, Jan 13, 2017 at 10:12:16AM +, Tvrtko Ursulin wrote:
On 13/01/2017 08:31, Chris Wilson wrote:
On Wed, Jan 11, 2017 at 09:09:02PM +, Chris Wilson wrote:
Some pieces of code are independent of hardware but are very tricky to
exercise thro
On Fri, Jan 13, 2017 at 12:34:54PM +0200, Jarkko Nikula wrote:
> On 01/13/2017 11:26 AM, Ville Syrjälä wrote:
> > It also feels quite hand wavy since the punit could do whatever at
> > any time AFAIK. Eg. if there's some thermal event or something the
> > punit might kick into action. So trying to
On 13/01/2017 10:33, Chris Wilson wrote:
Ok, ok, this cover note only exists to continue the run on joke of my
mispellings!
Everything but
[5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union
has a r-b, so this is a good time to complain if this is too much of a
hack.
If you could
On Fri, Jan 13, 2017 at 10:59:46AM +, Tvrtko Ursulin wrote:
>
> On 13/01/2017 10:33, Chris Wilson wrote:
> >Ok, ok, this cover note only exists to continue the run on joke of my
> >mispellings!
> >
> >Everything but
> >[5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union
> >has a r
On 01/13/2017 12:51 PM, Ville Syrjälä wrote:
On Fri, Jan 13, 2017 at 12:34:54PM +0200, Jarkko Nikula wrote:
On 01/13/2017 11:26 AM, Ville Syrjälä wrote:
It also feels quite hand wavy since the punit could do whatever at
any time AFAIK. Eg. if there's some thermal event or something the
punit mi
On 13/01/2017 10:33, Chris Wilson wrote:
Reading the ggtt_views is much more pleasant without the extra
characters from specifying the union (i.e. ggtt_view.partial rather than
ggtt_view.params.partial). To make this work inside i915_vma_compare()
with only a single memcmp requires us to ensure
On Fri, 2017-01-13 at 09:55 +0200, Jani Nikula wrote:
> On Thu, 12 Jan 2017, Mika Kahola wrote:
> >
> > This is definitely needed to pass igt test on bxt
> >
> > 'gem_exec_suspend --run-subtest basic-S3'
> >
> > Tested-by: Mika Kahola
> >
> > On Mon, 2017-01-09 at 14:46 +0530, Vidya Srinivas
== Series Details ==
Series: series starting with [v3,1/7] drm/i915: Name the anonymous structs
inside i915_ggtt_view
URL : https://patchwork.freedesktop.org/series/17960/
State : success
== Summary ==
Series 17960v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series
On 13/01/2017 11:11, Chris Wilson wrote:
On Fri, Jan 13, 2017 at 10:59:46AM +, Tvrtko Ursulin wrote:
On 13/01/2017 10:33, Chris Wilson wrote:
Ok, ok, this cover note only exists to continue the run on joke of my
mispellings!
Everything but
[5/7] drm/i915: Convert i915_ggtt_view to use an
On pe, 2017-01-13 at 10:33 +, Chris Wilson wrote:
> Reading the ggtt_views is much more pleasant without the extra
> characters from specifying the union (i.e. ggtt_view.partial rather than
> ggtt_view.params.partial). To make this work inside i915_vma_compare()
> with only a single memcmp requ
On Fri, Jan 13, 2017 at 11:23:47AM +, Tvrtko Ursulin wrote:
>
> On 13/01/2017 11:11, Chris Wilson wrote:
> >On Fri, Jan 13, 2017 at 10:59:46AM +, Tvrtko Ursulin wrote:
> >>
> >>On 13/01/2017 10:33, Chris Wilson wrote:
> >>>Ok, ok, this cover note only exists to continue the run on joke of
On 11 January 2017 at 21:09, Chris Wilson wrote:
> Write into an object using WB, WC, GTT, and GPU paths and make sure that
> our internal API is sufficient to ensure coherent reads and writes.
>
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/i915_gem.c| 1 +
>
On Fri, Jan 13, 2017 at 01:12:15PM +0200, Jarkko Nikula wrote:
> On 01/13/2017 12:51 PM, Ville Syrjälä wrote:
> > On Fri, Jan 13, 2017 at 12:34:54PM +0200, Jarkko Nikula wrote:
> >> On 01/13/2017 11:26 AM, Ville Syrjälä wrote:
> >>> It also feels quite hand wavy since the punit could do whatever at
The function intel_ddi_get_link_dpll() was added in f169660ed4e5
("drm/i915/dp: Add a standalone function to obtain shared dpll for
HSW/BDW/SKL/BXT") to "allow for the implementation of a platform
neutral upfront link training function", but such implementation
never landed.
So remove that functio
On Thu, Jan 12, 2017 at 08:51:22AM -0800, Anusha Srivatsa wrote:
> From: Peter Antoine
>
> The HuC authentication is done by host2guc call. The HuC RSA keys
> are sent to GuC for authentication.
>
> v2: rebased on top of drm-intel-nightly.
> changed name format and upped version 1.7.
> v3: r
On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote:
> Simple test to exercise creation and lookup of VMA within an object.
>
> Signed-off-by: Chris Wilson
> +static int vma_create(struct drm_i915_private *i915,
> + struct list_head *objects,
> + struct lis
On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote:
> High-level testing of the struct drm_mm by verifying our handling of
> weird requests to i915_vma_pin.
>
> Signed-off-by: Chris Wilson
> +static int igt_vma_pin1(void *arg)
> +{
> + struct drm_i915_private *i915 = arg;
> + const s
On Fri, Jan 13, 2017 at 02:28:54PM +0200, Joonas Lahtinen wrote:
> On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote:
> > Simple test to exercise creation and lookup of VMA within an object.
> >
> > Signed-off-by: Chris Wilson
>
>
>
> > +static int vma_create(struct drm_i915_private *i915,
== Series Details ==
Series: drm/i915: Remove unused function intel_ddi_get_link_dpll()
URL : https://patchwork.freedesktop.org/series/17963/
State : success
== Summary ==
Series 17963v1 drm/i915: Remove unused function intel_ddi_get_link_dpll()
https://patchwork.freedesktop.org/api/1.0/series
On Fri, Jan 13, 2017 at 02:49:49PM +0200, Joonas Lahtinen wrote:
> On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote:
> > High-level testing of the struct drm_mm by verifying our handling of
> > weird requests to i915_vma_pin.
> >
> > Signed-off-by: Chris Wilson
>
>
>
> > +static int igt_vm
On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote:
> Mock testing to ensure we can create and lookup partial VMA.
>
> Signed-off-by: Chris Wilson
> +static int igt_vma_partial(void *arg)
> +{
> + struct drm_i915_private *i915 = arg;
> + const unsigned int npages = 1021; /* prime! */
On Fri, Jan 13, 2017 at 11:44:23AM +, Matthew Auld wrote:
> On 11 January 2017 at 21:09, Chris Wilson wrote:
> > Write into an object using WB, WC, GTT, and GPU paths and make sure that
> > our internal API is sufficient to ensure coherent reads and writes.
> >
> > Signed-off-by: Chris Wilson
On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote:
> Check we can create and execution within a context.
>
> Signed-off-by: Chris Wilson
> +static struct i915_vma *
> +gpu_fill_pages(struct i915_vma *vma,
> + unsigned long first_page,
> + unsigned int offset_in_page,
>
Rename some of the GuC fw loading code to make them more general. We
will utilise them for HuC loading as well.
s/intel_guc_fw/intel_uc_fw/g
s/GUC_FIRMWARE/INTEL_UC_FIRMWARE/g
Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members,
such as 'guc' or 'guc_fw' either is rename
The patches add HuC loading support. The driver builds a frame level
workload which is stored in the graphics memory. This workload is presented
to HuC for processing. The driver, therefore should first determine if the
HuC is enabled and also read the huC athentication status bit to determine
if H
On 12/01/17 10:21, Chris Wilson wrote:
> On Thu, Jan 12, 2017 at 07:03:25AM +0100, Juergen Gross wrote:
>> On 11/01/17 18:08, Chris Wilson wrote:
>>> On Wed, Jan 11, 2017 at 05:33:34PM +0100, Juergen Gross wrote:
With kernel 4.10rc3 running as Xen dm0 I get at each boot:
[ 49.21369
On pe, 2017-01-13 at 09:55 +0200, Jani Nikula wrote:
> On Thu, 12 Jan 2017, Mika Kahola wrote:
> > This is definitely needed to pass igt test on bxt
> >
> > 'gem_exec_suspend --run-subtest basic-S3'
> >
> > Tested-by: Mika Kahola
> >
> > On Mon, 2017-01-09 at 14:46 +0530, Vidya Srinivas wrote:
On Fri, Jan 13, 2017 at 05:03:33PM +0200, Imre Deak wrote:
> On pe, 2017-01-13 at 09:55 +0200, Jani Nikula wrote:
> > On Thu, 12 Jan 2017, Mika Kahola wrote:
> > > This is definitely needed to pass igt test on bxt
> > >
> > > 'gem_exec_suspend --run-subtest basic-S3'
> > >
> > > Tested-by: Mika
Hello,
As you may or may not be aware many distributions are switching from the
xf86-video-intel driver to the modesetting driver (with Glamor acceleration).
Debian, Arch, and now Fedora are unhappy that there has not been a stable release of
the driver in years.
- Have any of the distributi
Hi,
On 01/13/2017 10:26 AM, Ville Syrjälä wrote:
On Mon, Jan 02, 2017 at 03:21:13PM +0100, Hans de Goede wrote:
Hi,
On 02-01-17 15:12, Ville Syrjälä wrote:
On Sun, Jan 01, 2017 at 09:14:00PM +0100, Hans de Goede wrote:
The punit on baytrail / cherrytrail systems is not only accessed through
On Fri, Jan 13, 2017 at 05:06:52PM +0100, Hans de Goede wrote:
> Hi,
>
> On 01/13/2017 10:26 AM, Ville Syrjälä wrote:
> > On Mon, Jan 02, 2017 at 03:21:13PM +0100, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 02-01-17 15:12, Ville Syrjälä wrote:
> >>> On Sun, Jan 01, 2017 at 09:14:00PM +0100, Hans d
The patches add HuC loading support. The driver builds a frame level
workload which is stored in the graphics memory. This workload is presented
to HuC for processing. The driver, therefore should first determine if the
HuC is enabled and also read the huC athentication status bit to determine
if H
Rename some of the GuC fw loading code to make them more general. We
will utilise them for HuC loading as well.
s/intel_guc_fw/intel_uc_fw/g
s/GUC_FIRMWARE/INTEL_UC_FIRMWARE/g
Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members,
such as 'guc' or 'guc_fw' either is rename
The patches add HuC loading support. The driver builds a frame level
workload which is stored in the graphics memory. This workload is presented
to HuC for processing. The driver, therefore should first determine if the
HuC is enabled and also read the huC athentication status bit to determine
if H
Rename some of the GuC fw loading code to make them more general. We
will utilise them for HuC loading as well.
s/intel_guc_fw/intel_uc_fw/g
s/GUC_FIRMWARE/INTEL_UC_FIRMWARE/g
Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members,
such as 'guc' or 'guc_fw' either is rename
Add debugfs entry for HuC loading status check.
v2: rebased on top of drm-tip.
Cc: Michal wajdeczko
Tested-by: Xiang Haihao
Signed-off-by: Anusha Srivatsa
Signed-off-by: Alex Dai
Signed-off-by: Peter Antoine
Reviewed-by: Jeff McGee
Reviewed-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/i9
This patch adds the HuC Loading for the BXT by using
the updated file construction.
Version 1.7 of the HuC firmware.
v2: rebased on to top drm-tip. Rename BXT_FW_MAJOR to BXT_HUC_FW_
Cc: Micha Wajdeczko
Cc: Tvrtko Ursulin
Signed-off-by: Anusha Srivatsa
Reviewed-by: Arkadiusz Hiler
Reviewed-b
HuC firmware css header has almost exactly same definition as GuC
firmware except for the sw_version. Also, add a new member fw_type
into intel_uc_fw to indicate what kind of fw it is. So, the loader
will pull right sw_version from header.
v2: rebased on-top of drm-intel-nightly
v3: rebased. Renam
The HuC authentication is done by host2guc call. The HuC RSA keys
are sent to GuC for authentication.
v2: rebased on top of drm-tip. Changed name format and upped
version 1.7.
v3: changed wait_for_atomic to wait_for
v4: rebased. Rename intel_huc_auh() to intel_guc_auth_huc()
and place the prototyp
The HuC loading process is similar to GuC. The intel_uc_fw_fetch()
is used for both cases.
HuC loading needs to be before GuC loading. The WOPCM setting must
be done early before loading any of them.
v2: rebased on-top of drm-intel-nightly.
removed if(HAS_GUC()) before the guc call. (D.Gordon
This patch adds the support to load HuC on KBL
Version 2.0
v2: rebased on top of drm-tip. Rename KBL_FW_ to KBL_HUC_FW_
v3: rebased. Remove old checks.
Cc: Michal Wajdeczko
Cc: Tvrtko Ursulin
Signed-off-by: Anusha Srivatsa
Reviewed-by: Arkadiusz Hiler
Reviewed-by: Michal Wajdeczko
---
drive
This patch will allow for getparams to return the status of the HuC.
As the HuC has to be validated by the GuC this patch uses the validated
status to show when the HuC is loaded and ready for use. You cannot use
the loaded status as with the GuC as the HuC is verified after it is
loaded and is not
On Fri, Jan 13, 2017 at 09:06:34AM -0800, Anusha Srivatsa wrote:
> +/**
> + * huc_ucode_xfer() - DMA's the firmware
> + * @dev_priv: the drm_i915_private device
> + *
> + * Transfer the firmware image to RAM for execution by the microcontroller.
> + *
> + * Return: 0 on success, non-zero on failure
On Fri, Jan 13, 2017 at 09:07:08AM -0800, Anusha Srivatsa wrote:
> +/**
> + * intel_guc_auth_huc() - authenticate ucode
> + * @dev_priv: the drm_i915_device
> + *
> + * Triggers a HuC fw authentication request to the GuC via intel_guc_action_
> + * authenticate_huc interface.
> + */
> +void intel_g
>-Original Message-
>From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
>Sent: Friday, January 13, 2017 9:25 AM
>To: Srivatsa, Anusha
>Cc: intel-gfx@lists.freedesktop.org; Hiler, Arkadiusz
>;
>Wajdeczko, Michal ; Alex Dai
>; Peter Antoine
>Subject: Re: [PATCH 7/8] drm/i915/huc: Suppo
>-Original Message-
>From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
>Sent: Friday, January 13, 2017 9:16 AM
>To: Srivatsa, Anusha
>Cc: intel-gfx@lists.freedesktop.org; Alex Dai ; Peter Antoine
>
>Subject: Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support
>
>On Fr
Functions supporting GuC logging capabilities were spread across
many files, with unnecessary exposures and mixed with unrelated
code. Dedicate file will make maintenance of all GuC functions
easier as more functions are coming to support GuC submissions.
Signed-off-by: Michal Wajdeczko
Cc: Chris
On Fri, Jan 13, 2017 at 05:41:57PM +, Michal Wajdeczko wrote:
> Functions supporting GuC logging capabilities were spread across
> many files, with unnecessary exposures and mixed with unrelated
> code. Dedicate file will make maintenance of all GuC functions
> easier as more functions are comi
Rename some of the GuC fw loading code to make them more general. We
will utilise them for HuC loading as well.
s/intel_guc_fw/intel_uc_fw/g
s/GUC_FIRMWARE/INTEL_UC_FIRMWARE/g
Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members,
such as 'guc' or 'guc_fw' either is rename
The HuC loading process is similar to GuC. The intel_uc_fw_fetch()
is used for both cases.
HuC loading needs to be before GuC loading. The WOPCM setting must
be done early before loading any of them.
v2: rebased on-top of drm-intel-nightly.
removed if(HAS_GUC()) before the guc call. (D.Gordon
The patches add HuC loading support. The driver builds a frame level
workload which is stored in the graphics memory. This workload is presented
to HuC for processing. The driver, therefore should first determine if the
HuC is enabled and also read the huC athentication status bit to determine
if H
This patch will allow for getparams to return the status of the HuC.
As the HuC has to be validated by the GuC this patch uses the validated
status to show when the HuC is loaded and ready for use. You cannot use
the loaded status as with the GuC as the HuC is verified after it is
loaded and is not
This patch adds the HuC Loading for the BXT by using
the updated file construction.
Version 1.7 of the HuC firmware.
v2: rebased on to top drm-tip. Rename BXT_FW_MAJOR to BXT_HUC_FW_
Cc: Micha Wajdeczko
Cc: Tvrtko Ursulin
Signed-off-by: Anusha Srivatsa
Reviewed-by: Arkadiusz Hiler
Reviewed-b
Add debugfs entry for HuC loading status check.
v2: rebased on top of drm-tip.
Cc: Michal wajdeczko
Tested-by: Xiang Haihao
Signed-off-by: Anusha Srivatsa
Signed-off-by: Alex Dai
Signed-off-by: Peter Antoine
Reviewed-by: Jeff McGee
Reviewed-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/i9
HuC firmware css header has almost exactly same definition as GuC
firmware except for the sw_version. Also, add a new member fw_type
into intel_uc_fw to indicate what kind of fw it is. So, the loader
will pull right sw_version from header.
v2: rebased on-top of drm-intel-nightly
v3: rebased. Renam
This patch adds the support to load HuC on KBL
Version 2.0
v2: rebased on top of drm-tip. Rename KBL_FW_ to KBL_HUC_FW_
v3: rebased. Remove old checks.
Cc: Michal Wajdeczko
Cc: Tvrtko Ursulin
Signed-off-by: Anusha Srivatsa
Reviewed-by: Arkadiusz Hiler
Reviewed-by: Michal Wajdeczko
---
drive
The HuC authentication is done by host2guc call. The HuC RSA keys
are sent to GuC for authentication.
v2: rebased on top of drm-tip. Changed name format and upped
version 1.7.
v3: changed wait_for_atomic to wait_for
v4: rebased. Rename intel_huc_auh() to intel_guc_auth_huc()
and place the prototyp
On Fri, Jan 13, 2017 at 10:08:42AM -0800, Anusha Srivatsa wrote:
> The HuC authentication is done by host2guc call. The HuC RSA keys
> are sent to GuC for authentication.
>
> v2: rebased on top of drm-tip. Changed name format and upped
> version 1.7.
> v3: changed wait_for_atomic to wait_for
> v4:
>-Original Message-
>From: Wajdeczko, Michal
>Sent: Friday, January 13, 2017 10:18 AM
>To: Srivatsa, Anusha
>Cc: intel-gfx@lists.freedesktop.org; Chris Wilson ;
>Hiler, Arkadiusz ; Alex Dai ;
>Peter
>Antoine
>Subject: Re: [PATCH 7/8] drm/i915/huc: Support HuC authentication
>
>On Fri,
== Series Details ==
Series: drm/i915/guc: Move GuC log related functions into dedicated file
URL : https://patchwork.freedesktop.org/series/17988/
State : success
== Summary ==
Series 17988v1 drm/i915/guc: Move GuC log related functions into dedicated file
https://patchwork.freedesktop.org/ap
On Fri, Jan 13, 2017 at 04:28:58PM +0200, Joonas Lahtinen wrote:
> On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote:
>
>
> For future synchronization purposes, maybe document where the below was
> cloned from?
It is a routine I've written many times.
> > + offset = PAGE_SIZE * first_page
On Thu, Jan 12, 2017 at 11:04 PM, Jani Nikula wrote:
> On Fri, 13 Jan 2017, Rodrigo Vivi wrote:
>> Most of commiters already knows that by heart and also dim already
>> have this warning. So maybe this is just Bart writing to blackboard. Duh!
>>
>> Anyway for my own usage this tripe check will he
On Fri, Jan 13, 2017 at 06:19:53PM +, Srivatsa, Anusha wrote:
> >> + /* Invalidate GuC TLB to let GuC take the latest updates to GTT. */
> >> + I915_WRITE(GEN8_GTCR, GEN8_GTCR_INVALIDATE);
This is not required on drm-tip.
> >> + /* Specify auth action and where public signature is. */
> >>
This and all the remaining patches on this series (6,7,8 and 9) got
merged to dinq.
Thanks for the patches.
On Thu, Jan 12, 2017 at 12:12 PM, Vivi, Rodrigo wrote:
> Reviewed-by: Rodrigo Vivi
>
> On Fri, 2017-01-13 at 00:31 +0530, vathsala nagaraju wrote:
>> As per bpsec, CHICKEN_TRANS_EDP bit 1
Chris wrote these patches, and the kernel patches too. I wrote the Mesa
patches that use the new feature. I'm submitting these patches myself to
get things moving.
This series depends on fence fd support in I915_GEM_EXECBUFFER2, which
isn't upstream in the kernel yet. I tested this with kmscube o
Generated with `make headers_install`
from tag 'chadv/test/i915-exec-fence-v03'
of .
TODO: Wait until header updates are in upstream kernel.
References:
http://git.kiwitree.net/cgit/~chadv/linux/tag/?h=chadv/test/i915-exec-fence-v03
Signed-off-by: Chad Versace
---
include/drm/i915_drm.h | 277 +
From: Chris Wilson
The kernel allows implicit synchronisation to be disabled on individual
buffers. Use at your own risk.
Signed-off-by: Chris Wilson
---
intel/intel_bufmgr.h | 2 ++
intel/intel_bufmgr_gem.c | 32
2 files changed, 30 insertions(+), 4 delet
== Series Details ==
Series: HuC Loading Patches
URL : https://patchwork.freedesktop.org/series/17992/
State : success
== Summary ==
Series 17992v1 HuC Loading Patches
https://patchwork.freedesktop.org/api/1.0/series/17992/revisions/1/mbox/
Test kms_flip:
Subgroup basic-plain-flip:
From: Chris Wilson
Allow the caller to pass in an fd to an array of fences to control
serialisation of the execbuf in the kernel and on the GPU, and in return
allow creation of a fence fd for signaling the completion (and flushing)
of the batch. When the returned fence is signaled, all writes to
When a plane is fully clipped (either because it's positioned offscreen,
or because the CRTC is currently off), the clipping calculations we do
during check_plane will leave nonsense/negative coordinates in plane's
source rectangle. This is generally harmless since we recognize that
the plane shou
When a plane is fully clipped (either because it's positioned offscreen,
or because the CRTC is currently off), the clipping calculations we do
during check_plane will leave nonsense/negative coordinates in plane's
source rectangle. This is generally harmless since we recognize that
the plane shou
1 - 100 of 125 matches
Mail list logo
