Re: [Intel-gfx] [PATCH v10 1/2] drm/i915/guc : Removing enable_guc_loading and enable_guc_submission module parameters

2017-11-28 Thread Joonas Lahtinen
+ Li (for WOPCM) On Mon, 2017-11-27 at 11:54 -0800, Sujaritha Sundaresan wrote: > We currently have two module parameters that control GuC: > "enable_guc_loading" and "enable_guc_submission". Whenever > we need submission=1, we also need loading=1.We also need > loading=1 when we want to want to

Re: [Intel-gfx] [PATCH v6 0/7] drm/fbdev: Panel orientation connector property support

2017-11-28 Thread Daniel Vetter
On Sat, Nov 25, 2017 at 06:33:34PM +0100, Hans de Goede wrote: > Hi All, > > Here is v6 of my series to add a "panel orientation" property to > the drm-connector for the LCD panel to let userspace know about LCD > panels which are not mounted upright, as well as detecting upside-down > panels

Re: [Intel-gfx] [PATCH] drm: Fix modifiers_property kernel-doc comment

2017-11-28 Thread Daniel Vetter
On Sat, Nov 25, 2017 at 08:27:31PM +0100, Hans de Goede wrote: > This fixes the following make kerneldocs messages: > > ./include/drm/drm_mode_config.h:772: warning: No description found for > parameter 'modifiers_property' > ./include/drm/drm_mode_config.h:772: warning: Excess struct member >

[Intel-gfx] ✗ Fi.CI.BAT: warning for igt: Remove gem_ctx_basic (rev2)

2017-11-28 Thread Patchwork
== Series Details == Series: igt: Remove gem_ctx_basic (rev2) URL : https://patchwork.freedesktop.org/series/34500/ State : warning == Summary == IGT patchset tested on top of latest successful build 53f2b4b4ce2372da0b3b741d934dd5a9110ac1e2 igt/perf_pmu: Keep batch_duration_ns as the minimum

[Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Move the execlists specific setup out of intel_engine_setup_common. This was supposed to be only for backend agnostic bits. At the same time rename it to intel_engine_setup_execlist to follow the setup vs init naming convetion we have.

Re: [Intel-gfx] [PATCH v2] drm/i915: Enable hotplug polling after registering the outputs

2017-11-28 Thread Chris Wilson
Quoting Chris Wilson (2017-11-28 11:01:47) > @@ -1266,6 +1271,13 @@ static void i915_driver_unregister(struct > drm_i915_private *dev_priv) > intel_fbdev_unregister(dev_priv); > intel_audio_deinit(dev_priv); > > + /* > +* After flushing the fbdev (incl. a late

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Fix for nested_enable_signaling BUG_ON

2017-11-28 Thread Chris Wilson
Quoting john.c.harri...@intel.com (2017-11-28 09:10:59) > From: John Harrison > > The call to enable signaling was occuring after the request had been > sent to the GuC for execution on the hardware. That means that it is > possible for the request to actually complete

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/perf_pmu: Sync invalid-init with i915 changes

2017-11-28 Thread Patchwork
== Series Details == Series: tests/perf_pmu: Sync invalid-init with i915 changes URL : https://patchwork.freedesktop.org/series/34530/ State : success == Summary == IGT patchset tested on top of latest successful build 53f2b4b4ce2372da0b3b741d934dd5a9110ac1e2 igt/perf_pmu: Keep

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-28 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 3:54 PM, Arkadiusz Hiler wrote: > Hey all, > > For some time already CI sends out 1-2 mails per series per (re)run, i.e. BAT > results and "full IGT" results (if BAT has not failed). > > Recently we have added 32bit build check, and if that fails

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-28 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-11-28 08:15:13) > On Mon, 2017-11-27 at 16:54 +0200, Arkadiusz Hiler wrote: > > Hey all, > > > > For some time already CI sends out 1-2 mails per series per (re)run, i.e. > > BAT > > results and "full IGT" results (if BAT has not failed). > > > > Recently we have

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-28 Thread Chris Wilson
Quoting Daniel Vetter (2017-11-28 10:08:56) > On Tue, Nov 28, 2017 at 11:06 AM, Chris Wilson > wrote: > > Quoting Joonas Lahtinen (2017-11-28 08:15:13) > >> On Mon, 2017-11-27 at 16:54 +0200, Arkadiusz Hiler wrote: > >> > Hey all, > >> > > >> > For some time already CI

[Intel-gfx] [CI] Revert "x86/irq: Simplify hotplug vector accounting"

2017-11-28 Thread Chris Wilson
This reverts commit 2cffad7bad83157f89332872015f4305d2ac09ac. Lost interrupts upon resume, characterised by <0>[ 1806.220332] do_IRQ: 4.33 No irq handler for vecto --- arch/x86/include/asm/apic.h | 1 - arch/x86/include/asm/irq.h| 4 ++ arch/x86/kernel/apic/vector.c | 32 +-

[Intel-gfx] [CI 1/2] drm-tip: 2017y-11m-27d-21h-48m-50s UTC integration manifest

2017-11-28 Thread Chris Wilson
--- integration-manifest | 28 1 file changed, 28 insertions(+) create mode 100644 integration-manifest diff --git a/integration-manifest b/integration-manifest new file mode 100644 index ..2048d8f934c9 --- /dev/null +++ b/integration-manifest @@ -0,0

Re: [Intel-gfx] [PATCH] drm/i915: Enable hotplug polling after registering the outputs

2017-11-28 Thread Maarten Lankhorst
Op 27-11-17 om 11:34 schreef Chris Wilson: > Quoting Maarten Lankhorst (2017-11-27 10:18:46) >> Op 27-11-17 om 10:45 schreef Chris Wilson: >>> Previously we would enable hotplug polling on the outputs immediately >>> upon construction. This would allow a very early hotplug event to >>> trigger

[Intel-gfx] [PATCH igt] igt: Remove gem_ctx_basic

2017-11-28 Thread Chris Wilson
This is just a very plain stress test that doesn't do any verification, and is entirely duplicated by the other context tests. The test currently leaks objects from every thread on every pass (which is triggering an oom on smaller machines), while fixing it would be trivial, it also is pointless

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Return -EINVAL when selecting the inactive CPU URL : https://patchwork.freedesktop.org/series/34529/ State : success == Summary == Series 34529v1 drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 12:41:27) > From: Tvrtko Ursulin > > Move the execlists specific setup out of intel_engine_setup_common. This > was supposed to be only for backend agnostic bits. At the same time rename > it to intel_engine_setup_execlist to follow

[Intel-gfx] [PATCH v2 4/4] drm/i915: Add GuC support for engine busy stats

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Wire up the engine busy stats accounting to the GuC submission backend. Since there is not context out interrupt we need to place the accounting callbacks per-request. v2: Rebase. Signed-off-by: Tvrtko Ursulin ---

[Intel-gfx] [PATCH v4 3/4] drm/i915: Consolidate checks for engine stats availability

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Sagar noticed the check can be consolidated between the engine stats implementation and the PMU. My first choice was a static inline helper but that got into include ordering mess quickly fast so I went with a macro instead. At some point we should

[Intel-gfx] [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Maarten Lankhorst
Some drivers like i915 start with crtc's enabled, but with deferred fbcon setup they were no longer disabled as part of fbdev setup. Headless units could no longer enter pc3 state because the crtc was still enabled. Fix this by calling restore_fbdev_mode when we would have called it otherwise

Re: [Intel-gfx] [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9

2017-11-28 Thread Maarten Lankhorst
Hey, Op 21-11-17 om 15:02 schreef Juha-Pekka Heikkila: > Gen10 onwards 90 and 270 degree rotations are supported for RGB565 format. > > v2 (Ville Syrjälä): > As a side effect to keep bad-pixel-format test valid on all supported > platforms it need to use DRM_FORMAT_C8 now. > > While at it clean

Re: [Intel-gfx] [PATCH v6 5/7] drm/i915: Add "panel orientation" property to the panel connector, v6.

2017-11-28 Thread Daniel Vetter
On Sat, Nov 25, 2017 at 06:33:39PM +0100, Hans de Goede wrote: > Ideally we could use the VBT for this, that would be simple, in > intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set > connector->display_info.panel_orientation accordingly and call >

[Intel-gfx] ✗ Fi.CI.BAT: warning for Revert "x86/irq: Simplify hotplug vector accounting"

2017-11-28 Thread Patchwork
== Series Details == Series: Revert "x86/irq: Simplify hotplug vector accounting" URL : https://patchwork.freedesktop.org/series/34527/ State : warning == Summary == Series 34527v1 Revert "x86/irq: Simplify hotplug vector accounting"

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2)

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Enable hotplug polling after registering the outputs (rev2) URL : https://patchwork.freedesktop.org/series/34445/ State : success == Summary == Series 34445v2 drm/i915: Enable hotplug polling after registering the outputs

Re: [Intel-gfx] [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Daniel Vetter
On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: > Some drivers like i915 start with crtc's enabled, but with deferred > fbcon setup they were no longer disabled as part of fbdev setup. > Headless units could no longer enter pc3 state because the crtc was > still enabled. > >

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Revert "x86/irq: Simplify hotplug vector accounting"

2017-11-28 Thread Chris Wilson
Quoting Patchwork (2017-11-28 12:22:22) > == Series Details == > > Series: Revert "x86/irq: Simplify hotplug vector accounting" > URL : https://patchwork.freedesktop.org/series/34527/ > State : failure And still the do_IRQ failures and what appears to be lost interrupts. This was not the patch

[Intel-gfx] [GIT PULL] gvt fixes for 4.15-rc2

2017-11-28 Thread Zhenyu Wang
Hi, Pls pull gvt fixes for 4.15-rc2, which contains one backport from f2880e04f3a5 ("drm/i915/gvt: Move request alloc to dispatch_workload path only"), and more new fixes. thanks -- The following changes since commit ac29fc66855b79c2960c63a4a66952d5b721d698: drm/i915: fix

[Intel-gfx] [PATCH i-g-t] tests/perf_pmu: Sync invalid-init with i915 changes

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin i915 started returning -EINVAL for incorrect CPU. Signed-off-by: Tvrtko Ursulin --- tests/perf_pmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c index

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-28 Thread Arkadiusz Hiler
On Mon, Nov 27, 2017 at 09:10:37PM +0530, Sagar Arun Kamble wrote: > I feel we generally tend to ignore the results mails for series that > we are not actively involved on (although we might be interested in > series itself). Also if number of revisions some series can undergo is > high, this

Re: [Intel-gfx] [PATCH i-g-t] tests/perf_pmu: Sync invalid-init with i915 changes

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 10:55:36) > From: Tvrtko Ursulin > > i915 started returning -EINVAL for incorrect CPU. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson -Chris

[Intel-gfx] [PATCH v2] drm/i915: Enable hotplug polling after registering the outputs

2017-11-28 Thread Chris Wilson
Previously we would enable hotplug polling on the outputs immediately upon construction. This would allow a very early hotplug event to trigger before we had finishing setting up the driver to handle it. Instead, move the output polling to the last step of registration, after we have set up all

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 10:55:15) > From: Tvrtko Ursulin > > In commit 0426c0465461 ("drm/i915/pmu: Only allow running on a single > CPU") I attempted to clarify the CPU hotplug logic in our PMU > implementation, but missed that a more logical error to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Patchwork
== Series Details == Series: drm/fb_helper: Disable all crtc's when initial setup fails. URL : https://patchwork.freedesktop.org/series/34532/ State : success == Summary == Series 34532v1 drm/fb_helper: Disable all crtc's when initial setup fails.

Re: [Intel-gfx] Fixes that failed to cleanly apply to v4.15-rc1

2017-11-28 Thread Zhenyu Wang
On 2017.11.28 10:54:27 +0200, Joonas Lahtinen wrote: > Hello, > > TL;DR Reply with backported patches for v4.15-rc1 latest TODAY > > Dear patch authors/Cc:s, the following patches failed to cleanly > backport to v4.15-rc1, if you believe they still are valid patches to > be included in

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-28 Thread Tvrtko Ursulin
On 27/11/2017 14:54, Arkadiusz Hiler wrote: Hey all, For some time already CI sends out 1-2 mails per series per (re)run, i.e. BAT results and "full IGT" results (if BAT has not failed). Recently we have added 32bit build check, and if that fails it sends out additional mail In-Reply-To the

[Intel-gfx] ✗ Fi.CI.IGT: failure for Revert "x86/irq: Simplify hotplug vector accounting"

2017-11-28 Thread Patchwork
== Series Details == Series: Revert "x86/irq: Simplify hotplug vector accounting" URL : https://patchwork.freedesktop.org/series/34527/ State : failure == Summary == Test prime_busy: Subgroup wait-hang-bsd: pass -> DMESG-WARN (shard-hsw) Subgroup

[Intel-gfx] [PATCH 2/4] drm/i915: Move engine->needs_cmd_parser to engine->flags

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Will be adding a new per-engine flags shortly so it makes sense to consolidate. v2: Keep the original code flow in intel_engine_cleanup_cmd_parser. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Suggested-by: Chris

[Intel-gfx] [PATCH 3/4] drm/i915: Consolidate checks for engine stats availability

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Sagar noticed the check can be consolidated between the engine stats implementation and the PMU. My first choice was a static inline helper but that got into include ordering mess quickly fast so I went with a macro instead. At some point we should

[Intel-gfx] [PATCH 4/4] drm/i915: Add GuC support for engine busy stats

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Wire up the engine busy stats accounting to the GuC submission backend. Since there is not context out interrupt we need to place the accounting callbacks per-request. Signed-off-by: Tvrtko Ursulin ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Return -EINVAL when selecting the inactive CPU URL : https://patchwork.freedesktop.org/series/34529/ State : failure == Summary == Test gem_exec_capture: Subgroup capture-blt: pass -> DMESG-WARN (shard-snb) fdo#103950 +9

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Consolidate checks for engine stats availability

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 12:41:29) > diff --git a/drivers/gpu/drm/i915/intel_guc_submission.c > b/drivers/gpu/drm/i915/intel_guc_submission.c > index cf1cc2cb6722..a8e63779de79 100644 > --- a/drivers/gpu/drm/i915/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/intel_guc_submission.c

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-28 Thread Daniel Vetter
On Tue, Nov 28, 2017 at 11:06 AM, Chris Wilson wrote: > Quoting Joonas Lahtinen (2017-11-28 08:15:13) >> On Mon, 2017-11-27 at 16:54 +0200, Arkadiusz Hiler wrote: >> > Hey all, >> > >> > For some time already CI sends out 1-2 mails per series per (re)run, i.e. >> > BAT

Re: [Intel-gfx] [PATCH v10 1/2] drm/i915/guc : Removing enable_guc_loading and enable_guc_submission module parameters

2017-11-28 Thread Sagar Arun Kamble
On 11/28/2017 1:24 AM, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need submission=1, we also need loading=1.We also need loading=1 when we want to want to verify the HuC, which is every

[Intel-gfx] [PATCH] drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In commit 0426c0465461 ("drm/i915/pmu: Only allow running on a single CPU") I attempted to clarify the CPU hotplug logic in our PMU implementation, but missed that a more logical error to return, when attempting to initialize an event on a currently

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2)

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Enable hotplug polling after registering the outputs (rev2) URL : https://patchwork.freedesktop.org/series/34445/ State : success == Summary == Blacklisted hosts: shard-apltotal:2509 pass:1582 dwarn:15 dfail:11 fail:13 skip:883 time:11204s

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Tvrtko Ursulin
On 28/11/2017 12:48, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-28 12:41:27) From: Tvrtko Ursulin Move the execlists specific setup out of intel_engine_setup_common. This was supposed to be only for backend agnostic bits. At the same time rename it to

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Correctly handle debugfs errors

2017-11-28 Thread Michal Wajdeczko
In commit 3f6ae7b19 ("igt/kms_frontbuffer_tracking: Keep the debugfs dir around") we introduced custom variant of __igt_debugfs_read function that fires assert when debugfs returns an error. Replace that assert with proper error handling to allow use of errors like -ENODEV. Signed-off-by: Michal

[Intel-gfx] [PATCH 1/2] lockdep: finer-grained completion key for kthread

2017-11-28 Thread Daniel Vetter
Ideally we'd create the key through a macro at the real callers and pass it all the way down. This would give us better coverage for cases where a bunch of kthreads are created for the same thing. But this gets the job done meanwhile and unblocks our CI. Refining later on is always possible. v2:

[Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-28 Thread Daniel Vetter
cross-release ftl Cc: Tvrtko Ursulin Cc: Marta Lofstedt References: https://bugs.freedesktop.org/show_bug.cgi?id=103707 Signed-off-by: Daniel Vetter --- kernel/locking/lockdep_internals.h | 2 +- 1 file changed, 1

Re: [Intel-gfx] [PATCH] drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Sujaritha
On 11/28/2017 07:42 AM, Michal Wajdeczko wrote: Instead of trying different seq_puts messages, lets use common -ENODEV error code to indicate missing/unsupported feature. I agree that this is the simplest way to unify the message. Regards, Sujaritha Suggested-by: Chris Wilson

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Increase busyspin limit before a context-switch

2017-11-28 Thread Tvrtko Ursulin
On 26/11/2017 12:20, Chris Wilson wrote: Looking at the distribution of i915_wait_request for a set of GL benchmarks, we see: broadwell# python bcc/tools/funclatency.py -u i915_wait_request usecs : count distribution 0 -> 1 : 29184

Re: [Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-28 Thread Chris Wilson
Quoting Daniel Vetter (2017-11-28 17:07:07) > cross-release ftl Fwiw, this isn't cross-release but us reloading the module many times, creating a whole host of new lockclasses. Even more fun is when the module gets a slightly different address and the new lock address hashes into an old lock...

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Correctly handle debugfs errors

2017-11-28 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: Correctly handle debugfs errors URL : https://patchwork.freedesktop.org/series/34555/ State : success == Summary == IGT patchset tested on top of latest successful build 5b3619f3751ecef55fa993984ddb59a458fcebed igt: Remove

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Tvrtko Ursulin
On 28/11/2017 16:04, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-28 13:07:54) On 28/11/2017 12:48, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-28 12:41:27) From: Tvrtko Ursulin Move the execlists specific setup out of intel_engine_setup_common.

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Correctly handle debugfs errors

2017-11-28 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-11-28 17:01:15) > In commit 3f6ae7b19 ("igt/kms_frontbuffer_tracking: Keep the debugfs > dir around") we introduced custom variant of __igt_debugfs_read function > that fires assert when debugfs returns an error. Replace that assert > with proper error handling to

[Intel-gfx] [PATCH] drm/i915/guc: Fix doc reference to intel_guc_fw.c

2017-11-28 Thread Jonathan Neuschäfer
Sphinx complains that it can't find intel_guc_loader.c, and rightly so: The file has been renamed. Fixes: e8668bbcb0f9 ("drm/i915/guc: Rename intel_guc_loader.c to intel_guc_fw.c") Cc: Michal Wajdeczko Signed-off-by: Jonathan Neuschäfer ---

Re: [Intel-gfx] [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot()

2017-11-28 Thread Jingoo Han
On Monday, November 27, 2017 11:58 AM, Sinan Kaya wrote: > > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. I think that this will be useful. I introduced multi

Re: [Intel-gfx] [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Thomas Voegtle
On Tue, 28 Nov 2017, Daniel Vetter wrote: On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: Some drivers like i915 start with crtc's enabled, but with deferred fbcon setup they were no longer disabled as part of fbdev setup. Headless units could no longer enter pc3 state

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

2017-11-28 Thread Tvrtko Ursulin
On 28/11/2017 11:14, Patchwork wrote: == Series Details == Series: drm/i915/pmu: Return -EINVAL when selecting the inactive CPU URL : https://patchwork.freedesktop.org/series/34529/ State : success == Summary == Series 34529v1 drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

Re: [Intel-gfx] [PATCH v4] drm/i915: Expose the busyspin durations for i915_wait_request

2017-11-28 Thread Tvrtko Ursulin
On 27/11/2017 10:10, Chris Wilson wrote: An interesting discussion regarding "hybrid interrupt polling" for NVMe came to the conclusion that the ideal busyspin before sleeping was half of the expected request latency (and better if it was already halfway through that request). This suggested

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 17:29:25) > > On 28/11/2017 16:04, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-11-28 13:07:54) > >> > >> On 28/11/2017 12:48, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2017-11-28 12:41:27) > From: Tvrtko Ursulin >

[Intel-gfx] [PATCH i-g-t 0/3] Simplify hunting for drm card sysfs root

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Short series to clean up the code and bit. Thanks to Lionel for pointing out the convenient /sys/dev/char/: symlink. Tvrtko Ursulin (3): lib/igt_sysfs: Remove support for finding sysfs path with no device opened lib/igt_sysfs:

[Intel-gfx] [PATCH i-g-t 3/3] lib/igt_sysfs: Simplify igt_sysfs_path

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There is no need to iterate over /sys/class/drm/card* directories looking for the one which matches our major and minor, when we can directly find the right one via the /sys/dev/char/: symlink. Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH i-g-t 2/3] lib/igt_sysfs: igt_sysfs_path only works for master nodes

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin DRM code defines the minor range for master nodes as 0-63, so express that explicitly near the top of the function. Signed-off-by: Tvrtko Ursulin --- lib/igt_sysfs.c | 4 1 file changed, 4 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t 1/3] lib/igt_sysfs: Remove support for finding sysfs path with no device opened

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It looks like no callers actually use this so remove it to simplify. Signed-off-by: Tvrtko Ursulin --- lib/igt_sysfs.c | 39 --- 1 file changed, 16 insertions(+), 23 deletions(-) diff

Re: [Intel-gfx] [PATCH v2] drm/i915: Enable hotplug polling after registering the outputs

2017-11-28 Thread Chris Wilson
Quoting Chris Wilson (2017-11-28 13:02:09) > Quoting Chris Wilson (2017-11-28 11:01:47) > > @@ -1266,6 +1271,13 @@ static void i915_driver_unregister(struct > > drm_i915_private *dev_priv) > > intel_fbdev_unregister(dev_priv); > > intel_audio_deinit(dev_priv); > > > > + /*

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Move execlists setup out of common (rev3)

2017-11-28 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Move execlists setup out of common (rev3) URL : https://patchwork.freedesktop.org/series/34541/ State : success == Summary == Series 34541v3 series starting with [1/4] drm/i915: Move execlists setup out of common

Re: [Intel-gfx] [PATCH v6 0/7] drm/fbdev: Panel orientation connector property support

2017-11-28 Thread Hans de Goede
Hi, On 28-11-17 11:27, Daniel Vetter wrote: On Sat, Nov 25, 2017 at 06:33:34PM +0100, Hans de Goede wrote: Hi All, Here is v6 of my series to add a "panel orientation" property to the drm-connector for the LCD panel to let userspace know about LCD panels which are not mounted upright, as well

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2)

2017-11-28 Thread Chris Wilson
Quoting Patchwork (2017-11-28 13:08:29) > == Series Details == > > Series: drm/i915: Enable hotplug polling after registering the outputs (rev2) > URL : https://patchwork.freedesktop.org/series/34445/ > State : success Maarten acked v2, so applied. At the worst it's an improvement which we'll

Re: [Intel-gfx] [PATCH V3 09/29] drm/i915: deprecate pci_get_bus_and_slot()

2017-11-28 Thread Ville Syrjälä
On Mon, Nov 27, 2017 at 11:57:46AM -0500, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot()

Re: [Intel-gfx] [PATCH v6 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-11-28 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc1 next-20171128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Fix for nested_enable_signaling BUG_ON

2017-11-28 Thread John Harrison
On 11/28/2017 1:40 AM, Chris Wilson wrote: Quoting john.c.harri...@intel.com (2017-11-28 09:10:59) From: John Harrison The call to enable signaling was occuring after the request had been sent to the GuC for execution on the hardware. That means that it is possible

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Move execlists setup out of common (rev3)

2017-11-28 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Move execlists setup out of common (rev3) URL : https://patchwork.freedesktop.org/series/34541/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2643 pass:1514 dwarn:6 dfail:2 fail:17 skip:1103

Re: [Intel-gfx] [PATCH V3 09/29] drm/i915: deprecate pci_get_bus_and_slot()

2017-11-28 Thread Sinan Kaya
On 11/28/2017 10:30 AM, Ville Syrjälä wrote: >> +dev_priv->bridge_dev = >> +pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0)); > Maybe just pci_get_slot(pdev->bus, PCI_DEVFN(0, 0)) ? > > I guess if we want to be pedantic we could go for: > > bus =

Re: [Intel-gfx] [PATCH v6 5/7] drm/i915: Add "panel orientation" property to the panel connector, v6.

2017-11-28 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc1 next-20171128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix doc reference to intel_guc_fw.c

2017-11-28 Thread Jonathan Neuschäfer
On Tue, Nov 28, 2017 at 09:51:13AM +0100, Michal Wajdeczko wrote: > On Tue, 28 Nov 2017 07:50:52 +0100, Jonathan Neuschäfer > wrote: > > > Sphinx complains that it can't find intel_guc_loader.c, and rightly so: > > The file has been renamed. > > > > Fixes: e8668bbcb0f9

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Michal Wajdeczko
On Tue, 28 Nov 2017 17:07:27 +0100, Patchwork wrote: == Series Details == Series: drm/i915: Unifying debugfs return codes for unsupported features URL : https://patchwork.freedesktop.org/series/34552/ State : failure == Summary == Series 34552v1

Re: [Intel-gfx] [PATCH 3/4] drm/i915: expose engine availability through sysfs

2017-11-28 Thread Tvrtko Ursulin
On 20/11/2017 12:23, Lionel Landwerlin wrote: > This enables userspace to discover the engines available on the GPU. > Here is the layout on a Skylake GT4: > > /sys/devices/pci:00/:00:02.0/drm/card0/gt On this one I think Joonas had a concern that it is difficult for userspace to get to

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] lockdep: finer-grained completion key for kthread

2017-11-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] lockdep: finer-grained completion key for kthread URL : https://patchwork.freedesktop.org/series/34556/ State : success == Summary == Series 34556v1 series starting with [1/2] lockdep: finer-grained completion key for kthread

[Intel-gfx] [PATCH] drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Michal Wajdeczko
Instead of trying different seq_puts messages, lets use common -ENODEV error code to indicate missing/unsupported feature. Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 13:07:54) > > On 28/11/2017 12:48, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-11-28 12:41:27) > >> From: Tvrtko Ursulin > >> > >> Move the execlists specific setup out of intel_engine_setup_common. This > >> was supposed to

Re: [Intel-gfx] [PATCH V3 03/29] x86/PCI: deprecate pci_get_bus_and_slot()

2017-11-28 Thread Thomas Gleixner
On Mon, 27 Nov 2017, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function in favor of >

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WA Display #1178 to fix some type C dongles

2017-11-28 Thread Ville Syrjälä
On Mon, Nov 27, 2017 at 03:14:21PM -0800, Lucas De Marchi wrote: > On Thu, Nov 23, 2017 at 7:21 AM, Ville Syrjälä > wrote: > > On Wed, Nov 22, 2017 at 10:55:14AM -0800, Lucas De Marchi wrote: > >> WA Display #1178 is meant to fix Aux channel voltage swing too low

[Intel-gfx] ✗ Fi.CI.BAT: failure for lockdep: finer-grained completion key for kthread

2017-11-28 Thread Patchwork
== Series Details == Series: lockdep: finer-grained completion key for kthread URL : https://patchwork.freedesktop.org/series/34547/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h

[Intel-gfx] [PATCH] drm/i915: Fix deadlock in i830_disable_pipe()

2017-11-28 Thread Ville Syrjala
From: Ville Syrjälä i830_disable_pipe() gets called from the power well code, and thus we're already holding the power domain mutex. That means we can't call plane->get_hw_state() as it will also try to grab the same mutex and will thus deadlock. Replace the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too (rev4)

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too (rev4) URL : https://patchwork.freedesktop.org/series/33772/ State : success == Summary == Series 33772v4 drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Patchwork
== Series Details == Series: drm/fb_helper: Disable all crtc's when initial setup fails. URL : https://patchwork.freedesktop.org/series/34532/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2662 pass:1528 dwarn:8 dfail:2 fail:8 skip:1116 time:9259s shard-kbl

[Intel-gfx] [PATCH] lockdep: finer-grained completion key for kthread

2017-11-28 Thread Daniel Vetter
Ideally we'd create the key through a macro at the real callers and pass it all the way down. This would give us better coverage for cases where a bunch of kthreads are created for the same thing. But this gets the job done meanwhile and unblocks our CI. Refining later on is always possible.

[Intel-gfx] ✓ Fi.CI.IGT: success for tests/perf_pmu: Sync invalid-init with i915 changes

2017-11-28 Thread Patchwork
== Series Details == Series: tests/perf_pmu: Sync invalid-init with i915 changes URL : https://patchwork.freedesktop.org/series/34530/ State : success == Summary == Blacklisted hosts: shard-apltotal:2348 pass:1453 dwarn:20 dfail:18 fail:10 skip:838 time:10677s shard-hsw

Re: [Intel-gfx] [PATCH] drm: Fix modifiers_property kernel-doc comment

2017-11-28 Thread Hans de Goede
Hi, On 28-11-17 11:28, Daniel Vetter wrote: On Sat, Nov 25, 2017 at 08:27:31PM +0100, Hans de Goede wrote: This fixes the following make kerneldocs messages: ./include/drm/drm_mode_config.h:772: warning: No description found for parameter 'modifiers_property'

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Unifying debugfs return codes for unsupported features URL : https://patchwork.freedesktop.org/series/34552/ State : failure == Summary == Series 34552v1 drm/i915: Unifying debugfs return codes for unsupported features

Re: [Intel-gfx] [PATCH] drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Sujaritha
On 11/28/2017 07:42 AM, Michal Wajdeczko wrote: Instead of trying different seq_puts messages, lets use common -ENODEV error code to indicate missing/unsupported feature. I agree that this is the simplest way to unify Suggested-by: Chris Wilson Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix deadlock in i830_disable_pipe()

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Fix deadlock in i830_disable_pipe() URL : https://patchwork.freedesktop.org/series/34553/ State : success == Summary == Series 34553v1 drm/i915: Fix deadlock in i830_disable_pipe() https://patchwork.freedesktop.org/api/1.0/series/34553/revisions/1/mbox/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Fix doc reference to intel_guc_fw.c

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix doc reference to intel_guc_fw.c URL : https://patchwork.freedesktop.org/series/34557/ State : success == Summary == Series 34557v1 drm/i915/guc: Fix doc reference to intel_guc_fw.c

[Intel-gfx] ✓ Fi.CI.BAT: success for Simplify hunting for drm card sysfs root

2017-11-28 Thread Patchwork
== Series Details == Series: Simplify hunting for drm card sysfs root URL : https://patchwork.freedesktop.org/series/34559/ State : success == Summary == IGT patchset tested on top of latest successful build 380cc811486ba3fefbe3ebe4761afa7e169dcd3e tests/perf_pmu: Sync invalid-init with i915

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: follow single notation for workaround number

2017-11-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: follow single notation for workaround number URL : https://patchwork.freedesktop.org/series/34563/ State : success == Summary == Series 34563v1 series starting with [1/2] drm/i915: follow single notation for workaround number

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_sysfs: Remove support for finding sysfs path with no device opened

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 18:09:55) > From: Tvrtko Ursulin > > It looks like no callers actually use this so remove it to simplify. We just added more users to the equivalent for debugfs, and accepting -1 here was simply to have consistency with our debugfs

Re: [Intel-gfx] [PATCH v6 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-11-28 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.15-rc1 next-20171128] [cannot apply to linus/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[Intel-gfx] [PATCH 1/2] drm/i915: follow single notation for workaround number

2017-11-28 Thread Lucas De Marchi
Cc: Ville Syrjälä Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_hdmi.c| 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

[Intel-gfx] [PATCH 2/2] drm/i915: add platform tag to WA

2017-11-28 Thread Lucas De Marchi
Cc: Ville Syrjälä Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index

  1   2   >