DC5 and DC6 counter register tells about residency of DC5 and DC6.
Added the same in debugfs file.
v2 : Remove csr_version check.
Added generic check regarding DC counters for Gen9 onwards. (Rodrigo)
v3 : Simplified gen checks. (Chris)
v4 : Simplified "if" ladder for multiple gens.
v5 :
On Fri, Oct 05, 2018 at 12:02:26AM -0400, Jyoti Yadav wrote:
> DC5 and DC6 counter register tells about residency of DC5 and DC6.
> These registers are same for SKL and ICL.
>
> v2 : Remove csr_version check.
> Added generic check regarding DC counters for Gen9 onwards. (Rodrigo)
> v3 :
On Thu, Oct 04, 2018 at 08:01:30PM -0700, Dhinakaran Pandiyan wrote:
> PSR2 sinks that require Y coordinates for selective update also need the
> Y coordinate Valid bit in VSC SDP.
> Spec: eDP 1.4b VSC payload extension for PSR2 operation (Table 6-12)
I couldn't get any meaningful information
If we reduce the suspend function for intel_opregion to do the minimum
required, the resume function can also do the simple task of notifier
the ACPI bios that we are back. This avoid some nasty restrictions on
the likes of register_acpi_notifier() that are not allowed during the
early phase of
== Series Details ==
Series: drm/i915: First cleanup pass to get rid of more crtc->config users.
(rev5)
URL : https://patchwork.freedesktop.org/series/50506/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933_full -> Patchwork_10377_full =
== Summary - WARNING ==
Minor
== Series Details ==
Series: drm/i915: Fix ILK-IVB sprite enable delays (rev2)
URL : https://patchwork.freedesktop.org/series/50328/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4931_full -> Patchwork_10359_full =
== Summary - FAILURE ==
Serious unknown changes coming
On Fri, Oct 05, 2018 at 03:43:30PM -, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Fix ILK-IVB sprite enable delays (rev2)
> URL : https://patchwork.freedesktop.org/series/50328/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4931_full ->
On Fri, 2018-10-05 at 10:38 -0700, Rodrigo Vivi wrote:
> On Thu, Oct 04, 2018 at 08:01:30PM -0700, Dhinakaran Pandiyan wrote:
> > PSR2 sinks that require Y coordinates for selective update also
> > need the
> > Y coordinate Valid bit in VSC SDP.
> > Spec: eDP 1.4b VSC payload extension for PSR2
On Thu, Oct 04, 2018 at 04:23:45PM -0700, Paulo Zanoni wrote:
> Em Qui, 2018-10-04 às 15:36 -0700, Rodrigo Vivi escreveu:
> > From: Anusha Srivatsa
> >
> > Add missing MODULE_FIRMWARE while loading DMC ICL.
> >
> > v2: Add Fixes tag. (Rodrigo)
> > v3: Rebase by Rodrigo after commit 7fe78985cd08
== Series Details ==
Series: drm/i915/aml: Add new Amber Lake PCI ID (rev2)
URL : https://patchwork.freedesktop.org/series/50037/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4944 -> Patchwork_10382 =
== Summary - SUCCESS ==
No regressions found.
External URL:
== Series Details ==
Series: drm/i915: Some plane init cleanups
URL : https://patchwork.freedesktop.org/series/50615/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4938 -> Patchwork_10378 =
== Summary - SUCCESS ==
No regressions found.
External URL:
On Mon, Oct 01, 2018 at 04:48:21PM +0100, Tvrtko Ursulin wrote:
>
> On 01/10/2018 16:37, Chris Wilson wrote:
> > Quoting Ville Syrjälä (2018-10-01 16:27:43)
> >> On Mon, Oct 01, 2018 at 04:12:09PM +0100, Chris Wilson wrote:
> >>> Quoting Ville Syrjälä (2018-10-01 16:03:30)
> On Wed, Sep 26,
On Thu, Oct 4, 2018 at 4:00 AM Daniel Vetter wrote:
>
> range-diff is awesome, but the interface is a bit silly. Add a bunch
> of shortcuts, inspired by what git diff does.
>
> v2: Add it to the developer commmands list. With this dim range-diff
> is useable on any git repo, not just a dim
== Series Details ==
Series: drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs
entry. (rev5)
URL : https://patchwork.freedesktop.org/series/49800/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4941 -> Patchwork_10380 =
== Summary - SUCCESS ==
No
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix VIDEO_DIP_CTL bit shifts
URL : https://patchwork.freedesktop.org/series/50636/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4941 -> Patchwork_10381 =
== Summary - SUCCESS ==
No regressions found.
On Fri, Oct 05, 2018 at 11:04:35PM +0300, Ville Syrjälä wrote:
> On Fri, Oct 05, 2018 at 02:08:46PM -0400, Jyoti Yadav wrote:
> > DC5 and DC6 counter register tells about residency of DC5 and DC6.
> > Added the same in debugfs file.
> >
> > v2 : Remove csr_version check.
> > Added generic
Op 04-10-18 om 17:24 schreef Ville Syrjälä:
> On Thu, Oct 04, 2018 at 03:25:42PM +0200, Maarten Lankhorst wrote:
>> Op 04-10-18 om 14:57 schreef Ville Syrjälä:
>>> On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote:
Do not rely on crtc->config any more. Remove the assertion
== Series Details ==
Series: drm/i915: Stop calling intel_opregion unregister/register in
suspend/resume
URL : https://patchwork.freedesktop.org/series/50630/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4940 -> Patchwork_10379 =
== Summary - WARNING ==
Minor unknown
On Thu, 2018-10-04 at 20:01 -0700, Dhinakaran Pandiyan wrote:
> The hardware can start selective update following capture of a full
> frame
> in the remote frame buffer, there is no need to wait any longer. Set
> "Frames Before SU Entry" bitfield to the default value of 1.
>
> Signed-off-by:
On Fri, Oct 05, 2018 at 02:40:01PM +0530, Kumar, Mahesh wrote:
> Hi,
>
> LGTM
>
> Reviewed-by: Mahesh Kumar
pushed to dinq adding also the rv-b from lucas
I got offline...
>
> On 10/4/2018 8:48 PM, Rodrigo Vivi wrote:
> > No functional change. But just a minor change to keep
> > up with
On Thu, Sep 27, 2018 at 05:35:00PM +, Souza, Jose wrote:
> On Thu, 2018-09-27 at 00:48 -0700, Lee, Shawn C wrote:
> > Amber Lake used the same gen graphics as Kaby Lake. Kernel driver
> > should configure KBL's DDI buffer setting for AML ULX as well.
> >
> > So far, driver would load DDI
On Thu, Oct 04, 2018 at 07:56:37PM -0700, Dhinakaran Pandiyan wrote:
> On Thu, 2018-10-04 at 17:27 -0700, Manasi Navare wrote:
> > On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan wrote:
> > > On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote:
> > > > On Thu, Oct 04, 2018 at
== Series Details ==
Series: drm/i915: Stop calling intel_opregion unregister/register in
suspend/resume
URL : https://patchwork.freedesktop.org/series/50630/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
eca8408fd83c drm/i915: Stop calling intel_opregion unregister/register
The bits weren't defined in descending order.
v2: Move definitions in a separate patch (Manasi)
Cc: Manasi Navare
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/i915_reg.h | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git
The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the
definitions are unused.
v2: Moves definitions in another patch (Manasi)
Cc: Manasi Navare
Cc: Anusha Srivatsa
Cc: Rodrigo Vivi
Fixes: 7af2be6d54d4 ("drm/i915/icl: Add VIDEO_DIP registers")
Signed-off-by: Dhinakaran Pandiyan
On Fri, Oct 05, 2018 at 10:51:28AM -0700, Dhinakaran Pandiyan wrote:
> On Fri, 2018-10-05 at 10:38 -0700, Rodrigo Vivi wrote:
> > On Thu, Oct 04, 2018 at 08:01:30PM -0700, Dhinakaran Pandiyan wrote:
> > > PSR2 sinks that require Y coordinates for selective update also
> > > need the
> > > Y
On Fri, 2018-10-05 at 10:51 -0700, Dhinakaran Pandiyan wrote:
> On Fri, 2018-10-05 at 10:38 -0700, Rodrigo Vivi wrote:
> > On Thu, Oct 04, 2018 at 08:01:30PM -0700, Dhinakaran Pandiyan
> > wrote:
> > > PSR2 sinks that require Y coordinates for selective update also
> > > need the
> > > Y
On Tue, Sep 25, 2018 at 08:08:59PM +, Souza, Jose wrote:
> On Mon, 2018-09-24 at 16:43 -0700, Rodrigo Vivi wrote:
> > commit 'b9be78531d27 ("drm/i915/whl: Introducing
> > Whiskey Lake platform")' introduced WHL by moving some
> > of CFL IDs here and using the Spec information of "U43" for
> >
On Fri, Oct 05, 2018 at 11:56:43AM -0700, Dhinakaran Pandiyan wrote:
> The bits weren't defined in descending order.
> v2: Move definitions in a separate patch (Manasi)
>
> Cc: Manasi Navare
> Signed-off-by: Dhinakaran Pandiyan
Reviewed-by: Manasi Navare
Manasi
> ---
>
On Fri, 2018-10-05 at 12:54 -0700, Rodrigo Vivi wrote:
> On Fri, Oct 05, 2018 at 10:51:28AM -0700, Dhinakaran Pandiyan wrote:
> > On Fri, 2018-10-05 at 10:38 -0700, Rodrigo Vivi wrote:
> > > On Thu, Oct 04, 2018 at 08:01:30PM -0700, Dhinakaran Pandiyan
> > > wrote:
> > > > PSR2 sinks that require
== Series Details ==
Series: drm/i915: Some plane init cleanups
URL : https://patchwork.freedesktop.org/series/50615/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4938_full -> Patchwork_10378_full =
== Summary - WARNING ==
Minor unknown changes coming with
On Fri, 2018-10-05 at 13:00 -0700, Souza, Jose wrote:
> On Thu, 2018-10-04 at 20:01 -0700, Dhinakaran Pandiyan wrote:
> > The hardware can start selective update following capture of a full
> > frame
> > in the remote frame buffer, there is no need to wait any longer.
> > Set
> > "Frames Before SU
On Fri, 2018-10-05 at 11:10 -0700, Manasi Navare wrote:
> On Thu, Oct 04, 2018 at 07:56:37PM -0700, Dhinakaran Pandiyan wrote:
> > On Thu, 2018-10-04 at 17:27 -0700, Manasi Navare wrote:
> > > On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan
> > > wrote:
> > > > On Thu, 2018-10-04 at
From: Clint Taylor
Setting the SCDC scrambling CTS mode causes HDMI Link Layer protocol tests
HF1-12 and HF1-13 to fail. Added "Source Shall" entries from SCDC
section before enabling scrambling.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107895
Bugzilla:
From: Clint Taylor
HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N
value mode instead of HDMI specification values.
Signed-off-by: Clint Taylor
---
drivers/gpu/drm/i915/intel_audio.c | 16
1 file changed, 16 insertions(+)
diff --git
On Fri, Oct 05, 2018 at 11:43:58AM -0700, Lucas De Marchi wrote:
> On Thu, Oct 4, 2018 at 4:00 AM Daniel Vetter wrote:
> >
> > range-diff is awesome, but the interface is a bit silly. Add a bunch
> > of shortcuts, inspired by what git diff does.
> >
> > v2: Add it to the developer commmands list.
On Fri, Oct 05, 2018 at 02:08:46PM -0400, Jyoti Yadav wrote:
> DC5 and DC6 counter register tells about residency of DC5 and DC6.
> Added the same in debugfs file.
>
> v2 : Remove csr_version check.
> Added generic check regarding DC counters for Gen9 onwards. (Rodrigo)
> v3 : Simplified
On Fri, 2018-10-05 at 12:53 -0700, Souza, Jose wrote:
> On Fri, 2018-10-05 at 10:51 -0700, Dhinakaran Pandiyan wrote:
> > On Fri, 2018-10-05 at 10:38 -0700, Rodrigo Vivi wrote:
> > > On Thu, Oct 04, 2018 at 08:01:30PM -0700, Dhinakaran Pandiyan
> > > wrote:
> > > > PSR2 sinks that require Y
On Thu, Oct 04, 2018 at 08:29:52PM -0400, Lyude Paul wrote:
> Currently we set intel_connector->mst_port to NULL to signify that the
> MST port has been removed from the system so that we can prevent further
> action on the port such as connector probes, mode probing, etc.
> However, we're going
It's the default. The exported version was kinda a transition state,
before we made this the default.
To stop new atomic drivers from using it (instead of just relying on
the default) let's unexport it.
v2: rename the default implementation to a more fitting name and add a
comment (Laurent)
That's purely for the uapi layer to implement the ALLOW_MODESET flag.
Drivers should instead look at the state, e.g. through
drm_atomic_crtc_needs_modeset(), which vmwgfx already does. Also remove
the confusing comment, since checking allow_modeset is at best a micro
optimization.
Signed-off-by:
We already have a separate overview doc for this, makes sense to
untangle it from the overall atomic helpers.
v2: Rebase
v3: Rebase more.
Acked-by: Ville Syrjälä
Signed-off-by: Daniel Vetter
---
Documentation/gpu/drm-kms-helpers.rst | 19 +-
drivers/gpu/drm/Makefile |
For atomic driver this is the default, no need to reimplement it. We
still need to keep the copypasta for not-atomic drivers though, since
no one polished the legacy crtc helpers as much as the atomic ones.
v2: amdgpu uses ->best_encoder internally, give it a local copy. It
might be a good idea
These do absolutely nothing for atomic drivers.
Reviewed-by: Ville Syrjälä
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c
b/drivers/gpu/drm/arc/arcpgu_crtc.c
index
The core _does_ the call to drm_atomic_commit for you. That's pretty
much the entire point of having the fancy new atomic_set/get_prop
callbacks.
Signed-off-by: Daniel Vetter
Cc: VMware Graphics
Cc: Sinclair Yeh
Cc: Thomas Hellstrom
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 --
1 file
Well except the destroy helper, which isn't really a primary helper
but generally useful, if mislabelled.
v2: Keep some of the nice comments about the limitations of the
primarmy plane helpers, and put them into the kerneldoc for
drm_crtc_init() (Sam).
Reviewed-by: Ville Syrjälä (v1)
Cc: Sam
Motivated by review comments from Ville
Cc: Ville Syrjälä
Cc: Sean Paul
Signed-off-by: Daniel Vetter
---
Documentation/gpu/todo.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 77c2b3c25565..5c9d86c962af 100644
drm_plane_helper_disable is a non-atomic drivers only function, and
will blow up (since no one passes the locking context it needs).
Atomic drivers which want to quiescent their hw on unload should
use drm_atomic_helper_shutdown() instead.
Reviewed-by: Ville Syrjälä
Signed-off-by: Daniel Vetter
drm_plane_helper_disable is a non-atomic drivers only function, and
will blow up (since no one passes the locking context it needs).
Atomic drivers which want to quiescent their hw on unload should
use drm_atomic_helper_shutdown() instead.
v2: Rebase.
Reviewed-by: Ville Syrjälä
Acked-by: Eric
drm_plane_helper_disable is a non-atomic drivers only function, and
will blow up (since no one passes the locking context it needs).
Atomic drivers which want to quiescent their hw on unload should
use drm_atomic_helper_shutdown() instead.
Reviewed-by: Ville Syrjälä
Signed-off-by: Daniel Vetter
drm_plane_helper_disable is a non-atomic drivers only function, and
will blow up (since no one passes the locking context it needs).
Atomic drivers which want to quiescent their hw on unload should
use drm_atomic_helper_shutdown() instead.
Reviewed-by: Ville Syrjälä
Signed-off-by: Daniel Vetter
These do absolutely nothing for atomic drivers.
Reviewed-by: Ville Syrjälä
Signed-off-by: Daniel Vetter
Cc: Boris Brezillon
Cc: Nicolas Ferre
Cc: Alexandre Belloni
Cc: linux-arm-ker...@lists.infradead.org
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 --
1 file changed, 2
The idea behind allowing drivers to override legacy ioctls (instead of
using the generic implementations unconditionally) is to handle bugs
in old driver-specific userspace. Like e.g. vmw_kms_set_config does,
to work around some vmwgfx userspace not clearing its ioctl structs
properly.
But you
drm_plane_helper_disable is a non-atomic drivers only function, and
will blow up (since no one passes the locking context it needs).
Atomic drivers which want to quiescent their hw on unload should
use drm_atomic_helper_shutdown() instead.
The sti cleanup code seems supremely confused:
- In the
Motivated by vmwgfx digging around in core uapi bits it shouldn't dig
around in.
Reviewed-by: Ville Syrjälä
Signed-off-by: Daniel Vetter
---
include/drm/drm_atomic.h | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_atomic.h
== Series Details ==
Series: series starting with [FOR,CI,01/22] drm/amdgpu: Remove default
best_encoder hook from DC
URL : https://patchwork.freedesktop.org/series/50604/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e8d0c0e620ed drm/amdgpu: Remove default best_encoder hook
Hi,
LGTM
Reviewed-by: Mahesh Kumar
On 10/4/2018 8:48 PM, Rodrigo Vivi wrote:
No functional change. But just a minor change to keep
up with Spec, since it has changed since commit c3cc39c539d4
("drm/i915/icl: program mbus during pipe enable")
The instructions previously said to program
Quoting Tvrtko Ursulin (2018-10-05 09:37:37)
>
> On 05/10/2018 09:02, Chris Wilson wrote:
> > Add a warning for an allocation stall to make it painfully more obvious
> > while debugging.
> >
> > Signed-off-by: Chris Wilson
> > ---
> > drivers/gpu/drm/i915/i915_gem.h | 2 ++
> >
Op 04-10-18 om 17:24 schreef Ville Syrjälä:
> On Thu, Oct 04, 2018 at 03:25:42PM +0200, Maarten Lankhorst wrote:
>> Op 04-10-18 om 14:57 schreef Ville Syrjälä:
>>> On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote:
Do not rely on crtc->config any more. Remove the assertion
On Thu, Oct 04, 2018 at 08:29:51PM -0400, Lyude Paul wrote:
> As mentioned in the previous commit, we currently prevent new modesets
> on recently-removed MST connectors by returning no encoder from our
> ->best_encoder() callback once the MST port has disappeared. This is
> wrong however, because
Quoting Chris Wilson (2018-10-04 11:21:19)
> Before we can reset the seqno, we have to be sure the engines are idle.
> In debugfs/i915_drop_caches_set, we do wait_for_idle but allow ourselves
> to be interrupted. We should only proceed to reset the seqno then if we
> were not interrupted.
>
>
If KMS is not available, we cannot simply turn on an output and expect
that to wake the device up. As such we have to ignore that part of the
basic subtest and simply proclaim victory if the device is able to
sleep!
Signed-off-by: Chris Wilson
---
tests/pm_rpm.c | 9 ++---
1 file changed, 6
On 05/10/2018 09:03, Chris Wilson wrote:
Earlier, we reasoned that having idled the gpu under mempressure, that
would be a good time to trim our request slabs in order to perform the
next request allocation. We have stopped performing the global operation
on the device (no idling) and wish to
Quoting Tvrtko Ursulin (2018-10-05 09:34:35)
>
> On 04/10/2018 15:32, Joonas Lahtinen wrote:
> > Some comments below, mostly related to trying to keep the uapi header
> > nice and tidy.
> >
> > Quoting Tvrtko Ursulin (2018-10-04 14:32:48)
> >> @@ -1747,6 +1748,52 @@ struct
On 05/10/2018 09:02, Chris Wilson wrote:
Add a warning for an allocation stall to make it painfully more obvious
while debugging.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.h | 2 ++
drivers/gpu/drm/i915/i915_request.c | 6 ++
2 files changed, 8 insertions(+)
Quoting Tvrtko Ursulin (2018-10-05 09:39:45)
>
> On 05/10/2018 09:03, Chris Wilson wrote:
> > Earlier, we reasoned that having idled the gpu under mempressure, that
> > would be a good time to trim our request slabs in order to perform the
> > next request allocation. We have stopped performing
On Thu, Oct 4, 2018 at 4:38 PM Jani Nikula wrote:
>
> They don't need to be modified.
>
> Cc: Greg Kroah-Hartman
> Cc: "Rafael J. Wysocki"
> Signed-off-by: Jani Nikula
Reviewed-by: Rafael J. Wysocki
> ---
> drivers/gpu/drm/i915/i915_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
On Thu, 2018-10-04 at 16:33 +0100, Chris Wilson wrote:
> Quoting Stanislav Lisovskiy (2018-10-04 13:49:41)
> > diff --git a/src/sna/sna_render.h b/src/sna/sna_render.h
> > index 6669af9d..ef88d1f9 100644
> > --- a/src/sna/sna_render.h
> > +++ b/src/sna/sna_render.h
> > @@ -139,20 +139,25 @@ struct
== Series Details ==
Series: Watermarks small fixes/improvements
URL : https://patchwork.freedesktop.org/series/50579/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933_full -> Patchwork_10368_full =
== Summary - WARNING ==
Minor unknown changes coming with
On Fri, Oct 5, 2018 at 9:36 AM Jani Nikula wrote:
>
> On Fri, 05 Oct 2018, "Rafael J. Wysocki" wrote:
> > On Thu, Oct 4, 2018 at 4:38 PM Jani Nikula wrote:
> >>
> >> Let the passed in array be const (and thus placed in rodata) instead of
> >> a mutable array of const pointers.
> >
> > I'm not
Add a warning for an allocation stall to make it painfully more obvious
while debugging.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.h | 2 ++
drivers/gpu/drm/i915/i915_request.c | 6 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.h
On 04/10/2018 17:33, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-04 11:51:18)
From: Tvrtko Ursulin
Engine discovery query allows userspace to enumerate engines, probe their
configuration features, all without needing to maintain the internal PCI
ID based database.
A new query for
On 04/10/2018 15:32, Joonas Lahtinen wrote:
Some comments below, mostly related to trying to keep the uapi header
nice and tidy.
Quoting Tvrtko Ursulin (2018-10-04 14:32:48)
@@ -1747,6 +1748,52 @@ struct drm_i915_query_topology_info {
__u8 data[];
};
+/**
+ * struct
== Series Details ==
Series: series starting with [1/2] drm/i915: Warn if request allocation stalls
URL : https://patchwork.freedesktop.org/series/50601/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10373 =
== Summary - SUCCESS ==
No regressions
On Thu, Oct 04, 2018 at 08:29:50PM -0400, Lyude Paul wrote:
> With the exception of modesets which would switch the DPMS state of a
> connector from on to off, we want to make sure that we disallow all
> modesets which would result in enabling a new monitor or a new mode
> configuration on a
On Thu, Oct 04, 2018 at 08:29:53PM -0400, Lyude Paul wrote:
> Since we need to be able to allow DPMS on->off prop changes after an MST
> port has disappeared from the system, we need to be able to make sure we
> can compute a config for the resulting atomic commit. Currently this is
> impossible
== Series Details ==
Series: series starting with [FOR,CI,01/22] drm/amdgpu: Remove default
best_encoder hook from DC
URL : https://patchwork.freedesktop.org/series/50604/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10374 =
== Summary - SUCCESS ==
== Series Details ==
Series: Add XYUV format support (rev8)
URL : https://patchwork.freedesktop.org/series/48007/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10375 =
== Summary - SUCCESS ==
No regressions found.
External URL:
On Thu, Oct 4, 2018 at 4:38 PM Jani Nikula wrote:
>
> Let the passed in array be const (and thus placed in rodata) instead of
> a mutable array of const pointers.
I'm not sure if the changes guarantee what you want. If I'm not
mistaken, they just mean that the function itself cannot modify
On Thu, Oct 04, 2018 at 08:29:54PM -0400, Lyude Paul wrote:
> Currently, i915 appears to rely on blocking modesets on
> no-longer-present MSTB ports by simply returning NULL for
> ->best_encoder(), which in turn causes any new atomic commits that don't
> disable the CRTC to fail. This is wrong
On Fri, 05 Oct 2018, "Rafael J. Wysocki" wrote:
> On Thu, Oct 4, 2018 at 4:38 PM Jani Nikula wrote:
>>
>> Let the passed in array be const (and thus placed in rodata) instead of
>> a mutable array of const pointers.
>
> I'm not sure if the changes guarantee what you want. If I'm not
> mistaken,
Earlier, we reasoned that having idled the gpu under mempressure, that
would be a good time to trim our request slabs in order to perform the
next request allocation. We have stopped performing the global operation
on the device (no idling) and wish to make the allocation failure
handling more
Somehow I forgot a few when typing all the shiny new kerneldoc. Drop
them.
Signed-off-by: Daniel Vetter
---
include/drm/drm_vblank.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/drm/drm_vblank.h b/include/drm/drm_vblank.h
index d25a9603ab57..6ad9630d4f48
With armada the last bigger driver that realistically needed these to
convert from legacy kms to atomic is converted. These helpers have
been broken more often than not the past 2 years, and as this little
patch series shows, tricked a bunch of people into using the wrong
helpers for their
From: Thomas Hellstrom
Use the correct helper and also return early on helper
success rather than on helper failure.
Also explicitly return 0 in the case of no fb.
v2: Check for !fb after updating state->visible (Ville).
Reviewed-by: Ville Syrjälä
Signed-off-by: Thomas Hellstrom (v1)
Didn't get updated in a rework of the original patch.
Fixes: 059b5eb5d955 ("drm: move native byte order quirk to new
drm_driver_legacy_fb_format function")
Cc: Gerd Hoffmann
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_fourcc.c | 6 +++---
1 file changed, 3 insertions(+), 3
Shuts up warning noise.
Signed-off-by: Daniel Vetter
---
include/drm/drm_mode_config.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
index 928e4172a0bb..d643d268693e 100644
--- a/include/drm/drm_mode_config.h
+++
It's for legacy drivers only (atomic ones should use
drm_atomic_helper_check_plane_state() instead), and there's no users
left except the one in the primary plane helpers.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_plane_helper.c | 49 +++---
== Series Details ==
Series: series starting with [1/2] drm/i915/psr: Reduce PSR2 "frames before
selective update entry"
URL : https://patchwork.freedesktop.org/series/50593/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4933_full -> Patchwork_10371_full =
== Summary -
== Series Details ==
Series: series starting with [FOR,CI,01/22] drm/amdgpu: Remove default
best_encoder hook from DC
URL : https://patchwork.freedesktop.org/series/50604/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/amdgpu: Remove default
Quoting Chris Wilson (2018-10-05 12:21:12)
> Quoting Tvrtko Ursulin (2018-10-05 09:34:35)
> >
> > On 04/10/2018 15:32, Joonas Lahtinen wrote:
> > > Some comments below, mostly related to trying to keep the uapi header
> > > nice and tidy.
> > >
> > > Quoting Tvrtko Ursulin (2018-10-04 14:32:48)
== Series Details ==
Series: series starting with [1/2] drm/i915: Warn if request allocation stalls
URL : https://patchwork.freedesktop.org/series/50601/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933_full -> Patchwork_10373_full =
== Summary - WARNING ==
Minor
Do not rely on crtc->config any more. Remove the assertion from
ibx_pch_dpll_disable, because we the dpll state tracking should
already handle this case correctly.
Changes since v1:
- Fixup accidental early return in intel_prepare_shared_dpll, oops!
Changes since v2:
- Don't use the freed
== Series Details ==
Series: drm/i915: First cleanup pass to get rid of more crtc->config users.
(rev5)
URL : https://patchwork.freedesktop.org/series/50506/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10377 =
== Summary - SUCCESS ==
No regressions
== Series Details ==
Series: series starting with [FOR,CI,01/22] drm/amdgpu: Remove default
best_encoder hook from DC
URL : https://patchwork.freedesktop.org/series/50604/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933_full -> Patchwork_10374_full =
== Summary -
== Series Details ==
Series: drm/i915: First cleanup pass to get rid of more crtc->config users.
(rev4)
URL : https://patchwork.freedesktop.org/series/50506/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M]
Quoting Tvrtko Ursulin (2018-10-05 09:26:37)
>
> On 04/10/2018 17:33, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2018-10-04 11:51:18)
> >> From: Tvrtko Ursulin
> >>
> >> Engine discovery query allows userspace to enumerate engines, probe their
> >> configuration features, all without
Do not rely on crtc->config any more. Remove the assertion from
ibx_pch_dpll_disable, because we the dpll state tracking should
already handle this case correctly.
Changes since v1:
- Fixup accidental early return in intel_prepare_shared_dpll, oops!
Changes since v2:
- Don't use the freed
== Series Details ==
Series: drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs
entry. (rev4)
URL : https://patchwork.freedesktop.org/series/49800/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933_full -> Patchwork_10372_full =
== Summary - SUCCESS ==
== Series Details ==
Series: drm/i915: First cleanup pass to get rid of more crtc->config users.
(rev5)
URL : https://patchwork.freedesktop.org/series/50506/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
66df1bb1f2eb drm/i915: Remove dereferences of crtc->config in
1 - 100 of 163 matches
Mail list logo
