[Intel-gfx] [PATCH] drm/i915: Introduce Jasper Lake PCH

2019-10-14 Thread Matt Roper
The Jasper Lake PCH follows ICP/TGP's south display behavior and is identical to MCC graphics-wise except that it does not use the unusual (port C -> TC1) pin mapping that MCC does. Also, it turns out the extra PCH ID that we had previously thought was a form of MCC is actually a second ID for

[Intel-gfx] [PATCH 08/10] drm/i915: Replace hangcheck by heartbeats

2019-10-14 Thread Chris Wilson
Replace sampling the engine state every so often with a periodic heartbeat request to measure the health of an engine. This is coupled with the forced-preemption to allow long running requests to survive so long as they do not block other users. The heartbeat interval can be adjusted per-engine

[Intel-gfx] [PATCH 04/10] drm/i915/execlists: Force preemption

2019-10-14 Thread Chris Wilson
If the preempted context takes too long to relinquish control, e.g. it is stuck inside a shader with arbitration disabled, evict that context with an engine reset. This ensures that preemptions are reasonably responsive, providing a tighter QoS for the more important context at the cost of

[Intel-gfx] [PATCH 09/10] drm/i915/execlist: Trim immediate timeslice expiry

2019-10-14 Thread Chris Wilson
We perform timeslicing immediately upon receipt of a request that may be put into the second ELSP slot. The idea behind this was that since we didn't install the timer if the second ELSP slot was empty, we would not have any idea of how long ELSP[0] had been running and so giving the newcomer a

[Intel-gfx] [PATCH 10/10] drm/i915: Flush idle barriers when waiting

2019-10-14 Thread Chris Wilson
If we do find ourselves with an idle barrier inside our active while waiting, attempt to flush it by emitting a pulse using the kernel context. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 14 + .../gpu/drm/i915/gt/intel_engine_heartbeat.h | 1 +

[Intel-gfx] [PATCH 06/10] drm/i915/execlists: Cancel banned contexts on schedule-out

2019-10-14 Thread Chris Wilson
On schedule-out (CS completion) of a banned context, scrub the context image so that we do not replay the active payload. The intent is that we skip banned payloads on request submission so that the timeline advancement continues on in the background. However, if we are returning to a preempted

[Intel-gfx] [PATCH 03/10] drm/i915: Expose engine properties via sysfs

2019-10-14 Thread Chris Wilson
Preliminary stub to add engines underneath /sys/class/drm/cardN/, so that we can expose properties on each engine to the sysadmin. To start with we have basic analogues of the i915_query ioctl so that we can pretty print engine discovery from the shell, and flesh out the directory structure.

[Intel-gfx] [PATCH 01/10] drm/i915/gem: Distinguish each object type

2019-10-14 Thread Chris Wilson
Separate each object class into a separate lock type to avoid lockdep cross-contamination between paths (i.e. userptr!). Signed-off-by: Chris Wilson Cc: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 ++- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 3 ++-

[Intel-gfx] [PATCH 02/10] drm/i915/execlists: Clear semaphore immediately upon ELSP promotion

2019-10-14 Thread Chris Wilson
There is no significance to our delay before clearing the semaphore the engine is waiting on, so release it as soon as we acknowledge the CS update following our preemption request. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 6 +++--- 1 file changed, 3 insertions(+),

[Intel-gfx] [PATCH 05/10] drm/i915/gt: Introduce barrier pulses along engines

2019-10-14 Thread Chris Wilson
To flush idle barriers, and even inflight requests, we want to send a preemptive 'pulse' along an engine. We use a no-op request along the pinned kernel_context at high priority so that it should run or else kick off the stuck requests. We can use this to ensure idle barriers are immediately

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/3] drm/i915: Add microcontrollers documentation section

2019-10-14 Thread Patchwork
== Series Details == Series: series starting with [v3,1/3] drm/i915: Add microcontrollers documentation section URL : https://patchwork.freedesktop.org/series/67986/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7090 -> Patchwork_14796

[Intel-gfx] [PATCH 07/10] drm/i915/gem: Cancel non-persistent contexts on close

2019-10-14 Thread Chris Wilson
Normally, we rely on our hangcheck to prevent persistent batches from hogging the GPU. However, if the user disables hangcheck, this mechanism breaks down. Despite our insistence that this is unsafe, the users are equally insistent that they want to use endless batches and will disable the

[Intel-gfx] [PATCH v2] drm/i915: Introduce Jasper Lake PCH

2019-10-14 Thread Matt Roper
The Jasper Lake PCH follows ICP/TGP's south display behavior and is identical to MCC graphics-wise except that it does not use the unusual (port C -> TC1) pin mapping that MCC does. Also, it turns out the extra PCH ID that we had previously thought was a form of MCC is actually a second ID for

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Introduce Jasper Lake PCH

2019-10-14 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Jasper Lake PCH URL : https://patchwork.freedesktop.org/series/67992/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7091 -> Patchwork_14799 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/10] drm/i915/gem: Distinguish each object type

2019-10-14 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gem: Distinguish each object type URL : https://patchwork.freedesktop.org/series/67993/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7091 -> Patchwork_14800

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clear Color Support for TGL Render Decompression (rev4)

2019-10-14 Thread Patchwork
== Series Details == Series: Clear Color Support for TGL Render Decompression (rev4) URL : https://patchwork.freedesktop.org/series/66814/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5b2a67fc7d74 drm/framebuffer: Format modifier for Intel Gen-12 render compression

[Intel-gfx] ✓ Fi.CI.BAT: success for Clear Color Support for TGL Render Decompression (rev4)

2019-10-14 Thread Patchwork
== Series Details == Series: Clear Color Support for TGL Render Decompression (rev4) URL : https://patchwork.freedesktop.org/series/66814/ State : success == Summary == CI Bug Log - changes from CI_DRM_7091 -> Patchwork_14802 Summary

[Intel-gfx] [PATCH v4 09/10] drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color

2019-10-14 Thread Radhakrishna Sripada
Gen12 display can decompress surfaces compressed by render engine with Clear Color, add a new modifier as the driver needs to know the surface was compressed by render engine. V2: Description changes as suggested by Rafael. V3: Mention the Clear Color size of 64 bits in the comments(DK) v4: Fix

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites (rev2)

2019-10-14 Thread Chris Wilson
Quoting Ville Syrjälä (2019-10-14 20:23:42) > On Wed, Oct 09, 2019 at 09:12:23PM -, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats > > on SNB-BDW sprites (rev2) > > URL :

Re: [Intel-gfx] [PATCH] drm/i915: Introduce Jasper Lake PCH

2019-10-14 Thread Vivek Kasireddy
On Mon, 14 Oct 2019 14:24:31 -0700 Matt Roper wrote: > The Jasper Lake PCH follows ICP/TGP's south display behavior and is > identical to MCC graphics-wise except that it does not use the unusual > (port C -> TC1) pin mapping that MCC does. > > Also, it turns out the extra PCH ID that we had

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers

2019-10-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers URL : https://patchwork.freedesktop.org/series/67987/ State : failure == Summary == Applying: drm/i915/perf: Add helper macros for comparing with whitelisted

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/10] drm/i915/gem: Distinguish each object type

2019-10-14 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gem: Distinguish each object type URL : https://patchwork.freedesktop.org/series/67993/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/gem: Distinguish each object type Okay!

[Intel-gfx] ✓ Fi.CI.BAT: success for kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-14 Thread Patchwork
== Series Details == Series: kernel-doc: rename the kernel-doc directive 'functions' to 'specific' URL : https://patchwork.freedesktop.org/series/67984/ State : success == Summary == CI Bug Log - changes from CI_DRM_7089 -> Patchwork_14795

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915/gem: Distinguish each object type

2019-10-14 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gem: Distinguish each object type URL : https://patchwork.freedesktop.org/series/67993/ State : warning == Summary == $ dim checkpatch origin/drm-tip 560c3f3d40a2 drm/i915/gem: Distinguish each object type 7b18d5f62f34

[Intel-gfx] [PATCH v4 02/10] drm/i915: Use intel_tile_height() instead of re-implementing

2019-10-14 Thread Radhakrishna Sripada
From: Dhinakaran Pandiyan intel_tile_dims() computes tile height using size and width, when there is already a function to do just that - intel_tile_height() Cc: Ville Syrjälä Cc: Matt Roper Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- 1 file

[Intel-gfx] [PATCH v4 08/10] Gen-12 display can decompress surfaces compressed by the media engine.

2019-10-14 Thread Radhakrishna Sripada
From: Dhinakaran Pandiyan Detect the modifier corresponding to media compression to enable display decompression for YUV and xRGB packed formats. A new modifier is added so that the driver can distinguish between media and render compressed buffers. Unlike render decompression, plane 6 and

[Intel-gfx] [PATCH v4 07/10] drm/fb: Extend format_info member arrays to handle four planes

2019-10-14 Thread Radhakrishna Sripada
From: Dhinakaran Pandiyan addfb() uAPI has supported four planes for a while now, make format_info compatible with that. Cc: Ville Syrjälä Cc: Matt Roper Signed-off-by: Dhinakaran Pandiyan --- include/drm/drm_fourcc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH v4 05/10] drm/i915: Extract framebufer CCS offset checks into a function

2019-10-14 Thread Radhakrishna Sripada
From: Dhinakaran Pandiyan intel_fill_fb_info() has grown quite large and wrapping the offset checks into a separate function makes the loop a bit easier to follow. Cc: Ville Syrjälä Cc: Matt Roper Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/display/intel_display.c | 69

[Intel-gfx] [PATCH v4 04/10] drm/i915/tgl: Gen-12 render decompression

2019-10-14 Thread Radhakrishna Sripada
From: Dhinakaran Pandiyan Gen-12 display decompression operates on Y-tiled compressed main surface. The CCS is linear and has 4 bits of metadata for each main surface cache line pair, a size ratio of 1:256. Gen-12 display decompression is incompatible with buffers compressed by earlier GPUs, so

[Intel-gfx] [PATCH v4 09/10] drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color

2019-10-14 Thread Radhakrishna Sripada
Gen12 display can decompress surfaces compressed by render engine with Clear Color, add a new modifier as the driver needs to know the surface was compressed by render engine. V2: Description changes as suggested by Rafael. V3: Mention the Clear Color size of 64 bits in the comments(DK) Cc:

[Intel-gfx] [PATCH v4 06/10] drm/framebuffer: Format modifier for Intel Gen-12 media compression

2019-10-14 Thread Radhakrishna Sripada
From: Dhinakaran Pandiyan Gen-12 display can decompress surfaces compressed by the media engine, add a new modifier as the driver needs to know the surface was compressed by the media or render engine. Cc: Nanley G Chery Cc: Matt Roper Cc: Ville Syrjälä Signed-off-by: Dhinakaran Pandiyan

[Intel-gfx] [PATCH v4 10/10] drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression

2019-10-14 Thread Radhakrishna Sripada
Render Decompression is supported with Y-Tiled main surface. The CCS is linear and has 4 bits of data for each main surface cache line pair, a ratio of 1:256. Additional Clear Color information is passed from the user-space through an offset in the GEM BO. Add a new modifier to identify and parse

[Intel-gfx] [PATCH v4 01/10] drm/framebuffer: Format modifier for Intel Gen-12 render compression

2019-10-14 Thread Radhakrishna Sripada
From: Dhinakaran Pandiyan Gen-12 has a new compression format, add a new modifier to indicate that. Cc: Ville Syrjälä Cc: Matt Roper Cc: Nanley G Chery Cc: Jason Ekstrand Signed-off-by: Dhinakaran Pandiyan Signed-off-by: Lucas De Marchi --- include/uapi/drm/drm_fourcc.h | 11 +++

[Intel-gfx] [PATCH v4 03/10] drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment

2019-10-14 Thread Radhakrishna Sripada
From: Dhinakaran Pandiyan Easier to read if all the alignment changes are in one place and contained within a function. Cc: Ville Syrjälä Cc: Matt Roper Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/display/intel_display.c | 31 ++-- 1 file changed, 16

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Introduce Jasper Lake PCH (rev2)

2019-10-14 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Jasper Lake PCH (rev2) URL : https://patchwork.freedesktop.org/series/67992/ State : success == Summary == CI Bug Log - changes from CI_DRM_7091 -> Patchwork_14801 Summary ---

[Intel-gfx] [PATCH v4 00/10] Clear Color Support for TGL Render Decompression

2019-10-14 Thread Radhakrishna Sripada
Support for Clear Color is contained in the last two patches submitted by Radhakrishna Sripada. The first 8 patches are currently undergoing review/revision changes. The first 8 patches are cherry-picked from the series https://patchwork.freedesktop.org/series/67078/ Expecting feedback for the

[Intel-gfx] ✓ Fi.CI.IGT: success for Add mipi dsi command mode support.

2019-10-14 Thread Patchwork
== Series Details == Series: Add mipi dsi command mode support. URL : https://patchwork.freedesktop.org/series/67974/ State : success == Summary == CI Bug Log - changes from CI_DRM_7086_full -> Patchwork_14792_full Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [CI,1/4] drm/i915/perf: introduce a versioning of the i915-perf uapi

2019-10-14 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/perf: introduce a versioning of the i915-perf uapi URL : https://patchwork.freedesktop.org/series/67990/ State : failure == Summary == Applying: drm/i915/perf: introduce a versioning of the i915-perf uapi Using index info to

Re: [Intel-gfx] [PATCH v2] drm/i915: Introduce Jasper Lake PCH

2019-10-14 Thread Vivek Kasireddy
On Mon, 14 Oct 2019 15:43:41 -0700 Matt Roper wrote: > The Jasper Lake PCH follows ICP/TGP's south display behavior and is > identical to MCC graphics-wise except that it does not use the unusual > (port C -> TC1) pin mapping that MCC does. > > Also, it turns out the extra PCH ID that we had

Re: [Intel-gfx] [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-14 Thread Tim.Bird
> -Original Message- > From: Jani Nikula on October 13, 2019 11:00 PM > On Sun, 13 Oct 2019, Changbin Du wrote: > > The 'functions' directive is not only for functions, but also works for > > structs/unions. So the name is misleading. This patch renames it to > > 'specific', so now we

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-14 Thread Patchwork
== Series Details == Series: kernel-doc: rename the kernel-doc directive 'functions' to 'specific' URL : https://patchwork.freedesktop.org/series/67984/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8314c1dd258c kernel-doc: rename the kernel-doc directive 'functions' to

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clear Color Support for TGL Render Decompression (rev5)

2019-10-14 Thread Patchwork
== Series Details == Series: Clear Color Support for TGL Render Decompression (rev5) URL : https://patchwork.freedesktop.org/series/66814/ State : warning == Summary == $ dim checkpatch origin/drm-tip e84d0c20bec1 drm/framebuffer: Format modifier for Intel Gen-12 render compression

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Some cleanup near the SKL wm/ddb area (rev2)

2019-10-14 Thread Patchwork
== Series Details == Series: drm/i915: Some cleanup near the SKL wm/ddb area (rev2) URL : https://patchwork.freedesktop.org/series/67930/ State : success == Summary == CI Bug Log - changes from CI_DRM_7087_full -> Patchwork_14794_full

Re: [Intel-gfx] [PATCH V3 6/7] virtio: introduce a mdev based transport

2019-10-14 Thread Jason Wang
On 2019/10/15 上午1:39, Stefan Hajnoczi wrote: On Fri, Oct 11, 2019 at 04:15:56PM +0800, Jason Wang wrote: +struct virtio_mdev_device { + struct virtio_device vdev; + struct mdev_device *mdev; + unsigned long version; + + struct virtqueue **vqs; + /* The lock to

Re: [Intel-gfx] [PATCH V3 0/7] mdev based hardware virtio offloading support

2019-10-14 Thread Jason Wang
On 2019/10/15 上午1:49, Stefan Hajnoczi wrote: On Fri, Oct 11, 2019 at 04:15:50PM +0800, Jason Wang wrote: There are hardware that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to

[Intel-gfx] ✓ Fi.CI.BAT: success for Clear Color Support for TGL Render Decompression (rev5)

2019-10-14 Thread Patchwork
== Series Details == Series: Clear Color Support for TGL Render Decompression (rev5) URL : https://patchwork.freedesktop.org/series/66814/ State : success == Summary == CI Bug Log - changes from CI_DRM_7091 -> Patchwork_14803 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Assert tasklet is locked for process_csb() (rev4)

2019-10-14 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Assert tasklet is locked for process_csb() (rev4) URL : https://patchwork.freedesktop.org/series/67957/ State : success == Summary == CI Bug Log - changes from CI_DRM_7087_full -> Patchwork_14793_full

Re: [Intel-gfx] [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-14 Thread Matthew Wilcox
On Mon, Oct 14, 2019 at 08:48:48PM +, tim.b...@sony.com wrote: > > > > -Original Message- > > From: Jani Nikula on October 13, 2019 11:00 PM > > On Sun, 13 Oct 2019, Changbin Du wrote: > > > The 'functions' directive is not only for functions, but also works for > > >

Re: [Intel-gfx] [PATCH V3 5/7] mdev: introduce virtio device and its device ops

2019-10-14 Thread Jason Wang
On 2019/10/15 上午1:23, Stefan Hajnoczi wrote: On Fri, Oct 11, 2019 at 04:15:55PM +0800, Jason Wang wrote: + * @set_vq_cb: Set the interrut calback function for s/interrut/interrupt/ s/calback/callback/ Fixed. Thanks ___

Re: [Intel-gfx] [intel-gfx] [PATCH] drm/i915: coffeelake supports hdcp2.2

2019-10-14 Thread Ramalingam C
On 2019-10-11 at 11:19:18 -0700, Juston Li wrote: > This includes other platforms that utilize the same gen graphics as > CFL: AML, WHL and CML. > > Signed-off-by: Juston Li > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Tweak virtual unsubmission

2019-10-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-14 10:34:31) > > On 13/10/2019 21:30, Chris Wilson wrote: > > Since commit e2144503bf3b ("drm/i915: Prevent bonded requests from > > overtaking each other on preemption") we have restricted requests to run > > on their chosen engine across preemption events. We can

Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Assert tasklet is locked for process_csb()

2019-10-14 Thread Tvrtko Ursulin
On 14/10/2019 10:37, Chris Wilson wrote: We rely on only the tasklet being allowed to call into process_csb(), so assert that is locked when we do. As the tasklet uses a simple bitlock, there is no strong lockdep checking so we must make do with a plain assertion that the tasklet is running and

Re: [Intel-gfx] [PATCH 06/15] drm/i915/selftests: Check known register values within the context

2019-10-14 Thread Tvrtko Ursulin
On 14/10/2019 10:07, Chris Wilson wrote: Check the logical ring context by asserting that the registers hold expected start during execution. (It's a bit chicken-and-egg for how could we manage to execute our request if the registers were not being updated. Still, it's nice to verify that the

Re: [Intel-gfx] [PATCH 06/15] drm/i915/selftests: Check known register values within the context

2019-10-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-14 10:59:44) > > On 14/10/2019 10:07, Chris Wilson wrote: > > +static int __live_lrc_state(struct i915_gem_context *fixme, > > + struct intel_engine_cs *engine, > > + struct i915_vma *scratch) > > +{ > > + struct

Re: [Intel-gfx] [PATCH 08/15] drm/i915: Expose engine properties via sysfs

2019-10-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-14 11:17:54) > > On 14/10/2019 10:07, Chris Wilson wrote: > > +static ssize_t > > +caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) > > +{ > > + struct intel_engine_cs *engine = kobj_to_engine(kobj); > > + const char * const *repr; >

[Intel-gfx] [RFC 2/7] drm/i915/dsi: Configure transcoder operation for command mode.

2019-10-14 Thread Vandita Kulkarni
Configure the transcoder to operate in TE GATE command mode and take TE events from GPIO. Also disable the periodic command mode, that GOP would have programmed. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 32 ++ 1 file changed, 32

[Intel-gfx] [RFC 7/7] drm/i915/dsi: Initiate frame request in cmd mode

2019-10-14 Thread Vandita Kulkarni
In TE Gate mode, on every flip we need to set the frame update request bit. After this bit is set transcoder hardware will automatically send the frame data to the panel when it receives the TE event. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c| 27

Re: [Intel-gfx] [PATCH v3] drm/i915: Restrict qgv points which don't have enough bandwidth.

2019-10-14 Thread Lisovskiy, Stanislav
On Fri, 2019-10-11 at 16:49 -0700, James Ausmus wrote: > On Wed, Sep 25, 2019 at 03:17:37PM +0300, Stanislav Lisovskiy wrote: > > According to BSpec 53998, we should try to > > restrict qgv points, which can't provide > > enough bandwidth for desired display configuration. > > > > Currently we

[Intel-gfx] [RFC 5/7] drm/i915/dsi: Configure TE interrupt for cmd mode

2019-10-14 Thread Vandita Kulkarni
We need to configure TE interrupt in two places. Port interrupt and DSI interrupt mask registers. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [RFC 1/7] drm/i915/dsi: Define command mode registers

2019-10-14 Thread Vandita Kulkarni
Adding all the register definitions needed for mipi dsi command mode. Signed-off-by: Madhav Chauhan Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_reg.h | 76 + 1 file changed, 68 insertions(+), 8 deletions(-) diff --git

[Intel-gfx] [RFC 4/7] drm/i915/dsi: Helper to find dsi encoder in cmd mode

2019-10-14 Thread Vandita Kulkarni
From: Madhav Chauhan This patch adds a helper function to find encoder if DSI is operating in command mode. This function will be used while enabling/disabling TE interrupts for DSI. Signed-off-by: Madhav Chauhan Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c |

[Intel-gfx] [RFC 6/7] drm/i915/dsi: Add TE handler for dsi cmd mode.

2019-10-14 Thread Vandita Kulkarni
In case of dual link, we get the TE on slave. So clear the TE on slave DSI IIR. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 61 + 1 file changed, 61 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [RFC 0/7] Add mipi dsi command mode support.

2019-10-14 Thread Vandita Kulkarni
This series has mainly patches to configure the dsi in command mode, TE event handling and initiate a frame request to the panel. Floating the RFC for review wrt the above mentioned implementation. For now we are configuring the MIPI DSI to operate in TE gate mode and take TE events via GPIO.

[Intel-gfx] [RFC 3/7] drm/i915/dsi: Add vblank calculation for command mode

2019-10-14 Thread Vandita Kulkarni
Transcoder timing calculation differ for command mode. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 56 +- 1 file changed, 37 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c

[Intel-gfx] [PATCH v3] drm/i915/execlists: Assert tasklet is locked for process_csb()

2019-10-14 Thread Chris Wilson
We rely on only the tasklet being allowed to call into process_csb(), so assert that is locked when we do. As the tasklet uses a simple bitlock, there is no strong lockdep checking so we must make do with a plain assertion that the tasklet is running and assume that we are the tasklet! v2: Fixup

[Intel-gfx] [PATCH v2] drm/i915/execlists: Assert tasklet is locked for process_csb()

2019-10-14 Thread Chris Wilson
We rely on only the tasklet being allowed to call into process_csb(), so assert that is locked when we do. As the tasklet uses a simple bitlock, there is no strong lockdep checking so we must make do with a plain assertion that the tasklet is running and assume that we are the tasklet! v2: Fixup

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Tweak virtual unsubmission

2019-10-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-14 10:34:31) > > On 13/10/2019 21:30, Chris Wilson wrote: > > Since commit e2144503bf3b ("drm/i915: Prevent bonded requests from > > overtaking each other on preemption") we have restricted requests to run > > on their chosen engine across preemption events. We can

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Tweak virtual unsubmission

2019-10-14 Thread Chris Wilson
Quoting Ramalingam C (2019-10-14 10:28:18) > On 2019-10-13 at 21:30:12 +0100, Chris Wilson wrote: > > Since commit e2144503bf3b ("drm/i915: Prevent bonded requests from > > overtaking each other on preemption") we have restricted requests to run > > on their chosen engine across preemption events.

Re: [Intel-gfx] [PATCH] drm/i915/display: Squelch kerneldoc warnings

2019-10-14 Thread Tvrtko Ursulin
On 12/10/2019 09:02, Chris Wilson wrote: Just a parameter rename, drivers/gpu/drm/i915/display/intel_display.c:14425: warning: Function parameter or member '_new_plane_state' not described in 'intel_prepare_plane_fb' drivers/gpu/drm/i915/display/intel_display.c:14425: warning: Excess function

Re: [Intel-gfx] [PATCH 08/15] drm/i915: Expose engine properties via sysfs

2019-10-14 Thread Tvrtko Ursulin
On 14/10/2019 10:07, Chris Wilson wrote: Preliminary stub to add engines underneath /sys/class/drm/cardN/, so that we can expose properties on each engine to the sysadmin. To start with we have basic analogues of the i915_query ioctl so that we can pretty print engine discovery from the shell,

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Tweak virtual unsubmission

2019-10-14 Thread Tvrtko Ursulin
On 14/10/2019 10:41, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-10-14 10:34:31) On 13/10/2019 21:30, Chris Wilson wrote: Since commit e2144503bf3b ("drm/i915: Prevent bonded requests from overtaking each other on preemption") we have restricted requests to run on their chosen engine

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Tweak virtual unsubmission

2019-10-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-14 10:50:25) > > On 14/10/2019 10:41, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-10-14 10:34:31) > >> > >> On 13/10/2019 21:30, Chris Wilson wrote: > >>> Since commit e2144503bf3b ("drm/i915: Prevent bonded requests from > >>> overtaking each other on

Re: [Intel-gfx] [PATCH 07/15] drm/i915/selftests: Check that GPR are cleared for new contexts

2019-10-14 Thread Tvrtko Ursulin
On 14/10/2019 10:07, Chris Wilson wrote: We want the general purpose registers to be clear in all new contexts so that we can be confident that no information is leaked from one to the next. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 185

Re: [Intel-gfx] [PATCH 10/15] drm/i915/gt: Introduce barrier pulses along engines

2019-10-14 Thread Tvrtko Ursulin
On 14/10/2019 10:07, Chris Wilson wrote: To flush idle barriers, and even inflight requests, we want to send a preemptive 'pulse' along an engine. We use a no-op request along the pinned kernel_context at high priority so that it should run or else kick off the stuck requests. We can use this

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Assert tasklet is locked for process_csb()

2019-10-14 Thread Chris Wilson
Quoting Chris Wilson (2019-10-14 10:28:53) > Quoting Chris Wilson (2019-10-14 10:27:59) > > Quoting Tvrtko Ursulin (2019-10-14 10:25:04) > > > > > > On 13/10/2019 20:31, Chris Wilson wrote: > > > > We rely on only the tasklet being allowed to call into process_csb(), so > > > > assert that is

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Fixup naked 64b divide

2019-10-14 Thread Matthew Auld
On 13/10/2019 12:45, Chris Wilson wrote: drivers/gpu/drm/i915/intel_memory_region.o: in function `igt_mock_contiguous': drivers/gpu/drm/i915/selftests/intel_memory_region.c:166: undefined reference to `__umoddi3' v2: promote target to u64 for consistency across all builds Reported-by: kbuild

Re: [Intel-gfx] [PATCH] drm/i915: Favor last VBT child device with conflicting AUX ch/DDC pin

2019-10-14 Thread Jani Nikula
On Fri, 11 Oct 2019, Ville Syrjala wrote: > From: Ville Syrjälä > > The first come first served apporoach to handling the VBT > child device AUX ch conflicts has backfired. We have machines > in the wild where the VBT specifies both port A eDP and > port E DP (in that order) with port E being

[Intel-gfx] [PATCH 04/15] drm/i915/execlists: Clear semaphore immediately upon ELSP promotion

2019-10-14 Thread Chris Wilson
There is no significance to our delay before clearing the semaphore the engine is waiting on, so release it as soon as we acknowledge the CS update following our preemption request. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 6 +++--- 1 file changed, 3 insertions(+),

[Intel-gfx] [PATCH 11/15] drm/i915/execlists: Cancel banned contexts on schedule-out

2019-10-14 Thread Chris Wilson
On schedule-out (CS completion) of a banned context, scrub the context image so that we do not replay the active payload. The intent is that we skip banned payloads on request submission so that the timeline advancement continues on in the background. However, if we are returning to a preempted

[Intel-gfx] [PATCH 09/15] drm/i915/execlists: Force preemption

2019-10-14 Thread Chris Wilson
If the preempted context takes too long to relinquish control, e.g. it is stuck inside a shader with arbitration disabled, evict that context with an engine reset. This ensures that preemptions are reasonably responsive, providing a tighter QoS for the more important context at the cost of

[Intel-gfx] [PATCH 13/15] drm/i915: Replace hangcheck by heartbeats

2019-10-14 Thread Chris Wilson
Replace sampling the engine state every so often with a periodic heartbeat request to measure the health of an engine. This is coupled with the forced-preemption to allow long running requests to survive so long as they do not block other users. The heartbeat interval can be adjusted per-engine

[Intel-gfx] [PATCH 15/15] drm/i915/execlist: Trim immediate timeslice expiry

2019-10-14 Thread Chris Wilson
We perform timeslicing immediately upon receipt of a request that may be put into the second ELSP slot. The idea behind this was that since we didn't install the timer if the second ELSP slot was empty, we would not have any idea of how long ELSP[0] had been running and so giving the newcomer a

[Intel-gfx] [PATCH 05/15] drm/i915/execlists: Tweak virtual unsubmission

2019-10-14 Thread Chris Wilson
Since commit e2144503bf3b ("drm/i915: Prevent bonded requests from overtaking each other on preemption") we have restricted requests to run on their chosen engine across preemption events. We can take this restriction into account to know that we will want to resubmit those requests onto the same

[Intel-gfx] [PATCH 14/15] drm/i915: Flush idle barriers when waiting

2019-10-14 Thread Chris Wilson
If we do find ourselves with an idle barrier inside our active while waiting, attempt to flush it by emitting a pulse using the kernel context. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 14 + .../gpu/drm/i915/gt/intel_engine_heartbeat.h | 1 +

[Intel-gfx] [PATCH 12/15] drm/i915/gem: Cancel non-persistent contexts on close

2019-10-14 Thread Chris Wilson
Normally, we rely on our hangcheck to prevent persistent batches from hogging the GPU. However, if the user disables hangcheck, this mechanism breaks down. Despite our insistence that this is unsafe, the users are equally insistent that they want to use endless batches and will disable the

[Intel-gfx] [PATCH 08/15] drm/i915: Expose engine properties via sysfs

2019-10-14 Thread Chris Wilson
Preliminary stub to add engines underneath /sys/class/drm/cardN/, so that we can expose properties on each engine to the sysadmin. To start with we have basic analogues of the i915_query ioctl so that we can pretty print engine discovery from the shell, and flesh out the directory structure.

[Intel-gfx] [PATCH 07/15] drm/i915/selftests: Check that GPR are cleared for new contexts

2019-10-14 Thread Chris Wilson
We want the general purpose registers to be clear in all new contexts so that we can be confident that no information is leaked from one to the next. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 185 ++--- 1 file changed, 166

[Intel-gfx] [PATCH 03/15] drm/i915/execlists: Assert tasklet is locked for process_csb()

2019-10-14 Thread Chris Wilson
We rely on only the tasklet being allowed to call into process_csb(), so assert that is locked when we do. As the tasklet uses a simple bitlock, there is no strong lockdep checking so we must make do with a plain assertion that the tasklet is running and assume that we are the tasklet!

[Intel-gfx] [PATCH 06/15] drm/i915/selftests: Check known register values within the context

2019-10-14 Thread Chris Wilson
Check the logical ring context by asserting that the registers hold expected start during execution. (It's a bit chicken-and-egg for how could we manage to execute our request if the registers were not being updated. Still, it's nice to verify that the HW is working as expected.) Signed-off-by:

[Intel-gfx] [PATCH 01/15] drm/i915/display: Squelch kerneldoc warnings

2019-10-14 Thread Chris Wilson
Just a parameter rename, drivers/gpu/drm/i915/display/intel_display.c:14425: warning: Function parameter or member '_new_plane_state' not described in 'intel_prepare_plane_fb' drivers/gpu/drm/i915/display/intel_display.c:14425: warning: Excess function parameter 'new_state' description in

[Intel-gfx] [PATCH 10/15] drm/i915/gt: Introduce barrier pulses along engines

2019-10-14 Thread Chris Wilson
To flush idle barriers, and even inflight requests, we want to send a preemptive 'pulse' along an engine. We use a no-op request along the pinned kernel_context at high priority so that it should run or else kick off the stuck requests. We can use this to ensure idle barriers are immediately

Re: [Intel-gfx] Does the i915 VBT tell us if a panel is an OLED panel?

2019-10-14 Thread Jani Nikula
On Fri, 11 Oct 2019, Sean Paul wrote: > On Thu, Oct 10, 2019 at 04:35:56PM +0300, Jani Nikula wrote: >> On Thu, 10 Oct 2019, Hans de Goede wrote: >> > Hi Jani, >> > >> > During plumbers I had some discussions with Daniel about supporting >> > OLED screens. Userspace may need to know that a panel

Re: [Intel-gfx] [PATCH 08/24] drm/i915: Prepare to split crtc state in uapi and hw state

2019-10-14 Thread Maarten Lankhorst
Op 10-10-2019 om 16:47 schreef Ville Syrjälä: > On Thu, Oct 10, 2019 at 04:21:00PM +0200, Maarten Lankhorst wrote: >> Op 08-10-2019 om 19:06 schreef Ville Syrjälä: >>> On Fri, Oct 04, 2019 at 01:34:58PM +0200, Maarten Lankhorst wrote: We want to split drm_crtc_state into the user visible

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Fixup naked 64b divide

2019-10-14 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fixup naked 64b divide URL : https://patchwork.freedesktop.org/series/67947/ State : success == Summary == CI Bug Log - changes from CI_DRM_7075_full -> Patchwork_14780_full Summary ---

[Intel-gfx] [PATCH 02/15] drm/i915/gem: Distinguish each object type

2019-10-14 Thread Chris Wilson
Separate each object class into a separate lock type to avoid lockdep cross-contamination between paths (i.e. userptr!). Signed-off-by: Chris Wilson Cc: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 ++- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 3 ++-

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Assert tasklet is locked for process_csb()

2019-10-14 Thread Tvrtko Ursulin
On 13/10/2019 20:31, Chris Wilson wrote: We rely on only the tasklet being allowed to call into process_csb(), so assert that is locked when we do. As the tasklet uses a simple bitlock, there is no strong lockdep checking so we must make do with a plain assertion that the tasklet is running and

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Avoid polluting the i915_oa_config with error pointers

2019-10-14 Thread Patchwork
== Series Details == Series: drm/i915/perf: Avoid polluting the i915_oa_config with error pointers URL : https://patchwork.freedesktop.org/series/67949/ State : success == Summary == CI Bug Log - changes from CI_DRM_7075 -> Patchwork_14782

Re: [Intel-gfx] [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-14 Thread Jani Nikula
On Sun, 13 Oct 2019, Changbin Du wrote: > The 'functions' directive is not only for functions, but also works for > structs/unions. So the name is misleading. This patch renames it to > 'specific', so now we have export/internal/specific directives to limit > the functions/types to be included in

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Tweak virtual unsubmission

2019-10-14 Thread Ramalingam C
On 2019-10-13 at 21:30:12 +0100, Chris Wilson wrote: > Since commit e2144503bf3b ("drm/i915: Prevent bonded requests from > overtaking each other on preemption") we have restricted requests to run > on their chosen engine across preemption events. We can take this > restriction into account to

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Assert tasklet is locked for process_csb()

2019-10-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-14 10:25:04) > > On 13/10/2019 20:31, Chris Wilson wrote: > > We rely on only the tasklet being allowed to call into process_csb(), so > > assert that is locked when we do. As the tasklet uses a simple bitlock, > > there is no strong lockdep checking so we must

  1   2   >