[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/perf: Whitelist OA report trigger registers

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/perf: Whitelist OA report trigger registers URL : https://patchwork.freedesktop.org/series/79571/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8759 -> Patchwork_18199

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/perf: Whitelist OA report trigger registers

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/perf: Whitelist OA report trigger registers URL : https://patchwork.freedesktop.org/series/79571/ State : warning == Summary == $ dim checkpatch origin/drm-tip 451a46ae0075 drm/i915/perf: Whitelist OA report trigger registers

Re: [Intel-gfx] [PATCH v8 3/5] drm/i915/rkl: Add DPLL4 support

2020-07-16 Thread Lucas De Marchi
On Thu, Jul 16, 2020 at 03:05:49PM -0700, Matt Roper wrote: Rocket Lake has a third DPLL (called 'DPLL4') that must be used to enable a third display. Unlike EHL's variant of DPLL4, the RKL variant behaves the same as DPLL0/1. And despite its name, the DPLL4 registers are offset as if it were

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/perf: Whitelist OA report trigger registers

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/perf: Whitelist OA report trigger registers URL : https://patchwork.freedesktop.org/series/79571/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be

Re: [Intel-gfx] [PATCH] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Tvrtko Ursulin
On 10/07/2020 18:10, Chris Wilson wrote: [ 1413.563200] BUG: KCSAN: data-race in __await_execution+0x217/0x370 [i915] [ 1413.563221] [ 1413.563236] race at unknown origin, with read to 0x5bb6c478 of 8 bytes by task 9654 on cpu 1: [ 1413.563548] __await_execution+0x217/0x370 [i915] [

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs

2020-07-16 Thread Tvrtko Ursulin
On 16/07/2020 10:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-07-16 10:01:15) On 14/07/2020 10:47, Chris Wilson wrote: diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index e0280a672f1d..aa7be7f05f8c 100644 ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs

2020-07-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-07-16 11:11:55) > > > On 16/07/2020 10:16, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-07-16 10:01:15) > >> > >> On 14/07/2020 10:47, Chris Wilson wrote: > >>> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c > >>> b/drivers/gpu/drm/i915/gt/intel_lrc.c >

Re: [Intel-gfx] [PATCH] drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-07-16 09:41:17) > Right I missed dma_fence_is_signaled calls i915_request_completed. > > In this case the remaining question is do we care about wait ioctl > potentially returning before the hypothetical sync fence for the same > request is signaled? This seems like

Re: [Intel-gfx] [PATCH] drm/i915: Provide the perf pmu.module

2020-07-16 Thread Tvrtko Ursulin
On 16/07/2020 10:46, Chris Wilson wrote: Rather than manually implement our own module reference counting for perf pmu events, finally realise that there is a module parameter to struct pmu for this very purpose. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: sta...@vger.kernel.org ---

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Mock the status_page.vma for the kernel_context

2020-07-16 Thread Mika Kuoppala
Chris Wilson writes: > Since we assert that the kernel_context is using the perma-pinned HWSP, > make it so. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/mock_engine.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [Intel-gfx] [RFC 33/60] drm/i915/lmem: support pwrite

2020-07-16 Thread Matthew Auld
On 16/07/2020 01:43, Dave Airlie wrote: On Wed, 15 Jul 2020 at 00:35, Matthew Auld wrote: On 13/07/2020 06:09, Dave Airlie wrote: On Fri, 10 Jul 2020 at 22:00, Matthew Auld wrote: We need to add support for pwrite'ing an LMEM object. why? DG1 is a discrete GPU, these interfaces we

[Intel-gfx] [PATCH] drm/i915/display/fbc: Disable fbc by default on TGL

2020-07-16 Thread Uma Shankar
Fbc is causing random underruns in CI execution on TGL platforms. Disabling the same while the problem is being debugged and analyzed. Cc: Stanislav Lisovskiy Cc: Ville Syrjälä Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_fbc.c | 7 +++ 1 file changed, 7 insertions(+)

Re: [Intel-gfx] [PATCH] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-07-16 10:17:11) > > On 10/07/2020 18:10, Chris Wilson wrote: > > [ 1413.563200] BUG: KCSAN: data-race in __await_execution+0x217/0x370 [i915] > > [ 1413.563221] > > [ 1413.563236] race at unknown origin, with read to 0x5bb6c478 of 8 > > bytes by task 9654 on

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Provide the perf pmu.module

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915: Provide the perf pmu.module URL : https://patchwork.freedesktop.org/series/79547/ State : success == Summary == CI Bug Log - changes from CI_DRM_8753 -> Patchwork_18187 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2) URL : https://patchwork.freedesktop.org/series/79514/ State : success == Summary == CI Bug Log - changes from CI_DRM_8753 -> Patchwork_18188

Re: [Intel-gfx] [PATCH] drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-16 Thread Tvrtko Ursulin
On 15/07/2020 15:47, Chris Wilson wrote: Quoting Chris Wilson (2020-07-15 15:47:15) Quoting Tvrtko Ursulin (2020-07-15 13:26:23) On 15/07/2020 13:06, Tvrtko Ursulin wrote: On 15/07/2020 11:50, Chris Wilson wrote: Currently, we use i915_request_completed() directly in i915_request_wait()

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/fbc: Disable fbc by default on TGL

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915/display/fbc: Disable fbc by default on TGL URL : https://patchwork.freedesktop.org/series/79541/ State : success == Summary == CI Bug Log - changes from CI_DRM_8753 -> Patchwork_18186 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-16 Thread Tvrtko Ursulin
On 16/07/2020 09:47, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-07-16 09:41:17) Right I missed dma_fence_is_signaled calls i915_request_completed. In this case the remaining question is do we care about wait ioctl potentially returning before the hypothetical sync fence for the same

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs

2020-07-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-07-16 10:01:15) > > On 14/07/2020 10:47, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c > > b/drivers/gpu/drm/i915/gt/intel_lrc.c > > index e0280a672f1d..aa7be7f05f8c 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > > +++

[Intel-gfx] [PATCH] drm/i915: Provide the perf pmu.module

2020-07-16 Thread Chris Wilson
Rather than manually implement our own module reference counting for perf pmu events, finally realise that there is a module parameter to struct pmu for this very purpose. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: sta...@vger.kernel.org --- drivers/gpu/drm/i915/i915_pmu.c | 7 ++-

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/fbc: Disable fbc by default on TGL

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915/display/fbc: Disable fbc by default on TGL URL : https://patchwork.freedesktop.org/series/79541/ State : success == Summary == CI Bug Log - changes from CI_DRM_8753_full -> Patchwork_18186_full Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2) URL : https://patchwork.freedesktop.org/series/79514/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs

2020-07-16 Thread Tvrtko Ursulin
On 14/07/2020 10:47, Chris Wilson wrote: Since the breadcrumb enabling/cancelling itself is serialised by the breadcrumbs.irq_lock, with a bit of care we can remove the outer A few sentences explaining this care would be really helpful for review. serialisation with i915_request.lock for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Provide the perf pmu.module

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915: Provide the perf pmu.module URL : https://patchwork.freedesktop.org/series/79547/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [CI] drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-16 Thread Chris Wilson
Currently, we use i915_request_completed() directly in i915_request_wait() and follow up with a manual invocation of dma_fence_signal(). This appears to cause a large number of contentions on i915_request.lock as when the process is woken up after the fence is signaled by an interrupt, we will

Re: [Intel-gfx] [PATCH] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-07-16 12:11:18) > > On 16/07/2020 10:37, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-07-16 10:17:11) > >> > >> On 10/07/2020 18:10, Chris Wilson wrote: > >>> [ 1413.563200] BUG: KCSAN: data-race in __await_execution+0x217/0x370 > >>> [i915] > >>> [

[Intel-gfx] [PULL] drm-misc-next

2020-07-16 Thread Maarten Lankhorst
drm-misc-next-2020-07-16: drm-misc-next for v5.9: UAPI Changes: Cross-subsystem Changes: - Add ckoenig as dma-buf maintainer. - Revert invalid fix for dma-fence-chain, and fix selftest. - Add fixmes to amifb about APUS support. - Use array3_size in fbcon_prepare_logo, and struct_size() in

Re: [Intel-gfx] [PATCH] drm/i915/display/fbc: Disable fbc by default on TGL

2020-07-16 Thread Ville Syrjälä
On Thu, Jul 16, 2020 at 02:25:40PM +0530, Uma Shankar wrote: > Fbc is causing random underruns in CI execution on TGL platforms. > Disabling the same while the problem is being debugged and analyzed. > > Cc: Stanislav Lisovskiy > Cc: Ville Syrjälä > Signed-off-by: Uma Shankar Acked-by: Ville

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2) URL : https://patchwork.freedesktop.org/series/79514/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8753_full -> Patchwork_18188_full

Re: [Intel-gfx] [PATCH] drm/i915/display/fbc: Disable fbc by default on TGL

2020-07-16 Thread Ville Syrjälä
On Thu, Jul 16, 2020 at 03:38:03PM +0300, Ville Syrjälä wrote: > On Thu, Jul 16, 2020 at 02:25:40PM +0530, Uma Shankar wrote: > > Fbc is causing random underruns in CI execution on TGL platforms. > > Disabling the same while the problem is being debugged and analyzed. > > > > Cc: Stanislav

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists URL : https://patchwork.freedesktop.org/series/79551/ State : success == Summary == CI Bug Log - changes from CI_DRM_8754 -> Patchwork_18189

[Intel-gfx] [CI 2/2] drm/i915: Remove i915_request.lock requirement for execution callbacks

2020-07-16 Thread Chris Wilson
We are using the i915_request.lock to serialise adding an execution callback with __i915_request_submit. However, if we use an atomic llist_add to serialise multiple waiters and then check to see if the request is already executing, we can remove the irq-spinlock. v2: Avoid using the irq_work

[Intel-gfx] [CI 1/2] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Chris Wilson
[ 1413.563200] BUG: KCSAN: data-race in __await_execution+0x217/0x370 [i915] [ 1413.563221] [ 1413.563236] race at unknown origin, with read to 0x5bb6c478 of 8 bytes by task 9654 on cpu 1: [ 1413.563548] __await_execution+0x217/0x370 [i915] [ 1413.563891]

Re: [Intel-gfx] [PATCH] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Tvrtko Ursulin
On 16/07/2020 10:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-07-16 10:17:11) On 10/07/2020 18:10, Chris Wilson wrote: [ 1413.563200] BUG: KCSAN: data-race in __await_execution+0x217/0x370 [i915] [ 1413.563221] [ 1413.563236] race at unknown origin, with read to 0x5bb6c478

Re: [Intel-gfx] [PATCH] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Tvrtko Ursulin
On 16/07/2020 12:15, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-07-16 12:11:18) On 16/07/2020 10:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-07-16 10:17:11) On 10/07/2020 18:10, Chris Wilson wrote: [ 1413.563200] BUG: KCSAN: data-race in __await_execution+0x217/0x370

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists URL : https://patchwork.freedesktop.org/series/79551/ State : warning == Summary == $ dim checkpatch origin/drm-tip 83628de655db drm/i915: Be wary of data races when

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Provide the perf pmu.module

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915: Provide the perf pmu.module URL : https://patchwork.freedesktop.org/series/79547/ State : success == Summary == CI Bug Log - changes from CI_DRM_8753_full -> Patchwork_18187_full Summary ---

[Intel-gfx] [PATCH 1/5] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Chris Wilson
[ 1413.563200] BUG: KCSAN: data-race in __await_execution+0x217/0x370 [i915] [ 1413.563221] [ 1413.563236] race at unknown origin, with read to 0x5bb6c478 of 8 bytes by task 9654 on cpu 1: [ 1413.563548] __await_execution+0x217/0x370 [i915] [ 1413.563891]

[Intel-gfx] [PATCH 5/5] drm/i915/gt: Only transfer the virtual context to the new engine if active

2020-07-16 Thread Chris Wilson
One more complication of preempt-to-busy with respect to the virtual engine is that we may have retired the last request along the virtual engine at the same time as preparing to submit the completed request to a new engine. That submit will be shortcircuited, but not before we have updated the

[Intel-gfx] [PATCH 3/5] drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs

2020-07-16 Thread Chris Wilson
Since the breadcrumb enabling/cancelling itself is serialised by the breadcrumbs.irq_lock, with a bit of care we can remove the outer serialisation with i915_request.lock for concurrent dma_fence_enable_signaling(). This has the important side-effect of eliminating the nested i915_request.lock

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Remove i915_request.lock requirement for execution callbacks

2020-07-16 Thread Tvrtko Ursulin
On 16/07/2020 12:33, Chris Wilson wrote: We are using the i915_request.lock to serialise adding an execution callback with __i915_request_submit. However, if we use an atomic llist_add to serialise multiple waiters and then check to see if the request is already executing, we can remove the

[Intel-gfx] [PATCH 4/5] drm/i915/gt: Drop intel_engine_transfer_stale_breadcrumbs

2020-07-16 Thread Chris Wilson
Now that we have serialised the request retirement's decoupling of the breadcrumb from the engine with the request signaling, we know that there should never be a stale breadcrumb attached to an unbound virtual engine. We can now remove the fixup code that had to migrate the breadcrumbs along with

[Intel-gfx] [PATCH 2/5] drm/i915: Remove i915_request.lock requirement for execution callbacks

2020-07-16 Thread Chris Wilson
We are using the i915_request.lock to serialise adding an execution callback with __i915_request_submit. However, if we use an atomic llist_add to serialise multiple waiters and then check to see if the request is already executing, we can remove the irq-spinlock. v2: Avoid using the irq_work

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists URL : https://patchwork.freedesktop.org/series/79551/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit

Re: [Intel-gfx] [PATCH 10/66] drm/i915: Soften the tasklet flush frequency before waits

2020-07-16 Thread Mika Kuoppala
Chris Wilson writes: > We include a tasklet flush before waiting on a request as a precaution > against the HW being lax in event signaling. We now have a precautionary > flush in the engine's heartbeat and so do not need to be quite so > zealous on every request wait. If we focus on the

[Intel-gfx] [v2] drm/i915/display/fbc: Disable fbc by default on TGL

2020-07-16 Thread Uma Shankar
Fbc is causing random underruns in CI execution on TGL platforms. Disabling the same while the problem is being debugged and analyzed. v2: Moved the check below the module param check (Ville) Cc: Stanislav Lisovskiy Cc: Ville Syrjälä Signed-off-by: Uma Shankar ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Be wary of data races when reading the active execlists URL : https://patchwork.freedesktop.org/series/79556/ State : success == Summary == CI Bug Log - changes from CI_DRM_8754 -> Patchwork_18190

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs

2020-07-16 Thread Tvrtko Ursulin
On 16/07/2020 12:33, Chris Wilson wrote: Since the breadcrumb enabling/cancelling itself is serialised by the breadcrumbs.irq_lock, with a bit of care we can remove the outer serialisation with i915_request.lock for concurrent dma_fence_enable_signaling(). This has the important side-effect of

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/fbc: Disable fbc by default on TGL (rev2)

2020-07-16 Thread Shankar, Uma
From: Patchwork Sent: Thursday, July 16, 2020 9:13 PM To: Shankar, Uma Cc: intel-gfx@lists.freedesktop.org Subject: ✗ Fi.CI.BAT: failure for drm/i915/display/fbc: Disable fbc by default on TGL (rev2) Patch Details Series: drm/i915/display/fbc: Disable fbc by default on TGL (rev2) URL:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/fbc: Disable fbc by default on TGL (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915/display/fbc: Disable fbc by default on TGL (rev2) URL : https://patchwork.freedesktop.org/series/79541/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8754 -> Patchwork_18191 Summary

Re: [Intel-gfx] [PATCH 28/66] drm/i915/gem: Replace i915_gem_object.mm.mutex with reservation_ww_class

2020-07-16 Thread Tvrtko Ursulin
On 15/07/2020 16:43, Maarten Lankhorst wrote: Op 15-07-2020 om 13:51 schreef Chris Wilson: Our goal is to pull all memory reservations (next iteration obj->ops->get_pages()) under a ww_mutex, and to align those reservations with other drivers, i.e. control all such allocations with the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Be wary of data races when reading the active execlists URL : https://patchwork.freedesktop.org/series/79556/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each

Re: [Intel-gfx] [PATCH] drm/i915/display/fbc: Disable fbc by default on TGL

2020-07-16 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Thursday, July 16, 2020 6:19 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/fbc: Disable fbc by default > on > TGL > > On Thu, Jul 16, 2020 at 03:38:03PM +0300, Ville

Re: [Intel-gfx] [PATCH 1/1] drm/i915/perf: Map OA buffer to user space

2020-07-16 Thread Lionel Landwerlin
On 14/07/2020 10:22, Umesh Nerlige Ramappa wrote: From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf

Re: [Intel-gfx] [PATCH 4/5] drm/i915/gt: Drop intel_engine_transfer_stale_breadcrumbs

2020-07-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-07-16 16:29:37) > > On 16/07/2020 12:33, Chris Wilson wrote: > > Now that we have serialised the request retirement's decoupling of the > > breadcrumb from the engine with the request signaling, we know that > > there should never be a stale breadcrumb attached to an

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Be wary of data races when reading the active execlists URL : https://patchwork.freedesktop.org/series/79556/ State : warning == Summary == $ dim checkpatch origin/drm-tip a9025407e910 drm/i915: Be wary of data races when

Re: [Intel-gfx] [v2] drm/i915/display/fbc: Disable fbc by default on TGL

2020-07-16 Thread Ville Syrjälä
On Thu, Jul 16, 2020 at 08:28:57PM +0530, Uma Shankar wrote: > Fbc is causing random underruns in CI execution on TGL platforms. > Disabling the same while the problem is being debugged and analyzed. > > v2: Moved the check below the module param check (Ville) > > Cc: Stanislav Lisovskiy > Cc:

Re: [Intel-gfx] [PATCH 4/5] drm/i915/gt: Drop intel_engine_transfer_stale_breadcrumbs

2020-07-16 Thread Tvrtko Ursulin
On 16/07/2020 12:33, Chris Wilson wrote: Now that we have serialised the request retirement's decoupling of the breadcrumb from the engine with the request signaling, we know that there should never be a stale breadcrumb attached to an unbound virtual engine. We can now remove the fixup code

Re: [Intel-gfx] [PATCH 5/5] drm/i915/gt: Only transfer the virtual context to the new engine if active

2020-07-16 Thread Tvrtko Ursulin
On 16/07/2020 12:33, Chris Wilson wrote: One more complication of preempt-to-busy with respect to the virtual engine is that we may have retired the last request along the virtual engine at the same time as preparing to submit the completed request to a new engine. That submit will be

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists URL : https://patchwork.freedesktop.org/series/79551/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8754_full -> Patchwork_18189_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists (rev2) URL : https://patchwork.freedesktop.org/series/79551/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists (rev2) URL : https://patchwork.freedesktop.org/series/79551/ State : warning == Summary == $ dim checkpatch origin/drm-tip 848b1076da85 drm/i915: Be wary of data races

[Intel-gfx] [PATCH 06/14] drm/i915: Ocd the HSW PCI ID hex numbers

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Most of the HSW PCI IDs are upper case hex numbers, but a few are lower case. Make it consistent so these don't stick out like a sore thumb. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 6 +++--- 1 file changed, 3 insertions(+), 3

[Intel-gfx] [PATCH 05/14] drm/i915: Try to fix the SKL GT3/4 vs. GT3e/4e comments

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Bunch of the SKL SKUs currently documented as GT3/4 seem to actually be GT3e/4e. Fix up the comments. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 04/14] drm/i915: Add SKL GT1.5 PCI IDs

2020-07-16 Thread Ville Syrjala
From: Alexei Podtelezhnikov Add three new devices 0x1913, 0x1915, and 0x1917 also known as iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15. Signed-off-by: Alexei Podtelezhnikov [vsyrjala: Split separate changes into separate patchs, Sort the IDs] Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 02/14] drm/i915: Reclassify SKL 0x192a as GT3

2020-07-16 Thread Ville Syrjala
From: Alexei Podtelezhnikov Reclassify 0x192A according to specifications. Of note, the second to last digit seems to correspond to GT#. Signed-off-by: Alexei Podtelezhnikov [vsyrjala: Split separate changes into separate patches] Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h |

[Intel-gfx] [PATCH 01/14] drm/i915: Update Haswell PCI IDs

2020-07-16 Thread Ville Syrjala
From: Alexei Podtelezhnikov Reclassify 0x0426 as GT3 (GT2+) according to specifications and the second least significant digit. Signed-off-by: Alexei Podtelezhnikov [vsyrjala: s/GT2/GT3/ in the comment] Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH 03/14] drm/i915: Reclassify SKL 0x1923 and 0x1927 as ULT

2020-07-16 Thread Ville Syrjala
From: Alexei Podtelezhnikov Reclassify 0x1923, 0x1927 according to specifications. Of note, the second to last digit seems to correspond to GT#. Signed-off-by: Alexei Podtelezhnikov [vsyrjala: Split separate changes into separate patches, Sort the IDs] Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH 00/14] drm/i915: PCI ID cleanup

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä I started by splitting Alexei's SKL PCI ID fix into logical chunks, and then ocd kicked in a bit... Cc: Alexei Podtelezhnikov Alexei Podtelezhnikov (4): drm/i915: Update Haswell PCI IDs drm/i915: Reclassify SKL 0x192a as GT3 drm/i915: Reclassify SKL 0x1923 and 0x1927

[Intel-gfx] [PATCH 08/14] drm/i915: Sort SKL PCI IDs

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Sort the SKL PCI IDs numerically. Some order seems better than randomness. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/drm/i915_pciids.h

[Intel-gfx] [PATCH 14/14] drm/i915: Sort EHL/JSL PCI IDs

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Sort the EHL/JSL PCI IDs numerically. Some order seems better than randomness. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/drm/i915_pciids.h

[Intel-gfx] [PATCH 11/14] drm/i915: Sort CFL PCI IDs

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Sort the CFL PCI IDs numerically. Some order seems better than randomness. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_pciids.h

[Intel-gfx] [PATCH 13/14] drm/i915: Sort ICL PCI IDs

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Sort the ICL PCI IDs numerically. Some order seems better than randomness. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/drm/i915_pciids.h

[Intel-gfx] [PATCH 07/14] drm/i915: Sort HSW PCI IDs

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Sort the HSW PCI IDs numerically. Some order seems better than randomness. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: PCI ID cleanup

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915: PCI ID cleanup URL : https://patchwork.freedesktop.org/series/79561/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists (rev2) URL : https://patchwork.freedesktop.org/series/79551/ State : success == Summary == CI Bug Log - changes from CI_DRM_8757 -> Patchwork_18193

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/fbc: Disable fbc by default on TGL (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915/display/fbc: Disable fbc by default on TGL (rev2) URL : https://patchwork.freedesktop.org/series/79541/ State : success == Summary == CI Bug Log - changes from CI_DRM_8754 -> Patchwork_18191 Summary

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/fbc: Disable fbc by default on TGL (rev2)

2020-07-16 Thread Vudum, Lakshminarayana
Re-reported. From: Shankar, Uma Sent: Thursday, July 16, 2020 6:51 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/display/fbc: Disable fbc by default on TGL (rev2) From: Patchwork mailto:patchw...@emeril.freedesktop.org>>

Re: [Intel-gfx] [PATCH 1/1] drm/i915/perf: Map OA buffer to user space

2020-07-16 Thread Umesh Nerlige Ramappa
On Thu, Jul 16, 2020 at 06:32:10PM +0300, Lionel Landwerlin wrote: On 14/07/2020 10:22, Umesh Nerlige Ramappa wrote: From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: PCI ID cleanup

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915: PCI ID cleanup URL : https://patchwork.freedesktop.org/series/79561/ State : success == Summary == CI Bug Log - changes from CI_DRM_8757 -> Patchwork_18192 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH 2/2] drm/i915: Apply WAC6entrylatency to kbl/cfl

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä WAC6entrylatency is trying to fix excessive rc6 entry latency caused by the extra delay from FBC_LLC_READ_CTRL, which is there for some extra sync with uncore for frame buffer caching in LLC. Reading through the hsd the recommendation was to set the FBC_LLC_FULLY_OPEN bit to

[Intel-gfx] [PATCH 1/2] drm/i915: Move WaDisableDopClockGating:skl to skl_init_clock_gating()

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä It's silly to have if(SKL) checks in gen9_init_clock_gating() when we can just move those bits into skl_init_clock_gating(). I'm not entirely convinced we even need this w/a, or if we do then maybe we want it for kbl/cfl as well. IIRC it was only listed in the wadb, but that

Re: [Intel-gfx] [PATCH v6 06/11] drm/i915: Enable big joiner support in enable and disable sequences.

2020-07-16 Thread Manasi Navare
On Wed, Jul 15, 2020 at 03:42:17PM -0700, Manasi Navare wrote: > From: Maarten Lankhorst > > Make vdsc work when no output is enabled. The big joiner needs VDSC > on the slave, so enable it and set the appropriate bits. > Also update timestamping constants, because slave crtc's are not > updated

[Intel-gfx] [PATCH 12/14] drm/i915: Sort CNL PCI IDs

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Sort the CNL PCI IDs numerically. Some order seems better than randomness. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/drm/i915_pciids.h

[Intel-gfx] [PATCH 10/14] drm/i915: Sort CML PCI IDs

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Sort the CML PCI IDs numerically. Some order seems better than randomness. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/drm/i915_pciids.h

[Intel-gfx] [PATCH 09/14] drm/i915: Sort KBL PCI IDs

2020-07-16 Thread Ville Syrjala
From: Ville Syrjälä Sort the KBL PCI IDs numerically. Some order seems better than randomness. Cc: Alexei Podtelezhnikov Signed-off-by: Ville Syrjälä --- include/drm/i915_pciids.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/drm/i915_pciids.h

[Intel-gfx] [PATCH] drm/i915/gt: Replace intel_engine_transfer_stale_breadcrumbs

2020-07-16 Thread Chris Wilson
After staring at the breadcrumb enabling/cancellation and coming to the conclusion that the cause of the mysterious stale breadcrumbs must the act of submitting a completed requests, we can then redirect those completed requests onto a dedicated signaled_list at the time of construction and so

Re: [Intel-gfx] [PATCH 5/5] drm/i915/gt: Only transfer the virtual context to the new engine if active

2020-07-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-07-16 16:37:25) > > On 16/07/2020 12:33, Chris Wilson wrote: > > One more complication of preempt-to-busy with respect to the virtual > > engine is that we may have retired the last request along the virtual > > engine at the same time as preparing to submit the

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Be wary of data races when reading the active execlists

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Be wary of data races when reading the active execlists URL : https://patchwork.freedesktop.org/series/79556/ State : success == Summary == CI Bug Log - changes from CI_DRM_8754_full -> Patchwork_18190_full

Re: [Intel-gfx] [PATCH 1/1] drm/i915/perf: Map OA buffer to user space

2020-07-16 Thread Lionel Landwerlin
On 16/07/2020 21:06, Umesh Nerlige Ramappa wrote: On Thu, Jul 16, 2020 at 06:32:10PM +0300, Lionel Landwerlin wrote: On 14/07/2020 10:22, Umesh Nerlige Ramappa wrote: From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/fbc: Disable fbc by default on TGL (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915/display/fbc: Disable fbc by default on TGL (rev2) URL : https://patchwork.freedesktop.org/series/79541/ State : success == Summary == CI Bug Log - changes from CI_DRM_8754_full -> Patchwork_18191_full

Re: [Intel-gfx] [PATCH 1/1] drm/i915/perf: Map OA buffer to user space

2020-07-16 Thread Umesh Nerlige Ramappa
On Thu, Jul 16, 2020 at 09:44:46PM +0300, Lionel Landwerlin wrote: On 16/07/2020 21:06, Umesh Nerlige Ramappa wrote: On Thu, Jul 16, 2020 at 06:32:10PM +0300, Lionel Landwerlin wrote: On 14/07/2020 10:22, Umesh Nerlige Ramappa wrote: From: Piotr Maciejewski i915 used to support time based

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Add compiler paranoia for checking HWSP values

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Add compiler paranoia for checking HWSP values URL : https://patchwork.freedesktop.org/series/79565/ State : warning == Summary == $ dim checkpatch origin/drm-tip 31bcd6fa4b2a drm/i915/selftests: Add compiler

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/selftests: Add compiler paranoia for checking HWSP values

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Add compiler paranoia for checking HWSP values URL : https://patchwork.freedesktop.org/series/79565/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/selftests: Add compiler paranoia for checking HWSP values

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Add compiler paranoia for checking HWSP values URL : https://patchwork.freedesktop.org/series/79565/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8757 -> Patchwork_18195

[Intel-gfx] [PATCH v7 06/11] drm/i915: Enable big joiner support in enable and disable sequences.

2020-07-16 Thread Manasi Navare
From: Maarten Lankhorst Make vdsc work when no output is enabled. The big joiner needs VDSC on the slave, so enable it and set the appropriate bits. Also update timestamping constants, because slave crtc's are not updated in drm_atomic_helper_update_legacy_modeset_state(). This should be enough

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Wait for aux invalidation on Tigerlake

2020-07-16 Thread Chris Wilson
Quoting Chris Wilson (2020-07-16 21:32:01) > Add a SRM read back of the aux invalidation register after poking > hsdes: 1809175790, as failing to do so leads to writes going astray. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2169 > Signed-off-by: Chris Wilson > Cc: Mika

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,01/11] HAX to make DSC work on the icelake test system (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [v6,01/11] HAX to make DSC work on the icelake test system (rev2) URL : https://patchwork.freedesktop.org/series/79534/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6756ad0df458 HAX to make DSC work on the icelake test system

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v6,01/11] HAX to make DSC work on the icelake test system (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [v6,01/11] HAX to make DSC work on the icelake test system (rev2) URL : https://patchwork.freedesktop.org/series/79534/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move WaDisableDopClockGating:skl to skl_init_clock_gating()

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move WaDisableDopClockGating:skl to skl_init_clock_gating() URL : https://patchwork.freedesktop.org/series/79563/ State : success == Summary == CI Bug Log - changes from CI_DRM_8757 -> Patchwork_18194

  1   2   >