Re: [Intel-gfx] [PATCH] drm/i915: Fix typo in i915_drm_resume()

2018-08-06 Thread Mun, Gwan-gyeong
On Fri, 2018-08-03 at 20:12 +0100, Chris Wilson wrote: > Quoting Gwan-gyeong Mun (2018-08-03 17:41:50) > > Even for trivial patches, always include a changelog. In this case, I > added "Trivial typo, s/loose/lose/, in i915_drm_resume." > > > Signed-off-by: Gwan-gyeong Mun > > Reviewed-by:

Re: [Intel-gfx] [PATCH] drm/i915/icl: enable SAGV for ICL platform

2018-10-12 Thread Mun, Gwan-gyeong
On Thu, 2018-10-11 at 15:57 -0700, Paulo Zanoni wrote: > From: Mahesh Kumar > > Enable SAGV for ICL platform. > > Cc: Gwan-gyeong Mun > Reviewed-by: James Ausmus > Reviewed-by: Paulo Zanoni > Signed-off-by: Mahesh Kumar > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_pm.c

Re: [Intel-gfx] [RFC 1/6] drm/i915/dp: Support DP ports YUV 4:2:0 output to GEN11

2019-02-21 Thread Mun, Gwan-gyeong
On Fri, 2019-02-08 at 16:24 +0100, Maarten Lankhorst wrote: > Op 31-01-2019 om 22:10 schreef Gwan-gyeong Mun: > > Bspec describes that GEN10 only supports capability of YUV 4:2:0 > > output to > > HDMI port and GEN11 supports capability of YUV 4:2:0 output to both > > DP and > > HDMI ports. > > >

Re: [Intel-gfx] [RFC 4/6] drm/i915/dp: Program VSC Header and DB for Pixel Encoding/Colorimetry Format

2019-02-21 Thread Mun, Gwan-gyeong
On Fri, 2019-02-08 at 16:31 +0100, Maarten Lankhorst wrote: > Op 31-01-2019 om 22:10 schreef Gwan-gyeong Mun: > > Function intel_pixel_encoding_setup_vsc handles vsc header and data > > block > > setup for pixel encoding / colorimetry format. > > > > Setup VSC header and data block in function >

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Preliminary support for DP YCbCr4:2:0 outputs

2019-02-21 Thread Mun, Gwan-gyeong
On Mon, 2019-02-18 at 11:44 +0200, Jani Nikula wrote: > FWIW these are all valid checkpatch complaints. > > BR, > Jani. > > On Thu, 31 Jan 2019, Patchwork > wrote: > > == Series Details == > > > > Series: drm/i915/dp: Preliminary support for DP YCbCr4:2:0 outputs > > URL :

Re: [Intel-gfx] [RFC v2 1/6] drm/i915/dp: Add a config function for YCBCR420 outputs

2019-03-05 Thread Mun, Gwan-gyeong
On Thu, 2019-02-21 at 21:37 +0200, Ville Syrjälä wrote: > On Thu, Feb 21, 2019 at 09:27:26PM +0200, Gwan-gyeong Mun wrote: > > This patch checks a support of YCBCR420 outputs on an encoder > > level. > > If the input mode is YCBCR420-only mode then it prepares DP as an > > YCBCR420 > > output,

Re: [Intel-gfx] [RFC v4 1/6] drm/i915/dp: Add a config function for YCBCR420 outputs

2019-03-07 Thread Mun, Gwan-gyeong
On Wed, 2019-03-06 at 22:52 +0200, Ville Syrjälä wrote: > On Wed, Mar 06, 2019 at 09:30:57PM +0200, Gwan-gyeong Mun wrote: > > This patch checks a support of YCBCR420 outputs on an encoder > > level. > > If the input mode is YCBCR420-only mode then it prepares DP as an > > YCBCR420 > > output,

Re: [Intel-gfx] [RFC v4 5/6] drm/i915/dp: Change a link bandwidth computation for DP YCbCr 4:2:0 output

2019-03-07 Thread Mun, Gwan-gyeong
On Wed, 2019-03-06 at 23:04 +0200, Ville Syrjälä wrote: > On Wed, Mar 06, 2019 at 09:31:01PM +0200, Gwan-gyeong Mun wrote: > > All of the link bandwidth and Data M/N calculations were assumed a > > bpp as > > RGB format. But When we are using YCbCr 4:2:0 output format on DP, > > we should change

Re: [Intel-gfx] [PATCH 2/2] drm: Add detection of changing of edid on between suspend and resume

2019-04-11 Thread Mun, Gwan-gyeong
On Mon, 2019-03-04 at 12:45 +0100, Maarten Lankhorst wrote: > Op 01-03-2019 om 11:01 schreef Gwan-gyeong Mun: > > The hotplug detection routine of drm_helper_hpd_irq_event() can > > detect > > changing of status of connector, but it can not detect changing of > > edid. > > > > Following scenario

Re: [Intel-gfx] [PATCH v5 1/2] drm: Add detection of changing of edid on between suspend and resume

2019-04-16 Thread Mun, Gwan-gyeong
On Thu, 2019-04-11 at 17:00 +0100, Lisovskiy, Stanislav wrote: > On Thu, 2019-04-11 at 17:36 +0300, Gwan-gyeong Mun wrote: > > The hotplug detection routine of drm_helper_hpd_irq_event() can > > detect > > changing of status of connector, but it can not detect changing of > > edid. > > > >

Re: [Intel-gfx] [PATCH v5 0/2] drm: Add detection of changing of edid on between suspend and resume

2019-04-17 Thread Mun, Gwan-gyeong
On Mon, 2019-04-15 at 18:32 +0200, Daniel Vetter wrote: > On Thu, Apr 11, 2019 at 05:36:30PM +0300, Gwan-gyeong Mun wrote: > > This patch series fix missed detection of changing of edid on > > between > > suspend and resume. > > First patch fixes drm_helper_hdp_irq_event() in order to fix a > >

Re: [Intel-gfx] [PATCH] drm: Fire off KMS hotplug events if probe detect says the connector is connected

2019-04-18 Thread Mun, Gwan-gyeong
On Thu, 2019-04-18 at 10:28 +0200, Daniel Vetter wrote: > On Thu, Apr 18, 2019 at 11:09:29AM +0300, Gwan-gyeong Mun wrote: > > The hotplug detection routine of drm_helper_hpd_irq_event() can > > detect > > changing of status of connector, but it can not detect changing of > > properties of the

Re: [Intel-gfx] [PATCH v7 3/6] drm/i915/dp: Program VSC Header and DB for Pixel Encoding/Colorimetry Format

2019-05-20 Thread Mun, Gwan-gyeong
On Fri, 2019-05-17 at 15:36 +0200, Maarten Lankhorst wrote: > Op 10-05-2019 om 03:53 schreef Gwan-gyeong Mun: > > Function intel_pixel_encoding_setup_vsc handles vsc header and data > > block > > setup for pixel encoding / colorimetry format. > > > > Setup VSC header and data block in function >

Re: [Intel-gfx] [PATCH v6 3/6] drm/i915/dp: Program VSC Header and DB for Pixel Encoding/Colorimetry Format

2019-05-09 Thread Mun, Gwan-gyeong
On Wed, 2019-05-08 at 20:56 +0300, Ville Syrjälä wrote: > On Wed, May 08, 2019 at 11:17:54AM +0300, Gwan-gyeong Mun wrote: > > Function intel_pixel_encoding_setup_vsc handles vsc header and data > > block > > setup for pixel encoding / colorimetry format. > > > > Setup VSC header and data block

Re: [Intel-gfx] [PATCH v6 5/6] drm/i915/dp: Change a link bandwidth computation for DP

2019-05-09 Thread Mun, Gwan-gyeong
On Wed, 2019-05-08 at 20:58 +0300, Ville Syrjälä wrote: > On Wed, May 08, 2019 at 11:17:56AM +0300, Gwan-gyeong Mun wrote: > > Data M/N calculations were assumed a bpp as RGB format. But when we > > are > > using YCbCr 4:2:0 output format on DP, we should change bpp > > calculations > > as YCbCr

Re: [Intel-gfx] [PATCH v6 2/6] drm: Add a VSC structure for handling Pixel Encoding/Colorimetry Formats

2019-05-09 Thread Mun, Gwan-gyeong
On Wed, 2019-05-08 at 20:32 +0300, Ville Syrjälä wrote: > On Wed, May 08, 2019 at 11:17:53AM +0300, Gwan-gyeong Mun wrote: > > SDP VSC Header and Data Block follow DP 1.4a spec, section > > 2.2.5.7.5, > > chapter "VSC SDP Payload for Pixel Encoding/Colorimetry Format". > > > > Signed-off-by:

Re: [Intel-gfx] [PATCH v8 2/6] drm: Rename struct edp_vsc_psr to struct dp_sdp

2019-05-21 Thread Mun, Gwan-gyeong
On Tue, 2019-05-21 at 13:14 +0300, Laurent Pinchart wrote: > Hello Jani, > > On Tue, May 21, 2019 at 09:44:04AM +0300, Jani Nikula wrote: > > On Mon, 20 May 2019, Gwan-gyeong Mun > > wrote: > > > VSC SDP Payload for PSR is one of data block type of SDP > > > (Secondaray Data > > > Packet). In

Re: [Intel-gfx] [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected

2019-04-20 Thread Mun, Gwan-gyeong
On Thu, Apr 18, 2019 at 7:33 PM Jani Nikula wrote: > > On Thu, 18 Apr 2019, Gwan-gyeong Mun wrote: > > The hotplug detection routine of drm_helper_hpd_irq_event() can detect > > changing of status of connector, but it can not detect changing of > > properties of the connector. > > e.g. changing

Re: [Intel-gfx] [PATCH] drm/i915: Don't overestimate 4:2:0 link symbol clock

2019-07-11 Thread Mun, Gwan-gyeong
On Wed, 2019-07-10 at 15:58 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > With 4:2:0 output the LS clock can be half of what it is with 4:4:4. > Make that happen. > > Cc: Gwan-gyeong Mun > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_dp.c | 4 +++- > 1 file

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/dp: Add support of BT.2020 Colorimetry to DP MSA

2019-09-02 Thread Mun, Gwan-gyeong
On Mon, 2019-09-02 at 17:43 +0300, Ville Syrjälä wrote: > On Fri, Aug 23, 2019 at 12:52:28PM +0300, Gwan-gyeong Mun wrote: > > When BT.2020 Colorimetry output is used for DP, we should program > > BT.2020 > > Colorimetry to MSA and VSC SDP. It adds output_colorspace to > > intel_crtc_state struct

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata

2019-09-02 Thread Mun, Gwan-gyeong
On Tue, 2019-08-27 at 01:14 +0530, Shankar, Uma wrote: > > -Original Message- > > From: Mun, Gwan-gyeong > > Sent: Friday, August 23, 2019 3:23 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: dri-de...@lists.freedesktop.org; Shankar, Uma < >

Re: [Intel-gfx] [PATCH v2 3/6] drm: Add DisplayPort colorspace property

2019-09-02 Thread Mun, Gwan-gyeong
On Mon, 2019-09-02 at 17:44 +0300, Ville Syrjälä wrote: > On Fri, Aug 23, 2019 at 12:52:29PM +0300, Gwan-gyeong Mun wrote: > > In order to use colorspace property to Display Port connectors, it > > extends > > DRM_MODE_CONNECTOR_DisplayPort connector_type on > > drm_mode_create_colorspace_property

Re: [Intel-gfx] [PATCH v4 3/7] drm: Add DisplayPort colorspace property

2019-09-07 Thread Mun, Gwan-gyeong
; > > > Sent: Tuesday, September 3, 2019 6:12 PM > > > > To: Mun, Gwan-gyeong > > > > Cc: Intel Graphics Development > > > >; Shankar, Uma > > > > ; dri-devel < > > > > dri-de...@lists.freedesktop.org> > > > > Sub

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Switch to using DP_MSA_MISC_* defines

2019-09-18 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that we have standard defines for the MSA MISC bits lets use > them on HSW+ where we program these directly into the TRANS_MSA_MISC > register. > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Don't look at unrelated PIPECONF bits for interlaced readout

2019-09-18 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Since HSW the PIPECONF progressive vs. interlaced selection is done > with just two bits instead of the earlier three. Let's not look at > the > extra bit on HSW+. Also gen2 doesn't support interlaced displays at >

Re: [Intel-gfx] [PATCH v2 05/12] drm/i915: Never set limited_color_range=true for YCbCr output

2019-09-18 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 19:45 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > crtc_state->limited_color_range only applies to RGB output but > we're currently setting it even for YCbCr output. That will > lead to conflicting MSA and PIPECONF settings which can mess > up the image. Let's make

Re: [Intel-gfx] [PATCH 12/12] drm/i915: Add PIPECONF YCbCr 4:4:4 programming for ILK-IVB

2019-09-18 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > On ILK-IVB the pipe colorspace is configured via PIPECONF > (as opposed to PIPEMISC in BDW+). Let's configure+readout > that stuff correctly. > > Enablling YCbCr 4:4:4 output will now be a simple matter of Typo:

Re: [Intel-gfx] [PATCH 01/12] drm/dp: Add definitons for MSA MISC bits

2019-09-18 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add definitions for the MSA (Main Stream Attribute) MISC bits. On > some hardware you can program these directly into a register. > > Signed-off-by: Ville Syrjälä > --- > include/drm/drm_dp_helper.h | 42 >

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Fix HSW+ DP MSA YCbCr colorspace indication

2019-09-18 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Looks like we're currently setting the MSA to xvYCC BT.709 instead > of the YCbCr BT.601 claimed by the comment. But even that comment > is wrong since we configure the CSC matrix to BT.709. > > Let's remove the

Re: [Intel-gfx] [PATCH 04/12] drm/i915: Extract intel_hdmi_limited_color_range()

2019-09-18 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Pull the code for computing the limited color range > setting into a small helper. We'll add a bit more to it > later. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 30

Re: [Intel-gfx] [PATCH 09/12] drm/i915: Add PIPECONF YCbCr 4:4:4 programming for HSW

2019-09-18 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > On HSW the pipe colorspace is configured via PIPECONF > (as opposed to PIPEMISC in BDW+). Let's configure+readout > that stuff correctly. > > Enablling YCbCr 4:4:4 output will now be a simple matter of Typo:

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Simplify intel_get_crtc_ycbcr_config()

2019-09-18 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Make intel_get_crtc_ycbcr_config() simpler and rename it > to bdw_get_pipemisc_output_format() to better reflect what > it does. > > Also toss in some comments to document that the 4:2:0 PIPECONF > bits are glk+

Re: [Intel-gfx] [PATCH v7 3/7] drm: Add DisplayPort colorspace property

2019-09-16 Thread Mun, Gwan-gyeong
On Fri, 2019-09-13 at 22:13 +0300, Ville Syrjälä wrote: > On Thu, Sep 12, 2019 at 02:33:34PM +0300, Gwan-gyeong Mun wrote: > > Because between HDMI and DP have different colorspaces, it renames > > drm_mode_create_colorspace_property() function to > > drm_mode_create_hdmi_colorspace_property()

Re: [Intel-gfx] [PATCH v4 3/7] drm: Add DisplayPort colorspace property

2019-09-10 Thread Mun, Gwan-gyeong
On Mon, 2019-09-09 at 13:25 +0300, Ville Syrjälä wrote: > On Sat, Sep 07, 2019 at 11:19:55PM +0000, Mun, Gwan-gyeong wrote: > > On Fri, 2019-09-06 at 09:24 -0400, Ilia Mirkin wrote: > > > On Fri, Sep 6, 2019 at 7:43 AM Ville Syrjälä > > > wrote: > > > > O

Re: [Intel-gfx] [PATCH v4 3/7] drm: Add DisplayPort colorspace property

2019-09-10 Thread Mun, Gwan-gyeong
On Sat, 2019-09-07 at 21:43 -0400, Ilia Mirkin wrote: > On Sat, Sep 7, 2019 at 7:20 PM Mun, Gwan-gyeong > wrote: > > On Fri, 2019-09-06 at 09:24 -0400, Ilia Mirkin wrote: > > > On Fri, Sep 6, 2019 at 7:43 AM Ville Syrjälä > > > wrote: > > > > On Fri,

Re: [Intel-gfx] [PATCH v8 6/7] drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata

2019-09-19 Thread Mun, Gwan-gyeong
On Wed, 2019-09-18 at 17:13 +0300, Ville Syrjälä wrote: > On Mon, Sep 16, 2019 at 10:11:49AM +0300, Gwan-gyeong Mun wrote: > > Function intel_dp_setup_hdr_metadata_infoframe_sdp handles > > Infoframe SDP > > header and data block setup for HDR Static Metadata. It enables > > writing of > > HDR

Re: [Intel-gfx] [PATCH v8 2/7] drm/i915/dp: Add support of BT.2020 Colorimetry to DP MSA

2019-09-19 Thread Mun, Gwan-gyeong
On Wed, 2019-09-18 at 17:15 +0300, Ville Syrjälä wrote: > On Mon, Sep 16, 2019 at 10:11:45AM +0300, Gwan-gyeong Mun wrote: > > When BT.2020 Colorimetry output is used for DP, we should program > > BT.2020 > > Colorimetry to MSA and VSC SDP. It adds output_colorspace to > > intel_crtc_state struct

Re: [Intel-gfx] [PATCH v8 3/7] drm: Add DisplayPort colorspace property

2019-09-19 Thread Mun, Gwan-gyeong
On Wed, 2019-09-18 at 17:08 +0300, Ville Syrjälä wrote: > On Mon, Sep 16, 2019 at 10:11:46AM +0300, Gwan-gyeong Mun wrote: > > Because between HDMI and DP have different colorspaces, it renames > > drm_mode_create_colorspace_property() function to > > drm_mode_create_hdmi_colorspace_property()

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Set up ILK/SNB csc unit properly for YCbCr output

2019-09-20 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Prepare the pipe csc for YCbCr output on ilk/snb. The main difference > to IVB+ is the lack of explicit post offsets, and instead we must > configure the CSC info RGB->YUV mode (which takes care of offsetting >

Re: [Intel-gfx] [PATCH 12/12] drm/i915: Add PIPECONF YCbCr 4:4:4 programming for ILK-IVB

2019-09-20 Thread Mun, Gwan-gyeong
Except typo, the changes look good to me. Reviewed-by: Gwan-gyeong Mun On Wed, 2019-09-18 at 19:05 +, Mun, Gwan-gyeong wrote: > On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On ILK-IVB the pipe colorspace is configured via PIP

Re: [Intel-gfx] [PATCH 09/12] drm/i915: Add PIPECONF YCbCr 4:4:4 programming for HSW

2019-09-20 Thread Mun, Gwan-gyeong
Except typo, the changes look good to me. Reviewed-by: Gwan-gyeong Mun On Wed, 2019-09-18 at 19:03 +, Mun, Gwan-gyeong wrote: > On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On HSW the pipe colorspace is configured via PIP

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Split a setting of MSA to MST and SST (rev3)

2019-11-11 Thread Mun, Gwan-gyeong
On Sat, 2019-11-09 at 05:16 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Split a setting of MSA to MST and SST (rev3) > URL : https://patchwork.freedesktop.org/series/69092/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7288_full ->

Re: [Intel-gfx] [PATCH] drm/i915: Split a setting of MSA to MST and SST

2019-11-11 Thread Mun, Gwan-gyeong
On Mon, 2019-11-11 at 11:46 +, Saarinen, Jani wrote: > Hi, > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Souza, > > Jose > > Sent: torstai 7. marraskuuta 2019 23.16 > > To: Mun, Gwan-gyeong ; intel- > > g...@lists.fre

Re: [Intel-gfx] [PATCH] drm/i915/display: Force the state compute phase once to enable PSR

2019-12-05 Thread Mun, Gwan-gyeong
Hi, On Mon, 2019-11-25 at 15:38 -0800, José Roberto de Souza wrote: > Recent improvements in the state tracking in i915 caused PSR to not > be > enabled when reusing firmware/BIOS modeset, this is due to all > initial > commits returning ealier in intel_atomic_check() as needs_modeset() > is

Re: [Intel-gfx] [PATCH] drm/i915: Fix MST oops due to MSA changes

2019-10-16 Thread Mun, Gwan-gyeong
On Tue, 2019-10-15 at 22:05 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The MSA MISC computation now depends on the connector state, and > we do it from the DDI .pre_enable() hook. All that is fine for > DP SST but with MST we don't actually pass the connector state > to the dig port's

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Fix AVI infoframe quantization range for YCbCr output

2019-09-20 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We're configuring the AVI infoframe quantization range bits as if > we're always transmitting RGB pixels. Let's fix this so that we > correctly indicate limited range YCC quantization range when > transmitting

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Document ILK+ pipe csc matrix better

2019-09-20 Thread Mun, Gwan-gyeong
On Thu, 2019-07-18 at 17:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add comments to explain the ilk pipe csc operation a bit better. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_color.c | 26 +--- > -- > 1 file changed, 21

Re: [Intel-gfx] [PATCH v3 04/17] drm/i915/dp: Add writing of DP SDPs (Secondary Data Packet)

2020-02-08 Thread Mun, Gwan-gyeong
On Wed, 2020-02-05 at 21:39 +0530, Shankar, Uma wrote: > > -Original Message- > > From: dri-devel On Behalf > > Of Gwan- > > gyeong Mun > > Sent: Tuesday, February 4, 2020 4:50 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: linux-fb...@vger.kernel.org; dri-de...@lists.freedesktop.org

Re: [Intel-gfx] [PATCH v3 06/17] drm/i915/dp: Read out DP SDPs (Secondary Data Packet)

2020-02-08 Thread Mun, Gwan-gyeong
On Wed, 2020-02-05 at 21:59 +0530, Shankar, Uma wrote: > > -Original Message- > > From: dri-devel On Behalf > > Of Gwan- > > gyeong Mun > > Sent: Tuesday, February 4, 2020 4:50 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: linux-fb...@vger.kernel.org; dri-de...@lists.freedesktop.org

Re: [Intel-gfx] [PATCH v3 01/17] drm: add DP 1.4 VSC SDP Payload related enums and a structure

2020-02-08 Thread Mun, Gwan-gyeong
On Wed, 2020-02-05 at 20:12 +0530, Shankar, Uma wrote: > > -Original Message- > > From: dri-devel On Behalf > > Of Gwan- > > gyeong Mun > > Sent: Tuesday, February 4, 2020 4:50 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: linux-fb...@vger.kernel.org; dri-de...@lists.freedesktop.org

Re: [Intel-gfx] [PATCH 08/18] drm/i915/dp: Add logging function for DP VSC SDP

2020-02-03 Thread Mun, Gwan-gyeong
On Sat, 2020-02-01 at 14:43 +0200, Jani Nikula wrote: > On Fri, 31 Jan 2020, Gwan-gyeong Mun > wrote: > > When receiving video it is very useful to be able to log DP VSC > > SDP. > > This greatly simplifies debugging. > > Seems like a lot of the functions should really be in drm core. > > BR, >

Re: [Intel-gfx] [PATCH v3 11/17] drm/i915: Program DP SDPs with computed configs

2020-02-08 Thread Mun, Gwan-gyeong
On Wed, 2020-02-05 at 22:21 +0530, Shankar, Uma wrote: > > -Original Message- > > From: Intel-gfx On Behalf > > Of Gwan- > > gyeong Mun > > Sent: Tuesday, February 4, 2020 4:50 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: linux-fb...@vger.kernel.org; dri-de...@lists.freedesktop.org

Re: [Intel-gfx] [PATCH v4] drm/i915/psr: Force PSR probe only after full initialization

2020-02-21 Thread Mun, Gwan-gyeong
On Thu, 2020-02-20 at 15:15 -0800, José Roberto de Souza wrote: > Commit 60c6a14b489b ("drm/i915/display: Force the state compute phase > once to enable PSR") was forcing the state compute too earlier > causing errors because not everything was initialized, so here > moving to the end of

Re: [Intel-gfx] [PATCH v4] drm/i915/psr: Force PSR probe only after full initialization

2020-02-21 Thread Mun, Gwan-gyeong
On Fri, 2020-02-21 at 12:11 -0800, Souza, Jose wrote: > On Fri, 2020-02-21 at 20:04 +0000, Mun, Gwan-gyeong wrote: > > On Thu, 2020-02-20 at 15:15 -0800, José Roberto de Souza wrote: > > > Commit 60c6a14b489b ("drm/i915/display: Force the state compute > > >

Re: [Intel-gfx] [PATCH v3] drm/i915/psr: Force PSR probe only after full initialization

2020-02-21 Thread Mun, Gwan-gyeong
On Fri, 2020-02-21 at 10:15 -0800, Souza, Jose wrote: > On Fri, 2020-02-21 at 15:46 +0000, Mun, Gwan-gyeong wrote: > > On Thu, 2020-02-20 at 12:55 -0800, Souza, Jose wrote: > > > On Thu, 2020-02-20 at 12:39 +, Mun, Gwan-gyeong wrote: > > > > On Tue, 2020-02-18 a

Re: [Intel-gfx] [PATCH v3] drm/i915/psr: Force PSR probe only after full initialization

2020-02-21 Thread Mun, Gwan-gyeong
On Thu, 2020-02-20 at 12:55 -0800, Souza, Jose wrote: > On Thu, 2020-02-20 at 12:39 +0000, Mun, Gwan-gyeong wrote: > > On Tue, 2020-02-18 at 12:39 -0800, José Roberto de Souza wrote: > > > Commit 60c6a14b489b ("drm/i915/display: Force the state compute > > >

Re: [Intel-gfx] [PATCH v3] drm/i915/psr: Force PSR probe only after full initialization

2020-02-20 Thread Mun, Gwan-gyeong
On Tue, 2020-02-18 at 12:39 -0800, José Roberto de Souza wrote: > Commit 60c6a14b489b ("drm/i915/display: Force the state compute phase > once to enable PSR") was forcing the state compute too earlier > causing errors because not everything was initialized, so here > moving to

Re: [Intel-gfx] [PATCH v3] drm/i915/display: Force the state compute phase once to enable PSR

2020-01-08 Thread Mun, Gwan-gyeong
On Mon, 2020-01-06 at 07:21 -0800, José Roberto de Souza wrote: > Recent improvements in the state tracking in i915 caused PSR to not > be > enabled when reusing firmware/BIOS modeset, this is due to all > initial > commits returning ealier in intel_atomic_check() as needs_modeset() > is always

Re: [Intel-gfx] [PATCH v7 05/18] video/hdmi: Add Unpack only function for DRM infoframe

2020-03-27 Thread Mun, Gwan-gyeong
On Fri, 2020-03-20 at 13:57 +0200, Laurent Pinchart wrote: > Hi Jani, > > On Fri, Mar 20, 2020 at 01:32:17PM +0200, Jani Nikula wrote: > > On Fri, 20 Mar 2020, Jani Nikula > > wrote: > > > On Tue, 11 Feb 2020, Gwan-gyeong Mun > > > wrote: > > > > It adds an unpack only function for DRM

Re: [Intel-gfx] [PATCH v7 05/18] video/hdmi: Add Unpack only function for DRM infoframe

2020-03-30 Thread Mun, Gwan-gyeong
On Fri, 2020-03-27 at 14:56 +0200, Ville Syrjälä wrote: > On Fri, Mar 27, 2020 at 07:27:56AM +0000, Mun, Gwan-gyeong wrote: > > On Fri, 2020-03-20 at 13:57 +0200, Laurent Pinchart wrote: > > > Hi Jani, > > > > > > On Fri, Mar 20, 2020 at 01:32:17PM +0200, Jani

Re: [Intel-gfx] [PATCH v12 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-05-15 Thread Mun, Gwan-gyeong
Hi Ville, Thank you for notifying me that. I definitely missed the crash. Sorry for that. Danial and Jani, I' under debugging the crash case. If you are availabe please do not merge current version. Br, G.G. > On Fri, 2020-05-15 at 16:14 +0200, Daniel Vetter wrote: > On Fri, May 15, 2020 at

Re: [Intel-gfx] [PATCH v12 01/14] video/hdmi: Add Unpack only function for DRM infoframe

2020-05-14 Thread Mun, Gwan-gyeong
Hi Bartlomiej and Laurent Pinchart, can I have your ack for merging this via drm-intel along with the rest of the series, please? BR, G.G. On Thu, 2020-05-14 at 09:07 +0300, Gwan-gyeong Mun wrote: > It adds an unpack only function for DRM infoframe for dynamic range > and > mastering infoframe

Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: Program PSR2 selective fetch registers

2020-09-15 Thread Mun, Gwan-gyeong
t; > selective fetch registers and MAN_TRK_CTL enabling selective > > > fetch but > > > for now it is fetching the whole area of the planes. > > > The damaged area calculation will come as next and final step. > > > > > > BSpec: 55229 >

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Program PSR2 selective fetch registers

2020-10-07 Thread Mun, Gwan-gyeong
On Thu, 2020-10-01 at 10:14 -0700, Souza, Jose wrote: > On Thu, 2020-10-01 at 12:24 +0100, Mun, Gwan-gyeong wrote: > > On Thu, 2020-09-24 at 10:42 -0700, José Roberto de Souza wrote: > > > Another step towards PSR2 selective fetch, here programming plane > > >

Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications

2020-10-12 Thread Mun, Gwan-gyeong
On Mon, 2020-10-12 at 11:15 -0700, Souza, Jose wrote: > On Mon, 2020-10-12 at 19:12 +0100, Mun, Gwan-gyeong wrote: > > After applying this patch, the psr screen glitch issue is still > > seen. > > Same IOMMU errors too? In my end it is fixed. > Can you also give a try

Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications

2020-10-12 Thread Mun, Gwan-gyeong
After applying this patch, the psr screen glitch issue is still seen. On Fri, 2020-10-02 at 16:16 -0700, José Roberto de Souza wrote: > Writes to CURSURFLIVE in TGL are causing IOMMU errors and visual > glitches that are often reproduced when executing CPU intensive > workloads while a eDP 4K

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915/display: Program PSR2 selective fetch registers

2020-10-08 Thread Mun, Gwan-gyeong
Looks good to me. Reviewed-by: Gwan-gyeong Mun On Wed, 2020-10-07 at 12:52 -0700, José Roberto de Souza wrote: > Another step towards PSR2 selective fetch, here programming plane > selective fetch registers and MAN_TRK_CTL enabling selective fetch > but > for now it is fetching the whole area

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/display: Program PSR2 selective fetch registers

2020-09-23 Thread Mun, Gwan-gyeong
On Thu, 2020-09-17 at 18:02 -0700, José Roberto de Souza wrote: > Another step towards PSR2 selective fetch, here programming plane > selective fetch registers and MAN_TRK_CTL enabling selective fetch > but > for now it is fetching the whole area of the planes. > The damaged area calculation will

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/display: Program PSR2 selective fetch registers

2020-09-24 Thread Mun, Gwan-gyeong
On Wed, 2020-09-23 at 10:09 -0700, Souza, Jose wrote: > On Wed, 2020-09-23 at 10:10 -0700, José Roberto de Souza wrote: > > On Wed, 2020-09-23 at 14:02 +0100, Mun, Gwan-gyeong wrote: > > > On Thu, 2020-09-17 at 18:02 -0700, José Roberto de Souza wrote: > > > > Anoth

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Program PSR2 selective fetch registers

2020-10-01 Thread Mun, Gwan-gyeong
On Thu, 2020-09-24 at 10:42 -0700, José Roberto de Souza wrote: > Another step towards PSR2 selective fetch, here programming plane > selective fetch registers and MAN_TRK_CTL enabling selective fetch > but > for now it is fetching the whole area of the planes. > The damaged area calculation will

Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: Program PSR2 selective fetch registers

2020-09-17 Thread Mun, Gwan-gyeong
On Tue, 2020-09-15 at 12:57 -0700, Souza, Jose wrote: > On Tue, 2020-09-15 at 20:28 +0100, Mun, Gwan-gyeong wrote: > > On Mon, 2020-09-14 at 13:15 -0700, Souza, Jose wrote: > > > On Mon, 2020-09-14 at 17:28 +0300, Ville Syrjälä wrote: > > > > On Mon, Aug 31, 2020 at

Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications

2020-10-22 Thread Mun, Gwan-gyeong
1. While testing the problematic scenario, it has not always shown the IOMMU DAMR related below errors on the drm-tip. (sometimes the error messages raised, but some times it has not happened on the same kernel and scenario. DMAR: DRHD: handling fault status reg 2 DMAR: [DMA Read] Request

Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications

2020-10-22 Thread Mun, Gwan-gyeong
On Thu, 2020-10-22 at 12:43 +, Mun, Gwan-gyeong wrote: > 1. While testing the problematic scenario, it has not always shown > the > IOMMU DAMR related below errors on the drm-tip. >(sometimes the error messages raised, but some times it has not > happened on the same kern

Re: [Intel-gfx] [PATCH 1/6] drm/i915/display/psr: Calculate selective fetch plane registers

2020-10-26 Thread Mun, Gwan-gyeong
On Tue, 2020-10-13 at 16:01 -0700, José Roberto de Souza wrote: > Add the calculations to set plane selective fetch registers depending > in the value of the area damaged. > It is still using the whole plane area as damaged but that will > change > in next patches. > > BSpec: 55229 > Cc:

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-10-26 Thread Mun, Gwan-gyeong
On Tue, 2020-10-13 at 16:01 -0700, José Roberto de Souza wrote: > Now using plane damage clips property to calcualte the damaged area. > Selective fetch only supports one region to be fetched so software > needs to calculate a bounding box around all damage clips. > > Cc: Ville Syrjälä > Cc:

Re: [Intel-gfx] [PATCH 3/6] drm/i915/display/psr: Consider other planes to damaged area calculation

2020-10-27 Thread Mun, Gwan-gyeong
On Tue, 2020-10-13 at 16:01 -0700, José Roberto de Souza wrote: > Planes can individually have transparent, move or have visibility > changed if any of those happens, planes bellow it will be visible or > have more pixels of it visible than before. > > This patch is taking care of this case for

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/display: Implement WA 1408330847

2020-08-10 Thread Mun, Gwan-gyeong
On Mon, 2020-07-06 at 16:43 -0700, José Roberto de Souza wrote: > From the 3 WAs for PSR2 man track/selective fetch this is only one > needed when doing single full frames at every flip. > > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/i915/display/intel_psr.c | 19

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Initial implementation of PSR2 selective fetch

2020-08-10 Thread Mun, Gwan-gyeong
On Mon, 2020-07-06 at 16:43 -0700, José Roberto de Souza wrote: > All GEN12 platforms supports PSR2 selective fetch but not all GEN12 > platforms supports PSR2 hardware tracking(aka RKL). > > This feature consists in software programming registers with the > damaged area of each plane this way

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add PSR2 software tracking registers

2020-06-15 Thread Mun, Gwan-gyeong
On Fri, 2020-06-12 at 21:49 +, Mun, Gwan-gyeong wrote: > On Fri, 2020-06-12 at 14:18 -0700, Souza, Jose wrote: > > On Fri, 2020-06-12 at 21:57 +0100, Mun, Gwan-gyeong wrote: > > > On Tue, 2020-05-26 at 15:14 -0700, José Roberto de Souza wrote: > > > > This regis

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Implement PSR2 selective fetch

2020-06-16 Thread Mun, Gwan-gyeong
On Mon, 2020-06-15 at 19:40 +0300, Ville Syrjälä wrote: > On Fri, Jun 12, 2020 at 08:33:31PM +, Souza, Jose wrote: > > On Fri, 2020-06-12 at 19:30 +0300, Ville Syrjälä wrote: > > > On Tue, May 26, 2020 at 03:14:46PM -0700, José Roberto de Souza > > > wrote: > > > > All GEN12 platforms supports

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Add PSR2 selective fetch registers

2020-06-26 Thread Mun, Gwan-gyeong
On Thu, 2020-06-25 at 18:01 -0700, José Roberto de Souza wrote: > This registers will be used to implement PSR2 manual > tracking/selective > fetch. > > v2: > - Fixed typo in _PLANE_SEL_FETCH_BASE > - Renamed PSR2_MAN_TRK_CTL bits to better match spec names > - Renamed _PLANE_SEL_FETCH_* to

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Implement PSR2 selective fetch

2020-06-16 Thread Mun, Gwan-gyeong
On Tue, 2020-06-16 at 10:29 -0700, Souza, Jose wrote: > On Tue, 2020-06-16 at 16:16 +0100, Mun, Gwan-gyeong wrote: > > On Mon, 2020-06-15 at 19:40 +0300, Ville Syrjälä wrote: > > > On Fri, Jun 12, 2020 at 08:33:31PM +, Souza, Jose wrote: > > > > On Fri, 2020-06-12

Re: [Intel-gfx] [PATCH] drm/i915: Add psr_safest_params

2020-06-04 Thread Mun, Gwan-gyeong
Looks good to me. Reviewed-by: Gwan-gyeong Mun On Wed, 2020-05-20 at 14:27 -0700, José Roberto de Souza wrote: > This parameter is meant to be used when PSR issues are found as some > issues in the past was due wrong values set in VBT so this would be > a quick and easy way to ask users or for

Re: [Intel-gfx] [PATCH] drm/i915/psr: Program default IO buffer Wake and Fast Wake

2020-06-05 Thread Mun, Gwan-gyeong
On Thu, 2020-06-04 at 18:51 -0700, Souza, Jose wrote: > On Fri, 2020-06-05 at 03:23 +0300, Gwan-gyeong Mun wrote: > > The IO buffer Wake and Fast Wake bit size and value have been > > changed from > > Gen12+. > > It programs default value of IO buffer Wake and Fast Wake on > > Gen12+. > > > > -

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Add plane damage clips property

2020-06-12 Thread Mun, Gwan-gyeong
This feature is supported from GEN9+, but this time it focuses on supporting of PSR2 software tracking for GEN12+. Looks good to me. Reviewed-by: Gwan-gyeong Mun On Tue, 2020-05-26 at 15:14 -0700, José Roberto de Souza wrote: > This property will be used by PSR2 software tracking, adding it to

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Reorder intel_psr2_config_valid()

2020-06-12 Thread Mun, Gwan-gyeong
Looks good to me. Reviewed-by: Gwan-gyeong Mun On Tue, 2020-05-26 at 15:14 -0700, José Roberto de Souza wrote: > Future patches will bring PSR2 selective fetch configuration > validation but most of the configuration checks will be used for HW > tracking and selective fetch so the reoder was

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add PSR2 software tracking registers

2020-06-12 Thread Mun, Gwan-gyeong
On Fri, 2020-06-12 at 14:18 -0700, Souza, Jose wrote: > On Fri, 2020-06-12 at 21:57 +0100, Mun, Gwan-gyeong wrote: > > On Tue, 2020-05-26 at 15:14 -0700, José Roberto de Souza wrote: > > > This registers will be used to implement PSR2 software tracking. > > > > >

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add PSR2 software tracking registers

2020-06-12 Thread Mun, Gwan-gyeong
On Tue, 2020-05-26 at 15:14 -0700, José Roberto de Souza wrote: > This registers will be used to implement PSR2 software tracking. > > BSpec: 55229 > BSpec: 50424 > BSpec: 50420 > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/i915/i915_reg.h | 68 ++- >

Re: [Intel-gfx] [RFC][PATCH 2/3] drm/i915: Sending AVI infoframe through GMP DIP

2021-01-07 Thread Mun, Gwan-gyeong
On Fri, 2020-12-18 at 16:03 +0530, Swati Sharma wrote: > DP does not support sending AVI info frame to panel. So we need to > send AVI info frame to HDMI through some other DIP. > > When DP-to-HDMI protocol converter is present GMP DIP will be used > to send AVI infoframe instead of static HDR

Re: [Intel-gfx] [RFC][PATCH 3/3] drm/i915: Implement readout for AVI infoframe SDP

2021-01-07 Thread Mun, Gwan-gyeong
On Fri, 2020-12-18 at 16:03 +0530, Swati Sharma wrote: > In this patch readout for AVI infoframes enclosed in GMP > DIP is implemented. > > Signed-off-by: Swati Sharma > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 74 > - > 1 file

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915/display/psr: Calculate selective fetch plane registers

2020-11-27 Thread Mun, Gwan-gyeong
Reviewed-by: Gwan-gyeong Mun Tested-by: Gwan-gyeong Mun On Mon, 2020-11-02 at 11:18 -0800, Souza, Jose wrote: > On Thu, 2020-10-29 at 21:37 +0000, Mun, Gwan-gyeong wrote: > > On Tue, 2020-10-27 at 16:45 -0700, José Roberto de Souza wrote: > > > Add the calculations to set pla

Re: [Intel-gfx] [PATCH v2 5/6] RFC/WIP: drm/i915/display/psr: Consider tiling when doing the plane offset calculation

2020-11-27 Thread Mun, Gwan-gyeong
It works properly on a normal rgba plane. In order to apply this patch, the commit messaged need to be polished. Reviewed-by: Gwan-gyeong Mun Tested-by: Gwan-gyeong Mun On Tue, 2020-10-27 at 16:45 -0700, José Roberto de Souza wrote: > Do the calculation of x and y offsets using >

Re: [Intel-gfx] [PATCH v2 4/6] drm/i915/display: Split and export main surface calculation from skl_check_main_surface()

2020-11-27 Thread Mun, Gwan-gyeong
Reviewed-by: Gwan-gyeong Mun Tested-by: Gwan-gyeong Mun On Tue, 2020-10-27 at 16:45 -0700, José Roberto de Souza wrote: > The calculation the offsets of the main surface will be needed by > PSR2 > selective fetch code so here splitting and exporting it. > No functional changes were done here. >

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-01 Thread Mun, Gwan-gyeong
On Tue, 2020-12-01 at 09:39 -0800, Souza, Jose wrote: > On Tue, 2020-12-01 at 17:26 +0000, Mun, Gwan-gyeong wrote: > > On Tue, 2020-10-27 at 13:12 -0700, Souza, Jose wrote: > > > On Tue, 2020-10-27 at 01:04 +, Souza, Jose wrote: > > > > On Mon, 2020-10-26 at 21:40

Re: [Intel-gfx] [PATCH 3/6] drm/i915/display/psr: Consider other planes to damaged area calculation

2020-12-01 Thread Mun, Gwan-gyeong
On Tue, 2020-12-01 at 09:44 -0800, Souza, Jose wrote: > On Tue, 2020-12-01 at 17:33 +0000, Mun, Gwan-gyeong wrote: > > On Tue, 2020-10-27 at 10:25 -0700, Souza, Jose wrote: > > > On Tue, 2020-10-27 at 13:34 +, Mun, Gwan-gyeong wrote: > > > > On Tue, 2020-10-13 a

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-01 Thread Mun, Gwan-gyeong
On Tue, 2020-10-27 at 13:12 -0700, Souza, Jose wrote: > On Tue, 2020-10-27 at 01:04 +, Souza, Jose wrote: > > On Mon, 2020-10-26 at 21:40 +0000, Mun, Gwan-gyeong wrote: > > > On Tue, 2020-10-13 at 16:01 -0700, José Roberto de Souza wrote: > > > > Now usi

Re: [Intel-gfx] [PATCH 3/6] drm/i915/display/psr: Consider other planes to damaged area calculation

2020-12-01 Thread Mun, Gwan-gyeong
On Tue, 2020-10-27 at 10:25 -0700, Souza, Jose wrote: > On Tue, 2020-10-27 at 13:34 +0000, Mun, Gwan-gyeong wrote: > > On Tue, 2020-10-13 at 16:01 -0700, José Roberto de Souza wrote: > > > Planes can individually have transparent, move or have visibility > > > chan

Re: [Intel-gfx] [PATCH v3 4/9] drm/i915/display/dp: Do not enable PSR if VRR is enabled

2020-12-04 Thread Mun, Gwan-gyeong
On Thu, 2020-12-03 at 15:53 -0800, Manasi Navare wrote: > Even though our HW supports PSR + VRR, the available panels > do not work reliably with PSR and VRR together. So if user > requested VRR and is supported by HW enable that and do not > enable PSR in that case. > > Cc: Ville Syrjälä > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: wait PSR state back to idle when turn PSR off

2020-12-02 Thread Mun, Gwan-gyeong
On Fri, 2020-10-23 at 21:06 +, Souza, Jose wrote: > On Thu, 2020-10-22 at 13:56 +, Lee, Shawn C wrote: > > On Thu, Oct. 22, 2020, 3:24 a.m, Lee Shawn C wrote: > > > On Wed, Oct. 21, 2020, 5:13 p.m, Souza, Jose wrote: > > > > On Wed, 2020-10-21 at 22:24 +0800, Lee Shawn C wrote: > > > > >

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-02 Thread Mun, Gwan-gyeong
On Tue, 2020-12-01 at 13:15 -0800, Souza, Jose wrote: > On Tue, 2020-12-01 at 19:40 +0000, Mun, Gwan-gyeong wrote: > > On Tue, 2020-12-01 at 09:39 -0800, Souza, Jose wrote: > > > On Tue, 2020-12-01 at 17:26 +, Mun, Gwan-gyeong wrote: > > > > On Tue, 2020-10-27 at

  1   2   >