[Intel-gfx] [RFC] drm/i915: Simplify page allocation loop a bit

2014-03-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Looks like there are some redundant lines in the main loop of i915_gem_object_get_pages_gtt. v2: Put CONFIG_SWIOTLB back in. I haven't tested this so just RFC please. Not sure that seven lines net less is worth this. It just made it clerer to a

Re: [Intel-gfx] [RFC] drm/i915: Simplify page allocation loop a bit

2014-03-27 Thread Tvrtko Ursulin
On 03/27/2014 10:18 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Looks like there are some redundant lines in the main loop of i915_gem_object_get_pages_gtt. v2: Put CONFIG_SWIOTLB back in. I haven't tested this so just RFC please. Not sure that seven lines net

[Intel-gfx] [RFC] drm/i915: Simplify page allocation loop a bit

2014-03-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Looks like there are some redundant lines in the main loop of i915_gem_object_get_pages_gtt. I haven't tested this so just RFC please. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Cc: Imre Deak imre.d...@intel.com ---

Re: [Intel-gfx] [RFC] drm/i915: Simplify page allocation loop a bit

2014-03-26 Thread Imre Deak
On Wed, 2014-03-26 at 16:48 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Looks like there are some redundant lines in the main loop of i915_gem_object_get_pages_gtt. I haven't tested this so just RFC please. Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [RFC] drm/i915: Simplify page allocation loop a bit

2014-03-26 Thread Chris Wilson
On Wed, Mar 26, 2014 at 04:48:47PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Looks like there are some redundant lines in the main loop of i915_gem_object_get_pages_gtt. I haven't tested this so just RFC please. Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [RFC] drm/i915: Simplify page allocation loop a bit

2014-03-26 Thread Tvrtko Ursulin
On 03/26/2014 05:11 PM, Chris Wilson wrote: On Wed, Mar 26, 2014 at 04:48:47PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Looks like there are some redundant lines in the main loop of i915_gem_object_get_pages_gtt. I haven't tested this so just RFC please.