Re: [Interest] Q_NAMESPACE is not portable?

2019-08-27 Thread John Weeks
And I was taught in middle school that such a "for instance" should have commas 
before and after:

"This is useful, for instance, if the object needs to be exported from a 
dynamic library."

> On Aug 27, 2019, at 12:58 AM, Kai Köhne  wrote:
> 
> 
> 
>> -Original Message-
>> From: Interest  On Behalf Of Jason H
>> Sent: Monday, August 26, 2019 10:33 PM
>> To: Andy 
>> Cc: Qt Project 
>> Subject: Re: [Interest] Q_NAMESPACE is not portable?
>> 
>> That's what I was attempting to point out.
>> I think "for instance" should be written out in this case, or use an 
>> established
>> abbreviation, or dropped entirely:
> 
> I had the same thought 😊
> 
> https://codereview.qt-project.org/c/qt/qtbase/+/271615
> 
> Kai
> ___
> Interest mailing list
> Interest@qt-project.org
> https://lists.qt-project.org/listinfo/interest

-John

___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-27 Thread Kai Köhne


> -Original Message-
> From: Interest  On Behalf Of Jason H
> Sent: Monday, August 26, 2019 10:33 PM
> To: Andy 
> Cc: Qt Project 
> Subject: Re: [Interest] Q_NAMESPACE is not portable?
> 
> That's what I was attempting to point out.
> I think "for instance" should be written out in this case, or use an 
> established
> abbreviation, or dropped entirely:

I had the same thought 😊

https://codereview.qt-project.org/c/qt/qtbase/+/271615

Kai
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-26 Thread Jason H

That's what I was attempting to point out. 

I think "for instance" should be written out in this case, or use an established abbreviation, or dropped entirely:

 


"This is useful if the object needs to be exported from a dynamic library."

"This is useful for intance, if the object needs to be exported from a dynamic library." (comma placement?)

"This is useful, e.g. if the object needs to be exported from a dynamic library." (comma placement?)

 

But I have never seen f.i. used anywhere in documentation.  It took me several seconds to figure out what it was...

 

 

Sent: Monday, August 26, 2019 at 12:14 PM
From: "Andy" 
To: "Giuseppe D'Angelo" 
Cc: "Jason H" , "Qt Project" 
Subject: Re: [Interest] Q_NAMESPACE is not portable?




Not trying to start a "thing", but I am curious where "f.i." comes from. Is this a new thing?

 

I've honestly never seen it before.

 









---
Andy Maloney  //  https://asmaloney.com

twitter ~ @asmaloney










 


On Mon, Aug 26, 2019 at 12:07 PM Giuseppe D'Angelo via Interest <interest@qt-project.org> wrote:

On 26/08/2019 18:04, Jason H wrote:
> "This is useful f.i. if the object needs to be exported from a dynamic library."
> what's "f.i."? "For instance"? Isn't that "e.g." (but definitely not i.e.)

"For instance" / "for example" are precisly the English translations of
exempli grati-a...

Cheers,
--
Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com
KDAB - The Qt, C++ and OpenGL Experts

___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest





___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-26 Thread Matthew Woehlke
On 26/08/2019 11.56, Giuseppe D'Angelo wrote:
> On 26/08/2019 17:29, Matthew Woehlke wrote:
>> BTW, what happened to the doc? Macros aren't class members...
> 
> I'm thinking it's still https://bugreports.qt.io/browse/QTBUG-76822

Could be.

>> (Relatedly, any word on lifting the implied  dependency on
>> several of these?)
> 
> I agree in principle at moving these macros elsewhere, didn't *you* push
> a patch that got stuck just because of documentation issues? :-)

Yes (https://codereview.qt-project.org/c/qt/qtbase/+/265168). I would
like to see it un-stuck :-).

-- 
Matthew
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-26 Thread Andy
Not trying to start a "thing", but I am curious where "f.i." comes from. Is
this a new thing?

I've honestly never seen it before.

---
Andy Maloney  //  https://asmaloney.com
twitter ~ @asmaloney 



On Mon, Aug 26, 2019 at 12:07 PM Giuseppe D'Angelo via Interest <
interest@qt-project.org> wrote:

> On 26/08/2019 18:04, Jason H wrote:
> > "This is useful f.i. if the object needs to be exported from a dynamic
> library."
> > what's "f.i."? "For instance"? Isn't that "e.g." (but definitely not
> i.e.)
>
> "For instance" / "for example" are precisly the English translations of
> exempli grati-a...
>
> Cheers,
> --
> Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer
> KDAB (France) S.A.S., a KDAB Group company
> Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com
> KDAB - The Qt, C++ and OpenGL Experts
>
> ___
> Interest mailing list
> Interest@qt-project.org
> https://lists.qt-project.org/listinfo/interest
>
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-26 Thread Giuseppe D'Angelo via Interest

On 26/08/2019 18:04, Jason H wrote:

"This is useful f.i. if the object needs to be exported from a dynamic library."
what's "f.i."? "For instance"? Isn't that "e.g." (but definitely not i.e.)


"For instance" / "for example" are precisly the English translations of 
exempli grati-a...


Cheers,
--
Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com
KDAB - The Qt, C++ and OpenGL Experts



smime.p7s
Description: S/MIME Cryptographic Signature
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-26 Thread Jason H


> Sent: Friday, August 23, 2019 at 7:02 PM
> From: "Giuseppe D'Angelo via Interest" 
> To: interest@qt-project.org
> Subject: Re: [Interest] Q_NAMESPACE is not portable?
>
> On 24/08/2019 00:10, Matthew Woehlke wrote:
> > Am I doing something wrong, or is it impossible to use Q_NAMESPACE
> > correctly without platform-specific PP conditionals?
>
> I've fixed this in 5.14, see
>
> > https://doc-snapshots.qt.io/qt5-dev/qobject.html#Q_NAMESPACE_EXPORT

"This is useful f.i. if the object needs to be exported from a dynamic library."
what's "f.i."? "For instance"? Isn't that "e.g." (but definitely not i.e.)


___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-26 Thread Giuseppe D'Angelo via Interest

On 26/08/2019 17:29, Matthew Woehlke wrote:

Okay... that's both good and bad news... good that it's fixed, bad that
it isn't available in a released version.

BTW, what happened to the doc? Macros aren't class members...


I'm thinking it's still


https://bugreports.qt.io/browse/QTBUG-76822



(Relatedly, any word on lifting the implied  dependency on
several of these?)


I agree in principle at moving these macros elsewhere, didn't *you* push 
a patch that got stuck just because of documentation issues? :-)


Thanks,
--
Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com
KDAB - The Qt, C++ and OpenGL Experts



smime.p7s
Description: S/MIME Cryptographic Signature
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-26 Thread Allan Sandfeld Jensen
On Monday, 26 August 2019 17:29:31 CEST Matthew Woehlke wrote:
> On 23/08/2019 19.02, Giuseppe D'Angelo via Interest wrote:
> > On 24/08/2019 00:10, Matthew Woehlke wrote:
> >> Am I doing something wrong, or is it impossible to use Q_NAMESPACE
> >> correctly without platform-specific PP conditionals?
> > 
> > I've fixed this in 5.14, see
> > 
> >> https://doc-snapshots.qt.io/qt5-dev/qobject.html#Q_NAMESPACE_EXPORT
> 
> BTW, what happened to the doc? Macros aren't class members...

LOL. 
It is broken in 5.13 too
https://doc-snapshots.qt.io/qt5-5.13/qobject.html#Q_NAMESPACE

looks right 5.12
https://doc-snapshots.qt.io/qt5-5.12/qobject.html#Q_NAMESPACE


___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-26 Thread Matthew Woehlke
On 23/08/2019 19.02, Giuseppe D'Angelo via Interest wrote:
> On 24/08/2019 00:10, Matthew Woehlke wrote:
>> Am I doing something wrong, or is it impossible to use Q_NAMESPACE
>> correctly without platform-specific PP conditionals?
> 
> I've fixed this in 5.14, see
> 
>> https://doc-snapshots.qt.io/qt5-dev/qobject.html#Q_NAMESPACE_EXPORT

Okay... that's both good and bad news... good that it's fixed, bad that
it isn't available in a released version.

BTW, what happened to the doc? Macros aren't class members...

(Relatedly, any word on lifting the implied  dependency on
several of these?)

-- 
Matthew
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Q_NAMESPACE is not portable?

2019-08-23 Thread Giuseppe D'Angelo via Interest

On 24/08/2019 00:10, Matthew Woehlke wrote:

Am I doing something wrong, or is it impossible to use Q_NAMESPACE
correctly without platform-specific PP conditionals?


I've fixed this in 5.14, see


https://doc-snapshots.qt.io/qt5-dev/qobject.html#Q_NAMESPACE_EXPORT


Cheers,

--
Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com
KDAB - The Qt, C++ and OpenGL Experts



smime.p7s
Description: S/MIME Cryptographic Signature
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


[Interest] Q_NAMESPACE is not portable?

2019-08-23 Thread Matthew Woehlke
Am I missing something, or is it impossible to portably use Q_NAMESPACE?

If I just use Q_NAMESPACE on its own, e.g.:

  namespace foo {
  Q_NAMESPACE
  }

...then I get unresolved externals on Linux. If I attempt the obvious fix:

  namespace foo {
  Q_NAMESPACE
  extern FOO_EXPORT const QMetaObject staticMetaObject; // Ugh
  }

...then I get 'redefinition, different linkage' errors on Windows.

Am I doing something wrong, or is it impossible to use Q_NAMESPACE
correctly without platform-specific PP conditionals?

-- 
Matthew
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest