[PHP-DEV] Re: PHP 4.3.9RC3 Released

2004-09-14 Thread Lester Caine
Ilia Alshanetsky wrote: The final release candidate of PHP 4.3.9 is now available for testing. Hf no new problems are uncovered, this release will be re-released as 4.3.9 at the end of the week. If you have any patches (4.X tree) for non-critical problems please hold them off either until we dec

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Andi Gutmans
Yeah I'll try and see what can be done. It might be a bit tricky because TSRM doesn't "know" PHP but I think it can be solved. Andi At 04:33 PM 9/14/2004 -0700, Rasmus Lerdorf wrote: On Tue, 14 Sep 2004, Andi Gutmans wrote: > a) I will try and send internals@ an updated version of the realpath()

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Rasmus Lerdorf
On Tue, 14 Sep 2004, Andi Gutmans wrote: > a) I will try and send internals@ an updated version of the realpath() > cache in the next few days. This should give a lot of bang for the buck > because realpath() is probably the suckiest system call in the startup. Make sure you update it to use the n

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Andi Gutmans
At 11:30 AM 9/14/2004 -0700, Rasmus Lerdorf wrote: On Tue, 14 Sep 2004, Andi Gutmans wrote: > Can you describe the other non-essential syscalls? I want to be sure we > really can't cover those (probably some of them we can't). > As far as the realpath patch goes (which is probably the biggest probl

[PHP-DEV] PHP 4.3.9RC3 Released

2004-09-14 Thread Ilia Alshanetsky
The final release candidate of PHP 4.3.9 is now available for testing. Hf no new problems are uncovered, this release will be re-released as 4.3.9 at the end of the week. If you have any patches (4.X tree) for non-critical problems please hold them off either until we decide that another RC is n

[PHP-DEV] Sefault in clone

2004-09-14 Thread Timm Friebe
name = 'Copy'; ?> $ php5 test.php Warning: __clone method called on non-object in /usr/home/thekid/test.php on line 6 [Wed Sep 15 00:07:35 2004] Script: 'test.php' --- /usr/home/thekid/devel/php/php/Zend/zend_variables.c(179) : Block 0x083B67F0 status: /usr/ho

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Rasmus Lerdorf
On Tue, 14 Sep 2004, Andi Gutmans wrote: > Can you describe the other non-essential syscalls? I want to be sure we > really can't cover those (probably some of them we can't). > As far as the realpath patch goes (which is probably the biggest problem), > I think that if we have the realpath cache i

[PHP-DEV] Segfault in str_replace()

2004-09-14 Thread Timm Friebe
Hello, I'm experiencing very weird segfaults (and cannot reproduce them with a small script) in PHP4 (to be exact: PHP4.3.8) - a backtrace is attached. Now the weird thing is: #0 0x080e3ff3 in php_char_to_str (str=0x0, len=1515870810, from=34 '"', to=0x85d5f54 "\"\"", to_len=2, result=0x8601

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Andi Gutmans
At 10:52 AM 9/14/2004 -0700, Rasmus Lerdorf wrote: The patch doesn't just address realpath though. We have a number of other redundant/non-essential syscalls in the streams code, for example. And the realpath cache is still heavier than not worrying about the full path at all. Can you describe th

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Rasmus Lerdorf
The patch doesn't just address realpath though. We have a number of other redundant/non-essential syscalls in the streams code, for example. And the realpath cache is still heavier than not worrying about the full path at all. I do agree that however people get this patch, they need to understan

Re: [PHP-DEV] PHP's error handler: xmlrpc_errors, entity encoding, and handler chaining

2004-09-14 Thread Andi Gutmans
Personally I prefer today's approach vs. a more complex chaining solution. It only requires an additional if() in your error handler to handle different error codes differently. At 10:07 PM 9/13/2004 -0700, Sara Golemon wrote: > Having it trickle back through the stack would make sense to me too.

Re: [PHP-DEV] [patch] Zend/zend_objects_API.c - bug #29980 (segfault while executing __destruct())

2004-09-14 Thread Andi Gutmans
Yes I agree. At 02:02 PM 9/13/2004 +0300, Stanislav Malyshev wrote: AD>>ATM ZE2 calls destructor at the end of the request and no matter is AD>>there were a fatal error (which should probably stop executing the AD>>script). In some cases it leads to nasty segfaults (me and report's AD>>author can r

Re: [PHP-DEV] [patch] Zend/zend_objects_API.c - bug #29980 (segfault while executing __destruct())

2004-09-14 Thread Andi Gutmans
At 02:02 PM 9/13/2004 +0300, Stanislav Malyshev wrote: AD>>ATM ZE2 calls destructor at the end of the request and no matter is AD>>there were a fatal error (which should probably stop executing the AD>>script). In some cases it leads to nasty segfaults (me and report's AD>>author can reproduce it,

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Zeev Suraski
At 19:29 14/09/2004, Derick Rethans wrote: > And yes, there is no doubt that this patch can critically alter the way > PHP works and has the potential to break all sorts of stuff. Anything > that relies on PHP knowing the full path will break. I had to fix both > xdebug and APC, for example. At

Re: [PHP-DEV] Re: [PATCH] zend_operators DVAL_TO_LVAL fix

2004-09-14 Thread Andi Gutmans
Also <= LONG_MIN needed? I guess yes? At 03:22 PM 9/11/2004 +0200, Ard Biesheuvel wrote: Joe Orton wrote: The DVAL_TO_LVAL macro is quite weird, I'm not sure exactly what it's supposed to be doing but it probably isn't doing it. If the integral part of d is outside the range of a long, the conversi

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Andi Gutmans
Hey Derick and all, As I mentioned in the past, I think solving it in a completely compatible manner is the best way to go. I sent out the realpath() cache patch which addresses the most problematic file system issues (and if there are any other things we could probably address too). I think the

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Andrey Hristov
Derick Rethans wrote: On Tue, 14 Sep 2004, Rasmus Lerdorf wrote: That should have been a #ifndef SKIP_PATH_CHECKS there. And it is there to get rid of a non-critical ftell(). Attached is the patch with this corrected, and corrected white space. And yes, there is no doubt that this patch can cri

RE: [PHP-DEV] [PATCH] round 3

2004-09-14 Thread Steph
Yesterday that was a 'wrong fix' too :) Please can you at least commit that so that the win32 build works as advertised at least? You can worry about the mystery of other systems breaking later. > -Original Message- > From: Derick Rethans [mailto:[EMAIL PROTECTED] > Sent: 14 September 20

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Derick Rethans
On Tue, 14 Sep 2004, Rasmus Lerdorf wrote: > That should have been a #ifndef SKIP_PATH_CHECKS there. And it is there > to get rid of a non-critical ftell(). Attached is the patch with this corrected, and corrected white space. > And yes, there is no doubt that this patch can critically alter th

Re: [PHP-DEV] [PATCH] round 3

2004-09-14 Thread Derick Rethans
On Tue, 14 Sep 2004, Steph wrote: > Moved #if a few paces to the left on Wez's advice. Fussy old compilers ;) > > Still does the same job (fixes win32 build and all builds where there is no > strcoll), only this time without breaking otherwise happy builds. It's still wrong. The only change need

[PHP-DEV] [PATCH] round 3

2004-09-14 Thread Steph
Moved #if a few paces to the left on Wez's advice. Fussy old compilers ;) Still does the same job (fixes win32 build and all builds where there is no strcoll), only this time without breaking otherwise happy builds. - Steph Index: Zend/zend_config.w32.h ==

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Rasmus Lerdorf
On Tue, 14 Sep 2004, Derick Rethans wrote: > On Tue, 14 Sep 2004, Derick Rethans wrote: > > > On Tue, 14 Sep 2004, Wez Furlong wrote: > > > > > There's an #if 0 in there that probably shouldn't be > > > > Yeah, the whole stuff can be removed, as it's added in later again :) > > I'll create a new p

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Zeev Suraski
I don't think we should have this patch in the distribution. It shouldn't be that accessible as it has the potential to break behavior of both apps and plugins. I think it belongs in a patches repository such as http://www.zend.com/zend/week/pat/ (doesn't have to be that one in particular, bu

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Wez Furlong
To eliminate an fstat() most likely; it can stay, but it should probably changed to #ifndef SKIP_PATH_CHECKS instead. --Wez. On Tue, 14 Sep 2004 14:50:09 +0200 (CEST), Derick Rethans <[EMAIL PROTECTED]> wrote: > On Tue, 14 Sep 2004, Derick Rethans wrote: > > > On Tue, 14 Sep 2004, Wez Furlong w

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Derick Rethans
On Tue, 14 Sep 2004, Derick Rethans wrote: > On Tue, 14 Sep 2004, Wez Furlong wrote: > > > There's an #if 0 in there that probably shouldn't be > > Yeah, the whole stuff can be removed, as it's added in later again :) > I'll create a new patch for it here. hmm, no, this was a different patch. No

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Derick Rethans
On Tue, 14 Sep 2004, Wez Furlong wrote: > There's an #if 0 in there that probably shouldn't be Yeah, the whole stuff can be removed, as it's added in later again :) I'll create a new patch for it here. Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org -- PHP

Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Wez Furlong
There's an #if 0 in there that probably shouldn't be --Wez. On Tue, 14 Sep 2004 14:10:52 +0200 (CEST), Derick Rethans <[EMAIL PROTECTED]> wrote: > Hei, > > This is Rasmus' patch including a configure option > "--disable-path-normalization" to enable this patch. By default this > option is of co

[PHP-DEV] Patch: Rasmus statcallpatch with configure option

2004-09-14 Thread Derick Rethans
Hei, This is Rasmus' patch including a configure option "--disable-path-normalization" to enable this patch. By default this option is of course turned off. I am planning to commit this patch after 4.3.9 is released too, in case there are no good objections. Derick -- Derick Rethans http://der

[PHP-DEV] Patch: Foreach Performance for 4.3

2004-09-14 Thread Derick Rethans
Hei, I backported Marcus' performance-improvement-when-not-using-a-key-in-foreach patch to 4.3 and attached it. I am planning to commit this after 4.3.9 is released. If there are any comments, please let me know. Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.o

Re: [PHP-DEV] Re: Bug #25570 Some requests cause Apache to crash/restart

2004-09-14 Thread Lester Caine
Jacques Marneweck wrote: It would seem that this bug has appeared again, in 5.0.1 on Apache 2.0.50 I've had a report about it on the firebird-php list, and on checking it would seem that it can be reproduced. Could someone have a look and see if we are right please. Come on people - have two sites

Re: [PHP-DEV] Re: Bug #25570 Some requests cause Apache to crash/restart

2004-09-14 Thread Jacques Marneweck
On Tue, 14 Sep 2004 07:49:04 +0100, Lester Caine <[EMAIL PROTECTED]> wrote: > Lester Caine wrote: > > > It would seem that this bug has appeared again, in 5.0.1 on Apache 2.0.50 > > I've had a report about it on the firebird-php list, and on checking it > > would seem that it can be reproduced. >

[PHP-DEV] curl multi backport to PHP4

2004-09-14 Thread Rasmus Lerdorf
I needed the curl multi stuff for something, so I trivially backported it to PHP4's ext/curl. There is nothing really PHP5-specific in it and it is basically just a standalone extension keeping track with the 3rd-party library it is wrapping. Ilia, as RM of the 4.3 tree, do you see any reason not