Re: [PHP-DEV] [RFC] [VOTE] Implement missing SQLite feature "openBlob" in PDO

2017-10-30 Thread Rowan Collins
On 30/10/2017 03:14, Dan Ackroyd wrote: The vote for this should have ended..3 days ago. At which point I believe the vote was actually passing. Hm, that's awkward! For the record: - voting was announced on the evening of the 9th "for two weeks" which would imply the evening of the

Re: [PHP-DEV] Consistent indentation for test files

2017-10-30 Thread Sara Golemon
On Sat, Oct 28, 2017 at 7:59 AM, Nikita Popov wrote: > Right now we do not have a consistent standard for the indentation of > PHPT files. > > I would like to propose that we establish a common standard > Not for nothin', but PSR-2 exists. If we adopt *any* standard, I

[PHP-DEV] [RFC][VOTE] PCRE2 migration

2017-10-30 Thread Anatol Belski
Hi, The vote on https://wiki.php.net/rfc/pcre2-migration is open. The vote opens today and closes on November 13th. Regards Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Consistent indentation for test files

2017-10-30 Thread Derick Rethans
On Sun, 29 Oct 2017, Jakub Zelenka wrote: > On Sat, Oct 28, 2017 at 12:59 PM, Nikita Popov wrote: > > Here are the current statistics for code in .phpt files: > > > > total: 15515 > > prefer tabs: 4273 (27.5%) > > prefer spaces: 6307 (40.7%) > > draw: 77 (0.5%) > > no

Re: [PHP-DEV] Apply substr() optimization to array_slice()

2017-10-30 Thread Nikita Popov
On Mon, Oct 30, 2017 at 4:09 PM, Sara Golemon wrote: > On Mon, Oct 30, 2017 at 6:51 AM, Dmitry Stogov wrote: > > The optimization also broke Zend/tests/bug72598.phpt and > Zend/tests/bug72598_2.phpt > > > Damn. I had a feeling references would rear their ugly

Re: [PHP-DEV] Apply substr() optimization to array_slice()

2017-10-30 Thread Sara Golemon
On Mon, Oct 30, 2017 at 6:51 AM, Dmitry Stogov wrote: > The optimization also broke Zend/tests/bug72598.phpt and > Zend/tests/bug72598_2.phpt > Damn. I had a feeling references would rear their ugly head here. Fuggit, reverted. We can take another swing at it later, but it's

Re: [PHP-DEV] Apply substr() optimization to array_slice()

2017-10-30 Thread Dmitry Stogov
The optimization also broke Zend/tests/bug72598.phpt and Zend/tests/bug72598_2.phpt From: p...@golemon.com on behalf of Sara Golemon Sent: Friday, October 27, 2017 7:34:15 PM To: Nikita Popov Cc: Benjamin Coutu; PHP

[PHP-DEV] RE: PCRE2 support

2017-10-30 Thread Anatol Belski
Hi, > -Original Message- > From: Anatol Belski [mailto:a...@php.net] > Sent: Saturday, October 14, 2017 11:59 PM > To: internals@lists.php.net > Subject: PCRE2 support > > Hi, > > I experimented with PCRE2 and created > https://github.com/php/php-src/pull/2857 . So far the

Re: [PHP-DEV] Re: Consistent indentation for test files

2017-10-30 Thread Kris Craig
On Sat, Oct 28, 2017 at 5:42 AM, Christoph M. Becker wrote: > On 28.10.2017 at 13:59, Nikita Popov wrote: > > > Right now we do not have a consistent standard for the indentation of > PHPT > > files. Some people create space-indented files, others create > tab-indented > >

Re: [PHP-DEV] Weird PHP 7.2 bug

2017-10-30 Thread Xinchen Hui
Hey: On Mon, Oct 30, 2017 at 3:55 PM, Dmitry Stogov wrote: > Fixed. thanks. for catching. > Great thanks > The real problem - incorrect handling of "wrong index type. > > In this situation PHP should keep input array unchanged. > Inferring types "by usage" makes sense (for

Re: [PHP-DEV] Weird PHP 7.2 bug

2017-10-30 Thread Dmitry Stogov
Fixed. thanks. for catching. The real problem - incorrect handling of "wrong index type. In this situation PHP should keep input array unchanged. Inferring types "by usage" makes sense (for array) e.g. $a[$n]++ should change the type of array. Thanks. Dmitry.

Re: [PHP-DEV] Weird PHP 7.2 bug

2017-10-30 Thread Xinchen Hui
Hey: On Mon, Oct 30, 2017 at 2:48 AM, Derick Rethans wrote: > Hi, > > running: > https://raw.githubusercontent.com/xdebug/xdebug/master/tests/bug01263.inc > > with: > $ php -n -dzend_extension=opcache.so -dopcache.enable_cli=1 > tests/bug01263.inc > > Produces the following