Re: [PHP-DEV] A Standard PHAR library included with PHP?

2020-05-07 Thread Stanislav Malyshev
Hi! > One of the primary reasons for many of us — or at least me — to want > more things in core is not listed above, and that reason is: > > - Standardization Core and standardization are completely different things. There are a lot of things in PHP that are being standardized out of core,

[PHP-DEV] A Standard PHAR library included with PHP?

2020-05-07 Thread Mike Schinkel
> On May 7, 2020, at 10:33 AM, Dan Ackroyd wrote: > > On Thu, 7 May 2020 at 10:13, Rowan Tommins wrote: >> >> Unless we're actively trying to shrink the functionality of PHP's core, > > I think we should. > > There are things that were added to core rather than done in userland because: > >

Re: [PHP-DEV] [RFC] Parameter Blocks (vs. Constructor Property Promotion and Named Parameters)

2020-05-07 Thread Mike Schinkel
> On May 7, 2020, at 4:47 AM, Rowan Tommins wrote: > the current parser seems to handle it just fine. Interesting. You are correct on this point. I was going by memory that we had lots of problems with nested arrays, I should have tested this one assertion before posting. > I think you're

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Nicolas Grekas
> > https://wiki.php.net/rfc/deprecated_attribute Thanks for the RFC. Why didn't you mention support for deprecating classes/interfaces/traits themselves? If there is a reason, it should be in the RFC at least to me. > > It feels complicated to me, because there are so many entry points to a >

Re: [PHP-DEV] Deprecating uniqid()

2020-05-07 Thread Dik Takken
On 07-05-2020 17:24, Larry Garfield wrote: > Between preloading, PHP 7's improvements, FFI funkiness, and the upcoming > JIT, there's been on and off discussion about moving much of the standard > library from C to "PHP code that is bundled and preloaded automatically." A > real "standard

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
On Thu, May 7, 2020 at 12:43 PM Nicolas Grekas wrote: > Hi Benjamin, > > https://wiki.php.net/rfc/deprecated_attribute > > > Thanks for the RFC. > Why didn't you mention support for deprecating classes/interfaces/traits > themselves? > If there is a reason, it should be in the RFC at least to

Re: [PHP-DEV] Deprecating uniqid()

2020-05-07 Thread Arvids Godjuks
Hello Ben, On Thu, 7 May 2020 at 17:29, Ben Ramsey wrote: > > On May 7, 2020, at 09:33, Dan Ackroyd wrote: > > *snip* > > I’m done waxing philosophical, so what I can say about `uniqid()`? > > This is one of those functions I think (without doing the research) is > used a lot in CLI scripts

Re: [PHP-DEV] Deprecating uniqid()

2020-05-07 Thread Ben Ramsey
> On May 7, 2020, at 09:33, Dan Ackroyd wrote: > > On Thu, 7 May 2020 at 10:13, Rowan Tommins wrote: >> >> Unless we're actively trying to shrink the functionality of PHP's core, > > I think we should. > > There are things that were added to core rather than done in userland because: > > *

Re: [PHP-DEV] Deprecating uniqid()

2020-05-07 Thread Larry Garfield
On Thu, May 7, 2020, at 9:33 AM, Dan Ackroyd wrote: > On Thu, 7 May 2020 at 10:13, Rowan Tommins wrote: > > > > Unless we're actively trying to shrink the functionality of PHP's core, > > I think we should. > > There are things that were added to core rather than done in userland because: > >

Re: [PHP-DEV] Deprecating uniqid()

2020-05-07 Thread Dan Ackroyd
On Thu, 7 May 2020 at 10:13, Rowan Tommins wrote: > > Unless we're actively trying to shrink the functionality of PHP's core, I think we should. There are things that were added to core rather than done in userland because: * distributing libraries in userland used to be a lot harder than it

Re: [PHP-DEV] Re: [RFC] [VOTE] Locale-independent float to string cast

2020-05-07 Thread Benjamin Morel
Thank you Mate, this will be a very welcome change, that will naturally fix bugs such as this one , and probably others going unnoticed. Benjamin On Thu, 7 May 2020 at 14:02, Máté Kocsis wrote: > Hi Internals, > > I'm pleased to announce that the

[PHP-DEV] Re: [RFC] [VOTE] Locale-independent float to string cast

2020-05-07 Thread Máté Kocsis
Hi Internals, I'm pleased to announce that the Locale-independent float to string cast RFC has been accepted with 41 votes in favour, and 1 vote against. According to the result of the secondary vote, the debug_locale_sensitive_float_casts ini setting won't be introduced. Cheers: Máté Máté

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Nicolas Grekas
Hi Benjamin, https://wiki.php.net/rfc/deprecated_attribute Thanks for the RFC. Why didn't you mention support for deprecating classes/interfaces/traits themselves? If there is a reason, it should be in the RFC at least to me. - all other languages with Attributes/Annotations support have it as

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
On Thu, May 7, 2020 at 10:54 AM Marco Pivetta wrote: > Hey Benjamin, > > On Thu, May 7, 2020, 10:42 Benjamin Eberlei wrote: > >> >> This attribute is "reflected" by the engine during compilation, userland >> doesn't have to reflect it again itself. on a code level the engine >> "patches" each

Re: [PHP-DEV] Deprecating uniqid()

2020-05-07 Thread Rowan Tommins
On Wed, 6 May 2020 at 13:40, Dan Ackroyd wrote: > This is a problem that would be better solved in userland rather than > trying to design and evolve inside core PHP. > I think that's a major philosophical question: should the core of a language provide only those most basic building blocks

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Côme Chilliet
This is a really good proposal. I did not participate in the attribute discussion/vote as I do not really understand what attributes are and what they are good for. Having this kind of examples in core will help a lot, and is useful too (I do have functions with only a trigger_error of

[PHP-DEV] [RFC] [VOTE] Mixed type v2

2020-05-07 Thread Máté Kocsis
Hi Internals, We have just opened the vote on the Mixed type v2 RFC. The voting will be open for two weeks, until 2020-05-21 12:00 UTC. Link: https://wiki.php.net/rfc/mixed_type_v2 Cheers, Máté

[PHP-DEV] max_input_vars trigger detection

2020-05-07 Thread Côme Chilliet
Hello, We’ve hit the max_input_vars limit some time ago, and at first I tried to detect this case, but I failed as there is no handy way to detect this situation. In our case the application was complaining about CSRF token missing since the token was truncated, and you had to go see the logs

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Marco Pivetta
Hey Benjamin, On Thu, May 7, 2020, 10:42 Benjamin Eberlei wrote: > > This attribute is "reflected" by the engine during compilation, userland > doesn't have to reflect it again itself. on a code level the engine > "patches" each function automatically, this would do the following at > compile

Re: [PHP-DEV] [RFC] Parameter Blocks (vs. Constructor Property Promotion and Named Parameters)

2020-05-07 Thread Rowan Tommins
On Wed, 6 May 2020 at 22:48, Mike Schinkel wrote: > Now, consider the following two examples. On which line would PHP report > the error? > > function foo() ( > > public $foo, > > public $ bar > > ) {} > > > vs. > > function foo { > public $foo; > public $ bar; > } {} > > This feels like an

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
On Thu, May 7, 2020 at 10:27 AM Davey Shafik wrote: > > > On Thu, May 7, 2020 at 01:18 Benjamin Eberlei wrote: > >> >> >> On Thu, May 7, 2020 at 10:10 AM Davey Shafik wrote: >> >>> >>> >>> On Thu, May 7, 2020 at 00:22 Benjamin Eberlei >>> wrote: >>> Hi everyone, The attributes

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Davey Shafik
On Thu, May 7, 2020 at 01:18 Benjamin Eberlei wrote: > > > On Thu, May 7, 2020 at 10:10 AM Davey Shafik wrote: > >> >> >> On Thu, May 7, 2020 at 00:22 Benjamin Eberlei >> wrote: >> >>> Hi everyone, >>> >>> The attributes RFC specifically looked into the use of attributes at the >>>

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
On Thu, May 7, 2020 at 10:10 AM Davey Shafik wrote: > > > On Thu, May 7, 2020 at 00:22 Benjamin Eberlei wrote: > >> Hi everyone, >> >> The attributes RFC specifically looked into the use of attributes at the >> engine/compiler level. >> >> To have a showcase of this with the 8.0 release I want

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Davey Shafik
On Thu, May 7, 2020 at 00:22 Benjamin Eberlei wrote: > Hi everyone, > > The attributes RFC specifically looked into the use of attributes at the > engine/compiler level. > > To have a showcase of this with the 8.0 release I want to propose this RFC > for a <> attribute: > >

[PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
Hi everyone, The attributes RFC specifically looked into the use of attributes at the engine/compiler level. To have a showcase of this with the 8.0 release I want to propose this RFC for a <> attribute: https://wiki.php.net/rfc/deprecated_attribute <> is the most obvious engine attribute to