Re: [PHP-DEV] PHP 8.0 branch cut - The Return

2020-09-28 Thread Dmitry Stogov
Hi, This is fine to me. I stopped active JIT development, and going to do only fixes and may be minor improvements. Thanks. Dmitry. On Mon, Sep 28, 2020 at 11:56 AM Gabriel Caruso wrote: > Following Sara's email a couple of weeks ago, I come this week with a > similar one: > > Next Tuesday,

Re: [PHP-DEV] PHP 8.0 branch cut - The Return

2020-09-28 Thread Nikita Popov
On Mon, Sep 28, 2020 at 10:56 AM Gabriel Caruso wrote: > Following Sara's email a couple of weeks ago, I come this week with a > similar one: > > Next Tuesday, Sep 29th, has been marked on our calendars as the branch date > for PHP-8.0 which would open master up for 8.1 targeted work. > > This

Re: [PHP-DEV] Re: Attributes and constructor property promotion

2020-09-28 Thread Benjamin Eberlei
On Mon, Sep 28, 2020 at 4:35 PM Benjamin Morel wrote: > On Mon, 28 Sep 2020 at 15:17, Nicolas Grekas > wrote: > >> I assume the 80% case is properties, because attributes did not have >>> docblock annotations yet, that means this use-case isn't even possible at >>> the moment. Yet annotations

Re: [PHP-DEV] Re: Attributes and constructor property promotion

2020-09-28 Thread Benjamin Morel
On Mon, 28 Sep 2020 at 15:17, Nicolas Grekas wrote: > I assume the 80% case is properties, because attributes did not have >> docblock annotations yet, that means this use-case isn't even possible at >> the moment. Yet annotations on properties are widespread (Doctrine ORM, >> symfony validator,

Re: [PHP-DEV] Re: Attributes and constructor property promotion

2020-09-28 Thread Nicolas Grekas
> > >> imho, we should pick the 80% use-case and advise to desugar the code if > >> other behavior is desired. For me the 80% case is that the attribute > only > >> applies to the property, not to the parameter. > > > > > > +1 for the desugaring advice in this case, however as a matter of > >

Re: [PHP-DEV] Re: Attributes and constructor property promotion

2020-09-28 Thread Benjamin Eberlei
On Mon, Sep 28, 2020 at 2:25 PM Benjamin Morel wrote: > On Mon, 28 Sep 2020 at 13:56, Benjamin Eberlei > wrote: > > >> imho, we should pick the 80% use-case and advise to desugar the code if >> other behavior is desired. For me the 80% case is that the attribute only >> applies to the

Re: [PHP-DEV] List of attributes

2020-09-28 Thread Nicolas Grekas
> Hi Benjamin, hi everyone >> >> I'm wondering if the syntax that allows for several attributes is really >> future-proof when considering nested attributes: >> >> >> *1.* >> #[foo] >> #[bar] >> >> VS >> >> >> *2.* >> #[foo, bar] >> >> Add nested attributes to the mix, here are two possible ways:

Re: [PHP-DEV] Re: Attributes and constructor property promotion

2020-09-28 Thread Benjamin Morel
On Mon, 28 Sep 2020 at 13:56, Benjamin Eberlei wrote: > imho, we should pick the 80% use-case and advise to desugar the code if > other behavior is desired. For me the 80% case is that the attribute only > applies to the property, not to the parameter. +1 for the desugaring advice in this

[PHP-DEV] Re: Attributes and constructor property promotion

2020-09-28 Thread Benjamin Eberlei
On Mon, Sep 28, 2020 at 12:36 PM Nikita Popov wrote: > Hi internals, > > When the constructor property promotion landed, the question of how it > interacts with attributes on promoted properties did not get fully > resolved. See https://wiki.php.net/rfc/constructor_promotion#attributes > for

[PHP-DEV] Attributes and constructor property promotion

2020-09-28 Thread Nikita Popov
Hi internals, When the constructor property promotion landed, the question of how it interacts with attributes on promoted properties did not get fully resolved. See https://wiki.php.net/rfc/constructor_promotion#attributes for what the issue is. The behavior that landed was to apply the

Re: [PHP-DEV] List of attributes

2020-09-28 Thread Nikita Popov
On Sun, Sep 27, 2020 at 10:23 AM Nicolas Grekas wrote: > Hi Benjamin, hi everyone > > I'm wondering if the syntax that allows for several attributes is really > future-proof when considering nested attributes: > > > *1.* > #[foo] > #[bar] > > VS > > > *2.* > #[foo, bar] > > Add nested attributes

[PHP-DEV] PHP 8.0 branch cut - The Return

2020-09-28 Thread Gabriel Caruso
Following Sara's email a couple of weeks ago, I come this week with a similar one: Next Tuesday, Sep 29th, has been marked on our calendars as the branch date for PHP-8.0 which would open master up for 8.1 targeted work. This would mean that bug fixes would need to include PHP-8.0 in their merge