[PHP-DEV] Re: [RFC][Vote] New Curl URL API

2022-07-04 Thread Mark Randall
On 05/07/2022 00:34, Pierrick Charron wrote: All recent discussions show that we are not even close to getting a consensus on how the new CurlUrl OO API should be done. After changing my mind 300 times in the last day, I decided to only propose the procedural implementation that stays consistent

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Peter Cowburn
On Mon, 4 Jul 2022 at 11:11, Jakub Zelenka wrote: > On Mon, Jul 4, 2022 at 8:38 AM Timon de Groot > wrote: > > > Hi internals, > > > > If the rest also thinks the RFC is good to go, I suggest we start a vote > > coming week. > > As this is my first RFC, I'm not so sure how this typically gets

[PHP-DEV] Re: [RFC][Vote] New Curl URL API

2022-07-04 Thread Pierrick Charron
Sorry, I forgot to include the RFC Url : https://wiki.php.net/rfc/curl-url-api Le lun. 4 juill. 2022, à 19 h 34, Pierrick Charron a écrit : > Hi internals, > > I opened voting for the new Curl URL API as part of PHP8.2. > > All recent discussions show that we are not even close to getting a >

[PHP-DEV] [RFC][Vote] New Curl URL API

2022-07-04 Thread Pierrick Charron
Hi internals, I opened voting for the new Curl URL API as part of PHP8.2. All recent discussions show that we are not even close to getting a consensus on how the new CurlUrl OO API should be done. After changing my mind 300 times in the last day, I decided to only propose the procedural

[PHP-DEV] Re: [RFC] [Under Discussion] Constants in traits

2022-07-04 Thread shinji igarashi
Hello! I have updated the RFC for constants in traits to clearly state that Enumerations can use traits having constants. https://wiki.php.net/rfc/constants_in_traits As I said before, if there is no further discussion, I will open the voting tomorrow. Thanks! -- Shinji Igarashi 2022年7月2日(土)

Re: [PHP-DEV] [RFC][Vote] Add json_encode indent parameter

2022-07-04 Thread Tim Düsterhus
Hi On 7/4/22 20:23, Timon de Groot wrote: I went with Jakub's advice and opened the vote, not getting into any other adjustments to the RFC prior to opening it for vote. The vote for the json_encode 'indent' parameter is now open. It will run until 15 July. RFC:

[PHP-DEV] [RFC][Vote] Add json_encode indent parameter

2022-07-04 Thread Timon de Groot
Hi internals, I went with Jakub's advice and opened the vote, not getting into any other adjustments to the RFC prior to opening it for vote. The vote for the json_encode 'indent' parameter is now open. It will run until 15 July. RFC: https://wiki.php.net/rfc/json_encode_indentation. Kind

Re: [PHP-DEV] [RFC][Vote] Auto-capture closures

2022-07-04 Thread Arnaud Le Blanc
Hi, On lundi 4 juillet 2022 11:47:03 CEST Nicolas Grekas wrote: > I'm just wondering if there could be a way to enable the auto-capture > optimization for arrow functions. Having three kinds of rules for capturing > feels too much, especially when there are that subtles for short closures. >

Re: [PHP-DEV] [RFC][Vote] Auto-capture closures

2022-07-04 Thread Arnaud Le Blanc
Hi, On lundi 4 juillet 2022 12:04:59 CEST Marco Pivetta wrote: > I ended up voting NO due to the fact that there is no mention of `$this` > behavior changes ( https://externals.io/message/117888#117889 ) : I also > disagree with NikiC's stance on this being the same construct as before ( >

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Jakub Zelenka
On Mon, Jul 4, 2022 at 8:38 AM Timon de Groot wrote: > Hi internals, > > If the rest also thinks the RFC is good to go, I suggest we start a vote > coming week. > As this is my first RFC, I'm not so sure how this typically gets kicked > off, so I'd like to know what I need to do! > You just

Re: [PHP-DEV] Re: PHP-8.1 branch seems broken

2022-07-04 Thread Derick Rethans
On Mon, 4 Jul 2022, Christoph M. Becker wrote: > On 04.07.2022 at 10:16, Remi Collet wrote: > > > In PHP 8.1: > > > > This branch is 1 commit ahead, 7 commits behind master. > > > > > > This seems terribly wrong, looks like was merged from master > > (NEWS file have 8.2 entries) > > > > > > Can

Re: [PHP-DEV] [RFC][Vote] Auto-capture closures

2022-07-04 Thread Marco Pivetta
I ended up voting NO due to the fact that there is no mention of `$this` behavior changes ( https://externals.io/message/117888#117889 ) : I also disagree with NikiC's stance on this being the same construct as before ( https://externals.io/message/117888#117897 ), so I really wanted to get rid of

Re: [PHP-DEV] [RFC][Vote] Auto-capture closures

2022-07-04 Thread Nicolas Grekas
Hi there, Greetings, Internalians. > > The vote for auto-capture closures is now open. It will run until 15 July. > > https://wiki.php.net/rfc/auto-capture-closure > Thanks for the RFC, I voted yes as I think the optimized auto-capturing logic is sound. Having "function()" still be a

[PHP-DEV] Re: PHP-8.1 branch seems broken

2022-07-04 Thread Christoph M. Becker
On 04.07.2022 at 10:16, Remi Collet wrote: > In PHP 8.1: > > This branch is 1 commit ahead, 7 commits behind master. > > > This seems terribly wrong, looks like was merged from master > (NEWS file have 8.2 entries) > > > Can some GIT expert check and fix that ? Derick is working on fixing the

Re: [PHP-DEV] PHP-8.1 branch seems broken

2022-07-04 Thread Ilija Tovilo
> > In PHP 8.1: > > > > This branch is 1 commit ahead, 7 commits behind master. > > > > > > This seems terribly wrong, looks like was merged from master > > (NEWS file have 8.2 entries) > > > > > > Can some GIT expert check and fix that ? > > I guess that the "1 commit ahead" is just that your

Re: [PHP-DEV] PHP-8.1 branch seems broken

2022-07-04 Thread Sebastian Bergmann
Am 04.07.2022 um 11:04 schrieb Patrick ALLAERT: I guess that the "1 commit ahead" is just that your local branch is a merge with master. No. If you look at https://github.com/php/php-src/tree/PHP-8.1 right now then you will see "This branch is 1 commit ahead, 7 commits behind master." --

Re: [PHP-DEV] PHP-8.1 branch seems broken

2022-07-04 Thread Patrick ALLAERT
Le lun. 4 juil. 2022 à 10:16, Remi Collet a écrit : > Hi, > > In PHP 8.1: > > This branch is 1 commit ahead, 7 commits behind master. > > > This seems terribly wrong, looks like was merged from master > (NEWS file have 8.2 entries) > > > Can some GIT expert check and fix that ? > > > Regards, >

[PHP-DEV] PHP-8.1 branch seems broken

2022-07-04 Thread Remi Collet
Hi, In PHP 8.1: This branch is 1 commit ahead, 7 commits behind master. This seems terribly wrong, looks like was merged from master (NEWS file have 8.2 entries) Can some GIT expert check and fix that ? Regards, Remi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Tim Düsterhus
Hi On 7/4/22 09:38, Timon de Groot wrote: If the rest also thinks the RFC is good to go, I suggest we start a vote coming week. With the minimum voting period being 14 days as per https://wiki.php.net/RFC/voting#voting and the feature freeze for PHP 8.2 being 2022-07-19 23:59:59 UTC as per

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Timon de Groot
As a flag can't really hurt, I'm thinking of going with option B before starting the vote. Also agree with ignoring the indent parameter, as a tab character is less dependent on how much it is repeated. Kind regards, Timon On 04-07-2022 03:22, Kevin Israel wrote: On 7/3/22 18:01, Jakub

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Timon de Groot
Hi internals, If the rest also thinks the RFC is good to go, I suggest we start a vote coming week. As this is my first RFC, I'm not so sure how this typically gets kicked off, so I'd like to know what I need to do! Kind regards, Timon On 04-07-2022 00:01, Jakub Zelenka wrote: Hi, On

Re: [PHP-DEV] [RFC] Make the iterator_*() family accept all iterables

2022-07-04 Thread Tim Düsterhus , WoltLab GmbH
Hi On 6/21/22 16:27, Tim Düsterhus, WoltLab GmbH wrote: https://wiki.php.net/rfc/iterator_xyz_accept_array which I am officially opening up for discussion, just in time for PHP 8.2. Voting will start in 2 weeks on 2022-07-05. Voting will end in 4 weeks on 2022-07-19. Tomorrow is the 5th,