Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2021-02-18 Thread Máté Kocsis
Hi Nikita, Something potentially worth pointing out (and assuming I'm inferring the > correct behavior here): If max_execution_wall_time is exceeded during an > internal function call (which seems quite likely, as that's where there is > the most potential for something to hang) and the function d

Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2021-01-06 Thread Nikita Popov
On Sun, Dec 13, 2020 at 1:25 AM Máté Kocsis wrote: > Hi Everyone, > > Thanks for all the insightful feedbacks so far, I went ahead, and wrote a > proper > RFC: https://wiki.php.net/rfc/max_execution_wall_time > > Regards: > Máté > Something potentially worth pointing out (and assuming I'm inferr

Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2020-12-21 Thread Máté Kocsis
Hi Rowan and Peter, Tangentially, can this be considered a bug in FPM's handling? I appreciate > the speed boost FPM brought over CGI, but the more I work with it the less > I like the way it functions (but that is a separate conversation). > No, I don't think so, since FPM terminates the child p

Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2020-12-21 Thread Peter Bowyer
On Fri, 18 Dec 2020 at 16:43, Máté Kocsis wrote: > Also, please > be aware that the timeout is a clean shutdown > mechanism, so shutdown handlers and the already > mentioned RSHUTDOWN functions are triggered. On the other hand, fpm's > timeout doesn't invoke any of them. > Tangentially, can this

Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2020-12-18 Thread Rowan Tommins
Hi Máté, On 18/12/2020 16:43, Máté Kocsis wrote: I think this is mostly not about application-level, rather than infrastructure-level issues, at least according to our use-cases. I think we may actually just be saying the same thing in different terms: in this message, you refer to a "heav

Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2020-12-18 Thread Máté Kocsis
Hi Rowan, I'd be likely to treat it similarly to > the Linux OOM killer: if it was ever actually invoked, I would be > investigating how to fix my application. > I think this is mostly not about application-level, rather than infrastructure-level issues, at least according to our use-cases. For e

Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2020-12-16 Thread Rowan Tommins
Hi Máté, On 15/12/2020 23:12, Máté Kocsis wrote: I've just collected a few examples when my proposal would be useful: https://gist.github.com/kocsismate/dbcc4ba81b27cfb2e25b949723bb7c79 [...] Do the above examples and this reasoning make sense to you? Also, I'll improve the wording I used when

Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2020-12-15 Thread Máté Kocsis
Hi Rowan and Benjamin, we talked about this before and I think it's a good addition. Two > suggestions to improve the RFC: > Thanks for the ideas, I'll incorporate more details about the interaction of these settings. And I've just collected a few examples when my proposal would be useful: https:

Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2020-12-14 Thread Benjamin Eberlei
Hi Máté we talked about this before and I think it's a good addition. Two suggestions to improve the RFC: The RFC could include more details on how the behavior works exactly in combination with long running I/O. Lets say the default socket timeout being 60 seconds, andt the max execution wall ti

Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2020-12-13 Thread Rowan Tommins
Hi Máté, On 13 December 2020 00:25:10 GMT+00:00, "Máté Kocsis" wrote: >RFC: https://wiki.php.net/rfc/max_execution_wall_time I wonder if you could give some more detailed examples of what you would use this for. You write: > [The current functionality] can have serious consequences for distr

[PHP-DEV] [RFC] [Discussion] Measuring maximum execution time based on wall-time

2020-12-12 Thread Máté Kocsis
Hi Everyone, Thanks for all the insightful feedbacks so far, I went ahead, and wrote a proper RFC: https://wiki.php.net/rfc/max_execution_wall_time Regards: Máté