Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-15 Thread Nikita Popov
On Mon, Jun 8, 2020 at 10:13 AM Benjamin Eberlei wrote: > Hello internals, > > I have opened voting for four different amendments to the Attributes RFC > > https://wiki.php.net/rfc/attribute_amendments > > The voting period ends at 2020-06-22 8:00 UTC. > > greetings > Benjamin > On the

Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-09 Thread Lester Caine
On 08/06/2020 19:37, Larry Garfield wrote: That... is not related? This is*not* a documentation tool. At all. It's more akin to moving Doctrine Annotations into core (junior version thereof). It doesn't render docblocks redundant, it renders "using docblocks for custom metaprogramming"

Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-08 Thread Benjamin Eberlei
On Mon, Jun 8, 2020 at 6:48 PM Lester Caine wrote: > On 08/06/2020 16:30, Benjamin Eberlei wrote: > > > > > > On Mon, Jun 8, 2020 at 11:11 AM Lester Caine > > wrote: > > > > On 08/06/2020 09:44, Marco Pivetta wrote: > > > I was mostly conflicted around the

Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-08 Thread Benas IML
Hey, I'm not sure what you're referring to as "generic variable system" but given that you mentioned "type", I assume you mean typed variables? If so, PHP is never going to have typed variables due to performance implications. As for the `/**` and `*/`, I believe Marco was talking about Doctrine

Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-08 Thread Larry Garfield
On Mon, Jun 8, 2020, at 11:47 AM, Lester Caine wrote: > On 08/06/2020 16:30, Benjamin Eberlei wrote: > > > > > > On Mon, Jun 8, 2020 at 11:11 AM Lester Caine > > wrote: > > > > On 08/06/2020 09:44, Marco Pivetta wrote: > > > I was mostly conflicted around the

Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-08 Thread Lester Caine
On 08/06/2020 16:30, Benjamin Eberlei wrote: On Mon, Jun 8, 2020 at 11:11 AM Lester Caine > wrote: On 08/06/2020 09:44, Marco Pivetta wrote: > I was mostly conflicted around the "allow grouped attributes" bit, but > James Titcumb (who currently

Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-08 Thread Benjamin Eberlei
On Mon, Jun 8, 2020 at 11:11 AM Lester Caine wrote: > On 08/06/2020 09:44, Marco Pivetta wrote: > > I was mostly conflicted around the "allow grouped attributes" bit, but > > James Titcumb (who currently cannot write to this list due to bounced > > emails) convinced me that it is a good

Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-08 Thread Dan Ackroyd
On Mon, 8 Jun 2020 at 09:13, Benjamin Eberlei wrote: > > I have opened voting for four different amendments to the Attributes RFC > > https://wiki.php.net/rfc/attribute_amendments To explain a 'no' vote. > Should a secondary grouped syntax for attributes be introduced? Voted no, as it's not

Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-08 Thread Lester Caine
On 08/06/2020 09:44, Marco Pivetta wrote: I was mostly conflicted around the "allow grouped attributes" bit, but James Titcumb (who currently cannot write to this list due to bounced emails) convinced me that it is a good replacement for `/**` and `*/`: If twenty years of documentation

Re: [PHP-DEV] [VOTE] Attribute Amendments

2020-06-08 Thread Marco Pivetta
Hey Benjamin, On Mon, Jun 8, 2020 at 10:13 AM Benjamin Eberlei wrote: > Hello internals, > > I have opened voting for four different amendments to the Attributes RFC > > https://wiki.php.net/rfc/attribute_amendments > > The voting period ends at 2020-06-22 8:00 UTC. > > greetings > Benjamin >

[PHP-DEV] [VOTE] Attribute Amendments

2020-06-08 Thread Benjamin Eberlei
Hello internals, I have opened voting for four different amendments to the Attributes RFC https://wiki.php.net/rfc/attribute_amendments The voting period ends at 2020-06-22 8:00 UTC. greetings Benjamin