Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-18 Thread Dmitry Stogov
On Sat, Sep 16, 2023 at 12:46 PM Hans Henrik Bergan wrote: > I think the submodule approach is fine, but maybe it should be moved from > Dmitry's gh to php-src gh, or maybe it's own dedicated group, to reduce the > bus factor (how much work needs to be done if Dmitry is hit by a bus~) > ``git

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-18 Thread Dmitry Stogov
On Sat, Sep 16, 2023 at 1:22 AM Tim Düsterhus wrote: > Hi > > On 9/15/23 17:50, Ben Ramsey wrote: > > Additionally, despite the use of a Git submodule complicating things for > > "everyone else," it provides a clear dependency and development > > boundary, avoiding situations where the php-src

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-18 Thread Dmitry Stogov
On Mon, Sep 18, 2023 at 8:01 AM Pierre Joye wrote: > Great work! This is a massive jump for PHP. Thank you :) > > I don't have much concerns about the license etc as the ZE is already > under Zend the ZE license (never updated since Perforce acquired them, > tho'): > >

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-18 Thread Dmitry Stogov
Hi Ben, On Fri, Sep 15, 2023 at 6:50 PM Ben Ramsey wrote: > On 9/15/23 09:35, Derick Rethans wrote: > > > I understand that working on an RFC for such a complex issue is going to > > take time, but that also gives to opportunity to pair with somebody, > > who, while writing it, will also learn

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-18 Thread Dmitry Stogov
Hi Derick, On Fri, Sep 15, 2023 at 5:35 PM Derick Rethans wrote: > I think this is great work. It looks like the new JIT-IR approach is > more suitable. I have however concerns with a few things here. > > This is a lot of new code, that very few other people understand in > great detail. > > I

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-17 Thread Dmitry Stogov
On Fri, Sep 15, 2023 at 4:03 PM Juliette Reinders Folmer < php-internals_nos...@adviesenzo.nl> wrote: > If merged to `master`, will that automatically mean that the next > version of PHP will be PHP 9.0 ? > > If so, would that warrant a separate discussion ? (whether there should > still be a

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-17 Thread Pierre Joye
Hello :) Posting again, I just realized I used "reply" not "reply all" On Mon, Sep 11, 2023 at 4:29 PM Dmitry Stogov wrote: > > Hi internals, > > I'm glad to present a new JIT engine that is going to be used in the next > major PHP version. Now it's a real optimizing compiler with Intermediate

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-16 Thread Hans Henrik Bergan
I think the submodule approach is fine, but maybe it should be moved from Dmitry's gh to php-src gh, or maybe it's own dedicated group, to reduce the bus factor (how much work needs to be done if Dmitry is hit by a bus~) On Sat, Sep 16, 2023, 00:22 Tim Düsterhus wrote: > Hi > > On 9/15/23

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-15 Thread Tim Düsterhus
Hi On 9/15/23 17:50, Ben Ramsey wrote: Additionally, despite the use of a Git submodule complicating things for "everyone else," it provides a clear dependency and development boundary, avoiding situations where the php-src version of IR drifts from the upstream version. I think we can adjust

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-15 Thread Ben Ramsey
On 9/15/23 09:35, Derick Rethans wrote: This is a lot of new code, that very few other people understand in great detail. I think it is unwise if we have another large part of the engine that does not have enough people understanding enough of it, to be able to debug issues, and contribute to

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-15 Thread Derick Rethans
Hi Dmitry, On Fri, 15 Sep 2023, Dmitry Stogov wrote: > After the code-review feedback, one of the most questionable decisions > was changed. > > Instead of including IR Framework as a git submodule, now its part is > embedded into php-src. > > This will complicate the IR/JIT development a bit,

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-15 Thread Juliette Reinders Folmer
On 15-9-2023 12:15, Dmitry Stogov wrote: Hi, After the code-review feedback, one of the most questionable decisions was changed. Instead of including IR Framework as a git submodule, now its part is embedded into php-src. This will complicate the IR/JIT development a bit, but will simplify

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-15 Thread Dmitry Stogov
Hi, After the code-review feedback, one of the most questionable decisions was changed. Instead of including IR Framework as a git submodule, now its part is embedded into php-src. This will complicate the IR/JIT development a bit, but will simplify things for everyone else. I'm going to merge

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-12 Thread Björn Larsson via internals
Den 2023-09-11 kl. 11:28, skrev Dmitry Stogov: Hi internals, I'm glad to present a new JIT engine that is going to be used in the next major PHP version. Now it's a real optimizing compiler with Intermediate Representation similar to Java HotSpot server compiler. It makes a base for future

[PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-11 Thread Dmitry Stogov
Hi internals, I'm glad to present a new JIT engine that is going to be used in the next major PHP version. Now it's a real optimizing compiler with Intermediate Representation similar to Java HotSpot server compiler. It makes a base for future improvements and eliminates many low-level details