Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3

2008-05-21 Thread Antony Dovgal
On 20.05.2008 22:22, Kalle Sommer Nielsen wrote: Greetings internals I've made two functions that allows convertion between degress and gradians, below is a pastebin of the functions as that would look in math.c: http://www.phpfi.com/318450 Functions that can be implemented in one line of

[PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3

2008-05-20 Thread Kalle Sommer Nielsen
Greetings internals I've made two functions that allows convertion between degress and gradians, below is a pastebin of the functions as that would look in math.c: http://www.phpfi.com/318450 If no objections against it I will commit them in PHP_5_3 and HEAD and I will prepare some test

Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3

2008-05-20 Thread Guilherme Blanco
Hi... Are there any explanation why you used 360 and 400 and not optimized it? I know 1 full circle = 360 deg = 400 grads, but you can simplify it to: RETURN_DOUBLE((9 / 10) * deg); and... RETURN_DOUBLE((10 / 9) * grads); Regards, On Tue, May 20, 2008 at 3:22 PM, Kalle Sommer Nielsen [EMAIL

Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3

2008-05-20 Thread Kalle Sommer Nielsen
Subject: Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3 Hi... Are there any explanation why you used 360 and 400 and not optimized it? I know 1 full circle = 360 deg = 400 grads, but you can simplify it to: RETURN_DOUBLE((9 / 10) * deg); and... RETURN_DOUBLE((10 / 9) * grads); Regards

Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3

2008-05-20 Thread Christopher Jones
[EMAIL PROTECTED] Cc: PHP Developers Mailing List internals@lists.php.net Sent: Tuesday, May 20, 2008 8:47 PM Subject: Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3 Hi... Are there any explanation why you used 360 and 400 and not optimized it? I know 1 full circle = 360 deg = 400

Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3

2008-05-20 Thread Kalle Sommer Nielsen
PROTECTED]; PHP Developers Mailing List internals@lists.php.net Sent: Wednesday, May 21, 2008 3:24 AM Subject: Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3 Even for small projects like this, we should get into the habit of creating an RFC on the Wiki. This is a way to explain the pros

Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3

2008-05-20 Thread Rasmus Lerdorf
Subject: Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3 Even for small projects like this, we should get into the habit of creating an RFC on the Wiki. This is a way to explain the pros cons so the functionality can be evaluated. You can argue about the algorithm choice and point out