[PHP-DEV] Merge #62852 and #53437 into 5.3 and 5.4

2013-03-18 Thread Anatol Belski
Hi, #62852 and #53437 introduced fixes for the date extension crashing when unserializing objects. They was applied to 5.5. If there are no objections, I would backport those to 5.3 and 5.4. Regards Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] Merge #62852 and #53437 into 5.3 and 5.4

2013-03-18 Thread Johannes Schlüter
Hi, commit f8b91d9ac (fix for #62852) looks fine to me. Commit 0ee71 for #53437 is a bit too much for 5.3 in my opinion - what happens if users have custom work-arounds in extended classes with custom __wakeup or __set_State methods? Will there be a change of behavihor? I think there should

Re: [PHP-DEV] Merge #62852 and #53437 into 5.3 and 5.4

2013-03-18 Thread Anatol Belski
Johannes, I completely agree about the E_ERROR - in general. An error should be recoverable as much as possible. In this concrete case as I've reworking a patch descending from 2010 and that E_ERROR was there, I just let it go. The situation is that doing an E_WARNING possibly leaves user with