Re: [PHP-DEV] Re: [RFC] Amendments to Attributes

2020-06-05 Thread Benjamin Eberlei
On Fri, Jun 5, 2020 at 5:58 AM guilhermebla...@gmail.com < guilhermebla...@gmail.com> wrote: > Hi Benjamin, > > Overall, all these amendments are good in my opinion, but I'd like to > challenge a few things: > > 1- On item 3, the acceptable targets would be: class, function, > method, property,

Re: [PHP-DEV] Re: [RFC] Amendments to Attributes

2020-06-04 Thread guilhermebla...@gmail.com
Hi Benjamin, Overall, all these amendments are good in my opinion, but I'd like to challenge a few things: 1- On item 3, the acceptable targets would be: class, function, method, property, class constant, parameter or all. If possible, I'd like to ask if it's possible to expand this list and

Re: [PHP-DEV] Re: [RFC] Amendments to Attributes

2020-06-04 Thread Benjamin Eberlei
On Thu, Jun 4, 2020 at 12:54 PM Benas IML wrote: > Thank you for the update! Given that there is still an open issue, is the > RFC proposing flags or a separate `<>` attribute? > Good point, we came to the conclusion to simplify. Should attributes be in the global namespace, then we shouldn't

Re: [PHP-DEV] Re: [RFC] Amendments to Attributes

2020-06-04 Thread Benas IML
Thank you for the update! Given that there is still an open issue, is the RFC proposing flags or a separate `<>` attribute? Best regards, Benas On Thu, Jun 4, 2020, 12:29 PM Benjamin Eberlei wrote: > I have changed back the rename from namespacing to Attributes\Attribute to > using just

[PHP-DEV] Re: [RFC] Amendments to Attributes

2020-06-04 Thread Benjamin Eberlei
I have changed back the rename from namespacing to Attributes\Attribute to using just Attribute after a few discussions off list. The reasoning is that it becomes more clear that a majority of core contributors strongly prefers using the global namespace as the PHP namespace and opening up this