Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-08-20 Thread Fleshgrinder
On 8/20/2017 1:56 PM, Dan Ackroyd wrote: > On 20 August 2017 at 11:45, Fleshgrinder wrote: >> On 5/24/2017 2:28 AM, Fleshgrinder wrote: >> >> I would like to start the voting phase the next days, but leave a little >> time for further feedback before doing so. > > >

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-08-20 Thread Dan Ackroyd
On 20 August 2017 at 11:45, Fleshgrinder wrote: > On 5/24/2017 2:28 AM, Fleshgrinder wrote: > > I would like to start the voting phase the next days, but leave a little > time for further feedback before doing so. Perhaps it was clear in your head, but in the context of

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-08-20 Thread Fleshgrinder
On 5/24/2017 2:28 AM, Fleshgrinder wrote: > Hey internals! > > I haven't written the RFC yet, but the implementation is already done. I > think that this is enough to start the discussion, since the concept of > UUIDs should be well known to most people. > >

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-26 Thread Marco Pivetta
On 26 May 2017 10:30 a.m., "Nikita Popov" wrote: On Thu, May 25, 2017 at 5:48 PM, Marco Pivetta wrote: > Hey Nikita, > > On Thu, May 25, 2017 at 12:14 PM, Nikita Popov > wrote: > >> On Thu, May 25, 2017 at 12:05 PM, Fleshgrinder

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-26 Thread Fleshgrinder
On 5/26/2017 11:00 AM, Nikita Popov wrote: > To clarify, I certainly do *not* want the behavior that was implemented > here. The correct way (in your specific case) to handle this if by using > > if (zend_parse_parameters_throw(ZEND_NUM_ARGS(), "") == FAILURE) { > return; > } > > or adding a

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-26 Thread Fleshgrinder
On 5/26/2017 10:30 AM, Nikita Popov wrote: > Especially if it would allow us to replace a 4kloc diff with one 10loc > function. > > Nikita > I could remove the provided C API for other modules. Would make the header file empty and the implementation much shorter. Or at least remove those that

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-26 Thread Nikita Popov
On Fri, May 26, 2017 at 10:34 AM, Fleshgrinder wrote: > On 5/26/2017 1:08 AM, Marco Pivetta wrote: > > Saw the discussion on github, and I wish that the argument parsing just > > behaved like a *NORMAL* PHP method. > > > > The following is perfectly valid: > > > >

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-26 Thread Fleshgrinder
On 5/26/2017 1:08 AM, Marco Pivetta wrote: > Saw the discussion on github, and I wish that the argument parsing just > behaved like a *NORMAL* PHP method. > > The following is perfectly valid: > > $crapTonOfUuids = array_map([UUID::class, 'v4'], range(0, 1000)); > > This would raise a lot of

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-26 Thread Nikita Popov
On Thu, May 25, 2017 at 5:48 PM, Marco Pivetta wrote: > Hey Nikita, > > On Thu, May 25, 2017 at 12:14 PM, Nikita Popov > wrote: > >> On Thu, May 25, 2017 at 12:05 PM, Fleshgrinder >> wrote: >> >>> On 5/24/2017 10:12 PM, Ben

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Marco Pivetta
On Thu, May 25, 2017 at 6:41 PM, Fleshgrinder wrote: > On 5/25/2017 4:45 PM, Fleshgrinder wrote: > > RFC is finished > > > > https://wiki.php.net/rfc/uuid > > > > Would it be possible that we discuss the open issues, instead of trying > to get rid of the proposal

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread li...@rhsoft.net
Am 25.05.2017 um 19:50 schrieb Levi Morrison: https://wiki.php.net/rfc/uuid#namespace This is more a general thing. I know from many online conversations, meetups, and conferences that people would love to see it. My $0.02 is basically what Nikita Popov has said at some point in the past:

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Fleshgrinder
On 5/25/2017 7:50 PM, Levi Morrison wrote: >> https://wiki.php.net/rfc/uuid#namespace >> >> This is more a general thing. I know from many online conversations, >> meetups, and conferences that people would love to see it. > > My $0.02 is basically what Nikita Popov has said at some point in the

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Levi Morrison
> https://wiki.php.net/rfc/uuid#namespace > > This is more a general thing. I know from many online conversations, > meetups, and conferences that people would love to see it. My $0.02 is basically what Nikita Popov has said at some point in the past: The PHP namespace should be reserved for

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Fleshgrinder
On 5/25/2017 4:45 PM, Fleshgrinder wrote: > RFC is finished > > https://wiki.php.net/rfc/uuid > Would it be possible that we discuss the open issues, instead of trying to get rid of the proposal completely? I will not back up anyways after investing so much time. ;)

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Marco Pivetta
Hey Nikita, On Thu, May 25, 2017 at 12:14 PM, Nikita Popov wrote: > On Thu, May 25, 2017 at 12:05 PM, Fleshgrinder > wrote: > >> On 5/24/2017 10:12 PM, Ben Ramsey wrote: >> > I'll take a look at the patch soon. If this is accepted to the core, >> >

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Fleshgrinder
RFC is finished https://wiki.php.net/rfc/uuid -- Richard "Fleshgrinder" Fussenegger signature.asc Description: OpenPGP digital signature

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Fleshgrinder
On 5/25/2017 12:34 PM, Michał Brzuchalski wrote: > 2017-05-25 12:14 GMT+02:00 Nikita Popov : >> I'm wondering if just adding a uuid_v4_create() function (directly >> returning a UUID string) might not cover the 95% use case here. My general >> impression is that that's what

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Fleshgrinder
On 5/25/2017 1:01 AM, Sara Golemon wrote: > On Wed, May 24, 2017 at 11:04 AM, Larry Garfield > wrote: >> It doesn't have to be a PECL library. I agree that a project requiring a >> PECL library greatly limits its potential reach, but with Composer >> user-space libraries

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Michał Brzuchalski
2017-05-25 12:14 GMT+02:00 Nikita Popov : > On Thu, May 25, 2017 at 12:05 PM, Fleshgrinder > wrote: > > > On 5/24/2017 10:12 PM, Ben Ramsey wrote: > > > I'll take a look at the patch soon. If this is accepted to the core, > > > I'll probably add an

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Nikita Popov
On Thu, May 25, 2017 at 12:05 PM, Fleshgrinder wrote: > On 5/24/2017 10:12 PM, Ben Ramsey wrote: > > I'll take a look at the patch soon. If this is accepted to the core, > > I'll probably add an adapter to ramsey/uuid that wraps this > > implementation. The point of the

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-25 Thread Fleshgrinder
On 5/24/2017 10:12 PM, Ben Ramsey wrote: > I'll take a look at the patch soon. If this is accepted to the core, > I'll probably add an adapter to ramsey/uuid that wraps this > implementation. The point of the "over engineering" there is to provide > choice. Some users want to generate bytes from

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Sara Golemon
On Wed, May 24, 2017 at 11:04 AM, Larry Garfield wrote: > It doesn't have to be a PECL library. I agree that a project requiring a > PECL library greatly limits its potential reach, but with Composer > user-space libraries are totally easy to install. There's a nice and

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Ben Ramsey
On Wed, May 24, 2017 at 2:47 PM, Marco Pivetta wrote: > > On Wed, May 24, 2017 at 8:39 PM, Fleshgrinder wrote: > > > > Furthermore, I carefully crafted everything to be as close to userland > > as possible. No magic, none at all. I use default PHP

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Marco Pivetta
On Wed, May 24, 2017 at 8:39 PM, Fleshgrinder wrote: > On 5/24/2017 8:09 PM, Marco Pivetta wrote: > > For once, I must say that I disagree with having an OOP API defined in > core. > > This can exist in userland, so it probably should. Internal classes, > their > >

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Fleshgrinder
On 5/24/2017 8:09 PM, Marco Pivetta wrote: > For once, I must say that I disagree with having an OOP API defined in core. > This can exist in userland, so it probably should. Internal classes, their > reflection, behavior, inheritance model, etc are full of quirks. > There's nothing wrong in

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Jan Ehrhardt
"Christoph M. Becker" in php.internals (Wed, 24 May 2017 18:35:08 +0200): >On 24.05.2017 at 18:25, Remi Collet wrote: > >> And I also think using system libuuid is better than reinventing the >> wheel, and having to maintain a uuid algo, when already maintained by >> someone else, which only work

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Marco Pivetta
On Wed, May 24, 2017 at 8:01 PM, Fleshgrinder wrote: > On 5/24/2017 5:11 PM, Levi Morrison wrote: > > On Wed, May 24, 2017 at 9:04 AM, Larry Garfield > > wrote: > > > >> It doesn't have to be a PECL library. I agree that a project requiring > a >

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Fleshgrinder
On 5/24/2017 5:11 PM, Levi Morrison wrote: > On Wed, May 24, 2017 at 9:04 AM, Larry Garfield > wrote: > >> It doesn't have to be a PECL library. I agree that a project requiring a >> PECL library greatly limits its potential reach, but with Composer >> user-space

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread li...@rhsoft.net
Am 24.05.2017 um 18:35 schrieb Christoph M. Becker: On 24.05.2017 at 18:25, Remi Collet wrote: Le 24/05/2017 à 17:57, Levi Morrison a écrit : I understand the user experience improvement for having a package for UUIDs in core; I'd like that myself. I just want to know why we haven't

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread li...@rhsoft.net
Am 24.05.2017 um 18:30 schrieb Remi Collet: Le 24/05/2017 à 17:21, li...@rhsoft.net a écrit : frankly get out of my sight with composer i maintain the whole webstacke for many years at my own (rpm packages) and so the Fedora repos have excluded anything relevant to PHP - trying to build

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Christoph M. Becker
On 24.05.2017 at 18:25, Remi Collet wrote: > Le 24/05/2017 à 17:57, Levi Morrison a écrit : > >> I understand the user experience improvement for having a package for UUIDs >> in core; I'd like that myself. I just want to know why we haven't discussed >> the existing UUID package and made a new

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Remi Collet
Le 24/05/2017 à 17:21, li...@rhsoft.net a écrit : > frankly get out of my sight with composer > > i maintain the whole webstacke for many years at my own (rpm packages) > and so the Fedora repos have excluded anything relevant to PHP - trying > to build composer by just download the src.rpm ends

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Remi Collet
Le 24/05/2017 à 17:57, Levi Morrison a écrit : > I understand the user experience improvement for having a package for UUIDs > in core; I'd like that myself. I just want to know why we haven't discussed > the existing UUID package and made a new one. I agree here, why a new extension ? And I

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Levi Morrison
On Wed, May 24, 2017 at 9:29 AM, li...@rhsoft.net wrote: > > > Am 24.05.2017 um 17:11 schrieb Levi Morrison: > >> On Wed, May 24, 2017 at 9:04 AM, Larry Garfield >> wrote: >> >> On 05/24/2017 04:31 AM, li...@rhsoft.net wrote: >>> Am 24.05.2017

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread li...@rhsoft.net
Am 24.05.2017 um 17:11 schrieb Levi Morrison: On Wed, May 24, 2017 at 9:04 AM, Larry Garfield wrote: On 05/24/2017 04:31 AM, li...@rhsoft.net wrote: Am 24.05.2017 um 11:27 schrieb Dan Ackroyd: Hey internals! I haven't written the RFC yet, Please don't forget

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread li...@rhsoft.net
Am 24.05.2017 um 17:04 schrieb Larry Garfield: On 05/24/2017 04:31 AM, li...@rhsoft.net wrote: Am 24.05.2017 um 11:27 schrieb Dan Ackroyd: Hey internals! I haven't written the RFC yet, Please don't forget to include in the RFC a justification for why this should be part of PHP core,

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Levi Morrison
On Wed, May 24, 2017 at 9:04 AM, Larry Garfield wrote: > On 05/24/2017 04:31 AM, li...@rhsoft.net wrote: > >> >> >> Am 24.05.2017 um 11:27 schrieb Dan Ackroyd: >> >>> Hey internals! I haven't written the RFC yet, >>> >>> Please don't forget to include in

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Larry Garfield
On 05/24/2017 04:31 AM, li...@rhsoft.net wrote: Am 24.05.2017 um 11:27 schrieb Dan Ackroyd: Hey internals! I haven't written the RFC yet, Please don't forget to include in the RFC a justification for why this should be part of PHP core, rather than a library because as developer in

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread li...@rhsoft.net
Am 24.05.2017 um 11:27 schrieb Dan Ackroyd: Hey internals! I haven't written the RFC yet, Please don't forget to include in the RFC a justification for why this should be part of PHP core, rather than a library because as developer in reality you can not use and rely on features which

Re: [PHP-DEV] [RFC] [Discussion] UUID

2017-05-24 Thread Dan Ackroyd
> Hey internals! > > I haven't written the RFC yet, Please don't forget to include in the RFC a justification for why this should be part of PHP core, rather than a library. cheers Dan -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php