Hi
On 7/10/24 15:47, Larry Garfield wrote:
The other half of this RFC, removing the recursion guard in return for
performance, has had no objections. Its discussion period ends Friday, so I
will open the vote on that Monday-ish.
Thank you, looks good to me, ship it.
One minor remark about
On Mon, Jul 1, 2024, at 12:02 PM, Larry Garfield wrote:
> Hi folks. As Ilija's been polishing off hooks to get the PR merged,
> we've run into two small revisions that should make life better for all
> involved. One is a performance improvement that requires a very slight
> error handling beha
Hi Derick
On Wed, Jul 10, 2024 at 11:32 AM Derick Rethans wrote:
>
> On Mon, 1 Jul 2024, Larry Garfield wrote:
>
> >
> > https://wiki.php.net/rfc/hook_improvements
>
> 1. Remove the proactive guard against recursive backing value access
>
> "which would eventually trigger a stack overflow
On Mon, 1 Jul 2024, Larry Garfield wrote:
> Hi folks. As Ilija's been polishing off hooks to get the PR merged,
> we've run into two small revisions that should make life better for
> all involved. One is a performance improvement that requires a very
> slight error handling behavior change,
On Wed, 3 Jul 2024, Claude Pache wrote:
> > Le 1 juil. 2024 à 19:02, Larry Garfield a
> > écrit :
> >
> > Hi folks. As Ilija's been polishing off hooks to get the PR merged,
> > we've run into two small revisions that should make life better for
> > all involved. One is a performance improv
Hi
On 7/1/24 22:57, Larry Garfield wrote:
Are there specific concerns you have about implications, or just a general "dude,
it's July" sense?
From my side primarily "dude, it's July", because I do not want to
think this through right now. Claude did the thinking, though and I
agree with th
On Wed, Jul 3, 2024, at 16:22, Rob Landers wrote:
>
>
> On Wed, Jul 3, 2024, at 15:29, Claude Pache wrote:
>>
>>
>>> Le 3 juil. 2024 à 14:42, Rob Landers a écrit :
>>>
>>> On Wed, Jul 3, 2024, at 14:28, Claude Pache wrote:
> Le 3 juil. 2024 à 11:54, Claude Pache a écrit :
>
On Wed, Jul 3, 2024, at 15:29, Claude Pache wrote:
>
>
>> Le 3 juil. 2024 à 14:42, Rob Landers a écrit :
>>
>> On Wed, Jul 3, 2024, at 14:28, Claude Pache wrote:
>>>
>>>
Le 3 juil. 2024 à 11:54, Claude Pache a écrit :
2. As for readonly, I think that the invariant it
> Le 3 juil. 2024 à 14:42, Rob Landers a écrit :
>
> On Wed, Jul 3, 2024, at 14:28, Claude Pache wrote:
>>
>>
>>> Le 3 juil. 2024 à 11:54, Claude Pache a écrit :
>>>
>>>
>>> 2. As for readonly, I think that the invariant it is supposed to provide
>>> should be enforced as strictly as poss
On Wed, Jul 3, 2024, at 14:28, Claude Pache wrote:
>
>
>> Le 3 juil. 2024 à 11:54, Claude Pache a écrit :
>>
>>
>> 2. As for readonly, I think that the invariant it is supposed to provide
>> should be enforced as strictly as possible. It means that `readonly` is only
>> acceptable if there i
> Le 3 juil. 2024 à 11:54, Claude Pache a écrit :
>
>
> 2. As for readonly, I think that the invariant it is supposed to provide
> should be enforced as strictly as possible. It means that `readonly` is only
> acceptable if there is no `get` hook.
Hi,
One more thing, why I think that we sh
> Le 1 juil. 2024 à 19:02, Larry Garfield a écrit :
>
> Hi folks. As Ilija's been polishing off hooks to get the PR merged, we've
> run into two small revisions that should make life better for all involved.
> One is a performance improvement that requires a very slight error handling
> be
On Mon, Jul 1, 2024, at 8:32 PM, Tim Düsterhus wrote:
> Hi
>
> On 7/1/24 19:02, Larry Garfield wrote:
>> I'd say we expect these to be uncontroversial, but this is PHP. :-) So I
>> will instead just note that it's a short RFC and open the discussion
>> accordingly.
>
> Big fan of the performance
Hi
On 7/1/24 19:02, Larry Garfield wrote:
I'd say we expect these to be uncontroversial, but this is PHP. :-) So I will
instead just note that it's a short RFC and open the discussion accordingly.
Big fan of the performance improvement, given that I convinced Ilija to
look into that once mo
On Mon, Jul 1, 2024, at 5:28 PM, Lynn wrote:
> "A side effect of that optimization, however, is that we cannot
> proactively detect the bug above. Instead, it would result in an
> infinite loop, which would eventually trigger a a stack overflow."
>
> This got a small typo ("a a" at the end).
F
On Mon, Jul 1, 2024 at 7:05 PM Larry Garfield
wrote:
> Hi folks. As Ilija's been polishing off hooks to get the PR merged, we've
> run into two small revisions that should make life better for all
> involved. One is a performance improvement that requires a very slight
> error handling behavior
16 matches
Mail list logo
